On 27/5/23 19:14, Anton Khirnov wrote:
Hi Zane,
Quoting Zane van Iperen (2020-05-09 16:00:04)
diff --git a/tests/ref/fate/adpcm-ima-cunning-trunc-t2-track1
b/tests/ref/fate/adpcm-ima-cunning-trunc-t2-track1
new file mode 100644
index 00..df9edc403d
--- /dev/null
+++ b/tests/ref/fate
lgtm, will apply in a few days if no objections
On 29/10/22 00:55, Pierre-Anthony Lemieux wrote:
Hi Zane et al.,
Quick ping on the revised patchset below.
It addresses https://trac.ffmpeg.org/ticket/9842.
Best,
-- Pierre
On Sun, Oct 2, 2022 at 9:28 AM wrote:
From: Pierre-Anthony Lemieux
Looks mostly ok from a cursory glance, just one minor nit.
On 23/8/22 15:10, p...@sandflow.com wrote:
+static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value)
+{
+xmlChar *element_text = NULL;
+int ret = 0;
+
+element_text = xmlNodeListGetString(element->doc,
element->xm
lgtm, will apply
On 20/9/22 01:26, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
---
libavformat/imfdec.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index 5bbe7a53f8..9ba8b6de8b 100644
--- a/libavf
On 21/7/22 08:00, Andreas Rheinhardt wrote:
+if (av_dict_set_int(&st->metadata, "loop", ctx->header.loop, 0) < 0)
+return AVERROR(ENOMEM);
+
+if (av_dict_set_int(&st->metadata, "reverb", ctx->header.reverb, 0) < 0)
+return AVERROR(ENOMEM);
+
+if (av_dict_set_int(&s
Signed-off-by: Zane van Iperen
---
libavformat/argo_cvg.c | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
index be78091f0c..32247a06be 100644
--- a/libavformat/argo_cvg.c
+++ b/libavformat
Signed-off-by: Zane van Iperen
---
libavformat/argo_cvg.c | 4
1 file changed, 4 deletions(-)
diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
index 32247a06be..12465dcbcc 100644
--- a/libavformat/argo_cvg.c
+++ b/libavformat/argo_cvg.c
@@ -159,13 +159,9 @@ static int
Signed-off-by: Zane van Iperen
---
libavformat/argo_cvg.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
index 12465dcbcc..3d4abb4758 100644
--- a/libavformat/argo_cvg.c
+++ b/libavformat/argo_cvg.c
@@ -162,6 +162,15 @@ static int
Signed-off-by: Zane van Iperen
---
libavformat/argo_cvg.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
index f32487023a..be78091f0c 100644
--- a/libavformat/argo_cvg.c
+++ b/libavformat
On 18/7/2022 11:45 pm, Andreas Rheinhardt wrote:
av_log(s, AV_LOG_TRACE, "size = %u\n", ctx->header.size);
-av_log(s, AV_LOG_TRACE, "unk= %u, %u\n", ctx->header.unk1,
ctx->header.unk2);
+av_log(s, AV_LOG_TRACE, "loop = %u\n", ctx->header.loop);
+av_log(s
Signed-off-by: Zane van Iperen
---
libavformat/argo_cvg.c | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
index 2ee4a64449..36026e562e 100644
--- a/libavformat/argo_cvg.c
+++ b/libavformat
Signed-off-by: Zane van Iperen
---
libavformat/argo_cvg.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
index f32487023a..2ee4a64449 100644
--- a/libavformat/argo_cvg.c
+++ b/libavformat
Signed-off-by: Zane van Iperen
---
doc/APIchanges | 10 ++
1 file changed, 10 insertions(+)
diff --git a/doc/APIchanges b/doc/APIchanges
index 4f7a19d176..3349e94a4f 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -18,6 +18,16 @@ API changes, most recent first:
Add avio_vprintf
Forgot to bump after the uuid patches.
Signed-off-by: Zane van Iperen
---
libavutil/version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/version.h b/libavutil/version.h
index 2c7f4f6b37..2e9e02dda8 100644
--- a/libavutil/version.h
+++ b/libavutil/version.h
On 2/6/22 10:30, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Ping, this patchset mostly looks good. Will apply in a few days.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To uns
On 11/5/22 21:53, Anton Khirnov wrote:
Quoting Zane van Iperen (2022-04-24 12:14:03)
+void av_uuid_nil_set(AVUUID uu)
^^^
sounds weird
av_uuid_zero()?
av_uuid_reset()?
Good point, `av_uuid_zero()` has a nice ring to it
On 10/5/22 23:18, Andreas Rheinhardt wrote:
+int av_uuid_parse_range(const char *in_start, const char *in_end, AVUUID uu)
+{
+int i;
+const char *cp;
+char buf[3];
+
+if ((in_end - in_start) != 36)
+return -1;
+
+for (i = 0, cp = in_start; i < 36; i++, cp++) {
+
On 2/5/22 07:06, Mark Thompson wrote:
Maybe additional options exist.
I do not have a definitive opinion. Some folks expressed strong
interest in having a consistent scheme for manipulating UUIDs.
I think for now the simplest option is just not to change the CBS header, which
is completel
From: Pierre-Anthony Lemieux
---
libavcodec/cbs_sei.h | 3 ++-
libavcodec/vaapi_encode_h264.c | 8
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavcodec/cbs_sei.h b/libavcodec/cbs_sei.h
index c7a7a95be0..67c6e6cbbd 100644
--- a/libavcodec/cbs_sei.h
+++ b/li
Co-authored-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavutil/Makefile | 2 +
libavutil/uuid.c | 155 +
libavutil/uuid.h | 137 +++
3 files changed, 294 insertions(+)
create mode 100644
From: Pierre-Anthony Lemieux
---
libavfilter/vf_showinfo.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 12d39310ef..0d6f2805bb 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinf
From: Pierre-Anthony Lemieux
---
libavformat/mov.c| 25 +
libavformat/movenc.c | 9 +
2 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 3e83e54a77..cb6b49d98e 100644
--- a/libavformat/mov.c
+++ b/liba
From: Pierre-Anthony Lemieux
---
libavformat/smoothstreamingenc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c
index c67f0cba43..3d857b932e 100644
--- a/libavformat/smoothstreamingenc.c
+++ b/libavf
+/uuid
/xtea
diff --git a/libavutil/tests/uuid.c b/libavutil/tests/uuid.c
new file mode 100644
index 00..0a7a0eb07d
--- /dev/null
+++ b/libavutil/tests/uuid.c
@@ -0,0 +1,139 @@
+/*
+ * Copyright (c) 2022 Pierre-Anthony Lemieux
+ *Zane van Iperen
+ *
+ * This file is part
From: Pierre-Anthony Lemieux
---
libavformat/imf.h | 18 -
libavformat/imf_cpl.c | 60 +++--
libavformat/imfdec.c| 34 +++
libavformat/tests/imf.c | 18 ++---
4 files changed, 52 insertions(+), 78 deletions(-
/smoothstreamingenc: refactor to use avutil/uuid
avcodec/cbs_sei: refactor to use avutil/uuid
avformat/imf: refactor to use avutil/uuid
avfilter/showinfo: refactor to use avutil/uuid
Zane van Iperen (1):
avutil/uuid: add utility library for manipulating UUIDs as specified
in RFC 4122
lgtm. Will apply in a few days.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On 23/2/22 19:54, Lynne wrote:
23 Feb 2022, 07:48 by z...@zanevaniperen.com:
Why the double header in the header file? It doesn't contain
any libuuid code.
It does, this was copy/pasted from libuuid, then had things stripped from it.
Some examples:
-
https://github.com/util-linux/util-l
On 23/2/22 16:48, Zane van Iperen wrote:
On 23/2/22 16:01, Lynne wrote:
Code style
Mostly fixed, do these changes look right?
https://github.com/vs49688/FFmpeg/commit/867fffe04ffedf0609260557d1db0ebbc519c4d2
Uhh, wrong one:
https://github.com/vs49688/FFmpeg/commit
On 23/2/22 00:21, James Almer wrote:
+int av_uuid_equal(const AVUUID uu1, const AVUUID uu2)
+{
+ return memcmp(uu1, uu2, AV_UUID_LEN) == 0;
+}
+
+void av_uuid_copy(AVUUID dest, const AVUUID src)
+{
+ memcpy(dest, src, AV_UUID_LEN);
+}
+
+void av_uuid_nil_set(AVUUID uu)
+{
+ memset(uu,
On 23/2/22 16:01, Lynne wrote:
Code style
Mostly fixed, do these changes look right?
https://github.com/vs49688/FFmpeg/commit/867fffe04ffedf0609260557d1db0ebbc519c4d2
Why the double header in the header file? It doesn't contain
any libuuid code.
It does, this was copy/pasted from libu
On 22/2/22 23:01, Zane van Iperen wrote:
+int av_uuid_urn_parse(const char *in, AVUUID uu)
+{
+return av_uuid_parse(in + 9, uu);
Self-review: this should check if "strlen(in) == 45", then simply
return av_uuid_parse_range(in + 9).
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavfilter/vf_showinfo.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 71728bced4
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavformat/imf.h | 18 -
libavformat/imf_cpl.c | 60 +++--
libavformat/imfdec.c| 34 +++
libavformat/tests
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavcodec/cbs_sei.h | 3 ++-
libavcodec/vaapi_encode_h264.c | 8
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavcodec/cbs_sei.h b/libavcodec/cbs_sei.h
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavformat/smoothstreamingenc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c
index
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavformat/mov.c| 25 +
libavformat/movenc.c | 9 +
2 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/libavformat/mov.c b/libavformat
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavutil/Makefile | 1 +
libavutil/tests/.gitignore | 1 +
libavutil/tests/uuid.c | 139 +
tests/fate/libavutil.mak | 5 ++
4 files
Loosely based on libuuid
Co-authored-by: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavutil/Makefile | 2 +
libavutil/uuid.c | 156 ++
libavutil/uuid.h | 167
(6):
avutil/tests/uuid: add uuid tests
avformat/mov: refactor to use avutil/uuid
avformat/smoothstreamingenc: refactor to use avutil/uuid
avcodec/cbs_sei: refactor to use avutil/uuid
avformat/imf: refactor to use avutil/uuid
avfilter/showinfo: refactor to use avutil/uuid
Zane van Iperen
On 17/2/22 02:54, p...@sandflow.com wrote:
av_log(s,
AV_LOG_DEBUG,
"Switch resource on track %d: re-open context\n",
track->index);
-if (open_track_resource_context(s, &(track->resource
On 3/2/22 14:07, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
---
libavformat/imfdec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index e6a1020ecc..658ddc40f2 100644
--- a/libavformat/imfdec.c
+++ b/libavfor
On 15/2/22 23:05, Michael Niedermayer wrote:
Signed-off-by: Michael Niedermayer
---
libavformat/argo_cvg.c | 15 +--
libavformat/version.h | 2 +-
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
index c5da32536d
On 15/2/22 05:32, Michael Niedermayer wrote:
+static int argo_cvg_write_trailer(AVFormatContext *s)
+{
+ArgoCVGMuxContext *ctx = s->priv_data;
+int64_t ret;
+
+av_log(s, AV_LOG_TRACE, "size = %zu\n", ctx->size);
+av_log(s, AV_LOG_TRACE, "checksum = %u\n", ctx->checksum);
Signed-off-by: Zane van Iperen
---
libavformat/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/Makefile b/libavformat/Makefile
index 3dc6a479cc..6566e40cac 100644
--- a/libavformat/Makefile
+++ b/libavformat/Makefile
@@ -374,7 +374,7 @@ OBJS
On 21/1/22 03:45, Pierre-Anthony Lemieux wrote:
Hi all,
It was recently suggested that UUID functionality in the codebase
could be refactored into a single library.
Below is short explainer.
I would appreciate your review/feedback before I/we start writing code.
Best,
-- Pierre
I have
On 5/2/22 12:07, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
---
libavformat/tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/tests/.gitignore b/libavformat/tests/.gitignore
index 7ceb7a356b..aabf76345e 100644
--- a/libavformat/tests/.gitignore
+
On 4/2/22 17:58, Paul B Mahol wrote:
Never apply this. Very sorry state of project.
Iirc, there was some discussion on IRC about it. If you're okay with it, then
I'll apply it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.
On 7/1/22 13:55, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
libavformat/tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/tests/.gitignore b/libavformat/tests/.gitignore
index 7ceb7a356b..aabf76345e 1006
---
libavformat/imfdec.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index 023f3556f6..3925462a26 100644
--- a/libavformat/imfdec.c
+++ b/libavformat/imfdec.c
@@ -263,7 +263,7 @@ static void imf_asset_locator_map_
On 6/1/22 04:44, Andreas Rheinhardt wrote:
Forgotten in 555f5c1fc5ae0c4e7b0431dc3166c3fcf3f4e979.
...how did I miss this? LGTM.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
On 5/1/22 12:42, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
libavformat/imf_cpl.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
index 7055b49ae8..f49469f56e 100
Signed-off-by: Zane van Iperen
---
libavcodec/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index 7dc4ccb85f..8cd2d6f849 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -481,8 +481,8 @@ OBJS
On 5/1/22 11:44, Pierre-Anthony Lemieux wrote:
On Tue, Jan 4, 2022 at 5:39 PM Zane van Iperen wrote:
On 4/1/22 01:59, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
Notes:
Found through manual fuzzing.
libavformat/imfdec.c
On 4/1/22 01:59, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
Notes:
Found through manual fuzzing.
libavformat/imfdec.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/imfdec.c b/libavformat/im
On 4/1/22 16:10, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
libavformat/imf_cpl.c | 51 +++
1 file changed, 27 insertions(+), 24 deletions(-)
Could you please resend this as two separate commit
Suggested-By: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index edb4152d0f..8e11fe6d35 100644
--- a/Changelog
+++ b/Changelog
@@ -44,6 +44,7 @@ version :
- yadif_videotoolbox filter
On 4/1/22 16:11, p...@sandflow.com wrote:
cpl_element = xmlDocGetRootElement(doc);
-if (xmlStrcmp(cpl_element->name, "CompositionPlaylist")) {
+if ((!cpl_element) || xmlStrcmp(cpl_element->name, "CompositionPlaylist"))
{
Nit: Extra set of parens around "!cpl_element".
Otherwi
On 4/1/22 19:25, Andreas Rheinhardt wrote:
Signed-off-by: Andreas Rheinhardt
---
I'll apply this pretty soon.
lgtm, Please do.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
On Monday, 3 January 2022 3:22:26 AM AEST p...@sandflow.com wrote:
> From: Pierre-Anthony Lemieux
>
> Signed-off-by: Pierre-Anthony Lemieux
> ---
> libavformat/imfdec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> inde
On Monday, 3 January 2022 4:19:05 PM AEST Andreas Rheinhardt wrote:
> The former is useless without the latter.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 6ad70b9f7b..e2ea473565 100755
> --- a/co
On 3/1/22 01:09, James Almer wrote:
Reverting something in the release branch is already going to be dirty
no matter what, because we do a minor bump to ensure the release has its
own soname. Right now that'd mean 5.0 will be lavf 59.13, while lacking
a demuxer available in lavf 59.12
Depe
On Monday, 3 January 2022 12:29:02 AM AEST James Almer wrote:
> > There were some disagreements on IRC a few days ago about what should
> > and should not go into the release because of insufficient fuzzing and
> > the danger of introducing security issues.
> >
> > To avoid conflicts around this
On 31/12/21 21:19, Paul B Mahol wrote:
++i instead of i++
You're right, I missed that. I'll submit a patch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, o
On 31/12/21 19:40, Paul B Mahol wrote:
Why was this applied?
Both patches lgtm, I'll apply in a few days if no objections.
No one objected.
It still breaks style of ffmpeg code, just from quick glance.
Which parts specifically?
The main potential issue I can see is the long scanf(
Ping. Will apply (with the minor version bump I forgot) in a few days.
On 28/12/21 15:37, Zane van Iperen wrote:
A simple, interleaved variant, but with initial state and
extra, uncompressed samples. Found in Ubisoft soundbanks from
early-2000's games (Splinter Cell, RS3, etc.)
Signed-o
A simple, interleaved variant, but with initial state and
extra, uncompressed samples. Found in Ubisoft soundbanks from
early-2000's games (Splinter Cell, RS3, etc.)
Signed-off-by: Zane van Iperen
---
Changelog | 1 +
doc/general_contents.texi | 1 +
libavcodec/Mak
On 27/12/21 10:47, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
Notes:
The IMF demuxer accepts as input an IMF CPL. The assets referenced by the
CPL can be
contained in multiple deliveries, each defined by an ASSETMAP file:
On 27/12/21 11:41, lance.lmw...@gmail.com wrote:
On Sun, Dec 26, 2021 at 04:37:54PM -0500, Ronald S. Bultje wrote:
Hi,
On Sun, Dec 26, 2021 at 3:21 PM Soft Works wrote:
I'm not sure. My interpretation of Lance' and Steven's comments would
be that they'd prefer to stick to the ML.
No, i
Looks mostly alright, just some style nits. Once they're fixed, lgtm.
On Wednesday, 22 December 2021 4:42:08 AM AEST p...@sandflow.com wrote:
> +
> +int ff_imf_xml_read_uuid(xmlNodePtr element, uint8_t uuid[16])
> +{
> +xmlChar *element_text = NULL;
> +int scanf_ret;
> +int ret = 0;
>
Will apply tomorrow unless there are objections.
On 15/12/21 10:35, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
Notes:
Refactors save_avio_options() from dashdec.c and hls.c
into a common ffio_copy_url_options() in libavformat/a
Dedup is always good, lgtm.
On 15/12/21 10:35, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
Notes:
Refactors save_avio_options() from dashdec.c and hls.c
into a common ffio_copy_url_options() in libavformat/aviobuf.c.
C
Does anyone have any particularly strong feelings against this?
I see nothing obviously wrong with it. The UUID and XML discussion can be
finished later,
so I see no reason why this shouldn't make it in time for the 5.0 release.
I'll apply this weekend if no objections.
On 13/12/21 15:43, p...
On 9/12/21 13:55, p...@sandflow.com wrote:
+
+#define FF_UUID_FORMAT\
+"urn:uuid:%02hhx%02hhx%02hhx%02hhx-%02hhx%02hhx-" \
+"%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx"
+
+/**
+ * UUID as defined in IETF RFC 422
+ */
+typedef uint8_t
Ping, will apply in a few days if no objections.
On 27/11/21 13:51, Zane van Iperen wrote:
Adds demuxer for Square Enux SCD files.
Based off [1] and personal investigation.
This has only been tested against Drakengard 3 (PS3) *_SCD.XXX files
(big-endian). As it is highly likely that FFXIV
.
[1]: http://ffxivexplorer.fragmenterworks.com/research/scd%20files.txt
Signed-off-by: Zane van Iperen
---
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/scd.c| 378 +++
3 files changed, 380 insertions(+)
create mode
On 27/11/21 01:32, Andreas Rheinhardt wrote:
Zane van Iperen:
+
+static int scd_seek(AVFormatContext *s, int stream_index,
+int64_t pts, int flags)
+{
+SCDDemuxContext *ctx = s->priv_data;
+SCDTrackHeader *trk = ctx->tracks + stream_index;
+
+if (pt
On 23/11/21 16:18, Peter Ross wrote:
index cbfadcb639..1054ac9667 100644
--- a/libavformat/allformats.c
+++ b/libavformat/allformats.c
@@ -392,6 +392,7 @@ extern const AVOutputFormat ff_sbc_muxer;
extern const AVInputFormat ff_sbg_demuxer;
extern const AVInputFormat ff_scc_demuxer;
Ping again?
I'll merge in a few days if no objections.
On 13/11/21 04:22, Zane van Iperen wrote:
Ping?
Pretty sure most people didn't get this as I was making DMARC changes at the
time. I can re-send if necessary.
On 4/11/21 00:29, Zane van Iperen wrote:
Adds demuxer for Squar
Ping?
Pretty sure most people didn't get this as I was making DMARC changes at the
time. I can re-send if necessary.
On 4/11/21 00:29, Zane van Iperen wrote:
Adds demuxer for Square Enux SCD files.
s/Enux/Enix/
Based off [1] and personal investigation.
This has only been tested ag
Prevents desktop stutters caused by the change (specifically on KDE).
We're not a game, we don't actually need it disabled.
Signed-off-by: Zane van Iperen
---
fftools/ffplay.c | 4
1 file changed, 4 insertions(+)
diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index
On 14/10/21 10:45 pm, "zhilizhao(赵志立)" wrote:
} ArgoASFFileHeader;
I failed to see why null-terminator is needed from the commit message or from
the source code.
See https://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/286939.html
Sorry for the noise, email client doesn’t show the patc
On 14/10/21 10:11 pm, "zhilizhao(赵志立)" wrote:
typedef struct ArgoASFFileHeader {
uint32_tmagic; /*< Magic Number, {'A', 'S', 'F', '\0'} */
@@ -40,7 +41,7 @@ typedef struct ArgoASFFileHeader {
uint16_tversion_minor; /*< File Minor Version. */
uint32_tnum_chu
Will apply tomorrow if no objections.
Zane
On 12/10/21 9:02 pm, Zane van Iperen wrote:
Signed-off-by: Zane van Iperen
---
libavformat/argo_asf.c | 8
libavformat/argo_asf.h | 3 ++-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavformat/argo_asf.c b
Signed-off-by: Zane van Iperen
---
libavformat/argo_asf.c | 2 ++
tests/ref/acodec/adpcm-argo | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index acf30839b9..740680ece1 100644
--- a/libavformat/argo_asf.c
+++ b
Signed-off-by: Zane van Iperen
---
libavformat/argo_asf.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index 740680ece1..2b3569ebc3 100644
--- a/libavformat/argo_asf.c
+++ b/libavformat/argo_asf.c
@@ -358,14
Signed-off-by: Zane van Iperen
---
libavformat/argo_asf.c | 8
libavformat/argo_asf.h | 3 ++-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index 7e759c7c0c..acf30839b9 100644
--- a/libavformat/argo_asf.c
+++ b
Signed-off-by: Zane van Iperen
---
libavformat/argo_asf.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index f729a393ad..1171d9b7a7 100644
--- a/libavformat/argo_asf.c
+++ b/libavformat/argo_asf.c
Signed-off-by: Zane van Iperen
---
libavformat/argo_asf.c | 5 +
libavformat/argo_asf.h | 3 ++-
tests/ref/acodec/adpcm-argo | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index 7e759c7c0c..f729a393ad 100644
On 26/9/21 1:09 pm, Andreas Rheinhardt wrote:
This avoids a -Wstringop-truncation warning from GCC which takes
issue with the fact that the destination might not be NUL terminated.
Signed-off-by: Andreas Rheinhardt
---
libavformat/argo_asf.c | 20 +++-
1 file changed, 7 in
I say leave it as is.
There's nothing stopping people from submitting a GitHub PR to the mirror repo.
If a maintainer
sees it and decides to pick it up, then they can re-post it to the ML. Imo,
that's completely up to them.
Also, git send-email takes about 2 minutes to configure. Gmail, Yahoo,
Will apply this and parts 3-8 of part 1 soon.
On 18/7/21 7:01 pm, Zane van Iperen wrote:
Signed-off-by: Zane van Iperen
---
libavcodec/argo.c| 4 ++--
libavcodec/version.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/argo.c b/libavcodec/argo.c
index
On 18/7/21 11:18 pm, James Almer wrote:
On 7/17/2021 10:21 PM, Zane van Iperen wrote:
But fall back to bits_per_raw_sample, in case we're with older
libavformat.
What older libavformat? We bumped major version a few months ago, so you can't
link git head lavc with lavf <= 5
Signed-off-by: Zane van Iperen
---
libavformat/argo_brp.c | 2 +-
libavformat/version.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c
index 059418cd1d..2ccdbd3e5b 100644
--- a/libavformat/argo_brp.c
+++ b/libavformat
Signed-off-by: Zane van Iperen
---
libavcodec/argo.c| 4 ++--
libavcodec/version.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/argo.c b/libavcodec/argo.c
index 87c646f56c..057100bd12 100644
--- a/libavcodec/argo.c
+++ b/libavcodec/argo.c
@@ -676,12
I really doubt this is correct approach. No other video decoder use pix
format set from demuxer.
I could change it to use bits_per_coded_sample instead, would that be better?
I see that's what Cinepak does.
Zane
___
ffmpeg-devel mailing list
ffmpeg-
Signed-off-by: Zane van Iperen
---
libavformat/pp_bnk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/pp_bnk.c b/libavformat/pp_bnk.c
index dfe5343cde..821d14a4aa 100644
--- a/libavformat/pp_bnk.c
+++ b/libavformat/pp_bnk.c
@@ -214,7 +214,6 @@ static int pp_bnk_read_header
Signed-off-by: Zane van Iperen
---
libavformat/kvag.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/kvag.c b/libavformat/kvag.c
index 94dc1ddc04..b5ebe418e6 100644
--- a/libavformat/kvag.c
+++ b/libavformat/kvag.c
@@ -80,7 +80,6 @@ static int kvag_read_header(AVFormatContext *s
Signed-off-by: Zane van Iperen
---
libavformat/apm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/apm.c b/libavformat/apm.c
index 6ae53b8712..6a047c5095 100644
--- a/libavformat/apm.c
+++ b/libavformat/apm.c
@@ -146,7 +146,6 @@ static int apm_read_header(AVFormatContext *s
Signed-off-by: Zane van Iperen
---
libavformat/alp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/alp.c b/libavformat/alp.c
index bc19f02083..4876015f4b 100644
--- a/libavformat/alp.c
+++ b/libavformat/alp.c
@@ -127,7 +127,6 @@ static int alp_read_header(AVFormatContext *s
1 - 100 of 611 matches
Mail list logo
