Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/vf_bwdif: consider chroma subsampling when enforcing minimum dimensions

2023-12-02 Thread Thomas Mundt
Cosmin Stejerean via ffmpeg-devel schrieb am Sa., 2. Dez. 2023, 21:17: > From: Cosmin Stejerean > > Fixes #10688 > > Signed-off-by: Cosmin Stejerean > --- > libavfilter/vf_bwdif.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_bwdif.c b/libavfi

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_bwdif: consider chroma subsampling when enforcing minimum dimensions

2023-11-30 Thread Thomas Mundt
Am Do., 30. Nov. 2023 um 01:23 Uhr schrieb Cosmin Stejerean via ffmpeg-devel : > From: Cosmin Stejerean > > Fixes #10688 > > Signed-off-by: Cosmin Stejerean > --- > libavfilter/vf_bwdif.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_bwdi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif: consider chroma subsampling when enforcing minimum dimensions

2023-11-28 Thread Thomas Mundt
Hi Cosmin, Cosmin Stejerean via ffmpeg-devel schrieb am Sa., 25. Nov. 2023, 21:39: > Fixes #10688 > > Signed-off-by: Cosmin Stejerean > --- > libavfilter/vf_bwdif.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/libavfilter/vf_bwdif.c b/libavfilter/vf_bwdif.c > index 13

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-03 Thread Thomas Mundt
Lynne schrieb am Di., 4. Juli 2023, 00:54: > Jul 4, 2023, 00:08 by tmund...@gmail.com: > > > Am So., 2. Juli 2023 um 20:58 Uhr schrieb Lynne : > > > >> Jul 2, 2023, 20:41 by tmund...@gmail.com: > >> > >> > Am So., 2. Juli 2023 um 18:57 Uhr schrieb Lynne : > >> > > >> >> Jul 2, 2023, 18:54 by d...

Re: [FFmpeg-devel] [PATCH v2 12/15] avfilter/vf_bwdif: Add a filter_line3 method for optimisation

2023-07-03 Thread Thomas Mundt
Am Mo., 3. Juli 2023 um 10:27 Uhr schrieb John Cox : > On Mon, 3 Jul 2023 00:12:46 +0300 (EEST), you wrote: > > >On Sun, 2 Jul 2023, Thomas Mundt wrote: > > > >> Am So., 2. Juli 2023 um 14:34 Uhr schrieb John Cox : > >> Add an optional filter_

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-03 Thread Thomas Mundt
Am So., 2. Juli 2023 um 20:58 Uhr schrieb Lynne : > Jul 2, 2023, 20:41 by tmund...@gmail.com: > > > Am So., 2. Juli 2023 um 18:57 Uhr schrieb Lynne : > > > >> Jul 2, 2023, 18:54 by d...@lynne.ee: > >> > >> > The issue is that clipping the interpolated temporal sample against > >> > the spatially p

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Thomas Mundt
Am So., 2. Juli 2023 um 18:57 Uhr schrieb Lynne : > Jul 2, 2023, 18:54 by d...@lynne.ee: > > > The issue is that clipping the interpolated temporal sample against > > the spatially predicted sample causes artifacts to appear. > > > > Discovered while writing the Vulkan version (where I omitted the

Re: [FFmpeg-devel] [PATCH v2 12/15] avfilter/vf_bwdif: Add a filter_line3 method for optimisation

2023-07-02 Thread Thomas Mundt
Am So., 2. Juli 2023 um 14:34 Uhr schrieb John Cox : > Add an optional filter_line3 to the available optimisations. > > filter_line3 is equivalent to filter_line, memcpy, filter_line > > filter_line shares quite a number of loads and some calculations in > common with its next iteration and testin

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif: Remove undesireable spatial preference logic

2023-06-14 Thread Thomas Mundt
Lynne schrieb am So., 11. Juni 2023, 20:11: > Jun 11, 2023, 04:53 by phil...@overt.org: > > > On Sat, 25 Mar 2023 00:02:03 +0100 > > Thomas Mundt wrote: > > > >> Hi Philip, > >> > >> Philip Langdale schrieb am Fr., 24. März 2023, > >&

Re: [FFmpeg-devel] [PATCH 2/3] checkasm: add test for bwdif

2023-03-11 Thread Thomas Mundt
Hi James, Am Mo., 20. Feb. 2023 um 20:59 Uhr schrieb James Darnley : > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > tests/checkasm/vf_bwdif.c | 70 +++ > tests/fate/checkasm.mak | 1 + >

Re: [FFmpeg-devel] [PATCH 3/3] avfilter: add avx2 filter_line function for bwdif

2023-03-11 Thread Thomas Mundt
Hi James, Am Mo., 20. Feb. 2023 um 20:59 Uhr schrieb James Darnley : > 2.24x faster (1925±1.3 vs. 859±2.2 decicycles) compared with ssse3 > --- > libavfilter/x86/vf_bwdif.asm| 29 - > libavfilter/x86/vf_bwdif_init.c | 12 > 2 files changed, 36 inserti

Re: [FFmpeg-devel] [PATCH 1/3] avfilter: move bwdif's filter_line init into a dedicated function

2023-02-23 Thread Thomas Mundt
Hi James, James Darnley schrieb am Mo., 20. Feb. 2023, 13:59: > --- > libavfilter/bwdif.h | 3 ++- > libavfilter/vf_bwdif.c | 13 + > libavfilter/x86/vf_bwdif_init.c | 4 +--- > 3 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/libavfilter/bwd

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_tinterlace: support full-range YUV

2022-12-16 Thread Thomas Mundt
Am Fr., 9. Dez. 2022 um 01:28 Uhr schrieb Niklas Haas : > From: Niklas Haas > > This filter, when used in the "pad" mode, currently makes the > distinction between limited and full range solely by testing for YUVJ > pixel formats at link setup time. This is deprecated and should be > improved to

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif_cuda: CUDA implementation of bwdif

2020-10-13 Thread Thomas Mundt
Am Mo., 12. Okt. 2020 um 21:42 Uhr schrieb Philip Langdale < phil...@overt.org>: > On Sun, 11 Oct 2020 18:36:42 +0200 > Thomas Mundt wrote: > > > Hi Philip, > > > > Am Fr., 9. Okt. 2020 um 18:33 Uhr schrieb Philip Langdale > > > >: > > > &

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif_cuda: CUDA implementation of bwdif

2020-10-11 Thread Thomas Mundt
Hi Philip, Am Fr., 9. Okt. 2020 um 18:33 Uhr schrieb Philip Langdale : > I've been sitting on this for a couple of years now, and I figured I > should just send it out. This is what I believe is a conceptually > correct port of bwdif to cuda (modulo edge handling which is not done > in the same w

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif: fix heap-buffer overflow

2019-10-14 Thread Thomas Mundt
Am So., 13. Okt. 2019 um 23:22 Uhr schrieb Paul B Mahol : > Fixes #8261 > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_bwdif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_bwdif.c b/libavfilter/vf_bwdif.c > index 37165584cf..b6aed7a450 10064

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-19 Thread Thomas Mundt
Am Fr., 16. Aug. 2019 um 23:31 Uhr schrieb Tomas Härdin : > tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: > > Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin < > tjop...@acc.umu.se > > > : > > > ons 2019-08-14 klockan 22:18 +0200 skr

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-15 Thread Thomas Mundt
Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin : > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt: > > Hi Tomas, > > > > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin < > tjop...@acc.umu.se > > > : > > > tis 2019-08-13 klock

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-14 Thread Thomas Mundt
Hi Tomas, Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin : > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt: > > Hi, > > > > attached patch fixes ticket #8077. > > Please comment. > > Probably OK, bitrates lower than 5000 are fine in D-10 acco

[FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-13 Thread Thomas Mundt
Hi, attached patch fixes ticket #8077. Please comment. Regards, Thomas 0001-libavformat-mxfenc-Allow-more-bitrates-for-NTSC-IMX5.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/f

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-05-14 Thread Thomas Mundt
Hi Baptiste, Am Di., 14. Mai 2019 um 18:59 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 186 + > libavformat/avc.h| 15 +++ > libavformat/hevc.c | 36 +--- > libavfo

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-05-14 Thread Thomas Mundt
Hi Baptiste, Am Di., 14. Mai 2019 um 00:33 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 186 + > libavformat/avc.h| 15 +++ > libavformat/hevc.c | 36 +--- > libavfo

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-05-13 Thread Thomas Mundt
Hi Baptiste, Am Fr., 10. Mai 2019 um 17:51 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 188 ++ > libavformat/avc.h| 15 +++ > libavformat/hevc.c | 36 +--- > libavf

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Thomas Mundt
Hi Baptiste, Am Mi., 10. Apr. 2019 um 00:29 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > Hi Thomas, I hope you are doing well > > > On Apr 4, 2019, at 7:27 AM, Thomas Mundt wrote: > > > > Hi Baptiste, > > > > […] > > For

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-04 Thread Thomas Mundt
Hi Baptiste, Am Mi., 3. Apr. 2019 um 11:23 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 197 --- > 2 files changed, 147 insertions(+), 51 deletions(-) > > diff --git a/libavf

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-04-01 Thread Thomas Mundt
Am Sa., 30. März 2019 um 17:52 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > Hi Thomas, > > > On Mar 29, 2019, at 1:11 PM, Thomas Mundt wrote: > > > > > > […] > > > >> > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0a,0x04,0x01,0x

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-03-29 Thread Thomas Mundt
Am Do., 28. März 2019 um 16:51 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 194 --- > 2 files changed, 145 insertions(+), 50 deletions(-) > > diff --git a/libavformat/mxf.h b

Re: [FFmpeg-devel] [PATCH 0/2] Update vf_bwdif to use yadif_common v2

2018-11-12 Thread Thomas Mundt
s to the common code. > > Assuming it's reasonable to do that tracking even though yadif doesn't > need it, we can then remove all the duplicated logic. > > v2: Rename enum values as recommened by Thomas Mundt. > > Philip Langdale (2): > avfilter/yadif_common: Add field

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/yadif_common: Add field type tracking to help bwdif

2018-11-11 Thread Thomas Mundt
Am Sa., 10. Nov. 2018 um 18:47 Uhr schrieb Philip Langdale < phil...@overt.org>: > The bwdif filter can use common yadif frame management if we track > when a field is the first or last field in a sequence. While this > information is not used by yadif, the added benefit of removing the > duplicat

Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options

2018-09-07 Thread Thomas Mundt
Am Do., 30. Aug. 2018 um 10:37 Uhr schrieb Thomas Mundt : > Am Mo., 27. Aug. 2018 um 20:40 Uhr schrieb Thomas Mundt < > tmund...@gmail.com>: > >> Am Mo., 27. Aug. 2018 um 19:40 Uhr schrieb Paul B Mahol > >: >> >>> On 8/27/18, Thomas Mundt wrote: >&g

Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options

2018-08-30 Thread Thomas Mundt
Am Mo., 27. Aug. 2018 um 20:40 Uhr schrieb Thomas Mundt : > Am Mo., 27. Aug. 2018 um 19:40 Uhr schrieb Paul B Mahol >: > >> On 8/27/18, Thomas Mundt wrote: >> > Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol < >> one...@gmail.com>: >&g

Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options

2018-08-27 Thread Thomas Mundt
Am Mo., 27. Aug. 2018 um 19:40 Uhr schrieb Paul B Mahol : > On 8/27/18, Thomas Mundt wrote: > > Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol < > one...@gmail.com>: > > > >> On 8/23/18, Thomas Mundt wrote: > >> > Currently numerical opt

Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options

2018-08-27 Thread Thomas Mundt
Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol : > On 8/23/18, Thomas Mundt wrote: > > Currently numerical option values are misinterpreted in vf_interlace > > filter. > > Patch attached. > > > > Regards, > > Thomas >

[FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options

2018-08-23 Thread Thomas Mundt
Currently numerical option values are misinterpreted in vf_interlace filter. Patch attached. Regards, Thomas 0001-avfilter-vf_interlace-fix-numerical-options.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-08-17 Thread Thomas Mundt
Hi, 2018-08-16 13:56 GMT+02:00 Vasile Toncu : > Hi, > > Thank you for the additional testing effort. > Fixed the issue. > > thanks, the patch looks good to me as far as I can judge. It´s up to more experienced developers now to permit the license change. Can anybody please have a look at this. R

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-08-14 Thread Thomas Mundt
Hi, 2018-08-14 18:53 GMT+02:00 Vasile Toncu : > Hi Thomas, > > I added the log messages. > > Thanks for the review. > I found some more time for testing this evening. Unfortunately there are still issues. I get half green pictures with some modes at high bit depth. But the fix is easy. The bytew

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-08-14 Thread Thomas Mundt
Hi, 2018-08-13 0:02 GMT+02:00 Vasile Toncu : > Hello, > > I have updated patch 3 according to review, removed all code related to the > new flags (MERGE_TFF, MERGE_BFF) and threading functionality. > > Thanks, your patch looks fine to me now. There is just one thing, I forgot to mention last revi

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-07-28 Thread Thomas Mundt
Hi, 2018-07-24 12:17 GMT+02:00 Vasile Toncu : > Fixed tabs. > Thank you for the feedback. > > {} > +case MODE_INTERLEAVE_BOTTOM: > +case MODE_INTERLEAVE_TOP: > +y = y * 2; > + > +if (tinterlace->flags & FLAG_VLPF || tinterlace->flags & > FLAG_CVLPF) { > + > +

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-07-25 Thread Thomas Mundt
2018-07-25 17:11 GMT+02:00 Vasile Toncu : > What would be the next steps? > > On Tue, Jul 24, 2018 at 12:17 PM, Vasile Toncu > wrote: > > > Fixed tabs. > > Thank you for the feedback. > > > > On Fri, Jul 20, 2018 at 7:27 PM, Paul B Mahol wrote: > > > >> On 7/20/18, Vasile Toncu wrote: > >> > Hi

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-05-31 Thread Thomas Mundt
Hi, 2018-05-30 16:10 GMT+02:00 Vasile Toncu : > Hello, > > I've sent a wrong version in the previous email for patch 3. Please > ignore. This is the corect one. the compiler warnings are gone, but fate-filter-pixfmts-tinterlace_pad still fails. Why do you replace the usage of draw utils for gen

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-08 Thread Thomas Mundt
2018-05-07 10:40 GMT+02:00 Tomas Härdin : > sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt: > > 2018-05-06 13:32 GMT+02:00 Tomas Härdin : > > > > > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt: > > > > Hi, > > > > > > > &g

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-06 Thread Thomas Mundt
2018-05-06 13:32 GMT+02:00 Tomas Härdin : > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt: > > Hi, > > > > this is a better version of the patch. > > 10 bit and TFF are mandatory for AVC Intra only. Other profiles > > differ. > > > > >

Re: [FFmpeg-devel] [PATCH v2] avformat/mxfenc: add h264 profiles

2018-05-03 Thread Thomas Mundt
Hi, this is a better version of the patch. 10 bit and TFF are mandatory for AVC Intra only. Other profiles differ. Regards, Thomas 0001-avformat-mxfenc-add-h264-profiles.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add h264 profiles

2018-04-30 Thread Thomas Mundt
2018-04-30 19:27 GMT+02:00 Paul B Mahol : > On 4/30/18, Thomas Mundt wrote: > > Hi, > > > > attached patch adds some h264 profiles to the mxf encoder. > > *muxer, not encoder. > Right. I was writing mxfenc short before and seem to switched of my brain. > &

[FFmpeg-devel] [PATCH] avformat/mxfenc: add h264 profiles

2018-04-30 Thread Thomas Mundt
Hi, attached patch adds some h264 profiles to the mxf encoder. Please comment. Thomas 0001-avformat-mxfenc-add-h264-profiles.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-04-25 Thread Thomas Mundt
Hi, 2018-04-25 16:24 GMT+02:00 Vasile Toncu : > Hello, > > Here is patch 3. I renamed reinterlace to tinterlace and replaced the > functionality of tinterlace with the one from reinterlace. Please review. > > Thank you, > Vasile > Same as I wrote for your previous version. Lots of compiler warni

Re: [FFmpeg-devel] [PATCH 3/5] reitnerlace - tinterlace-like filter under LGPL

2018-04-25 Thread Thomas Mundt
Hi, 2018-04-23 18:22 GMT+02:00 Vasile Toncu : > Hello, > > Here is patch 3. Please review. > > Thank you, > Vasile > Some fate tests fail when both patches are applied. I also get lots of compiler warnings. Please fix them and, as already said, run fate. All tests must pass, otherwise there is s

Re: [FFmpeg-devel] [PATCH 1/6] reitnerlace - tinterlace-like filter under LGPL

2018-04-17 Thread Thomas Mundt
Hi, 2018-04-17 13:33 GMT+02:00 Vasile Toncu : > > > On 12.04.2018 19:45, Thomas Mundt wrote: > >> >> You need to write separate AVOption interlace_options and AVFilter >> avfilter_vf_interlace in vf_tinterlace.c >> Have a look at this patch: >> https://g

Re: [FFmpeg-devel] [PATCH 1/6] reitnerlace - tinterlace-like filter under LGPL

2018-04-12 Thread Thomas Mundt
Hi, 2018-04-10 22:34 GMT+02:00 Vasile Toncu : > Hello, > > This is the first part of the first patch. I added interlace options to > tinterlace. On the next patch I will delete vf_interlace. > > > Thank you, > > Vasile Toncu > > > From b2be4e949e071f9017d8a9d6fbd1fbb56505ac50 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-29 Thread Thomas Mundt
2018-03-29 15:44 GMT+02:00 Vasile Toncu : > > > On 14.03.2018 18:56, Thomas Mundt wrote: > >> 2018-03-13 16:10 GMT+01:00 Vasile Toncu : >> >> >>> On 06.03.2018 20:38, Thomas Mundt wrote: >>> >>> Hi, >>>> >>>> 2018-03

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-14 Thread Thomas Mundt
2018-03-13 16:10 GMT+01:00 Vasile Toncu : > > > On 06.03.2018 20:38, Thomas Mundt wrote: > >> Hi, >> >> 2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos : >> >> 2018-03-05 12:37 GMT+01:00, Paul B Mahol : >>> >>>> On 3/5/18, Vasile Toncu w

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-06 Thread Thomas Mundt
2018-03-07 0:49 GMT+01:00 Carl Eugen Hoyos : > 2018-03-06 19:38 GMT+01:00, Thomas Mundt : > > > > 2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos : > > > >> 2018-03-05 12:37 GMT+01:00, Paul B Mahol : > >> > On 3/5/18, Vasile Toncu wrote: > >> &g

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-06 Thread Thomas Mundt
Hi, 2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos : > 2018-03-05 12:37 GMT+01:00, Paul B Mahol : > > On 3/5/18, Vasile Toncu wrote: > >> Hello, > >> > >> Thanks for the review. I've made changes according to your guidance. > >> > >> It would be great to know if the community will go on with our in

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-02-21 Thread Thomas Mundt
e the > parts they wrote under LGPL. I mention here Thomas Mundt and Stefano > Sabatini. > > This being said, I come up with a new filter - reinterlace - which > implements all the tinterlace functionalities and adds a few more. > > The new filter is added to ffmpeg without --enable

Re: [FFmpeg-devel] tinterlace license

2018-02-06 Thread Thomas Mundt
it happens that this task results in unnecessary > duplicated code. > > I want to address the main copyright holders Thomas Mundt, Stefano > Sabatini, Baptiste Coudurier and other ffmpeg maintainers for their > approval. > I have no objections changing the license to LGPL, but

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-19 Thread Thomas Mundt
2017-12-19 22:57 GMT+01:00 James Almer : > On 12/19/2017 6:40 PM, Martin Vignali wrote: > > 2017-12-19 21:59 GMT+01:00 James Almer : > > > >> On 12/19/2017 5:16 PM, Martin Vignali wrote: > > LGTM, thanks. > > >>> > >>> Pushed, thanks > >> > >> This broke several interlace fate tests

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-18 Thread Thomas Mundt
2017-12-18 11:34 GMT+01:00 Martin Vignali : > > > > > > > Please also add the changes you made in patch 1 and avx2 to > vf_tinterlace. > > > > > > > > For patch 1, IMHO, it's not necessary (the modification is mainly to make > checkasm test easier to write, and like vf_interlace and vf_tinterlace

Re: [FFmpeg-devel] avfilter/vf_interlace and vf_tinterlace : remove avx version

2017-12-17 Thread Thomas Mundt
Hi, 2017-12-16 18:38 GMT+01:00 Martin Vignali : > Hello, > > Following discussion "avfilter/vf_interlace : add checkasm for lowpass_line > and AVX2 version" > the AVX version seems to be slower than SSE > > Patch in attach remove it, for vf_interlace and vf_tinterlace (both use the > same SIMD) >

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-17 Thread Thomas Mundt
Hi, 2017-12-16 18:35 GMT+01:00 Martin Vignali : > 2017-12-16 14:48 GMT+01:00 Carl Eugen Hoyos : > > > 2017-12-16 14:17 GMT+01:00 Martin Vignali : > > > > > 002 : Checkasm test for lowpass_line > > > > The change to checkasm.mak contains unexpected tabs iiuc. > > > > New patch in attach > Please

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-14 Thread Thomas Mundt
2017-12-14 21:33 GMT+01:00 Thomas Mundt : > Hi, > > 2017-12-14 17:01 GMT+01:00 Martin Vignali : > >> Hello, >> >> >> in attach patch to fix crash using this command line >> ./ffmpeg -f lavfi -i testsrc=s=hd1080,format=yuv420p -vf >> crop=1440:108

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash in low_pass_complex

2017-12-14 Thread Thomas Mundt
Hi, 2017-12-14 17:58 GMT+01:00 Martin Vignali : > Hello, > > related to ticket 6491 (crash using crop and vf_interlace) > > in attach patch to fix crash when data are unaligned, with low_pass_complex > filtering > (the previous patch, fix crash, for low_pass_simple filtering) > > > Can be test wi

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-14 Thread Thomas Mundt
Hi, 2017-12-14 17:01 GMT+01:00 Martin Vignali : > Hello, > > > in attach patch to fix crash using this command line > ./ffmpeg -f lavfi -i testsrc=s=hd1080,format=yuv420p -vf > crop=1440:1080,interlace -f null - > (ticket 6491) > > Use unaligned load, to avoid crash > this changes the color plan

Re: [FFmpeg-devel] R: [PATCH] MXF format fix for Sony Station compatibility

2017-10-24 Thread Thomas Mundt
2017-10-24 12:35 GMT+02:00 : > >From 2a657145a9b6bc2c1beb450100fe2d4d80ee Mon Sep 17 00:00:00 2001 > From: "Axel Technology" > Date: Mon, 23 Oct 2017 18:02:58 +0200 > Subject: [PATCH] Sony XDCAM Fix > > Signed-off-by: Axel Technology > --- > libavformat/mxfenc.c | 112 > +++

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

2017-10-12 Thread Thomas Mundt
Hi Michael, 2017-10-12 1:28 GMT+02:00 Michael Niedermayer : > On Tue, Oct 10, 2017 at 10:26:13PM +0200, Thomas Mundt wrote: > > 2017-10-10 19:36 GMT+02:00 Sasi Inguva : > > > > > This is required for FLV files, for which duration_pts comes out to be > > > zero

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

2017-10-10 Thread Thomas Mundt
2017-10-10 19:36 GMT+02:00 Sasi Inguva : > This is required for FLV files, for which duration_pts comes out to be > zero. > > Signed-off-by: Sasi Inguva > --- > fftools/ffmpeg.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

2017-10-10 Thread Thomas Mundt
2017-10-10 19:44 GMT+02:00 wm4 : > On Tue, 10 Oct 2017 10:36:58 -0700 > Sasi Inguva wrote: > > > This is required for FLV files, for which duration_pts comes out to be > zero. > > > > Signed-off-by: Sasi Inguva > > --- > > fftools/ffmpeg.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 d

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

2017-10-10 Thread Thomas Mundt
2017-10-10 3:27 GMT+02:00 Sasi Inguva : > This is required for FLV files, for which duration_pts comes out to be > zero. > > Signed-off-by: Sasi Inguva > --- > fftools/ffmpeg.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 6d64bc1043..5f3

Re: [FFmpeg-devel] [PATCH] lavfi/avfilter.c: Correct guess_status_pts to account for differing link timebases.

2017-10-06 Thread Thomas Mundt
2017-10-06 10:01 GMT+02:00 Nicolas George : > Le quartidi 14 vendémiaire, an CCXXVI, Sasi Inguva a écrit : > > Signed-off-by: Sasi Inguva > > --- > > libavfilter/avfilter.c | 16 > > 1 file changed, 8 insertions(+), 8 deletions(-) > > You are right, this change is needed. Thanks

Re: [FFmpeg-devel] [PATCH] lavfi/avfilter.c: Correct guess_status_pts to account for differing link timebases.

2017-10-06 Thread Thomas Mundt
2017-10-06 4:49 GMT+02:00 Sasi Inguva : > Signed-off-by: Sasi Inguva > --- > libavfilter/avfilter.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index 58917ed445..ec7dfc0bd3 100644 > --- a/libavfilter/

Re: [FFmpeg-devel] [PATCH 5/5] ffmpeg: send EOF pts to filters.

2017-10-03 Thread Thomas Mundt
Hi Nicolas, 2017-09-07 10:59 GMT+02:00 Nicolas George : > Signed-off-by: Nicolas George > --- > ffmpeg.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index b95addd277..1d248bc269 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c > @@ -2223,14

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: rename two variables for consistency

2017-09-25 Thread Thomas Mundt
2017-09-19 22:54 GMT+02:00 Thomas Mundt : > The attached patch needs to be applied on top of > "avfilter/interlace: add support for 10 and 12 bit". > Thanks. > Ping This patch is needful cosmetic after last commit. ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 3/3 v2] avfilter/interlace: add support for 10 and 12 bit

2017-09-23 Thread Thomas Mundt
2017-09-23 20:24 GMT+02:00 Michael Niedermayer : > On Tue, Sep 19, 2017 at 10:35:30PM +0200, Thomas Mundt wrote: > > 2017-09-19 17:53 GMT+02:00 James Almer : > > > > > On 9/19/2017 5:02 AM, Thomas Mundt wrote: > > > > 2017-09-19 4:09 GMT+02:00 James Almer : &g

[FFmpeg-devel] [PATCH] avfilter/interlace: rename two variables for consistency

2017-09-19 Thread Thomas Mundt
The attached patch needs to be applied on top of "avfilter/interlace: add support for 10 and 12 bit". Thanks. 0001-avfilter-interlace-rename-two-variables-for-consiste.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 3/3 v2] avfilter/interlace: add support for 10 and 12 bit

2017-09-19 Thread Thomas Mundt
2017-09-19 17:53 GMT+02:00 James Almer : > On 9/19/2017 5:02 AM, Thomas Mundt wrote: > > 2017-09-19 4:09 GMT+02:00 James Almer : > > > >> On 9/18/2017 10:41 PM, Thomas Mundt wrote: > >>> I tried to set up MIPS compiler for two days on windows and linux > wi

Re: [FFmpeg-devel] [PATCH 3/3 v2] avfilter/interlace: add support for 10 and 12 bit

2017-09-19 Thread Thomas Mundt
2017-09-19 4:09 GMT+02:00 James Almer : > On 9/18/2017 10:41 PM, Thomas Mundt wrote: > > I tried to set up MIPS compiler for two days on windows and linux without > > success. > > Now I try it blind. This solution is based on the first suggestion James > > gave me at I

[FFmpeg-devel] [PATCH 3/3 v2] avfilter/interlace: add support for 10 and 12 bit

2017-09-18 Thread Thomas Mundt
I tried to set up MIPS compiler for two days on windows and linux without success. Now I try it blind. This solution is based on the first suggestion James gave me at IRC. There might be room for improvement and an alternative solution with AV_RL16() / AV_WL16(). I used av_le2ne16() because it will

[FFmpeg-devel] [PATCH 2/3 v2] avfilter/tinterlace: use drawutils for pad mode

2017-09-18 Thread Thomas Mundt
Patch 1/3 has already been applied. Patch attached. 0002-avfilter-tinterlace-use-drawutils-for-pad-mode.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself for bwdif and (t)interlace

2017-09-15 Thread Thomas Mundt
Requested by Michael 0001-MAINTAINERS-add-myself-for-bwdif-and-t-interlace.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/interlace: add support for 10 and 12 bit

2017-09-15 Thread Thomas Mundt
2017-09-15 22:15 GMT+02:00 Michael Niedermayer : > On Thu, Sep 14, 2017 at 10:58:01PM +0200, Thomas Mundt wrote: > > > Patch attached > > > > > libavfilter/interlace.h|4 - > > > libavfilter/tinterlace.h |4

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-09-15 Thread Thomas Mundt
2017-09-15 22:26 GMT+02:00 Michael Niedermayer : > On Fri, Sep 15, 2017 at 04:38:16PM +0200, Thomas Mundt wrote: > > > Michael, is it possible for you to push this? > > will push > Thanks! also i see noone listed in MAINTAINERS for vf_(t)interlace > if noone objects,

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-09-15 Thread Thomas Mundt
2017-09-13 23:35 GMT+02:00 Thomas Mundt : > 2017-09-06 22:15 GMT+02:00 Thomas Mundt : > >> 2017-09-01 1:55 GMT+02:00 Thomas Mundt : >> >>> 2017-09-01 1:22 GMT+02:00 Michael Niedermayer : >>> >>>> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael N

[FFmpeg-devel] [PATCH 1/3] avfilter/interlace: simplify code

2017-09-14 Thread Thomas Mundt
Patch attached 0001-avfilter-interlace-simplify-code.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/3] avfilter/interlace: add support for 10 and 12 bit

2017-09-14 Thread Thomas Mundt
Patch attached 0003-avfilter-interlace-add-support-for-10-and-12-bit.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/3] avfilter/tinterlace: use drawutils for pad mode

2017-09-14 Thread Thomas Mundt
Patch attached 0002-avfilter-tinterlace-use-drawutils-for-pad-mode.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 0/3] avfilter/interlace: add support for 10 and 12 bit

2017-09-14 Thread Thomas Mundt
Hi, this patch set adds support for 10 and 12 bit to the interlace filters. This is useful for broadcasters transcoding high bit depth sources to AVC Intra or similar 10 bit video codecs. These patches need to be applied on top of the following patch, which is not pushed yet: http://ffmpeg.org/pip

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-09-13 Thread Thomas Mundt
2017-09-06 22:15 GMT+02:00 Thomas Mundt : > 2017-09-01 1:55 GMT+02:00 Thomas Mundt : > >> 2017-09-01 1:22 GMT+02:00 Michael Niedermayer : >> >>> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote: >>> > On Thu, Aug 31, 2017 at 10:40:12PM +02

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-12 Thread Thomas Mundt
Hi Thierry, 2017-09-12 3:25 GMT+02:00 Thierry Foucu : > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > > Update the Patch with the correct number of duplicate showing. > For exmaple, in case we up-sample one second video at 24fps by 2, we > should be getting 24 duplicate frames

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-11 Thread Thomas Mundt
Hi Thierry, 2017-09-11 23:00 GMT+02:00 Thierry Foucu : > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > libavfilter/vf_fps.c| 40 +++- > tests/ref/fate/filter-fps | 6 ++ > tests/ref/fate/filter-fps-r | 4 > tests/ref/fa

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-08 Thread Thomas Mundt
Hi Thierry, 2017-09-08 19:03 GMT+02:00 Thierry Foucu : > --- > libavfilter/vf_fps.c| 42 ++ > +++- > tests/ref/fate/filter-fps | 6 ++ > tests/ref/fate/filter-fps-r | 4 > 3 files changed, 47 insertions(+), 5 deletions(-) > > diff --git a/

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-09-06 Thread Thomas Mundt
2017-09-01 1:55 GMT+02:00 Thomas Mundt : > 2017-09-01 1:22 GMT+02:00 Michael Niedermayer : > >> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote: >> > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote: >> > > 2017-08-31 21

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-31 Thread Thomas Mundt
2017-09-01 1:22 GMT+02:00 Michael Niedermayer : > On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote: > > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote: > > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer >: > > > > > > >

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-31 Thread Thomas Mundt
2017-08-31 21:42 GMT+02:00 Michael Niedermayer : > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote: > > Hi, > > > > we did a transcoding cascade test at work were over-sharpening became > > visible with the complex low-pass filter. This patch

[FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-29 Thread Thomas Mundt
Hi, we did a transcoding cascade test at work were over-sharpening became visible with the complex low-pass filter. This patch rectifies the behaviour. Please comment... 0001-avfilter-interlace-prevent-over-sharpening-with-the-.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 Thread Thomas Mundt
2017-06-15 21:23 GMT+02:00 Nicolas George : > Le septidi 27 prairial, an CCXXV, Thomas Mundt a écrit : > > Hmm, before rewriting and sending this patch I asked if it would have a > > chance to be pushed just to fix the ticket which is open for a very long > > time. Yo

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 Thread Thomas Mundt
2017-06-15 20:00 GMT+02:00 Nicolas George : > Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > > Patch attached. This fixes ticket #2674. I inserted a FIXME message as a > > reminder. > > Please comment. > > I am sorry to say I do not like it. The timestamp c

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-13 Thread Thomas Mundt
2017-06-13 15:04 GMT+02:00 Thomas Mundt : > 2017-06-13 15:00 GMT+02:00 Nicolas George : > >> Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : >> > Live with the open ticket or with the modified patch? >> >> Either, actually, but I meant the modified p

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-13 Thread Thomas Mundt
2017-06-13 15:00 GMT+02:00 Nicolas George : > Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > > Live with the open ticket or with the modified patch? > > Either, actually, but I meant the modified patch. > Okay, I´ll write the patch then and send it soon. Thanks a

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-13 Thread Thomas Mundt
2017-06-13 14:46 GMT+02:00 Nicolas George : > Le quintidi 25 prairial, an CCXXV, Thoms Mundt a écrit : > > Since I dont see any solution or wip for this, I could modify my patch > and > > remove the use of pkt_duration. This would only work for constant frame > rate > > input, but fixes ticket #26

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-05-02 Thread Thomas Mundt
2017-05-02 19:14 GMT+02:00 James Almer : > On 5/2/2017 1:49 PM, Paul B Mahol wrote: > > On 5/2/17, Thomas Mundt wrote: > >> 2017-04-29 18:15 GMT+02:00 Thomas Mundt : > >> > >>> 2017-04-20 23:54 GMT+02:00 Thomas Mundt : > >>> > >>

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-05-02 Thread Thomas Mundt
2017-04-29 18:15 GMT+02:00 Thomas Mundt : > 2017-04-20 23:54 GMT+02:00 Thomas Mundt : > >> Patch attached... >> >> Ping > Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

  1   2   >