Re: [FFmpeg-devel] [v7 PATCH 1/1] libavfilter/vf_grayworld: Add gray world filter

2021-08-30 Thread Paul Buxton
Thats, great thanks. How did you generate the NANs? I don't believe under normal operation (i.e. with data converted from YUV video to RGB) we would expect to see negative values for the RGB data, so I guess it was from some specific input tests? Regards, Paul On Sun, Aug 29, 2021 at 12:38 PM Pa

[FFmpeg-devel] [v7 PATCH 1/1] libavfilter/vf_grayworld: Add gray world filter

2021-08-29 Thread Paul Buxton
Implements a gray world color correction algorithm using a log scale LAB colorspace Signed-off-by: Paul Buxton --- doc/filters.texi | 12 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_grayworld.c | 352

Re: [FFmpeg-devel] [v6 PATCH 1/1] libavfilter/vf_grayworld: Add gray world filter

2021-08-29 Thread Paul Buxton
You're right those are unused now that the else statement is gone. Removing and checking now. Sorry this is turning into a bit of a grind! On Sun, Aug 29, 2021 at 9:12 AM Paul Buxton wrote: > Implemants a gray world color correction algorithm > using a log scale LAB colorspace &

[FFmpeg-devel] [v6 PATCH 1/1] libavfilter/vf_grayworld: Add gray world filter

2021-08-29 Thread Paul Buxton
0644 index 00..33670c369e --- /dev/null +++ b/libavfilter/vf_grayworld.c @@ -0,0 +1,362 @@ +/* + * Copyright (c) 2021 Paul Buxton + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + *

Re: [FFmpeg-devel] [PATCH 1/1] avfilter: Implement gray world color correction Uses log LAB colorspace

2021-08-29 Thread Paul Buxton
see some filters (e.g. vf_guided) are doing? I will resolve the the other issues at the same time. Anything else? On Sat, Aug 28, 2021 at 6:31 PM Paul B Mahol wrote: > > > On Fri, Aug 27, 2021 at 11:18 AM Paul Buxton < > paulbuxton.m...@googlemail.com> wrote: >

[FFmpeg-devel] What parameters are people using for git-send email

2021-08-27 Thread Paul Buxton
Hi, I am using git-prepare patch and send-email to send my patches, but don't seem to get the subject line correct. It seems to ignore the subject line I pass in except for if I use the cover letter option with prepare patch, but only applies it to the cover letter. Thanks, Paul __

[FFmpeg-devel] [PATCH 1/1] avfilter: Implement gray world color correction Uses log LAB colorspace

2021-08-27 Thread Paul Buxton
Signed-off-by: Paul Buxton --- doc/filters.texi | 12 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_grayworld.c | 362 + 5 files changed, 377 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 1/1 v5] avfilter: Implement color correction using gray world algorithm

2021-08-27 Thread Paul Buxton
Updated with more input from Paul and Andreas Paul Buxton (1): avfilter: Implement gray world color correction Uses log LAB colorspace doc/filters.texi | 12 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2

[FFmpeg-devel] [PATCH] avfilter: Implement gray world color correction Uses log LAB colorspace

2021-08-27 Thread Paul Buxton
Signed-off-by: Paul Buxton --- doc/filters.texi | 12 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_grayworld.c | 362 + 5 files changed, 377 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH] avfilter: Implement gray world color correction Uses log LAB colorspace

2021-08-27 Thread Paul Buxton
I will get there eventually! On Fri, Aug 27, 2021 at 9:06 AM Paul Buxton wrote: > Signed-off-by: Paul Buxton > --- > doc/filters.texi | 12 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/version.h | 2

[FFmpeg-devel] [PATCH] avfilter: Implement gray world color correction Uses log LAB colorspace

2021-08-27 Thread Paul Buxton
Signed-off-by: Paul Buxton --- doc/filters.texi | 12 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_grayworld.c | 361 + 5 files changed, 376 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 1/1] Implement gray world color correction uses log LAB colorspace

2021-08-26 Thread Paul Buxton
Signed-off-by: Paul Buxton --- doc/filters.texi | 12 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_grayworld.c | 368 + 5 files changed, 383 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH v2 0/1] avfilter: Add Grayworld color correction filter

2021-08-26 Thread Paul Buxton
Implementation of a grayworld color correction filter Paul Buxton (1): Implement gray world color correction uses log LAB colorspace doc/filters.texi | 12 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter

Re: [FFmpeg-devel] [PATCH 1/1] Add grayworld color correction filer

2021-08-24 Thread Paul Buxton
2021 at 7:28 PM Paul B Mahol wrote: > > > On Tue, Aug 24, 2021 at 6:58 PM Paul Buxton < > paulbuxton.m...@googlemail.com> wrote: > >> Signed-off-by: Paul Buxton >> --- >> MAINTAINERS| 1 + >> doc/filters.texi | 14 ++ >

[FFmpeg-devel] Fate Test for linear RGB filter

2021-08-24 Thread Paul Buxton
Hi, I have just submitted my first path, hopefully it should meet the contribution requirements. I did try and implement a Fate test to exercise the filter but was struggling to get them to run as it would complain about there being no path between the colorspaces. Looking through the fate tests fo

[FFmpeg-devel] [PATCH 1/1] Add grayworld color correction filer

2021-08-24 Thread Paul Buxton
Signed-off-by: Paul Buxton --- MAINTAINERS| 1 + doc/filters.texi | 14 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_grayworld.c | 401 + 6 files

[FFmpeg-devel] [PATCH 0/1] avfilter Add grayworld color correction filter

2021-08-24 Thread Paul Buxton
Implements a grayworld based color correction filter aimed at use for underwater video, but applicable to other situations Paul Buxton (1): Add grayworld color correction filer MAINTAINERS| 1 + doc/filters.texi | 14 ++ libavfilter/Makefile | 1

[FFmpeg-devel] Implementing FATE tests

2021-08-20 Thread Paul Buxton
Hi, I am a little unclear how/where to implement a test for my new filter. I see the makefile for the video filters, but it mostly looks to be command lines. Should I be adding some reference input/output data somewhere? If anyone is interested in the results of the underwater correction filter.

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul Buxton
2021 at 4:09 PM Paul B Mahol wrote: > On Sun, Aug 15, 2021 at 3:43 PM Paul Buxton < > paulbuxton.m...@googlemail.com> > wrote: > > > Thanks both. > > > > I have implemented the algorithm in this paper >

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul Buxton
Paul B Mahol wrote: > On Sun, Aug 15, 2021 at 3:27 PM Nicolas George wrote: > > > Paul Buxton (12021-08-15): > > > I have my filter working nicely but it is a little slow. I have > > > parallelised it where possible, but it is still a bit heavy. I am > > wonder

[FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul Buxton
Hi, I have my filter working nicely but it is a little slow. I have parallelised it where possible, but it is still a bit heavy. I am wondering if there are any optimised implementations/approximations of some math functions built in that I should use instead of the standard library implementation

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-11 Thread Paul Buxton
From the point of view of someone who is currently developing a filter for ffmpeg and will be submitting a patch to the list for the first time, I think this is a great idea.Whilst following simple instructions to prepare and submit a patch should't be outside the ability of anyone who is capable o

[FFmpeg-devel] Bunch of questions from a newbie.

2021-07-20 Thread Paul Buxton
Hi everyone. I am planning on doingsome work on ffmpeg. The first thing I notice is that the Ubuntu build instructions on the wiki aren't currently working with Ubuntu 20. It seems that you need to install gnutls-dev as well as unistring-dev. Is there a review process for content on the wiki, or sh