Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread Marvin Scholz
On 31 May 2025, at 21:31, Leo Izen wrote: > On 5/28/25 11:24, softworkz . wrote: >> Hello everybody, >> >> it's about 14 days ago, on Thursday, 2025-05-15, when I had applied >> my "Execution Graph Printing" patchset after 12 revisions and 3 >> reminder e-mails sent to the ML. > > Please, as a

Re: [FFmpeg-devel] Building for Mac x86 with GCC & NASM

2025-05-28 Thread Marvin Scholz
On 28 May 2025, at 10:49, softworkz . wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Martin Storsjö >> Sent: Mittwoch, 28. Mai 2025 10:27 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] Building for Mac x86 with GC

Re: [FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit messages

2025-05-27 Thread Marvin Scholz
On 3 May 2025, at 11:32, softworkz . wrote: > Hello everybody, > > I have an organizational question that I cannot quite figure out how to do it > right: > > Whether and when to add 'Reviewed-by: xxx' to a commit message? > Personally I try add this when someone reviewed and gave a LGTM for t

Re: [FFmpeg-devel] [PATCH] avfilter: add CUDA stack filters (hstack_cuda, vstack_cuda, xstack_cuda)

2025-05-26 Thread Marvin Scholz
On 23 May 2025, at 23:58, Faeez Kadiri wrote: > [...] > diff --git a/doc/filters.texi b/doc/filters.texi > index 6d2df07508..1c9afac9eb 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -26850,6 +26850,84 @@ Only deinterlace frames marked as interlaced. > The default value is @code

Re: [FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry

2025-05-23 Thread Marvin Scholz
On 23 May 2025, at 20:53, Michael Niedermayer wrote: > Hi Marvin > > On Fri, May 23, 2025 at 02:11:24AM +0200, Marvin Scholz wrote: >> --- >> libavformat/sdp.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavformat/sdp.c b/libavforma

[FFmpeg-devel] [PATCH v2] avformat/sdp: add framerate entry

2025-05-23 Thread Marvin Scholz
This also updates fate-lavf-mov_rtphint as there the SDP is included in the muxed file. --- libavformat/sdp.c | 3 +++ tests/ref/lavf/mov_rtphint | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/sdp.c b/libavformat/sdp.c index 215e38f8fc..21ada5d1ce 100

[FFmpeg-devel] [PATCH v2 1/2] avformat/rtsp: parse framerate in sdp

2025-05-23 Thread Marvin Scholz
From: Erik Linge Co-authored-by: Marvin Scholz --- libavformat/rtsp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 5ea471b40c..3f2966414f 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -618,6 +618,13 @@ static void

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtsp: parse framerate in sdp

2025-05-23 Thread Marvin Scholz
On 23 May 2025, at 18:06, Michael Niedermayer wrote: > On Fri, May 23, 2025 at 01:59:37AM +0200, Marvin Scholz wrote: >> From: Erik Linge >> >> Co-authored-by: Marvin Scholz >> --- >> libavformat/rtsp.c | 7 +++ >> 1 file changed, 7 insertions(+)

[FFmpeg-devel] [PATCH v2 2/2] avformat/rtpdec_jpeg: Set width and heigh codec parameters

2025-05-23 Thread Marvin Scholz
From: Erik Linge --- libavformat/rtpdec_jpeg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index 81036247c1..4d9ee0d754 100644 --- a/libavformat/rtpdec_jpeg.c +++ b/libavformat/rtpdec_jpeg.c @@ -233,6 +233,8 @@ static int jpeg_parse

[FFmpeg-devel] [PATCH] doc: use av_dict_iterate in documentation example

2025-05-23 Thread Marvin Scholz
--- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 2034d2aecc..feef317840 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -146,8 +146,8 @@ * consumed). The calling program ca

[FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry

2025-05-22 Thread Marvin Scholz
--- libavformat/sdp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/sdp.c b/libavformat/sdp.c index 215e38f8fc..21ada5d1ce 100644 --- a/libavformat/sdp.c +++ b/libavformat/sdp.c @@ -867,6 +867,9 @@ int ff_sdp_write_media(char *buff, int size, const AVStream *st, int idx,

[FFmpeg-devel] [PATCH 1/2] avformat/rtsp: parse framerate in sdp

2025-05-22 Thread Marvin Scholz
From: Erik Linge Co-authored-by: Marvin Scholz --- libavformat/rtsp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 5ea471b40c..6807e1d6b5 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -618,6 +618,13 @@ static void

[FFmpeg-devel] [PATCH 2/2] avformat/rtpdec_jpeg: Set width and heigh codec parameters

2025-05-22 Thread Marvin Scholz
From: Erik Linge --- libavformat/rtpdec_jpeg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index 81036247c1..4d9ee0d754 100644 --- a/libavformat/rtpdec_jpeg.c +++ b/libavformat/rtpdec_jpeg.c @@ -233,6 +233,8 @@ static int jpeg_parse

[FFmpeg-devel] [PATCH] avformat/http: Handle IPv6 Zone ID in hostname

2025-05-22 Thread Marvin Scholz
When using a literal IPv6 address as hostname, it can contain a Zone ID especially in the case of link-local addresses. Sending this to the server in the Host header is not useful to the server and in some cases servers refuse such requests. To prevent any such issues, strip the Zone ID from the a

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str

2025-05-22 Thread Marvin Scholz
On 22 May 2025, at 18:57, Tristan Matthews wrote: > --- > doc/examples/filter_audio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/doc/examples/filter_audio.c b/doc/examples/filter_audio.c > index 8b237e2adf..0f5914 100644 > --- a/doc/examples/filter_audio.c > +

[FFmpeg-devel] [PATCH] lavfi: add noop multimedia filter

2025-05-19 Thread Marvin Scholz
This filter does nothing, it is mainly useful during development/debugging and demonstrates a simple case of a mixed-input filter. --- doc/filters.texi | 20 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_noop.c | 247 +++

[FFmpeg-devel] [PATCH] avformat/rtsp: add TLS options

2025-05-06 Thread Marvin Scholz
From: Daniel N Pettersson Add TLS options to RTSP for when TLS is used for the lower protocol. Signed-off-by: Marvin Scholz Co-authored-by: Marvin Scholz --- libavformat/rtsp.c | 30 +- libavformat/rtsp.h | 9 + 2 files changed, 38 insertions(+), 1

[FFmpeg-devel] [PATCH] avcodec/pcm-dvdenc: always assert switch default cases

2025-05-05 Thread Marvin Scholz
Fixes the following warning when building with assertions disabled: warning: variable 'quant' is used uninitialized whenever switch default is taken --- libavcodec/pcm-dvdenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-

[FFmpeg-devel] [PATCH] avformat/apvdec: remove unused variable

2025-05-05 Thread Marvin Scholz
--- libavformat/apvdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/apvdec.c b/libavformat/apvdec.c index e53c9ed085..1e5497bcd3 100644 --- a/libavformat/apvdec.c +++ b/libavformat/apvdec.c @@ -53,7 +53,6 @@ static int apv_extract_header_info(GetByteContext *gbc) if (inf

[FFmpeg-devel] [PATCH 2/2] rtpdec: Set bitrate for pcm-mulaw audio

2025-05-05 Thread Marvin Scholz
From: Erik Linge Signed-off-by: Marvin Scholz Co-authored-by: Marvin Scholz --- libavformat/rtpdec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c index 10e9502ae2..9d3014b0e0 100644 --- a/libavformat/rtpdec.c +++ b/libavformat/rtpdec.c

[FFmpeg-devel] [PATCH 1/2] rtpdec: add fmtp parsing of sprop-maxcapturerate for opus

2025-05-05 Thread Marvin Scholz
From: Erik Linge Co-authored-by: Marvin Scholz Signed-off-by: Marvin Scholz --- libavformat/Makefile | 1 + libavformat/rtpdec.c | 8 + libavformat/rtpdec_formats.h | 1 + libavformat/rtpdec_opus.c| 62 4 files changed, 65

Re: [FFmpeg-devel] [PATCH] configure: Enable -fno-common for Darwin targets, avoid linker warnings

2025-05-05 Thread Marvin Scholz
On 5 May 2025, at 10:45, Martin Storsjö wrote: > On Fri, 2 May 2025, Martin Storsjö wrote: > >> On Tue, 29 Apr 2025, Martin Storsjö wrote: >> >>> Since GCC 10 and llvm.org Clang 11, -fno-common is the default. >>> However Apple's Xcode Clang hasn't followed suit yet, and still >>> defaults to -f

Re: [FFmpeg-devel] [PATCH] postproc/tests: Add test tools to .gitignore

2025-04-28 Thread Marvin Scholz
On 28 Apr 2025, at 16:02, Andreas Rheinhardt wrote: > Patch attached. > LGTM > - Andreas > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffm

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/hls: Show error info when read key file failed

2025-04-24 Thread Marvin Scholz
On 24 Apr 2025, at 5:54, Zhao Zhili wrote: > From: Zhao Zhili > > --- > libavformat/hls.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 6623c80309..6139b8525e 100644 > --- a/libavformat/hls.c > +++ b/li

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hls: Show error info when read key file failed

2025-04-23 Thread Marvin Scholz
On 23 Apr 2025, at 14:59, Zhao Zhili wrote: > From: Zhao Zhili > > --- > libavformat/hls.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 6623c80309..45c1b283c9 100644 > --- a/libavformat/hls.c > +++ b/libavf

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/f_sendcmd: clear Command on alloc failure

2025-04-22 Thread Marvin Scholz
On 30 Jan 2025, at 1:25, Marvin Scholz wrote: > If the command array failed to allocate, the current parsed > Command has to be cleared, else memory allocated for it > would be leaked. > > Fix CID 1638635 > --- I intend to push the set in a few days, if no one has comm

[FFmpeg-devel] [RFC PATCH 2/2] ffmpeg_demux: make readrate stall warning input-specific

2025-04-22 Thread Marvin Scholz
Given the readrate catchup is input-specific, it seems to make sense to also warn on a per-input demux basis. --- fftools/ffmpeg_demux.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 6e01efc420..1f7ec20a43 100644 --

[FFmpeg-devel] [PATCH 1/2] ffmpeg_demux: init resume_warn variable

2025-04-22 Thread Marvin Scholz
Fixes an uninitialized read introduced with 6232f416b172358c9dd82462037953f02743df27 Fix CID1643162 Uninitialized scalar variable --- fftools/ffmpeg_demux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index cb4318c75b..6e01ef

Re: [FFmpeg-devel] [PATCH] avformat: Fix AV1 RTP wrong log condition

2025-04-05 Thread Marvin Scholz
On 1 Apr 2025, at 11:26, Chris Hodges wrote: > Fixed warning about OBU count being wrong, which can only be > determined when the number of OBUs in the header is non-zero, > not the other way round. > > Signed-off-by: Chris Hodges > --- > libavformat/rtpdec_av1.c | 2 +- > 1 file changed, 1 inse

Re: [FFmpeg-devel] [PATCH] rtpdec_mpeg4: Add fmtp parsing of bitrate value

2025-04-05 Thread Marvin Scholz
On 26 Sep 2022, at 21:24, Marvin Scholz wrote: > According to RFC 6416 the audio stream sender can pass the data rate > for the audio bitstream as "bitrate=" media format parameter. > > Signed-off-by: Marvin Scholz > --- Somehow the correct author line got lost when

[FFmpeg-devel] [PATCH] avfilter/drawutils: narrow variable scopes

2025-04-01 Thread Marvin Scholz
--- libavfilter/drawutils.c | 85 +++-- 1 file changed, 39 insertions(+), 46 deletions(-) diff --git a/libavfilter/drawutils.c b/libavfilter/drawutils.c index c3d4bb0a25..6f7dca021b 100644 --- a/libavfilter/drawutils.c +++ b/libavfilter/drawutils.c @@ -48,8 +48

[FFmpeg-devel] [PATCH 6/7] tools/sidxindex: use av_err2str

2025-04-01 Thread Marvin Scholz
There is no need to explicitly specify the buffer, as it is only ever passed to fprintf, so av_err2str can be used. --- tools/sidxindex.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/sidxindex.c b/tools/sidxindex.c index 3e43d95e02..96b1fce8c4 100644 --- a/tool

[FFmpeg-devel] [PATCH 5/7] tools/ismindex: use av_err2str

2025-04-01 Thread Marvin Scholz
There is no need to explicitly specify the buffer, as it is only ever passed to fprintf, so av_err2str can be used. --- tools/ismindex.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tools/ismindex.c b/tools/ismindex.c index 6fe68d8a79..b110420bf0 100644 --- a/to

[FFmpeg-devel] [PATCH 7/7] tools/aviocat: use av_err2str

2025-04-01 Thread Marvin Scholz
There is no need to explicitly specify the buffer, as it is only ever passed to fprintf, so av_err2str can be used. --- tools/aviocat.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tools/aviocat.c b/tools/aviocat.c index 816ab700ef..7f8a247f1c 100644 --- a/tool

[FFmpeg-devel] [PATCH 4/7] tests: lavfi/drawutils: use av_err2str

2025-04-01 Thread Marvin Scholz
There is no need to explicitly specify the buffer, as it is only ever passed to printf, so av_err2str can be used. --- libavfilter/tests/drawutils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/tests/drawutils.c b/libavfilter/tests/drawutils.c index 7fe53ddf31

[FFmpeg-devel] [PATCH 3/7] lavfi/vf_xpsnr: use av_err2str

2025-04-01 Thread Marvin Scholz
There is no need to explicitly specify the buffer, as it is only ever passed to av_log, so av_err2str can be used. --- libavfilter/vf_xpsnr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_xpsnr.c b/libavfilter/vf_xpsnr.c index 3097db0878..34c875456e 100644

[FFmpeg-devel] [PATCH 2/7] avformat/crypto: use av_err2str

2025-04-01 Thread Marvin Scholz
There is no need to explicitly specify the buffer, as it is only ever passed to av_log, so av_err2str can be used. --- libavformat/crypto.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/crypto.c b/libavformat/crypto.c index 868f6ddc25..da8aa0f0ec 100644 --- a/l

[FFmpeg-devel] [PATCH 1/7] avformat/dashdec: use av_err2str

2025-04-01 Thread Marvin Scholz
There is no need to explicitly specify the buffer, as it is only ever passed to av_log, so av_err2str can be used. --- libavformat/dashenc.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index d4a6fe0304..af92e38bbd 10064

[FFmpeg-devel] [PATCH] ffbuild: fix include path for uninstalled .pc files

2025-03-31 Thread Marvin Scholz
--- ffbuild/pkgconfig_generate.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffbuild/pkgconfig_generate.sh b/ffbuild/pkgconfig_generate.sh index e5de6716d2..fc6af774a6 100755 --- a/ffbuild/pkgconfig_generate.sh +++ b/ffbuild/pkgconfig_generate.sh @@ -50,7 +50,7 @@ included

Re: [FFmpeg-devel] [PATCH] rtpdec_mpeg4: Add fmtp parsing of bitrate value

2025-03-31 Thread Marvin Scholz
On 26 Sep 2022, at 21:24, Marvin Scholz wrote: > According to RFC 6416 the audio stream sender can pass the data rate > for the audio bitstream as "bitrate=" media format parameter. > > Signed-off-by: Marvin Scholz If there are no comments / objections I intend to p

Re: [FFmpeg-devel] [PATCH] configure: Allow mixing declarations and statements

2025-03-30 Thread Marvin Scholz
On 30 Mar 2025, at 17:37, Andreas Rheinhardt wrote: > Patch attached. > Yes please, +1 to this. > - Andreas > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link ab

[FFmpeg-devel] [PATCH] rtpdec_mpeg4: Add fmtp parsing of bitrate value

2025-03-20 Thread Marvin Scholz
According to RFC 6416 the audio stream sender can pass the data rate for the audio bitstream as "bitrate=" media format parameter. Signed-off-by: Marvin Scholz --- libavformat/rtpdec_mpeg4.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/rtpdec_mpeg4.c b/l

Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files

2025-03-18 Thread Marvin Scholz
On 18 Mar 2025, at 16:49, Gyan Doshi wrote: > --- > configure | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/configure b/configure > index d84e32196d..14f7bcde0e 100755 > --- a/configure > +++ b/configure > @@ -5230,12 +5230,6 @@ else > ar_o='$@' >

Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids

2025-03-11 Thread Marvin Scholz
On 6 Mar 2025, at 19:16, Soft Works wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of Marvin >> Scholz >> Sent: Donnerstag, 6. März 2025 18:49 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids

2025-03-11 Thread Marvin Scholz
On 6 Mar 2025, at 18:02, Soft Works wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Nicolas George >> Sent: Donnerstag, 6. März 2025 11:09 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log >>

Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids

2025-03-08 Thread Marvin Scholz
On 6 Mar 2025, at 18:44, Soft Works wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of Marvin >> Scholz >> Sent: Donnerstag, 6. März 2025 18:38 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids

2025-03-06 Thread Marvin Scholz
On 6 Mar 2025, at 20:27, Soft Works wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of Marvin >> Scholz >> Sent: Donnerstag, 6. März 2025 19:59 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH] doc/metadata.texi: Start documenting keys

2025-03-04 Thread Marvin Scholz
On 4 Mar 2025, at 12:36, Andreas Rheinhardt wrote: > Tomas Härdin: >> +@item ref-frame-config @tab @tab @tab >> +@item reverb @tab S @tab argo_cvg @tab > > The first is libvp9enc-only, the second argo_cvg only. IMO it is better > to document this at the documentation of the relevant encoder and

[FFmpeg-devel] [PATCH 2/2] lavfi/f_sendcmd: clear Command on alloc failure

2025-01-29 Thread Marvin Scholz
If the command array failed to allocate, the current parsed Command has to be cleared, else memory allocated for it would be leaked. Fix CID 1638635 --- libavfilter/f_sendcmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c index 8a0c368108..

[FFmpeg-devel] [PATCH 1/2] lavfi/f_sendcmd: add helper to clear Command

2025-01-29 Thread Marvin Scholz
Makes clearing the Command more explicit and consistent. --- libavfilter/f_sendcmd.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c index d5d72e6410..8a0c368108 100644 --- a/libavfilter/f_sendcmd.c +++ b/l

Re: [FFmpeg-devel] [PATCH v2 1/2] Parse ogg/flac header again after processing a new chained ogg bitstream.

2025-01-29 Thread Marvin Scholz
On 29 Jan 2025, at 15:40, Romain Beauxis wrote: > This patch makes sure that ogg/flac headers are parsed again when > encountering a new logic stream inside a chained ogg bistream[1]. > > This patches makes it possible to retrieve metadata in chained ogg/flac > bitstreams. It is particularly imp

Re: [FFmpeg-devel] Your message to ffmpeg-devel awaits moderator approval

2024-12-19 Thread Marvin Scholz
do this revoked immediately as this is a clear abuse of admin powers. (Even if the current CC had decided to do this, this is something that HAS to be transparently communicated at the very least.) Sincerely, Marvin Scholz > > -- > Anton Khirnov > _

[FFmpeg-devel] [PATCH] avcodec/libaomenc: fix use after free of sidedata

2024-11-27 Thread Marvin Scholz
Move the ff_dovi_configure to happen before ff_encode_add_cpb_side_data as the former reallocates the sidedata so the pointer returned from ff_encode_add_cpb_side_data would be invalid. --- libavcodec/libaomenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcode

[FFmpeg-devel] [PATCH 2/2] lavfi: Add libspatialaudio filter

2024-11-25 Thread Marvin Scholz
dio_c.o af_libspatialaudio.o OBJS-$(CONFIG_LV2_FILTER)+= af_lv2.o OBJS-$(CONFIG_MCOMPAND_FILTER) += af_mcompand.o OBJS-$(CONFIG_PAN_FILTER)+= af_pan.o diff --git a/libavfilter/af_libspatialaudio.cpp b/libavfilter/af_libspatial

[FFmpeg-devel] [PATCH 1/2] configure: add {test, check, require}_pkg_config_cxx

2024-11-25 Thread Marvin Scholz
This is necessary to check for C++ only pkg-config dependencies --- configure | 33 + 1 file changed, 33 insertions(+) diff --git a/configure b/configure index 5dd7964fdf..ff26aa2da7 100755 --- a/configure +++ b/configure @@ -1551,6 +1551,26 @@ test_pkg_config_cpp(

[FFmpeg-devel] [PATCH] swscale/internal: fix typo in loongarch specific code

2024-11-24 Thread Marvin Scholz
Regression from 2d077f9acda4946b3455ded5778fb3fc7e85bba2 --- libswscale/loongarch/swscale_init_loongarch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/loongarch/swscale_init_loongarch.c b/libswscale/loongarch/swscale_init_loongarch.c index 843fa08196..5204a8b66d

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as Darwin maintainer

2024-11-24 Thread Marvin Scholz
/ CPU architectures Alpha [0] MIPSManojkumar Bhosale, Shiyou Yin LoongArch [2] Shiyou Yin +Darwin (macOS, iOS) [2] Marvin Scholz Mac OS X / PowerPC Romain Dolbeau

[FFmpeg-devel] [PATCH 1/2] configure: add {test, check, require}_pkg_config_cxx

2024-10-25 Thread Marvin Scholz
This is necessary to check for C++ only pkg-config dependencies --- configure | 33 + 1 file changed, 33 insertions(+) diff --git a/configure b/configure index 9f508a2527..6fb163aa84 100755 --- a/configure +++ b/configure @@ -1551,6 +1551,26 @@ test_pkg_config_cpp(

[FFmpeg-devel] [PATCH 2/2] lavfi: Add libspatialaudio filter

2024-10-25 Thread Marvin Scholz
ibspatialaudio.o OBJS-$(CONFIG_LV2_FILTER)+= af_lv2.o OBJS-$(CONFIG_MCOMPAND_FILTER) += af_mcompand.o OBJS-$(CONFIG_PAN_FILTER)+= af_pan.o diff --git a/libavfilter/af_libspatialaudio.cpp b/libavfilter/af_libspatialaudio.cpp new file mode 10064

[FFmpeg-devel] [PATCH] avcodec/hw_base_encode: fix use after free on close

2024-10-17 Thread Marvin Scholz
The way the linked list of images was freed caused a use after free, by accessing pic->next after pic was already freed. Regression from 48a1a12968345bf673db1e1cbb5c64bd3529c50c Fix CID1633236 --- libavcodec/hw_base_encode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH] avfilter: fix unused variable warning

2024-10-13 Thread Marvin Scholz
The ctxi_dst variable is unused outside of the av_assert1, causing an unused variable warning. The simplest solution for this is to avoid the intermediate variable here. --- libavfilter/avfilter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/avfilter.c b/libavf

[FFmpeg-devel] [PATCH] libavutil/vulkan: fix flexible array struct allocation

2024-10-08 Thread Marvin Scholz
The flexible array member struct can have padding added by the compiler which was not taken into account properly, which could lead to a heap buffer overflow. --- libavutil/vulkan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index cd

[FFmpeg-devel] [PATCH v2 2/2] fftools: log unconnected filter output label

2024-10-03 Thread Marvin Scholz
--- fftools/ffmpeg_filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index ddcd18dd15..b1ca710999 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1410,7 +1410,9 @@ int fg_finalise_bindings(void)

[FFmpeg-devel] [PATCH v2 1/2] fftools: do not access out of bounds filtergraph

2024-10-03 Thread Marvin Scholz
The log message was logged for `filtergraphs[j]` which would cause a heap buffer overflow in certain circumstances. Correctly it should be logged for the current filtergraph, so just use `fg` here. --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fft

[FFmpeg-devel] [PATCH 1/2] fftools: do not access out of bounds filtergraph

2024-09-30 Thread Marvin Scholz
The log message was logged for `filtergraphs[j]` which would cause a heap buffer overflow in certain circumstances. Correctly it should be logged for the current filtergraph, so just use `fg` here. --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fft

[FFmpeg-devel] [PATCH 2/2] fftools: log unconnected filter output label

2024-09-30 Thread Marvin Scholz
--- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index e9271e74ed..01e3c087dd 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1410,7 +1410,7 @@ int fg_finalise_bindings(void)

[FFmpeg-devel] [PATCH 2/2] configure: allow mixed declarations and code for Objective-C

2024-09-25 Thread Marvin Scholz
Mixing declarations and code is quite common in Objective-C (as can be seen by the number of warnings we have for this in Objective-C files) and forcing to not do it usually results in worse code, with unnecessary widely scoped variables, which in turn makes variable shadowing and accidentally usin

[FFmpeg-devel] [PATCH 1/2] configure: fix passing Objective-C flags

2024-09-25 Thread Marvin Scholz
Passing Objective-C flags from configure to the Makefiles was broken, as configure incorrectly used the OBJCCFLAGS instead of OBJCFLAGS variable which was then later overwritten in the common.mak: OBJCCFLAGS = $(CPPFLAGS) $(CFLAGS) $(OBJCFLAGS) The fix for this is simple, analogous to how it i

[FFmpeg-devel] [PATCH] configure: do not use interval regexp operators with awk

2024-09-19 Thread Marvin Scholz
Some awk implementations like mawk (used on Ubuntu) do not support these. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d872213af7a..d568739bf90 100755 --- a/configure +++ b/configure @@ -6150,11 +6150,11 @@ enable_weak_pic() { enabl

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h265: fix missing slice_block_cols assignment

2024-09-19 Thread Marvin Scholz
Instead of assigning to unit_opts.slice_block_cols, the slice_block_cols value from the context was incorrectly assigned to slice_block_rows. Regression from 12f158ca8f2ecc172f27569af88426d0e39ce995 Fixes CID1619479 Unused value --- libavcodec/vaapi_encode_h265.c | 2 +- 1 file changed, 1 insert

[FFmpeg-devel] [PATCH v2 2/2] doc: add styles for good/bad code examples

2024-09-13 Thread Marvin Scholz
Makes it easier to immediately see if the code examples given in the style documentation are good or bad examples, making it harder to accidentally confuse a bad example for a good one. --- doc/style.min.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/style.min.css b/do

[FFmpeg-devel] [PATCH v2 1/2] doc/developer: add examples to clarify code style

2024-09-13 Thread Marvin Scholz
Given the frequency that new developers, myself included, get the code style wrong, it is useful to add some examples to clarify how things should be done. --- doc/developer.texi | 101 - 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/doc

Re: [FFmpeg-devel] [PATCH] lavc: Fix epirats suggestions

2024-09-12 Thread Marvin Scholz
> Signed-off-by: Petro Mozil […] Thanks, Marvin Scholz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v3 2/2] configure: correctly set sanitizer toolchain compilers

2024-09-12 Thread Marvin Scholz
Previously only the C compiler was set, which would lead to confusing situations where even though clang-asan was selected, it would still use g++ for C++ code, failing because configure does not support mixing compilers in this way (which is a separate issue not addressed by this commit). --- con

[FFmpeg-devel] [PATCH v3 1/2] configure: fix symbol prefix detection

2024-09-12 Thread Marvin Scholz
The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to onl

[FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: fix leaks on error

2024-09-11 Thread Marvin Scholz
In case of errors in this function, the allocated context was not properly freed in several cases. --- libavdevice/decklink_dec.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9a817daf187..418701

[FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: fix leak on error

2024-09-11 Thread Marvin Scholz
In the early return when both draw_bars and signal_loss_action options are used, the context allocated previously was not properly freed. Introduced in 9bcb86b0fa58f1a5a2a8613065349e26abadb329 Fixes CID1619296 --- libavdevice/decklink_dec.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/l

[FFmpeg-devel] [PATCH v2] configure: fix symbol prefix detection

2024-09-11 Thread Marvin Scholz
The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to o

[FFmpeg-devel] [PATCH] configure: fix symbol prefix detection

2024-09-11 Thread Marvin Scholz
The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to o

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as vf_xfade_vulkan maintainer

2024-09-11 Thread Marvin Scholz
Ruiling Song vf_yadif.c[2] Michael Niedermayer + vf_xfade_vulkan.c [2] Marvin Scholz (CC ) Sources: vsrc_mandelbrot.c [2] Michael Niedermayer base-commit: a15d2fdfd96c0ce711e0be3fe6c2f47b5a39b931 -- 2.39.3 (Apple Git-146

[FFmpeg-devel] [PATCH] lavfi/af_channelmap: fix channelmap_init error handling

2024-09-11 Thread Marvin Scholz
The channelmap_init function was returning success even on error after 7dc81d33c241b9e176ea85956e8317f29bc9e3c0 due to shadowing of the outer ret variable. Fixes CID1619297 Logically dead code --- libavfilter/af_channelmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liba

[FFmpeg-devel] [PATCH 60/60] avfilter/drawutils: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavfilter/drawutils.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/drawutils.c b/libavfilter/drawutils.c index 95525d38b4..b29d3e565e 100644 --- a/libavfilter/drawutils.c +++ b/libavfilter/drawutils.c @@ -156,7 +156,6 @@ int ff_draw_init(FFDrawContext *dr

[FFmpeg-devel] [PATCH 59/60] avformat/apetag: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/apetag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/apetag.c b/libavformat/apetag.c index 0989fcb094..84645607de 100644 --- a/libavformat/apetag.c +++ b/libavformat/apetag.c @@ -81,7 +81,7 @@ static int ape_tag_read_field(AVFormatContext *s)

[FFmpeg-devel] [PATCH 58/60] avformat/avio: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/avio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index d109f3adff..fd767c9ba9 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -57,7 +57,7 @@ static void *urlcontext_child_next(void *obj, void *prev)

[FFmpeg-devel] [PATCH 57/60] avformat/bonk: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/bonk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/bonk.c b/libavformat/bonk.c index 44de8e2087..d5eacfdc91 100644 --- a/libavformat/bonk.c +++ b/libavformat/bonk.c @@ -63,7 +63,7 @@ static int bonk_read_header(AVFormatContext *s) const

[FFmpeg-devel] [PATCH 56/60] avformat/http: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index ec60bc0b17..22e4126790 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -150,7 +150,7 @@ typedef struct HTTPContext { #define E AV_OPT_FLAG_ENCOD

[FFmpeg-devel] [PATCH 55/60] avformat/img2enc: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/img2enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 526a11e5ee..ae239d27ea 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c @@ -224,7 +224,7 @@ static int write_packet(AVFormatContext *s, AV

[FFmpeg-devel] [PATCH 54/60] avformat/matroskadec: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/matroskadec.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index c8741ff2af..60b20e9658 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -1281,8 +1281,8 @@ static int

[FFmpeg-devel] [PATCH 53/60] avformat/nsvdec: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/nsvdec.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c index dd01765d7d..a55da05226 100644 --- a/libavformat/nsvdec.c +++ b/libavformat/nsvdec.c @@ -380,7 +380,7 @@ static int nsv_parse_

[FFmpeg-devel] [PATCH 52/60] avformat/mxfdec: narrow variable scopes

2024-09-08 Thread Marvin Scholz
--- libavformat/mxfdec.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index eb7d301444..8a83bdfa04 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -482,9 +482,7 @@ static int kl

[FFmpeg-devel] [PATCH 51/60] avformat/mxfdec: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/mxfdec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index ac63c0d5ad..eb7d301444 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -871,16 +871,16 @@ static int mxf_read_partition_

[FFmpeg-devel] [PATCH 50/60] avformat/rawdec: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/rawdec.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/rawdec.c b/libavformat/rawdec.c index d0c829dc42..c7c18f9aac 100644 --- a/libavformat/rawdec.c +++ b/libavformat/rawdec.c @@ -161,12 +161,11 @@ const FFInputFormat ff_data_demuxer = { #i

[FFmpeg-devel] [PATCH 48/60] avformat/tee: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/tee.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/tee.c b/libavformat/tee.c index 1a2a8ead82..7ec9ab4800 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -65,7 +65,7 @@ static const char *const slave_bsfs_spec_sep = "/"; static cons

[FFmpeg-devel] [PATCH 49/60] avformat/srtpproto: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/srtpproto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/srtpproto.c b/libavformat/srtpproto.c index 02cf156327..cf6064625c 100644 --- a/libavformat/srtpproto.c +++ b/libavformat/srtpproto.c @@ -37,7 +37,7 @@ typedef struct SRTPProtoContext {

[FFmpeg-devel] [PATCH 47/60] avformat/yuv4mpegdec: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/yuv4mpegdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c index 2b66a1e596..61b5a9e17b 100644 --- a/libavformat/yuv4mpegdec.c +++ b/libavformat/yuv4mpegdec.c @@ -36,7 +36,7 @@ static int yuv4_read_hea

[FFmpeg-devel] [PATCH 46/60] avformat/vividas: narrow variable scopes

2024-09-08 Thread Marvin Scholz
--- libavformat/vividas.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index 4cad6c6456..e984dd0b21 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@ -282,7 +282,7 @@ static uint8_t *read_

[FFmpeg-devel] [PATCH 45/60] avformat/vividas: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/vividas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index 130b81ebbe..4cad6c6456 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@ -417,7 +417,7 @@ static int track_header(VividasDemuxContext *v

[FFmpeg-devel] [PATCH 44/60] avformat/vorbiscomment: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/vorbiscomment.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/vorbiscomment.c b/libavformat/vorbiscomment.c index abe12fd586..af51c237e6 100644 --- a/libavformat/vorbiscomment.c +++ b/libavformat/vorbiscomment.c @@ -62,7 +62,7 @@ int64_t ff

[FFmpeg-devel] [PATCH 43/60] avformat/webmdashenc: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/webmdashenc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index 3d9badc0d3..a4940dd1c5 100644 --- a/libavformat/webmdashenc.c +++ b/libavformat/webmdashenc.c @@ -382,11 +382,11 @@ static int writ

[FFmpeg-devel] [PATCH 42/60] avformat/webpenc: fix variable shadowing

2024-09-08 Thread Marvin Scholz
--- libavformat/webpenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c index ce0d046aa9..5d0eed5a8e 100644 --- a/libavformat/webpenc.c +++ b/libavformat/webpenc.c @@ -163,7 +163,6 @@ static int webp_write_packet(AVFormatContext *s, AVPacket *pkt

  1   2   3   4   5   >