PR #20541 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20541
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20541.patch
- Fix leading space in the RTSP reason string
- Avoid logging invalid values and instead properly log warnings on failure
reading
On 16 Sep 2025, at 10:49, Michael Niedermayer wrote:
> Hi all
>
> 2 months ago we voted on testing Forgejo vs Gitlab, we picked and tested
> Forgejo. And as said in that vote, (and surprisingly, i have not forgotten it)
> heres the "after testing" discussion and vote
>
> do we want to keep Forgejo
PR #20525 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20525
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20525.patch
Fixes an issue uncovered since 0ce413af9cc8040095a6b714600d6a8dceaca514
where flags were properly separated but without the
PR #20496 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20496
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20496.patch
>From 8fbd564bed9ee358b7d376e80197253283c55679 Mon Sep 17 00:00:00 2001
From: Zhao Zhili
Date: Mon, 1 Sep 2025 01:17:08 +0
PR #20472 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20472
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20472.patch
Should fix #11240
>From 9147a2603a3465100ae05d98a0f0e2577def6e7e Mon Sep 17 00:00:00 2001
From: Marvin Scholz
Date: Tue, 9
PR #20349 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20349
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20349.patch
This PR is a proposal for a new API in `libavformat`, which I call the command
API, it adds the ability to send commands to
PR #20311 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20311
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20311.patch
This makes it more clear that it will be removed in a future release.
>From a6c578ef6555fdb0af0789f8fc673f9188f4b0ec Mon Sep 17
PR #20312 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20312
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20312.patch
Improves grouping and brief descriptions for AVCodecParameters.
>From 0e610267507db4b657669e6da442ed58798a8680 Mon Sep 17 00:00
PR #20310 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20310
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20310.patch
The use of this protocol was already discouraged and warned about
for years with the recommendation to use the HLS demuxer instead
PR #20250 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20250
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20250.patch
The previous fix in 0ffe97d9b9e10e88db29d8d910c24ec00ef24edc only
checked the count, which is not sufficient. In case there is an
PR #20245 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20245
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20245.patch
When dimensions differ from context, those were updated using
ff_set_dimensions, however this overwrote the aligned coded_width and
On 10 Jul 2025, at 13:51, Marvin Scholz wrote:
> When no explicit CAs file is set, load the default locations,
> else there is no way for verification to succeed.
>
> This matches the behavior of other TLS backends.
> ---
> libavformat/tls_openssl.c | 6 ++
> 1 file
st worth a try to go
that route.
Note also that it doesn't mean anything is set in stone, we could change again
if it turns
out Forgejo doesn't work well for us…
Sorry for the long email, have a nice start of the week everyone!
Regards,
Marvin Scholz
__
On 11 Jul 2025, at 11:07, Vittorio Palmisano wrote:
> It adds a new audio filter for running audio transcriptions with the whisper
> model.
> Documentation and examples are included into the patch.
>
> Signed-off-by: Vittorio Palmisano
> ---
> configure| 5 +
> doc/filters.t
The use of this protocol was already discouraged and warned about
for years with the recommendation to use the HLS demuxer instead.
---
Changelog | 1 +
doc/protocols.texi | 20 ---
libavformat/Makefile| 2 -
libavformat/hlsproto.c | 318 ---
On 25 Jun 2025, at 23:39, Tristan Matthews via ffmpeg-devel wrote:
> On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt
> wrote:
>
> Tristan Matthews via ffmpeg-devel:
>
> On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt
> andreas.rheinha...@outlook.com wrote:
>
> Patch attac
This makes these functions appear in the AVCodecParameters
documentation page, so they are easier to find.
---
libavcodec/avcodec.h | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index a004cccd2d..a1d82cb9a9 100644
--- a/libavcodec/avcodec.h
+++
Mostly adding references and making the video/audio only
annotations not be the brief description.
---
libavcodec/codec_par.h | 123 -
1 file changed, 84 insertions(+), 39 deletions(-)
diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h
index f4b9b
On 7 Jul 2025, at 13:15, Andreas Rheinhardt wrote:
> Marvin Scholz:
>> From: Daniel N Pettersson
>>
>> Add TLS options to RTSP for when TLS is used for the lower protocol.
>>
>> Signed-off-by: Marvin Scholz
>> Co-authored-by: Marvin Sch
On 10 Jul 2025, at 12:51, Marvin Scholz wrote:
> On 8 Jul 2025, at 17:09, Marvin Scholz wrote:
>
>> ---
>> libavformat/rtsp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
>> in
When no explicit CAs file is set, load the default locations,
else there is no way for verification to succeed.
This matches the behavior of other TLS backends.
---
libavformat/tls_openssl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open
---
libavformat/tls_openssl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 8abe15ae55..33b3a46dfd 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -930,7 +930,11 @@ static int tls_open(
From: Daniel N Pettersson
When verification is enabled (using -tls_verify 1) now
the hostname will be verified properly too, while before
only other aspects of the certificate were checked.
Co-Authored-By: Marvin Scholz
---
libavformat/tls_openssl.c | 15 ---
1 file changed, 12
On 8 Jul 2025, at 20:33, Kieran Kunhya via ffmpeg-devel wrote:
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.
On 8 Jul 2025, at 21:16, Marvin Scholz wrote:
> On 8 Jul 2025, at 10:49, Peter Ross wrote:
>
>> Fixes CID1655273 and CID1655274.
>> ---
>> v2: Use the new av_unreachable() macro
>>
>> libavcodec/adpcm.c | 4
>> 1 file changed, 4 insertions(
On 8 Jul 2025, at 20:53, Marvin Scholz wrote:
> From: Daniel N Pettersson
>
> When verification is enabled (using -tls_verify 1) now
> the hostname will be verified properly too, while before
> only other aspects of the certificate were checked.
>
> Co-Autho
On 8 Jul 2025, at 17:09, Marvin Scholz wrote:
> ---
> libavformat/rtsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index 8d360b375f..6201f09136 100644
> --- a/libavformat/rtsp.c
> +++ b/libavf
On 10 Jul 2025, at 10:34, Vittorio Palmisano wrote:
> Thanks Michael, I will try to answer your comments.
>
>>> +ffmpeg -i input.mp4 -vn -af
>>> "aformat=sample_rates=16000:channel_layouts=mono,whisper=
>>
>> Is there a reason why we convert to 16khz mono here ?
>
> It is the only format suppo
On 9 Jul 2025, at 9:23, Vittorio Palmisano wrote:
> It adds a new audio filter for running audio transcriptions with the whisper
> model.
> Documentation and examples are included into the patch.
>
> Signed-off-by: Vittorio Palmisano
> ---
> configure| 5 +
> doc/filters.tex
On 9 Jul 2025, at 11:18, Steven Liu wrote:
> Marvin Scholz 于2025年7月9日周三 03:14写道：
> Hi Marvin,
>
>>
>> The use of this protocol was already discouraged and warned about
>> for years with the recommendation to use the HLS demuxer instead.
> What about make deprecat
On 8 Jul 2025, at 10:49, Peter Ross wrote:
> Fixes CID1655273 and CID1655274.
> ---
> v2: Use the new av_unreachable() macro
>
> libavcodec/adpcm.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
> index 92ab248f3d..83ef7c780a 100644
> --- a/
The use of this protocol was already discouraged and warned about
for years with the recommendation to use the HLS demuxer instead.
---
doc/protocols.texi | 20 ---
libavformat/Makefile| 2 -
libavformat/hlsproto.c | 318
libavformat/protocols.
On 8 Jul 2025, at 20:33, Nicolas George wrote:
> Marvin Scholz (HE12025-07-08):
>> That's already possible with `-tls_verify 0`
>
> Then the commit message inadequately explains what the patch does.
> Please clarify.
Sure, I will add a more verbose message.
However not
When no explicit CAs file is set, load the default locations,
else there is no way for verification to succeed.
This matches the behavior of other TLS backends.
---
libavformat/tls_openssl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open
---
libavformat/tls_openssl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 7f10d80f9e..248d1eedf9 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -927,7 +927,11 @@ static int tls_open(
From: Daniel N Pettersson
When verification is enabled (using -tls_verify 1) now
the hostname will be verified properly too, while before
only other aspects of the certificate were checked.
Co-Authored-By: Marvin Scholz
---
libavformat/tls_openssl.c | 12 +---
1 file changed, 9
---
libavformat/tls_openssl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 7f10d80f9e..248d1eedf9 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -927,7 +927,11 @@ static int tls_open(
When no explicit CAs file is set, load the default locations,
else there is no way for verification to succeed.
This matches the behavior of other TLS backends.
---
libavformat/tls_openssl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open
From: Daniel N Pettersson
Co-Authored-By: Marvin Scholz
---
libavformat/tls_openssl.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index a0fa3285d5..7f10d80f9e 100644
--- a/libavformat/tls_openssl.c
+++ b
On 8 Jul 2025, at 20:16, Nicolas George wrote:
> Marvin Scholz (HE12025-07-08):
>> ---
>> libavformat/tls_openssl.c | 6 +-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
>&
On 8 Jul 2025, at 20:21, Nicolas George wrote:
> Marvin Scholz (HE12025-07-08):
>> Can you clarify?
That's already possible with `-tls_verify 0`
(which is actually the default, arguably shouldn't be IMHO but
thats a different topic)
>
> wget(1):
>
>
On 8 Jul 2025, at 20:16, Nicolas George wrote:
> Marvin Scholz (HE12025-07-08):
>> From: Daniel N Pettersson
>>
>> Co-Authored-By: Marvin Scholz
>> ---
>> libavformat/tls_openssl.c | 9 -
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>&
Fix CID 1655306
---
libavformat/rtsp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 8d360b375f..0810c56a8b 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1847,6 +1847,7 @@ redirect:
/* GET requests */
if (ffurl
---
libavformat/tls_openssl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 7614caf089..e65914f11a 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -928,7 +928,11 @@ static int tls_open(
When no explicit CAs file is set, load the default locations,
else there is no way for verification to succeed.
This matches the behavior of other TLS backends.
---
libavformat/tls_openssl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open
From: Daniel N Pettersson
Co-Authored-By: Marvin Scholz
---
libavformat/tls_openssl.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index a0fa3285d5..7614caf089 100644
--- a/libavformat/tls_openssl.c
+++ b
On 8 Jul 2025, at 18:22, Devin Heitmueller wrote:
> Hi Marvin,
>
> On Tue, Jul 8, 2025 at 11:19 AM Marvin Scholz
> wrote:
>> I think even if a frame is schedule "far" in the future, if I want them
>> all played out then it should probably still wait, no? A
On 8 Jul 2025, at 16:54, Devin Heitmueller wrote:
> Hi Matt,
>
> Thanks for your contribution. Comments inline.
>
> On Mon, Jul 7, 2025 at 9:40 PM Matt via ffmpeg-devel
> wrote:
>> diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp
>> index cb8f91730e..5751f27de8 100644
>
Properly check av_dict_set return values and propagate them to
the caller so they can be handled.
---
libavformat/rtsp.c | 43 +--
1 file changed, 33 insertions(+), 10 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index c6203a07de..519fe
---
libavformat/rtsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 6201f09136..c6203a07de 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -2001,7 +2001,7 @@ redirect:
if (CONFIG_RTSP_MUXER)
err =
---
libavformat/rtsp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 8d360b375f..6201f09136 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -602,8 +602,8 @@ static void sdp_parse_line(AVFormatContext *s,
SDPParseS
On 7 Jul 2025, at 23:43, Timo Rothenpieler wrote:
> On 07.07.2025 23:41, Marvin Scholz wrote:
>> This was accidentally renamed back to the old names in
>> ba9817df9df5911ceb2edff37d9ec970c29329e2
>> ---
>> libavformat/tls.h | 4 ++--
>> 1 file chan
This was accidentally renamed back to the old names in
ba9817df9df5911ceb2edff37d9ec970c29329e2
---
libavformat/tls.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/tls.h b/libavformat/tls.h
index 3644b64fe2..6b6d06ab2d 100644
--- a/libavformat/tls.h
+++ b/liba
On 7 Jul 2025, at 20:17, Alexander Strasser via ffmpeg-devel wrote:
>> On 2025-07-07 15:57 +0200, Marvin Scholz wrote:
>> ---
>> Changelog | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Changelog b/Changelog
>> index f5ec9eafc3..0be
On 7 Jul 2025, at 18:00, Nicolas George wrote:
> Marvin Scholz (HE12025-07-07):
>> I never said not to check for it…
>
> You gave that argument in reply to the code becoming more verbose.
>
>> How is making an APIs return value adhere to its documentation
>> "
On 7 Jul 2025, at 17:32, Nicolas George wrote:
> Marvin Scholz (HE12025-07-04):
>> If copying two strings fails here, it is highly unlikely any of the following
>> code, needing much more memory, would have any chance of succeeding.
>
>> Yes it introducers two copies
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index f5ec9eafc3..0beefb73f6 100644
--- a/Changelog
+++ b/Changelog
@@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest
within each release,
releases are sorted from youngest to oldest.
On 7 Jul 2025, at 2:10, Michael Niedermayer wrote:
> Hi
>
> On Mon, Jul 07, 2025 at 12:29:44AM +0200, Alexander Strasser via ffmpeg-devel
> wrote:
>> Date: Mon, 7 Jul 2025 00:29:44 +0200
>> From: Alexander Strasser
>> To: FFmpeg development discussions and patches
>> Subject: Re: [FFmpeg-deve
On 27 Jun 2025, at 2:31, Marvin Scholz wrote:
> Resolves an unused variable warning when targeting a recent appleOS
> version.
> ---
> libavutil/hwcontext_videotoolbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/libavutil/hwcontex
On 25 Jun 2025, at 21:59, Marvin Scholz wrote:
> Given that OPENSSL_init_ssl was introduced in 1.1.0 means we can rely on
> that to ensure we have at least 1.1.0.
> ---
> configure | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/configur
On 24 Jun 2025, at 21:23, Marvin Scholz wrote:
> Used in a future commit to not duplicate options.
> ---
> libavformat/tls.h | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/tls.h b/libavformat/tls.h
> index 2f381acc04..c1d2
On 28 Jun 2025, at 16:27, Marvin Scholz wrote:
> The minimum valid packet length is 28, given that the length includes
> the packet header.
>
> This didn't cause any issues so far as the code did not care about the
> last two fields in the SR section, but will be relevant
On 27 Jun 2025, at 2:31, Marvin Scholz wrote:
> Resolves an unused variable warning when targeting a recent appleOS
> version.
> ---
> libavutil/hwcontext_videotoolbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/libavutil/hwcontex
On 25 Jun 2025, at 21:59, Marvin Scholz wrote:
> Given that OPENSSL_init_ssl was introduced in 1.1.0 means we can rely on
> that to ensure we have at least 1.1.0.
> ---
> configure | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/configur
On 24 Jun 2025, at 21:23, Marvin Scholz wrote:
> Used in a future commit to not duplicate options.
> ---
> libavformat/tls.h | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/tls.h b/libavformat/tls.h
> index 2f381acc04..c1d2
On 3 Jul 2025, at 11:08, Nicolas George wrote:
> Marvin Scholz (HE12025-06-25):
>> Would you be fine with just the removal of the messing with
>> the AVDictionary entries then, leaving the macros in place,
>> essentially removing STEAL_OPTION and doing a copy in CONSU
On 27 Jun 2025, at 23:50, Michael Niedermayer wrote:
> On Tue, Jun 24, 2025 at 08:02:01PM +0200, Marvin Scholz wrote:
>> This will be used in a future commit to expose the SR as side-data.
>> ---
>> libavcodec/defs.h | 14 ++
>>
---
libavcodec/packet.c | 1 +
libavcodec/packet.h | 6 ++
libavformat/rtpdec.c | 18 ++
3 files changed, 25 insertions(+)
diff --git a/libavcodec/packet.c b/libavcodec/packet.c
index 5104eb98b1..2aace71c7d 100644
--- a/libavcodec/packet.c
+++ b/libavcodec/packet.c
@@ -308
This will be used in a future commit to expose the SR as side-data.
---
libavcodec/defs.h | 14 ++
libavformat/rtpdec.c | 34 --
libavformat/rtpdec.h | 4 ++--
libavformat/rtspdec.c | 2 +-
4 files changed, 37 insertions(+), 17 deletions(-)
diff
The minimum valid packet length is 28, given that the length includes
the packet header.
This didn't cause any issues so far as the code did not care about the
last two fields in the SR section, but will be relevant in a future
commit.
---
libavformat/rtpdec.c | 2 +-
1 file changed, 1 insertion(
On 28 Jun 2025, at 4:17, Jack Lau via ffmpeg-devel wrote:
> AV_OPT_TYPE_INT,{ .i64 = 1200 },-1,
> INT_MAX, ENC },
> -{ "authorization", "The optional Bearer token for WHIP
> Authorization", OFFSET(authorization),
> +{ "authorization",
On 28 Jun 2025, at 3:42, Frank Plowman wrote:
> On 27/06/2025 00:23, Marvin Scholz wrote:
>> The ret value is checked later on again, so this check
>> is redundant and would cause the frame to not be unrefd on
>> failure as well.
>>
>> So rem
On 13 Jun 2025, at 10:56, Jack Lau via ffmpeg-devel wrote:
> mark this ignore_ipv6 flag could ignore any ipv6 ICE candidate,
> preventing “No route to host” errors on devices without IPv6 connectivity.
>
> Signed-off-by: Jack Lau
> ---
> libavformat/whip.c | 13 +
> 1 file changed, 1
Resolves an unused variable warning when targeting a recent appleOS
version.
---
libavutil/hwcontext_videotoolbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavutil/hwcontext_videotoolbox.c
b/libavutil/hwcontext_videotoolbox.c
index 172683121f..102fa485e5 100644
--
The ret value is checked later on again, so this check
is redundant and would cause the frame to not be unrefd on
failure as well.
So remove this check and add one before av_frame_remove_side_data
to ensure it is not called with an invalid frame.
Fix CID 1648350
---
libavcodec/vvc/refs.c | 5 ++-
On 23 Jun 2025, at 0:10, softworkz . wrote:
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of
>> Nicolas Gaullier
>> Sent: Freitag, 20. Juni 2025 13:08
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Nicolas Gaullier
>> Subject: [FFmpeg-devel] [PATCH 2/2] fftools/textformat: renamings
>>
On 23 Jun 2025, at 0:04, softworkz . wrote:
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of
>> Nicolas Gaullier
>> Sent: Freitag, 20. Juni 2025 13:08
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Nicolas Gaullier
>> Subject: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print
>>
The ret value is already checked earlier, making this condition
impossible to ever happen.
Fix CID 1648350
---
libavcodec/vvc/refs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c
index 79967b77d3..e52cc0c10d 100644
--- a/libavcodec/vvc/refs.c
+
Integer writing is impossible here as the first branch was dead code,
so remove it completely.
Fix CID 1646948
---
fftools/textformat/tf_mermaid.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c
index 3d864c
On 9 Jun 2025, at 5:21, Jack Lau wrote:
>> On Jun 6, 2025, at 11:02, Steven Liu wrote:
>>
>> Make sure the WHIP protocol performs the SDP offer/answer
>> exchange with the WebRTC peer over HTTP.
>>
>> Signed-off-by: Steven Liu
>> ---
>> libavformat/whip.c | 8
>> 1 file changed, 8 inse
On 6 Jun 2025, at 5:02, Steven Liu wrote:
> h264_annexb_insert_sps_pps (called after write_packet)
> reorganizes PPS, SPS, and IDR packets in H.264 streams.
> Since write_packet already validates pkt,
> redundant null checks in h264_annexb_insert_sps_pps can be removed.
>
> Signed-off-by: Steve
On 25 Jun 2025, at 11:56, Nicolas George wrote:
> Marvin Scholz (HE12025-06-25):
>> Since 155508c6e925f4f2f5e77087a7e1925b3de735ff specifying multiple
>> bsfs for different streams was broken:
>>
>> "[bsfs/a=h264_metadata:bsfs/v=h264_metadata]out.mp4|..."
&
On 26 Jun 2025, at 12:15, Maryla Ustarroz via ffmpeg-devel wrote:
> ffplay also has the -acodec, -vcodec etc. variants which I didn't add
> for simplicity.
> And indeed ffmpeg also has the shorter -c:specifier version.
> My reasoning was that ffmpeg and ffplay were already not consistent,
> and it
Using SSL_CTX_set_options to disallow specific versions is
discouraged by the documentation, which recommends to use
SSL_CTX_set_min_proto_version instead.
---
libavformat/tls_openssl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat
SSLv23_*_method was just a define for these anyway since OpenSSL 1.1.0
and the old functions are deprecated.
---
libavformat/tls_openssl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 8074251d9d..72ee36e7af 1006
Calling av_free with NULL is a no-op so this check is not needed.
---
libavformat/tls_openssl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 86e57ab389..8074251d9d 100644
--- a/libavformat/tls_openssl.c
+++
---
libavformat/tls_openssl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 7f796c7ddb..86e57ab389 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -369,7 +369,6 @@ einval_end:
ret = AVERROR(EINVAL);
en
As noted in the OpenSSL documentation, BIO_get_new_index must be
used to get a new BIO index. This is ORd with the proper type flag
BIO_TYPE_SOURCE_SINK.
---
libavformat/tls_openssl.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/libavformat/tls_openssl.c b/
This was used previously when multiple OpenSSL versions were supported
that required this to be handled differently.
---
libavformat/tls_openssl.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 525b7f3701..25991
---
libavformat/network.c | 8 --
libavformat/tls_openssl.c | 166 +-
2 files changed, 2 insertions(+), 172 deletions(-)
diff --git a/libavformat/network.c b/libavformat/network.c
index 2eabd0c167..a7026ac09b 100644
--- a/libavformat/network.c
+++ b/libav
Given that OPENSSL_init_ssl was introduced in 1.1.0 means we can rely on
that to ensure we have at least 1.1.0.
---
configure | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/configure b/configure
index d625461983..25d736170b 100755
--- a/configure
+++ b/configure
@@ -7
On 25 Jun 2025, at 13:23, Nicolas George wrote:
> Marvin Scholz (HE12025-06-25):
>> Instead of the convoluted nested macros, use a convenience
>> helper function. While this makes the code slightly longer, it
>> is now much clearer what is happening without running
Since 155508c6e925f4f2f5e77087a7e1925b3de735ff specifying multiple
bsfs for different streams was broken:
"[bsfs/a=h264_metadata:bsfs/v=h264_metadata]out.mp4|..."
This incorrectly only parsed the first bsfs specification. The reason
for this is that the dictionary is modified in the iterator, hen
Instead of the convoluted nested macros, use a convenience
helper function. While this makes the code slightly longer, it
is now much clearer what is happening without running the file
through a preprocessor first.
Additionally do not mess with the internals of the dictionary,
just to save two str
The minimum valid packet length is 28, given that the length includes
the packet header.
This didn't cause any issues so far as the code did not care about the
last two fields in the SR section, but will be relevant in a future
commit.
---
libavformat/rtpdec.c | 2 +-
1 file changed, 1 insertion(
This will be used in a future commit to expose the SR as side-data.
---
libavcodec/defs.h | 14 ++
libavformat/rtpdec.c | 34 --
libavformat/rtpdec.h | 4 ++--
libavformat/rtspdec.c | 2 +-
4 files changed, 37 insertions(+), 17 deletions(-)
diff
From: Daniel N Pettersson
Add TLS options to RTSP for when TLS is used for the lower protocol.
Signed-off-by: Marvin Scholz
Co-authored-by: Marvin Scholz
---
libavformat/rtsp.c | 26 +-
libavformat/rtsp.h | 11 +++
2 files changed, 36 insertions(+), 1 deletion
Used in a future commit to not duplicate options.
---
libavformat/tls.h | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/libavformat/tls.h b/libavformat/tls.h
index 2f381acc04..c1d2e21508 100644
--- a/libavformat/tls.h
+++ b/libavformat/tls.h
@@ -80,20 +80,24 @@ typed
---
libavcodec/packet.c | 1 +
libavcodec/packet.h | 6 ++
libavformat/rtpdec.c | 18 ++
3 files changed, 25 insertions(+)
diff --git a/libavcodec/packet.c b/libavcodec/packet.c
index 5104eb98b1..2aace71c7d 100644
--- a/libavcodec/packet.c
+++ b/libavcodec/packet.c
@@ -308
On 20 Jun 2025, at 13:07, Nicolas Gaullier wrote:
> Regression in ffprobe since textformat introduction
> in d7a3f68feae0b1c3718f9d2671c6d41c60a40680.
>
> Fixes #11638
>
> Signed-off-by: Nicolas Gaullier
> ---
> fftools/textformat/avtextformat.c | 2 +-
> fftools/textformat/avtextformat.h | 2
1 - 100 of 604 matches
Mail list logo
