On 23 May 2025, at 20:53, Michael Niedermayer wrote:
> Hi Marvin
>
> On Fri, May 23, 2025 at 02:11:24AM +0200, Marvin Scholz wrote:
>> ---
>> libavformat/sdp.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/libavformat/sdp.c b/libavformat/sdp.c
>> index 215e38f8fc..21ada5d1ce 100644
>> --- a/libavformat/sdp.c
>> +++ b/libavformat/sdp.c
>> @@ -867,6 +867,9 @@ int ff_sdp_write_media(char *buff, int size, const
>> AVStream *st, int idx,
>> if (p->bit_rate) {
>> av_strlcatf(buff, size, "b=AS:%"PRId64"\r\n", p->bit_rate / 1000);
>> }
>> + if (p->framerate.num > 0 && p->framerate.den > 0) {
>> + av_strlcatf(buff, size, "a=framerate:%g\r\n", av_q2d(p->framerate));
>> + }
>>
>> return sdp_write_media_attributes(buff, size, st, payload_type, fmt);
>> }
>> --
>> 2.39.5 (Apple Git-154)
>
> breaks fate:
>
> TEST lavf-mov_rtphint
> --- ./tests/ref/lavf/mov_rtphint 2025-05-23 14:14:31.476447585 +0200
> +++ tests/data/fate/lavf-mov_rtphint 2025-05-23 20:51:14.221038582 +0200
> @@ -1,3 +1,3 @@
> -d3d0b0a15e2207e1d69b7de5c0ff845c *tests/data/lavf/lavf.mov_rtphint
> -365745 tests/data/lavf/lavf.mov_rtphint
> +e5e994cd3885a28304229f5e277c1917 *tests/data/lavf/lavf.mov_rtphint
> +365761 tests/data/lavf/lavf.mov_rtphint
> tests/data/lavf/lavf.mov_rtphint CRC=0xbb2b949b
> Test lavf-mov_rtphint failed. Look at tests/data/fate/lavf-mov_rtphint.err
> for details.
> make: *** [tests/Makefile:316: fate-lavf-mov_rtphint] Error 1
>
Indeed it changed because it includes the SDP. Sent a new version that updates
the
ref accordingly.
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many that live deserve death. And some that die deserve life. Can you give
> it to them? Then do not be too eager to deal out death in judgement. For
> even the very wise cannot see all ends. -- Gandalf
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
