Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-12-26 Thread Martijn van Beurden
Op ma 26 dec. 2022 21:14 schreef Paul B Mahol : > Pushed. > > Next time do not put tabs in non Makefile parts in patch or I will > reject pushing it. > Thanks. Sorry about the tabs, I forgot to check, I will try to be more careful next time. > ___ ffmp

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-12-11 Thread Martijn van Beurden
Op do 1 dec. 2022 om 13:31 schreef Paul B Mahol : > > On 11/25/22, Paul B Mahol wrote: > > On 10/11/22, Martijn van Beurden wrote: > >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) > >> to create FLAC files containing 32-bit int PCM sa

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-11-25 Thread Martijn van Beurden
Op vr 11 nov. 2022 om 22:11 schreef Martijn van Beurden : > > Op vr 28 okt. 2022 om 22:13 schreef Martijn van Beurden : > > > > Op di 11 okt. 2022 om 19:24 schreef Martijn van Beurden : > > > > > > Recently libFLAC gained the ability (first released in FL

Re: [FFmpeg-devel] [PATCH] libavcodec/flacenc: Enable sample rates > 655350 Hz

2022-11-15 Thread Martijn van Beurden
Op ma 31 okt. 2022 om 19:33 schreef Martijn van Beurden : > > Op ma 31 okt. 2022 om 17:58 schreef Derek Buitenhuis > : > > > > It is interesting that the IETF RFC and the Xiph spec disagree on whether > > this is allowed. > > > > The Xiph spec also says the

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-11-11 Thread Martijn van Beurden
Op vr 28 okt. 2022 om 22:13 schreef Martijn van Beurden : > > Op di 11 okt. 2022 om 19:24 schreef Martijn van Beurden : > > > > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > > to create FLAC files containing 32-bit int PCM samples. To > > k

Re: [FFmpeg-devel] [PATCH] libavcodec/flacenc: Enable sample rates > 655350 Hz

2022-10-31 Thread Martijn van Beurden
not receive the streaminfo metadata block, and thus cannot use it to figure out the correct sample rate. Please let me know when this explanation falls short. Kind regards, Martijn van Beurden ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

[FFmpeg-devel] [PATCH] libavcodec/flacenc: Enable sample rates > 655350 Hz

2022-10-31 Thread Martijn van Beurden
Also, make use of the full sample rate code table --- libavcodec/flacenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index 5d8c3f82be..bca71b3780 100644 --- a/libavcodec/flacenc.c +++ b/libavcodec/flacenc.c @@ -299,7 +299,7

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-10-28 Thread Martijn van Beurden
Op di 11 okt. 2022 om 19:24 schreef Martijn van Beurden : > > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integers, wh

[FFmpeg-devel] [PATCH v7 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-10-11 Thread Martijn van Beurden
--- tests/fate/flac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak index 115cc965e1..3424b2bf82 100644 --- a/tests/fate/flac.mak +++ b/tests/fate/flac.mak @@ -6,6 +6,7 @@ FATE_FLAC += fate-flac-16-chmode-indep

[FFmpeg-devel] [PATCH v7 2/3] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-10-11 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict experimental is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 480 +++- libavcodec/put_bits.h

[FFmpeg-devel] [PATCH v7 1/3] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-10-11 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 218 +- libavcodec/get_bits.h | 12 +++ libavcodec/mathops.h | 9 ++ 4 files changed, 219 insertions(+), 24 deletions(-

[FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-10-11 Thread Martijn van Beurden
ible and changed ff_ctz to ff_ctzll where necessary Martijn van Beurden (3): libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM fate/flac: Add test of 32 bps encoding/decoding libavcodec/flac.c | 4 +- li

Re: [FFmpeg-devel] [PATCH v6 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-10-04 Thread Martijn van Beurden
Op di 4 okt. 2022 om 17:14 schreef Andreas Rheinhardt : > Is the encoder bitexact, i.e. does it always produce the same output > regardless of plattform (this is different from the encoder's output > decoding exactly to the original input)? I don't know but it seems unlikely to me. Of libFLAC I'm

Re: [FFmpeg-devel] [PATCH v6 0/3] 32bps FLAC patches

2022-10-04 Thread Martijn van Beurden
Op vr 16 sep. 2022 om 22:14 schreef Martijn van Beurden : > > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integers, wh

Re: [FFmpeg-devel] Need to reduce size of ffmpeg.exe for version 5.0.1

2022-10-04 Thread Martijn van Beurden
Op ma 3 okt. 2022 om 22:14 schreef Kumar, Rahul : > Can somebody help me answering below questions : > > 1. Can we reduce the size of ffmpeg.exe ? Any idea how can we create a > smaller ffmpeg.exe which should be able to run only above command to convert > RTSP to HLS? (as its size is 110 mb+ so

[FFmpeg-devel] [PATCH v6 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-09-16 Thread Martijn van Beurden
--- tests/fate/flac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak index 115cc965e1..3424b2bf82 100644 --- a/tests/fate/flac.mak +++ b/tests/fate/flac.mak @@ -6,6 +6,7 @@ FATE_FLAC += fate-flac-16-chmode-indep

[FFmpeg-devel] [PATCH v6 2/3] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-09-16 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict experimental is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 518 libavcodec/put_bits.h

[FFmpeg-devel] [PATCH v6 1/3] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-16 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 250 ++ libavcodec/get_bits.h | 12 ++ libavcodec/mathops.h | 9 ++ 4 files changed, 251 insertions(+), 24 deletions(-)

[FFmpeg-devel] [PATCH v6 0/3] 32bps FLAC patches

2022-09-16 Thread Martijn van Beurden
Changes since v5: Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced -strict -2 with -strict experimental in fate and encoder warning. Martijn van Beurden (3): libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM libavcodec/flacenc: Implement encoding of 32 bit-per-sa

Re: [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-09-16 Thread Martijn van Beurden
Op do 15 sep. 2022 om 21:52 schreef Martijn van Beurden : > Op do 15 sep. 2022 om 20:20 schreef Andreas Rheinhardt < > andreas.rheinha...@outlook.com>: > >> (In any case, I don't get why there are two samples: The flac decoder is >> intra-only, so if you made the s

Re: [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-09-15 Thread Martijn van Beurden
Op do 15 sep. 2022 om 20:20 schreef Andreas Rheinhardt < andreas.rheinha...@outlook.com>: > (In any case, I don't get why there are two samples: The flac decoder is > intra-only, so if you made the samples so that one of the frames had a > wasted bit, you could test all the codepaths that two samp

Re: [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-09-15 Thread Martijn van Beurden
Op do 15 sep. 2022 om 18:58 schreef Andreas Rheinhardt < andreas.rheinha...@outlook.com>: > Martijn van Beurden: > > --- > > tests/fate/flac.mak | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/tests/fate/flac.mak b/tests/fate/fl

[FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-09-15 Thread Martijn van Beurden
--- tests/fate/flac.mak | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak index 115cc965e1..4db28b1e1d 100644 --- a/tests/fate/flac.mak +++ b/tests/fate/flac.mak @@ -6,6 +6,8 @@ FATE_FLAC += fate-flac-16-chmode-indep

[FFmpeg-devel] [PATCH v5 2/3] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-09-15 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict -2 is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 519 libavcodec/put_bits.h | 7 +

[FFmpeg-devel] [PATCH v5 1/3] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-15 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 250 ++ libavcodec/get_bits.h | 12 ++ libavcodec/mathops.h | 9 ++ 4 files changed, 251 insertions(+), 24 deletions(-)

[FFmpeg-devel] [PATCH v5 0/3] 32bps FLAC patches

2022-09-15 Thread Martijn van Beurden
Martijn van Beurden (3): libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM fate/flac: Add test of 32 bps encoding/decoding libavcodec/flac.c | 4 +- libavcodec/flacdec.c| 250 +-- li

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-14 Thread Martijn van Beurden
Op wo 14 sep. 2022 om 15:03 schreef Andreas Rheinhardt < andreas.rheinha...@outlook.com>: > > --- a/libavcodec/flacdec.c > > +++ b/libavcodec/flacdec.c > > @@ -64,6 +64,9 @@ typedef struct FLACContext { > > int32_t *decoded[FLAC_MAX_CHANNELS];///< decoded samples > > uint8_t *decoded

Re: [FFmpeg-devel] [PATCH] Bonk, Bonk

2022-09-12 Thread Martijn van Beurden
Op wo 7 sep. 2022 om 19:59 schreef Paul B Mahol : > Patches attached. > > Could decoder be made faster? > > Haven't reviewed, but great to have another codec added. Concerning the speed, as far as I know Bonk is slow to decode. Its website states that it is slow: http://www.logarithmic.net/pfh/bon

Re: [FFmpeg-devel] [PATCH v4 0/2] 32bps FLAC patches

2022-09-10 Thread Martijn van Beurden
Op za 3 sep. 2022 om 11:21 schreef Martijn van Beurden : > Recently libFLAC gained the ability (not in any released version yet > though) to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integer

[FFmpeg-devel] [PATCH v4 2/2] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-09-03 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict -2 is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 519 libavcodec/put_bits.h | 7 +

[FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-03 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 248 ++ libavcodec/get_bits.h | 12 ++ libavcodec/mathops.h | 9 ++ 4 files changed, 250 insertions(+), 23 deletions(-)

[FFmpeg-devel] [PATCH v4 0/2] 32bps FLAC patches

2022-09-03 Thread Martijn van Beurden
n't apply anymore Changes since v3: Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) Martijn van Beurden (2): libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM libavcodec/flacenc: I

Re: [FFmpeg-devel] [PATCH v3 2/2] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-09-02 Thread Martijn van Beurden
First of all, thanks for reviewing. Op vr 2 sep. 2022 om 17:11 schreef Andreas Rheinhardt < andreas.rheinha...@outlook.com>: > > +static inline void put_sbits64(PutBitContext *pb, int n, int64_t value) > > +{ > > +av_assert2(n >= 0 && n <= 64); > > + > > +put_bits64(pb, n, (uint64_t)(valu

[FFmpeg-devel] [PATCH v3 2/2] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-09-02 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict -2 is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 499 libavcodec/put_bits.h | 7 +

[FFmpeg-devel] [PATCH v3 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-02 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 248 ++ libavcodec/get_bits.h | 12 ++ libavcodec/mathops.h | 9 ++ 4 files changed, 250 insertions(+), 23 deletions(-)

[FFmpeg-devel] [PATCH v3 0/2] 32bps FLAC patches

2022-09-02 Thread Martijn van Beurden
oder, several invocations of lpc_encode_choose_datapath used wrong parameters, making FATE fail as compression was less than it should be Changes since v2: Rebased decoder part as it didn't apply anymore Martijn van Beurden (2): libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

Re: [FFmpeg-devel] Converting build to CMake

2022-08-28 Thread Martijn van Beurden
Op ma 29 aug. 2022 om 01:17 schreef Jaime Rios : > The reason I ask is that I am not a fan of having to install MinGW just to > build on Windows > There's no need to install MinGW, just MSYS will do: https://trac.ffmpeg.org/wiki/CompilationGuide/MSVC __

Re: [FFmpeg-devel] [PATCH v2 0/2] 32bps FLAC patches

2022-08-15 Thread Martijn van Beurden
Op ma 1 aug. 2022 om 14:03 schreef Martijn van Beurden : > Recently libFLAC gained the ability (not in any released version yet > though) to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integer

[FFmpeg-devel] [PATCH] avformat/movenc: Remove experimental status of flac-in-MP4 muxing

2022-08-06 Thread Martijn van Beurden
The fLaC and dfLa box IDs have been registered with the MP4 RA (they are now listed at https://mp4ra.org/#/codecs) and support for muxing FLAC in MP4 has been experimental in ffmpeg for 6 years now, since Nov 21, 2016 This patch removes the experimental status and removes the MP4 object type, as n

[FFmpeg-devel] [PATCH v2 2/2] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-08-01 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict -2 is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 499 libavcodec/put_bits.h | 7 +

[FFmpeg-devel] [PATCH v2 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-08-01 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 248 ++ libavcodec/get_bits.h | 12 ++ libavcodec/mathops.h | 9 ++ 4 files changed, 250 insertions(+), 23 deletions(-)

[FFmpeg-devel] [PATCH v2 0/2] 32bps FLAC patches

2022-08-01 Thread Martijn van Beurden
oder, several invocations of lpc_encode_choose_datapath used wrong parameters, making FATE fail as compression was less than it should be Martijn van Beurden (2): libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM liba

[FFmpeg-devel] [PATCH 2/2] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-07-26 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict -2 is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 499 libavcodec/put_bits.h | 7 +

[FFmpeg-devel] [PATCH 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-07-26 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 248 ++ libavcodec/get_bits.h | 12 ++ libavcodec/mathops.h | 9 ++ 4 files changed, 250 insertions(+), 23 deletions(-)

[FFmpeg-devel] [PATCH 0/2] 32bps FLAC patches

2022-07-26 Thread Martijn van Beurden
two patches implement decoding and encoding following this format. The decoding patch has been send in for review earlier, but didn't get any feedback yet, so I'm sending it in again, unchanged, this time with a patch for encoding too. Martijn van Beurden (2): libavcodec/flacdec: Implemen

Re: [FFmpeg-devel] [PATCH] RELEASE_NOTES: Based on the version from 5.0

2022-07-17 Thread Martijn van Beurden
Op zo 17 jul. 2022 om 00:50 schreef Michael Niedermayer < mich...@niedermayer.cc>: > ATM we have to maintain many releases because each is used by some distro > the LTS designation might cause distros to coalescence onto fewer releases > This may also make life easier to distro maintainers > The

Re: [FFmpeg-devel] [PATCH] RELEASE_NOTES: Based on the version from 5.0

2022-07-16 Thread Martijn van Beurden
Op za 16 jul. 2022 om 22:36 schreef Michael Niedermayer < mich...@niedermayer.cc>: > > something like this: ? > > + The FFmpeg Project proudly presents FFmpeg 5.1 "Riemann" LTS, about 6 > + months after the release of FFmpeg 5.0, our first Long Term Support > + release. > > Yes, that probabl

Re: [FFmpeg-devel] [PATCH] RELEASE_NOTES: Based on the version from 5.0

2022-07-16 Thread Martijn van Beurden
Op za 16 jul. 2022 om 17:09 schreef Michael Niedermayer < mich...@niedermayer.cc>: > +┌┐ > +│ RELEASE NOTES for FFmpeg 5.1 "Riemann" LTS │ > +└┘ > + > Should there perhaps b

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: Implement decoding of 32-bit PCM

2022-07-11 Thread Martijn van Beurden
Op ma 20 jun. 2022 om 22:14 schreef Martijn van Beurden : > Recently libFLAC gained the ability (not in any released version yet > though) to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit int

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing

2022-07-05 Thread Martijn van Beurden
Op za 11 jun. 2022 om 09:31 schreef Martijn van Beurden : > The afconvert utility shipped with MacOS supports muxing of FLAC > in CAF, see afconvert help output on a recent Mac here: > https://hydrogenaud.io/index.php?topic=122509.0 A file created > with afconvert free of copyright (

[FFmpeg-devel] [PATCH] avformat/flacdec: Implement decoding of 32-bit PCM

2022-06-20 Thread Martijn van Beurden
Recently libFLAC gained the ability (not in any released version yet though) to create FLAC files containing 32-bit int PCM samples. To keep complexity reasonable, the choice was made to limit residuals to 32-bit integers, which the encoder must make sure of. In case the encoder cannot find any pre

Re: [FFmpeg-devel] Need info on how to run ffmpeg command using dll file

2022-06-13 Thread Martijn van Beurden
Op ma 13 jun. 2022 om 11:09 schreef Kumar, Rahul : > alternative instead of using "ffmpeg.exe" (as its size is 110 mb+ and we > want to avoid shipping it with our product). ? > Questions about use of ffmpeg are better posted at the user mailinglist, see https://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] Trivial codec based on QOI and zstd compresses better than all lossless ffmpeg codecs on my data from screen

2022-06-11 Thread Martijn van Beurden
Op za 11 jun. 2022 01:37 schreef Аскар Сафин : > ffv1 spec reads: "FFV1 is designed to support a wide range of lossless > video applications such as... screen recording..." Unfortunately, ffv1 > turned out to be bad compared to my codec > on screen recording data, so it is possible ffv1 could bene

[FFmpeg-devel] [PATCH v3 2/2] avformat/mov: prevent potential use of uninitialized value

2022-06-11 Thread Martijn van Beurden
--- libavformat/mov.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d7be593a86..51c0f6f9d8 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6772,7 +6772,10 @@ static int mov_read_dfla(MOVContext *c, AVIOContext *pb, M

[FFmpeg-devel] [PATCH v3 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing

2022-06-11 Thread Martijn van Beurden
The afconvert utility shipped with MacOS supports muxing of FLAC in CAF, see afconvert help output on a recent Mac here: https://hydrogenaud.io/index.php?topic=122509.0 A file created with afconvert free of copyright (licensed CC0) can be found here: http://www.audiograaf.nl/misc_stuff/afconvert-FL

[FFmpeg-devel] [PATCH v2 2/2] avformat/mov: prevent potential use of uninitialized value

2022-06-04 Thread Martijn van Beurden
--- libavformat/mov.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d7be593a86..f3a63abaaa 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6772,7 +6772,10 @@ static int mov_read_dfla(MOVContext *c, AVIOContext *pb, M

[FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing

2022-06-04 Thread Martijn van Beurden
The afconvert utility shipped with MacOS supports muxing of FLAC in CAF, see afconvert help output on a recent Mac here: https://hydrogenaud.io/index.php?topic=122509.0 A file created with afconvert free of copyright (licensed CC0) can be found here: http://www.audiograaf.nl/misc_stuff/afconvert-FL

Re: [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing

2022-06-03 Thread Martijn van Beurden
Op vr 3 jun. 2022 om 19:11 schreef Andreas Rheinhardt : > > You are not checking this; this could lead to uninitialized values being > used in flac_parse_block_header() below. > Yes, indeed, thank you. Interestingly enough, I copied this bit directly from mov_read_dfla in mov.c, so I'll send a pat

[FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing

2022-06-03 Thread Martijn van Beurden
The afconvert utility shipped with MacOS supports muxing of FLAC in CAF, see afconvert help output on a recent Mac here: https://hydrogenaud.io/index.php?topic=122509.0 A file created with afconvert free of copyright (licensed CC0) can be found here: http://www.audiograaf.nl/misc_stuff/afconvert-FL

[FFmpeg-devel] lavf/isom: is ff_mp4_obj_type for FLAC useful somewhere

2022-05-31 Thread Martijn van Beurden
registering? Please advise. If possible, please add a short reasoning that I can copy/rephrase to MP4RA on this matter. Kind regards, Martijn van Beurden ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX

2022-04-29 Thread Martijn van Beurden
Op wo 6 apr. 2022 om 09:12 schreef Martijn van Beurden : > > Op di 5 apr. 2022 om 15:37 schreef Martijn van Beurden : > > > > --- > > libavcodec/flacdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/

Re: [FFmpeg-devel] Request For Comment no Matroska specs

2022-04-15 Thread Martijn van Beurden
elements can be found in Annex A. >> >> I forgot to mention you can reply here or on the GitHub repository of >> the specs [3] by creating an issue or even a Pull Request. >> >> [3] https://github.com/ietf-wg-cellar/matroska-specification >> >> > T

Re: [FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX

2022-04-06 Thread Martijn van Beurden
Op di 5 apr. 2022 om 15:37 schreef Martijn van Beurden : > > --- > libavcodec/flacdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c > index dd6026f9de..cb32d7cae8 100644 > --- a/libavcodec/flac

Re: [FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX

2022-04-05 Thread Martijn van Beurden
Op di 5 apr. 2022 18:04 schreef Andreas Rheinhardt < andreas.rheinha...@outlook.com>: > > Wouldn't it be possible to use unsigned for real_limit? > The limit is passed to get_ur_golomb_jpegls which takes int. In that function, the limit is subtracted from, and the function is used by quite a few

[FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX

2022-04-05 Thread Martijn van Beurden
--- libavcodec/flacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c index dd6026f9de..cb32d7cae8 100644 --- a/libavcodec/flacdec.c +++ b/libavcodec/flacdec.c @@ -260,7 +260,7 @@ static int decode_residuals(FLACContext *s, int32_t

Re: [FFmpeg-devel] Request For Comment no Matroska specs

2022-04-02 Thread Martijn van Beurden
Op vr 1 apr. 2022 14:53 schreef Steve Lhomme : > On 2022-04-01 14:33, Steve Lhomme wrote: > > Hi ffmmpeg developers, > > > > As you may know, we are working hard on the Matroska specifications at > > the IETF. We already got EBML as an RFC [1]. We are in the process of > > finalizing the main Matr

Re: [FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

2022-03-30 Thread Martijn van Beurden
First of all, thanks for reviewing Op wo 30 mrt. 2022 om 12:42 schreef Andreas Rheinhardt : > Can this happen with real encoders or has this file been specifically > crafted? What is the performance impact of this patch on ordinary files? This file has been crafted. It seems unlikely to occur in

[FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

2022-03-27 Thread Martijn van Beurden
The size of residuals in a FLAC file coding for 24-bit PCM can exceed the range of a 32-bit signed integer. One pathological example with residuals exceeding [-2^33,2^33) can be found here: http://www.audiograaf.nl/misc_stuff/Extreme%20residual%20LPC%20order%2014.flac The theorectical maximum bit

Re: [FFmpeg-devel] [PATCH 3/3] lavc/encode: pick a sane default for bits_per_raw_sample if it's not set

2022-01-23 Thread Martijn van Beurden
Op do 20 jan. 2022 22:18 schreef Anton Khirnov : > Quoting Martijn van Beurden (2022-01-20 19:58:54) > > Op do 20 jan. 2022 om 17:05 schreef Anton Khirnov : > > > > > Fixes #9563. > > > --- > > > libavcodec/encode.c | 3 +++ > > > 1 fil

Re: [FFmpeg-devel] [PATCH 3/3] lavc/encode: pick a sane default for bits_per_raw_sample if it's not set

2022-01-20 Thread Martijn van Beurden
Op do 20 jan. 2022 om 19:58 schreef Martijn van Beurden : > This creates a new regression: now 24-bit WAV files are converted to > 32-bit WavPack files. I think I found the cause of the problem though: the > issue is that wavpack uses sample format s32p and 24-bit wav files use s32. &g

Re: [FFmpeg-devel] [PATCH 3/3] lavc/encode: pick a sane default for bits_per_raw_sample if it's not set

2022-01-20 Thread Martijn van Beurden
Op do 20 jan. 2022 om 17:05 schreef Anton Khirnov : > Fixes #9563. > --- > libavcodec/encode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index b6f81d1458..44ab81af3f 100644 > --- a/libavcodec/encode.c > +++ b/libavcodec/encode.c > @@ -

[FFmpeg-devel] [PATCH v4] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2022-01-08 Thread Martijn van Beurden
Enables creation of FLAC files with up to 32 bits-per-sample, up from the previous limit of 24 bit. This is a feature requested for RAWcooked, the archiving community has a need for storing files with 32-bit integer audio samples. See https://github.com/MediaArea/RAWcooked/issues/356 Restrictions

[FFmpeg-devel] [PATCH v3] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2022-01-03 Thread Martijn van Beurden
Enables creation of FLAC files with up to 32 bits-per-sample, up from the previous limit of 24 bit. This is a feature requested for RAWcooked, the archiving community has a need for storing files with 32-bit integer audio samples. See https://github.com/MediaArea/RAWcooked/issues/356 Restrictions

Re: [FFmpeg-devel] [PATCH v2] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-20 Thread Martijn van Beurden
Op ma 20 dec. 2021 om 09:12 schreef Martijn van Beurden : > +if (avctx->bits_per_raw_sample == 0) > +avctx->bits_per_raw_sample = 32; This part is wrong. bits_per_raw_sample should not be 0. I assumed that 0 meant 'no different from sample format

[FFmpeg-devel] [PATCH v2] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-20 Thread Martijn van Beurden
Enables creation of FLAC files with up to 32 bits-per-sample, up from the previous limit of 24 bit. This is a feature requested for RAWcooked, the archiving community has a need for storing files with 32-bit integer audio samples. See https://github.com/MediaArea/RAWcooked/issues/356 Restrictions

Re: [FFmpeg-devel] [PATCH] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-19 Thread Martijn van Beurden
Op zo 19 dec. 2021 om 22:11 schreef Lynne : > What happens if there's an overflow and the prediction coefficients > are lowered? Is there a loss of bits? What about if it gives up? The result remains lossless. If the prediction coefficients are lowered, the residual of the prediction increases. Th

[FFmpeg-devel] [PATCH] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-19 Thread Martijn van Beurden
Enables creation of FLAC files with up to 32 bits-per-sample, up from the previous limit of 24 bit. This is a feature requested for RAWcooked, the archiving community has a need for storing files with 32-bit integer audio samples. See https://github.com/MediaArea/RAWcooked/issues/356 Restrictions

Re: [FFmpeg-devel] [PATCH] Add 32 bit-per-sample capability to FLAC encoder

2021-12-17 Thread Martijn van Beurden
Op vr 17 dec. 2021 om 12:43 schreef Michael Niedermayer : > > +sub->coefs[i] = sub->coefs[i]*0.98; > > This is ugly, the amount of actual overflow should be known at this point > so no arbitrary downscale should be needed here

Re: [FFmpeg-devel] [PATCH] Add 32 bit-per-sample capability to FLAC encoder

2021-12-16 Thread Martijn van Beurden
Could you please explain what makes this a bad patch, so I can try to improve it? Wavpack was already suggested, but using FLAC for archival is preferred because the FLAC standard is currently in the process of becoming an IETF RFC. Op do 16 dec. 2021 om 22:09 schreef Paul B Mahol : > > use wavpa

[FFmpeg-devel] [PATCH] Add 32 bit-per-sample capability to FLAC encoder

2021-12-16 Thread Martijn van Beurden
This commit makes ffmpeg create FLAC files with up to 32 bits-per-sample, up from the previous limit of 24 bit. This is because of a feature request to RAWcooked, apparently the archiving community has a need for storing files with 32-bit integer audio samples. See https://github.com/MediaArea/RAW