Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch

2025-07-29 Thread James Almer
On 7/29/2025 5:56 PM, Kacper Michajlow wrote: On Tue, 29 Jul 2025 at 22:11, James Almer wrote: On 7/29/2025 5:02 PM, Kieran Kunhya via ffmpeg-devel wrote: Hello, It seem there is strong evidence that AI wrote TLS code as part of the WHIP patch. It goes without saying why this is bad

Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch

2025-07-29 Thread James Almer
On 7/29/2025 5:02 PM, Kieran Kunhya via ffmpeg-devel wrote: Hello, It seem there is strong evidence that AI wrote TLS code as part of the WHIP patch. It goes without saying why this is bad. Further discussion here: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20053 This patch was pushed without

Re: [FFmpeg-devel] [PATCH 0/2] Support the new APMP boxes and spherical metadata

2025-07-28 Thread James Almer
On 7/28/2025 10:50 PM, Vittorio Giovara wrote: From a244d96e045439f9e3a4db99e2f479e8686221da Mon Sep 17 00:00:00 2001 From: Vittorio Giovara Date: Wed, 23 Jul 2025 23:42:14 +0200 Subject: [PATCH 2/2] lavu/spherical: Add support for Spherical Immersive type --- libavformat/mov.c | 3 +++ li

Re: [FFmpeg-devel] forgejo PR vs git send email questions

2025-07-28 Thread James Almer
On 7/28/2025 8:13 PM, Michael Niedermayer wrote: Hi with git send email i can send 5 independant patches with git send-email --to='FFmpeg development discussions and patches ' -5 and have some CC: tags to make sure people (like bug reporter or security researcher) get notified Does our for

Re: [FFmpeg-devel] Authorize BtbN

2025-07-25 Thread James Almer
On 7/25/2025 2:14 PM, Derek Buitenhuis wrote: https://0x0.st/85bn.png Yeah, not ideal. I know who BtbN is, random contributor does not. Appears sketchy. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

[FFmpeg-devel] [PATCH] avfilter/af_channelmap: always set out_channel in the map

2025-07-24 Thread James Almer
Fixes use-of-uninitialized-value. Signed-off-by: James Almer --- libavfilter/af_channelmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index a883934fa6..b864317312 100644 --- a/libavfilter/af_channelmap.c +++ b/libavfilter

Re: [FFmpeg-devel] FFmpeg 8.0 Release

2025-07-23 Thread James Almer
On 7/23/2025 11:01 AM, Niklas Haas wrote: On Wed, 23 Jul 2025 16:01:14 +0200 Niklas Haas wrote: On Wed, 23 Jul 2025 13:43:43 +0200 Michael Niedermayer wrote: Hi everyone I intend to create the release/8.0 branch in the next 1-2 weeks after that i intend to make teh 8.0 release in the follow

Re: [FFmpeg-devel] Notifications for the new monolithic tool

2025-07-23 Thread James Almer
On 7/23/2025 4:24 PM, Nicolas George wrote: Hi. I just saw somebody mention this on trac: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20025 But I have no trace of it in my inbox. If this is now an accepted way of getting contributions, then either the devel mailing-list should receive notificat

[FFmpeg-devel] [PATCH] avcodec/opus/silk: don't assume stereo when calling silk_decode_frame()

2025-07-22 Thread James Almer
Fixes use-of-uninitialized-value under MSAN. Signed-off-by: James Almer --- libavcodec/opus/silk.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/opus/silk.c b/libavcodec/opus/silk.c index 97bb95037c..ffa2ec996b 100644 --- a/libavcodec/opus/silk.c +++ b

[FFmpeg-devel] [PATCH 3/3] avfilter: use the getters for xGA font data arrays

2025-07-21 Thread James Almer
Signed-off-by: James Almer --- libavfilter/af_aiir.c | 2 +- libavfilter/avf_showcqt.c | 3 ++- libavfilter/avf_showspectrum.c | 2 +- libavfilter/avf_showvolume.c | 2 +- libavfilter/f_ebur128.c| 4 ++-- libavfilter/f_graphmonitor.c | 2 +- libavfilter

[FFmpeg-devel] [PATCH 2/3] avcodec: use the getters for xGA font data arrays

2025-07-21 Thread James Almer
Signed-off-by: James Almer --- libavcodec/ansi.c| 12 ++-- libavcodec/bintext.c | 4 ++-- libavcodec/tmv.c | 3 ++- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/ansi.c b/libavcodec/ansi.c index b58b72ef49..bde9edbe60 100644 --- a/libavcodec/ansi.c

[FFmpeg-devel] [PATCH 1/3] avutil/xga_font_data: add getters to access the shared arrays

2025-07-21 Thread James Almer
And stop exposing the arrays on the next major bump. Signed-off-by: James Almer --- libavutil/xga_font_data.c | 16 libavutil/xga_font_data.h | 6 ++ 2 files changed, 22 insertions(+) diff --git a/libavutil/xga_font_data.c b/libavutil/xga_font_data.c index 3aed3142cf

Re: [FFmpeg-devel] [PATCH 0/2] Fix Nikon HEIF decoding error

2025-07-19 Thread James Almer
On 7/19/2025 3:09 AM, compn wrote: On Fri, 18 Jul 2025 10:58:18 -0700, Eric Joyner wrote: On 7/17/2025 8:54 AM, compn wrote: do we have a nikon heif/ hif file sample for our samples repository? http://samples.ffmpeg.org we like to keep some files around for testing , to make sure we dont brea

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate/lavf-container: add test for APV in MP4

2025-07-19 Thread James Almer
On 7/19/2025 5:00 AM, Martin Storsjö wrote: On Fri, 18 Jul 2025, James Almer wrote: ffmpeg | branch: master | James Almer | Tue Jul 15 19:00:21 2025 -0300| [3cd5672bfeb796342d24228a78f2e733c0a40e7d] | committer: James Almer fate/lavf-container: add test for APV in MP4 Signed-off-by: James

[FFmpeg-devel] [PATCH] avformat/hevc: don't print parameter_set_id for any NALU

2025-07-18 Thread James Almer
It's not a value stored in the hvcC structure. Fixes use of uninitialized variable errors under sanitizer when the input extradata is already hvcC formatted, given we don't parse parameter sets for those. Signed-off-by: James Almer --- libavformat/hevc.c | 4 1 file changed, 4

[FFmpeg-devel] [PATCH] avcodec/ffv1dec: don't add offsets to more NULL pointers

2025-07-18 Thread James Almer
Fixes: libavcodec/ffv1dec.c:453:43: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/ffv1dec.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index d613aa5395

[FFmpeg-devel] [PATCH] avcodec/ffv1dec: don't add offsets to more NULL pointer

2025-07-18 Thread James Almer
Fixes: libavcodec/ffv1dec.c:453:43: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/ffv1dec.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index d613aa5395

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

2025-07-18 Thread James Almer
On 7/18/2025 8:01 PM, Michael Niedermayer wrote: On Tue, Jul 15, 2025 at 10:33:10AM -0300, James Almer wrote: Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/motion_est.c | 6 +++--- 1 file changed, 3

Re: [FFmpeg-devel] [PATCH 1/2] libavformat: Support multiple thumbnails in HEIF

2025-07-17 Thread James Almer
On 7/16/2025 11:30 PM, Eric Joyner wrote: Prevents ffmpeg/ffprobe from erroring out when reading an HEIF that contains multiple hvcC thumbnails (e.g. from a Nikon Z6III camera). Before, move_read_iref_thmb() would always override the stored thmb_item_id in the MOVContext with each new read thumb

[FFmpeg-devel] [PATCH] avformat/mov: don't assume iloc and iinf entries for each item_id will be in the same order

2025-07-17 Thread James Almer
Nothing forbids them to be in any order the muxer desires. Fixes demuxing heif samples generated by S1II. Signed-off-by: James Almer --- libavformat/mov.c | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/libavformat/mov.c b

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: Enable jpeg streams in HEIF MOVContext

2025-07-17 Thread James Almer
On 7/17/2025 8:54 AM, Lynne wrote: Thanks. Patchset LGTM. This also helps HEIF files generated by the S1II, but sadly they still fail: > [mjpeg @ 0x55a49a0e29c0] No JPEG data found in image And for the main stream: > [hevc @ 0x55a49a0fe880] Failed to parse header of NALU (type 34): "Inval

Re: [FFmpeg-devel] [PATCH v2 2/3] tests/checkasm: add check for vf_colordetect

2025-07-16 Thread James Almer
On 7/16/2025 1:24 PM, Niklas Haas wrote: From: Niklas Haas --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/vf_colordetect.c | 137 4 files changed, 142 insertions

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_colordetect: add x86 SIMD implementation

2025-07-16 Thread James Almer
On 7/16/2025 6:49 PM, Niklas Haas wrote: On Wed, 16 Jul 2025 17:25:12 -0300 James Almer wrote: On 7/16/2025 1:24 PM, Niklas Haas wrote: +cglobal detect_alpha%1_%3, 6, 7, 6, color, color_stride, alpha, alpha_stride, width, height, x +pxor m0, m0 +add colorq, widthq +add alphaq

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_colordetect: add x86 SIMD implementation

2025-07-16 Thread James Almer
On 7/16/2025 1:24 PM, Niklas Haas wrote: +cglobal detect_alpha%1_%3, 6, 7, 6, color, color_stride, alpha, alpha_stride, width, height, x +pxor m0, m0 +add colorq, widthq +add alphaq, widthq +neg widthq +%ifidn %3, limited +%if ARCH_X86_64 +movq xm3, r6mp ; p +movq xm4, r7

Re: [FFmpeg-devel] [PATCH v4] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-07-15 Thread James Almer
On 7/14/2025 6:18 AM, Dawid Kozinski wrote: - Changes in mov_write_video_tag function to handle APV elementary stream - Provided structure APVDecoderConfigurationRecord that specifies the decoder configuration information for APV video content Signed-off-by: Dawid Kozinski --- libavcodec/cbs

[FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

2025-07-15 Thread James Almer
Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/motion_est.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index 93be712cc0

[FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

2025-07-13 Thread James Almer
Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/motion_est.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index 93be712cc0

[FFmpeg-devel] [PATCH] avcodec/ffv1dec: don't add offsets to NULL pointers

2025-07-13 Thread James Almer
Fixes: libavcodec/ffv1dec.c:452:43: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/ffv1dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 8d10d2cf8b..d613aa5395

[FFmpeg-devel] [PATCH] swscale/swscale_unscaled: don't add offsets to NULL pointers

2025-07-13 Thread James Almer
Fixes: libswscale/swscale_unscaled.c:916:20: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libswscale/swscale_unscaled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c index

[FFmpeg-devel] [PATCH v3] avformat/tls_schannel: add check for Windows 10 only types and defines

2025-07-13 Thread James Almer
Old Mingw-w64 releases provided by some distros seemingly don't have them, so check for them and disable the dtls protocol if unavailable. Signed-off-by: James Almer --- configure | 4 libavformat/tls_schannel.c | 33 +++-- 2 files change

[FFmpeg-devel] [PATCH v2] avformat/tls_schannel: add check for Windows 10 only types and defines

2025-07-13 Thread James Almer
Old Mingw-w64 releases provided by some distros seemingly don't have them, so check for them and disable the dtls protocol if unavailable. Signed-off-by: James Almer --- configure | 4 libavformat/tls_schannel.c | 29 +++-- 2 files change

[FFmpeg-devel] [PATCH] avformat/tls_schannel: add check for Windows 10 only types and defines

2025-07-13 Thread James Almer
Old Mingw-w64 releases provided by supported distros seemingly don't have them, so check for them and disable the dtls protocol if unavailable. Signed-off-by: James Almer --- configure | 3 +++ libavformat/tls_schannel.c | 33 +++-- 2 files ch

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/tls_schannel: add DTLS support

2025-07-13 Thread James Almer
On 7/13/2025 8:35 AM, Timo Rothenpieler wrote: On 7/13/2025 4:59 AM, James Almer wrote: On 7/12/2025 9:32 PM, Michael Niedermayer wrote: On Fri, Jul 11, 2025 at 04:04:17PM +, Timo Rothenpieler wrote: ffmpeg | branch: master | Timo Rothenpieler | Tue Jun 24 19:30:19 2025 +0200

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/tls_schannel: add DTLS support

2025-07-13 Thread James Almer
On 7/12/2025 11:59 PM, James Almer wrote: On 7/12/2025 9:32 PM, Michael Niedermayer wrote: On Fri, Jul 11, 2025 at 04:04:17PM +, Timo Rothenpieler wrote: ffmpeg | branch: master | Timo Rothenpieler | Tue Jun 24 19:30:19 2025 +0200| [90fa9636efff84ec5a4b06815722c08188dca551] | committer

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/tls_schannel: add DTLS support

2025-07-12 Thread James Almer
On 7/12/2025 9:32 PM, Michael Niedermayer wrote: On Fri, Jul 11, 2025 at 04:04:17PM +, Timo Rothenpieler wrote: ffmpeg | branch: master | Timo Rothenpieler | Tue Jun 24 19:30:19 2025 +0200| [90fa9636efff84ec5a4b06815722c08188dca551] | committer: Timo Rothenpieler avformat/tls_schannel: a

[FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: don't flag timestamps as unreliable if they are generated

2025-07-08 Thread James Almer
Regardless of the source being an AVFMT_NOTIMESTAMPS format, if the timestamps are generated like when using the use_wallclock_as_timestamps demuxer option, then they are reliable. Fixes ticket #11268 Signed-off-by: James Almer --- fftools/ffmpeg_demux.c | 11 ++- 1 file changed, 10

Re: [FFmpeg-devel] [PATCH v2] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-07-07 Thread James Almer
On 5/8/2025 7:30 AM, Dawid Kozinski wrote: - Changes in mov_write_video_tag function to handle APV elementary stream - Provided structure APVDecoderConfigurationRecord that specifies the decoder configuration information for APV video content Signed-off-by: Dawid Kozinski --- libavformat/Mak

Re: [FFmpeg-devel] [PATCH v1] avformat/mov_demuxer: Extended MOV demuxer to handle APV video content

2025-07-07 Thread James Almer
On 5/6/2025 6:28 AM, Dawid Kozinski wrote: - Added apv extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- libavformat/demux.c | 1 + libavformat/mov.c | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/demux.c b/lib

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/aac_ac3_parser: remove dead code

2025-07-07 Thread James Almer
On 7/7/2025 10:19 AM, Nicolas Gaullier wrote: ff_adts_header_parse() gets the object_type from only 2 bits. See also 696ea1c2236842572df88d573e24a39be3f19c98. Introduced in 64bb91fd3b5a00a8849531c7e8dd207f2a626096. Signed-off-by: Nicolas Gaullier --- libavcodec/aac_ac3_parser.c | 7 +++

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/aac_ac3_parser: do not override the profile set by the decoder

2025-07-07 Thread James Almer
On 7/7/2025 10:19 AM, Nicolas Gaullier wrote: Parsing the ADTS header is not enough to detect HE-AAC v1/v2. Regression since 64bb91fd3b5a00a8849531c7e8dd207f2a626096. Fixes #11600 Signed-off-by: Nicolas Gaullier --- libavcodec/aac_ac3_parser.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

Re: [FFmpeg-devel] [PATCH] Macroblocks modes extraction

2025-07-04 Thread James Almer
On 7/2/2025 7:57 AM, Timothee wrote: Hello, I am working on a modification toextract per-macroblock prediction modes (H.264 for now). The goal is to make this information available to vf_codecview and print it in a log file (for now). This are what I have added: 1.    A new H264MBInfostru

Re: [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist

2025-07-03 Thread James Almer
On 7/3/2025 1:28 PM, Andreas Rheinhardt wrote: Scott Theisen: This matches how the other libraries define their exported symbols. --- libavformat/libavformat.v | 5 - libavutil/libavutil.v | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/libavforma

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-07-01 Thread James Almer
On 7/1/2025 3:49 PM, Timo Rothenpieler wrote: On 23.06.2025 17:44, Timo Rothenpieler wrote: On 16.06.2025 20:26, Andreas Rheinhardt wrote: Timo Rothenpieler: On 16.06.2025 14:55, James Almer wrote: On 6/16/2025 9:38 AM, Timo Rothenpieler wrote: On 13/06/2025 16:07, Timo Rothenpieler wrote

Re: [FFmpeg-devel] [PATCH] avcodec/speexdec: consider differing frame sizes in remaining space check

2025-06-27 Thread James Almer
On 6/27/2025 1:14 PM, Michael Niedermayer wrote: Fixes: talk109-q5.spx Can this file be added to FATE? Regression since: f6986e75be87f512f65d64ac91ba19d505a8d210 Signed-off-by: Michael Niedermayer --- libavcodec/speexdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH] avformat/apvdec: add framerate option

2025-06-26 Thread James Almer
Based on code from rawvideo demuxer. Signed-off-by: James Almer --- libavformat/apvdec.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/libavformat/apvdec.c b/libavformat/apvdec.c index 1e5497bcd3..70f6babbb7 100644 --- a/libavformat/apvdec.c

[FFmpeg-devel] [PATCH] avformat/iamf_parse: prevent overreads in update_extradata

2025-06-23 Thread James Almer
process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: James Almer --- libavformat/iamf_parse.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c index 71497876ac..46a74ea679 100644 ---

Re: [FFmpeg-devel] [PATCH 1/4] avformat/iamf_parse: Check extradata size

2025-06-23 Thread James Almer
On 6/23/2025 12:14 PM, James Almer wrote: On 6/23/2025 9:57 AM, Andreas Rheinhardt wrote: James Almer: On 6/23/2025 9:44 AM, Michael Niedermayer wrote: On Fri, Jun 20, 2025 at 12:28:13AM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: Assertion n>=0 && n<

Re: [FFmpeg-devel] [PATCH 1/4] avformat/iamf_parse: Check extradata size

2025-06-23 Thread James Almer
On 6/23/2025 9:57 AM, Andreas Rheinhardt wrote: James Almer: On 6/23/2025 9:44 AM, Michael Niedermayer wrote: On Fri, Jun 20, 2025 at 12:28:13AM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: Assertion n>=0 && n<=32 failed at ./libavcodec/get_bits.h:406 Fi

Re: [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check that sample_count is allocated in mov_parse_heif_items()

2025-06-23 Thread James Almer
On 6/21/2025 6:15 PM, Michael Niedermayer wrote: Fixes: NULL pointer dereference Fixes: 416811958/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5425269114732544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

Re: [FFmpeg-devel] [PATCH 1/4] avformat/iamf_parse: Check extradata size

2025-06-23 Thread James Almer
On 6/23/2025 9:44 AM, Michael Niedermayer wrote: On Fri, Jun 20, 2025 at 12:28:13AM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: Assertion n>=0 && n<=32 failed at ./libavcodec/get_bits.h:406 Fixes: 398527871/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-6602025714647040

[FFmpeg-devel] [PATCH 2/2] avcodec/mss2dsp: use FF_PTR_ADD to add offsets to a pointer

2025-06-23 Thread James Almer
Fixes: libavcodec/mss2dsp.c:59:14: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clang-cl-

[FFmpeg-devel] [PATCH v2 2/2] avcodec/mss2dsp: use FF_PTR_ADD to add offsets to a pointer

2025-06-22 Thread James Almer
Fixes: libavcodec/mss2dsp.c:59:14: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clang-cl-

[FFmpeg-devel] [PATCH] avcodec/ffv1enc_template: use FF_PTR_ADD to add offsets to a pointer

2025-06-22 Thread James Almer
Fixes: libavcodec\ffv1enc_template.c:75:79: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clan

Re: [FFmpeg-devel] [PATCH v5 07/13] avfilter/x86/f_ebur128: add x86 AVX implementation

2025-06-20 Thread James Almer
On 6/20/2025 10:21 AM, Niklas Haas wrote: From: Niklas Haas Processes two channels in parallel, using 128-bit XMM registers. In theory, we could go up to YMM registers to process 4 channels, but this is not a gain except for relatively high channel counts (e.g. 7.1), and also complicates the s

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mov: Check that sample_sizes is allocated in mov_parse_heif_items()

2025-06-19 Thread James Almer
On 6/19/2025 9:32 PM, Michael Niedermayer wrote: Fixes: NULL pointer dereference Fixes: 416811958/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5425269114732544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

Re: [FFmpeg-devel] [PATCH 1/2] configure: cbs_apv depends on cbs

2025-06-17 Thread James Almer
On 6/17/2025 8:19 PM, Peter Ross wrote: --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index e2e9fc26d8..bfe5f5bbee 100755 --- a/configure +++ b/configure @@ -2869,6 +2869,7 @@ w32threads_deps="atomics_native" threads_if_any="$THREADS_LIST" # sub

[FFmpeg-devel] [PATCH 9/9] avformat/iamf_writer: use named constants in more places

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index ad40871fa1..4302df7931 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat/iamf_writer.c @@ -783,7

[FFmpeg-devel] [PATCH 8/9] avformat/iamf_writer: reindent after previous commit

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 37e75dc01a..ad40871fa1 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat/iamf_writer.c

[FFmpeg-devel] [PATCH 7/9] avformat/iamf_writer: add extra constrains for Parameter Sets in Audio Elements

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 40 --- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 635d1989ef..37e75dc01a 100644 --- a/libavformat/iamf_writer.c +++ b

[FFmpeg-devel] [PATCH 6/9] avformat/iamf_writer: factorize out getting loudspeaker_layout values

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 65 +++ 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 86d09c3308..635d1989ef 100644 --- a/libavformat/iamf_writer.c +++ b

[FFmpeg-devel] [PATCH 5/9] avformat/iamf: fix setting channel layout for Scalable layers

2025-06-17 Thread James Almer
stereo, fltp (dependent) Stream #0:5[0x5]: Audio: opus, 48000 Hz, stereo, fltp (dependent) Signed-off-by: James Almer --- libavformat/iamf_parse.c | 77 +-- libavformat/iamf_writer.c | 28 +-- libavformat/iamfdec.c

[FFmpeg-devel] [PATCH 4/9] tests/iamf: rename BACK to SIDE filterchain labels in the 5.1.4 iamf tests

2025-06-17 Thread James Almer
Cosmetic change to reflect the actual channels used in the layouts. Signed-off-by: James Almer --- tests/fate/iamf.mak | 2 +- tests/fate/mov.mak| 2 +- tests/filtergraphs/iamf_5_1_4 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/iamf.mak

[FFmpeg-devel] [PATCH 3/9] tests/iamf: reorder muxed streams

2025-06-17 Thread James Almer
Follows the proper order defined by the spec, even if mostly cosmetic, and is also preparation for a following change. Signed-off-by: James Almer --- tests/fate/iamf.mak | 4 +- tests/fate/mov.mak| 4 +- tests/ref/fate/iamf-9_1_6 | 82 +++ 3

[FFmpeg-devel] [PATCH 2/9] avformat/iamf_parse: try to retype the channel layout for ambisonics_mode == 0

2025-06-17 Thread James Almer
In most cases, the channel ids will match the standard Ambisonic Order, saving us the need to use a custom order layout. Signed-off-by: James Almer --- libavformat/iamf_parse.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/iamf_parse.c b

[FFmpeg-devel] [PATCH 1/9] avformat/iamf_writer: ensure each layer's channel layout contains all channels from the previous one

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 60a0990504..e34afb9a2c 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH WIP 01/10] ffbuild/bin2c: Use zlib directly instead of gzip

2025-06-17 Thread James Almer
On 6/16/2025 5:18 PM, softworkz . wrote: But why that? If we include the decompression code (that's why I've been searching for the most compact implementations available with compatible licenses), then we won't have any zlib dependency anymore - neither at build- nor at run-time. We don't add so

Re: [FFmpeg-devel] [PATCH 3/4] avformat/sbgdec: fix leak in sbg_read_header()

2025-06-17 Thread James Almer
On 6/17/2025 11:23 AM, Nicolas George wrote: Lidong Yan (HE12025-06-17): In sbg_read_header(), if avformat_new_stream() failed, it returns without cleanup, which may cause memory leaks. Replace return statement with goto so that we would first clean up then return. Signed-off-by: Lidong Yan <50

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-06-16 Thread James Almer
On 6/16/2025 2:26 PM, Timo Rothenpieler wrote: On 16.06.2025 14:55, James Almer wrote: On 6/16/2025 9:38 AM, Timo Rothenpieler wrote: On 13/06/2025 16:07, Timo Rothenpieler wrote: On 10/06/2025 00:09, Andreas Rheinhardt wrote: James Almer: On 6/9/2025 5:59 PM, Timo Rothenpieler wrote: On

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-06-16 Thread James Almer
On 6/9/2025 7:09 PM, Andreas Rheinhardt wrote: James Almer: On 6/9/2025 5:59 PM, Timo Rothenpieler wrote: On 08.06.2025 17:45, James Almer wrote: On 6/8/2025 11:29 AM, Andreas Rheinhardt wrote: Timo Rothenpieler: From: James Almer I don't like that you add another allocator for

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-06-16 Thread James Almer
On 6/16/2025 9:38 AM, Timo Rothenpieler wrote: On 13/06/2025 16:07, Timo Rothenpieler wrote: On 10/06/2025 00:09, Andreas Rheinhardt wrote: James Almer: On 6/9/2025 5:59 PM, Timo Rothenpieler wrote: On 08.06.2025 17:45, James Almer wrote: On 6/8/2025 11:29 AM, Andreas Rheinhardt wrote

Re: [FFmpeg-devel] [RFC] statictrac, trac and caching

2025-06-15 Thread James Almer
On 6/15/2025 10:35 AM, Michael Niedermayer wrote: Hi all As it seems someone figured out how to make AI solve anubis, which made trac rather slow due to the DDOS from 100 different IPs, which eventually we had to block. (maybe timo has time to write an incident report?) Some questions * does so

Re: [FFmpeg-devel] [RFC] statictrac, trac and caching

2025-06-15 Thread James Almer
On 6/15/2025 10:42 AM, Michael Niedermayer wrote: Hi On Sun, Jun 15, 2025 at 03:35:15PM +0200, Michael Niedermayer wrote: Hi all As it seems someone figured out how to make AI solve anubis, which made trac rather slow due to the DDOS from 100 different IPs, which eventually we had to block.

Re: [FFmpeg-devel] [PATCH v2 07/13] avfilter/x86/f_ebur128: add x86 AVX implementation

2025-06-13 Thread James Almer
On 6/13/2025 1:37 PM, Niklas Haas wrote: From: Niklas Haas Processes two channels in parallel, using 128-bit XMM registers. In theory, we could go up to YMM registers to process 4 channels, but this is not a gain except for relatively high channel counts (e.g. 7.1), and also complicates the sa

[FFmpeg-devel] [PATCH 3/3] avutil/aes: add an OpenSSL-libcrypto backed implementation

2025-06-10 Thread James Almer
OpenSSL has optimizations for more architectures than x86-AESNI, so use it if libavutil is configured with libcrypto explicitly (Enabling OpenSSL alone will not make use of it). Signed-off-by: James Almer --- configure| 8 +++- libavutil/aes.c | 37

[FFmpeg-devel] [PATCH 1/3] avutil/aes_ctr: rename AES_BLOCK_SIZE to FF_AES_BLOCK_SIZE

2025-06-10 Thread James Almer
This is in preparation for the following commit, to prevent redefinitions from namespace collisions. Signed-off-by: James Almer --- libavutil/aes_ctr.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavutil/aes_ctr.c b/libavutil/aes_ctr.c index

[FFmpeg-devel] [PATCH 2/3] avutil/aes: remove superfluous rounds argument

2025-06-10 Thread James Almer
It's set during int and never changed. Signed-off-by: James Almer --- libavutil/aes.c | 10 +- libavutil/aes_internal.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavutil/aes.c b/libavutil/aes.c index 3c8ac1c349..7fe42a5548 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-06-09 Thread James Almer
On 6/9/2025 5:59 PM, Timo Rothenpieler wrote: On 08.06.2025 17:45, James Almer wrote: On 6/8/2025 11:29 AM, Andreas Rheinhardt wrote: Timo Rothenpieler: From: James Almer I don't like that you add another allocator for this; instead we should add a generic allocator for the frame side

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-06-08 Thread James Almer
On 6/8/2025 11:29 AM, Andreas Rheinhardt wrote: Timo Rothenpieler: From: James Almer As defined in section G.14.3.2.3 of ITU-T H.265, it's required for proper signaling of MV-HEVC. Signed-off-by: James Almer --- libavutil/Makefile | 2 + libavutil/tdrdi.c

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: List types and checksums for for side data

2025-06-07 Thread James Almer
On 5/18/2025 6:23 PM, Michael Niedermayer wrote: On Sun, May 18, 2025 at 11:43:14AM -0300, James Almer wrote: On 5/18/2025 9:25 AM, Michael Niedermayer wrote: This allows detecting changes and regressions in side data related code, same as what framecrc does for before already for packet data

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

2025-06-07 Thread James Almer
On 6/5/2025 9:14 PM, James Almer wrote: The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer. Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 16 +--- 1 file changed

[FFmpeg-devel] [PATCH v2 1/4] avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

2025-06-05 Thread James Almer
The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer. Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

2025-06-05 Thread James Almer
On 6/5/2025 9:32 PM, Andreas Rheinhardt wrote: James Almer: On 6/5/2025 9:29 PM, Andreas Rheinhardt wrote: James Almer: The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer. Signed-off-by

[FFmpeg-devel] [PATCH v2 2/4] avcodec/ac3_parser: handle more header bits in ff_ac3_parse_header()

2025-06-05 Thread James Almer
Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 219 +++ libavcodec/ac3_parser_internal.h | 19 +++ libavcodec/ac3dec.c | 88 +++-- libavcodec/ac3dec.h | 4 +- libavcodec/ac3defs.h | 2 + libavcodec

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

2025-06-05 Thread James Almer
On 6/5/2025 9:29 PM, Andreas Rheinhardt wrote: James Almer: The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer. Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 16

[FFmpeg-devel] [PATCH v2 3/4] avformat/movenc: fix writing reserved bits in EC3SpecificBox

2025-06-05 Thread James Almer
As described in section F.6.1 from ETSI TS 102 366. Found-by: nyanmisaka Signed-off-by: James Almer --- libavformat/movenc.c | 2 +- tests/ref/fate/copy-trac3074 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

[FFmpeg-devel] [PATCH v2 4/4] avformat/movenc: handle EAC-3 extension bits for Atmos

2025-06-05 Thread James Almer
From: nyanmisaka Fixes commit #9996. Signed-off-by: James Almer --- libavformat/movenc.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7bcdc2463d..cd5b45f6fe 100644 --- a/libavformat/movenc.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

2025-06-05 Thread James Almer
On 6/5/2025 9:14 PM, James Almer wrote: The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer. Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 16 +--- 1 file changed

[FFmpeg-devel] [PATCH 1/4] avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

2025-06-05 Thread James Almer
The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer. Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: handle EAC-3 extension bits for Atmos

2025-06-05 Thread James Almer
From: nyanmisaka Fixes commit #9996. Signed-off-by: James Almer --- libavformat/movenc.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 25360b004d..b546c8b545 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 2/3] avformat/movenc: fix writing reserved bits in EC3SpecificBox

2025-06-05 Thread James Almer
As described in section F.6.1 from ETSI TS 102 366. Found-by: nyanmisaka Signed-off-by: James Almer --- libavformat/movenc.c | 2 +- tests/ref/fate/copy-trac3074 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

[FFmpeg-devel] [PATCH 1/3] avcodec/ac3_parser: handle more header bits in ff_ac3_parse_header()

2025-06-05 Thread James Almer
Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 218 +++ libavcodec/ac3_parser_internal.h | 19 +++ libavcodec/ac3dec.c | 88 +++-- libavcodec/ac3dec.h | 4 +- libavcodec/ac3defs.h | 2 + libavcodec

Re: [FFmpeg-devel] [PATCH] avformat/format: make experimental flag works for muxer

2025-06-05 Thread James Almer
On 6/5/2025 1:06 PM, Zhao Zhili wrote: From: Zhao Zhili --- libavformat/avformat.h | 3 +-- libavformat/format.c | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 2034d2aecc..6edcf11022 100644 --- a/libavformat/avf

Re: [FFmpeg-devel] [PATCH] avformat/whip: set this muxer as experimental

2025-06-05 Thread James Almer
On 6/5/2025 11:54 AM, Jack Lau via ffmpeg-devel wrote: Signed-off-by: Jack Lau --- libavformat/whip.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/whip.c b/libavformat/whip.c index 0671e23635..e7cd57400d 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -173

[FFmpeg-devel] [PATCH] avformat/mov: add more sanity checks when reading clap boxes

2025-06-04 Thread James Almer
If the apperture window is bigger than the canvas, then the clap box is invalid and there's no point calculating cropping values. Fixes: libavformat/mov.c:1295:14: runtime error: -256 is outside the range of representable values of type 'unsigned long' Signed-off-

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-03 Thread James Almer
On 6/3/2025 1:40 PM, Nicolas George wrote: James Almer (HE12025-06-03): The first sentence was unnecessary. No need to be this aggressive. “softworks” has been abusing many people in the last week but it is Lynne that you decide to chide? I missed it if he was aggressive to someone else

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-03 Thread James Almer
The first sentence was unnecessary. No need to be this aggressive. On 6/3/2025 1:00 PM, Lynne wrote: You don't get to say "oh, there were no more objections, so it was fine" or "the use is evident" after the mess that your original patchsets were. You're still not using the native time fields,

[FFmpeg-devel] [PATCH] avutil/x86/intmath: remove inline asm implementations for clip functions

2025-06-02 Thread James Almer
ntial speedup. x86_32 builds targetting anything made in the last two decades and a half should use -msse -mfp=sse anyway. Signed-off-by: James Almer --- libavutil/x86/intmath.h | 62 - 1 file changed, 62 deletions(-) diff --git a/libavutil/x86/intmat

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilterPriv private again

2025-06-01 Thread James Almer
On 6/1/2025 11:07 PM, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of softworkz . Sent: Samstag, 31. Mai 2025 03:44 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilte

Re: [FFmpeg-devel] [RFC] Cherry picks vs merges

2025-06-01 Thread James Almer
On 6/1/2025 4:23 PM, Michael Niedermayer wrote: Hi James On Sun, Jun 01, 2025 at 02:27:37PM -0300, James Almer wrote: On 6/1/2025 12:22 PM, Michael Niedermayer wrote: Hi all almpeg is now merged upto 1 months ago. (and since last merge it contains bits of AGPL code) The question now is, how

Re: [FFmpeg-devel] [RFC] Cherry picks vs merges

2025-06-01 Thread James Almer
On 6/1/2025 12:22 PM, Michael Niedermayer wrote: Hi all almpeg is now merged upto 1 months ago. (and since last merge it contains bits of AGPL code) The question now is, how does the community want to proceed from here? Full stop. Not only you're trying to bypass explicit a license notice on

  1   2   3   4   5   6   7   8   9   10   >