Re: [FFmpeg-devel] [PATCH] lavd/v4l2: produce a 0 byte packet when a dequeued buffer is flagged with V4L2_BUF_FLAG_ERROR

2015-05-08 Thread Giorgio Vazzana
sd and openbsd. >> >> http://fate.ffmpeg.org/log.cgi?time=20150508171126&log=compile&slot=x86_64-netbsd-clang-noopt >> http://fate.ffmpeg.org/log.cgi?time=20150508182740&log=compile&slot=x86_64-openbsd5.6-gcc4.8 > > should be fixed Sorry and thank you James and Michae

[FFmpeg-devel] [PATCH] lavd/v4l2: produce a 0 byte packet when a dequeued buffer is flagged with V4L2_BUF_FLAG_ERROR

2015-05-08 Thread Giorgio Vazzana
Hi, this patch fixes ticket #4030. Users have tested it and they confirm it solves the problem. Giorgio Vazzana From 5f1b247ee7c47821da301eddad539f8e35652cf5 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 8 May 2015 17:25:15 +0200 Subject: [PATCH] lavd/v4l2: produce a 0 byte packet

[FFmpeg-devel] [PATCH] lavd/v4l2: fix typo

2015-05-08 Thread Giorgio Vazzana
From 55f35aaea4b1aaf59e3a7620e0ca0e078c8c2010 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 8 May 2015 17:42:34 +0200 Subject: [PATCH] lavd/v4l2: fix typo This was introduced in cde6e328de214ffe8387641cdc1e433a2c2150f3 --- libavdevice/v4l2.c |2 +- 1 file changed, 1 insertion

[FFmpeg-devel] [PATCH] lavd/v4l2: print buffer flags in case of error

2015-04-24 Thread Giorgio Vazzana
Hello, I wrote this simple patch a while back trying to solve ticket #4030, but I think we might as well apply it as it would make debugging easier in general. Giorgio Vazzana From 1b471609878a9982960bf25e921c560e595ad667 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Thu, 16 Oct 2014 11

[FFmpeg-devel] [PATCH] ffmpeg: fix option name in documentation

2015-03-24 Thread Giorgio Vazzana
Hi, $ ffmpeg -h full 2>/dev/null | grep thread_queue_size -thread_queue_size set the maximum number of queued packets from the demuxer Giorgio Vazzana From 15e9d7d8d3e23ec7a0649b36f104c755c5a33783 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Tue, 24 Mar 2015 20:20:45 +0100 Subj

Re: [FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-18 Thread Giorgio Vazzana
Hi, 2015-02-14 11:12 GMT+01:00 Giorgio Vazzana : > Hi, > > 2015-02-14 9:33 GMT+01:00 supraja reddy : >> Hello, >> >> I have added the necessary functions for twofish in crypto_bench. >> A note, there is no twofish implementation in openssl library but since

Re: [FFmpeg-devel] libavutil: optimize camellia cipher

2015-02-14 Thread Giorgio Vazzana
Hi Supraja, could you also post the result of crypto_bench now to see how fast our implementation is compared to the others? Thanks. Giorgio Vazzana ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-14 Thread Giorgio Vazzana
let's see if others have comments. Giorgio Vazzana ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-28 Thread Giorgio Vazzana
s used for >> encryption/decryption >> > + * @param key_bits number of keybits: 128, 192, 256 If less than the >> required, padded with zeroes to nearest valid value >> > + */ >> >> You need to document the return values of t

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-26 Thread Giorgio Vazzana
Hi, 2015-01-25 20:00 GMT+01:00 supraja reddy : > Sorry. I forgot to make a small change. Updated the patch. > +for (i = 0; i < cs->ksize; i++) { > +Me[i] = Key[2 * i]; > +Mo[i] = Key[2 * i + 1]; > +} > +for (i = 0; i < cs->ksize; i++) > +cs->S[cs->ksize - i - 1

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-24 Thread Giorgio Vazzana
gt; +/* > + * An implementation of the TwoFish algorithm > + * Copyright (c) 2015 Supraja Meedinti > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > +

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-19 Thread Giorgio Vazzana
, 0x09, 0x0a, 0x00, 0x0e, 0x0d, >> 0x08, 0x02, 0x0b, 0x03, 0x0f, >> +0x0b, 0x09, 0x05, 0x01, 0x0c, 0x03, 0x0d, 0x0e, 0x06, 0x04, 0x07, >> 0x0f, 0x02, 0x00, 0x08, 0x0a} >> +}; >> + >> +struct AVTWOFISH *av_twofish_alloc(void) >> +{ >> +ret

Re: [FFmpeg-devel] [PATCH 1/2] lavd/v4l2: implement list device callback

2015-01-03 Thread Giorgio Vazzana
2015-01-03 4:45 GMT+01:00 Lukasz Marek : > On 21 December 2014 at 23:39, Lukasz Marek wrote: > >> On 21.12.2014 22:43, Lukasz Marek wrote: >> >>> Signed-off-by: Lukasz Marek >>> --- >>> libavdevice/v4l2.c | 58 ++ >>> >>> 1 file changed, 58

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2015-01-02 Thread Giorgio Vazzana
ost important to less important. > maybe you can add a fate test for it Yes please, a fate test would be nice. Giorgio Vazzana From bdd85f3b5727f0e64f4bbae02c9023b379e50f4c Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 2 Jan 2015 16:33:17 +0100 Subject: [PATCH 1/4] avutil/camellia

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-30 Thread Giorgio Vazzana
} > +av_free(cs); > +return err; > +} > +#endif > diff --git a/libavutil/camellia.h b/libavutil/camellia.h > new file mode 100644 > index 000..41076d4 > --- /dev/null > +++ b/libavutil/camellia.h > @@ -0,0 +1,68 @@ > +/* > + * An implem

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-27 Thread Giorgio Vazzana
2014-12-26 20:01 GMT+01:00 Michael Niedermayer : > [...] > >> +static uint64_t F(uint64_t F_IN, uint64_t KE) >> +{ >> +uint32_t Zl, Zr; > >> +Zl = (F_IN >> 32) ^ (KE >> 32); >> +Zr = (F_IN & MASK32) ^ (KE & MASK32); > > KE ^= F_IN; > Zl = KE >> 32; > Zr = KE & MASK32; > > >> +Zl = (

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-27 Thread Giorgio Vazzana
Hi, 2014-12-24 23:41 GMT+01:00 supraja reddy : > Hello, > > Thank you for your reviews. I have attached the updated patch . > > You are using a single array K for all the keys, without distinguishing >> between >> kw, k and ke as in the rfc. This makes code harder to read/maintain with no >> real

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-24 Thread Giorgio Vazzana
Hello Supraja, 2014-12-23 18:38 GMT+01:00 supraja reddy : > I have attached the patch to the basic implementation of camellia block > cipher. Please let me know if there are any bugs to be fixed or if any > further optimization needed. thanks for the patch and thank you Michael for the first revi

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-18 Thread Giorgio Vazzana
rypt a buffer using a previously initialized context > + * > + * @param ctx an AVCAST5 context > + * @param dst destination array, can be equal to src > + * @param src source array, can be equal to dst > + * @param count number of 8 byte blocks > + * @param iv initialization vector for CBC mode, NULL for ECB mode > + * @param decrypt 0 for encryption, 1 for decryption > + */ > +void av_cast5_crypt2(struct AVCAST5 *ctx, uint8_t *dst, const uint8_t *src, > int count, uint8_t *iv, int decrypt); > /** > * @} > */ > -- > 1.8.3.2 > the rest LGTM, thanks. Giorgio Vazzana ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-18 Thread Giorgio Vazzana
Hello, 2014-12-17 19:53 GMT+01:00 supraja reddy : > I hope this fixes all the issues . > From 16c8db86ebf92f68a8a750dcbe5e3598a8bd69b5 Mon Sep 17 00:00:00 2001 > From: Supraja Meedinti > Date: Thu, 18 Dec 2014 00:17:45 +0530 > Subject: [PATCH] libavutil: Added cbc mode to cast128 > > Signed-off-

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-17 Thread Giorgio Vazzana
t; +dst[i] = src[i] ^ iv[i]; >> +encipher(cs, dst, dst); > > Indentation in the new code is wrong. thank you Carl for the review, I agree all your points are valid. There seems to be a bigger problem with this patch though, the IV ve

Re: [FFmpeg-devel] libavutil : cosmetic: added spaces wherever necessary

2014-12-16 Thread Giorgio Vazzana
for (i = 0; i < 100; i++){ > +av_cast5_init(cs, rpt2[1], 128); > +av_cast5_crypt(cs, rpt2[0], rpt2[0], 2, 0); > +av_cast5_init(cs, rpt2[0], 128); > +av_cast5_crypt(cs, rpt2[1], rpt2[1], 2, 0); > } > -for (j=0;j<2;j++

Re: [FFmpeg-devel] [PATCH] v4l2: setting device parameters early

2014-11-08 Thread Giorgio Vazzana
2014-11-06 12:47 GMT+01:00 Giorgio Vazzana : > Hi, > > 2014-11-05 21:54 GMT+01:00 Michael Niedermayer : >> On Wed, Oct 22, 2014 at 04:12:31PM +0200, Giorgio Vazzana wrote: >>> Hello, >>> >>> this was probably wrong and has caused >> >> i c

Re: [FFmpeg-devel] [PATCH] v4l2: setting device parameters early

2014-11-06 Thread Giorgio Vazzana
Hi, 2014-11-05 21:54 GMT+01:00 Michael Niedermayer : > On Wed, Oct 22, 2014 at 04:12:31PM +0200, Giorgio Vazzana wrote: >> Hello, >> >> this was probably wrong and has caused > > i can revert it if you want ? I will sent a patch for testing on that ticket later and

[FFmpeg-devel] [PATCH] lavd/v4l2: use pixel format variable names consistently

2014-11-06 Thread Giorgio Vazzana
From c373c413bd2d27463a45e50c5827975e579b6e7c Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Thu, 6 Nov 2014 11:30:41 +0100 Subject: [PATCH] lavd/v4l2: use pixel format variable names consistently We now use 'pixelformat' for V4L2_PIX_FMT_* (as they do in v4l2 documentation) an

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

2014-10-29 Thread Giorgio Vazzana
2014-10-21 12:26 GMT+02:00 Stefano Sabatini : > On date Tuesday 2014-10-21 03:56:06 -0300, James Almer encoded: >> No need to keep the old symbols around until a major bump since lavd >> functions >> with the avpriv_ prefix were never exposed. >> >> Signed-off-by: James Almer > > LGTM. Ping. Any

Re: [FFmpeg-devel] [PATCH] v4l2: setting device parameters early

2014-10-22 Thread Giorgio Vazzana
Hello, this was probably wrong and has caused https://trac.ffmpeg.org/ticket/3517 . Will investigate. Giorgio Vazzana 2014-01-05 17:17 GMT+01:00 Michael Niedermayer : > On Sun, Jan 05, 2014 at 12:33:42PM +0100, Federico Simoncelli wrote: >> Any feedback? > > looks good, thus app

[FFmpeg-devel] [PATCH] libavutil: Add missing av_free() to cast5 selftest

2014-10-18 Thread Giorgio Vazzana
Hi, this should make fate green again. Giorgio Vazzana From 769cd50d4d3ba4a6f62db3c2599ba653e919e94a Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Sat, 18 Oct 2014 16:50:59 +0200 Subject: [PATCH] libavutil: Add missing av_free() to cast5 selftest --- libavutil/cast5.c |1 + 1 file

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-16 Thread Giorgio Vazzana
Hi, 2014-10-16 5:32 GMT+02:00 Michael Niedermayer : > On Thu, Oct 16, 2014 at 03:25:42AM +0530, supraja reddy wrote: >> Extremely sorry for resending the patch . There was a trailing whitespace >> which I hadn't corrected . >> All the changes are done . >> Please let me if any changes needed furth

Re: [FFmpeg-devel] gnome-opw 2015

2014-10-13 Thread Giorgio Vazzana
Hi, 2014-10-13 22:07 GMT+02:00 Nikita Mantri : > Hi, > For the generic CMAC module, can I reuse the code of md5 and sha from > libavutil, or should I implement this hash function again. You can reuse the existing code, of course. ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] opw@ffmpeg mail alias

2014-10-13 Thread Giorgio Vazzana
2014-10-13 3:49 GMT+02:00 Michael Niedermayer : > Hi all > > does any mentor want to be added to the opw@ffmpeg alias > if so, tell me and ill add you Sure, add me, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/l

Re: [FFmpeg-devel] gnome-opw 2015

2014-10-12 Thread Giorgio Vazzana
Hello Nikita, we already have a HMAC module in libavutil, so you could try to implement "The AES-CMAC Algorithm", RFC 4493. Michael, would this be acceptable for you? Giorgio Vazzana 2014-10-12 19:17 GMT+02:00 Nikita Mantri : > Hi, > Thanks for your response. I want to co

Re: [FFmpeg-devel] gnome-opw 2015

2014-10-12 Thread Giorgio Vazzana
Hi Michael, 2014-10-12 18:11 GMT+02:00 Michael Niedermayer : > On Sun, Oct 12, 2014 at 05:49:54PM +0200, Giorgio Vazzana wrote: >> 2014-10-12 2:18 GMT+02:00 Michael Niedermayer : >> > Hi >> > >> > On Sun, Oct 12, 2014 at 02:51:36AM +0530, Nikita Mantri wr

Re: [FFmpeg-devel] gnome-opw 2015

2014-10-12 Thread Giorgio Vazzana
e so popular!) Anyway if you still want to try let us know and together with you we will choose a suitable qualification task (the ones that Michael proposed are fine with me). You will have only ten days to complete your qualification task and submit your application, but depending on your level

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-12 Thread Giorgio Vazzana
2014-10-12 13:59 GMT+02:00 supraja reddy : > Hello , > > I , Supraja , am interested to work with ffmpeg as a part of OPW internship > . As a part of the qualification task , I have taken up the implementation > of Cast 128 algorithm implementation . I have written the code for the same > and have

Re: [FFmpeg-devel] Please help update tasks and mentor/backups for OPW

2014-09-26 Thread Giorgio Vazzana
he currently listed mentors so > they can hopefully help with the latter. I am still available as a mentor for the Symmetric-key block ciphers project. Regards, Giorgio Vazzana ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-09-05 Thread Giorgio Vazzana
.4. Regards, Giorgio Vazzana ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 5/5] lavd/v4l2: simplify list_formats()

2014-09-05 Thread Giorgio Vazzana
From 5ab8d5700c69033fd5dc27d49525df84863a38f9 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 5 Sep 2014 17:43:59 +0200 Subject: [PATCH 5/5] lavd/v4l2: simplify list_formats() We can avoid passing file descriptor fd explicitely. --- libavdevice/v4l2.c |6 +++--- 1 file changed, 3

[FFmpeg-devel] [PATCH 2/5] lavd/v4l2: simplify first_field()

2014-09-05 Thread Giorgio Vazzana
From 5642dbb81dadff02c63b454726b1ca4c99ee1c2c Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 5 Sep 2014 17:24:43 +0200 Subject: [PATCH 2/5] lavd/v4l2: simplify first_field() There is no need to pass fd as a second parameter. Additionally remove unneeded curly braces. --- libavdevice

[FFmpeg-devel] [PATCH 1/5] lavd/v4l2: Replace s1 with ctx for consistency.

2014-09-05 Thread Giorgio Vazzana
From b85da403cb0856887d4a657aa706b6cdfbb619e0 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 5 Sep 2014 17:12:39 +0200 Subject: [PATCH 1/5] lavd/v4l2: Replace s1 with ctx for consistency. No functional change in the code. --- libavdevice/v4l2.c | 114

[FFmpeg-devel] [PATCH 3/5] lavd/v4l2: remove unneeded variable in device_init()

2014-09-05 Thread Giorgio Vazzana
From fab5a8ac8d2151dce5384c6ff70d5dee25e72066 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 5 Sep 2014 17:34:51 +0200 Subject: [PATCH 3/5] lavd/v4l2: remove unneeded variable in device_init() --- libavdevice/v4l2.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[FFmpeg-devel] [PATCH 4/5] lavd/v4l2: simplify list_framesizes()

2014-09-05 Thread Giorgio Vazzana
From 7b62611a54861e5d972e61c94a00a843aca44b19 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 5 Sep 2014 17:39:50 +0200 Subject: [PATCH 4/5] lavd/v4l2: simplify list_framesizes() We can avoid passing file descriptor fd explicitely. --- libavdevice/v4l2.c |6 +++--- 1 file changed

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as lavd/v4l2 maintainer

2014-09-05 Thread Giorgio Vazzana
Hello, here's a patch to add myself as a maintainer for lavd/v4l2. I asked Luca about this a while back and he was fine with this change. Regards, Giorgio Vazzana From 17faef15e981fe6797455084c0212927a2a99357 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Fri, 5 Sep 2014 16:26:11

Re: [FFmpeg-devel] [PATCH 1/1] libavdevice/v4l2: fix descriptors leak on error paths

2014-09-04 Thread Giorgio Vazzana
2014-09-03 13:46 GMT+02:00 : > From: Dmitry Volyntsev > > Signed-off-by: Dmitry Volytnsev > --- > libavdevice/v4l2.c | 37 - > 1 file changed, 20 insertions(+), 17 deletions(-) LGTM too, thanks. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-09-02 Thread Giorgio Vazzana
2014-09-02 2:07 GMT+02:00 Michael Niedermayer : > should i apply the previous patch or wait ? Let's wait some days so that Dmitry can test the patch if he wants to and give us some feedback. > also if you want, you can add yourself to the v4l2 maintainers in the > MAINTAINERs file, as you seem to

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-09-01 Thread Giorgio Vazzana
2014-09-01 22:46 GMT+02:00 Reimar Döffinger : > On Mon, Sep 01, 2014 at 10:33:15PM +0200, Giorgio Vazzana wrote: >> +static int enqueue_buffer(struct video_data *s, struct v4l2_buffer *buf) >> +{ >> +int res = 0; >> + >> +if (v4l2_ioctl(s->fd, VIDI

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-09-01 Thread Giorgio Vazzana
Hello, as Reimar pointed out the proposed patch is not the correct solution. Please see/test attached patch. Regards, Giorgio Vazzana 2014-08-31 14:35 GMT+02:00 Dmitry Volyntsev : >>why is this condition true ? > > I tried several configuration and problem occurred only u