Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: increase precision of Sleep() on Windows

On Mon, Nov 27, 2023 at 3:05 PM Henrik Gramner via ffmpeg-devel wrote: > > On Mon, Nov 27, 2023 at 2:42 PM Mark Thompson wrote: > > Is it reasonable to set this global state from a library without the parent > > program knowing? We'd really prefer not to affect the global state > > unexpectedl

Re: [FFmpeg-devel] [PATCH 8/9] avfilter/scale_amf: Add AMF HW scaler & color converter

On Wed, Feb 14, 2024 at 5:26 PM Dennis Mungai wrote: > On Wed, 14 Feb 2024, 18:28 Evgeny Pavlov, wrote: > > > On Wed, Feb 14, 2024 at 4:08 PM Timo Rothenpieler > > > wrote: > > > > > On 14/02/2024 02:55, Dmitrii Ovchinnikov wrote: > > > > From:

Re: [FFmpeg-devel] [PATCH 8/9] avfilter/scale_amf: Add AMF HW scaler & color converter

On Wed, Feb 14, 2024 at 4:08 PM Timo Rothenpieler wrote: > On 14/02/2024 02:55, Dmitrii Ovchinnikov wrote: > > From: Evgeny Pavlov > > > > This commit adds two AMF filters: scale_amf & scale_amf_hq. > > Both filters are using AMF hardware acceleration. > &

Re: [FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

On Mon, Dec 11, 2023 at 10:21 PM Mark Thompson wrote: > > Not the same, but here is a freely-available test video which has the same > effect: . Output below. > > It doesn't seem like this should be dependent on the underlying hardware > since (I

Re: [FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

On Wed, Nov 29, 2023 at 11:57 AM Evgeny Pavlov wrote: > On Tue, Nov 28, 2023 at 8:13 PM Mark Thompson wrote: > >> I upgraded to 23.11.1 and see no change - the colour information is still >> missing in the header but not the stream, and the two different sequence >> para

Re: [FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

On Tue, Nov 28, 2023 at 8:13 PM Mark Thompson wrote: > I upgraded to 23.11.1 and see no change - the colour information is still > missing in the header but not the stream, and the two different sequence > parameter sets are identical to what they were before the change. > > Can you share what yo

Re: [FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

On Mon, Nov 27, 2023 at 8:47 PM Mark Thompson wrote: > There is something very wrong with how the header information is working > here. > > With this series applied, I ran: > > ffmpeg_g.exe -report -y -i in.mp4 -an -c:v hevc_amf -bsf:v trace_headers > -frames:v 1 out.mp4 > > My input file is: > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

> > > Seems like we could template this to avoid the duplication, something like: > > #define PER_CODEC_OPTION(name) \ >(ctx->codec == AV1 ? AMF_VIDEO_ENCODER_AV1_ ## name : \ > ctx->codec == HEVC ? AMF_VIDEO_ENCODER_HEVC_ ## name : \ > AMF_VIDEO_ENCODER_ ##

[FFmpeg-devel] [PATCH v3] avcodec/amfenc: add smart access video option

This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc.c

[FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc.h

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: increase precision of Sleep() on Windows

On Mon, Nov 13, 2023 at 3:41 PM Evgeny Pavlov wrote: > This commit increase precision of Sleep() function on Windows. > This fix reduces the sleep time on Windows to improve AMF encoding > performance on low resolution input videos. > > Fix for issue #10622 > > v2

Re: [FFmpeg-devel] [PATCH, v2] avcodec/amfenc: add smart access video option

On Mon, Jul 24, 2023 at 1:25 PM Evgeny Pavlov wrote: > This commit adds option for enabling SmartAccess Video (SAV) > in AMF encoders. SAV is an AMD hardware-specific feature which > enables the parallelization of encode and decode streams across > multiple Video Codec Engine (V

Re: [FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

On Tue, Oct 31, 2023 at 7:13 PM Evgeny Pavlov wrote: > From: Michael Fabian 'Xaymar' Dirks > > added 10 bit support for amf hevc. > > before: > > command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va > -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c

[FFmpeg-devel] [PATCH v2] avcodec/amfenc: increase precision of Sleep() on Windows

This commit increase precision of Sleep() function on Windows. This fix reduces the sleep time on Windows to improve AMF encoding performance on low resolution input videos. Fix for issue #10622 v2: use timeBeginPeriod/timeEndPeriod for increasing precision of Sleep() Signed-off-by: Evgeny

[FFmpeg-devel] [PATCH 10bit support v5 3/3] avcodec/amfenc: add 10 bit encoding in av1_amf

v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 068bb53002

[FFmpeg-devel] [PATCH 10 bit support v5 2/3] avcodec/amfenc: HDR metadata.

From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

t - 10bit file v2 - lost line returned in ff_amf_pix_fmts v3 - fixes after review v4 - extract duplicated code, fix incorrect processing of 10-bit input for h264 v5 - non-functional changes after review Co-authored-by: Evgeny Pavlov --- libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 10bit support v5 3/3] avcodec/amfenc: add 10 bit encoding in av1_amf

v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 068bb53002

[FFmpeg-devel] [PATCH 10 bit support v5 2/3] avcodec/amfenc: HDR metadata.

From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

t - 10bit file v2 - lost line returned in ff_amf_pix_fmts v3 - fixes after review v4 - extract duplicated code, fix incorrect processing of 10-bit input for h264 v5 - non-functional changes after review Co-authored-by: Evgeny Pavlov --- libavcodec/amfenc.c

[FFmpeg-devel] [PATCH avcodec/amfenc: 10-bit support, v5, 3/3] avcodec/amfenc: add 10 bit encoding in av1_amf

v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 068bb53002

[FFmpeg-devel] [PATCH avcodec/amfenc: 10-bit support, v5, 2/3] avcodec/amfenc: HDR metadata.

From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH avcodec/amfenc: 10-bit support, v5, 1/3] avcodec/amfenc: Fixes the color information in the output.

t - 10bit file v2 - lost line returned in ff_amf_pix_fmts v3 - fixes after review v4 - extract duplicated code, fix incorrect processing of 10-bit input for h264 v5 - non-functional changes after review Co-authored-by: Evgeny Pavlov --- libavcodec/amfenc.c

Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Add more pixel formats support

On Sun, Oct 22, 2023 at 5:01 PM Mark Thompson wrote: > On 20/10/2023 09:13, Evgeny Pavlov wrote: > > On Tue, Jul 18, 2023 at 10:32 AM Evgeny Pavlov > wrote: > > > >> This commit adds BGRA, RGBA and ARGB pixel formats for AMF encoders > >&g

Re: [FFmpeg-devel] [PATCH avcodec/amfenc: 10 bit support, v4, 1/3] avcodec/amfenc: Fixes the color information in the output.

On Wed, Oct 18, 2023 at 10:48 PM Mark Thompson wrote: > On 17/10/2023 19:00, Evgeny Pavlov wrote: > > On Mon, Oct 16, 2023 at 11:41 PM Mark Thompson wrote: > > ... > >>> @@ -785,6 +787,41 @@ int ff_amf_receive_packet(AVCodecContext *avctx, > >> AVPa

Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Add more pixel formats support

On Tue, Jul 18, 2023 at 10:32 AM Evgeny Pavlov wrote: > This commit adds BGRA, RGBA and ARGB pixel formats for AMF encoders > > Signed-off-by: Evgeny Pavlov > --- > libavcodec/amfenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/amfenc.c b/lib

Re: [FFmpeg-devel] [PATCH] amfenc: Use a blocking call instead of sleeping and polling

On Wed, Oct 18, 2023 at 10:36 PM Mark Thompson wrote: > --- > On 17/10/2023 18:11, Evgeny Pavlov wrote: > > The reason for using av_usleep() here is that AMF API doesn’t provide an > > API for explicit wait. There are two modes to get output from encoder: > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix for windows imprecise sleep

On Tue, Oct 17, 2023 at 9:45 PM Kacper Michajlow wrote: > On Tue, 17 Oct 2023 at 19:34, Evgeny Pavlov wrote: > > > > The reason for using av_usleep() here is that AMF API doesn’t provide an > > API for explicit wait. There are two modes to get output from encoder: > &g

Re: [FFmpeg-devel] [PATCH avcodec/amfenc: 10 bit support, v4, 1/3] avcodec/amfenc: Fixes the color information in the output.

On Mon, Oct 16, 2023 at 11:41 PM Mark Thompson wrote: > On 09/10/2023 10:52, Evgeny Pavlov wrote: > > From: Michael Fabian 'Xaymar' Dirks > > > > added 10 bit support for amf hevc. > > > > before: > > > > command - ffmpeg.exe -hide_banne

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix for windows imprecise sleep

bring significant performance improvement (about 15%). It will not bring improvement for high resolution such as 4K. Thanks, Evgeny вт, 17 окт. 2023 г. в 03:26, Zhao Zhili : > > > 在 2023年10月17日，上午5:24，Mark Thompson 写道： > > > > On 16/10/2023 10:13, Evgeny Pavlov wrote: >

[FFmpeg-devel] [PATCH] avcodec/amfenc: Fix for windows imprecise sleep

This commit reduces the sleep time on Windows to improve AMF encoding performance on low resolution input videos. This fix is for Windows only, because sleep() function isn't very accurate on Windows OS. Fix for issue #10622 Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc.c | 4 1

[FFmpeg-devel] [PATCH 10 bit support, v4, 3/3] avcodec/amfenc: add 10 bit encoding in av1_amf

v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 068bb53002

[FFmpeg-devel] [PATCH 10 bit support, v4, 2/3] avcodec/amfenc: HDR metadata.

From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH avcodec/amfenc: 10 bit support, v4, 1/3] avcodec/amfenc: Fixes the color information in the output.

t - 10bit file v2 - lost line returned in ff_amf_pix_fmts v3 - fixes after review v4 - extract duplicated code, fix incorrect processing of 10-bit input for h264 Co-authored-by: Evgeny Pavlov --- libavcodec/amfenc.c | 37 + libavcodec/amfenc.h

[FFmpeg-devel] [PATCH] avfilter/vf_ssim: Fix x86 assembly code for SSIM calculation

branches Signed-off-by: Evgeny Pavlov --- libavfilter/x86/vf_ssim.asm | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/libavfilter/x86/vf_ssim.asm b/libavfilter/x86/vf_ssim.asm index 78809305de..e3e0c8104b 100644 --- a/libavfilter/x86/vf_ssim.asm +++ b

[FFmpeg-devel] [PATCH avcodec/amfenc:, 10, bit, support, v3, 3/3] avcodec/amfenc: add 10 bit encoding in av1_amf

Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc_av1.c | 47 + 1 file changed, 47 insertions(+) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index 30c0a9fad2..5c5313001d 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH avcodec/amfenc:, 10, bit, support, v3, 2/3] avcodec/amfenc: HDR metadata.

From: nyanmisaka --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 1d863afdc4..ec71f899fe 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c @@ -36,6 +36,57 @@ #inclu

[FFmpeg-devel] [PATCH avcodec/amfenc:, 10, bit, support, v3, 1/3] avcodec/amfenc: Fixes the color information in the output.

From: Michael Fabian 'Xaymar' Dirks added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by

[FFmpeg-devel] [PATCH, v2] avcodec/amfenc: add smart access video option

This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov --- Changes in v2

[FFmpeg-devel] [PATCH] libavcodec/amfenc: add smart access video option

This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc.h

[FFmpeg-devel] [PATCH] libavcodec/amfenc: add smart access video option

This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SmartAccess video - AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov

[FFmpeg-devel] [PATCH] libavcodec/amfenc: Add more pixel formats support

This commit adds BGRA, RGBA and ARGB pixel formats for AMF encoders Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index cb48f8c273..234cd012ef 100644 --- a/libavcodec/amfenc.c +++ b

[FFmpeg-devel] [PATCH] libavcodec/amfenc: Fix issue with missing headers in AV1 encoder

perty, because default value depends on USAGE property. Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc_av1.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index 30c0a9fad2..0a58a0808a 100644 --- a/libavcodec/amfenc_

[FFmpeg-devel] [PATCH] libavcodec/amfenc: Fix issue with missing headers in AV1 encoder

this property, because default value depends on USAGE property. Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc_av1.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index 30c0a9fad2..0a58a0808a 100644 --- a/libav

[FFmpeg-devel] ffmpeg-rtpdec-4175-gray

Support of grayscale video (from IR-camera as example) --- libavformat/rtpdec_rfc4175.c +++ libavformat/rtpdec_rfc4175.c @@ -96,6 +96,16 @@ static int rfc4175_parse_format(AVStream *stream, PayloadContext *data) } else { return AVERROR_INVALIDDATA; } + } else if (!strncmp(data->sampling,

Re: [FFmpeg-devel] [PATCH] libavcodec/htmlsubtitles: skip newline characters at the beginning of the subtitle

> Anyway, I don't understand why this makes subtitle lines actually > disappear? Because SubRip format does not allow to have empty lines, that is: 1. Subtitle text itself on one or more lines 2. A blank line containing no text, indicating the end of this subtitle So, when we have '\n' at

Re: [FFmpeg-devel] [PATCH] libavcodec/htmlsubtitles: skip newline characters at the beginning of the subtitle

parser) in VLC, in other 2 files these subtitle lines have dissapeared. Therefore, I suggest deleting the newline characters at the beginning of the line, and working on. FATE tests works without error. 2017-06-16 21:23 GMT+03:00 Evgeny Shulgin : > We can have a certain number of newline charact

[FFmpeg-devel] [PATCH] libavcodec/htmlsubtitles: skip newline characters at the beginning of the subtitle

We can have a certain number of newline characters at the very beginning of the subtitles. We must skip them to get the correct result. --- libavcodec/htmlsubtitles.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/htmlsubtitles.c b/libavcodec/htmlsubtitles.c index 16295da..b144a