Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amfenc: B-Frame support for av1_amf encoder.

2024-12-17 Thread Dmitrii Ovchinnikov
If there are no comments, I’ll merge it in a few days. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubs

[FFmpeg-devel] [PATCH 2/2] avcodec/amfenc: B-Frame support for av1_amf encoder.

2024-12-12 Thread Dmitrii Ovchinnikov
--- libavcodec/amfenc_av1.c | 66 + 1 file changed, 66 insertions(+) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index 01b1f85747..11da9496ba 100644 --- a/libavcodec/amfenc_av1.c +++ b/libavcodec/amfenc_av1.c @@ -101,6 +101,10 @@ static c

[FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.35.0 for AMF SDK.

2024-12-12 Thread Dmitrii Ovchinnikov
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index bf55ba67fa..266c5e7aab 100755 --- a/configure +++ b/configure @@ -7427,7 +7427,7 @@ fi enabled amf && check_cpp_condition amf "AMF/core/Version.h" \ -"(AMF_VERSION_MAJOR <<

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Implement async_depth option

2024-12-11 Thread Dmitrii Ovchinnikov
Looks good to me. If there are no comments, I’ll merge it in a few days. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

[FFmpeg-devel] [PATCH 5/5] avcodec/amfenc: redesign to use hwcontext_amf.

2024-12-03 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov v3: cleanup code --- libavcodec/amfenc.c | 875 +-- libavcodec/amfenc.h | 34 +- libavcodec/amfenc_av1.c | 8 +- libavcodec/amfenc_h264.c | 6 +- libavcodec/amfenc_hevc.c | 6 +- 5 files changed, 306 insertions(+)

[FFmpeg-devel] [PATCH 4/5] doc/filters: Add documentation for AMF filters

2024-12-03 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 428986a1e9..7d75ebfa3e 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH 3/5] avfilter/scale_amf: Add AMF VPP & super resolution filters

2024-12-03 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: vpp_amf & sr_amf. Both filters are using AMF hardware acceleration. vpp_amf supports simple scaling algorithms & color conversion. sr_amf supports advanced scaling algorithms such as FSR & can be used for upscaling only. --- configure

[FFmpeg-devel] [PATCH 2/5] avcodec: add amfdec.

2024-12-03 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov v2: added encoder reinitialisation v3: use AMF_SURFACE_UNKNOWN to int decoder(ctx->output_format before) --- configure | 3 + libavcodec/Makefile| 7 +- libavcodec/allcodec

[FFmpeg-devel] [PATCH 1/5] avutil: add hwcontext_amf.

2024-12-03 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, enabling a shared AMF context for encoders, decoders, and AMF-based filters, without copy to the host memory. Code also was tested in HandBrake. Benefits: - Optimizations for direct video memory access from CPU - Significant performance boost in full AMF pipelines with fi

[FFmpeg-devel] [PATCH 5/5] avcodec/amfenc: redesign to use hwcontext_amf.

2024-12-02 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov v3: cleanup code --- libavcodec/amfenc.c | 875 +-- libavcodec/amfenc.h | 34 +- libavcodec/amfenc_av1.c | 8 +- libavcodec/amfenc_h264.c | 6 +- libavcodec/amfenc_hevc.c | 6 +- 5 files changed, 306 insertions(+)

[FFmpeg-devel] [PATCH 4/5] doc/filters: Add documentation for AMF filters

2024-12-02 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 428986a1e9..7d75ebfa3e 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH 3/5] avfilter/scale_amf: Add AMF VPP & super resolution filters

2024-12-02 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: vpp_amf & sr_amf. Both filters are using AMF hardware acceleration. vpp_amf supports simple scaling algorithms & color conversion. sr_amf supports advanced scaling algorithms such as FSR & can be used for upscaling only. --- configure

[FFmpeg-devel] [PATCH 2/5] avcodec: add amfdec.

2024-12-02 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov v2: added encoder reinitialisation v3: use AMF_SURFACE_UNKNOWN to int decoder(ctx->output_format before) --- configure | 3 + libavcodec/Makefile| 7 +- libavcodec/allcodec

[FFmpeg-devel] [PATCH 1/5] avutil: add hwcontext_amf.

2024-12-02 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, enabling a shared AMF context for encoders, decoders, and AMF-based filters, without copy to the host memory. Code also was tested in HandBrake. Benefits: - Optimizations for direct video memory access from CPU - Significant performance boost in full AMF pipelines with filt

Re: [FFmpeg-devel] [PATCH, v3] avcodec/amfenc: increase precision of Sleep() on Windows

2024-10-31 Thread Dmitrii Ovchinnikov
This patch does not touch the sleep . The description remains from the old version and I will correct it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] [PATCH, v3] avcodec/amfenc: increase precision of Sleep() on Windows

2024-10-31 Thread Dmitrii Ovchinnikov
If there are no comments, I plan to merge this patch at the end of the week. I will update the title and description to match the current version of the patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpe

[FFmpeg-devel] [PATCH 4/5] doc/filters: Add documentation for AMF filters

2024-10-21 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 428986a1e9..7d75ebfa3e 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH 5/5] avcodec/amfenc: redesign to use hwcontext_amf.

2024-10-21 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov v3: cleanup code --- libavcodec/amfenc.c | 520 +-- libavcodec/amfenc.h | 29 +-- libavcodec/amfenc_av1.c | 8 +- libavcodec/amfenc_h264.c | 6 +- libavcodec/amfenc_hevc.c | 6 +- 5 files changed, 132 insertions(+

[FFmpeg-devel] [PATCH 3/5] avfilter/scale_amf: Add AMF VPP & super resolution filters

2024-10-21 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: vpp_amf & sr_amf. Both filters are using AMF hardware acceleration. vpp_amf supports simple scaling algorithms & color conversion. sr_amf supports advanced scaling algorithms such as FSR & can be used for upscaling only. --- configure

[FFmpeg-devel] [PATCH 1/5] avutil: add hwcontext_amf.

2024-10-21 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, which allows to use shared AMF context for the encoder, decoder and AMF-based filters, without copy to the host memory. It will also allow you to use some optimisations in the interaction of components (for example, SAV) and make a more manageable and optimal setup for using GPU

[FFmpeg-devel] [PATCH 2/5] avcodec: add amfdec.

2024-10-21 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov v2: added encoder reinitialisation v3: use AMF_SURFACE_UNKNOWN to int decoder(ctx->output_format before) --- configure | 3 + libavcodec/Makefile| 7 +- libavcodec/allcodec

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix inverted loop filter option

2024-09-28 Thread Dmitrii Ovchinnikov
Thanks for the fix. Merged. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix AV1 HDR metadata for delayed surfaces

2024-09-11 Thread Dmitrii Ovchinnikov
Thanks for the fix. merged. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: Add support for on-demand key frames

2024-09-11 Thread Dmitrii Ovchinnikov
Thanks for your contribution. It looks good to me. If there are no comments, I'll merge it in a few days. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] [PATCH 1/4, v2] avcodec/amfenc: Fixes the color information in the output.

2024-08-25 Thread Dmitrii Ovchinnikov
If there are no objections, I would like to merge this patch series on the next week. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@f

Re: [FFmpeg-devel] [PATCH 01/10, v3] avutil: add hwcontext_amf.

2024-05-30 Thread Dmitrii Ovchinnikov
I would appreciate your review. Just to clarify: The information I provided is coming from AMF and driver developers. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH 01/10, v3] avutil: add hwcontext_amf.

2024-05-30 Thread Dmitrii Ovchinnikov
DX12 and Vulkan native encoders will expose less features compare to AMF, at least in foreseeable feature. The missing features include low latency, PreAnalysis including look-ahead etc. AMF context on Windows allows fully enable SAV - ability to utilize VCNs in dGPU and APU in a single session.

Re: [FFmpeg-devel] [PATCH 02/10, v2] avcodec: add amfdec.

2024-05-30 Thread Dmitrii Ovchinnikov
>>I do not see a configure dependency of your AMF decoders on AMF Thanks, apparently I always put it together with the encoder and therefore did not get such an error. I'll fix the dependencies and check the options without AMF. ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf.

2024-05-30 Thread Dmitrii Ovchinnikov
>>This seems to have forgotten to actually allocate anything? I made an empty allocation here, since in fact all allocation takes place in the decoder. >>This makes it look like you really wanted to implement map_from, not transfer_data_from. These functions were conceived specifically for transfe

Re: [FFmpeg-devel] [PATCH 02/10, v2] avcodec: add amfdec.

2024-05-30 Thread Dmitrii Ovchinnikov
In the new version, I removed unnecessary includes and cleaned up the code (https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=11968). It didn't seem to help. On my local computer build is successful in all configurations that I have tried. The file mentioned in the error is also already used

[FFmpeg-devel] [PATCH 08/10, v3] avcodec/amfenc: redesign to use hwcontext_amf.

2024-05-30 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov v3: cleanup code --- libavcodec/amfenc.c | 573 +++ libavcodec/amfenc.h | 32 +-- libavcodec/amfenc_av1.c | 8 +- libavcodec/amfenc_h264.c | 8 +- libavcodec/amfenc_hevc.c | 14 +- 5 files changed, 176 insertions(+

[FFmpeg-devel] [PATCH 10/10, v3] doc/filters: Add documentation for AMF filters

2024-05-30 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index f5bf475d13..78e87ff5f7 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH 07/10, v3] avcodec/amfenc: add smart access video option

2024-05-30 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov ---

[FFmpeg-devel] [PATCH 09/10, v3] avfilter/scale_amf: Add AMF VPP & super resolution filters

2024-05-30 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: vpp_amf & sr_amf. Both filters are using AMF hardware acceleration. vpp_amf supports simple scaling algorithms & color conversion. sr_amf supports advanced scaling algorithms such as FSR & can be used for upscaling only. --- configure

[FFmpeg-devel] [PATCH 06/10, v3] avcodec/amfenc: GPU driver version check

2024-05-30 Thread Dmitrii Ovchinnikov
From: Araz Iusubov Implemented gpu driver check. 10-bit patch works incorrectly on driver version lower than 23.30. Signed-off-by: Araz Iusubov --- libavcodec/amfenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 49dd91c4e0..510050e282

[FFmpeg-devel] [PATCH 05/10, v3] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-05-30 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Araz Iusubov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0

[FFmpeg-devel] [PATCH 04/10, v3] avcodec/amfenc: HDR metadata.

2024-05-30 Thread Dmitrii Ovchinnikov
From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 03/10, v3] avcodec/amfenc: Fixes the color information in the output.

2024-05-30 Thread Dmitrii Ovchinnikov
From: Michael Fabian 'Xaymar' Dirks added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by

[FFmpeg-devel] [PATCH 02/10, v3] avcodec: add amfdec.

2024-05-30 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov v2: added encoder reinitialisation v3: use AMF_SURFACE_UNKNOWN to int decoder(ctx->output_format before) --- libavcodec/Makefile| 7 +- libavcodec/allcodecs.c | 3 + libavcodec/amfde

[FFmpeg-devel] [PATCH 01/10, v3] avutil: add hwcontext_amf.

2024-05-30 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, which allows to use shared AMF context for the encoder, decoder and AMF-based filters, without copy to the host memory. It will also allow you to use some optimisations in the interaction of components (for example, SAV) and make a more manageable and optimal setup for using GPU

Re: [FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf.

2024-05-02 Thread Dmitrii Ovchinnikov
>>Is there a reason to add this code in now? DX12 and Vulkan native encoders will expose less features compare to AMF, at least in foreseeable feature. The missing features include low latency, PreAnalysis including look-ahead etc. AMF context on Windows allows fully enable SAV - ability to utilize

[FFmpeg-devel] [PATCH 10/10, v2] doc/filters: Add documentation for AMF filters

2024-05-01 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index fc813f12c1..81dad32ce9 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH 09/10, v2] avfilter/scale_amf: Add AMF VPP & super resolution filters

2024-05-01 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: vpp_amf & sr_amf. Both filters are using AMF hardware acceleration. vpp_amf supports simple scaling algorithms & color conversion. sr_amf supports advanced scaling algorithms such as FSR & can be used for upscaling only. --- configure

[FFmpeg-devel] [PATCH 08/10, v2] avcodec/amfenc: redesign to use hwcontext_amf.

2024-05-01 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov --- libavcodec/amfenc.c | 568 +--- libavcodec/amfenc.h | 23 +- 2 files changed, 163 insertions(+), 428 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 510050e282..781254327a 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 07/10, v2] avcodec/amfenc: add smart access video option

2024-05-01 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov ---

[FFmpeg-devel] [PATCH 06/10, v2] avcodec/amfenc: GPU driver version check

2024-05-01 Thread Dmitrii Ovchinnikov
From: Araz Iusubov Implemented gpu driver check. 10-bit patch works incorrectly on driver version lower than 23.30. Signed-off-by: Araz Iusubov --- libavcodec/amfenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 49dd91c4e0..510050e282

[FFmpeg-devel] [PATCH 05/10, v2] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-05-01 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Araz Iusubov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0

[FFmpeg-devel] [PATCH 04/10, v2] avcodec/amfenc: HDR metadata.

2024-05-01 Thread Dmitrii Ovchinnikov
From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 03/10, v2] avcodec/amfenc: Fixes the color information in the output.

2024-05-01 Thread Dmitrii Ovchinnikov
From: Michael Fabian 'Xaymar' Dirks added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by

[FFmpeg-devel] [PATCH 02/10, v2] avcodec: add amfdec.

2024-05-01 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov v2: added encoder reinitialisation --- libavcodec/Makefile| 7 +- libavcodec/allcodecs.c | 3 + libavcodec/amfdec.c| 719 + libavcodec/amfdec.h

[FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf.

2024-05-01 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, which allows to use shared AMF context for the encoder, decoder and AMF-based filters, without copy to the host memory. It will also allow you to use some optimizations in the interaction of components (for example, SAV) and make a more manageable and optimal setup for using GPU

Re: [FFmpeg-devel] [PATCH 1/9] libavutil: add hwcontext_amf.

2024-02-14 Thread Dmitrii Ovchinnikov
>>AVAMFDeviceContextInternal *internal. Can't say if this is needed here >>at all or not. I have separated AVAMFDeviceContextInternal into a separate structure, since it is also used in the decoder and encoder, even when hwaccel amf is not used >>These should probably take a AVAMFDeviceContext poi

[FFmpeg-devel] [PATCH 9/9] doc/filters: Add documentation for AMF filters

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index e0436a5755..4c5b9c1f63 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH 8/9] avfilter/scale_amf: Add AMF HW scaler & color converter

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: scale_amf & scale_amf_hq. Both filters are using AMF hardware acceleration. scale_amf supports simple scaling algorithms & color conversion. scale_amf_hq supports advanced scaling algorithms & might be used for upscaling only. Signed-off-by:

[FFmpeg-devel] [PATCH 7/9] libavcodec/amfenc: redesign to use hwcontext_amf.

2024-02-13 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov --- libavcodec/amfenc.c | 560 libavcodec/amfenc.h | 23 +- 2 files changed, 158 insertions(+), 425 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index f1b76bd6aa..e6e5302cca 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 6/9] avcodec/amfenc: add smart access video option

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov ---

[FFmpeg-devel] [PATCH 5/9] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 4/9] avcodec/amfenc: HDR metadata.

2024-02-13 Thread Dmitrii Ovchinnikov
From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 3/9] avcodec/amfenc: Fixes the color information in the output.

2024-02-13 Thread Dmitrii Ovchinnikov
From: Michael Fabian 'Xaymar' Dirks added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by

[FFmpeg-devel] [PATCH 2/9] libavcodec: add amfdec.

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/Makefile | 4 +- libavcodec/allcodecs.c | 3 + libavcodec/amfdec.c | 667 libavcodec/amfdec.h | 75 + libavcodec

[FFmpeg-devel] [PATCH 1/9] libavutil: add hwcontext_amf.

2024-02-13 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, which allows to use shared AMF context for the encoder, decoder and AMF-based filters, without copy to the host memory. It will also allow you to use some optimizations in the interaction of components (for example, SAV) and make a more manageable and optimal setup for using GPU

Re: [FFmpeg-devel] [PATCH 7/7] fftools/ffplay: support applying container level cropping

2024-01-17 Thread Dmitrii Ovchinnikov
I tested these patches with the AMF AV1 encoder(by adding AV_PKT_DATA_FRAME_CROPPING) It works fine. I suggest a small change to the code for better safety. Change this part: >>if (sd->data && sd->size == sizeof(uint32_t) * 4) { to: if (sd && sd->data && sd->size == sizeof(uint32_t) * 4) { This c

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amd: fix pict_type, match it with amf & ffmpeg. add sps pps when frame->keyframe

2023-11-30 Thread Dmitrii Ovchinnikov
The idea itself looks good to me, but the patch is corrupted. Regarding the patch: 1) >>// Keyframe overrides previous assignment. It might be better instead of: setting the frame type -> if key frame then overwrite to do: check for key frame and if it's not, set other PICTURE_TYPE to avoid unnece

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-26 Thread Dmitrii Ovchinnikov
>> The code looks significantly duplicated. This is not moved to amfenc.c since the property has different names for different encoders, and many other properties (also common to different encoders, but with different names) are separated in this way. _

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-24 Thread Dmitrii Ovchinnikov
If there are no objections, I would like to merge it in 2-3 days ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Fix issue with missing headers in AV1 encoder

2023-10-31 Thread Dmitrii Ovchinnikov
This is a trivial patch that fixes the bug. If there are no objections, I would like to merge it in 2-3 days ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH 2/2, v3] libavcodec/amfenc: add PreAnalysis support

2023-05-17 Thread Dmitrii Ovchinnikov
Additional information about the work of preanalysis can be found here: https://github.com/GPUOpen-LibrariesAndSDKs/AMF/wiki/PreProcessing%20and%20PreAnalysis --- libavcodec/amfenc.c | 101 +++-- libavcodec/amfenc.h | 27 +- libavcodec/amfenc_av1.c | 133 +++

[FFmpeg-devel] [PATCH 1/2, v3] amfenc: Update the min version to 1.4.29.0 for AMF SDK.

2023-05-17 Thread Dmitrii Ovchinnikov
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index bb7be67676..937be943a4 100755 --- a/configure +++ b/configure @@ -7082,7 +7082,7 @@ fi enabled amf && check_cpp_condition amf "AMF/core/Version.h" \ -"(AMF_VERSION_MAJOR <<

Re: [FFmpeg-devel] I have an issue when try to using h264_amf encoding rtsp stream

2023-04-29 Thread Dmitrii Ovchinnikov
s > either because the encoder only encode the first I frame properly or the > decoder can not recognize the I frame generated by amf encoder. > > Dmitrii Ovchinnikov 于 2023年4月19日周三 > 01:55写道: > > > For libx264 the default gop size is 10, while for amf the default gop &

[FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-05 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov This change improves the performance and multicore scalability of the vp9 codec for streaming single-pass encoded videos. The current thread limit for ffmpeg codecs is 16 (MAX_AUTO_THREADS in pthread_internal.h) due to a limitation in H.264 codec that prevents more

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2022-12-20 Thread Dmitrii Ovchinnikov
Hi, >>When was this release released? The release was 13.12.2022 >> Is it headers only or is it runtime too? it still supports old drivers, but to use the av1 encoder, you need an up-to-date driver version and a supported graphics card. ___ ffmpeg-devel

[FFmpeg-devel] [crop support for matroska demuxer, V4 3/3] libavformat\matroskadec.c: crop support for matroska demuxer.

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov In webm specification, it supports cropping information. (https://www.webmproject.org/docs/container/) In ffmpeg, the implementation of webm is a subset of matroska. In matroskadec.c, those cropping related four fields are forced to 0. for the sample file with crop

[FFmpeg-devel] [crop support for matroska demuxer, V4 2/3] libavcodec: Public code to support container crop

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov Support both simple and receive_frame api The container crop information is applied additional to frame crop information --- libavcodec/codec_par.c | 30 ++- libavcodec/decode.c| 54 ++ 2 files changed, 73

[FFmpeg-devel] [crop support for matroska demuxer, V4 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov --- libavcodec/avcodec.h | 35 +++ libavcodec/codec_par.h | 8 libavcodec/options_table.h | 4 3 files changed, 47 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3edd8e2636

[FFmpeg-devel] [PATCH 2/2] libavcodec/amfenc: add AV1 encoding support

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov --- configure | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/amfenc.c | 9 + libavcodec/amfenc.h | 6 + libavcodec/amfenc_av1.c | 361 6 files changed, 379

[FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 2180ebb4f1..8a20d67612 100755 --- a/configure +++ b/configure @@ -7034,7 +7034,7 @@ fi enabled amf && check_cpp_condition amf "AMF/c

Re: [FFmpeg-devel] [crop support for matroska demuxer, V4 2/3] libavcodec: Public code to support container crop

2022-11-23 Thread Dmitrii Ovchinnikov
>>The types seems mismatching The reason for the mismatch of types is that I left the int type according to the comments : " James Almer IMO the AVFrame ones should have not been size_t to begin with, not just because the actual dimensions you'll apply them to are int, but because these fields are

Re: [FFmpeg-devel] [PATCH V2] lavc/libvpx: increase thread limit to 64

2022-11-23 Thread Dmitrii Ovchinnikov
Thanks for the answer and comment! I will think about how best to rework the patch and then send a new version. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or em

Re: [FFmpeg-devel] [avcodec/amfenc: 10 bit support v2 1/3] amf: Update the min version to 1.4.23.0 for AMF SDK.

2022-10-25 Thread Dmitrii Ovchinnikov
Hi! These patches have already been tested and accepted into the HandBrake (https://github.com/HandBrake/HandBrake/pull/4538 ). Could you take a look? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-deve

Re: [FFmpeg-devel] [PATCH V2] lavc/libvpx: increase thread limit to 64

2022-10-25 Thread Dmitrii Ovchinnikov
>> Why do you still impose an upper limit unconditionally even if the >>user has set his preferred number of threads? Libvpx-vp9 does not support number of threads greater than 64, so we impose an upper limit of 64. E.g. if we set it any higher we get the following execution error: [libvpx-vp9 @ 0x

Re: [FFmpeg-devel] [crop support for matroska demuxer, V3 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

2022-10-12 Thread Dmitrii Ovchinnikov
>>Why does an encoder or decoder need to care about this, given it's >>container level information? >>Do you plan on implementing cropping support into all the encoders? This implementation takes a reference of the h.264 supporting cropping. In h264, if width (stored in ACCodecContext) parsed fr

Re: [FFmpeg-devel] [crop support for matroska demuxer, V3 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

2022-10-12 Thread Dmitrii Ovchinnikov
>> I don't see why should a decoder deal with this at all? >>This can be just as well done by the caller. This implementation takes a reference of the h.264 supporting cropping. In h264, if width (stored in ACCodecContext) parsed from container is different from width parsed from elementary, it wi

Re: [FFmpeg-devel] [crop support for matroska demuxer 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

2022-10-07 Thread Dmitrii Ovchinnikov
Sent an updated version: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7707. 1) >>All of these should be size_t The field type is still "int" according to James Almer's comment. 2) I placed the fields at the very end, according to a message from Timo Rothenpieler. 3) >>The semantics of t

Re: [FFmpeg-devel] [PATCH V2] lavc/libvpx: increase thread limit to 64

2022-10-06 Thread Dmitrii Ovchinnikov
Removed unnecessary comment as requested by Ronald S. Bultje. some more thoughts about the patch: This is my deduction from what I could find - There was a hard limit of 16 threads in libvpx as there was no benefit to adding more threads based upon the parallelism available in the the codec. Thi

Re: [FFmpeg-devel] [PATCH] libavformat\matroskadec.c: crop support for matroska demuxer.

2022-09-30 Thread Dmitrii Ovchinnikov
I fixed issues1-4 and sent an updated version: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7668 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] libavformat\matroskadec.c: crop support for matroska demuxer.

2022-09-26 Thread Dmitrii Ovchinnikov
Hi Andreas, Thanks for your quick and direct feedback about the patch. Your feedback about the displayWidth, displayHeight and the display aspect ratio shows that you have deep thinking in this area. I have several questions and comments about your feedback. 1. Yes, i will get this change, and p

Re: [FFmpeg-devel] [avcodec/amfenc: 10 bit support v2 1/3] amf: Update the min version to 1.4.23.0 for AMF SDK.

2022-09-07 Thread Dmitrii Ovchinnikov
>>Isn't that a bit too recent? Or does it not matter because it still supports old drivers? Old drivers are fully supported. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit li

Re: [FFmpeg-devel] [PATCH 2/5] lavu/hwcontext_amf: HWContext for AMF based components

2020-10-28 Thread Dmitrii Ovchinnikov
This part of the code is also planned to be used in AMF decorer. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subjec

Re: [FFmpeg-devel] [PATCH 4/5] lavu/hwcontext_amf: Engine selection support for AMF context

2020-10-28 Thread Dmitrii Ovchinnikov
>Why? Given that you are already initialising from a specific device when one is given, what does this actually change? This code was created quite a long time ago in order to allow the user to use the vulkan encoder on Windows. For now, it looks like you can use AVVulkanDeviceContext instead.I wi

Re: [FFmpeg-devel] [PATCH 1/5] lavc/amfenc: HWConfig for amf encoder.

2020-10-28 Thread Dmitrii Ovchinnikov
> > > This looks right, but can you clarify the intent behind the hw config > cases? (Do you have an ffmpeg command line or other example which is > improved by them?) > > Hi! This ticket describes the problem. https://trac.ffmpeg.org/ticket/8953#ticket