Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-07 Thread David Fletcher
On Fri May 6 21:29:51 EEST 2022 Lynne dev at lynne.ee wrote: > I disagree with this patch. The native decoder should be fixed instead, > or if it's not able to be fixed, users should use specialized libraries. > We're not adding a yet another decoding library to fix an issue on > very old ARM chip

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-04 Thread David Fletcher
> Andreas Rheinhardt wrote: > > David Fletcher: > > Following today's posts about help with submitting patches I realised I > > sent the libmad patch yesterday in the wrong format. Apologies, I was > > not familiar with the git format patches. > > > >

Re: [FFmpeg-devel] PATCH - wolfSSL TLS support

2022-05-03 Thread David Fletcher
aster branch. Best regards, David. From 3fc91e85b31ce0e5422f6ffe39d7d2287bce5939 Mon Sep 17 00:00:00 2001 From: David Fletcher Date: Tue, 3 May 2022 19:23:50 +0100 Subject: [PATCH] Patched to work with wolfSSL as a new TLS backend Signed-off-by: David Fletcher --- configure

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-03 Thread David Fletcher
eport about why this exists is at the following link, including a link to sample distorted audio from decoding an mp3 stream on ARMv4 hardware: https://trac.ffmpeg.org/ticket/9764 Best regards, David. From c7012e7743d245bfc737bd921341a462cd5c843c Mon Sep 17 00:00:00 2001 From: David Fletcher Date: T

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
On 2/5/2022, "Martin Storsjö" martin at martin.st wrote: > That sounds like there's an issue with some of the ARM implementations of > DSP functions, that only exists in implementations for less featureful ARM > instruction sets. > > (It could theoretically be a compiler bug also but I think it

Re: [FFmpeg-devel] PATCH - wolfSSL TLS support

2022-05-02 Thread David Fletcher
On 2/5/2022, "Timo Rothenpieler" wrote: >Only patches against master can be accepted. >New stuff like this does not get backported either. Only fixes for >existing features. Hi Timo, Thanks for the comments. Please find attached an updated patch against the master (ffmpeg-master-b67572c). Best

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
On 2/5/2022, "Nicolas George" wrote: >Is there a trac ticket? If not, please fill one: we would not want to >keep that bug. > >Regards, > >-- > Nicolas George Hi Nicolas, I'll prepare a test case to demonstrate the issue and fill in a ticket. As far as I can tell this is an issue affecting old

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
7572c-libmad/libavcodec/libmaddec.c --- ./ffmpeg-master-b67572c/libavcodec/libmaddec.c 1970-01-01 01:00:00.0 +0100 +++ ./ffmpeg-master-b67572c-libmad/libavcodec/libmaddec.c 2022-05-02 18:11:33.062055778 +0100 @@ -0,0 +1,181 @@ +/* + * MP3 decoder using libmad + * Copyright (c) 2022 David Flet

[FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-01 Thread David Fletcher
.c 1970-01-01 01:00:00.0 +0100 +++ ./ffmpeg-5.0.1-mad/libavcodec/libmaddec.c 2022-04-12 19:00:21.0 +0100 @@ -0,0 +1,181 @@ +/* + * MP3 decoder using libmad + * Copyright (c) 2022 David Fletcher + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute i

[FFmpeg-devel] PATCH - wolfSSL TLS support

2022-05-01 Thread David Fletcher
Please find attached a patch adding support for wolfSSL as a TLS backend. This is against release ffmpeg-5.0.1, and is working well with wolfSSL 5.1.1 (January 2022 release). This is based on a patch previously submitted in 2018 which never made it into the mail codebase, but now updated for ffmpe