Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info,
and also add the expected test results for the implementation.
Signed-off-by: Christopher Snowhill
---
Curses, Apple Mail is broken, too. Using git imap-send instead.
libavformat/mp3dec.c | 86
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info,
and also add the expected test results for the implementation.
Signed-off-by: Christopher Snowhill
---
Curses, Apple Mail is broken, too. Using git imap-send instead. If
this doesn't work, I haven't a damn clue h
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info,
and also add the expected test results for the implementation.
Signed-off-by: Christopher Snowhill
---
Let's see if I can get Apple Mail to do what Canary Mail cannot: Send an .eml
without removing all the "
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info,
and also add the expected test results for the implementation.
Signed-off-by: Christopher Snowhill
---
libavformat/mp3dec.c | 86 ++-
tests/fate/gapless.mak | 3 ++
tests/ref/fate/gapless-mp3-itunes
These candidate formats are likely already decoded in floating point
internally anyway, so request float output so that it's also possible
to clip or peak level as necessary.
Signed-off-by: Christopher Snowhill
---
libavcodec/audiotoolboxdec.c | 36
1
y.
Signed-off-by: Christopher Snowhill
---
libavcodec/audiotoolboxdec.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c
index 9939fef218..4abcb63a03 100644
--- a/libavcodec/audiotoolboxdec.c
+++ b/libavcodec/audiotoolboxdec.c
I've finally assembled a fate test for this patch.
The test file goes here:
/gapless/gapless-itunes.mp3
I have uploaded a copy here:
https://f.losno.co/gapless-itunes.mp3
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman
---
tests/fate/gapless.mak| 3 ++-
tests/ref/fate/gapless-mp3-itunes | 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
create mode 100644 tests/ref/fate/gapless-mp3-itunes
diff --git a/tests/fate/gapless.mak b/tests/fate/gapless.mak
index 0253b9ec61..46b3b98c13 100644
--- a/
From: Chris Moeller
---
libavformat/id3v2.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index 9969d7a..f7fa3ef 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -823,6 +823,7 @@ static void id3v2_parse(AVIOConte
It needs this patch first, but I have some example MP3 files that
decode gaplessly with these patches applied. Encoded using the latest
iTunes as of this writing (12.5.5.5) on macOS Sierra. Attaching the
MP3 files, as well as source FLAC files, after this patch goes
through.
_
Signed-off-by: Christopher Snowhill
---
libavformat/mp3dec.c | 77 +++-
1 file changed, 76 insertions(+), 1 deletion(-)
diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c
index 099ca57..b895e37 100644
--- a/libavformat/mp3dec.c
+++ b
Let's try this again. I can't believe I missed all those things you
mentioned. It's almost as if I didn't actually proofread my patch
before sending it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
---
libavformat/mp3dec.c | 70 +++-
1 file changed, 69 insertions(+), 1 deletion(-)
diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c
index 56c7f8c..47f4028 100644
--- a/libavformat/mp3dec.c
+++ b/libavformat/mp3dec.c
@@ -295,6 +295,59 @@ sta
ed to check the validity of
the input values now, giving approximately 32 frames of lead
and 64 frames of tail padding, with a rudimentary check on
total file size before attempting the total file size check,
and error checking on the seek operation.
Christopher Snowhill (1):
avformat: parse i
Sorry for the noise, I made some poor assumptions. First, I wasn’t really
paying attention when it mentioned the whitespace errors on apply, and didn’t
correct them the first time. Second, I didn’t realize that it would ignore my
—subject directive when sending the revised first patch. Now I lea
15 matches
Mail list logo
