Re: [FFmpeg-devel] [PATCH v4 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Christopher Snowhill
On Sat May 31, 2025 at 3:03 AM PDT, Martin Storsjö wrote: > On Sat, 31 May 2025, Dmitriy Kovalenko wrote: > >> Great. I send another version with the reverted change for the asr >> register change. What is the correct process to reply for the inline >> changes then? Inline email answer or cover l

Re: [FFmpeg-devel] Building for Mac x86 with GCC & NASM

2025-05-28 Thread Christopher Snowhill
gt; Subject: Re: [FFmpeg-devel] Building for Mac x86 with GCC & NASM >> >> On Wed, 28 May 2025, softworkz . wrote: >> >> >> -----Original Message- >> >> From: ffmpeg-devel On Behalf Of >> >> Christopher Snowhill >>

Re: [FFmpeg-devel] Building for Mac x86 with GCC & NASM

2025-05-28 Thread Christopher Snowhill
On Wed May 28, 2025 at 1:12 AM PDT, softworkz . wrote: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Christopher Snowhill >> Sent: Mittwoch, 28. Mai 2025 09:40 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org&g

Re: [FFmpeg-devel] Building for Mac x86 with GCC & NASM

2025-05-28 Thread Christopher Snowhill
On Tue May 27, 2025 at 10:54 PM PDT, Martin Storsjö wrote: > On Tue, 27 May 2025, softworkz . wrote: > >> Hi, >> >> I have an issue with the CI builds for Mac in a way that it prints >> tons of lines like this: >> >> ld: warning: no platform load command found in >> 'libavcodec/libavcodec.a[1008](

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Christopher Snowhill
On Sat Mar 29, 2025 at 10:02 PM PDT, Gyan Doshi wrote: > > > On 2025-03-29 11:52 pm, Martin Storsjö wrote: >> On Sat, 29 Mar 2025, Gyan Doshi wrote: >> Did you not try to use GNU make's flie function? >>> >>> I just benched this and it ranges from 1m28.093s to 1m29.971s (5% >>> faster) for th

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- Curses, Apple Mail is broken, too. Using git imap-send instead. libavformat/mp3dec.c | 86

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- Curses, Apple Mail is broken, too. Using git imap-send instead. If this doesn't work, I haven't a damn clue h

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- Let's see if I can get Apple Mail to do what Canary Mail cannot: Send an .eml without removing all the "

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- libavformat/mp3dec.c | 86 ++- tests/fate/gapless.mak | 3 ++ tests/ref/fate/gapless-mp3-itunes

[FFmpeg-devel] [PATCH] avcodec/audiotoolboxdec: Decode appropriate formats to float

2021-12-30 Thread Christopher Snowhill
These candidate formats are likely already decoded in floating point internally anyway, so request float output so that it's also possible to clip or peak level as necessary. Signed-off-by: Christopher Snowhill --- libavcodec/audiotoolboxdec.c | 36 1

[FFmpeg-devel] [PATCH] avcodec/audiotoolboxdec: Properly fill out_format

2021-12-30 Thread Christopher Snowhill
y. Signed-off-by: Christopher Snowhill --- libavcodec/audiotoolboxdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index 9939fef218..4abcb63a03 100644 --- a/libavcodec/audiotoolboxdec.c +++ b/libavcodec/audiotoolboxdec.c

[FFmpeg-devel] [PATCH] fate: add test for iTunes gapless MP3

2017-10-01 Thread Christopher Snowhill
I've finally assembled a fate test for this patch. The test file goes here: /gapless/gapless-itunes.mp3 I have uploaded a copy here: https://f.losno.co/gapless-itunes.mp3 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

[FFmpeg-devel] [PATCH] fate: add test for iTunes gapless MP3

2017-10-01 Thread Christopher Snowhill
--- tests/fate/gapless.mak| 3 ++- tests/ref/fate/gapless-mp3-itunes | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/gapless-mp3-itunes diff --git a/tests/fate/gapless.mak b/tests/fate/gapless.mak index 0253b9ec61..46b3b98c13 100644 --- a/

[FFmpeg-devel] [PATCH] avformat: fix ID3v2 parser for v2.2 comment frames

2017-01-27 Thread Christopher Snowhill
From: Chris Moeller --- libavformat/id3v2.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 9969d7a..f7fa3ef 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -823,6 +823,7 @@ static void id3v2_parse(AVIOConte

[FFmpeg-devel] [PATCH] avformat: fix ID3v2 parser for v2.2 comment frames

2017-01-27 Thread Christopher Snowhill
It needs this patch first, but I have some example MP3 files that decode gaplessly with these patches applied. Encoded using the latest iTunes as of this writing (12.5.5.5) on macOS Sierra. Attaching the MP3 files, as well as source FLAC files, after this patch goes through. _

[FFmpeg-devel] [PATCH] avformat: parse iTunes gapless information

2017-01-26 Thread Christopher Snowhill
Signed-off-by: Christopher Snowhill --- libavformat/mp3dec.c | 77 +++- 1 file changed, 76 insertions(+), 1 deletion(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 099ca57..b895e37 100644 --- a/libavformat/mp3dec.c +++ b

[FFmpeg-devel] [FFmpeg-devel, PATCHv5] avformat: parse iTunes gapless information

2017-01-26 Thread Christopher Snowhill
Let's try this again. I can't believe I missed all those things you mentioned. It's almost as if I didn't actually proofread my patch before sending it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv4] avformat: parse iTunes gapless information

2016-12-08 Thread Christopher Snowhill
--- libavformat/mp3dec.c | 70 +++- 1 file changed, 69 insertions(+), 1 deletion(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 56c7f8c..47f4028 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -295,6 +295,59 @@ sta

[FFmpeg-devel] [PATCHv4] iTunes gapless info parsing, hopefully correct this time

2016-12-08 Thread Christopher Snowhill
ed to check the validity of the input values now, giving approximately 32 frames of lead and 64 frames of tail padding, with a rudimentary check on total file size before attempting the total file size check, and error checking on the seek operation. Christopher Snowhill (1): avformat: parse i

Re: [FFmpeg-devel] [PATCH 1/2] avformat: read id3v2 comment tags

2016-07-22 Thread Christopher Snowhill
Sorry for the noise, I made some poor assumptions. First, I wasn’t really paying attention when it mentioned the whitespace errors on apply, and didn’t correct them the first time. Second, I didn’t realize that it would ignore my —subject directive when sending the revised first patch. Now I lea