Re: [FFmpeg-devel] Patchwork issues

2022-09-26 Thread Andriy Gelman
On Mon, 26. Sep 14:46, Marvin Scholz wrote: > As I am not sure who else to email about this, I'll just post it here. > > I tried to register for Patchwork, however I got an error when registering. > I tried again and was told the account already exists, I tried to reset the > password for the acco

Re: [FFmpeg-devel] 答复: [PATCH] avcodec/v4l2_m2m: close the invalid file descriptor -1 in function v4l2_m2m_destroy_context

2022-06-25 Thread Andriy Gelman
Hi, On Sat, 25. Jun 03:04, Wujian(Chin) wrote: > Hi: > Please review it. > Thks! > > -邮件原件- > 发件人: Wujian(Chin) > 发送时间: 2022年6月15日 19:15 > 收件人: 'ffmpeg-devel@ffmpeg.org' > 主题: [PATCH] avcodec/v4l2_m2m: close the invalid file descriptor -1 in > function v4l2_m2m_destroy_context Maybe t

Re: [FFmpeg-devel] [EXT] [PATCH v5 7/7] avcodec/v4l2_m2m_dec: setup capture queue before enqueue the first frame

2022-04-03 Thread Andriy Gelman
Hi Ming, Sorry for the late reply. On Tue, 29. Mar 06:51, Ming Qian wrote: > > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > > Sent: Saturday, March 26, 2022 11:43 PM > > To: FFmpeg development discussions and patches > > Cc: Ming Qian > > Subject: Re: [F

Re: [FFmpeg-devel] [EXT] [PATCH v5 7/7] avcodec/v4l2_m2m_dec: setup capture queue before enqueue the first frame

2022-03-26 Thread Andriy Gelman
Hi Ming, On Mon, 21. Mar 07:27, Ming Qian wrote: > Hi Andriy, > > What do you think of this patch? > > The Initialization flow defined in > linux/Documentation/userspace-api/media/v4l/dev-decoder.rst > 1. Set the coded format on OUTPUT via VIDIOC_S_FMT(). > 2. Allocate source (bytestrea

Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize

2022-03-26 Thread Andriy Gelman
On Wed, 23. Mar 08:51, Wang, Fei W wrote: > > -Original Message- > > From: Wang, Fei W > > Sent: Tuesday, March 22, 2022 10:11 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Linjie Fu ; Wang, Fei W > > Subject: [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize > > > > From: Linj

[FFmpeg-devel] M1 Patchwork CI runner

2022-02-20 Thread Andriy Gelman
Hello, I understand we have some spare M1 minis for ffmpeg resources. Do we want to set up a Patchwork CI runner on M1 hardware? Unfortunately I can't use my x86 box for x86/ppc tests anymore. I have asked Raz if we can setup an x86 VM for the time being until we find some dedicated hardware.

Re: [FFmpeg-devel] fatal: Resolve operation not in progress, we are not resuming.

2022-02-02 Thread Andriy Gelman
Hi, On Wed, 02. Feb 16:02, Bryce Newman wrote: > Hi, > I am trying to apply this patch > https://patchwork.ffmpeg.org/project/ffmpeg/patch/d412c54e-2e51-4522-a8fb-32c5c6ca6...@gettyimages.com/. > I am able to `git apply` the patch locally and `make fate passes`, so I am > not sure what I need to

Re: [FFmpeg-devel] Patchwork FATE Errors

2022-01-20 Thread Andriy Gelman
On Fri, 21. Jan 01:44, Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Andreas > > Rheinhardt > > Sent: Friday, January 21, 2022 2:31 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > > Soft Works: > > > > > >

Re: [FFmpeg-devel] [PATCH v3 21/26] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding

2022-01-20 Thread Andriy Gelman
Hi, On Thu, 20. Jan 15:17, Soft Works wrote: > > > Patches 19,20,21,22 and 23 do not appear on Patchwork. > > Do you have an idea why? The full set is on patchwork now. -- Andriy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

2022-01-09 Thread Andriy Gelman
On Fri, 07. Jan 01:30, Martin Storsjö wrote: > On Wed, 5 Jan 2022, Martin Storsjö wrote: > > > While this function on its own passes all of fate-hevc, there's > > indications that the function might need to handle widths that > > aren't a multiple of 8 (noted in commit > > f63f9be37c799ddc835af358

Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-08 Thread Andriy Gelman
On Tue, 04. Jan 17:58, Andriy Gelman wrote: > On Tue, 04. Jan 17:48, Andriy Gelman wrote: > > Hi Ming, > > > > On Tue, 04. Jan 07:51, Ming Qian wrote: > > > > > > > -Original Message- > > > > From: Andriy Gelman [mailto:andriy.gel...@

Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:48, Andriy Gelman wrote: > Hi Ming, > > On Tue, 04. Jan 07:51, Ming Qian wrote: > > > > > -Original Message- > > > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > > > Sent: Monday, January 3, 2022 12:41 AM > >

Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Andriy Gelman
Hi Ming, On Tue, 04. Jan 07:51, Ming Qian wrote: > > > -Original Message- > > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > > Sent: Monday, January 3, 2022 12:41 AM > > To: FFmpeg development discussions and patches > > Cc: Ming Qian >

Re: [FFmpeg-devel] [PATCH v5 5/7] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:08, Ming Qian wrote: > client need to resume the decoding process > after it dequeues the source change event. > no matter what's the return value of v4l2_resolution_changed(). > if the client doesn't resume the decoding process, > the decoder may keep waiting > > in documentati

Re: [FFmpeg-devel] [PATCH v5 3/7] avcodec/v4l2_context: add v4l2_start_decode

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:08, Ming Qian wrote: > on dynamic resolution change, > The decoding process must be resumed with either a pair of calls to > VIDIOC_STREAMOFF() and VIDIOC_STREAMON() on the CAPTURE queue, or a call > to VIDIOC_DECODER_CMD() with the V4L2_DEC_CMD_START command. > For the patch t

Re: [FFmpeg-devel] [PATCH v5 1/7] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:08, Ming Qian wrote: > in the v4l2 stateful video document, we can see the following > description: > During the resolution change sequence, the OUTPUT queue must remain > streaming. Calling VIDIOC_STREAMOFF() on the OUTPUT queue would > abort the sequence and initiat

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_dec: dequeue frame if input isn't ready

2022-01-02 Thread Andriy Gelman
On Tue, 28. Dec 18:41, Andriy Gelman wrote: > On Mon, 27. Dec 03:18, Cameron Gutman wrote: > > On 12/27/21 00:17, Andriy Gelman wrote: > > > On Tue, 14. Dec 02:12, Cameron Gutman wrote: > > >> The V4L2M2M API operates asynchronously, so multiple packets can >

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/v4l2_m2m_dec: setup capture queue before enqueue the first frame

2022-01-02 Thread Andriy Gelman
On Thu, 19. Aug 16:55, Ming Qian wrote: > there are two proper ways to setup capture queue. > 1. client wait the source change event, >then setup the capture queue and streamon > 2. client setup the capture queue in advance, >but to avoid time issues, client should start >the capture qu

Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-02 Thread Andriy Gelman
On Thu, 19. Aug 16:55, Ming Qian wrote: > client need to resume the decoding process > after it dequeues the source change event. > no matter what's the return value of v4l2_resolution_changed(). > if the client doesn't resume the decoding process, > the decoder may keep waiting > > in documentati

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2022-01-02 Thread Andriy Gelman
On Thu, 19. Aug 16:55, Ming Qian wrote: > in the v4l2 stateful video document, we can see the following > description: > During the resolution change sequence, the OUTPUT queue must remain > streaming. Calling VIDIOC_STREAMOFF() on the OUTPUT queue would > abort the sequence and initiat

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_dec: dequeue frame if input isn't ready

2021-12-28 Thread Andriy Gelman
On Mon, 27. Dec 03:18, Cameron Gutman wrote: > On 12/27/21 00:17, Andriy Gelman wrote: > > On Tue, 14. Dec 02:12, Cameron Gutman wrote: > >> The V4L2M2M API operates asynchronously, so multiple packets can > >> be enqueued before getting a batch of frames back. Since i

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_dec: dequeue frame if input isn't ready

2021-12-26 Thread Andriy Gelman
On Tue, 14. Dec 02:12, Cameron Gutman wrote: > The V4L2M2M API operates asynchronously, so multiple packets can > be enqueued before getting a batch of frames back. Since it was > only possible to receive a frame by submitting another packet, > there wasn't a way to drain those excess output frames

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_dec: dequeue frame if input isn't ready

2021-12-24 Thread Andriy Gelman
On Tue, 14. Dec 02:12, Cameron Gutman wrote: > The V4L2M2M API operates asynchronously, so multiple packets can > be enqueued before getting a batch of frames back. Since it was > only possible to receive a frame by submitting another packet, > there wasn't a way to drain those excess output frames

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-30 Thread Andriy Gelman
On Mon, 16. Aug 20:42, Michael Niedermayer wrote: > On Sun, Aug 15, 2021 at 01:53:23PM -0400, Andriy Gelman wrote: > > On Sun, 15. Aug 17:15, Michael Niedermayer wrote: > > > On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote: > > > > On Sun, 15. A

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/v4l2_m2m_dec: start capture after source change event is received

2021-08-16 Thread Andriy Gelman
On Thu, 29. Jul 14:00, Ming Qian wrote: > if client start the capture queue without waiting the source change > event, > there may be some timing issues. > For example, in client, the sequence is: > capture streamon -> source change -> capture streamoff -> capture > streamon. > but in driver side,

Re: [FFmpeg-devel] [EXT] Re: [PATCH v3 1/3] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2021-08-16 Thread Andriy Gelman
On Mon, 02. Aug 02:32, Ming Qian wrote: > > -Original Message- > > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > > Sent: Monday, August 2, 2021 7:36 AM > > To: FFmpeg development discussions and patches > > Cc: Ming Qian > > Subject: [E

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 16:04, Nicolas George wrote: > Andriy Gelman (12021-08-15): > > That sounds fine. > > See the attached code. > > I have tested it against the 2721 commits I have since the beginning of > the year, it finds 56 to object, about half of them real problems

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 17:15, Michael Niedermayer wrote: > On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote: > > On Sun, 15. Aug 11:17, Nicolas George wrote: > > > Is it possible to add hooks in Patchwork to warn people automatically > > > when their commit messa

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 14:22, Nicolas George wrote: > Andriy Gelman (12021-08-15): > > Yes, nice idea. > > > > If the commit message is invalid I could add a warning similar to: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210809102919.387-1-an...@khirnov.net/ &

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 11:17, Nicolas George wrote: > Is it possible to add hooks in Patchwork to warn people automatically > when their commit message does not match standards? > > If it is possible, I volunteer to write it. > Yes, nice idea. If the commit message is invalid I could add a warning sim

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavformat/isom_tags.c: add ipcm to list of tags

2021-08-14 Thread Andriy Gelman
On Sat, 14. Aug 12:14, Stephen Hutchinson wrote: > ffmpeg | branch: master | Stephen Hutchinson | Wed Jul 14 > 20:16:41 2021 -0400| [1c42fd93236e7869ef4d9fe3650dd3e951387321] | committer: > Paul B Mahol > > libavformat/isom_tags.c: add ipcm to list of tags > > Fixes http://trac.ffmpeg.org/tick

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Andriy Gelman
On Fri, 13. Aug 23:53, Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Friday, 13 August 2021 20:10 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [RFC] Suggestion

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2021-08-01 Thread Andriy Gelman
Hi, On Thu, 29. Jul 14:00, Ming Qian wrote: > in the v4l2 stateful video document, we can see the following > description: > During the resolution change sequence, the OUTPUT queue must remain > streaming. Calling VIDIOC_STREAMOFF() on the OUTPUT queue would > abort the sequence and in

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2021-07-24 Thread Andriy Gelman
Hi, On Thu, 22. Jul 11:01, Ming Qian wrote: > in the v4l2 stateful video document, we can see the following > description: > During the resolution change sequence, the OUTPUT queue must remain > streaming. Calling VIDIOC_STREAMOFF() on the OUTPUT queue would > abort the sequence and in

Re: [FFmpeg-devel] FFMPEG for V4L2 M2M devices ?

2021-07-12 Thread Andriy Gelman
On Mon, 12. Jul 11:02, Dave Stevenson wrote: > On Sat, 10 Jul 2021 at 00:56, Brad Hards wrote: > > > > On Saturday, 10 July 2021 8:53:27 AM AEST Andrii wrote: > > > I am working on porting a Kodi player to an NVidia Jetson Nano device. > > > I've > > > been developing a decoder for quite some tim

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/rtsp: Include rtcp in port range check

2021-07-05 Thread Andriy Gelman
On Sun, 04. Jul 22:51, Martin Storsjö wrote: > On Sun, 4 Jul 2021, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > Currently it is only checked that the rtp port does not exceed rtp_port_max. > > > > Signed-off-by: Andriy Gelman > > --- > &

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Try to continue decoding on zero quant matrix value

2021-07-05 Thread Andriy Gelman
On Sun, 04. Jul 21:28, Michael Niedermayer wrote: > On Sat, Jul 03, 2021 at 12:25:28PM -0400, Andriy Gelman wrote: > > From: Andriy Gelman > > > > A zero value in the quantization matrix is invalid but in practice will > > just set the transform coefficient to zero

[FFmpeg-devel] [PATCH v2 3/3] avformat/rtsp: Include rtcp in port range check

2021-07-04 Thread Andriy Gelman
From: Andriy Gelman Currently it is only checked that the rtp port does not exceed rtp_port_max. Signed-off-by: Andriy Gelman --- libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index bedb75c7bd..a3026f8b73 100644

[FFmpeg-devel] [PATCH v2 2/3] avformat/rtsp: Reindent after previous commit

2021-07-04 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/rtsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 0185baca8e..bedb75c7bd 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1458,9 +1458,9

[FFmpeg-devel] [PATCH v2 1/3] avformat/rtsp: Set port_off to zero for low min/max port range

2021-07-04 Thread Andriy Gelman
From: Andriy Gelman Fixes: $ ffmpeg -min_port 32000 -max_port 32001 -i rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_115k.mov -f null - [1]303871 floating point exception (core dumped) Signed-off-by: Andriy Gelman --- libavformat/rtsp.c | 4 +++- 1 file changed, 3 insertions

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: Fix floating point exception for low min/max port range

2021-07-04 Thread Andriy Gelman
Hi Zhili, On Sun, 04. Jul 19:00, "zhilizhao(赵志立)" wrote: > > > > On Apr 4, 2021, at 11:36 PM, Andriy Gelman wrote: > > > > From: Andriy Gelman > > > > Fixed by setting port offset to zero when it cannot be computed. > > > > To

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: Try to continue decoding on zero quant matrix value

2021-07-03 Thread Andriy Gelman
From: Andriy Gelman A zero value in the quantization matrix is invalid but in practice will just set the transform coefficient to zero after inverse quantization. Try to continue decoding if the AV_EF_EXPLODE flag is not set. Fixes ticket #9287. Signed-off-by: Andriy Gelman --- The last

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: Fix floating point exception for low min/max port range

2021-07-03 Thread Andriy Gelman
On Sun, 04. Apr 11:36, Andriy Gelman wrote: > From: Andriy Gelman > > Fixed by setting port offset to zero when it cannot be computed. > > To reproduce: > $ ffmpeg -min_port 32000 -max_port 32001 -i > rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_115k.mov -f n

Re: [FFmpeg-devel] [PATCH v2] avformat/rtsp: fix timeout option

2021-07-03 Thread Andriy Gelman
On Sun, 30. May 16:24, Andriy Gelman wrote: > From: Andriy Gelman > > 92c40ef882be115e72d2aa02f9032b7ce88f8537 added a listen_timeout option > for sdp. This allowed a user to set variable timeout in sdp which was > originally hard coded to 10 seconds. > > The commit use

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Adjustable discard threshold

2021-06-27 Thread Andriy Gelman
On Sun, 27. Jun 15:53, Michael Niedermayer wrote: > Fixes regression > Fixes: last frame of Ticket9287 > > Analysed-by: Andriy Gelman > Signed-off-by: Michael Niedermayer > --- > libavcodec/mjpegdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[FFmpeg-devel] [PATCH v2] avformat/rtsp: fix timeout option

2021-05-30 Thread Andriy Gelman
From: Andriy Gelman 92c40ef882be115e72d2aa02f9032b7ce88f8537 added a listen_timeout option for sdp. This allowed a user to set variable timeout in sdp which was originally hard coded to 10 seconds. The commit used the initial_timeout variable to store the value. However, in rtsp this variable

Re: [FFmpeg-devel] [PATCH] avfilter/yadif: Fix time base for large denominators

2021-05-24 Thread Andriy Gelman
Hello, On Mon, 24. May 11:52, Tom Boshoven wrote: > This fixes an issue where the yadif filter could cause the timebase > denominator to overflow. > > Signed-off-by: Tom Boshoven > --- > libavfilter/vf_yadif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavfil

Re: [FFmpeg-devel] [PATCH] movenc: add movie_timescale option instead of hardcoding 1000

2021-04-27 Thread Andriy Gelman
On Wed, 28. Apr 09:55, Gyan Doshi wrote: > > > On 2021-04-28 03:05, Vittorio Giovara wrote: > > From: Justin Ruggles > > > > There are cases where using 1000 as the MP4 timescale is not > > accurate enough, for example when one needs sample-accurate audio > > handling. > > > > This adds a new

Re: [FFmpeg-devel] [PATCH] doc/muxers.texi: fix build issue for unknown command

2021-04-18 Thread Andriy Gelman
Hi, On Mon, 19. Apr 01:10, Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Gyan Doshi > > Sent: 2021年4月18日 23:45 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH] doc/muxers.texi: fix build issue for > > unknown command > > > >

Re: [FFmpeg-devel] [PATCH 2/4] doc/protocols: update options

2021-04-10 Thread Andriy Gelman
On Sat, 10. Apr 12:40, Gyan Doshi wrote: > > > On 2021-04-10 11:45, Andriy Gelman wrote: > > On Sun, 15. Nov 13:20, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > Define listen_timeout. Set user-agent and timeout to deprecated.

[FFmpeg-devel] [PATCH v2] avformat/rtsp: fix timeout option

2021-04-10 Thread Andriy Gelman
From: Andriy Gelman 92c40ef882be115e72d2aa02f9032b7ce88f8537 added a listen_timeout option for sdp. This allowed a user to set variable timeout in sdp which was originally hard coded to 10 seconds. The commit used the initial_timeout variable to store the value. However, in rtsp this variable

Re: [FFmpeg-devel] [PATCH 2/4] doc/protocols: update options

2021-04-09 Thread Andriy Gelman
On Sun, 15. Nov 13:20, Andriy Gelman wrote: > From: Andriy Gelman > > Define listen_timeout. Set user-agent and timeout to deprecated. > > Signed-off-by: Andriy Gelman > --- > doc/protocols.texi | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rtsp: set AV_OPT_FLAG_DEPRECATED on depracated options

2021-04-04 Thread Andriy Gelman
On Sun, 10. Jan 10:57, Andriy Gelman wrote: > On Thu, 17. Dec 10:42, Andriy Gelman wrote: > > On Tue, 08. Dec 22:35, Andriy Gelman wrote: > > > Hi Zhao, > > > > > > Thanks for reviewing. > > > > > > On Tue, 08. Dec 13:25, "zhilizhao(赵志立

[FFmpeg-devel] [PATCH 1/3] avformat/rtsp: Fix floating point exception for low min/max port range

2021-04-04 Thread Andriy Gelman
From: Andriy Gelman Fixed by setting port offset to zero when it cannot be computed. To reproduce: $ ffmpeg -min_port 32000 -max_port 32001 -i rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_115k.mov -f null - [1]303871 floating point exception (core dumped) Signed-off-by: Andriy

[FFmpeg-devel] [PATCH 3/3] avformat/rtsp: Include rtcp in port range check

2021-04-04 Thread Andriy Gelman
From: Andriy Gelman Currently it is only checked that the rtp port does not exceed rtp_port_max. --- libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 6438e2edb8..e6a068148b 100644 --- a/libavformat/rtsp.c +++ b

[FFmpeg-devel] [PATCH 2/3] avformat/rtsp: Reindent after previous commit

2021-04-04 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/rtsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 76efbf42cd..6438e2edb8 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1466,9 +1466,9

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: don't reduce short seek threshold

2021-03-16 Thread Andriy Gelman
On Mon, 15. Mar 11:52, Martin Storsjö wrote: > On Sat, 13 Mar 2021, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > Commit 8c8e5d5286bf598a89ef9993a2cf6ea409d03a32 added a way to reduce > > seek time by waiting for the windowed tcp packets instead of creati

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-03-14 Thread Andriy Gelman
On Sat, 13. Mar 00:02, Andriy Gelman wrote: > On Sun, 28. Feb 10:39, Andriy Gelman wrote: > > On Sun, 28. Feb 13:57, sgerwk-at-aol@ffmpeg.org wrote: > > > Hi, > > > > > > On Sat, 27 Feb 2021, Andriy Gelman wrote: > > > > > > >

[FFmpeg-devel] [PATCH] avformat/aviobuf: don't reduce short seek threshold

2021-03-13 Thread Andriy Gelman
From: Andriy Gelman Commit 8c8e5d5286bf598a89ef9993a2cf6ea409d03a32 added a way to reduce seek time by waiting for the windowed tcp packets instead of creating a new socket connection. It implemented this by overwriting s->short_seek_threshold in the avio_seek(). However, s->short_seek_thr

Re: [FFmpeg-devel] [PATCH 2/2] RFC ffmpeg: exit demuxers earlier after signal received

2021-03-13 Thread Andriy Gelman
On Sun, 07. Feb 15:04, Andriy Gelman wrote: > On Sat, 28. Nov 14:46, Andriy Gelman wrote: > > From: Andriy Gelman > > > > We currently use the same interrupt_callback function for both muxers > > and demuxers to break out of potential infinite loops. > > >

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-03-12 Thread Andriy Gelman
On Sun, 28. Feb 10:39, Andriy Gelman wrote: > On Sun, 28. Feb 13:57, sgerwk-at-aol@ffmpeg.org wrote: > > Hi, > > > > On Sat, 27 Feb 2021, Andriy Gelman wrote: > > > > > On Mon, 22. Feb 17:53, sgerwk-at-aol@ffmpeg.org wrote: > > > > Hi, >

Re: [FFmpeg-devel] [PATCH] avformat/httpauth: don't overwrite auth digest with unimplemented algorithm

2021-03-12 Thread Andriy Gelman
On Sun, 07. Mar 18:14, Andriy Gelman wrote: > From: Andriy Gelman > > In rtsp/http authentication the server may provide several options for > hash algorithms. This includes MD5, SHA2-256 and SHA2-512/256 (RFC 7616 > Section 3.7). Currently only support for MD5 is implemented i

[FFmpeg-devel] [PATCH] avformat/httpauth: don't overwrite auth digest with unimplemented algorithm

2021-03-07 Thread Andriy Gelman
From: Andriy Gelman In rtsp/http authentication the server may provide several options for hash algorithms. This includes MD5, SHA2-256 and SHA2-512/256 (RFC 7616 Section 3.7). Currently only support for MD5 is implemented in the auth code. If the SHA2 option follows the MD5 option in the

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-02-28 Thread Andriy Gelman
On Sun, 28. Feb 13:57, sgerwk-at-aol@ffmpeg.org wrote: > Hi, > > On Sat, 27 Feb 2021, Andriy Gelman wrote: > > > On Mon, 22. Feb 17:53, sgerwk-at-aol@ffmpeg.org wrote: > > > Hi, > > > > > > On Sun, 21 Feb 2021, Andriy Gelman wrote: > &

Re: [FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-28 Thread Andriy Gelman
gt; > law-and-order-partial.wtv from the FATE-suite exhibited the problem. > > Thanks-to: Andriy Gelman > Signed-off-by: Andreas Rheinhardt > --- > libavformat/wtvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/wtvdec.c b/libavformat

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-02-27 Thread Andriy Gelman
On Mon, 22. Feb 17:53, sgerwk-at-aol@ffmpeg.org wrote: > Hi, > > On Sun, 21 Feb 2021, Andriy Gelman wrote: > > Hi, > > > > Thanks for updating the patch. Sorry for the delay in getting you some > > feedback.. > > > > When I tested with -show_mo

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-02-21 Thread Andriy Gelman
return to avoid this? > > On Sun, 7 Feb 2021, Andriy Gelman wrote: > > > Also the commit title should start with avdevice/xcbgrab: or lavd/xcbgrab: > > > > done > > > > > If you try with -show_region 1, the border gets drawn in the wrong place. > >

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

2021-02-20 Thread Andriy Gelman
Hi Reimar, On Sat, 20. Feb 12:34, Reimar Döffinger wrote: > Hi! > > > On 24 Jan 2021, at 17:35, Andriy Gelman wrote: > > > > On Sat, 07. Nov 16:31, Andriy Gelman wrote: > >> On Sat, 31. Oct 10:17, Andriy Gelman wrote: > >>> On Fri, 16. Oct 00:02, A

Re: [FFmpeg-devel] [PATCH 2/2] RFC ffmpeg: exit demuxers earlier after signal received

2021-02-07 Thread Andriy Gelman
On Sat, 28. Nov 14:46, Andriy Gelman wrote: > From: Andriy Gelman > > We currently use the same interrupt_callback function for both muxers > and demuxers to break out of potential infinite loops. > > The function decode_interrupt_cb() checks for how many SIGINT/SIGTERM >

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-02-07 Thread Andriy Gelman
Hi, On Tue, 26. Jan 11:23, sgerwk-at-aol@ffmpeg.org wrote: > In my previous email the patch got mangled by the web mail interface, so I am > sending it again. Sorry for the duplicate. I couldn't apply this version, but previous one applied ok: https://patchwork.ffmpeg.org/project/ffmpeg/patch

Re: [FFmpeg-devel] [PATCH v4 8/9] avcodec/cbs_h2645: vvc, do not skip nals for nuh_layer_id > 0

2021-02-05 Thread Andriy Gelman
On Sat, 06. Feb 11:30, Nuo Mi wrote: > On Mon, Jan 25, 2021 at 10:21 PM Nuo Mi wrote: > > > > > On Mon, Jan 25, 2021 at 10:17 PM Nuo Mi wrote: > > > >> --- > >> libavcodec/cbs_h2645.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/libavcodec/cbs_h2645.c b/li

Re: [FFmpeg-devel] [PATCH 00/10] deprecate av_init_packet() and sizeof(AVPacket) as part of the ABI

2021-02-02 Thread Andriy Gelman
On Mon, 01. Feb 19:44, James Almer wrote: > As the subject says, this puts AVPacket in line with AVFrame, allowing > easier extensibility of the struct, and preventing potential undefined > behavior > in some cases when packets are used uninitialized on stack. > > This set adapts only a few modul

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: don't assume Xserver endianness

2021-02-01 Thread Andriy Gelman
On Sun, 31. Jan 23:28, Carl Eugen Hoyos wrote: > Am So., 31. Jan. 2021 um 20:51 Uhr schrieb Andriy Gelman > : > > > > From: Andriy Gelman > > > > Xserver defines the endianness of the grabbed images. Use this information > > to set the correct pixel format

[FFmpeg-devel] [PATCH] avdevice/xcbgrab: don't assume Xserver endianness

2021-01-31 Thread Andriy Gelman
From: Andriy Gelman Xserver defines the endianness of the grabbed images. Use this information to set the correct pixel format. This also fixes format selection in configuration depth=32/bpp=32 with Xserver on a little endian machine. Before the patch, the big endian layout 0RGB was always

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

2021-01-24 Thread Andriy Gelman
On Sat, 07. Nov 16:31, Andriy Gelman wrote: > On Sat, 31. Oct 10:17, Andriy Gelman wrote: > > On Fri, 16. Oct 00:02, Andriy Gelman wrote: > > > On Fri, 09. Oct 20:17, Andriy Gelman wrote: > > > > From: Chip Kerchner > > > > > > > &

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: don't overwrite session control uri

2021-01-17 Thread Andriy Gelman
On Sun, 17. Jan 19:55, Andriy Gelman wrote: > On Mon, 18. Jan 00:49, Carl Eugen Hoyos wrote: > > Am So., 11. Okt. 2020 um 01:54 Uhr schrieb Andriy Gelman > > : > > > > > > From: Andriy Gelman > > > > > > Fixes #1941 > > > > > >

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: don't overwrite session control uri

2021-01-17 Thread Andriy Gelman
On Mon, 18. Jan 00:49, Carl Eugen Hoyos wrote: > Am So., 11. Okt. 2020 um 01:54 Uhr schrieb Andriy Gelman > : > > > > From: Andriy Gelman > > > > Fixes #1941 > > > > Currently the session control uri gets overwritten by the media's uri > > wh

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: don't overwrite session control uri

2021-01-17 Thread Andriy Gelman
On Sat, 31. Oct 10:16, Andriy Gelman wrote: > On Wed, 21. Oct 13:39, Andriy Gelman wrote: > > On Sat, 10. Oct 19:22, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > Fixes #1941 > > > > > > Currently the session control uri ge

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2021-01-10 Thread Andriy Gelman
On Sun, 10. Jan 16:32, Zane van Iperen wrote: > On 29/11/20 5:46 am, Andriy Gelman wrote: > > > void term_init(void) > > { > > +#if defined __linux__ > > +struct sigaction action; Hi Zane, Thanks for reviewing the patch. > > Nit: Should this have

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2021-01-10 Thread Andriy Gelman
On Sun, 13. Dec 11:41, Andriy Gelman wrote: > On Sat, 28. Nov 14:46, Andriy Gelman wrote: > > From: Andriy Gelman > > > > As per signal() help (man 2 signal) the semantics of using signal may > > vary across platforms. It is suggested to use sigaction() instead.

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rtsp: set AV_OPT_FLAG_DEPRECATED on depracated options

2021-01-10 Thread Andriy Gelman
On Thu, 17. Dec 10:42, Andriy Gelman wrote: > On Tue, 08. Dec 22:35, Andriy Gelman wrote: > > Hi Zhao, > > > > Thanks for reviewing. > > > > On Tue, 08. Dec 13:25, "zhilizhao(赵志立)" wrote: > > > > > > > > > > On Dec 8,

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: add support for satip://

2020-12-22 Thread Andriy Gelman
On Mon, 21. Dec 16:35, Aman Karmani wrote: > From: Aman Karmani > > The SAT>IP protocol[1] is similar to RTSP. However SAT>IP servers > are assumed to speak only MP2T, so DESCRIBE is not used in the same > way. When no streams are active, DESCRIBE will return 404 according > to the spec (see sect

Re: [FFmpeg-devel] [PATCH] avformat/amqp: parse vhost in uri

2020-12-20 Thread Andriy Gelman
On Sun, 20. Dec 23:11, Marton Balint wrote: > > > On Sat, 19 Dec 2020, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > Signed-off-by: Andriy Gelman > > --- > > doc/protocols.texi| 7 --- > > libavformat/libamqp.c | 31 +++

[FFmpeg-devel] [PATCH] avformat/amqp: parse vhost in uri

2020-12-19 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/protocols.texi| 7 --- libavformat/libamqp.c | 31 ++- 2 files changed, 30 insertions(+), 8 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index b4efa14509..de377a9546 100644 --- a

Re: [FFmpeg-devel] [PATCH] avformat/libamqp: add option vhost

2020-12-19 Thread Andriy Gelman
On Sat, 19. Dec 18:41, Florian Levis wrote: > I have no idea how to do it. > I can take a look ; but I'm really not sure how to do it. > > If one of you can handle it it might be safer ; if you can't, I will try. > Just let me know. I can send in the patch. -- Andriy

Re: [FFmpeg-devel] [PATCH] avformat/libamqp: add option vhost

2020-12-19 Thread Andriy Gelman
On Sat, 19. Dec 11:54, Marton Balint wrote: > > > On Fri, 18 Dec 2020, Andriy Gelman wrote: > > > On Thu, 17. Dec 21:34, Florian Levis wrote: > > > From: Florian Levis > > > > > > Add option vhost to allow publishing on other > > > vhos

Re: [FFmpeg-devel] [PATCH] avformat/libamqp: add option vhost

2020-12-18 Thread Andriy Gelman
On Thu, 17. Dec 21:34, Florian Levis wrote: > From: Florian Levis > > Add option vhost to allow publishing on other > vhost than default '/' > > Signed-off-by: Florian Levis > --- > doc/protocols.texi| 3 +++ > libavformat/libamqp.c | 4 +++- > 2 files changed, 6 insertions(+), 1 deletion(

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dpx: fix use of uninitialised value

2020-12-18 Thread Andriy Gelman
On Fri, 18. Dec 18:22, James Almer wrote: > ffmpeg | branch: master | James Almer | Fri Dec 18 > 14:31:47 2020 -0300| [20b09b20a942d4aad38f9fa1324b713168d3db9a] | committer: > James Almer > > avcodec/dpx: fix use of uninitialised value > > Found by Valgrind. > > Reviewed-by: Paul B Mahol > S

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rtsp: set AV_OPT_FLAG_DEPRECATED on depracated options

2020-12-17 Thread Andriy Gelman
On Tue, 08. Dec 22:35, Andriy Gelman wrote: > Hi Zhao, > > Thanks for reviewing. > > On Tue, 08. Dec 13:25, "zhilizhao(赵志立)" wrote: > > > > > > > On Dec 8, 2020, at 12:08 PM, Andriy Gelman > > > wrote: > > > > > &g

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2020-12-13 Thread Andriy Gelman
On Sat, 28. Nov 14:46, Andriy Gelman wrote: > From: Andriy Gelman > > As per signal() help (man 2 signal) the semantics of using signal may > vary across platforms. It is suggested to use sigaction() instead. > > On my system, the capture signal is reset to the default handler

Re: [FFmpeg-devel] [PATCH] swscale/rgb2rgb_template: use shuffle macro on BE arches

2020-12-12 Thread Andriy Gelman
On Sun, 13. Dec 00:22, Carl Eugen Hoyos wrote: > Am Sa., 12. Dez. 2020 um 23:41 Uhr schrieb Andriy Gelman > : > > > > On Wed, 02. Dec 22:09, Michael Niedermayer wrote: > > > On Mon, Nov 30, 2020 at 12:46:51AM -0500, Andriy Gelman wrote: > > > > From: Andriy G

Re: [FFmpeg-devel] [PATCH] swscale/rgb2rgb_template: use shuffle macro on BE arches

2020-12-12 Thread Andriy Gelman
On Wed, 02. Dec 22:09, Michael Niedermayer wrote: > On Mon, Nov 30, 2020 at 12:46:51AM -0500, Andriy Gelman wrote: > > From: Andriy Gelman > > > > Fixes fate-qtrle-32bit on PPC64 qemu > > also fixes this on mips-qemu > > LGTM > > thx > thanks,

Re: [FFmpeg-devel] [PATCH] fate: fix fate-filter-hqx on BE arches

2020-12-12 Thread Andriy Gelman
On Sat, 05. Dec 23:51, Michael Niedermayer wrote: > On Fri, Dec 04, 2020 at 09:26:11PM -0500, Andriy Gelman wrote: > > From: Andriy Gelman > > > > One of the inputs to the fate test has an rgba pixel format which needs > > to be converted to rgb32 (argb on BE) for t

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rtsp: set AV_OPT_FLAG_DEPRECATED on depracated options

2020-12-08 Thread Andriy Gelman
Hi Zhao, Thanks for reviewing. On Tue, 08. Dec 13:25, "zhilizhao(赵志立)" wrote: > > > > On Dec 8, 2020, at 12:08 PM, Andriy Gelman wrote: > > > > On Sun, 15. Nov 13:20, Andriy Gelman wrote: > >> From: Andriy Gelman > >> > >> Signe

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-08 Thread Andriy Gelman
Hi, On Mon, 07. Dec 10:32, Harry Mallon wrote: > Signed-off-by: Harry Mallon > --- > tests/fate/image.mak | 4 ++ > tests/ref/fate/dpx-probe | 85 > 2 files changed, 89 insertions(+) > create mode 100644 tests/ref/fate/dpx-probe > > diff --git a/te

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rtsp: set AV_OPT_FLAG_DEPRECATED on depracated options

2020-12-07 Thread Andriy Gelman
On Sun, 15. Nov 13:20, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > libavformat/rtsp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index d9832bbf1f

Re: [FFmpeg-devel] [PATCH 2/2] avformat/framecrcenc: Make side-data checksums endian-independent

2020-12-06 Thread Andriy Gelman
On Sun, 06. Dec 04:09, Andreas Rheinhardt wrote: > Do this by converting big-endian side data to little endian for > checksumming. Fixes the ts-demux FATE test. It's quite nicely done imo. Same as Michael, I enabled ts-demux test in link below and it worked fine (PPC64 qemu) https://patchwork.f

Re: [FFmpeg-devel] [PATCH 2/3] fate/mxf: Fix d10-user-comments test

2020-12-05 Thread Andriy Gelman
On Fri, 04. Dec 23:57, Andreas Rheinhardt wrote: > The mxf_d10 muxer is very picky regarding the input it accepts: > The only video accepted is MPEG-2 with absolutely constant bitrate, > i.e. all packets need to have exactly the same size; and only a few > bitrates are accepted. > > The sample fil

[FFmpeg-devel] [PATCH] fate: fix fate-filter-hqx on BE arches

2020-12-04 Thread Andriy Gelman
From: Andriy Gelman One of the inputs to the fate test has an rgba pixel format which needs to be converted to rgb32 (argb on BE) for the hqx filter. Because auto scaling in the fate test is disabled, this needs a separate scale filter. Signed-off-by: Andriy Gelman --- tests/fate/filter

Re: [FFmpeg-devel] [PATCH] swscale/rgb2rgb_template: use shuffle macro on BE arches

2020-12-03 Thread Andriy Gelman
On Tue, 01. Dec 00:45, Carl Eugen Hoyos wrote: > Am Mo., 30. Nov. 2020 um 06:48 Uhr schrieb Andriy Gelman > : > > > > From: Andriy Gelman > > > > Fixes fate-qtrle-32bit on PPC64 qemu > > I suspect your patch fixes colourspace conversion (and the fate > t

  1   2   3   4   5   6   >