Re: [FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

2024-07-20 Thread Aaron
0 header. > > nice find > > > I have made changes in the patch attached to fix these problems. > > thx for sharing. > the patch needs a small amount of improvement. see below for my > suggestions. > > > From 306f9db010cf000eb8477aca243fc970f5b95df8 Mon Sep 17

[FFmpeg-devel] [PATCH] lavc/libvpxenc: Fix parsing of ts_layering_mode parameter

2024-05-15 Thread Aaron Thompson via ffmpeg-devel
The value was being parsed as base 4, so the value "4" was invalid and would result in ts_layering_mode being set to 0. Signed-off-by: Aaron Thompson --- libavcodec/libvpxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/l

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-09-09 Thread Aaron Boushley
to go from no notification to an error log. I could also just put a continue call there, or do more research to figure out if I can go to without having any content on the line. Suggestions for what I should do differently with that context? Aaron On Mon, Sep 9, 2019, 9:13 AM Michael Niederma

[FFmpeg-devel] [PATCH] libsrt: add password ACL support using new streamID specification

2019-09-09 Thread Aaron Boxer
, Aaron From 8a11e0d673872049b8260cb08f3c7cb40f9a1297 Mon Sep 17 00:00:00 2001 From: Aaron Boxer Date: Wed, 14 Aug 2019 08:26:17 -0400 Subject: [PATCH] libsrt: support streamid spec --- libavformat/libsrt.c | 135 +++ 1 file changed, 135 insertions(+) diff

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-09-07 Thread Aaron Boushley
Can I get a review on this. Anywhere we have code calling out and performing undefined behavior we should clean that up. Aaron On Sat, Jul 27, 2019 at 7:58 AM Aaron Boushley wrote: > > The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. > Each of these use `continue

[FFmpeg-devel] [PATCH 1/1] Support new SRT streamid specification

2019-08-14 Thread Aaron Boxer
This patch supports the new SRT streamid spec allowing caller to send key/value pairs of parameters to the listener, including user name. A callback parses the streamid - in this case, the parsers chooses the passphrase for the user based on specified list of passphrases. Thanks, Aaron From

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-07-27 Thread Aaron Boushley
force an exit from the macro code (e.g. through a goto or a return) in order to prevent undefined results." This patch adjusts vf_drawtext to use goto error handlers similar to other locations in ffmpeg. Aaron PS Sorry for having to send again, sent from the wrong address last time, so patchw

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-07-27 Thread Aaron Boushley
force an exit from the macro code (e.g. through a goto or a return) in order to prevent undefined results." This patch adjusts vf_drawtext to use goto error handlers similar to other locations in ffmpeg. Aaron PS Sorry for having to send again, sent from the wrong address last time, so patchw

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-07-26 Thread Aaron Boushley
force an exit from the macro code (e.g. through a goto or a return) in order to prevent undefined results." This patch adjusts vf_drawtext to use goto error handlers similar to other locations in ffmpeg. Aaron libavfilter-drawtext-avoid-undefined-behavior.patch Description: B

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing (Take 2)

2018-11-13 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 3:48 PM Aaron Boushley wrote: > > Sorry for the second thread, first one was corrupted with a newline > because I attempted an inline patch. Hopefully the mime-type will be set > correctly on this one. > --- > When parsing a fragmented MP4 with the use_m

[FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing (Take 2)

2018-11-05 Thread Aaron Boushley
doesn't require a scan of the entire file. Aaron From 61412c5990037484e13c7daa60d83b8ba548b8a6 Mon Sep 17 00:00:00 2001 From: Aaron Boushley Date: Mon, 5 Nov 2018 11:02:00 -0800 Subject: [PATCH] libavformat/mov: Speed up fragmented mp4 parsing When parsing a fragmented MP4 with the use_mfr

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 3:25 PM Aaron Boushley wrote: > > On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote: > > > > 2018-11-06 0:03 GMT+01:00, Aaron Boushley : > > > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer > > > wrote: > > > > &

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote: > > 2018-11-06 0:03 GMT+01:00, Aaron Boushley : > > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer > > wrote: > > >> > diff --git a/libavformat/mov.c b/libavformat/mov.c > >> > index ec57a0580

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer wrote: > > On Mon, Nov 05, 2018 at 11:17:25AM -0800, Aaron Boushley wrote: > > When parsing a fragmented MP4 with the use_mfra_for option set so that > > the mfra box is parsed we currently continue to parse all the top level &g

[FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Aaron Boushley
option is passed). When loading the file over a network this results in significantly better performance since avformat_open_input doesn't require a scan of the entire file. Signed-off-by: Aaron Boushley --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mo

Re: [FFmpeg-devel] [PATCH] tcp: properly return EOF

2017-12-30 Thread Aaron Levinson
On 12/30/2017 8:44 AM, wm4 wrote: There is no POSIX error code for EOF - recv() signals EOF by simply returning 0. But libavformat recently changed its conventionts and "conventionts" -> "conventions" requires an explicit AVERROR_EOF, or it might get into an endless retry loop, consuming 100%

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2017-12-30 Thread Aaron Levinson
e need for using goto and the done label: store the return value of ScheduleAudioSamples() in a local variable. Then, free outbuf if appropriate. Then handle the ScheduleAudioSamples() failure case. Eliminating the goto will also make the code easier to understand, and it will result

Re: [FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

2017-12-30 Thread Aaron Levinson
FSET(enable_scte_104), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, DEC, "enable_scte_104"}, { NULL }, }; diff --git a/libavdevice/version.h b/libavdevice/version.h index 364404d65e..0d4477f82e 100644 --- a/libavdevice/version.h +++ b/libavdevice/version.h @@ -29,7 +29,7

Re: [FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

2017-12-29 Thread Aaron Levinson
ERROR(). +goto error; +} else { +ctx->vanc_ctx->verbose = 0; +ctx->vanc_ctx->callbacks = &callbacks; +} +#endif + if (ctx->dli->StartStreams() != S_OK) { av_log(avctx, AV_LOG_ERROR, "Cannot start input stream\n"); ret = AVERROR(EIO); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

2017-12-29 Thread Aaron Levinson
c 8.2.5) */ +sei_data[7] = 0x41; +sei_data[8] = 0xf0 | side_data->data[0]; + +return 0; +} + int64_t ff_guess_coded_bitrate(AVCodecContext *avctx) { AVRational framerate = avctx->framerate; I don't know enough about this to review the technical aspects of this co

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 Thread Aaron Levinson
io_mode"}, +{ "discrete", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AUDIO_MODE_DISCRETE}, 0, 0,DEC, "audio_mode"}, +{ "pairs",NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AUDIO_MODE_PAIRS}, 0, 0,DEC, "audio_mode"}, { "duplex_mode", "duplex mode", OFFSET(duplex_mode), AV_OPT_TYPE_INT, { .i64 = 0}, 0, 2,DEC, "duplex_mode"}, { "unset", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 0}, 0, 0,DEC, "duplex_mode"}, { "half", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 1}, 0, 0,DEC, "duplex_mode"}, Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2017-12-29 Thread Aaron Levinson
On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is d

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Aaron Levinson
deo modes, then there probably ought to be checks to make sure the code changes are only exercised for those video modes. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

2017-12-28 Thread Aaron Levinson
formance perspective. According to the blog post, it builds at least twice as fast under WSL than it does with msys2. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-11 Thread Aaron Levinson
On 12/9/2017 11:25 PM, Rostislav Pehlivanov wrote: On 10 December 2017 at 02:41, Aaron Levinson wrote: On 12/9/2017 6:24 PM, Aaron Levinson wrote: On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W

Re: [FFmpeg-devel] [PATCH] lavc/utils: remove unnecessary locking

2017-12-11 Thread Aaron Levinson
x object, perhaps one stored in avctx->internal. This approach would also eliminate the codec_mutex memory leak. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Aaron Levinson
On 12/9/2017 6:24 PM, Aaron Levinson wrote: On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Aaron Levinson
On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: On

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Aaron Levinson
On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote: After commi

Re: [FFmpeg-devel] [PATCH] configure, fftools/Makefile: Copy .pdb files to bindir for MSVC builds for make install

2017-11-09 Thread Aaron Levinson
Ping On 10/31/2017 11:05 AM, Aaron Levinson wrote: When ffmpeg is built using MSVC, symbols are stored separately from executables and libraries in .pdb files. However, unlike with gcc-based builds, when make install is invoked, symbols, in the form of .pdb files, which are important for

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

2017-11-08 Thread Aaron Levinson
On 11/8/2017 7:20 PM, James Almer wrote: Should fix ticket #6822 Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 191547ff10..e90b42811a 10

Re: [FFmpeg-devel] [PATCH] Fixing small memory leak when wrapping texture in AVD3D11FrameDescriptor

2017-11-07 Thread Aaron Levinson
ource base, and this issue exists there as well. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-11-05 Thread Aaron Levinson
See comments below. Aaron Levinson On 11/5/2017 4:49 PM, Marton Balint wrote: On Fri, 27 Oct 2017, Jeyapal, Karthick wrote: Please find the patch attached. Thanks, below some comments: From b18679b91a79f5e23a5ad23ae70f3862a34ddfb8 Mon Sep 17 00:00:00 2001 From: Karthick J Date: Fri

Re: [FFmpeg-devel] [PATCH 1/2] configure: Rename wincrypt to advapi32 for consistency with existing uses of check_lib

2017-10-31 Thread Aaron Levinson
On 10/31/2017 11:44 AM, Hendrik Leppkes wrote: On Tue, Oct 31, 2017 at 6:50 PM, Aaron Levinson wrote: Signed-off-by: Aaron Levinson --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ea22d692b9..572299c9d3 100755 --- a

[FFmpeg-devel] [PATCH] configure, fftools/Makefile: Copy .pdb files to bindir for MSVC builds for make install

2017-10-31 Thread Aaron Levinson
. Signed-off-by: Aaron Levinson --- configure| 4 +++- fftools/Makefile | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 2ac6fed98a..feb86b2069 100755 --- a/configure +++ b/configure @@ -5101,9 +5101,10 @@ case $target_os in

[FFmpeg-devel] [PATCH 2/2] configure: Fix backup libmfx MSVC build by adding advapi32 library dependency

2017-10-31 Thread Aaron Levinson
Signed-off-by: Aaron Levinson --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 572299c9d3..2ac6fed98a 100755 --- a/configure +++ b/configure @@ -5994,7 +5994,7 @@ enabled libkvazaar&& require_pkg_config libkvazaar

[FFmpeg-devel] [PATCH 1/2] configure: Rename wincrypt to advapi32 for consistency with existing uses of check_lib

2017-10-31 Thread Aaron Levinson
Signed-off-by: Aaron Levinson --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ea22d692b9..572299c9d3 100755 --- a/configure +++ b/configure @@ -3327,7 +3327,7 @@ avformat_deps="avcodec avutil" avformat_suggest="li

Re: [FFmpeg-devel] [PATCH] ffmpeg: Add spherical_mapping command-line option.

2017-10-06 Thread Aaron Colwell
Hi Mark, You aren't missing anything. I haven't really used bsf's so it didn't occur to me to use them. I'll take a look. Thanks for the suggestion. Aaron On Fri, Oct 6, 2017 at 8:53 AM Mark Thompson wrote: > On 06/10/17 16:19, Aaron Colwell wrote: > > Allow

[FFmpeg-devel] [PATCH] ffmpeg: Add spherical_mapping command-line option.

2017-10-06 Thread Aaron Colwell
Allows spherical mapping metadata to be injected into files. From 6a86e9766708b9b74e4ae0ec6928a81df4041afc Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 6 Oct 2017 08:14:15 -0700 Subject: [PATCH] ffmpeg: Add spherical_mapping command-line option. Allows spherical mapping metadata to be

Re: [FFmpeg-devel] [PATCH] JPEG2000 encoding with variable codeblock size

2017-08-04 Thread Aaron Boxer
be less or equal to 12 ( xvalue + yvalue <=12). So 64x128 >> are allowed because >> >> xvalue = 4 and yvalue = 5. >> >> >> >> On 03/08/2017 19.24, Aaron Boxer wrote: >> >>> On Aug 3, 2017 9:58 AM, wrote: >>> >>> From: France

Re: [FFmpeg-devel] [PATCH] JPEG2000 encoding with variable codeblock size

2017-08-03 Thread Aaron Boxer
On Aug 3, 2017 9:58 AM, wrote: From: Francesco Cuzzocrea Hi to all I've made some simple changes tha allow encoding with variable codeblock size. Default value are the same as previous (16X16) but now setting them to 64x128 make generated codestream compatible with Analog Devices ADV212 video

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-08-02 Thread Aaron Boxer
Sorry, it looks like this is a packet capture of mpeg ts. On Wed, Aug 2, 2017 at 1:26 PM, Aaron Boxer wrote: > > > On Wed, Aug 2, 2017 at 12:02 PM, Carl Eugen Hoyos > wrote: > >> 2017-08-02 14:07 GMT+02:00 Aaron Boxer : >> > On Sun, Jul 23, 2017 at 6

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-08-02 Thread Aaron Boxer
On Wed, Aug 2, 2017 at 12:02 PM, Carl Eugen Hoyos wrote: > 2017-08-02 14:07 GMT+02:00 Aaron Boxer : > > On Sun, Jul 23, 2017 at 6:16 PM, Carl Eugen Hoyos wrote: > > > >> 2017-07-22 15:39 GMT+02:00 Aaron Boxer : > >> > >> > GStreamer project now ha

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-08-02 Thread Aaron Boxer
On Sun, Jul 23, 2017 at 6:16 PM, Carl Eugen Hoyos wrote: > 2017-07-22 15:39 GMT+02:00 Aaron Boxer : > > > GStreamer project now has a working muxer/demuxer for J2K over MPEG TS. > > Did you test it? > I have acquired a test capture of VSF TR1 video from a nevion VS902: ht

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-07-23 Thread Aaron Boxer
On Sun, Jul 23, 2017 at 6:16 PM, Carl Eugen Hoyos wrote: > 2017-07-22 15:39 GMT+02:00 Aaron Boxer : > > > GStreamer project now has a working muxer/demuxer for J2K over MPEG TS. > > Did you test it? > Hi Carl. muxer+demuxer pipeline has been tested in GStreamer. Not

[FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-07-22 Thread Aaron Boxer
test this feature with GStreamer, if anyone is interested. Cheers, Aaron ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: add support for receiving op47 teletext

2017-07-03 Thread Aaron Levinson
On 7/3/2017 1:06 PM, Marton Balint wrote: On Mon, 3 Jul 2017, Aaron Levinson wrote: +22, and lines 318 to 335. Line 6 is the LSB in the mask. Selected lines which +do not contain teletext information will be ignored. You can use the special +@option{all} constant to select all possible

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: add support for receiving op47 teletext

2017-07-03 Thread Aaron Levinson
av_log(avctx, AV_LOG_ERROR, "Libzvbi support is needed for capturing teletext, please recompile FFmpeg.\n"); -return AVERROR(ENOSYS); -} -#endif - /* Check audio channel option for valid values: 2, 8 or 16 */ switch (cctx->audio_channel

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

2017-07-03 Thread Aaron Levinson
if (i == 22) +i = 317; } - if (i == 22) -i = 317; } vanc->Release(); if (txt_buf - txt_buf0 > 1) { Overall, looks good. I'll review the second patch in a bit. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Attached a new patch that fixes a bug and the indentation in the previous patch. This should be good now. Sorry for the spam. Aaron On Mon, Jun 5, 2017 at 12:32 PM Aaron Colwell wrote: > Comments below.. > > On Mon, Jun 5, 2017 at 12:02 PM Vittorio Giovara < > vittorio.giov...@g

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Comments below.. On Mon, Jun 5, 2017 at 12:02 PM Vittorio Giovara wrote: > Hey Aaron > > This allows adding AVSphericalMapping information to files > > that don't already have it. > > --- > > ffmpeg.h | 3 ++ > > ffmpeg_opt.c

[FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Add spherical_mapping command-line argument to ffmpeg. This allows adding AVSphericalMapping information to files that don't already have it. From eaa84a5f86d37e7de8bd0d6f72a308af57f3ef1d Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 2 Jun 2017 16:11:21 -0700 Subject: [PATCH

Re: [FFmpeg-devel] [PATCH] compat: LoadLibrary isn't available on UWP/WinRT

2017-06-03 Thread Aaron Levinson
patch isn't sufficient. Plus, there is no reason to #define LOAD_LIBRARY_SEARCH_SYSTEM32 if the code won't be built anyway. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: If vfwcap_indev disabled, don't do vfw32 checks; if enabled, require vfw32

2017-05-18 Thread Aaron Levinson
On 5/18/2017 9:21 AM, Hendrik Leppkes wrote: On Thu, May 18, 2017 at 3:18 PM, Michael Niedermayer wrote: On Tue, May 16, 2017 at 03:38:32PM -0700, Aaron Levinson wrote: Signed-off-by: Aaron Levinson --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] configure: If vfwcap_indev disabled, don't do vfw32 checks; if enabled, require vfw32

2017-05-16 Thread Aaron Levinson
On 5/16/2017 4:23 PM, Steven Liu wrote: 2017-05-17 6:38 GMT+08:00 Aaron Levinson : Signed-off-by: Aaron Levinson --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 7980d92..49f91ac 100755 --- a/configure +++ b/configure

[FFmpeg-devel] [PATCH] configure: If vfwcap_indev disabled, don't do vfw32 checks; if enabled, require vfw32

2017-05-16 Thread Aaron Levinson
Signed-off-by: Aaron Levinson --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 7980d92..49f91ac 100755 --- a/configure +++ b/configure @@ -6013,10 +6013,10 @@ check_header sys/videoio.h check_code cc sys/videoio.h "s

[FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: Don't improperly free IDirect3DSurface9 objects

2017-05-16 Thread Aaron Levinson
ws, it likely results in memory corruption, since av_free() is being called on memory that was allocated using IDirectXVideoAccelerationService::CreateSurface(). Signed-off-by: Aaron Levinson --- libavutil/hwcontext_dxva2.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --gi

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: No longer improperly freeing IDirect3DSurface9 objects

2017-05-16 Thread Aaron Levinson
Please disregard--I will submit a new patch with a better commit message. Aaron On 5/16/2017 4:09 AM, Aaron Levinson wrote: Purpose: No longer improperly freeing IDirect3DSurface9 objects in hwcontext_dxva2.c. Added dxva2_pool_release_dummy() and using it in call to av_buffer_create() in

[FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: No longer improperly freeing IDirect3DSurface9 objects

2017-05-16 Thread Aaron Levinson
7;t appear to result in a crash when the release version of the C-runtime is used on Windows, it likely results in memory corruption, since av_free() is being called on memory that was allocated using IDirectXVideoAccelerationService::CreateSurface(). Signed-off-by: Aaron Levinson -

Re: [FFmpeg-devel] FFMpeg GPL license Violations by Android apps

2017-05-15 Thread Aaron Levinson
t the source code that was used to build the FFmpeg binaries that were shipped with the app. Aaron Levinson On Mon, May 15, 2017 at 1:38 PM, Kieran Kunhya wrote: Hi, Out of interest, how did you automate this process? Is it as simple as looking for the FFmpeg configure string? Regards, K

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-12 Thread Aaron Levinson
On 5/12/2017 5:51 PM, Michael Niedermayer wrote: On Fri, May 12, 2017 at 01:19:43PM -0700, Aaron Levinson wrote: On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I create

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Made execution of reap_filters() more deterministic with respect to when headers are written

2017-05-12 Thread Aaron Levinson
tion to the output stream's codecpar (mux_par->field_order in do_video_out()). However, check_init_output_file() calls avformat_write_header() prior to the initial call to do_video_out(), so field_order is populated too late, and the header is written with the default field_order value,

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from init_output_stream()

2017-05-12 Thread Aaron Levinson
Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

2017-05-12 Thread Aaron Levinson
Please disregard--I messed up the subject. I'll send a new one. Aaron Levinson On 5/12/2017 1:22 PM, Aaron Levinson wrote: Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after ca

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

2017-05-12 Thread Aaron Levinson
Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-12 Thread Aaron Levinson
On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I created the first version of the patch on March 26th, this was the first patch that I submitted to ffmpeg, and some aspects

Re: [FFmpeg-devel] [PATCH] configure: jni no longer requires -ldl

2017-05-12 Thread Aaron Levinson
&& { check_header ladspa.h || die "ERROR: ladspa.h header not found"; } enabled libiec61883 && require libiec61883 libiec61883/iec61883.h iec61883_cmp_connect -lraw1394 -lavc1394 -lrom1394 -liec61883 enabled libass&& require_pkg_config libass ass/ass

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: move old_filename free operation earlier

2017-05-10 Thread Aaron Levinson
On 5/10/2017 3:33 AM, Steven Liu wrote: Suggested-by: Aaron Levinson Signed-off-by: Steven Liu --- libavformat/hlsenc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 221089c..7ed121a 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix memleak

2017-05-09 Thread Aaron Levinson
ls to av_free(old_filename). } ret = ff_write_chained(oc, stream_index, pkt, s, 0); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
handle .m3u8 files that use '\' for multi-line TAG spans, and in addition, there is no mention of '\' anywhere in the actual grammar documented in the specification. So, it seems that that this patch isn't needed. Aaron Levinson On 5/9/2017 1:01 PM, Aaron Levi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
ts #EXTINF:8.64, out1.ts #EXTINF:9.16, out2.ts Reported-by: Aaron Levinson Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 21 +++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 221089c..c1

Re: [FFmpeg-devel] [PATCH] videotoolbox: add hwcontext support

2017-05-07 Thread Aaron Levinson
Are you also planning to change ffmpeg_videotoolbox.c? See below for more comments. Aaron Levinson On 5/2/2017 8:26 PM, wm4 wrote: This adds tons of code for no other benefit than making VideoToolbox support conform with the new hwaccel API (using hw_device_ctx and hw_frames_ctx). Since

[FFmpeg-devel] [PATCH 2/2] qsvenc: Make sure the interlaced encoding works

2017-05-07 Thread Aaron Levinson
From 30eb78bac7bd92b0c085ba6873341e8319072acc Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 5 May 2017 21:31:30 -0700 Subject: [PATCH 2/2] qsvenc: Make sure the interlaced encoding works Purpose: qsvenc: make sure that interlaced encoding works. Also, reduce the vertical alignment

[FFmpeg-devel] [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters

2017-05-07 Thread Aaron Levinson
From 2882d77d76805e74fe139f6763f91c39746bebaf Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 5 May 2017 18:49:57 -0700 Subject: [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters Purpose: Fill out the default/unset parameters with ones actually in use. Note

Re: [FFmpeg-devel] [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding

2017-05-07 Thread Aaron Levinson
Please disregard this patch--I'm submitting two new patches that have already been reviewed and applied to libav. Aaron Levinson On 4/13/2017 11:36 PM, Aaron Levinson wrote: From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 20

Re: [FFmpeg-devel] [PATCH] build: remove --enable-raise-major configure option

2017-05-06 Thread Aaron Levinson
for the decoder). The third component always starts at 100 to distinguish FFmpeg from Libav." Note that my review only covers the content of the patch, and I don't know whether or not it makes sense to discontinue this practice. Aaron Levinson __

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread Aaron Levinson
On 5/5/2017 2:26 AM, wm4 wrote: On Fri, 5 May 2017 01:11:17 -0700 Aaron Levinson wrote: As I said on IRC, I'm skeptic against this, but I'm also not sure whether I understand the situation. First, your change seems a bit fragile, and almost relies on coincidences. This could easil

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 4:50 AM, Michael Niedermayer wrote: > On Fri, May 05, 2017 at 11:36:05AM +0200, Hendrik Leppkes wrote: >> On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch wrote: >>> On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: >>> [...] >>>>>

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-05 Thread Aaron Levinson
On 5/5/2017 4:57 PM, Marton Balint wrote: > > > On Fri, 5 May 2017, Aaron Levinson wrote: > >> On 4/16/2017 4:11 PM, Aaron Levinson wrote: >>> On 4/15/2017 6:13 AM, Aaron Levinson wrote: >>>> On 4/15/2017 4:19 AM, Marton Balint wrote: >>>&g

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

2017-05-05 Thread Aaron Levinson
The entire patch set LGTM. Aaron Levinson On 5/3/2017 6:41 PM, James Almer wrote: On 5/3/2017 9:39 PM, Aaron Levinson wrote: James, Can you document which patches depend on other patches in this patch set to make it easier to review this patch set in chunks? Patch 2 depends on 1. Patches 3

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:57 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: [...] Back to your issue: you should fix the .pc in the upstream project, this is the correct fix. The "upstream project" in this case is the Intel Media SDK. This is not an o

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:55 AM, wm4 wrote: On Thu, 4 May 2017 23:46:30 -0700 Aaron Levinson wrote: On 4/12/2017 6:08 PM, Aaron Levinson wrote: On 3/26/2017 10:34 AM, Aaron Levinson wrote: On 3/26/2017 4:41 AM, Matthias Hunstock wrote: Am 26.03.2017 um 11:50 schrieb Aaron Levinson

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:44 AM, Carl Eugen Hoyos wrote: 2017-05-05 9:42 GMT+02:00 Aaron Levinson : On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:42 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: On 4/19/2017 10:43 AM, Aaron Levinson wrote: On 4/14/2017 6:51 PM, Aaron Levinson wrote: From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function ‘av_timecode_make_string’: libavutil

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-05 Thread Aaron Levinson
On 4/16/2017 4:11 PM, Aaron Levinson wrote: > On 4/15/2017 6:13 AM, Aaron Levinson wrote: >> On 4/15/2017 4:19 AM, Marton Balint wrote: >>> >>> On Thu, 13 Apr 2017, Aaron Levinson wrote: >>> >>>> On 4/13/2017 1:23 PM, Hendrik Leppkes wrote: >&

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 4/19/2017 10:43 AM, Aaron Levinson wrote: > On 4/14/2017 6:51 PM, Aaron Levinson wrote: >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson >> Date: Fri, 14 Apr 2017 18:38:37 -0700 >> Subject: [PATCH] Added require fall

Re: [FFmpeg-devel] [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install

2017-05-05 Thread Aaron Levinson
On 4/14/2017 6:27 PM, Aaron Levinson wrote: From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:14:21 -0700 Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install Purpose

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-04 Thread Aaron Levinson
On 4/12/2017 6:08 PM, Aaron Levinson wrote: > On 3/26/2017 10:34 AM, Aaron Levinson wrote: >> On 3/26/2017 4:41 AM, Matthias Hunstock wrote: >>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: >>>> When using the following command to play back either file: >>

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-05-04 Thread Aaron Levinson
On 5/2/2017 2:29 PM, wm4 wrote: On Tue, 2 May 2017 14:17:33 -0700 Aaron Levinson wrote: On 5/1/2017 11:06 PM, MFojtak wrote: Currently this muxer does not work at all. I don't know if 000Z would make it compatible with more player as I don't know any. However, adding Z makes it

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-04 Thread Aaron Levinson
On 5/4/2017 9:15 PM, Steven Liu wrote: 2017-05-03 9:49 GMT+08:00 Aaron Levinson : On 4/27/2017 7:21 PM, Steven Liu wrote: 2017-04-26 7:30 GMT+08:00 Steven Liu : fix ticket id: #6353 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 24 1 file changed, 24

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-04 Thread Aaron Levinson
never use 32 characters, its not a big deal to have a little waste here. The buffer size should match the format specification. An alternative would be to use "%02hd" or "%02hhd", but doing so would require casts or using different types for hh, mm, etc. Aaron Levins

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-04 Thread Aaron Levinson
NAN); In order to preserve the original logic, why not do the following: +num = den ? num * intnum / den : (((num * intnum) != 0) ? INFINITY : NAN); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

2017-05-03 Thread Aaron Levinson
James, Can you document which patches depend on other patches in this patch set to make it easier to review this patch set in chunks? Thanks, Aaron Levinson On 5/2/2017 2:55 PM, James Almer wrote: Some changes and fixes suggested on IRC. Some patches are v3 as they have been sent before

Re: [FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-05-03 Thread Aaron Levinson
On 4/21/2017 2:03 PM, James Almer wrote: On 4/21/2017 12:09 PM, Michael Niedermayer wrote: On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote: From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 20 Apr 2017 23:20:20 -0700 Subject

[FFmpeg-devel] [PATCH] doc: Enhanced fate.texi to reference Windows line endings section from git-howto.texi

2017-05-03 Thread Aaron Levinson
From 345a98d31c6c758f0f82edab1b502cd8aeb3354b Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Wed, 3 May 2017 12:38:39 -0700 Subject: [PATCH] doc: Enhanced fate.texi to reference Windows line endings section from git-howto.texi Purpose: Enhanced fate.texi to indicate that FATE will fail if

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-05-03 Thread Aaron Levinson
On 4/22/2017 12:22 PM, Aaron Levinson wrote: On 4/22/2017 12:09 PM, Hendrik Leppkes wrote: On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson wrote: On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] This is documented in doc

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-02 Thread Aaron Levinson
I don't seem to have the original e-mail in my inbox anymore, so I'll respond to wm4's response. Overall, the new code is a lot cleaner and easier to understand than the existing code. See below for more. Aaron Levinson On 5/2/2017 5:04 PM, wm4 wrote: On Fri, 28 Apr 2017

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-02 Thread Aaron Levinson
f(hls->key_uri)). In addition, based on the EXT-X-KEY example at https://developer.apple.com/library/content/technotes/tn2288/_index.html , it would appear that an EXT-X-KEY declaration may span multiple lines. Your solution will not work properly in this case. Aaron Levinson +

Re: [FFmpeg-devel] [PATCH]configure: Fix libopus detection

2017-05-02 Thread Aaron Levinson
currently taken in configure doesn't distinguish between encoding and decoding, but the patch as originally proposed just trades decoding API requirements for encoding API requirements. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

  1   2   3   >