Re: [FFmpeg-devel] [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2nv12cX_c() [v2]

2025-06-11 Thread Harshitha Sarangu Suresh
Hi, Can you please review the patch? Thanks. Get Outlook for Android From: Harshitha Sarangu Suresh Sent: Monday, June 9, 2025 8:41:39 PM To: FFmpeg development discussions and patches Cc: Dash Santosh Sathyanarayanan ; Logaprakash Ramajay

Re: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not return early

2025-06-11 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 22:42 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not > return early > > This would make the goto dead code and also would not properly

Re: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop free

2025-06-11 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 22:42 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop > free > > The tctx->hash was freed already right before. > --- > fftools/te

Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes

2025-06-11 Thread softworkz .
Hi Marvin, > -Original Message- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 22:42 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow > variable scopes > > --- > fftools/textformat/avtextformat.c | 15 +

Re: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in mermaid_print_value

2025-06-11 Thread softworkz .
Hi Marvin, > -Original Message- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 21:57 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in > mermaid_print_value > > Instead of the caller having to indicate

Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid

2025-06-11 Thread softworkz .
Hi Marvin, > -Original Message- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 21:57 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing > integers for mermaid > > With the previous logic, the integer writ

Re: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in mermaid_print_value

2025-06-11 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 21:57 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in > mermaid_print_value > > Doesn't change the logic, instead of exiting in e

Re: [FFmpeg-devel] [PATCH 3/3] fate/video: Add media100 test

2025-06-11 Thread compn
On Wed, 11 Jun 2025 18:51:58 +0200, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Patches attached. > > > > - Andreas > > > > And here is a test. The file for the test is at > https://0x0.st/8E1C.mov/media100.mov and should be put into the mjpegb > directory. > > - Andreas thanks. add

Re: [FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_d3d12va: added resource Flags support to command line

2025-06-11 Thread Dmitrii Ovchinnikov
>> We should set these flags in d3d12va_frames_init >> instead of referencing device->flags directly Sorry, I didn't fully understand this part. Is it actually possible to pass the required flags to the frames context without using the device context? Or perhaps you meant something like this: 1)

[FFmpeg-devel] [PATCH] acvodec/amfenc: Enable use of AMF Surface in multiple encoders

2025-06-11 Thread Dmitrii Ovchinnikov
Fixes the behavior of AMF encoders when the same AMF surface is passed to multiple encoder objects. for example when using -filter_complex --- libavcodec/amfenc.c | 453 -- libavcodec/amfenc.h | 2 + libavutil/hwcontext_amf.h | 3 +- 3 files chan

Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph wrapper script in build output

2025-06-11 Thread softworkz .
> -Original Message- > From: Kieran Kunhya > Sent: Mittwoch, 11. Juni 2025 23:14 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include > show-graph wrapper script in build output > > On Wed, Jun 11, 2025 at

Re: [FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

2025-06-11 Thread Martin Storsjö
On Wed, 11 Jun 2025, Kacper Michajlow wrote: On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: Fixes use of bultins on clang x86_64-pc-windows-msvc which does not define any __GNUC__. Also on other targets __GNUC__ is defined to 4 by default, so any feature testing based on version is not

Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph wrapper script in build output

2025-06-11 Thread softworkz .
> -Original Message- > From: Kieran Kunhya > Sent: Mittwoch, 11. Juni 2025 23:14 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include > show-graph wrapper script in build output > > On Wed, Jun 11, 2025 at

Re: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in mermaid_print_value

2025-06-11 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 21:57 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in > mermaid_print_value > > Instead of the caller having to indicate if it is

Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph wrapper script in build output

2025-06-11 Thread Kieran Kunhya via ffmpeg-devel
--- Begin Message --- On Wed, Jun 11, 2025 at 9:58 PM softworkz . wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Marton Balint > > Sent: Mittwoch, 11. Juni 2025 21:18 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFm

Re: [FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove useless error check

2025-06-11 Thread Marvin Scholz
On 11 Jun 2025, at 22:53, Andreas Rheinhardt wrote: > Marvin Scholz: >> This can never be reached as the errors are already handled >> locally when they occur in the code preceding this. >> --- >> fftools/textformat/avtextformat.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/ff

Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph wrapper script in build output

2025-06-11 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Mittwoch, 11. Juni 2025 21:18 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include > show-graph wrapper script in build output

Re: [FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove useless error check

2025-06-11 Thread Andreas Rheinhardt
Marvin Scholz: > This can never be reached as the errors are already handled > locally when they occur in the code preceding this. > --- > fftools/textformat/avtextformat.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fftools/textformat/avtextformat.c > b/fftools/textformat/avtextfo

[FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not return early

2025-06-11 Thread Marvin Scholz
This would make the goto dead code and also would not properly call avtext_context_close. Fix CID 1646939 --- fftools/textformat/avtextformat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index fa5abce261..e1aaa9ba57 10

[FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove useless error check

2025-06-11 Thread Marvin Scholz
This can never be reached as the errors are already handled locally when they occur in the code preceding this. --- fftools/textformat/avtextformat.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index e1aaa9ba57..6a309f

[FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop free

2025-06-11 Thread Marvin Scholz
The tctx->hash was freed already right before. --- fftools/textformat/avtextformat.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index f1811abb1c..fa5abce261 100644 --- a/fftools/textformat/avtextformat.c +++ b/fftools

[FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes

2025-06-11 Thread Marvin Scholz
--- fftools/textformat/avtextformat.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index 14779e6f0c..f1811abb1c 100644 --- a/fftools/textformat/avtextformat.c +++ b/fftools/textformat/avte

[FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid

2025-06-11 Thread Marvin Scholz
With the previous logic, the integer writing codepath was unreachable. Fix CID 1646948 --- fftools/textformat/tf_mermaid.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c index d3b9131ada..

[FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in mermaid_print_value

2025-06-11 Thread Marvin Scholz
Instead of the caller having to indicate if it is passing an integer, just use the fact that str is NULL when an integer is to be printed. --- fftools/textformat/tf_mermaid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fftools/textformat/tf_mermaid.c b/fftools/

[FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in mermaid_print_value

2025-06-11 Thread Marvin Scholz
Doesn't change the logic, instead of exiting in each of the two branches below, just exit before. --- fftools/textformat/tf_mermaid.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c index 59b11811f1

[FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove leftover comments in mermaid_print_value

2025-06-11 Thread Marvin Scholz
Remove some leftover commented code and an extraneous semicolon. --- fftools/textformat/tf_mermaid.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c index da371c8fff..9d98b6a36f 100644 --- a/fftools/textforma

Re: [FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

2025-06-11 Thread Kacper Michajlow
On Wed, 11 Jun 2025 at 20:45, Martin Storsjö wrote: > > On Wed, 11 Jun 2025, Kacper Michajlow wrote: > > > On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > >> > >> Fixes use of bultins on clang x86_64-pc-windows-msvc which does not > >> define any __GNUC__. Also on other targets __GNUC__ i

Re: [FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

2025-06-11 Thread Kacper Michajlow
On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > > Fixes use of bultins on clang x86_64-pc-windows-msvc which does not > define any __GNUC__. Also on other targets __GNUC__ is defined to 4 by > default, so any feature testing based on version is not really valid. > > Signed-off-by: Kacper M

[FFmpeg-devel] [PATCH] avcodec/vvc: parse all SEI messages

2025-06-11 Thread Marvin Scholz
While the current code iterated over the messages, it always returned in the first iteration. Instead keep iterating and warn for failure to parse. At time of writing, none of the parsing functions seems to actually return an error, ever. Fix CID 1648348 --- libavcodec/vvc/sei.c | 29

Re: [FFmpeg-devel] [PATCH v6 00/18] swscale: new ops framework

2025-06-11 Thread Niklas Haas
On Wed, 11 Jun 2025 14:47:06 +0200 Niklas Haas wrote: > Changes since v5: > - fix one compilation failure on MSVC > - remove av_dynarray2_dup() again I fixed two more MSVC build failures locally. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

2025-06-11 Thread Kacper Michajlow
On Wed, 11 Jun 2025 at 20:51, Kacper Michajlow wrote: > > On Wed, 11 Jun 2025 at 20:45, Martin Storsjö wrote: > > > > On Wed, 11 Jun 2025, Kacper Michajlow wrote: > > > > > On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > > >> > > >> Fixes use of bultins on clang x86_64-pc-windows-msvc wh

Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph wrapper script in build output

2025-06-11 Thread Marton Balint
On Mon, 9 Jun 2025, softworkz wrote: From: softworkz Signed-off-by: softworkz --- .gitignore | 1 + fftools/Makefile | 14 -- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 59c89da5e0..989c702b6c 100644 --- a/.gitignore +++ b/

[FFmpeg-devel] [PATCH 3/3] fate/video: Add media100 test

2025-06-11 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Patches attached. > > - Andreas > And here is a test. The file for the test is at https://0x0.st/8E1C.mov/media100.mov and should be put into the mjpegb directory. - Andreas From 349fd65df1d681360bebf97f57b16098641c3a7f Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Da

Re: [FFmpeg-devel] [PATCH 2/2] avformat/internal: add missing __clang__ check

2025-06-11 Thread Kacper Michajlow
On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > > Clang x86_64-pc-windows-msvc doesn't define __GNUC__. > > Signed-off-by: Kacper Michajłow > --- > libavformat/internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/internal.h b/libavformat/interna

[FFmpeg-devel] [PATCH] avcodec/vvc/dec: fix possible null-pointer dereference

2025-06-11 Thread Marvin Scholz
When checking for filmgrain here, needs_fg can be true even when film_grain_characteristics is NULL (when aom_film_grain.enable is true), therefore this check could end up dereferencing film_grain_characteristics even though it is NULL. Fix CID 1648347 --- libavcodec/vvc/dec.c | 3 ++- 1 file cha

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/decode: Fix avcodec parameters when bsfs, are enable by decoder"

2025-06-11 Thread Andreas Rheinhardt
Zhao Zhili: >> Otherwise the extradata used would be ISOBMFF if the input is >> even though we use the *_mp4toannexb BSFs to convert it to >> annex B to feed it to the actual decoder. >> >> (The mediacodec decoders also use said BSFs, yet they process >> the extradata in a way that works even when

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/decode: Fix avcodec parameters when bsfs, are enable by decoder"

2025-06-11 Thread Zhao Zhili
> Otherwise the extradata used would be ISOBMFF if the input is > even though we use the *_mp4toannexb BSFs to convert it to > annex B to feed it to the actual decoder. > > (The mediacodec decoders also use said BSFs, yet they process > the extradata in a way that works even when using the ISOBMFF

Re: [FFmpeg-devel] [PATCH] avformat/demux: Fix segfault due to avcodec_open2 failure (v2)

2025-06-11 Thread Michael Niedermayer
Hi Pavel On Tue, Jun 10, 2025 at 05:36:14PM -0600, Pavel Koshevoy wrote: > On Tue, Jun 10, 2025 at 4:11 PM Michael Niedermayer > wrote: > > > Hi Pavel > > > > On Tue, Jun 10, 2025 at 11:27:37AM -0600, Pavel Koshevoy wrote: > > > On Tue, Jun 10, 2025 at 9:29 AM Michael Niedermayer < > > mich...@n

[FFmpeg-devel] [PATCH 1/2] Revert "avcodec/decode: Fix avcodec parameters when bsfs, are enable by decoder"

2025-06-11 Thread Andreas Rheinhardt
Patches attached. - Andreas From 16581fd7fa6b45e69bb8c2d305739cb60bb798e6 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 11 Jun 2025 14:52:47 +0200 Subject: [PATCH 1/2] Revert "avcodec/decode: Fix avcodec parameters when bsfs are enable by decoder" This reverts commit 1c170613975d

Re: [FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: G.728 muxing and demuxing

2025-06-11 Thread compn
On Tue, 10 Jun 2025 10:29:40 +1000, Peter Ross wrote: > The aiff patch is based on sample here: > https://www.mmsp.ece.mcgill.ca/Documents/AudioFormats/AIFF/Samples.html > Search for G.728. I am unsure what software was used to create that sample. i grabbed the samples from that spec page ( ftp:/

Re: [FFmpeg-devel] [PATCH 0/3] tools/ffmpeg-sg: Add show-graph wrapper scripts (aka killer feature)

2025-06-11 Thread Nicolas George
Kieran Kunhya via ffmpeg-devel (HE12025-06-09): > Why does this need to be part of FFmpeg Please, not this nonsense again. Why is ffeval part of FFmpeg? Why is graph2dot part of FFmpeg? Because they are useful for users, and so is this. softworkz is finally doing the right thing instead of throwi

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Passthrough SCTE 35 Current behavior breaks SCTE 35 by wrapping it in a PES packet, this adds the logic for the SCTE 35 messages to be passed through cleanl

2025-06-11 Thread Devin Heitmueller
Hello Pierre, On Wed, Jun 11, 2025 at 10:22 AM Pierre Le Fevre via ffmpeg-devel wrote: > -- Forwarded message -- > From: Pierre Le Fevre > To: "ffmpeg-devel@ffmpeg.org" > Cc: > Bcc: > Date: Wed, 11 Jun 2025 14:22:29 + > Subject: [PATCH] avformat/mpegts: Passthrough SCTE 35 C

Re: [FFmpeg-devel] [PATCH 2/2] tests: Add media100 decoder test

2025-06-11 Thread compn
On Wed, 11 Jun 2025 04:17:55 -1000, compn wrote: > On Tue, 10 Jun 2025 23:56:43 +0800, Zhao Zhili wrote: > > > From: Zhao Zhili > > > > --- > > The sample comes from > > https://trac.ffmpeg.org/attachment/ticket/959/12%2027_Volcano%20Zoom-Dissolve-F-8.mov > > put it to mjpegb/media100.mov >

[FFmpeg-devel] [PATCH] avformat/mpegts: Passthrough SCTE 35 Current behavior breaks SCTE 35 by wrapping it in a PES packet, this adds the logic for the SCTE 35 messages to be passed through cleanly.

2025-06-11 Thread Pierre Le Fevre via ffmpeg-devel
--- Begin Message --- Signed-off-by: Pierre Le Fevre --- libavformat/mpegtsenc.c | 27 +++ libavformat/mux.c | 6 -- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 6935b71cfe..ba28e17696 10

Re: [FFmpeg-devel] [PATCH 2/2] tests: Add media100 decoder test

2025-06-11 Thread compn
On Tue, 10 Jun 2025 23:56:43 +0800, Zhao Zhili wrote: > From: Zhao Zhili > > --- > The sample comes from > https://trac.ffmpeg.org/attachment/ticket/959/12%2027_Volcano%20Zoom-Dissolve-F-8.mov > put it to mjpegb/media100.mov that specific sample has been in samples repo for a while: https://sa

[FFmpeg-devel] [PATCH v6 01/18] swscale/graph: pass per-pass image pointers to setup()

2025-06-11 Thread Niklas Haas
From: Niklas Haas This behavior had no real justification and was just incredibly confusing, since the in/out pointers passet to setup() did not match those passed to run(), all for what is arguably an exception anyways (the palette setup). --- libswscale/graph.c | 10 +++--- libswscale/grap

[FFmpeg-devel] [PATCH v6 14/18] swscale/ops_memcpy: add 'memcpy' backend for plane->plane copies

2025-06-11 Thread Niklas Haas
From: Niklas Haas Provides a generic fast path for any operation list that can be decomposed into a series of memcpy and memset operations. 25% faster than the x86 backend for yuv444p -> yuva444p 33% faster than the x86 backend for gray -> yuvj444p --- libswscale/Makefile | 1 + libswscal

Re: [FFmpeg-devel] [PATCH] avfilter/vf_perspective: factor the interpolation code out so that it's usable by other filters

2025-06-11 Thread Nicolas George
Quentin RENARD (HE12025-06-11): > As mentioned here > (https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344593.html), > this is the first step of a 2 steps patch: move the interpolation code > out of the vf_perspective filter so that we can use it in the zoompan > filter and apply scale/crop flo

[FFmpeg-devel] [PATCH v6 03/18] swscale/format: add ff_fmt_clear()

2025-06-11 Thread Niklas Haas
From: Niklas Haas Reset an SwsFormat to its fully unset/invalid state. --- libswscale/format.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libswscale/format.h b/libswscale/format.h index 3b6d745159..be92038f4f 100644 --- a/libswscale/format.h +++ b/libswscale/format.h @@

[FFmpeg-devel] [PATCH v6 18/18] swscale/graph: allow experimental use of new format handler

2025-06-11 Thread Niklas Haas
From: Niklas Haas Now, make it a Killer-Feature! --- libswscale/graph.c | 84 -- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/libswscale/graph.c b/libswscale/graph.c index 2b26c068d1..ff3977c9a6 100644 --- a/libswscale/graph.c +++ b/l

[FFmpeg-devel] [PATCH] avfilter/vf_perspective: factor the interpolation code out so that it's usable by other filters

2025-06-11 Thread Quentin RENARD
As mentioned here (https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344593.html), this is the first step of a 2 steps patch: move the interpolation code out of the vf_perspective filter so that we can use it in the zoompan filter and apply scale/crop floating point precision there. I've mov

[FFmpeg-devel] [PATCH v6 09/18] swscale/ops_internal: add internal ops backend API

2025-06-11 Thread Niklas Haas
From: Niklas Haas This adds an internal API for ops backends, which are responsible for compiling op lists into executable functions. --- libswscale/ops.c | 65 +++ libswscale/ops_internal.h | 108 ++ 2 files changed, 173 insertio

[FFmpeg-devel] [PATCH v6 10/18] swscale/ops: add dispatch layer

2025-06-11 Thread Niklas Haas
From: Niklas Haas This handles the low-level execution of an op list, and integration into the SwsGraph infrastructure. To handle frames with insufficient padding in the stride (or a width smaller than one block size), we use a fallback loop that pads the last column of pixels using `memcpy` into

[FFmpeg-devel] [PATCH v6 08/18] swscale/optimizer: add high-level ops optimizer

2025-06-11 Thread Niklas Haas
From: Niklas Haas This is responsible for taking a "naive" ops list and optimizing it as much as possible. Also includes a small analyzer that generates component metadata for use by the optimizer. --- libswscale/Makefile| 1 + libswscale/ops.h | 12 + libswscale/ops_optimiz

[FFmpeg-devel] [PATCH v6 06/18] swscale: add SWS_UNSTABLE flag

2025-06-11 Thread Niklas Haas
From: Niklas Haas Give users and developers a way to opt in to the new format conversion code, and more code from the swscale rewrite in general, even while development is still ongoing. --- doc/APIchanges | 3 +++ doc/scaler.texi | 4 libswscale/options.c | 1 + libswscale/swsca

[FFmpeg-devel] [PATCH v6 07/18] swscale/ops: introduce new low level framework

2025-06-11 Thread Niklas Haas
From: Niklas Haas See docs/swscale-v2.txt for an in-depth introduction to the new approach. This commit merely introduces the ops definitions and boilerplate functions. The subsequent commits will flesh out the underlying implementation. --- libswscale/Makefile | 1 + libswscale/ops.c| 52

[FFmpeg-devel] [PATCH v6 05/18] tests/checkasm: generalize DEF_CHECKASM_CHECK_FUNC to floats

2025-06-11 Thread Niklas Haas
From: Niklas Haas We split the standard macro into its body (implementation) and declaration, and use a macro argument in place of the raw `memcmp` call, with the major difference that we now take the number of pixels to compare instead of the number of bytes (to match the signature of float_near

[FFmpeg-devel] [PATCH v6 17/18] swscale/format: add new format decode/encode logic

2025-06-11 Thread Niklas Haas
From: Niklas Haas This patch adds format handling code for the new operations. This entails fully decoding a format to standardized RGB, and the inverse. Handling it this way means we can always guarantee that a conversion path exists from A to B without having to explicitly cover logic for each

[FFmpeg-devel] [PATCH v6 16/18] tests/checkasm: add checkasm tests for swscale ops

2025-06-11 Thread Niklas Haas
From: Niklas Haas Because of the lack of an external ABI on low-level kernels, we cannot directly test internal functions. Instead, we construct a minimal op chain consisting of a read, the op to be tested, and a write. The bigger complication arises from the fact that the backend may generate a

[FFmpeg-devel] [PATCH v6 15/18] swscale/x86: add SIMD backend

2025-06-11 Thread Niklas Haas
From: Niklas Haas This covers most 8-bit and 16-bit ops, and some 32-bit ops. It also covers all floating point operations. While this is not yet 100% coverage, it's good enough for the vast majority of formats out there. Of special note is the packed shuffle fast path, which uses pshufb at vect

[FFmpeg-devel] [PATCH v6 13/18] swscale/ops_backend: add reference backend basend on C templates

2025-06-11 Thread Niklas Haas
From: Niklas Haas This will serve as a reference for the SIMD backends to come. That said, with auto-vectorization enabled, the performance of this is not atrocious. It easily beats the old C code and sometimes even the old SIMD. In theory, we can dramatically speed it up by using GCC vectors in

[FFmpeg-devel] [PATCH v6 12/18] swscale/ops_chain: add internal abstraction for kernel linking

2025-06-11 Thread Niklas Haas
From: Niklas Haas See doc/swscale-v2.txt for design details. --- libswscale/Makefile| 1 + libswscale/ops_chain.c | 291 + libswscale/ops_chain.h | 134 +++ 3 files changed, 426 insertions(+) create mode 100644 libswscale/ops_chain.c

[FFmpeg-devel] [PATCH v6 11/18] swscale/optimizer: add packed shuffle solver

2025-06-11 Thread Niklas Haas
From: Niklas Haas This can turn any compatible sequence of operations into a single packed shuffle, including packed swizzling, grayscale->RGB conversion, endianness swapping, RGB bit depth conversions, rgb24->rgb0 alpha clearing and more. --- libswscale/ops_internal.h | 28 +++ libswsc

[FFmpeg-devel] [PATCH v6 04/18] tests/checkasm: increase number of runs in between measurements

2025-06-11 Thread Niklas Haas
From: Niklas Haas Sometimes, when measuring very small functions, rdtsc is not accurate enough to get a reliable measurement. This increases the number of runs inside the inner loop from 4 to 32, which should help a lot. Less important when using the more precise linux-perf API, but still useful.

[FFmpeg-devel] [PATCH v6 02/18] swscale/format: rename legacy format conversion table

2025-06-11 Thread Niklas Haas
From: Niklas Haas --- libswscale/format.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libswscale/format.c b/libswscale/format.c index e4c1348b90..b77081dd7a 100644 --- a/libswscale/format.c +++ b/libswscale/format.c @@ -24,14 +24,14 @@ #include "form

[FFmpeg-devel] [PATCH v6 00/18] swscale: new ops framework

2025-06-11 Thread Niklas Haas
Changes since v5: - fix one compilation failure on MSVC - remove av_dynarray2_dup() again ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ

[FFmpeg-devel] [RFC 0/1] avfilter/f_sendcmd: add format expressions

2025-06-11 Thread Ignacy Gawędzki
Hi, I'd like to submit the following patch adding a feature that I was missing and decided to try to implement myself. The problem I had was that although the parameters of the lutyuv filter are all commands, there was no way to use sendcmd to generate the expressions for the parameters using tim

[FFmpeg-devel] [RFC 1/1] avfilter/f_sendcmd: add format expressions

2025-06-11 Thread Ignacy Gawędzki
Add support for a "format" flag (exclusive with "expr") which indicates that the argument is a format string followed by expressions to be evaluated and formatted and the result sent as a string. Only simple 'f' format is supported as expressions are evaluated to double. Signed-off-by: Ignacy Gaw

Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format)

2025-06-11 Thread Zhao Zhili
> On Jun 11, 2025, at 18:50, Dawid Kozinski wrote: > > Signed-off-by: Dawid Kozinski > --- > libavcodec/liboapvenc.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c > index 0c95489bc9..d338b33e2d 100644 > --- a/libavcode

[FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format)

2025-06-11 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- libavcodec/liboapvenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c index 0c95489bc9..d338b33e2d 100644 --- a/libavcodec/liboapvenc.c +++ b/libavcodec/liboapvenc.c @@ -307,6 +307,18 @@ static

Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format)

2025-06-11 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: piątek, 9 maja 2025 17:11 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV > encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE > format (the

[FFmpeg-devel] [PATCH v1] avcodec/apv_codec: Update liboapv version requirement in configure script

2025-06-11 Thread Dawid Kozinski
Changed the minimum required version of liboapv from 0.1.13 to 0.1.13.1 Signed-off-by: Dawid Kozinski --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 534b443f7d..22f5ca738b 100755 --- a/configure +++ b/configure @@ -6949,7 +6949,7 @@

Re: [FFmpeg-devel] [PATCH] avformat/demux: Fix segfault due to avcodec_open2 failure (v2)

2025-06-11 Thread Michael Niedermayer
Hi Pavel On Tue, Jun 10, 2025 at 05:36:14PM -0600, Pavel Koshevoy wrote: > On Tue, Jun 10, 2025 at 4:11 PM Michael Niedermayer > wrote: > > > Hi Pavel > > > > On Tue, Jun 10, 2025 at 11:27:37AM -0600, Pavel Koshevoy wrote: > > > On Tue, Jun 10, 2025 at 9:29 AM Michael Niedermayer < > > mich...@n