Re: [FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when initializing graphprint

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Sonntag, 1. Juni 2025 05:27 > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when > initializing graphprint > > Patches attac

[FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when initializing graphprint

2025-05-31 Thread Andreas Rheinhardt
Patches attached. - Andreas From f33af4ef4913f37458b89f19ec7fb71ae4b39978 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Fri, 30 May 2025 16:02:08 +0200 Subject: [PATCH 01/11] fftools/graph/graphprint: Fix races when initializing graphprint Setting print_graphs_format (in case no -prin

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of softworkz . > Sent: Samstag, 31. Mai 2025 22:09 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] The "bad" Patch > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Leo Izen >

Re: [FFmpeg-devel] [PATCH v5 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-05-31 Thread Emma Worley
On Fri, May 30, 2025 at 12:19 PM Michael Niedermayer wrote: > > Hi Emma > > On Wed, May 28, 2025 at 03:35:29PM -0700, Emma Worley wrote: > > I successfully used this patch series to encode DXV files for a couple > > live events this past weekend and did not encounter any decoding > > issues with R

[FFmpeg-devel] 回复: [PATCH v2 10/20] avcodec/h274: add ff_h274_hash functions

2025-05-31 Thread Wu Jianhua
Andreas Rheinhardt : > toq...@gmail.com: >> From: Wu Jianhua >> >> Signed-off-by: Wu Jianhua >> --- >> libavcodec/h274.c | 155 ++ >> libavcodec/h274.h | 7 +++ >> 2 files changed, 162 insertions(+) >> >> diff --git a/libavcodec/h274.c b/libavcodec/h

Re: [FFmpeg-devel] Graphprint Patches Overview

2025-05-31 Thread softworkz .
> > A patchset so bad, people who quit the project like Derek came back to clean > up your mess. > > Kieran  For background and aftermath, please read: The "bad" Patch https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-May/344274.html sw ___ ffmpe

Re: [FFmpeg-devel] Graphprint Patches Overview

2025-05-31 Thread softworkz .
> I really wonder how you can't be embarrassed sending what imo is the > worst patchset in the history of the project. > Instead of acknowledging that, it's deflecting and playing the victim > you want to do. > > Kieran For background and aftermath, please read: The "bad" Patch https://lists.f

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature!

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of James Almer > Sent: Freitag, 16. Mai 2025 00:00 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a > Killer-Feature! > >> > >> Absolutely not, wtf. Calling an external app

Re: [FFmpeg-devel] Graphprint Patches Overview

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Donnerstag, 22. Mai 2025 10:50 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Graphprint Patches Overview > > Kieran Kunhya via ffmpeg-devel (HE12025-05-22): > > It's obvious b

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature!

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Freitag, 16. Mai 2025 14:04 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a > Killer-Feature! > > Michael Niedermayer (HE12

[FFmpeg-devel] [PATCH] lavc/vvc: Fix unchecked return code and shadowing

2025-05-31 Thread Frank Plowman
Signed-off-by: Frank Plowman --- libavcodec/vvc/dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index deb1b07b23..ac3f453440 100644 --- a/libavcodec/vvc/dec.c +++ b/libavcodec/vvc/dec.c @@ -1160,7 +1160,7 @@ fail: stat

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Leo Izen > Sent: Samstag, 31. Mai 2025 21:31 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] The "bad" Patch > > > On 5/28/25 11:24, softworkz . wrote: > > Hello everybody, > > > > it's about 14 days ago, on Thursday,

Re: [FFmpeg-devel] [PATCH v2 10/20] avcodec/h274: add ff_h274_hash functions

2025-05-31 Thread Andreas Rheinhardt
toq...@gmail.com: > From: Wu Jianhua > > Signed-off-by: Wu Jianhua > --- > libavcodec/h274.c | 155 ++ > libavcodec/h274.h | 7 +++ > 2 files changed, 162 insertions(+) > > diff --git a/libavcodec/h274.c b/libavcodec/h274.c > index 5709200322..e469

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread Mark Thompson
On 31/05/2025 19:28, softworkz . wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of Mark >> Thompson >> Sent: Samstag, 31. Mai 2025 18:21 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] The "bad" Patch >> >> On 31/05/2025 12:44, softworkz . wrote: -Origi

Re: [FFmpeg-devel] [PATCH v8 4/5] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-05-31 Thread Andreas Rheinhardt
Romain Beauxis: > Le ven. 30 mai 2025 à 19:44, Andreas Rheinhardt > a écrit : >> >> Romain Beauxis: >>> --- >>> libavcodec/vorbis_parser.h | 11 >>> libavcodec/vorbisdec.c | 75 +- >>> libavformat/oggparsevorbis.c | 67 +++

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread Marvin Scholz
On 31 May 2025, at 21:31, Leo Izen wrote: > On 5/28/25 11:24, softworkz . wrote: >> Hello everybody, >> >> it's about 14 days ago, on Thursday, 2025-05-15, when I had applied >> my "Execution Graph Printing" patchset after 12 revisions and 3 >> reminder e-mails sent to the ML. > > Please, as a

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread Leo Izen
On 5/28/25 11:24, softworkz . wrote: Hello everybody, it's about 14 days ago, on Thursday, 2025-05-15, when I had applied my "Execution Graph Printing" patchset after 12 revisions and 3 reminder e-mails sent to the ML. Please, as a bystander here who was not involved in the review or the di

Re: [FFmpeg-devel] [PATCH v8 4/5] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-05-31 Thread Romain Beauxis
Le ven. 30 mai 2025 à 19:44, Andreas Rheinhardt a écrit : > > Romain Beauxis: > > --- > > libavcodec/vorbis_parser.h | 11 > > libavcodec/vorbisdec.c | 75 +- > > libavformat/oggparsevorbis.c | 67 ++- > >

Re: [FFmpeg-devel] [PATCH v8 1/5] Add FATE test for sample from track ticket #2739

2025-05-31 Thread Romain Beauxis
Le ven. 30 mai 2025 à 15:07, Michael Niedermayer a écrit : > > Hi > > On Mon, May 26, 2025 at 05:28:50PM -0500, Romain Beauxis wrote: > > Le lun. 26 mai 2025 à 13:38, Michael Niedermayer a > > écrit : > > > > > > On Sat, May 24, 2025 at 01:14:04PM -0500, Romain Beauxis wrote: > > > > Sample avail

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread Kieran Kunhya via ffmpeg-devel
> > Let's get to the cast of the final chapter: > > - Lynne > - Nicolas George > - Kieran Kunyar > > The fact all of us (who normally disagree on various technical topics) agree about the deficiencies of your patch speaks volumes. Kieran > ___ ffmpeg-de

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 31. Mai 2025 18:21 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] The "bad" Patch > > On 31/05/2025 12:44, softworkz . wrote: > >> -Original Message- > >> From: ffmpeg-devel On Be

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix decoding fragmented MP4 with multiple sample entries and empty stsc

2025-05-31 Thread Dimitry Andric
On 9 May 2025, at 00:15, James Almer wrote: > > On 5/8/2025 7:14 PM, Dimitry Andric wrote: >> On 28 Apr 2025, at 13:00, Dimitry Andric >> wrote: >>> >>> On 19 Apr 2025, at 16:27, Dimitry Andric >>> wrote: On 10 Apr 2025, at 11:03, Dimitry Andric wrote: > > On 3 Apr

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-05-31 Thread Zhao Zhili
> On Jun 1, 2025, at 01:40, Marton Balint wrote: > > > On Sat, 31 May 2025, Michael Niedermayer wrote: > >> This allows adjusting them to exactly match whatever is fastest on >> a given CPU for each type. > > Did you use some tool to make this patch, or it was just manual work? > > Can't y

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-05-31 Thread Marton Balint
On Sat, 31 May 2025, Michael Niedermayer wrote: This allows adjusting them to exactly match whatever is fastest on a given CPU for each type. Did you use some tool to make this patch, or it was just manual work? Can't you use C11 generics to make this somewhat automatic? And if we are int

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread softworkz .
CONCLUSIONS === Meanwhile it should have become clear that this conversation is not about whether the 15/15 patchset gets or should have gotten included or not. It's about the things that happened around it and how they happened: => False statements like I would have pushed without addres

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread softworkz .
(this is the 2nd last message) Final Chapter = Some people here don't like me - that's okay. I'm honest, direct, I say what I'm thinking, often not very diplomatic, and I know which results it causes sometimes. But that a few people kind-of tried campaigning against me - even ne

[FFmpeg-devel] [PATCH v2] MAINTAINERS: Add myself as vvc maintainer

2025-05-31 Thread Frank Plowman
My OpenPGP key is available at https://keys.openpgp.org/vks/v1/by-fingerprint/34E248D6B7DF476970C7330403A84C6A098F2C6B and https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x34e248d6b7df476970c7330403a84c6a098f2c6b Signed-off-by: Frank Plowman --- Changes since v1: * Add my OpenPGP key ---

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread Mark Thompson
On 31/05/2025 12:44, softworkz . wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of softworkz . >> Sent: Donnerstag, 29. Mai 2025 04:59 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] The "bad" Patch > > > Two and a half days have passed and

[FFmpeg-devel] [PATCH] avfilter: add vf_yazf filter

2025-05-31 Thread Quentin RENARD
zoompan filter with floating point precision Signed-off-by: Quentin Renard --- Changelog    |   1 + doc/filters.texi |  59 +++ libavfilter/Makefile |   1 + libavfilter/allfilters.c |   1 + libavfilter/vf_yazf.c    | 360 +++

Re: [FFmpeg-devel] gcc: Remove auto-vectorization limitation.

2025-05-31 Thread Michael Niedermayer
Hi Remi On Fri, May 30, 2025 at 09:58:48AM +0300, Rémi Denis-Courmont wrote: > > > Le 30 mai 2025 03:46:05 GMT+03:00, Michael Niedermayer > a écrit : > >On Mon, May 26, 2025 at 11:43:15AM +0300, Rémi Denis-Courmont wrote: > >> > >> > >> Le 26 mai 2025 00:37:08 GMT+03:00, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] Revert "ogg/vorbis: implement header packet skip in chained ogg bitstreams."

2025-05-31 Thread Michael Niedermayer
On Fri, May 30, 2025 at 10:19:37PM -0300, James Almer wrote: > On 5/30/2025 10:17 PM, Michael Niedermayer wrote: > > Hi > > > > On Sat, May 31, 2025 at 02:45:30AM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > non flat extradata is problematic and was missed by reviewers > > >

[FFmpeg-devel] [PATCH 2/2] avutil/opt: round min/max in integer context

2025-05-31 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/opt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 7a84a18bb59..cc4832daeee 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -607,8 +607,8 @@ static int set_string_fmt(void

Re: [FFmpeg-devel] [PATCH 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Dmitriy Kovalenko
> On May 31, 2025, at 14:13, Martin Storsjö wrote: > > On Sat, 31 May 2025, Dmitriy Kovalenko wrote: > >> Correct. I meant dual issue >> https://developer.arm.com/documentation/ddi0460/d/Cycle-Timings-and-Interlock-Behavior/Dual-issue > > Do not top post. > > // Martin > > ___

Re: [FFmpeg-devel] [PATCH 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Martin Storsjö
On Sat, 31 May 2025, Dmitriy Kovalenko wrote: Correct. I meant dual issue https://developer.arm.com/documentation/ddi0460/d/Cycle-Timings-and-Interlock-Behavior/Dual-issue Do not top post. // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of softworkz . > Sent: Donnerstag, 29. Mai 2025 04:59 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] The "bad" Patch Two and a half days have passed and nobody has answered any of the questions from my p

Re: [FFmpeg-devel] [PATCH v4 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Dmitriy Kovalenko
I’m sorry for being slightly out of the process with my emails. I used the send-email and just thought it will be either to annotate the patches using cover letter but it seems like it is doing something weird with the messages. > by not allowing one to insert text into the middle of the quoted

Re: [FFmpeg-devel] [PATCH v4 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Christopher Snowhill
On Sat May 31, 2025 at 3:03 AM PDT, Martin Storsjö wrote: > On Sat, 31 May 2025, Dmitriy Kovalenko wrote: > >> Great. I send another version with the reverted change for the asr >> register change. What is the correct process to reply for the inline >> changes then? Inline email answer or cover l

Re: [FFmpeg-devel] [PATCH 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Dmitriy Kovalenko
Correct. I meant dual issue https://developer.arm.com/documentation/ddi0460/d/Cycle-Timings-and-Interlock-Behavior/Dual-issue Best regards, Dmitriy Kovalenko On May 31, 2025, at 12:32, Kieran Kunhya wrote:  On Sat, 31 May 2025, 10:17 Dmitriy Kovalenko, mailto:dmtr.kovale...@outlook.com>>

Re: [FFmpeg-devel] [PATCH 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Kieran Kunhya via ffmpeg-devel
On Sat, 31 May 2025, 10:17 Dmitriy Kovalenko, wrote: > This patch integrates so called double bufferring when we are loading > Nit: I am not sure this is what most people refer to as "double buffering" Kieran > ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH v4 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Martin Storsjö
On Sat, 31 May 2025, Dmitriy Kovalenko wrote: Great. I send another version with the reverted change for the asr register change. What is the correct process to reply for the inline changes then? Inline email answer or cover letter? Do not top post. Reply to review comments in an inline reply

[FFmpeg-devel] [PATCH 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Dmitriy Kovalenko
This patch integrates so called double bufferring when we are loading 2 batch of elements at a time and then processing them in parallel. On the moden arm processors especially Apple Silicon it gives a visible benefit, for subsampled pixel processing it is especially nice because it allows to read

[FFmpeg-devel] [PATCH 1/2] swscale: rgb_to_yuv neon optimizations

2025-05-31 Thread Dmitriy Kovalenko
I've found quite a few ways to optimize existing ffmpeg's rgb to yuv subsampled conversion. In this patch stack I'll try to improve the perofrmance. This particular set of changes is a small improvement to all the existing functions and macro. The biggest performance gain is coming from post loadi

[FFmpeg-devel] [PATCH 0/2] swscale: rgb_to_yuv neon optimizations

2025-05-31 Thread Dmitriy Kovalenko
This patch set version applies the last comment on the review by Martin Storsj?? to avoid changing the register used for asr, and also for the context historically appliesd comments: > This is an unrelated change Fixed and resolved > The patch adds trailing whitespace here and in many other place

Re: [FFmpeg-devel] [PATCH v4 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time

2025-05-31 Thread Dmitriy Kovalenko
Great. I send another version with the reverted change for the asr register change. What is the correct process to reply for the inline changes then? Inline email answer or cover letter? > On May 30, 2025, at 11:10, Martin Storsjö wrote: > > On Fri, 30 May 2025, Dmitriy Kovalenko wrote: > >>