[FFmpeg-devel] [PATCH v3] libavformat/dashdec: Fix buffer overflow in segment URL resolution

2025-04-15 Thread xiaohuanshu
From: xiaohuanshu Problem: The max_url_size calculation for DASH segment URLs only considered the base URL length, leading to buffer overflow when the segment's sourceURL exceeded the pre-allocated buffer. This triggered the log error: "DASH request for url 'invalid:truncated'". Reproduce: 1. A

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Mittwoch, 16. April 2025 08:31 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rational() > > softworkz .: > > > > > >>

Re: [FFmpeg-devel] [PATCH] avcodec/h264bsd_dec: add h264dec base on h264bsd

2025-04-15 Thread Lynne
On 16/04/2025 08:12, Shiqi Zhu wrote: h264bsd url https://github.com/oneam/h264bsd ./configure --enable-decoder="h264_bsd" --extra-cflags="-I/h264bsd/src" --extra-ldflags="-L/h264bsd/posix/lib" --extra-libs="-lh264bsd" Test ./ffmpeg -y -codec:v h264_bsd -i /h264bsd/test/test_640x360.h264 ./test

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread Andreas Rheinhardt
softworkz .: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Mittwoch, 16. April 2025 07:37 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 01/12] >> fftools/textformat/avtextformat: Simplify avtext_print_rational() >> >> s

Re: [FFmpeg-devel] [PATCH 2/9] fftools/textformat: Quality improvements

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Mittwoch, 16. April 2025 06:51 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/9] fftools/textformat: Quality > improvements > > softworkz .: > > > > > >> -Original Message-

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Mittwoch, 16. April 2025 07:37 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rational() > > softworkz .: > > > > > >>

[FFmpeg-devel] [PATCH] avcodec/h264bsd_dec: add h264dec base on h264bsd

2025-04-15 Thread Shiqi Zhu
h264bsd url https://github.com/oneam/h264bsd ./configure --enable-decoder="h264_bsd" --extra-cflags="-I/h264bsd/src" --extra-ldflags="-L/h264bsd/posix/lib" --extra-libs="-lh264bsd" Test ./ffmpeg -y -codec:v h264_bsd -i /h264bsd/test/test_640x360.h264 ./test_640x360.yuv Signed-off-by: Shiqi Zhu

Re: [FFmpeg-devel] [PATCH v2] libavformat/dashdec: Fix buffer overflow in segment URL resolution

2025-04-15 Thread Andreas Rheinhardt
xiaohuan...@gmail.com: > From: xiaohuanshu > > Problem: > The max_url_size calculation for DASH segment URLs only considered the base > URL > length, leading to buffer overflow when the segment's sourceURL exceeded the > pre-allocated buffer. This triggered the log error: > "DASH request for url

[FFmpeg-devel] [PATCH v2] libavformat/dashdec: Fix buffer overflow in segment URL resolution

2025-04-15 Thread xiaohuanshu
From: xiaohuanshu Problem: The max_url_size calculation for DASH segment URLs only considered the base URL length, leading to buffer overflow when the segment's sourceURL exceeded the pre-allocated buffer. This triggered the log error: "DASH request for url 'invalid:truncated'". Reproduce: 1. A

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Mittwoch, 16. April 2025 07:15 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > softwor

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix buffer overflow in segment URL resolution

2025-04-15 Thread jing yan
Thanks for the review! that can't be null and I found another mistake. I will fix this issue and send a v2 patch soon. Michael Niedermayer 于2025年4月16日周三 07:33写道: > Hi > > On Fri, Apr 11, 2025 at 03:48:08PM +0800, xiaohuan...@gmail.com wrote: > > From: xiaohuanshu > > > > Problem: > > The max_ur

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread Andreas Rheinhardt
softworkz .: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Mittwoch, 16. April 2025 06:28 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 01/12] >> fftools/textformat/avtextformat: Simplify avtext_print_rational() >> >> s

Re: [FFmpeg-devel] [PATCH v2] avcodec/webvttdec: strip classes

2025-04-15 Thread Leon Grutters
On 3/21/25 4:55 PM, Leon Grutters wrote: If a supported tag has a class, e.g "" it is ignored entirely; so for example "Hello" would be converted to "Hello{\i0}" instead of the intended "{\i1}Hello{\i0}". Signed-off-by: Leon Grutters Hi all, Wondering if anyone could review and/or apply this

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Nicolas George
softworkz . (HE12025-04-15): > which breaks all usages. Please elaborate. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsub

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add avformat_query_seekable

2025-04-15 Thread Andreas Rheinhardt
Gyan Doshi: > Utility function to report seekability features for a given input. > > Useful for ffprobe and to extend seek possibilities in fftools. > --- > v2: >made constants more descriptive >add exception for rtsp false negative seekability > > doc/APIchanges | 3 +++ > liba

Re: [FFmpeg-devel] [PATCH 2/9] fftools/textformat: Quality improvements

2025-04-15 Thread Andreas Rheinhardt
softworkz .: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Dienstag, 15. April 2025 03:06 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 2/9] fftools/textformat: Quality >> improvements >> >> softworkz: >>> From: softwor

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > softworkz . > Sent: Mittwoch, 16. April 2025 06:38 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rational()

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Mittwoch, 16. April 2025 06:28 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rational() > > softworkz .: > > > > > >>

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread Andreas Rheinhardt
softworkz .: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Dienstag, 15. April 2025 10:36 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 01/12] >> fftools/textformat/avtextformat: Simplify avtext_print_rational() >> >> s

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 03:34 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 02:54 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 03:34 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 03:34 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Michael Niedermayer
On Wed, Apr 16, 2025 at 01:29:02AM +, softworkz . wrote: [...] > > > This will cause deserialization errors for many people in the world > > > who are processing FFprobe data. > > > > As said, ffprobe should not produce troublesome output > > As I said, it cannot be remedied on the FFprobe si

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 03:22 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 15, 2025 at 10:59:07PM +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Mittwoch, 16. April 2025 00:50 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-de

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 02:54 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 15, 2025 at 11:01:14PM +, softworkz . wrote: [...] > Besides, the patch had been submitted 3 years ago, there hasn't been > any review and the merge was totally unexpected. no reply for 1 week means commit must be expected "Send a patch to ffmpeg-devel. If no one answers within a

Re: [FFmpeg-devel] [PATCH v2] configure: Clearer documentation for "disable-safe-bitstream-reader"

2025-04-15 Thread Michael Niedermayer
On Sat, Apr 12, 2025 at 02:42:11AM +0200, Michael Niedermayer wrote: > On Sat, Apr 12, 2025 at 02:19:08AM +0200, Timo Rothenpieler wrote: > > On 12.04.2025 02:11, Michael Niedermayer wrote: > > > On Fri, Apr 11, 2025 at 08:32:55AM +0200, Andreas Rheinhardt wrote: > > > > Michael Niedermayer: > > >

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Dienstag, 15. April 2025 10:36 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rational() > > softworkz .: > > > > > >>

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix buffer stride for arm

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 08, 2025 at 07:22:32PM +0800, Bin Peng wrote: > When decoding a bitstream with weighted-bipred enabled, > the results on ARM and x86 platforms may differ. > > The reason for the inconsistency is that the value of > STRIDE_ALIGN differs between platforms. And STRIDE_ALIGN > is set to th

Re: [FFmpeg-devel] [PATCH] tools: Fix deprecation warning in patcheck

2025-04-15 Thread Michael Niedermayer
On Wed, Apr 09, 2025 at 08:26:56PM +0200, Link Mauve wrote: > From: Link Mauve > > GNU apparently deprecated their egrep alias, replace it with 'grep -E' > to avoid getting flooded with deprecation warnings. > --- > tools/patcheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will app

Re: [FFmpeg-devel] [PATCH v3] avformat/fifo: Check for keyframe video type before stop dropping

2025-04-15 Thread Michael Niedermayer
On Thu, Apr 10, 2025 at 07:59:15PM -0300, Arthur Grillo wrote: > The current behavior when using restart_with_keyframe is that it will > recover if it also encounters any audio packet, as they are flagged as a > keyframe. > > The expectation is that packets are dropped until the next _video_ > key

Re: [FFmpeg-devel] [PATCH] doc/filters: Fix video size of mptestsrc

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 08, 2025 at 04:29:14PM +0800, Zhao Zhili wrote: > From: Zhao Zhili > > --- > doc/filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 52f67fbd0c..6b8d2c314c 100644 > --- a/doc/filters.texi > +++ b/doc/filte

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix buffer overflow in segment URL resolution

2025-04-15 Thread Michael Niedermayer
Hi On Fri, Apr 11, 2025 at 03:48:08PM +0800, xiaohuan...@gmail.com wrote: > From: xiaohuanshu > > Problem: > The max_url_size calculation for DASH segment URLs only considered the base > URL > length, leading to buffer overflow when the segment's sourceURL exceeded the > pre-allocated buffer. T

Re: [FFmpeg-devel] [PATCH v3] [NOT for git] avutil/tests/map: benchmark code [BENCHMARK included]

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Dienstag, 15. April 2025 22:51 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] [PATCH v3] [NOT for git] avutil/tests/map: > benchmark code [BENCHMARK includ

Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-04-15 Thread Pranav Kant via ffmpeg-devel
Hello again. Is there anything else I can do here? On Fri, Apr 4, 2025 at 11:40 AM Pranav Kant wrote: > Any thoughts on this? > > On Thu, Mar 20, 2025 at 5:30 PM Pranav Kant wrote: > >> Patch version v5: >> - Uses two new macros DECLARE_ASM_VAR (used for both external and inline >> asm) and DEC

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > softworkz . > Sent: Mittwoch, 16. April 2025 00:59 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > > > > --

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 00:50 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 15, 2025 at 07:59:00PM +, softworkz . wrote: [...] > - The representation of multi-values - both, internally and when > outputting as probe data - is a de-facto standard The external handling in formats is specified in the corresponing specifications. ";" is certainly not correc

[FFmpeg-devel] [PATCH v12 8/8] tests: Add chained ogg/opus stream dump test.

2025-04-15 Thread Romain Beauxis
--- tests/Makefile | 1 + tests/fate/ogg-opus.mak | 11 ++ tests/ref/fate/ogg-opus-chained-meta.txt | 27 3 files changed, 39 insertions(+) create mode 100644 tests/fate/ogg-opus.mak create mode 100644 tests/ref/fate/og

[FFmpeg-devel] [PATCH v12 7/8] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet.

2025-04-15 Thread Romain Beauxis
--- libavformat/oggparseopus.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavformat/oggparseopus.c b/libavformat/oggparseopus.c index 218e9df581..fe25ad44f3 100644 --- a/libavformat/oggparseopus.c +++ b/libavformat/oggparseopus.c @@ -29,6 +29,7 @@ struct

[FFmpeg-devel] [PATCH v12 6/8] tests: Add chained ogg/flac stream dump test.

2025-04-15 Thread Romain Beauxis
--- tests/Makefile | 1 + tests/fate/ogg-flac.mak | 11 +++ tests/ref/fate/ogg-flac-chained-meta.txt | 13 + 3 files changed, 25 insertions(+) create mode 100644 tests/fate/ogg-flac.mak create mode 100644 tests/ref/fate/ogg-flac-cha

[FFmpeg-devel] [PATCH v12 5/8] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata.

2025-04-15 Thread Romain Beauxis
--- libavformat/oggparseflac.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavformat/oggparseflac.c b/libavformat/oggparseflac.c index f25ed9cc15..29f5904575 100644 --- a/libavformat/oggparseflac.c +++ b/libavformat/oggparseflac.c @@ -78,6 +78,25 @@ flac_header (AV

[FFmpeg-devel] [PATCH v12 4/8] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism.

2025-04-15 Thread Romain Beauxis
--- libavformat/oggdec.h | 14 ++ libavformat/oggparsevorbis.c | 25 + 2 files changed, 31 insertions(+), 8 deletions(-) diff --git a/libavformat/oggdec.h b/libavformat/oggdec.h index 43df23f4cb..c8460a66e9 100644 --- a/libavformat/oggdec.h +++ b/libavf

[FFmpeg-devel] [PATCH v12 0/8] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams.

2025-04-15 Thread Romain Beauxis
This is a series of patches to allow proper decoding of ogg metadata in chained `ogg/vorbis, `ogg/flac` and `ogg/opus` streams. Samples are available at: https://www.dropbox.com/scl/fo/xrtrna2rxr1j354hrtymq/AGwemlxHYecBLNmQ8Fsy--4?rlkey=lzilr4m9w4gfdqygoe172vvy8&dl=0 ## Changes since last versio

[FFmpeg-devel] [PATCH v12 3/8] tests: Add chained ogg/vorbis stream dump test.

2025-04-15 Thread Romain Beauxis
--- tests/Makefile | 1 + tests/fate/ogg-vorbis.mak | 11 +++ tests/ref/fate/ogg-vorbis-chained-meta.txt | 17 + 3 files changed, 29 insertions(+) create mode 100644 tests/fate/ogg-vorbis.mak create mode 100644 tests/ref/fate/

[FFmpeg-devel] [PATCH v12 2/8] tests: Add stream dump test API util.

2025-04-15 Thread Romain Beauxis
--- tests/Makefile| 1 + tests/api/Makefile| 2 +- tests/api/api-dump-stream-meta-test.c | 177 ++ 3 files changed, 179 insertions(+), 1 deletion(-) create mode 100644 tests/api/api-dump-stream-meta-test.c diff --git a/tests

[FFmpeg-devel] [PATCH v12 1/8] libavcodec/decode.c: intercept `AV_PKT_DATA_METADATA_UPDATE` packet extra data, attach them to the next decoded frame.

2025-04-15 Thread Romain Beauxis
--- libavcodec/decode.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index fca0c7ff58..06d899a9dd 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -97,6 +97,8 @@ typedef struct DecodeContext { int lcevc_frame;

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Dienstag, 15. April 2025 22:47 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > softwor

Re: [FFmpeg-devel] [PATCH v2 5/6] libavutil: Add AVMap

2025-04-15 Thread Nicolas George
Michael Niedermayer (HE12025-04-15): > or is the goal to avoid the error handling? Both are desirable. I am sure we have in our API a few functions that take a dictionary but are very fast; is it really worth digging around to convince you that avoiding dynamic allocations is worth it? > also in

Re: [FFmpeg-devel] [PATCH v2 5/6] libavutil: Add AVMap

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 15, 2025 at 09:14:42PM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-04-15): > > Where exactly would that benefit FFmpeg ? > > Dictionaries generally are used to move stuff aorund, like metadata or > > options. > > Or may be used in the future to keep track of some mapping

[FFmpeg-devel] [PATCH v3] [NOT for git] avutil/tests/map: benchmark code [BENCHMARK included]

2025-04-15 Thread Michael Niedermayer
1000 entries variable bytes at location 4-5 4809796 decicycles in av_map_add, 512 runs, 0 skips 3457756 decicycles in av_map_get, 512 runs, 0 skips 153482370 decicycles in av_dict_set, 512 runs, 0 skips 150045088 decicycles in av_dict_get, 512 runs, 0 skips

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Nicolas George
softworkz . (HE12025-04-15): > but it would be a breaking change Please elaborate. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, v

Re: [FFmpeg-devel] AVDictionary vs. AVSet (AVDictionary2 approximation)

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 15, 2025 at 09:11:33PM +0200, Michael Niedermayer wrote: > On Mon, Apr 14, 2025 at 01:02:00PM +, softworkz . wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > softworkz . > > > Sent: Montag, 14. April 2025 14:40 > > > To: FFmpeg developme

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Dienstag, 15. April 2025 21:03 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > Michael

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Dienstag, 15. April 2025 20:56 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH] avcodec/libjxlenc: prevent color encoding from being set twice

2025-04-15 Thread Leo Izen
On 4/13/25 06:12, Leo Izen wrote: We currently populate the color encoding bundle and then check to see if there's an ICC profile to attach, and set the color encoding bundle in either case. The ICC profile overrides the color encoding bundle, so we should not calculate enum-based color encoding

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: check if expect_assume is supported by the headers

2025-04-15 Thread Tristan Matthews
On Tue, Apr 15, 2025 at 3:35 PM James Almer wrote: > On 4/15/2025 4:31 PM, Lynne wrote: > > --- > > libavutil/hwcontext_vulkan.c | 8 > > libavutil/vulkan_loader.h| 2 ++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: check if expect_assume is supported by the headers

2025-04-15 Thread James Almer
On 4/15/2025 4:31 PM, Lynne wrote: --- libavutil/hwcontext_vulkan.c | 8 libavutil/vulkan_loader.h| 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 8823af0175..f878dfec76 100644 --- a/libavutil/hwcontext_vulk

[FFmpeg-devel] [PATCH] hwcontext_vulkan: check if expect_assume is supported by the headers

2025-04-15 Thread Lynne
--- libavutil/hwcontext_vulkan.c | 8 libavutil/vulkan_loader.h| 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 8823af0175..f878dfec76 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Dienstag, 15. April 2025 20:33 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On

Re: [FFmpeg-devel] [PATCH v2 5/6] libavutil: Add AVMap

2025-04-15 Thread Nicolas George
Michael Niedermayer (HE12025-04-15): > Where exactly would that benefit FFmpeg ? > Dictionaries generally are used to move stuff aorund, like metadata or > options. > Or may be used in the future to keep track of some mappings like > timestamps to file positions during demuxing or muxing > Or maybe

Re: [FFmpeg-devel] AVDictionary vs. AVSet (AVDictionary2 approximation)

2025-04-15 Thread Michael Niedermayer
On Mon, Apr 14, 2025 at 01:02:00PM +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > softworkz . > > Sent: Montag, 14. April 2025 14:40 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] AVDic

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Dienstag, 15. April 2025 20:26 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > Hi

Re: [FFmpeg-devel] [PATCH v2 5/6] libavutil: Add AVMap

2025-04-15 Thread Michael Niedermayer
Hi Nicolas On Tue, Apr 15, 2025 at 08:45:27PM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-04-15): > > +AVMap *av_map_new(AVMapCompareFunc cmp_keyvalue, AVMapCopyFunc copy, > > AVMapFreeFunc freef) > > +{ > > +AVMap *s = av_mallocz(sizeof(*s)); > > +if (!s) > > +ret

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Nicolas George
Michael Niedermayer (HE12025-04-15): > I think ffprobe should not generate invalid output if metadata given to it has > 2 entries with the same key, independant of that being the correct way to > export > metadata. Good thing that “The JSON syntax […] does not require that name strings be unique”

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Nicolas George
Ridley Combs via ffmpeg-devel (HE12025-04-15): > This is an issue that should be resolved by supporting multiple > entries all the way through the relevant ffmpeg.c and muxer code > paths, rather than adding new fragile usage of in-band signaling > within metadata strings. Since it has been neglec

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Michael Niedermayer
On Mon, Apr 14, 2025 at 11:59:02PM +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Dienstag, 15. April 2025 01:20 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-de

Re: [FFmpeg-devel] [PATCH v2 5/6] libavutil: Add AVMap

2025-04-15 Thread Nicolas George
Michael Niedermayer (HE12025-04-15): > +AVMap *av_map_new(AVMapCompareFunc cmp_keyvalue, AVMapCopyFunc copy, > AVMapFreeFunc freef) > +{ > +AVMap *s = av_mallocz(sizeof(*s)); > +if (!s) > +return NULL; Please no. The ability to allocate on stack including room for a few values is

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Michael Niedermayer
On Tue, Apr 15, 2025 at 12:17:32AM +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Ridley Combs via ffmpeg-devel > > Sent: Dienstag, 15. April 2025 02:03 > > To: ffmpeg-devel > > Cc: Ridley Combs > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] a

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread Michael Niedermayer
Hi On Tue, Apr 15, 2025 at 01:37:56AM +, softworkz . wrote: [...] > > > do you have a test file perhaps? > > > > Will email you one, but the loop with a function that doesnt advance > > is an issue even if the specific file doesnt trigger it in a different > > implementation > > > Thanks a

[FFmpeg-devel] [PATCH v2 6/6] [NOT for git] avutil/tests/map: benchmark code

2025-04-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/tests/map.c | 56 +++ 1 file changed, 56 insertions(+) diff --git a/libavutil/tests/map.c b/libavutil/tests/map.c index 38f0a153e68..72bfafdb4f4 100644 --- a/libavutil/tests/map.c +++ b/libavutil/tests/map.c

[FFmpeg-devel] [PATCH v2 5/6] libavutil: Add AVMap

2025-04-15 Thread Michael Niedermayer
AVL Tree based Map compared to AVDictionary this has * clone is O(n) instead of O(n²) * copy is O(n*log n) instead of O(n²) * O(log n) malloc() calls by default and O(1) if av_map_realloc() is used instead of O(n) * get/add/delete is O(log n) * * You can add (if memory is realloced before)

[FFmpeg-devel] [PATCH v2 3/6] avutil/tree: Make av_tree_find2() non recursive

2025-04-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/tree.c b/libavutil/tree.c index 455a447bf11..a4c090e6d04 100644 --- a/libavutil/tree.c +++ b/libavutil/tree.c @@ -57,12 +57,12 @@ static void tree_find_next(co

[FFmpeg-devel] [PATCH v2 4/6] avutil/tree: Make tree_find_next() non recursive

2025-04-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/tree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/tree.c b/libavutil/tree.c index a4c090e6d04..09c55f6752d 100644 --- a/libavutil/tree.c +++ b/libavutil/tree.c @@ -40,16 +40,16 @@ struct AVTreeNode *av_tree_

[FFmpeg-devel] [PATCH v2 2/6] avutil/tree: Add av_tree_move

2025-04-15 Thread Michael Niedermayer
This will allow storing a tree in a flat array and reallocating it Signed-off-by: Michael Niedermayer --- libavutil/tree.c | 15 +++ libavutil/tree.h | 11 +++ 2 files changed, 26 insertions(+) diff --git a/libavutil/tree.c b/libavutil/tree.c index 9f58a3f3d49..455a447bf11 1

[FFmpeg-devel] [PATCH v2 1/6] avutil/tree: av_tree_find2() to also find the first and last elements comparing equal

2025-04-15 Thread Michael Niedermayer
This patch also improves the worst case of O(n) (with n equal elements) to O(log n) This may be used by AVDictionary2 And AVSet for iterating over identical keys Signed-off-by: Michael Niedermayer --- libavutil/tree.c | 34 +- libavutil/tree.h | 6 ++ 2 fil

[FFmpeg-devel] [PATCH v4] libpostproc: deprecate the AMD 3DNow! define

2025-04-15 Thread Sean McGovern
It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f. --- doc/APIchanges | 3 +++ libpostproc/postprocess.h | 2 ++ libpostproc/version.h | 2 +- libpostproc/version_major.h | 2 ++ 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix ref_order_hint value for second slot

2025-04-15 Thread David Rosca
We always use two slots, even when only one L0 reference is supported by the driver. However we still need to set the correct value for the ref_order_hint of the second slot. Fixes bf9f921ef7 ("avcodec/hw_base_encode: restrict size of next_prev") --- libavcodec/vaapi_encode_av1.c | 3 +++ 1 file

[FFmpeg-devel] [PATCH 2/9] fftools/textformat: Quality improvements

2025-04-15 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 121 +++--- fftools/textformat/avtextformat.h | 6 +- fftools/textformat/tf_default.c | 8 +- fftools/textformat/tf_ini.c | 2 +- fftools/textformat/tf_json.c | 8 +- ff

[FFmpeg-devel] [PATCH v2 2/2] ffprobe: show seekability details in format section

2025-04-15 Thread Gyan Doshi
--- doc/ffprobe.xsd | 2 ++ fftools/ffprobe.c| 15 ++- tests/ref/fate/cavs-demux| 2 +- tests/ref/fate/ffprobe_compact | 2 +- tests/ref/fate/ffprobe_csv | 2 +- tests/ref/fate/ffprobe_default | 2 ++ tests

Re: [FFmpeg-devel] [PATCH v2] lavc: add an av1_vulkan encoder

2025-04-15 Thread Andreas Rheinhardt
Lynne: > This commit adds a Vulkan AV1 encoder, using the native acceleration API. > --- > configure |1 + > libavcodec/Makefile|2 + > libavcodec/allcodecs.c |1 + > libavcodec/vulkan_encode_av1.c | 1385 > liba

[FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread Andreas Rheinhardt
Patches attached. - Andreas From e54f813ea94fad0081f79aad8c35daa858300176 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 14 Apr 2025 22:13:19 +0200 Subject: [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational() Use snprintf() directly instead of initializ

[FFmpeg-devel] [PATCH 5/9] fftools/ffmpeg_filter: Move some declaration to new header file

2025-04-15 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions(-) cr

Re: [FFmpeg-devel] [PATCH] libavcodec/riscv:add RVV optimized for idct_32x32_8:

2025-04-15 Thread Rémi Denis-Courmont
Hi, Le tiistaina 15. huhtikuuta 2025, 10.34.24 Itä-Euroopan kesäaika daichengr...@iscas.ac.cn a écrit : > From: daichengrong > > riscv/hevcdsp_idct_rvv: Optimize idct_32x32_8 > > On Banana PI F3: > > hevc_idct_32x32_8_c:119579.3 ( 1.00x) > h

Re: [FFmpeg-devel] [PATCH] lavfi/src_movie: set pkt_timebase

2025-04-15 Thread Nicolas George
Nicolas George (HE12025-01-05): > Fix “Could not update timestamps for skipped samples” warning > and associated misfeature. > > Signed-off-by: Nicolas George > --- > libavfilter/src_movie.c | 1 + > 1 file changed, 1 insertion(+) Pushed. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread Andreas Rheinhardt
softworkz .: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Dienstag, 15. April 2025 03:00 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: >> Simpl

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: add Blackmagic RAW decoder

2025-04-15 Thread Lynne
On 15/04/2025 12:04, Lynne wrote: Most of the work was done by Paul B Mahol. I cleaned the patch up, improved the code a bit, and added slice threading. --- configure | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/braw.c | 666 ++

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add avformat_query_seekable

2025-04-15 Thread Zhao Zhili
> On Apr 15, 2025, at 18:39, Gyan Doshi wrote: > > Utility function to report seekability features for a given input. > > Useful for ffprobe and to extend seek possibilities in fftools. > --- > v2: > made constants more descriptive > add exception for rtsp false negative seekability > > d

[FFmpeg-devel] [PATCH] aarch64/h26x: optimize sao_band_filter

2025-04-15 Thread Zhao Zhili
From: Zhao Zhili int8_t[] is enough for offset_table of 8 bit streams. On rpi5: Before After hevc_sao_band_8_8_c: 252.3 ( 1.00x) 252.3 ( 1.00x) hevc_sao_band_8_8_neon:95.8 ( 2.63x) 61.0 ( 4.14x) hevc_sao_band_16_8_c: 87

[FFmpeg-devel] [PATCH v2 1/2] avformat: add avformat_query_seekable

2025-04-15 Thread Gyan Doshi
Utility function to report seekability features for a given input. Useful for ffprobe and to extend seek possibilities in fftools. --- v2: made constants more descriptive add exception for rtsp false negative seekability doc/APIchanges | 3 +++ libavformat/avformat.h | 22

[FFmpeg-devel] [PATCH 3/3] avcodec: add Blackmagic RAW decoder

2025-04-15 Thread Lynne
Most of the work was done by Paul B Mahol. I cleaned the patch up, improved the code a bit, and added slice threading. --- configure | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/braw.c | 666 + 4 files

[FFmpeg-devel] [PATCH 1/3] avcodec: add AV_CODEC_ID_BRAW

2025-04-15 Thread Lynne
This adds codec entries for the Blackmagic RAW codec. --- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + 2 files changed, 8 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 9fb190e35a..90e31a8b6a 100644 --- a/libavcodec/codec_desc.c +++ b/lib

[FFmpeg-devel] [PATCH 2/3] lavf/mov: support demuxing Blackmagic RAW streams

2025-04-15 Thread Lynne
--- libavformat/isom_tags.c | 7 +++ libavformat/mov.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/isom_tags.c b/libavformat/isom_tags.c index f05762beec..7bf2bf7d5b 100644 --- a/libavformat/isom_tags.c +++ b/libavformat/isom_tags.c @@ -286,6 +286,13

[FFmpeg-devel] [PATCH] libavcodec/riscv:add RVV optimized for idct_32x32_8:

2025-04-15 Thread daichengrong
From: daichengrong riscv/hevcdsp_idct_rvv: Optimize idct_32x32_8 On Banana PI F3: hevc_idct_32x32_8_c:119579.3 ( 1.00x) hevc_idct_32x32_8_rvv_i64: 51254.4 ( 2.33x) Signed-off-by: daichengrong --- libavcodec/riscv/M