Re: [FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true

2025-02-05 Thread Leo Izen
On 2/6/25 2:00 AM, dank074 wrote: Currently when a Unix Domain Socket is used as input there is a loss of data when data is consumed from the stream. Setting is_streamed to true fixes this, since the unix domain socket is now treated like a consumable stream. Fixes: #9346 Signed-off-by: dank07

[FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true

2025-02-05 Thread dank074
Currently when a Unix Domain Socket is used as input there is a loss of data when data is consumed from the stream. Setting is_streamed to true fixes this, since the unix domain socket is now treated like a consumable stream. Fixes: #9346 Signed-off-by: dank074 --- libavformat/unix.c | 2 +- 1

Re: [FFmpeg-devel] [PATCH] ffv1dec: fix threaded decode failures

2025-02-05 Thread Lynne
On 05/02/2025 17:26, Lynne wrote: On 05/02/2025 15:51, James Almer wrote: On 2/5/2025 11:47 AM, Lynne wrote: Fixes 7187eadf8c0f0c640f1d23811c55fad0cba60aa5 The issue is that while avctx->pix_fmt is synchronized between threads, f->pix_fmt was not. Fixes fate-vsynth1-ffv1-2pass10 with THREADS=

[FFmpeg-devel] [PATCH] avutil/hwcontext_amf: fix crash on uninit after init failed

2025-02-05 Thread Kacper Michajłow
amf_device_create() calls amf_device_uninit() on errors, but if things were not initialized it will null deref amf_ctx->factory. Fixes: https://github.com/mpv-player/mpv/issues/15814 Signed-off-by: Kacper Michajłow --- libavutil/hwcontext_amf.c | 6 -- 1 file changed, 4 insertions(+), 2 del

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2025-02-05 Thread Leo Izen
On 2/5/25 11:14 AM, Marth64 wrote: behaved as per their reply. Could it make sense to only return the AVERROR(EEXIST) if -nostdin is If you do, you should consider not just -nostdin but also if reading from stdin like a pipe, e.g. ffmpeg -i - foo.mkv this will exit with success if foo.mk

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

2025-02-05 Thread Zhao Zhili
> On Feb 6, 2025, at 05:20, James Almer wrote: > > On 2/5/2025 12:10 PM, Zhao Zhili wrote: >> -skip_bits1(gb); /* direct_depenency_all_layers_flag */ >> -direct_dep_type = get_bits_long(gb, direct_dep_type_len); >> -if (direct_dep_type > HEVC_DEP_TYPE_BOTH) { >> -av_log(avc

[FFmpeg-devel] [PATCH v4 3/3] avcodec/hevc: Add alpha layer support

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavcodec/hevc/refs.c| 11 +- 3 files changed, 83 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec

[FFmpeg-devel] [PATCH v4 1/3] avcodec/hevc: Rewrite scalability_mask_flag parse in decode_vps_ext

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili Remove a for loop and make it easy to extend to support other types of scalability. Move ScalabilityMask to hevc header file so it can be used in hevc decoder. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 7 +++ libavcodec/hevc/ps.c | 33 +++---

[FFmpeg-devel] [PATCH v4 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili Only implementing what's needed for HEVC with alpha. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 5 ++ libavcodec/hevc/ps.c | 126 + libavcodec/hevc/ps.h | 4 ++ 3 files changed, 98 insertions(+), 37 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v3 2/2] Add stream dump test with test for ogg/flac.

2025-02-05 Thread Michael Niedermayer
On Tue, Feb 04, 2025 at 07:31:45AM -0500, Romain Beauxis wrote: > This is the new FATE test. > > Test samples are available here: > https://www.dropbox.com/scl/fo/fxt2edwkyj2mjc9qubku5/AICHxJyxMMAK8MIJqWLcvk4?rlkey=mlt12lsu741ejukz0p5qtn9rq&dl=0 > > Output prior to the changes is: > Stream ID: 0

[FFmpeg-devel] [PATCH v2 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages

2025-02-05 Thread James Almer
Considerably reduces the size of HEVCSEI. Signed-off-by: James Almer --- Fixed segfaults. libavcodec/hevc/hevcdec.c | 10 +- libavcodec/hevc/refs.c| 4 ++-- libavcodec/hevc/sei.c | 6 +- libavcodec/hevc/sei.h | 6 +- 4 files changed, 17 insertions(+), 9 deletions(

Re: [FFmpeg-devel] [PATCH v2 1/2] random_seed: Reorder if clauses for gathering entropy

2025-02-05 Thread Michael Niedermayer
Hi On Thu, Feb 06, 2025 at 12:18:08AM +0200, Martin Storsjö wrote: > Make it easier to add more cases. > > This should be a pure refactoring, with no functional changes. > --- > libavutil/random_seed.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages

2025-02-05 Thread Michael Niedermayer
On Mon, Feb 03, 2025 at 07:35:45PM -0300, James Almer wrote: > Considerably reduces the size of HEVCSEI and eliminates data copy between > threads. > > Signed-off-by: James Almer > --- > libavcodec/hevc/hevcdec.c | 4 ++-- > libavcodec/hevc/refs.c| 4 ++-- > libavcodec/hevc/sei.c | 6 ++

[FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true

2025-02-05 Thread Efrain Torres
Currently when a Unix Domain Socket is used as input there is a loss of data when data is consumed from the stream. Setting is_streamed to true fixes this, since the unix domain socket is now treated like a consumable stream. Fixes: #9346 Signed-off-by: dank074 --- libavformat/unix.c | 2 +-

[FFmpeg-devel] [PATCHv2] avcodec/g728dec: G.728 decoder

2025-02-05 Thread Peter Ross
--- suggestions incorporated. libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/g728data.h | 70 + libavcodec/g728dec.c| 220 libavcodec/utils.

Re: [FFmpeg-devel] [PATCH v2 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-05 Thread Michael Niedermayer
Hi Martin On Thu, Feb 06, 2025 at 12:18:09AM +0200, Martin Storsjö wrote: > On a Zen 5, on Ubuntu 24.04 (with CLOCKS_PER_SEC 100), the > value of clock() in this loop increments by 0 most of the time, > and when it does increment, it usually increments by 1 compared > to the previous round. >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-02-05 Thread Michael Niedermayer
Hi On Wed, Feb 05, 2025 at 07:41:39PM +0100, Michael Niedermayer wrote: > Hi Kacper > > On Tue, Feb 04, 2025 at 12:45:14PM +0100, Kacper Michajlow wrote: > [...] > > security benefits. I get it. Someone needed to hit their KPI by > > submitting CVEs, and they found a marginally applicable case of

Re: [FFmpeg-devel] Up to Date DeckLink Support broken in FFMPEG

2025-02-05 Thread Marth64
+ 1 to Leo I have this card installed and active and can help validate. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] Up to Date DeckLink Support broken in FFMPEG

2025-02-05 Thread Leo Izen
On 2/5/25 4:44 PM, ffm...@gallery.co.uk wrote: Hi Folks It seems like the current decklink code in FFMPEG is no longer fully compatible with the latest Decklink drivers The behaviour seen is that output via DeckLink starts OK but very quickly stalls. Apparently its related to the callbacks. I

Re: [FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

2025-02-05 Thread Peter Ross
On Sun, Jan 19, 2025 at 08:49:50PM +1100, Peter Ross wrote: > Fixes ticket #10658. > --- > > Tested with some different vertical resolution alignments. > > When the vertical resolution is not aligned to macroblock height, the > reference encoder & decoder performs buggy placement of the initial >

[FFmpeg-devel] [PATCH v2 1/2] random_seed: Reorder if clauses for gathering entropy

2025-02-05 Thread Martin Storsjö
Make it easier to add more cases. This should be a pure refactoring, with no functional changes. --- libavutil/random_seed.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index 8a4e4f1fc0..ca084b40da 1006

[FFmpeg-devel] [PATCH v2 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-05 Thread Martin Storsjö
On a Zen 5, on Ubuntu 24.04 (with CLOCKS_PER_SEC 100), the value of clock() in this loop increments by 0 most of the time, and when it does increment, it usually increments by 1 compared to the previous round. Due to the "last_t + 2*last_td + (CLOCKS_PER_SEC > 1000) >= t" expression, we only m

Re: [FFmpeg-devel] [PATCH] random_seed: Limit the time taken by get_generic_seed

2025-02-05 Thread Martin Storsjö
On Fri, 31 Jan 2025, Michael Niedermayer wrote: diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index 8a4e4f1fc0..8f969060a0 100644 --- a/libavutil/random_seed.c +++ b/libavutil/random_seed.c @@ -83,6 +83,7 @@ static uint32_t get_generic_seed(void) static uint32_t buffer[512]

[FFmpeg-devel] Up to Date DeckLink Support broken in FFMPEG

2025-02-05 Thread ffmpeg
Hi Folks It seems like the current decklink code in FFMPEG is no longer fully compatible with the latest Decklink drivers The behaviour seen is that output via DeckLink starts OK but very quickly stalls. Apparently its related to the callbacks. I believe this broken with BMD drivers 13.3 and lat

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data

2025-02-05 Thread Michael Niedermayer
On Wed, Feb 05, 2025 at 06:16:35PM -0300, James Almer wrote: > On 2/5/2025 6:07 PM, Michael Niedermayer wrote: > > On Mon, Feb 03, 2025 at 07:35:46PM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libavcodec/hevc/hevcdec.c | 55 ++-

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

2025-02-05 Thread James Almer
On 2/5/2025 12:10 PM, Zhao Zhili wrote: -skip_bits1(gb); /* direct_depenency_all_layers_flag */ -direct_dep_type = get_bits_long(gb, direct_dep_type_len); -if (direct_dep_type > HEVC_DEP_TYPE_BOTH) { -av_log(avctx, AV_LOG_WARNING, "Unsupported direct_dep_type: %d\n", -

Re: [FFmpeg-devel] [PATCH] checkasm: aacencdsp: Actually initialize ff_aac_pow34sf_tab

2025-02-05 Thread Martin Storsjö
On Sun, 2 Feb 2025, Michael Niedermayer wrote: On Wed, Jan 29, 2025 at 11:58:54AM +0200, Martin Storsjö wrote: This table is zero initialized by default, and has to be explicitly initialized. Coincidentally, this fixes linking checkasm with Apple's older linker. (In Xcode 15, Apple switched to

[FFmpeg-devel] [PATCH v2 1/2] x86: aacencdsp: Fix negating signed values in aac_quantize_bands

2025-02-05 Thread Martin Storsjö
Previously, we would do OR with the sign bit, forcing the output to a negative value, while we want to negate it, by inverting the sign bit. --- libavcodec/x86/aacencdsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/aacencdsp.asm b/libavcodec/x86/aacencdsp.

[FFmpeg-devel] [PATCH v2 2/2] checkasm: aacencdsp: Actually test nonzero values in quant_bands

2025-02-05 Thread Martin Storsjö
Previously, we read elements from ff_aac_pow34sf_tab; however that table is initialized to zero; one needs to call ff_aac_float_common_init() to make sure that the table is initialized. However, given the range of the input values, a large number of entries in ff_aac_pow34sf_tab would give results

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data

2025-02-05 Thread James Almer
On 2/5/2025 6:07 PM, Michael Niedermayer wrote: On Mon, Feb 03, 2025 at 07:35:46PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) seems to fail to build libavco

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data

2025-02-05 Thread Michael Niedermayer
On Mon, Feb 03, 2025 at 07:35:46PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/hevc/hevcdec.c | 55 ++- > 1 file changed, 54 insertions(+), 1 deletion(-) seems to fail to build libavcodec/hevc/hevcdec.c: In function ‘hevc_sei_to_c

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/hevc: Add alpha layer support

2025-02-05 Thread James Almer
On 2/5/2025 2:22 PM, Zhao Zhili wrote: On Feb 5, 2025, at 23:33, James Almer wrote: On 2/5/2025 12:10 PM, Zhao Zhili wrote: From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavco

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/osq: avoid undefined negation

2025-02-05 Thread Michael Niedermayer
On Tue, Feb 04, 2025 at 12:16:59AM -0300, James Almer wrote: > On 2/3/2025 11:58 PM, Michael Niedermayer wrote: > > Fixes: negation of -2147483648 cannot be represented in type 'int32_t' (aka > > 'int'); cast to an unsigned type to negate this value to itself > > Fixes: > > 390646659/clusterfuzz-

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-02-05 Thread Michael Niedermayer
Hi Kacper On Tue, Feb 04, 2025 at 12:45:14PM +0100, Kacper Michajlow wrote: [...] > security benefits. I get it. Someone needed to hit their KPI by > submitting CVEs, and they found a marginally applicable case of a > highly unrealistic attack scenario. I think you mis judge the (un)realism of th

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-02-05 Thread Michael Niedermayer
Hi Traneptora On Tue, Feb 04, 2025 at 06:35:07PM -0500, Leo Izen wrote: > > > On 1/28/25 4:44 PM, Michael Niedermayer wrote: > > Hi > > > > On Tue, Jan 28, 2025 at 10:12:30PM +0200, Jan Ekström wrote: > > > On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer > > > wrote: > > > > > > > > Maybe

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264: Set FFCodec.pix_fmts field and fix deprecation warning

2025-02-05 Thread Zhao Zhili
> On Feb 6, 2025, at 01:42, Andreas Rheinhardt > wrote: > > Zhao Zhili: >> From: Zhao Zhili >> >> We can fix deprecation warning by not set p.pix_fmts, and copy >> FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static(). >> However, that method requires non-const FFCodec. So I deci

[FFmpeg-devel] [PATCH v2 3/3] avcodec/mpeg12enc: Set pix_fmts and supported_framerates fields

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/mpeg12enc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index e56571da03..1dc8c2181f 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -1238,6 +1238,9 @@ const FFCodec ff_mpeg1video_e

[FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264: Set FFCodec.pix_fmts field

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili We can fix deprecation warning by not set p.pix_fmts, and copy FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static(). However, that method requires non-const FFCodec. So I decided to set pix_fmts and p.pix_fmts both for now. --- libavcodec/libx264.c | 3 +++ 1 file ch

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264: Set FFCodec.pix_fmts field and fix deprecation warning

2025-02-05 Thread Andreas Rheinhardt
Zhao Zhili: > From: Zhao Zhili > > We can fix deprecation warning by not set p.pix_fmts, and copy > FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static(). > However, that method requires non-const FFCodec. So I decided to > set pix_fmts and p.pix_fmts both, and disable deprecation warn

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/hevc: Add alpha layer support

2025-02-05 Thread Zhao Zhili
> On Feb 5, 2025, at 23:33, James Almer wrote: > > On 2/5/2025 12:10 PM, Zhao Zhili wrote: >> From: Zhao Zhili >> Signed-off-by: Zhao Zhili >> --- >> libavcodec/hevc/hevcdec.c | 72 ++- >> libavcodec/hevc/hevcdec.h | 2 ++ >> libavcodec/hevc/refs.c| 1

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: Fix deprecation warnings on pix_fmts

2025-02-05 Thread Zhao Zhili
I prefer another version which doesn't drop const modifier. https://ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339331.html > On Feb 6, 2025, at 00:07, Zhao Zhili > wrote: > > From: Zhao Zhili > > --- > libavcodec/allcodecs.c | 6 ++--- > libavcodec/libx264.c | 53 +

[FFmpeg-devel] [PATCH 3/3] avcodec/mpeg12enc: Set pix_fmts and supported_framerates fields

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/mpeg12enc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index e56571da03..7c8ba0b25a 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -1238,9 +1238,14 @@ const FFCodec ff_mpeg1

[FFmpeg-devel] [PATCH 2/3] avcodec/libx264: Set FFCodec.pix_fmts field and fix deprecation warning

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili We can fix deprecation warning by not set p.pix_fmts, and copy FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static(). However, that method requires non-const FFCodec. So I decided to set pix_fmts and p.pix_fmts both, and disable deprecation warning explicitly. --- lib

[FFmpeg-devel] [PATCH 1/3] avcodec/codec_internal: Add pix_fmts and supported_framerates fields to FFCodec

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili These fields in AVCodec are deprecated. For most codecs, it's cumbersome to implement get_supported_config only to export pix_fmts. --- libavcodec/avcodec.c| 6 ++ libavcodec/codec_internal.h | 9 + 2 files changed, 15 insertions(+) diff --git a/libavcodec/a

Re: [FFmpeg-devel] [PATCH 2/8] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors

2025-02-05 Thread Marth64
I know `if ((ret = av_do_something()) <0)` pattern has been frowned upon recently but besides that it LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] ffv1dec: fix threaded decode failures

2025-02-05 Thread Lynne
On 05/02/2025 15:51, James Almer wrote: On 2/5/2025 11:47 AM, Lynne wrote: Fixes 7187eadf8c0f0c640f1d23811c55fad0cba60aa5 The issue is that while avctx->pix_fmt is synchronized between threads, f->pix_fmt was not. Fixes fate-vsynth1-ffv1-2pass10 with THREADS=2. Can confirm "make fate-vsynth{

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2025-02-05 Thread Marth64
> On 2024-07-16 09:40 am, Marth64 wrote: > > Gyan: > >> The former is not an error. The user was asked and the application > >> behaved as per their reply. > > Could it make sense to only return the AVERROR(EEXIST) if -nostdin is > > passed (otherwise current behavior)? > > Agreed. Planning to sen

[FFmpeg-devel] [PATCH] avcodec/libx264: Fix deprecation warnings on pix_fmts

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/allcodecs.c | 6 ++--- libavcodec/libx264.c | 53 +- 2 files changed, 50 insertions(+), 9 deletions(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index 4e1b1c9b45..d2ec4c3045 100644 --- a/libavcodec/all

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/hevc: Add alpha layer support

2025-02-05 Thread James Almer
On 2/5/2025 12:10 PM, Zhao Zhili wrote: From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavcodec/hevc/refs.c| 11 +- 3 files changed, 83 insertions(+), 2 deletions(-) I tr

[FFmpeg-devel] [PATCH v3 1/3] avcodec/hevc: Rewrite scalability_mask_flag parse in decode_vps_ext

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili Remove a for loop and make it easy to extend to support other types of scalability. Move ScalabilityMask to hevc header file so it can be used in hevc decoder. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 7 +++ libavcodec/hevc/ps.c | 33 +++---

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mxfenc: Make write_desc return int

2025-02-05 Thread Tomas Härdin
tis 2024-11-12 klockan 18:49 +0100 skrev Tomas Härdin: > fre 2024-11-08 klockan 11:29 +0100 skrev Tomas Härdin: > > Passes fate-mxf > > Will push in a day or two .. or a month or two. Tested and pushed. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH v3 3/3] avcodec/hevc: Add alpha layer support

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavcodec/hevc/refs.c| 11 +- 3 files changed, 83 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec

[FFmpeg-devel] [PATCH v3 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

2025-02-05 Thread Zhao Zhili
From: Zhao Zhili Only implementing what's needed for HEVC with alpha. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 5 ++ libavcodec/hevc/ps.c | 126 + libavcodec/hevc/ps.h | 4 ++ 3 files changed, 98 insertions(+), 37 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] ffv1dec: fix threaded decode failures

2025-02-05 Thread James Almer
On 2/5/2025 11:47 AM, Lynne wrote: Fixes 7187eadf8c0f0c640f1d23811c55fad0cba60aa5 The issue is that while avctx->pix_fmt is synchronized between threads, f->pix_fmt was not. Fixes fate-vsynth1-ffv1-2pass10 with THREADS=2. Can confirm "make fate-vsynth{1,2,3,_lena} THREADS=2" (as well as highe

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

2025-02-05 Thread Tomas Härdin
ons 2025-02-05 klockan 12:56 +0100 skrev Michael Niedermayer: > Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be > represented in type 'long' > Fixes: 392672068/clusterfuzz-testcase-minimized- > ffmpeg_dem_MXF_fuzzer-6232335892152320 > > Found-by: continuous fuzzing process > http

[FFmpeg-devel] [PATCH] ffv1dec: fix threaded decode failures

2025-02-05 Thread Lynne
Fixes 7187eadf8c0f0c640f1d23811c55fad0cba60aa5 The issue is that while avctx->pix_fmt is synchronized between threads, f->pix_fmt was not. Fixes fate-vsynth1-ffv1-2pass10 with THREADS=2. --- libavcodec/ffv1dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ffv1dec.c b/libavcode

Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks

2025-02-05 Thread Tomas Härdin
ons 2024-12-04 klockan 15:14 +0100 skrev ffnicol...@sfr.fr: > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -634,7 +634,7 @@ static int mxf_get_d10_aes3_packet(AVIOContext *pb, > AVStream *st, AVPacket *pkt, > for (; end_ptr - buf_ptr >= st->codecpar->ch_layout.nb_channels * 4;

[FFmpeg-devel] [PATCH] fate/libswresample: add a test downmixing with a custom order layout

2025-02-05 Thread James Almer
Signed-off-by: James Almer --- tests/fate/libswresample.mak | 8 tests/filtergraphs/custom_rematrix | 1 + 2 files changed, 9 insertions(+) create mode 100644 tests/filtergraphs/custom_rematrix diff --git a/tests/fate/libswresample.mak b/tests/fate/libswresample.mak index a1e5ab9

[FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-05 Thread Tomas Härdin
Seems reasonable to me and passes FATE /Tomas From ecc3459990f2871fd907f96fe66362b8fea41bd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Zeb=C3=BChr?= Date: Tue, 21 Nov 2023 14:16:49 +0100 Subject: [PATCH 8/8] Make mime-type award a bonus probe score This changes the default behaviour of ffm

[FFmpeg-devel] [PATCH 7/8] avformat/mp3dec: Subtract known padding from duration

2025-02-05 Thread Tomas Härdin
From 6dca5b958693588d74081e8fa29f05a5f257c841 Mon Sep 17 00:00:00 2001 From: Ulrik Mikaelsson Date: Tue, 22 Aug 2023 13:55:14 +0200 Subject: [PATCH 7/8] avformat/mp3dec: Subtract known padding from duration When an Info-tag is present, marking initial and trailing samples as padding, those sampl

[FFmpeg-devel] [PATCH 6/8] GOL-1361: Remove invalid CTTS sample_offset check

2025-02-05 Thread Tomas Härdin
I trust that ticket #385 has a FATE test these days /Tomas From 8c105c5953c494402749eb27d2eb6a7a2393f855 Mon Sep 17 00:00:00 2001 From: ekir Date: Tue, 18 Apr 2023 17:31:43 +0200 Subject: [PATCH 6/8] GOL-1361: Remove invalid CTTS sample_offset check We checked in this places: * In 8.6.1.3 of ISO

[FFmpeg-devel] [PATCH 4/8] avformat/flacdec: Return correct error-codes on read-failure

2025-02-05 Thread Tomas Härdin
From c81e350d5419cf02f029ce006d94f257bc18fb97 Mon Sep 17 00:00:00 2001 From: Ulrik Date: Thu, 26 Jan 2023 17:51:02 +0100 Subject: [PATCH 4/8] avformat/flacdec: Return correct error-codes on read-failure Forward errors from `avio_read` directly. When `avio_read` sees EOF before expected bytes ca

[FFmpeg-devel] [PATCH 5/8] rtmp: Set correct message stream id when writing as server

2025-02-05 Thread Tomas Härdin
This one is difficult to test. Any ideas? /Tomas From c8689abcbf9bf85e1f7775a347b6bc994679cb77 Mon Sep 17 00:00:00 2001 From: Jonathan Murray Date: Thu, 31 Mar 2022 16:23:17 +0200 Subject: [PATCH 5/8] rtmp: Set correct message stream id when writing as server rtmp_write is used both for writing

[FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-05 Thread Tomas Härdin
From e1c4dfa4cc7a574f6fac76c11591547d3cd90ad2 Mon Sep 17 00:00:00 2001 From: Mattias Wadman Date: Mon, 11 Oct 2021 15:38:13 +0200 Subject: [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata Will be used by mal to compare metadat md5 with decoded samples md5. Part of fixing https://

[FFmpeg-devel] [PATCH 2/8] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors

2025-02-05 Thread Tomas Härdin
From 18a64198487582e9ef3246e7490d919ee19af595 Mon Sep 17 00:00:00 2001 From: Jonathan Murray Date: Wed, 9 Jun 2021 12:00:24 +0200 Subject: [PATCH 2/8] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors WMA files that fail to decode due to incoherent block lengths and frame lengths

[FFmpeg-devel] [PATCH 1/8] avformat/http: Return EIO for prematurely broken connection

2025-02-05 Thread Tomas Härdin
Rebased and trimmed down Spotify patchset. Does not include the mfra or ID3v2 stuff since those are turning out to be bigger tasks /Tomas From c808ca473529ca952c42f00d12aa50ade38850d8 Mon Sep 17 00:00:00 2001 From: Ulrik Date: Mon, 27 Jul 2020 11:46:56 +0200 Subject: [PATCH 1/8] avformat/http: Re

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/hevc: Add alpha layer support

2025-02-05 Thread James Almer
On 12/15/2024 3:39 AM, Zhao Zhili wrote: From: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavcodec/hevc/refs.c| 10 +- 3 files changed, 82 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc/he

[FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

2025-02-05 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long' Fixes: 392672068/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6232335892152320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-05 Thread Jack Lau
Hello. I found one better method to fix this issue. Firstly, i think the problem caused by incorrectly setting enc_ctx->time_base, so i refer to the implementation in avcodec_open2() 361 #if FF_API_AVCTX_TIMEBASE 362if (avctx->framerate.num > 0 && avctx->framerate.den > 0) 363

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-05 Thread Jack Lau via ffmpeg-devel
From: Jack Lau The `dec_ctx->time_base` was incorrectly default set by avcodec_open2(), while `enc_ctx->time_base` was derived from `dec_ctx->framerate`. This mismatch could cause incorrect video duration in the output. This patch corrects the issue by adjusting the `enc_ctx->time_base` calcul