[FFmpeg-devel] [PATCH 2/2] avformat/seek: Remove always true condition

2025-01-23 Thread Zhao Zhili
From: Zhao Zhili --- libavformat/seek.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/libavformat/seek.c b/libavformat/seek.c index a7e5ac9a63..a096d5e5b3 100644 --- a/libavformat/seek.c +++ b/libavformat/seek.c @@ -664,6 +664,9 @@ int av_seek_frame

[FFmpeg-devel] [PATCH] avformat/seek: Remove dead code

2025-01-23 Thread Zhao Zhili
From: Zhao Zhili --- libavformat/seek.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/seek.c b/libavformat/seek.c index 9822f9d83d..a7e5ac9a63 100644 --- a/libavformat/seek.c +++ b/libavformat/seek.c @@ -697,10 +697,6 @@ int avformat_seek_file(AVFormatContext *s, int stream

Re: [FFmpeg-devel] [PATCH v4] avcodec/h264_mb: Fix tmp buffer overlap

2025-01-23 Thread Bin Peng
Hi, Michael, Should I add the attached bitstream to the FATE test? https://trac.ffmpeg.org/attachment/ticket/11357/inter_weighted_bipred2.264 Regards Bin Peng On 2024/12/24 15:49, Bin Peng wrote: > When decoding a bitstream with weighted-bipred enabled, > the results on ARM and x86 platforms m

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/nvenc: Enable recovery point SEI for intra refresh mode

2025-01-23 Thread Zhao Zhili
> On Jan 24, 2025, at 02:02, Timo Rothenpieler wrote: > > On 23.01.2025 15:17, Zhao Zhili wrote: >> From: Zhao Zhili >> Otherwise all frames can be dropped after seek without the >> output_corrupt/showall flags. >> --- >> libavcodec/nvenc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> diff -

Re: [FFmpeg-devel] [PATCH v2 3/2] avcodec/sanm: codec37 buffers are private

2025-01-23 Thread Michael Niedermayer
Hi Manuel On Tue, Jan 21, 2025 at 05:40:25PM +0100, Manuel Lauss wrote: > Ping? I see you are quite active on the sanm code, maybe you want to send a patch to add yourself to MAINTAINERS for sanm ? This would give you git write access and simplify your work with sanm thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH] libavcodec/hdrdec: accept "#?RGBE" header in addition to "#?RADIANCE"

2025-01-23 Thread Michael Niedermayer
On Fri, Jan 17, 2025 at 06:11:04PM +0300, Kirill Gavrilov wrote: > Some Radiance HDR image files in the wild have "#?RGBE" header, > which other image readers accept. > > Signed-off-by: Kirill Gavrilov > --- > libavcodec/hdrdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) should be

Re: [FFmpeg-devel] Subject: Request for Support of Cineon Log Transfer Function in FFmpeg

2025-01-23 Thread compn
On Thu, 23 Jan 2025 18:46:51 +0100 (CET), ATERstudio wrote: > Dear FFmpeg Development Team, > I hope this email finds you well. I am reaching out to request the addition > of support for the Cineon log transfer function in FFmpeg, specifically for > the DPX files that use this format. Currently

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-23 Thread Michael Niedermayer
Hi Kieran On Thu, Jan 23, 2025 at 09:54:36PM +, Kieran Kunhya via ffmpeg-devel wrote: > On Thu, 23 Jan 2025, 00:11 Michael Niedermayer, > wrote: > > > Hi Kieran > > > > On Wed, Jan 22, 2025 at 10:47:52PM +, Kieran Kunhya via ffmpeg-devel > > wrote: > > > On Wed, 22 Jan 2025, 20:36 Michae

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-23 Thread Kieran Kunhya via ffmpeg-devel
On Thu, 23 Jan 2025, 00:11 Michael Niedermayer, wrote: > Hi Kieran > > On Wed, Jan 22, 2025 at 10:47:52PM +, Kieran Kunhya via ffmpeg-devel > wrote: > > On Wed, 22 Jan 2025, 20:36 Michael Niedermayer, > > wrote: > > > > > This blocks disallowed extensions from probing > > > It also requires

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-22 21:18 +0100, Nicolas George wrote: > James Almer (12025-01-22): > > Ok, will implement a new struct. > > Thanks. > > I think this code would work: > > typedef struct AVSideDataParamChange > … > intmax_t end_padding; > } AVSideDataSomethingType; > > static const AVSideDataParam

Re: [FFmpeg-devel] [PATCH] avutil/aarch64/float_dsp_neon: Refactor ff_vector_fmul_add_neon

2025-01-23 Thread Krzysztof Pyrkosz via ffmpeg-devel
On Sun, Jan 19, 2025 at 10:57:57PM +0200, Martin Storsjö wrote: > On Sun, 19 Jan 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: > > > Removed a branch, unrolled loop. Speed increase bumped from 3.95 to 5.60. > > On what core is that? Please quote the actual output including the absolute > number

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-23 Thread Michael Niedermayer
On Wed, Jan 22, 2025 at 09:36:09PM +0100, Michael Niedermayer wrote: > This blocks disallowed extensions from probing > It also requires all available segments to have matching extensions to the > format > mpegts is treated independent of the extension > > It is recommended to set the whitelists

Re: [FFmpeg-devel] [PATCH v2] libavutil/avstring: av_match_list: Update API documentation

2025-01-23 Thread epirat07
On 23 Jan 2025, at 21:35, Alexander Strasser via ffmpeg-devel wrote: > Since av_match_list was added in commit 0d92b0d5f445d4f2 , this > function changed its semantics shortly after, especially with > commit 3c0b98dced394da3 . > > Signed-off-by: Alexander Strasser > --- > > Diff to v1: > * use

Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-23 Thread Abdulrahman Saber
On Thu, Jan 23, 2025 at 11:01 PM Alexander Strasser via ffmpeg-devel wrote: > Seems like your mail client/editor does it (automatically?) to avoid > overly long lines, which might be fine for email texts but isn't in > patches. > > Hope you can find the setting for easier contribution in the futur

Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
Hi Abdulrahman! I fixed up and tested your patch locally and your change looks fine :) Will include when it when I push my next batch of changes soon'ish. Depending on how it goes it will take a couple of days from now. For your information I will outline the broken parts inline below: On 2025-

Re: [FFmpeg-devel] [PATCH] libavutil/avstring: av_match_list: Update API documentation

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-22 23:19 +0100, epira...@gmail.com wrote: > > On 22 Jan 2025, at 22:59, Alexander Strasser via ffmpeg-devel wrote: > > > Since av_match_list was added in commit 0d92b0d5f445d4f2 , this > > function changed its semantics shortly after, especially with > > commit 3c0b98dced394da3 . > > > >

[FFmpeg-devel] [PATCH v2] libavutil/avstring: av_match_list: Update API documentation

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
Since av_match_list was added in commit 0d92b0d5f445d4f2 , this function changed its semantics shortly after, especially with commit 3c0b98dced394da3 . Signed-off-by: Alexander Strasser --- Diff to v1: * use @p as suggested by ePirat * clarify that the hint about demuxer names is about FFmpe

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-23 Thread Kieran Kunhya via ffmpeg-devel
> The FEC decoder works on the demuxer/transport layer and is > independent from the content layer. > > The FEC decoder parameters can be set by the user according to their > content settings to determine the delay incurred by buffering and > packet loss for a CBR content. A buffer of N packets do

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/nvenc: Enable recovery point SEI for intra refresh mode

2025-01-23 Thread Timo Rothenpieler
On 23.01.2025 15:17, Zhao Zhili wrote: From: Zhao Zhili Otherwise all frames can be dropped after seek without the output_corrupt/showall flags. --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 06e3fb81a4..68b1b661e4 1

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-23 Thread Romain Beauxis
Le mer. 22 janv. 2025 à 11:03, Kieran Kunhya a écrit : > > On Thu, Jan 16, 2025 at 8:15 PM Romain Beauxis > wrote: > > > > This patch implements the decoding logic for the FEC error- > > correction method described in the Pro-MPEG CoP #3-R2 FEC[1] > > > > We are still in the process of testing t

[FFmpeg-devel] Subject: Request for Support of Cineon Log Transfer Function in FFmpeg

2025-01-23 Thread ATERstudio
Dear FFmpeg Development Team, I hope this email finds you well. I am reaching out to request the addition of support for the Cineon log transfer function in FFmpeg, specifically for the DPX files that use this format. Currently, while FFmpeg supports other transfer functions like gamma 2.2 or 2

Re: [FFmpeg-devel] [PATCH v3] avfilter/setpts: add option to preserve framerate

2025-01-23 Thread Gyan Doshi
On 2025-01-23 09:29 pm, Ronald S. Bultje wrote: Hi, On Thu, Jan 23, 2025 at 2:09 AM Gyan Doshi wrote: In f121d95, the outlink framerate was unconditionally unset. This breaks/bloats outputs from CFR muxers unless the user explicitly set a sane framerate. And the most common invocation for s

Re: [FFmpeg-devel] [PATCH v3] avfilter/setpts: add option to preserve framerate

2025-01-23 Thread Ronald S. Bultje
Hi, On Thu, Jan 23, 2025 at 2:09 AM Gyan Doshi wrote: > In f121d95, the outlink framerate was unconditionally unset. > This breaks/bloats outputs from CFR muxers unless the user explicitly > set a sane framerate. And the most common invocation for setpts seen in > workflows, our docs and across

[FFmpeg-devel] [PATCH v3 1/3] avcodec/nvenc: Enable recovery point SEI for intra refresh mode

2025-01-23 Thread Zhao Zhili
From: Zhao Zhili Otherwise all frames can be dropped after seek without the output_corrupt/showall flags. --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 06e3fb81a4..68b1b661e4 100644 --- a/libavcodec/nvenc.c +++ b/libavc

[FFmpeg-devel] [PATCH v3 1/3] avcodec/nvenc: Enable recovery point SEI for intra refresh mode

2025-01-23 Thread Zhao Zhili
From: Zhao Zhili Otherwise all frames can be dropped after seek without the output_corrupt/showall flags. --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 06e3fb81a4..68b1b661e4 100644 --- a/libavcodec/nvenc.c +++ b/libavc

[FFmpeg-devel] [PATCH v3 3/3] avcodec/hevc: Add support for output_corrupt/showall flags

2025-01-23 Thread Zhao Zhili
From: Zhao Zhili Also handle gradual decoding refresh stream. --- I can't find a perfect hevc intra refresh stream. 1. x265 doesn't output useful recovery point SEI. It only output a single recovery point SEI with recovery_poc_cnt equal to 0 together with IDR. 2. With patch 1/3, nvenc output S

[FFmpeg-devel] [PATCH v3 2/3] avcodec/hevc: Parse recovery point SEI

2025-01-23 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 1 + libavcodec/hevc/sei.c | 16 libavcodec/hevc/sei.h | 7 +++ 3 files changed, 24 insertions(+) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index 3655ed0039..79dd63092c 100644 --- a/libavcod

[FFmpeg-devel] [PATCH] rtmpproto: Avoid rare crashes in the fail: codepath in rtmp_open

2025-01-23 Thread Martin Storsjö
When running the cleanup in rtmp_close on failures in rtmp_open, we can in rare cases end up using rt->playpath, assuming that it is still set. The crash could happen if we hit the fail codepath in rtmp_open while publishing (rt->is_input == 0) with rt->state set to a value > STATE_FCPUBLISH. Thi