[FFmpeg-devel] [PATCH v3] avfilter/setpts: add option to preserve framerate

2025-01-22 Thread Gyan Doshi
In f121d95, the outlink framerate was unconditionally unset. This breaks/bloats outputs from CFR muxers unless the user explicitly set a sane framerate. And the most common invocation for setpts seen in workflows, our docs and across the web is `PTS-STARTPTS` or others of the form `PTS+constant` wh

Re: [FFmpeg-devel] [PATCH] avfilter/setpts: add option to preserve framerate

2025-01-22 Thread Gyan Doshi
Pls. ignore. Typo corrected in v2 On 2025-01-23 11:03 am, Gyan Doshi wrote: In f121d95, the outlink framerate was unconditionally unset. This breaks/bloats outputs from CFR muxers unless the user explicitly set a sane framerate. And the most common invocation for setpts seen in workflows, our do

[FFmpeg-devel] [PATCH v2] avfilter/setpts: add option to preserve framerate

2025-01-22 Thread Gyan Doshi
In f121d95, the outlink framerate was unconditionally unset. This breaks/bloats outputs from CFR muxers unless the user explicitly set a sane framerate. And the most common invocation for setpts seen in workflows, our docs and across the web is `PTS-STARTPTS` or others of the form `PTS+constant` wh

Re: [FFmpeg-devel] [PATCH] libavcodec/hdrdec: accept "#?RGBE" header in addition to "#?RADIANCE"

2025-01-22 Thread kirill
Ping, would appreciate it, if somebody would comment / push the patch. --- Kirill Gavrilov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH] avcodec/svq1enc: restrict Altivec acceleration to big-endian POWER configurations

2025-01-22 Thread Sean McGovern
Hi, On Thu, Jan 16, 2025 at 8:17 PM Michael Niedermayer wrote: > > Hi > > On Thu, Jan 16, 2025 at 04:57:13PM -0500, Sean McGovern wrote: > > On Thu, Jan 16, 2025 at 4:30 PM Sean McGovern wrote: > > > > > > This was disabled in da60b99a8857d5ca236f32c1799a066e0135a866 and then > > > accidentally

[FFmpeg-devel] [PATCH] avfilter/setpts: add option to preserve framerate

2025-01-22 Thread Gyan Doshi
In f121d95, the outlink framerate was unconditionally unset. This breaks/bloats outputs from CFR muxers unless the user explicitly set a sane framerate. And the most common invocation for setpts seen in workflows, our docs and across the web is `PTS-STARTPTS` or others of the form `PTS+constant` wh

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-22 Thread Michael Niedermayer
Hi Kieran On Wed, Jan 22, 2025 at 10:47:52PM +, Kieran Kunhya via ffmpeg-devel wrote: > On Wed, 22 Jan 2025, 20:36 Michael Niedermayer, > wrote: > > > This blocks disallowed extensions from probing > > It also requires all available segments to have matching extensions to the > > format > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, 22 Jan 2025, 20:36 Michael Niedermayer, wrote: > This blocks disallowed extensions from probing > It also requires all available segments to have matching extensions to the > format > mpegts is treated independent of the extension > Potentially this is a stupid question but what stops an

Re: [FFmpeg-devel] [PATCH] libavutil/avstring: av_match_list: Update API documentation

2025-01-22 Thread epirat07
On 22 Jan 2025, at 22:59, Alexander Strasser via ffmpeg-devel wrote: > Since av_match_list was added in commit 0d92b0d5f445d4f2 , this > function changed its semantics shortly after, especially with > commit 3c0b98dced394da3 . > > Signed-off-by: Alexander Strasser > --- > libavutil/avstring.h

Re: [FFmpeg-devel] Democratization

2025-01-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Wednesday, January 22, 2025 9:51 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Democratization > > Michael Niedermayer (12025-01-21): > > You have worded

[FFmpeg-devel] [PATCH] libavutil/avstring: av_match_list: Update API documentation

2025-01-22 Thread Alexander Strasser via ffmpeg-devel
Since av_match_list was added in commit 0d92b0d5f445d4f2 , this function changed its semantics shortly after, especially with commit 3c0b98dced394da3 . Signed-off-by: Alexander Strasser --- libavutil/avstring.h | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v6 1/5] avutil: add hwcontext_amf.

2025-01-22 Thread epirat07
On 22 Jan 2025, at 20:32, Dmitrii Ovchinnikov wrote: > Adds hwcontext_amf, enabling a shared AMF context for encoders, > decoders, and AMF-based filters, without copy to the host memory. > Code also was tested in HandBrake. > > Benefits: > - Optimizations for direct video memory access from CP

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-22 Thread Nicolas George
Nicolas George (12025-01-22): > That limitation of side data is very annoying. We should get rid of it, > especially since it is not that hard. > > The issue is that side data has to be flat because its refcounting is > built on top of AVBufferRef when AVBufferRef if only good for flat data > (if

Re: [FFmpeg-devel] Is the GA democratic ?

2025-01-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Wednesday, January 22, 2025 9:01 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Is the GA democratic ? > > Michael Niedermayer (12025-01-21): > > Being a "

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-22 Thread Nicolas George
James Almer (12025-01-22): > Actually, i just realized i can't store an AVDictionary or a string in a > struct like this that's meant to be stored as side data. It has a to be a > flat array with no pointers to separate arrays. Hum, good point. That limitation of side data is very annoying. We sh

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-22 Thread James Almer
On 1/22/2025 5:18 PM, Nicolas George wrote: James Almer (12025-01-22): Ok, will implement a new struct. Thanks. I think this code would work: typedef struct AVSideDataParamChange … intmax_t end_padding; } AVSideDataSomethingType; Actually, i just realized i can't store an AVDicti

Re: [FFmpeg-devel] Democratization

2025-01-22 Thread Nicolas George
Michael Niedermayer (12025-01-21): > You have worded this well Thanks (assuming you are not saying it to the “+1”). > Id like to add that this matches my understanding of what maintainers should > be. (actual "leaders" in their areas) > > As side effect this would make things more scaleable too.

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add missing ISO/IEC 15444-4 conformance tests

2025-01-22 Thread Pierre-Anthony Lemieux
On Sat, Nov 9, 2024 at 5:40 PM Michael Niedermayer wrote: > > On Fri, Nov 08, 2024 at 01:09:34PM -0800, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > --- > > tests/fate/jpeg2000.mak | 122 ++- > > tests/ref/fate/jpeg2000dec-ds0_hm_15_b8 |

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Nicolas George
James Almer (12025-01-20): > Partial support for MV-HEVC, partial support for IAMF (no rendering, only > demuxing/muxing), partial support for tiled HEIF (no stitching), the new VVC > decoder that's afaik not 100% complete, a PTS reorder bsf that's missing > some edge cases and support for HEVC and

[FFmpeg-devel] [PATCH 1/2] Revert "avformat/mpegts: Add standard extension so hls can check in extension_picky mode"

2025-01-22 Thread Michael Niedermayer
The next commit implements the hls fix in a way that doesnt need this This reverts commit 54897da7ce8ae6e349cd56d0f11cb2404e264efa. --- libavformat/mpegts.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 1337aa12030..765bedec5cc 100644 --- a/l

[FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-22 Thread Michael Niedermayer
This blocks disallowed extensions from probing It also requires all available segments to have matching extensions to the format mpegts is treated independent of the extension It is recommended to set the whitelists correctly instead of depending on extensions, but this should help a bit, and thi

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-22 Thread Nicolas George
James Almer (12025-01-22): > Ok, will implement a new struct. Thanks. I think this code would work: typedef struct AVSideDataParamChange … intmax_t end_padding; } AVSideDataSomethingType; static const AVSideDataParamChange default = { ... }; AVSideDataParamChange pc; av_assert

Re: [FFmpeg-devel] Is the GA democratic ?

2025-01-22 Thread Nicolas George
Michael Niedermayer (12025-01-21): > Being a "member of the commuity" should give them a vote if you want to > call it a democracy in relation to the FFmpeg community At this point I think it would be very useful if you took the time to write down the reasons you think this whole thing is a good i

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-22 Thread James Almer
On 1/22/2025 4:49 PM, Nicolas George wrote: James Almer (12025-01-22): New fields can be added this way too. The reason i didn't make it a struct is that i wanted to introduce the least amount of new public defines/symbols, thus reusing the packet side data implementation. Let us make the pack

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-22 Thread Nicolas George
James Almer (12025-01-22): > New fields can be added this way too. The reason i didn't make it a struct > is that i wanted to introduce the least amount of new public > defines/symbols, thus reusing the packet side data implementation. Let us make the packet side data a struct too. This version is

[FFmpeg-devel] [PATCH v6 5/5] avcodec/amfenc: redesign to use hwcontext_amf.

2025-01-22 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov v3: cleanup code --- libavcodec/amfenc.c | 873 +-- libavcodec/amfenc.h | 34 +- libavcodec/amfenc_av1.c | 8 +- libavcodec/amfenc_h264.c | 6 +- libavcodec/amfenc_hevc.c | 6 +- 5 files changed, 305 insertions(+)

[FFmpeg-devel] [PATCH v6 4/5] doc/filters: Add documentation for AMF filters

2025-01-22 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 236 +++ 1 file changed, 236 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index b926b865ae..39f54f5e0c 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH v6 2/5] avcodec: add amfdec.

2025-01-22 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov v2: added encoder reinitialisation v3: use AMF_SURFACE_UNKNOWN to int decoder(ctx->output_format before) --- configure | 3 + libavcodec/Makefile| 7 +- libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v6 3/5] avfilter/scale_amf: Add AMF VPP & super resolution filters

2025-01-22 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: vpp_amf & sr_amf. Both filters are using AMF hardware acceleration. vpp_amf supports simple scaling algorithms & color conversion. sr_amf supports advanced scaling algorithms such as FSR & can be used for upscaling only. --- configure

[FFmpeg-devel] [PATCH v6 1/5] avutil: add hwcontext_amf.

2025-01-22 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, enabling a shared AMF context for encoders, decoders, and AMF-based filters, without copy to the host memory. Code also was tested in HandBrake. Benefits: - Optimizations for direct video memory access from CPU - Significant performance boost in full AMF pipelines with filte

Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-22 Thread Abdulrahman Saber
On Tue, Jan 14, 2025 at 2:02 PM Abdulrahman Saber wrote: > > Signed-off-by: abdo > --- > libavfilter/vf_signalstats.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c > index b1451cc465..9b6af8becd 100644 > -

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
> Can you please stop this "my way or no way" The irony is not lost on me of this sentence (from the person banning people, censoring people, creating paranoid theories about the GA). Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Thu, Jan 16, 2025 at 8:15 PM Romain Beauxis wrote: > > This patch implements the decoding logic for the FEC error- > correction method described in the Pro-MPEG CoP #3-R2 FEC[1] > > We are still in the process of testing this patch with our encoders but > I wanted to send it now in case it coul

Re: [FFmpeg-devel] Is the GA democratic ?

2025-01-22 Thread Michael Niedermayer
Hi On Tue, Jan 21, 2025 at 08:05:05PM -0300, James Almer wrote: > On 1/21/2025 6:10 PM, Michael Niedermayer wrote: > > Hi > > > > On Tue, Jan 21, 2025 at 02:53:36PM -0300, James Almer wrote: > > > On 1/21/2025 2:41 PM, Michael Niedermayer wrote: > > > > Hi > > > > > > > > As people likely know i

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 4:37 PM Michael Niedermayer wrote: > > Hi > > On Mon, Jan 20, 2025 at 03:00:17PM +, Kieran Kunhya via ffmpeg-devel > wrote: > [...] > > > Error recovery protocols are complicated - > > everything is complicated > > > > this project lacks > > experience in them > > The

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 4:53 PM Romain Beauxis wrote: > > Le mer. 22 janv. 2025 à 10:29, Kieran Kunhya via ffmpeg-devel > a écrit : > > > > On Wed, Jan 22, 2025 at 3:33 PM Michael Niedermayer > > wrote: > > > > > > On Mon, Jan 20, 2025 at 06:46:46AM +, Kieran Kunhya via ffmpeg-devel > > > w

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 4:37 PM Michael Niedermayer wrote: > > Hi > > On Mon, Jan 20, 2025 at 03:00:17PM +, Kieran Kunhya via ffmpeg-devel > wrote: > [...] > > > Error recovery protocols are complicated - > > everything is complicated > > > > this project lacks > > experience in them > > The

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Romain Beauxis
Le mer. 22 janv. 2025 à 10:29, Kieran Kunhya via ffmpeg-devel a écrit : > > On Wed, Jan 22, 2025 at 3:33 PM Michael Niedermayer > wrote: > > > > On Mon, Jan 20, 2025 at 06:46:46AM +, Kieran Kunhya via ffmpeg-devel > > wrote: > > > > > > > > > The data arrives on multiple sockets, leading to

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Michael Niedermayer
Hi On Mon, Jan 20, 2025 at 03:00:17PM +, Kieran Kunhya via ffmpeg-devel wrote: [...] > Error recovery protocols are complicated - everything is complicated > this project lacks > experience in them The project is made of many developers, and several of them do have experience in protocols

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 3:33 PM Michael Niedermayer wrote: > > On Mon, Jan 20, 2025 at 06:46:46AM +, Kieran Kunhya via ffmpeg-devel > wrote: > > > > > > > The data arrives on multiple sockets, leading to all sorts > > > > of opportunities for timing behavior and reordering issues. > > > > > >

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Michael Niedermayer
On Mon, Jan 20, 2025 at 06:46:46AM +, Kieran Kunhya via ffmpeg-devel wrote: > > > > > The data arrives on multiple sockets, leading to all sorts > > > of opportunities for timing behavior and reordering issues. > > > > how does this matter? > > > > There are routers that put traffic on a diffe

Re: [FFmpeg-devel] [PATCH] swscale/swscale: don't reject scaling when color parameters are not supported but conversion is not required

2025-01-22 Thread Niklas Haas
On Fri, 17 Jan 2025 22:38:03 -0300 James Almer wrote: > Values in csp, prim, trc, etc, are irrelevant if there's no conversion needed. > > Signed-off-by: James Almer > --- > ./ffmpeg -i https://0x0.st/8Hr_.mp4 -vf "scale=1920:1080" -f null - > > Fails without this patch, because swscale lacks con

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/wtvdec: Initialize buf

2025-01-22 Thread Michael Niedermayer
Hi Peter On Wed, Jan 22, 2025 at 07:02:07PM +1100, Peter Ross wrote: > On Tue, Jan 21, 2025 at 09:57:43PM +, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Thu Dec 26 02:53:45 2024 +0100| [17b019c517af26c6d2f0c6266938c60d36db1fa3] > > | committer: Michael

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-22 Thread James Almer
On 1/22/2025 12:13 AM, Lynne wrote: On 22/01/2025 11:53, James Almer wrote: Equivalent to the one from packet side data using AVSideDataParamChangeFlags, and will be used for the same purpose with encoders. Signed-off-by: James Almer ---   libavutil/frame.c |  1 +   libavutil/frame.h | 13 +

Re: [FFmpeg-devel] Regarding Git Tooling

2025-01-22 Thread Nicolas George
Marth64 (12025-01-20): > This is fine and your preferences are understandable. Everyone has > their tools of choice. > > That said, I did try Forgejo on a local instance today without > JavaScript and it was not a usable experience for a contributor. > I could do some limited functions but not rai

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-22 Thread Jerome Martinez
Le 17/01/2025 à 21:43, Michael Niedermayer a écrit : On Fri, Jan 17, 2025 at 12:38:02PM +0100, Jerome Martinez wrote: [...] Subject: [PATCH] avformat: add DAT demuxer breaks fate-cdxl-pal8-small I guess the probe function is not working as expected cdxl parser provides a read_probe value of

[FFmpeg-devel] [PATCH] ffv1dec: set f->state_transition for default range coder table

2025-01-22 Thread Lynne
The table is only set when f->ac is set to CUSTOM. Setting it for default range coder tables simplifies hardware accelerator code. --- libavcodec/ffv1dec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 46db9c..f5ccf41f38 10064

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/wtvdec: Initialize buf

2025-01-22 Thread Peter Ross
On Tue, Jan 21, 2025 at 09:57:43PM +, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Thu > Dec 26 02:53:45 2024 +0100| [17b019c517af26c6d2f0c6266938c60d36db1fa3] | > committer: Michael Niedermayer > > avformat/wtvdec: Initialize buf > > ff_parse_mpeg2_descript