Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvcdec: remove vvc prefix for x86 and riscv

Hi, other RISC-V assembly file names usually include the extensions being used, such as rvv, rvb, etc. How about naming them mc_rvv.S and sad_rvv.S? Nuo Mi 于2024年12月17日周二 11:59写道： > --- > libavcodec/riscv/vvc/Makefile | 6 +++--- > libavcodec/riscv/vvc/{vvcdsp_init.c => ds

Re: [FFmpeg-devel] Coverity access

On Sat, 21 Dec 2024 01:42:32 +0100, Michael Niedermayer wrote: > Hi > > On Thu, Dec 19, 2024 at 04:53:48PM -1000, compn wrote: > > On Thu, 19 Dec 2024 21:04:50 +0100, Michael Niedermayer wrote: > > if our goal is to attract new developers it would be better to invite > > person (using ffmpeg x ac

[FFmpeg-devel] [PATCH] ffmpeg_sched: return better error code

The existing code of 'No space left on device' leaves end users confused since the issue isn't of disk space. --- fftools/ffmpeg_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index 420d3f9ce9..e6d22063d7 100644 --- a/fft

Re: [FFmpeg-devel] [PATCH] lavc/riscv: vset macro for simplify if-else

Applied, Thank you, On Tue, Dec 17, 2024 at 12:04 PM wrote: > From: sunyuechi > > --- > libavcodec/riscv/h26x/asm.S | 78 + > 1 file changed, 18 insertions(+), 60 deletions(-) > > diff --git a/libavcodec/riscv/h26x/asm.S b/libavcodec/riscv/h26x/asm.S > index

Re: [FFmpeg-devel] [PATCH 2/2] aarch64/vvc: Add apply_bdof

On Tue, Dec 17, 2024 at 9:00 PM Martin Storsjö wrote: > On Tue, 3 Dec 2024, Zhao Zhili wrote: > > > From: Zhao Zhili > > > > Test on rpi 5 with gcc 12: > > > > apply_bdof_8_8x16_c: 7315.2 ( 1.00x) > > apply_bdof_8_8x16_neon: 1876.8 (

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

Hi Anton On Fri, Dec 20, 2024 at 06:24:46AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-12-19 20:52:39) > > This was a brave decission and IMO it was the correct decission. > > You saw people fighting, and you stepped between them to stop it. > > So what we have here is a serv

Re: [FFmpeg-devel] [PATCH] swscale/output: fix bilinear yuv2rgb chroma interpolation

On Tue, Dec 17, 2024 at 02:11:30PM +0100, Niklas Haas wrote: > From: Niklas Haas > > These functions were divided into two special cases; one assuming that > uvalpha == 0, and the other assuming that uvalpha == 2048. This worked fine > for simple 2x chroma upscaling but broke for e.g. yuv410p, no

Re: [FFmpeg-devel] [PATCH v2 4/8] avfilter/vf_scale*: strip metadata on size change

On Wed, Dec 04, 2024 at 03:51:05PM +0100, Niklas Haas wrote: > From: Niklas Haas > > --- > libavfilter/vf_scale.c| 2 ++ > libavfilter/vf_scale_cuda.c | 3 +++ > libavfilter/vf_scale_npp.c| 3 +++ > libavfilter/vf_scale_vaapi.c | 3 +++ > libavfilter/vf_scale_vt.c | 2 ++ > li

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

On Sat, Dec 21, 2024 at 12:02:06AM +0200, Jan Ekström wrote: > On Thu, Dec 19, 2024 at 4:34 AM Peter Ross wrote: > > > > h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for > > ff_aom_uninit_film_grain_params() > > Set LGTM. > > Thanks for testing/noticing this stuff. I ju

Re: [FFmpeg-devel] Coverity access

Hi On Thu, Dec 19, 2024 at 04:53:48PM -1000, compn wrote: > On Thu, 19 Dec 2024 21:04:50 +0100, Michael Niedermayer wrote: > > > Hi Kieran > > > > (also thx to compn for reminding me about this mail) > > > > On Fri, Dec 13, 2024 at 01:30:43AM +, Kieran Kunhya via ffmpeg-devel > > wrote: >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

On Thu, Dec 12, 2024 at 09:25:55AM +1100, Peter Ross wrote: > --- > Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts > during > playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. > > Sample .wav and ref flac file: >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

On Thu, Dec 19, 2024 at 4:34 AM Peter Ross wrote: > > h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for > ff_aom_uninit_film_grain_params() Set LGTM. Thanks for testing/noticing this stuff. I just happened to get an issue reported when someone disabled the HEVC decoder,

Re: [FFmpeg-devel] [PATCH 2/3] arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter

On Fri, Dec 20, 2024 at 07:53:33PM +0100, Michael Niedermayer wrote: > Hi Janne > > On Thu, Dec 19, 2024 at 10:12:22PM +0100, Janne Grunau wrote: > > This reduces the amount the horizontal filters read beyond the filter > > width to a consistent 1 pixel. The data is not used so this is usually > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

On 2024-12-20 19:38 +0100, Michael Niedermayer wrote: > On Fri, Dec 20, 2024 at 02:56:54PM +0100, Niklas Haas wrote: > > On Fri, 20 Dec 2024 08:37:40 -0500 "Ronald S. Bultje" > > wrote: [...] > > > Assuming you agree with that - which is hard to argue with - don't you > > > agree that for now,

Re: [FFmpeg-devel] [PATCH 2/3] arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter

Hi Janne On Thu, Dec 19, 2024 at 10:12:22PM +0100, Janne Grunau wrote: > This reduces the amount the horizontal filters read beyond the filter > width to a consistent 1 pixel. The data is not used so this is usually > not noticeable. It becomes a problem when the application allocates > frame buff

Re: [FFmpeg-devel] [PATCH 3/3] vp9: recon: Use emulated edge to prevent buffer overflows

Hi Janne On Thu, Dec 19, 2024 at 10:12:23PM +0100, Janne Grunau wrote: > The arm/aarch64 horizontal filter reads one additional pixel beyond what > the filter uses. This can become an issue if the application does not > allocate larger buffers than what's required for the pixel data. If the > moti

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

Hi Niklas On Fri, Dec 20, 2024 at 02:56:54PM +0100, Niklas Haas wrote: > On Fri, 20 Dec 2024 08:37:40 -0500 "Ronald S. Bultje" > wrote: > > Hi, > > > > On Thu, Dec 19, 2024 at 5:19 PM Michael Niedermayer > > wrote: > > > > > Hi > > > > > > On Wed, Dec 18, 2024 at 12:48:03PM -0500, Ronald S. Bul

Re: [FFmpeg-devel] computer failure, IRC and fate clients

Hi On Fri, Dec 20, 2024 at 02:49:45PM +0100, Michael Niedermayer wrote: > Hi all > > one of my computers died overnight > this had my IRC client and fate clients on it, so until its fixed dont expect > replies frm me on IRC > please send important things by mail > > about the box, its dead, fans

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264: fix stride calculation in slice_table for multi-slice field video deblocking

On Fri, Dec 20, 2024 at 5:20 AM Lingyi Kong wrote: > > fix for https://trac.ffmpeg.org/ticket/11360 > > Signed-off-by: Lingyi Kong > --- > libavcodec/h264_mb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264_mb.c b/libavcodec/h264_mb.c > index 4e94136313.

[FFmpeg-devel] [PATCH] Correct braces bug in ac3dsp_init.c for RISCV

Hi, This patch corrects a braces bug when RVV is disabled. Thanks, Gaspard Signed-off-by: Gaspard COURCHINOUX --- libavcodec/riscv/ac3dsp_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/riscv/ac3dsp_init.c b/libavcodec/riscv/ac3dsp_init.c index 24b3881

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

On Fri, 20 Dec 2024 08:37:40 -0500 "Ronald S. Bultje" wrote: > Hi, > > On Thu, Dec 19, 2024 at 5:19 PM Michael Niedermayer > wrote: > > > Hi > > > > On Wed, Dec 18, 2024 at 12:48:03PM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Wed, Dec 18, 2024 at 5:29 AM Niklas Haas wrote: > > > >

[FFmpeg-devel] computer failure, IRC and fate clients

Hi all one of my computers died overnight this had my IRC client and fate clients on it, so until its fixed dont expect replies frm me on IRC please send important things by mail about the box, its dead, fans not spinning, there is a light or 2 on the mainboard pressing the power button on the

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

Hi, On Fri, Dec 20, 2024 at 1:06 AM compn wrote: > On Fri, 20 Dec 2024 06:24:46 +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-12-19 20:52:39) > > > This was a brave decission and IMO it was the correct decission. > > > You saw people fighting, and you stepped between them t

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

Hi, On Thu, Dec 19, 2024 at 5:19 PM Michael Niedermayer wrote: > Hi > > On Wed, Dec 18, 2024 at 12:48:03PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Dec 18, 2024 at 5:29 AM Niklas Haas wrote: > > > > > On Wed, 18 Dec 2024 02:32:07 +0100 Michael Niedermayer < > > > mich...@niedermay

Re: [FFmpeg-devel] [PATCH 3/4] checkasm/sw_rgb: add tests for yuv2packed{1, 2, X}

On Thu, 19 Dec 2024 04:26:03 +0100 Michael Niedermayer wrote: > On Mon, Dec 16, 2024 at 12:48:19PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > --- > > tests/checkasm/sw_rgb.c | 316 > > 1 file changed, 316 insertions(+) > > seems breaking fat

[FFmpeg-devel] [PATCH v2 4/4] checkasm/sw_rgb: add alpToYV12 check

From: Niklas Haas Mirroring lumToYV12 and chrToYV12. Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- tests/checkasm/sw_rgb.c | 47 + 1 file changed, 47 insertions(+) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index 8

[FFmpeg-devel] [PATCH v2 3/4] checkasm/sw_rgb: add tests for yuv2packed{1, 2, X}

From: Niklas Haas Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- tests/checkasm/sw_rgb.c | 308 1 file changed, 308 insertions(+) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index 05370c1e41..82621b6adb 100644 --- a/

[FFmpeg-devel] [PATCH v2 2/4] checkasm/sw_scale: add test for yuv2nv12cX

From: Niklas Haas Mirroring yuv2yuvX. Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- tests/checkasm/sw_scale.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c index 3d229775d7..

[FFmpeg-devel] [PATCH v2 1/4] checkasm/sw_scale: add assertion for hscale assumption

From: Niklas Haas This code only checks hcScale. In practice this is not an issue because the function pointers should always be identical to hyScale for the same filter size. Add an assertion just to make sure this assumption never regresses. Signed-off-by: Niklas Haas Sponsored-by: Sovereign

[FFmpeg-devel] [PATCH] VAEncSequenceParameterBufferAV1 field bit_depth_minus8 not set

VAEncSequenceParameterBufferAV1 field bit_depth_minus8 is always set to 0 what makes problems with encoding of 10 (and more) bit formats. Signed-off-by: Grzegorz Rys --- libavcodec/vaapi_encode_av1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/v

[FFmpeg-devel] [PATCH v3] swscale/unscaled: correctly round yuv2yuv when not dithering

From: Niklas Haas We should at least bias towards the nearest integer, instead of always rounding down, when not dithering. This is a bit more correct. The FATE changes are only in the cases where sws_dither was explicitly set to "none", which is exactly as expected. Signed-off-by: Niklas Haas

Re: [FFmpeg-devel] [PATCH v2 04/17] swscale/utils: read HDR mastering metadata from AVFrame

On Thu, 19 Dec 2024 05:36:08 -0500 Leo Izen wrote: > > > On 12/16/24 6:17 AM, Niklas Haas wrote: > > From: Niklas Haas > > > > --- > > libswscale/utils.c | 22 ++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/libswscale/utils.c b/libswscale/utils.c > > index 2d8

Re: [FFmpeg-devel] [PATCH v2 12/17] swscale/csputils: add internal colorspace math helpers

On Thu, 19 Dec 2024 19:17:52 +0100 Michael Niedermayer wrote: > Hi > > On Mon, Dec 16, 2024 at 12:17:33PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > Logic is, for the most part, a straight port of similar logic in > > liplacebo's colorspace.c, with some general edits and refactors.

[FFmpeg-devel] [PATCH v2] swscale/unscaled: add pal8 -> gbr(a)p special converter

From: Niklas Haas Fixes: ticket #9520 Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- libswscale/swscale.c | 8 libswscale/swscale_unscaled.c | 81 ++- 2 files changed, 87 insertions(+), 2 deletions(-) diff --git a/libswscale/swsc

Re: [FFmpeg-devel] [PATCH] swscale/unscaled: add pal8 -> gbr(a)p special converter

On Thu, 19 Dec 2024 22:34:05 -0300 James Almer wrote: > On 12/18/2024 11:24 AM, Niklas Haas wrote: > > From: Niklas Haas > > > > Fixes: ticket #9520 > > Signed-off-by: Niklas Haas > > Sponsored-by: Sovereign Tech Fund > > --- > > libswscale/swscale.c | 2 + > > libswscale/swscale_un