Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/v4l2: use libdrm

2024-12-17 Thread Zhao Zhili
> On Dec 18, 2024, at 12:23, Scott Theisen wrote: > > On 12/17/24 11:10, Zhao Zhili wrote: >>> On Dec 17, 2024, at 06:48, Scott Theisen wrote: >>> >>> On 12/15/24 22:15, Zhao Zhili wrote: > On Dec 15, 2024, at 12:14, Scott Theisen wrote: > > Based on patches by Lukas Rusak from >

[FFmpeg-devel] [PATCH] avcodec/cuviddec: Fix missing HW_CONFIG_METHOD_HW_FRAMES_CTX flag

2024-12-17 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/cuviddec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 3fae9c12eb..502bcc7fc2 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -1162,6 +1162,7 @@ static const AVCodecHWConfigInternal *con

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-17 Thread Lynne via ffmpeg-devel
On 18/12/2024 14:40, Peter Ross wrote: On Wed, Dec 18, 2024 at 02:28:26PM +0900, Lynne via ffmpeg-devel wrote: On 16/12/2024 20:00, Peter Ross wrote: since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c depends on golomb vlc tables. --- i often build with --disable-all an

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-17 Thread Peter Ross
On Wed, Dec 18, 2024 at 02:28:26PM +0900, Lynne via ffmpeg-devel wrote: > > > On 16/12/2024 20:00, Peter Ross wrote: > > since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c > > depends on golomb vlc tables. > > --- > > i often build with --disable-all and only turn on the co

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-17 Thread Lynne via ffmpeg-devel
On 16/12/2024 20:00, Peter Ross wrote: since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c depends on golomb vlc tables. --- i often build with --disable-all and only turn on the components that i am working on. this dependency would otherwise go unnoticed since many codec

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/v4l2: use libdrm

2024-12-17 Thread Scott Theisen
On 12/17/24 11:10, Zhao Zhili wrote: On Dec 17, 2024, at 06:48, Scott Theisen wrote: On 12/15/24 22:15, Zhao Zhili wrote: On Dec 15, 2024, at 12:14, Scott Theisen wrote: Based on patches by Lukas Rusak from https://github.com/lrusak/FFmpeg/commits/v4l2-drmprime-v4 libavcodec: v4l2m2m: output

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

2024-12-17 Thread Michael Niedermayer
Hi On Tue, Dec 17, 2024 at 10:31:42AM +0100, Niklas Haas wrote: > On Tue, 17 Dec 2024 01:48:02 +0100 Michael Niedermayer > wrote: > > Hi > > > > On Mon, Dec 16, 2024 at 02:57:53PM +0100, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > This is not a good way of generating a PAL8 output. >

[FFmpeg-devel] [PATCH v2 15/15] fate/flvenc: add test for multitrack flv

2024-12-17 Thread Timo Rothenpieler
--- tests/fate/flvenc.mak | 4 + tests/ref/fate/enhanced-flv-multitrack | 526 + 2 files changed, 530 insertions(+) create mode 100644 tests/ref/fate/enhanced-flv-multitrack diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak index e3703a8cc5..7b

Re: [FFmpeg-devel] [PATCH 06/14] avformat/flvenc: refactor fourcc writing

2024-12-17 Thread Timo Rothenpieler
On 15.12.2024 23:41, Michael Niedermayer wrote: Hi Timo On Thu, Dec 12, 2024 at 08:55:31PM +0100, Timo Rothenpieler wrote: --- libavformat/flvenc.c | 96 ++-- 1 file changed, 47 insertions(+), 49 deletions(-) diff --git a/libavformat/flvenc.c b/libavf

Re: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_encode: Query surface alignment

2024-12-17 Thread Timo Rothenpieler
On 18.11.2024 16:47, David Rosca wrote: On Tue, Oct 22, 2024 at 5:28 PM David Rosca wrote: It needs to create temporary config to query surface attribute. --- Ping. applied with slight alteration to patch 2. Thanks! ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-17 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-16 22:02 -0500, Leo Izen wrote: > On 12/16/24 5:50 PM, Michael Niedermayer wrote: [...] > > > (e): Find a input that encodes to max 2 variants and store 2 checksums > > Doesn't fix the problem, which is that need to be aware of all the known > variants and create hacks to work with them

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/v4l2: use libdrm

2024-12-17 Thread Zhao Zhili
> On Dec 17, 2024, at 06:48, Scott Theisen wrote: > > On 12/15/24 22:15, Zhao Zhili wrote: >> >>> On Dec 15, 2024, at 12:14, Scott Theisen wrote: >>> >>> Based on patches by Lukas Rusak from >>> https://github.com/lrusak/FFmpeg/commits/v4l2-drmprime-v4 >>> >>> libavcodec: v4l2m2m: output AVD

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

2024-12-17 Thread Jean-Baptiste Kempf
Hello, On Tue, 17 Dec 2024, at 13:31, Anton Khirnov wrote: > at [1], the winning committee is: > * Martin Storsjö > * Michael Niedermayer > * Anton Khirnov > * Niklas Haas > * Jan Ekström Congratulations. jbk -- Jean-Baptiste Kempf - President +33 672 704 734 https://jbkempf.com/

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

2024-12-17 Thread Michael Niedermayer
Hi On Tue, Dec 17, 2024 at 01:31:12PM +0100, Anton Khirnov wrote: > Hi all, > the poll has concluded, with 30 votes out of 52. Results are available > at [1], the winning committee is: > * Martin Storsjö > * Michael Niedermayer > * Anton Khirnov > * Niklas Haas > * Jan Ekström > > Raw ballots in

[FFmpeg-devel] [PATCH v2] swscale/unscaled: correctly round yuv2yuv when not dithering

2024-12-17 Thread Niklas Haas
From: Niklas Haas We should at least bias towards the nearest integer, instead of always rounding down, when not dithering. This is a bit more correct. Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- libswscale/swscale_unscaled.c | 20 +++- 1 file changed, 11 i

Re: [FFmpeg-devel] [PATCH v3] avformat: add AV1 RTP depacketizer and packetizer

2024-12-17 Thread Tristan Matthews via ffmpeg-devel
Hi, > I see. I've put the code in an #if block, so you can try if > > it makes a difference to anything you may encounter. > > The spec says: https://aomediacodec.github.io/av1-spec/#ordering-of-obus > > "Sequence header OBUs may appear in any order within a coded video > sequence. Within a parti

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amfenc: B-Frame support for av1_amf encoder.

2024-12-17 Thread Dmitrii Ovchinnikov
If there are no comments, I’ll merge it in a few days. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubs

Re: [FFmpeg-devel] [PATCH 2/2] avutil/mem_internal: Don't include stdalign.h on MSVC

2024-12-17 Thread Martin Storsjö
On Tue, 17 Dec 2024, Hendrik Leppkes wrote: On Tue, Dec 17, 2024 at 2:44 PM Zhao Zhili wrote: > On Dec 17, 2024, at 21:13, Martin Storsjö wrote: > > It's currently actually not used in MSVC builds, since > 6e49b8699657b808b7dc80033f2c3f2d0e029fa3. > > Older versions of MSVC (or, in particu

Re: [FFmpeg-devel] [PATCH 2/2] avutil/mem_internal: Don't include stdalign.h on MSVC

2024-12-17 Thread Hendrik Leppkes
On Tue, Dec 17, 2024 at 2:44 PM Zhao Zhili wrote: > > > > > On Dec 17, 2024, at 21:13, Martin Storsjö wrote: > > > > It's currently actually not used in MSVC builds, since > > 6e49b8699657b808b7dc80033f2c3f2d0e029fa3. > > > > Older versions of MSVC (or, in particular, older versions of UCRT) > >

[FFmpeg-devel] [PATCH 1/2] swscale/unscaled: correctly round yuv2yuv when not dithering

2024-12-17 Thread Niklas Haas
From: Niklas Haas We should at least bias towards the nearest integer, instead of always rounding down, when not dithering. This is a bit more correct. Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- libswscale/swscale_unscaled.c | 20 +++- 1 file changed, 11 i

Re: [FFmpeg-devel] [PATCH 2/2] swscale/unscaled: remove redundant subtraction

2024-12-17 Thread Niklas Haas
On Tue, 17 Dec 2024 15:27:41 +0100 Niklas Haas wrote: > From: Niklas Haas > > tmp is already right-shifted to dst_depth, so tmp >> dst_depth is always 0. This is not true in the case of overflow. Dropping this commit. > > Signed-off-by: Niklas Haas > Sponsored-by: Sovereign Tech Fund > --- >

[FFmpeg-devel] [PATCH 2/2] swscale/unscaled: remove redundant subtraction

2024-12-17 Thread Niklas Haas
From: Niklas Haas tmp is already right-shifted to dst_depth, so tmp >> dst_depth is always 0. Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- libswscale/swscale_unscaled.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libswscale/swscale

Re: [FFmpeg-devel] [PATCH 2/2] avutil/mem_internal: Don't include stdalign.h on MSVC

2024-12-17 Thread Zhao Zhili
> On Dec 17, 2024, at 21:13, Martin Storsjö wrote: > > It's currently actually not used in MSVC builds, since > 6e49b8699657b808b7dc80033f2c3f2d0e029fa3. > > Older versions of MSVC (or, in particular, older versions of UCRT) > don't have stdalign.h; it's available since WinSDK 10.0.22000.0, >

Re: [FFmpeg-devel] [PATCH 1/2] aarch64: vvc: Fix building the dmvr_hv assembly with older MSVC versions

2024-12-17 Thread Zhao Zhili
> On Dec 17, 2024, at 21:13, Martin Storsjö wrote: > > Explicitly use ldur for unaligned offsets; newer versions of > armasm64 implicitly convert ldr to ldur as necessary, but older > versions require it explicitly written out. > > This fixes these build errors: > >ffmpeg\libavcodec\aarch

[FFmpeg-devel] [PATCH 1/2] aarch64: vvc: Fix building the dmvr_hv assembly with older MSVC versions

2024-12-17 Thread Martin Storsjö
Explicitly use ldur for unaligned offsets; newer versions of armasm64 implicitly convert ldr to ldur as necessary, but older versions require it explicitly written out. This fixes these build errors: ffmpeg\libavcodec\aarch64\vvc\inter.o.asm(2039) : error A2518: operand 2: Memory offset

[FFmpeg-devel] [PATCH 2/2] avutil/mem_internal: Don't include stdalign.h on MSVC

2024-12-17 Thread Martin Storsjö
It's currently actually not used in MSVC builds, since 6e49b8699657b808b7dc80033f2c3f2d0e029fa3. Older versions of MSVC (or, in particular, older versions of UCRT) don't have stdalign.h; it's available since WinSDK 10.0.22000.0, shipped along with MSVC 2022 17.4 and newer. With this change, ffmpe

Re: [FFmpeg-devel] [PATCH 04/14] avformat/flvenc: remove !size check for audio packets

2024-12-17 Thread Anton Khirnov
Quoting James Almer (2024-12-16 00:13:43) > On 12/14/2024 5:49 PM, Timo Rothenpieler wrote: > > On 14.12.2024 10:16, Anton Khirnov wrote: > >> This could use some explanation. > > > > I unfortunately don't remember the exact reason, but it ran into this > > check in normal operation, and empty au

[FFmpeg-devel] [PATCH] swscale/output: fix bilinear yuv2rgb chroma interpolation

2024-12-17 Thread Niklas Haas
From: Niklas Haas These functions were divided into two special cases; one assuming that uvalpha == 0, and the other assuming that uvalpha == 2048. This worked fine for simple 2x chroma upscaling but broke for e.g. yuv410p, non-centered chroma, or other special cases that involved non-aligned chr

Re: [FFmpeg-devel] [PATCH 02/14] avformat/flvdec: add support for demuxing multi-track FLV

2024-12-17 Thread Anton Khirnov
Quoting Timo Rothenpieler (2024-12-14 22:48:17) > On 14.12.2024 10:17, Anton Khirnov wrote: > > Quoting Timo Rothenpieler (2024-12-12 20:55:27) > >> From: Dennis Sädtler > >> > >> Based on enhanced-rtmp v2 spec published by Veovera: > >> https://veovera.github.io/enhanced-rtmp/docs/enhanced/enhanc

[FFmpeg-devel] [PATCH 2/2] tests/swscale: allow nonzero positive return codes from sws_scale_frame()

2024-12-17 Thread Niklas Haas
From: Niklas Haas See previous commit. --- libswscale/tests/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c index 3ed00f90a8..2e83197694 100644 --- a/libswscale/tests/swscale.c +++ b/libswscale/tests/swscale.c

[FFmpeg-devel] [PATCH 1/2] swscale: fix documentation of sws_scale_frame()

2024-12-17 Thread Niklas Haas
From: Niklas Haas Since its introduction, this function has claimed to return 0 on success, yet never actually did so (until the introduction of the new graph based API). It always returned the number of scaled lines, and continues to do so. To avoid confusion, but also avoid regressing possible

Re: [FFmpeg-devel] [PATCH 2/2] aarch64/vvc: Add apply_bdof

2024-12-17 Thread Martin Storsjö
On Tue, 3 Dec 2024, Zhao Zhili wrote: From: Zhao Zhili Test on rpi 5 with gcc 12: apply_bdof_8_8x16_c: 7315.2 ( 1.00x) apply_bdof_8_8x16_neon: 1876.8 ( 3.90x) apply_bdof_8_16x8_c: 7170.5 ( 1.00x) a

Re: [FFmpeg-devel] [PATCH v1] aarch64/avc: Fix ff_pred16x16_plane_neon_10

2024-12-17 Thread Martin Storsjö
On Fri, 13 Dec 2024, Bin Peng wrote: Fix test failure on aarch64: ./tests/checkasm/checkasm --test=h264pred 367840 Signed-off-by: Peng Bin --- libavcodec/aarch64/h264pred_neon.S | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/aarch64/h264pred_neo

Re: [FFmpeg-devel] [PATCH v1] lavc/aarch64: Fix ff_pred8x8_plane_neon_10

2024-12-17 Thread Martin Storsjö
On Mon, 16 Dec 2024, Bin Peng wrote: Fix test failure on aarch64: ./tests/checkasm/checkasm --test=h264pred 479612 The mismatch between neon and C functions can also be reproduced using the following bitstream and command line. wget https://streams.videolan.org/ffmpeg/incoming/intra8x8pred_

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

2024-12-17 Thread Anton Khirnov
Hi all, the poll has concluded, with 30 votes out of 52. Results are available at [1], the winning committee is: * Martin Storsjö * Michael Niedermayer * Anton Khirnov * Niklas Haas * Jan Ekström Raw ballots in CSV format are attached for posterity. CCing root - please update the tc@ mailbox. [1

Re: [FFmpeg-devel] [PATCH v2] avutil/vulkan_glslang: Fix build failure

2024-12-17 Thread Lynne via ffmpeg-devel
On 17/12/2024 15:55, Zhao Zhili wrote: From: Zhao Zhili compile_only isn't available until 13.1.0. Let default initialization set it to zero, so the code works with version before and after 13.1.0. --- libavutil/vulkan_glslang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [FFmpeg-devel] [PATCH] swscale: use 16-bit intermediate precision for RGB/XYZ conversion

2024-12-17 Thread Niklas Haas
On Tue, 17 Dec 2024 00:36:13 +0100 Michael Niedermayer wrote: > Hi > > On Mon, Dec 16, 2024 at 02:56:07PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > The current logic uses 12-bit linear light math, which is woefully > > insufficient > > and leads to nasty postarization artifacts. T

Re: [FFmpeg-devel] [PATCH v2_2 6/6] lavc/vvc_mc R-V V sad

2024-12-17 Thread flow gg
> Don't clobber v8 here. > Use vsub.vv here to avoid the sequential dependency. Thanks, I will update later > Are you sure this does not require tail-undisturbed mode? I think you're > setting tail-agnostic mode up. I’m not sure if I understood correctly. My understanding is that tail-undisturbe

Re: [FFmpeg-devel] [PATCH 3/4] checkasm/sw_rgb: add tests for yuv2packed{1, 2, X}

2024-12-17 Thread Niklas Haas
On Mon, 16 Dec 2024 12:48:19 +0100 Niklas Haas wrote: > From: Niklas Haas > > --- > tests/checkasm/sw_rgb.c | 316 > 1 file changed, 316 insertions(+) > > diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c > index 05370c1e41..3b2dffc423 100644

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

2024-12-17 Thread Niklas Haas
On Tue, 17 Dec 2024 01:48:02 +0100 Michael Niedermayer wrote: > Hi > > On Mon, Dec 16, 2024 at 02:57:53PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > This is not a good way of generating a PAL8 output. > > of course not > > but this breaks fate and features It doesn't really break a