On Tue, Dec 17, 2024 at 2:44 PM Zhao Zhili <quinkblack-at-foxmail....@ffmpeg.org> wrote: > > > > > On Dec 17, 2024, at 21:13, Martin Storsjö <mar...@martin.st> wrote: > > > > It's currently actually not used in MSVC builds, since > > 6e49b8699657b808b7dc80033f2c3f2d0e029fa3. > > > > Older versions of MSVC (or, in particular, older versions of UCRT) > > don't have stdalign.h; it's available since WinSDK 10.0.22000.0, > > shipped along with MSVC 2022 17.4 and newer. > > > > With this change, ffmpeg can still be built with MSVC 2019. > > LGTM. I’m shocked that a not-so-outdated version of MSVC doesn’t have > stdalign.h. >
According to the documentation I found, 2019 16.8 should have introduced support for C11/C17 and stdalign.h In fact I can confirm that the ucrt of 10.0.20348.0 contains it, which is the latest Windows 10 SDK, any newer ones are branded Windows 11. Although a standard installation of 2019 might be using an older Windows SDK, I'm not sure what it installs by default these days. In any case, no reason to include the header if its not used for the moment. So LGTM as well. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
