Re: [FFmpeg-devel] [PATCH] avformat/mpegts: correctly skip TP_extra_header in m2ts

2024-12-06 Thread Hendrik Leppkes
On Sat, Nov 30, 2024 at 8:30 PM llyyr wrote: > > On 8/8/24 1:44 AM, llyyr wrote: > > On 6/7/24 1:29 PM, Hendrik Leppkes wrote: > >> On Fri, Jun 7, 2024 at 9:47 AM Hendrik Leppkes > >> wrote: > >>> > >>> On Mon, May 27, 2024 at 3:47 PM llyyr wrote: > > instead of just resyncing and skip

Re: [FFmpeg-devel] [PATCH] avformat/movenc: log stream index for invalid pkt duration

2024-12-06 Thread Gyan Doshi
On 2024-12-06 09:58 pm, Marth64 wrote: LGTM Thanks. Pushed as 914f89dbc61781eab00c05919b552b3170517e16 Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit lin

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: use dvdclut for YUV to RGB conversion of DVD subtitle palettes

2024-12-06 Thread Marth64
Will push on v3 Sunday ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/vvc decode: ALF filtering without CC-ALF

2024-12-06 Thread Nuo Mi
On Wed, Dec 4, 2024 at 5:20 AM Chris Warrington via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > Nuo Mi wrote: > > This will introduce two writes for all blocks, even if there is no CC > ALF. > How about checking the sps_ccalf_enabled_flag in ff_vvc_alf_filter? > > That makes sense too, but I'

Re: [FFmpeg-devel] [PATCH 3/6] lavc/vvc: Store MIP information over entire CU area

2024-12-06 Thread Nuo Mi
On Wed, Dec 4, 2024 at 2:09 AM Frank Plowman wrote: > Hi, > > Thanks for your review. > > On 03/12/2024 10:04, Nuo Mi wrote: > > Hi Frank, > > Thank you for the patch > > > > On Sat, Nov 30, 2024 at 8:13 PM Frank Plowman > wrote: > > > >> On 30/11/2024 06:46, Nuo Mi wrote: > >>> On Fri, Nov 29,

Re: [FFmpeg-devel] [PATCH] tests/swscale: fix sscanf return value check

2024-12-06 Thread Michael Niedermayer
On Wed, Dec 04, 2024 at 11:43:47AM +0100, Niklas Haas wrote: > From: Niklas Haas > > We only parse 12 values, so this check always failed. Regression caused by > a change to the print format. > > Fixes: 59c39a79cafdcb46972380aac5644f84059cd2a8 > Signed-off-by: Niklas Haas > Sponsored-by: Sovere

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-06 Thread Michael Niedermayer
Hi On Sun, Dec 01, 2024 at 09:13:56PM +0100, Alexander Strasser via ffmpeg-devel wrote: > This is a fixed up version of the series I sent before. > > This worked for me on Ubuntu 20.04 but probably will break > with older zlib versions as Hendrik pointed out in the > previous thread. Either we m

[FFmpeg-devel] [PATCH v2] avfilter/af_ashowinfo: fix scaling factor of replaygain peak values

2024-12-06 Thread Kacper Michajłow
Commit 8542f9c4f17125d483c40c0c5723842f1c982f81 changed replaygain peak values to use 100k instead of UINT32_MAX as peak, with possibility of overflow. af_ashowinfo was never updated to reflect this, so we update it now. Fixes: 8542f9c4f17125d483c40c0c5723842f1c982f81 Signed-off-by: Kacper Michajł

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/tests/color_utils: add tests for av_csp_itu_eotf

2024-12-06 Thread Michael Niedermayer
Hi On Thu, Dec 05, 2024 at 11:28:58AM +, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas | Mon Nov 25 14:10:46 > 2024 +0100| [7b73ea501dc738c52daf2a2fef0c41b4ce95928f] | committer: Niklas > Haas > > avutil/tests/color_utils: add tests for av_csp_itu_eotf > > > http://git.videol

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/csp: add av_csp_trc_inv_from_id()

2024-12-06 Thread Michael Niedermayer
Hi On Thu, Dec 05, 2024 at 11:28:54AM +, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas | Mon Nov 25 13:35:34 > 2024 +0100| [bf0a6c484ffab9f157db7ee7c8a0f59df077] | committer: Niklas > Haas > > avutil/csp: add av_csp_trc_inv_from_id() > > Mathematical inverse of av_csp_trc

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_scale: switch to new swscale API

2024-12-06 Thread Michael Niedermayer
Hi On Fri, Dec 06, 2024 at 02:40:06PM +0100, Niklas Haas wrote: > On Fri, 06 Dec 2024 14:31:43 +0100 Michael Niedermayer > wrote: > > Hi > > > > On Mon, Nov 25, 2024 at 10:11:49AM +, Niklas Haas wrote: > > > ffmpeg | branch: master | Niklas Haas | Fri Jun 28 > > > 21:42:23 2024 +0200| [04c

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/rv40dsp: fix RISC-V chroma_mc

2024-12-06 Thread Rémi Denis-Courmont
Le 6 décembre 2024 13:19:29 GMT+01:00, Niklas Haas a écrit : >On Thu, 05 Dec 2024 21:41:51 +0800 uk7b-at-foxmail@ffmpeg.org wrote: >> From: sunyuechi >> >> --- >> libavcodec/riscv/rv40dsp_rvv.S | 116 ++--- >> 1 file changed, 78 insertions(+), 38 deletions(-) >>

Re: [FFmpeg-devel] Decoding performance -f rawvideo pipe:1 vs BMP images output

2024-12-06 Thread Clément Péron
Hi, On Fri, 6 Dec 2024 at 18:55, Clément Péron wrote: > > Hi, > > I am trying to convert a RTSP stream to a series of frames that I send > to a stdout PIPE with a low latency . > > I first tried this command. > > "ffmpeg -hwaccel cuda -flags +low_delay -fflags +nobuffer -nostats > -debug_ts -re -

[FFmpeg-devel] Decoding performance -f rawvideo pipe:1 vs BMP images output

2024-12-06 Thread Clément Péron
Hi, I am trying to convert a RTSP stream to a series of frames that I send to a stdout PIPE with a low latency . I first tried this command. "ffmpeg -hwaccel cuda -flags +low_delay -fflags +nobuffer -nostats -debug_ts -re -rtsp_flags prefer_tcp -rtsp_transport tcp -i RTSP_STREAM -f rawvideo -fps

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-06 Thread Tristan Matthews via ffmpeg-devel
Hi (also apologies if my client mangles the inline version of the patch, it's the first time I've tried to review an attached patch with it)... On Monday, December 2nd, 2024 at 9:57 AM, Chris Hodges wrote: > Hi, > > On 11/25/24 18:47, Tristan Matthews via ffmpeg-devel wrote: > > > One nit I'

Re: [FFmpeg-devel] [PATCH] avformat/movenc: log stream index for invalid pkt duration

2024-12-06 Thread Marth64
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 10/16] avfilter/vf_scale: strip metadata when changing colorspace

2024-12-06 Thread Leo Izen
On 12/6/24 9:32 AM, Niklas Haas wrote: From: Niklas Haas This is no longer relevant after a change in color space. --- libavfilter/vf_scale.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index e33617468a..a56d452c6c 1006

Re: [FFmpeg-devel] [PATCH v2 11/16] swscale/csputils: add internal colorspace math helpers

2024-12-06 Thread Leo Izen
On 12/6/24 9:32 AM, Niklas Haas wrote: From: Niklas Haas Logic is, for the most part, a straight port of similar logic in liplacebo's colorspace.c, with some general edits and refactors. --- libswscale/Makefile | 1 + libswscale/csputils.c | 412 +++

[FFmpeg-devel] [PATCH v2 04/16] swscale/utils: read HDR mastering metadata from AVFrame

2024-12-06 Thread Niklas Haas
From: Niklas Haas --- libswscale/utils.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libswscale/utils.c b/libswscale/utils.c index 182f92396a..3d3fcadacc 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -46,6 +46,7 @@ #include "libavutil/imgutils.h" #incl

[FFmpeg-devel] [PATCH v2 11/16] swscale/csputils: add internal colorspace math helpers

2024-12-06 Thread Niklas Haas
From: Niklas Haas Logic is, for the most part, a straight port of similar logic in liplacebo's colorspace.c, with some general edits and refactors. --- libswscale/Makefile | 1 + libswscale/csputils.c | 412 ++ libswscale/csputils.h | 111

[FFmpeg-devel] [PATCH v2 10/16] avfilter/vf_scale: strip metadata when changing colorspace

2024-12-06 Thread Niklas Haas
From: Niklas Haas This is no longer relevant after a change in color space. --- libavfilter/vf_scale.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index e33617468a..a56d452c6c 100644 --- a/libavfilter/vf_scale.c +++ b/libavfil

[FFmpeg-devel] [PATCH v2 12/16] swscale/cms: add color management subsystem

2024-12-06 Thread Niklas Haas
From: Niklas Haas The underlying color mapping logic was ported as straightforwardly as possible from libplacebo, although the API and glue code has been very heavily refactored / rewritten. In particular, the generalization of gamut mapping methods is replaced by a single ICC intent selection, a

[FFmpeg-devel] [PATCH v2 09/16] avfilter/vf_scale: add colorspace and transfer property options

2024-12-06 Thread Niklas Haas
From: Niklas Haas In the long run, it would be ideal if we could add these to the avfilter negotiation as well, but for now, this is a good start. --- doc/filters.texi | 56 +++ libavfilter/vf_scale.c | 75 +- 2 files chan

[FFmpeg-devel] [PATCH v2 07/16] swscale/utils: fix XYZ primaries tagging

2024-12-06 Thread Niklas Haas
From: Niklas Haas Swscale currently handles XYZ by embedding a forced conversion to BT.709 RGB with a hardcoded matrix. This is not ideal, but to preserve the status quo and avoid any unexpected changes in behavior, this patch merely fixes the inferred primaries tag to match the reality. In the

[FFmpeg-devel] [PATCH v2 06/16] swscale/utils: add helper function to infer colorspace metadata

2024-12-06 Thread Niklas Haas
From: Niklas Haas Logic is loosely on equivalent decisions in libplacebo. The basic idea is to try and be a bit conservative by treating AVCOL_*_UNSPECIFIED as a no-op, unless the other primaries set are non-standard / wide-gamut or HDR. This helps avoid unintended or unexpected colorspace conver

[FFmpeg-devel] [PATCH v2 08/16] swscale: add ICC intent enum and option

2024-12-06 Thread Niklas Haas
From: Niklas Haas This setting can be used to infuence the type of tone and gamut mapping used internally when color space conversions are required. As discussed at VDD'24, the default was set to relative colorimetric clipping, which is approximately associative, surjective and idempotent. As suc

[FFmpeg-devel] [PATCH v2 05/16] swscale/utils: read dynamic HDR10+ metadata from AVFrame

2024-12-06 Thread Niklas Haas
From: Niklas Haas Logic ported from libplacebo's AVFrame helpers. The basic idea is to use the provided MaxRGB/MaxSCL values to infer what the actual luminance would have been, which HDR10+ metadata does not provide directly. It's worth pointing out that this gives us an *upper* bound on the true

[FFmpeg-devel] [PATCH v2 16/16] swscale: remove primaries/trc change warning

2024-12-06 Thread Niklas Haas
From: Niklas Haas This is now supported when using the new API. --- libswscale/swscale.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 7e77e82c8d..42efccd12b 100644 --- a/libswscale/swscale.c +++ b/libswscale/swscale.c @@ -1361,

[FFmpeg-devel] [PATCH v2 14/16] swscale/graph: add color mapping pass

2024-12-06 Thread Niklas Haas
From: Niklas Haas This leverages the previously introduced color management subsystem in order to adapt between transfer functions and color spaces, as well as for HDR tone mapping. Take special care to handle grayscale formats without a colorspace gracefully. --- libswscale/graph.c | 95 ++

[FFmpeg-devel] [PATCH v2 15/16] swscale/graph: allow dynamically updating HDR metadata

2024-12-06 Thread Niklas Haas
From: Niklas Haas Without triggering a full graph reinit. --- libswscale/graph.c | 21 - libswscale/graph.h | 12 +--- libswscale/utils.h | 6 ++ 3 files changed, 35 insertions(+), 4 deletions(-) diff --git a/libswscale/graph.c b/libswscale/graph.c index 7160458

[FFmpeg-devel] [PATCH v2 13/16] swscale/lut3d: add 3DLUT dispatch system

2024-12-06 Thread Niklas Haas
From: Niklas Haas This is a lightweight wrapper around the underlying color management system, whose job it is merely to manage the 3DLUT state and apply them to the frame data. This is where we might add platform-specific optimizations in the future. I also plan on adding support for more pixel

[FFmpeg-devel] [PATCH v2 03/16] swscale/utils: set static/implied HDR metadata

2024-12-06 Thread Niklas Haas
From: Niklas Haas Provide default values for the fields added in the previous commit. --- libswscale/utils.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libswscale/utils.c b/libswscale/utils.c index 428cf1c7f5..182f92396a 100644 --- a/libswscale/utils.c +++ b/libsw

[FFmpeg-devel] [PATCH v2 01/16] swscale/utils: check for supported color transfers

2024-12-06 Thread Niklas Haas
From: Niklas Haas We will use the av_csp_itu_eotf() functions to decode these internally, so check this function to see if it succeeds. --- libswscale/utils.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 32f90e366e..43805

[FFmpeg-devel] [PATCH v2 02/16] swscale/utils: add HDR metadata to SwsFormat

2024-12-06 Thread Niklas Haas
From: Niklas Haas Only add the condensed values that we actually care about. Group them into a new struct to make it easier to discard or replace this metadata. Define a special comparison function that does not choke on undefined/unknown metadata. --- libswscale/swscale.c | 7 --- libswsc

[FFmpeg-devel] (no subject)

2024-12-06 Thread Niklas Haas
Changes since v1: - Fix an edge case with XYZ, YUVJ and RGB0 handling - Fix compilation with asm enabled - Fix crash in fate test - Fix unnecessary reinitialization per frame in some cases - Fix vf_scale accidentally rejecting untagged files Note: For ease of testing, this series can also be foun

[FFmpeg-devel] [PATCH v3 2/2] avcodec/rawenc: propagate the Producer Reference time

2024-12-06 Thread Clément Péron
The Producer Reference time contains the source time when the frame has been produced. This is usefull in the muxer so propagate it. Signed-off-by: Clément Péron --- libavcodec/rawenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/rawenc.c b/libavcodec/rawenc.c in

[FFmpeg-devel] [PATCH v3 0/2] Propagate PRFT side data

2024-12-06 Thread Clément Péron
Hi, This is in the continuity of the v1 that was sent in September 2023. The idea is to be able to access the Producer Timestamp aka PRFT of a RTSP stream in the encoder to be able to write it in the final file. In my case, the PRFT is a timestamp that is produced by the camera to give the preci

[FFmpeg-devel] [PATCH v3 1/2] libavutil/frame: Introduce a new AV_FRAME_DATA_PRFT

2024-12-06 Thread Clément Péron
This will be used to propagate the Producer Reference Timestamp. Signed-off-by: Clément Péron --- libavcodec/decode.c | 1 + libavfilter/f_sidedata.c | 1 + libavutil/frame.c| 1 + libavutil/frame.h| 5 + 4 files changed, 8 insertions(+) diff --git a/libavcodec/decode.c

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

2024-12-06 Thread Clément Péron
Hi Hendrik, On Tue, 3 Dec 2024 at 19:05, Clément Péron wrote: > > Hi Hendrik, > > On Tue, 3 Dec 2024 at 17:47, Devin Heitmueller > wrote: > > > > On Tue, Dec 3, 2024 at 9:57 AM Hendrik Leppkes wrote: > > > The real question is, why are you using cuviddec instead of nvdec? > > > side data would

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_scale: switch to new swscale API

2024-12-06 Thread Niklas Haas
On Fri, 06 Dec 2024 14:31:43 +0100 Michael Niedermayer wrote: > Hi > > On Mon, Nov 25, 2024 at 10:11:49AM +, Niklas Haas wrote: > > ffmpeg | branch: master | Niklas Haas | Fri Jun 28 > > 21:42:23 2024 +0200| [04ce01df0bb2d66e143bcfcea439afc2a1b8d96e] | > > committer: Niklas Haas > > > > av

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_scale: switch to new swscale API

2024-12-06 Thread Michael Niedermayer
Hi On Mon, Nov 25, 2024 at 10:11:49AM +, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas | Fri Jun 28 21:42:23 > 2024 +0200| [04ce01df0bb2d66e143bcfcea439afc2a1b8d96e] | committer: Niklas > Haas > > avfilter/vf_scale: switch to new swscale API > > Most logic from this filter ha

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/rv40dsp: fix RISC-V chroma_mc

2024-12-06 Thread Niklas Haas
On Thu, 05 Dec 2024 21:41:51 +0800 uk7b-at-foxmail@ffmpeg.org wrote: > From: sunyuechi > > --- > libavcodec/riscv/rv40dsp_rvv.S | 116 ++--- > 1 file changed, 78 insertions(+), 38 deletions(-) > > diff --git a/libavcodec/riscv/rv40dsp_rvv.S b/libavcodec/riscv/rv40d

Re: [FFmpeg-devel] [PATCH] avcodec: uninit hwaccel in case of software decoder

2024-12-06 Thread Thomas Guillem via ffmpeg-devel
Ping. On Fri, Nov 29, 2024, at 11:44, Thomas Guillem via ffmpeg-devel wrote: > avcodec_get_hw_frames_parameters(), called by the user from get_format, > is allocating ctx->internal->hwaccel_priv_data. But the hardware > decoding setup may fail on the user side and it may fallback to software > dec

Re: [FFmpeg-devel] [PATCH 0/7] RFC: complete rework of s337m support

2024-12-06 Thread Nicolas Gaullier
>De : ffmpeg-devel de la part de Kieran >Kunhya via ffmpeg-devel >Envoyé : jeudi 5 décembre 2024 19:31 > >> I resample the decoded data. The s337m decoder requires the dolby_e decoder >> (same way the current ftr decoder requires the aac decoder, so should not be >> an issue). > >Why not just s

Re: [FFmpeg-devel] [PATCH 0/7] RFC: complete rework of s337m support

2024-12-06 Thread Nicolas Gaullier
>De : Anton Khirnov >Envoyé : jeudi 5 décembre 2024 15:06 >Hi, >I believe a similar approach was tried by Gyan earlier this year and >unanimously rejected by the TC [1-3]. > >[1] >https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ >[2] Message-Id <9be400cf-9

Re: [FFmpeg-devel] [PATCH 0/7] RFC: complete rework of s337m support

2024-12-06 Thread Nicolas Gaullier
>De : ffmpeg-devel de la part de Lynne via >ffmpeg-devel >Envoyé : jeudi 5 décembre 2024 15:15 >I strongly object to using a resampler here. We *never* covert audio or >video in decoders from the native codec samplerate or pixel format. >This includes Opus. Opus carries the original samplerate o

Re: [FFmpeg-devel] [RFC PATCH] tests/color_utils: Reduce precision requirement to resolve test failure

2024-12-06 Thread Martin Storsjö
On Fri, 6 Dec 2024, Zhao Zhili wrote: From: Zhao Zhili --- libavutil/tests/color_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/tests/color_utils.c b/libavutil/tests/color_utils.c index 27ba8b529e..b8200e91fa 100644 --- a/libavutil/tests/color_utils.c +++