[FFmpeg-devel] [PATCH 3/3] hwcontext_vulkan: add support for implicit DRM synchronization

2024-09-19 Thread Lynne via ffmpeg-devel
More recent kernel versions allow for users to extract a sync_file handle from a DMA-BUF, which can then be imported into Vulkan as a binary semaphore. This finally allows for synchronization between Vulkan and DMA-BUF images, such as those from screen capture software, or VAAPI, avoiding any corr

[FFmpeg-devel] [PATCH 1/3] hwcontext_vulkan: fix VUID-VkPhysicalDeviceImageFormatInfo2-usage-requiredbitmask

2024-09-19 Thread Lynne via ffmpeg-devel
fmt_props.usage was initialized to 0 as create_info.usage was set later. --- libavutil/hwcontext_vulkan.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index d6899df159..1de08c6181 100644 --- a/li

[FFmpeg-devel] [PATCH 2/3] vulkan: add ff_vk_exec_add_dep_bool_sem

2024-09-19 Thread Lynne via ffmpeg-devel
This function simply takes in a binary semaphore as a dependency to an execution. --- libavutil/vulkan.c | 108 - libavutil/vulkan.h | 4 ++ 2 files changed, 102 insertions(+), 10 deletions(-) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: support resizing while decoding

2024-09-19 Thread Hendrik Leppkes
On Fri, Sep 20, 2024 at 1:24 AM Carlos Ruiz wrote: > > Hi! > > This is my first contribution to the project so please excuse any bad > etiquette, I tried to read all the FAQs before posting. Would love to start > by thanking everyone for such an amazing framework you've built! > > Anyway, here's m

[FFmpeg-devel] [PATCH v2] avcodec/vvc: Don't use large array on stack

2024-09-19 Thread Zhao Zhili
From: Zhao Zhili tmp_array in dmvr_hv takes 33024 bytes on stack, which can be dangerous. --- libavcodec/vvc/ctu.h | 1 + libavcodec/vvc/dsp.h | 2 +- libavcodec/vvc/inter.c | 2 +- libavcodec/vvc/inter_template.c | 12 +++- libavcodec/x86/vvc/vvcdsp

[FFmpeg-devel] [PATCH v8 6/6] tests: Fate sample tests for DNxUncompressed

2024-09-19 Thread Martin Schitter
--- tests/Makefile | 1 + tests/fate/dnxuc.mak| 40 + tests/ref/fate/dnxuc-cb-rgb-10 | 8 ++ tests/ref/fate/dnxuc-cb-rgb-12 | 8 ++ tests/ref/fate/dnxuc-cb-rgb-8 | 8 ++ tests/ref/fate/dnxuc-cb-rgb-flo

[FFmpeg-devel] [PATCH v8 5/6] doc: DNxUncompressed Changelog and doc entries

2024-09-19 Thread Martin Schitter
--- Changelog | 1 + doc/general_contents.texi | 1 + 2 files changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 49a16da..13e2ac0 100644 --- a/Changelog +++ b/Changelog @@ -19,6 +19,7 @@ version : - Cropping metadata parsing and writing in Matroska and MP4/MOV de/m

[FFmpeg-devel] [PATCH v8 4/6] libavcodec/dnxucdec: DNxUncompressed decoder

2024-09-19 Thread Martin Schitter
--- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/dnxucdec.c | 391 + 3 files changed, 393 insertions(+) create mode 100644 libavcodec/dnxucdec.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 76366b3..87a9cc1 10

[FFmpeg-devel] [PATCH v8 2/6] libavformat/mxf: Add ULs for DNxUncompressed

2024-09-19 Thread Martin Schitter
--- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index a73e40e..b6c1f17 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -61,6 +61,7 @@ const MXFCodecUL ff_mxf_codec_uls[] = { { { 0x06,0x

[FFmpeg-devel] [PATCH v8 3/6] libavcodec/dnxuc_parser: DNxUncompressed essence parser

2024-09-19 Thread Martin Schitter
--- libavcodec/Makefile | 1 + libavcodec/dnxuc_parser.c | 124 ++ libavcodec/parsers.c | 1 + 3 files changed, 126 insertions(+) create mode 100644 libavcodec/dnxuc_parser.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 936fc34..

[FFmpeg-devel] DNxUncompressed decoder

2024-09-19 Thread Martin Schitter
This is just a rebased version of the DNxUncompressed patch set without any additional changes to make merging easier. Please contact me if you still see necessary improvements. thanks martin [PATCH v8 1/6] libavcodec/: Add ID and desc for DNxUncompressed [PATCH v8 2/6] libavformat/mxf: Add UL

[FFmpeg-devel] [PATCH v8 1/6] libavcodec/: Add ID and desc for DNxUncompressed

2024-09-19 Thread Martin Schitter
--- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/version.c| 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 03dea57..2452a7b 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec

Re: [FFmpeg-devel] [PATCH] tests: Fate sample tests for DNxUncompressed

2024-09-19 Thread martin schitter
On 20.09.24 04:42, James Almer wrote: On 9/13/2024 10:01 AM, martin schitter wrote: Here are the necessary samples for the fate checks. Please upload them to the fate sample collection. Done. thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ff

Re: [FFmpeg-devel] [PATCH] tests: Fate sample tests for DNxUncompressed

2024-09-19 Thread James Almer
On 9/13/2024 10:01 AM, martin schitter wrote: Here are the necessary samples for the fate checks. Please upload them to the fate sample collection. thanks martin Done. OpenPGP_signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Add handling HDR10+ sidedata on cuviddec.

2024-09-19 Thread 김윤주
Does native decoder refer to hevc (hevcdec.c)? I tried using hevc and in environments with low CPU performance, hevc_cuvid was much faster. So, I used hevc_cuvid for decoding but encountered an issue where HDR10+ sidedata did not exist. That's why I wrote this patch. I thought that the origina

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h265: fix missing slice_block_cols assignment

2024-09-19 Thread Xiang, Haihao
On Vr, 2024-09-20 at 01:12 +, Wang, Fei W wrote: > On Thu, 2024-09-19 at 20:01 +0200, Marvin Scholz wrote: > > Instead of assigning to unit_opts.slice_block_cols, the > > slice_block_cols > > value from the context was incorrectly assigned to slice_block_rows. > > > > Regression from 12f158ca8

[FFmpeg-devel] [PATCH] doc: Add email URLs for Fate sample-request

2024-09-19 Thread Martin Schitter
Because I'm now waiting for one week that someone finally puts my contributed DNxUncompressed sample files to the Fate sample repo (see: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333471.html), I frequently looked into the documentation to find out, what I could have done wrong

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h265: fix missing slice_block_cols assignment

2024-09-19 Thread Wang, Fei W
On Thu, 2024-09-19 at 20:01 +0200, Marvin Scholz wrote: > Instead of assigning to unit_opts.slice_block_cols, the > slice_block_cols > value from the context was incorrectly assigned to slice_block_rows. > > Regression from 12f158ca8f2ecc172f27569af88426d0e39ce995 > > Fixes CID1619479 Unused valu

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

2024-09-19 Thread James Almer
On 9/19/2024 9:34 PM, Michael Niedermayer wrote: On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: On 9/19/2024 7:56 PM, Michael Niedermayer wrote: Fixes: shift exponent 62 is too large for 32-bit type 'int' Fixes: 71020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

2024-09-19 Thread Michael Niedermayer
On Fri, Sep 20, 2024 at 02:34:25AM +0200, Michael Niedermayer wrote: > On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: > > On 9/19/2024 7:56 PM, Michael Niedermayer wrote: > > > Fixes: shift exponent 62 is too large for 32-bit type 'int' > > > Fixes: > > > 71020/clusterfuzz-testcase-m

[FFmpeg-devel] [PATCH 3/3] - libavcodec/aom_film_grain: Mark AFGS1 parameters in the current message as eligible for selection

2024-09-19 Thread Segall, Andrew via ffmpeg-devel
Details: Limit selection of the film grain parameters to (only) those received in the current message. Signed-off-by: Andrew Segall mailto:aseg...@amazon.com>> --- libavcodec/aom_film_grain.c | 7 +++ libavutil/film_grain_params.h | 5 + 2 files changed, 12 insertions(+) diff --git a/liba

[FFmpeg-devel] [PATCH 2/3] - libavcodec/aom_film_grain: Add apply_grain flag

2024-09-19 Thread Segall, Andrew via ffmpeg-devel
Details: Add support for the apply_grain_flag. This allows the film grain process to be enabled/disabled for different display properties. On 9/8/24, 12:06 AM, "Andrew Segall" mailto:aseg...@amazon.com>> wrote: Signed-off-by: Andrew Segall mailto:aseg...@amazon.com>> --- libavcodec/aom_film_g

[FFmpeg-devel] [PATCH 1/3] - libavcodec/aom_film_grain: Handle byte alignment when multiple film grain parameters sets are present in the bitstream

2024-09-19 Thread Segall, Andrew via ffmpeg-devel
More info: Series of patches to align the implementation of aom_film_grain.c with the AOM specification. First time committing. Suggestions very welcome. Signed-off-by: Andrew Segall mailto:aseg...@amazon.com>> --- libavcodec/aom_film_grain.c | 12 1 file changed, 12 insertions(+)

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

2024-09-19 Thread Michael Niedermayer
On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: > On 9/19/2024 7:56 PM, Michael Niedermayer wrote: > > Fixes: shift exponent 62 is too large for 32-bit type 'int' > > Fixes: > > 71020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6444916325023744 > > > > Found-by: cont

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

2024-09-19 Thread James Almer
On 9/19/2024 7:56 PM, Michael Niedermayer wrote: Fixes: shift exponent 62 is too large for 32-bit type 'int' Fixes: 71020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6444916325023744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/f

[FFmpeg-devel] [PATCH] avcodec/nvdec: support resizing while decoding

2024-09-19 Thread Carlos Ruiz
Hi! This is my first contribution to the project so please excuse any bad etiquette, I tried to read all the FAQs before posting. Would love to start by thanking everyone for such an amazing framework you've built! Anyway, here's my proposed patch to support video resizing when using NVDEC hwacce

[FFmpeg-devel] [PATCH 9/9] avcodec/eacmv: Check input size for intra frames

2024-09-19 Thread Michael Niedermayer
Fixes: Timeout Fixes: 71135/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EACMV_fuzzer-6251879028293632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/eacmv.c | 5 - 1 file changed, 4

[FFmpeg-devel] [PATCH 8/9] tools/target_dec_fuzzer: Adapt threshold for RASC

2024-09-19 Thread Michael Niedermayer
Fixes: Timeout Fixes: 71108/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-4799330484027392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +- 1 file changed

[FFmpeg-devel] [PATCH 6/9] avcodec/aac/aacdec: use correct index in deallocation

2024-09-19 Thread Michael Niedermayer
Fixes: memleak Fixes: 71084/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5857751899635712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH 7/9] avcodec/encode: Check bitrate

2024-09-19 Thread Michael Niedermayer
Fixes: -1.80923e+19 is outside the range of representable values of type 'long' Fixes: 71103/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-6542773681979392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael N

[FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

2024-09-19 Thread Michael Niedermayer
Fixes: shift exponent 62 is too large for 32-bit type 'int' Fixes: 71020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6444916325023744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- liba

[FFmpeg-devel] [PATCH 4/9] avcodec/osq: use unsigned for decorrelation

2024-09-19 Thread Michael Niedermayer
Fixes: signed integer overflow: 1205469696 + 1901074655 cannot be represented in type 'int' Fixes: 70773/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-5419594888577024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH 3/9] avcodec/jfdctint_template: use unsigned z* in row_fdct()

2024-09-19 Thread Michael Niedermayer
Fixes: signed integer overflow: 856827136 + 2123580416 cannot be represented in type 'int' Fixes: 70772/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PRORES_KS_fuzzer-5180569961431040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-

[FFmpeg-devel] [PATCH 2/9] avformat/asf: Check picsize

2024-09-19 Thread Michael Niedermayer
Fixes: signed integer overflow: 1073750247 * 2 cannot be represented in type 'int' Fixes: 70722/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-5447231587549184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nied

[FFmpeg-devel] [PATCH 1/9] avcodec/osq: Treat sum = 0 as k = 0

2024-09-19 Thread Michael Niedermayer
We have no valid sample that triggers this so we do not know if this would decode correctly, but -inf is not the correct k value Fixes: Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:423 Fixes: -inf is outside the range of representable values of type 'int' Fixes: 70709/clusterfuzz-test

[FFmpeg-devel] [PATCH] configure: do not use interval regexp operators with awk

2024-09-19 Thread Marvin Scholz
Some awk implementations like mawk (used on Ubuntu) do not support these. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d872213af7a..d568739bf90 100755 --- a/configure +++ b/configure @@ -6150,11 +6150,11 @@ enable_weak_pic() { enabl

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Add handling HDR10+ sidedata on cuviddec.

2024-09-19 Thread Fahad Mustafa
What? On Fri, Sep 20, 2024, 12:47 AM Timo Rothenpieler wrote: > On 19.09.2024 06:43, yoonjoo wrote: > > Implemented decoding of NAL units and handling HDR10+ sidedata > > by referring to hevcdec. > > Why? Can't you just use the native decoder with nvdec hwaccel? > ___

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Add handling HDR10+ sidedata on cuviddec.

2024-09-19 Thread Timo Rothenpieler
On 19.09.2024 06:43, yoonjoo wrote: Implemented decoding of NAL units and handling HDR10+ sidedata by referring to hevcdec. Why? Can't you just use the native decoder with nvdec hwaccel? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ff

Re: [FFmpeg-devel] [RFC PATCH] avcodec/vvc: Don't use large array on stack

2024-09-19 Thread James Almer
On 9/19/2024 2:27 PM, Zhao Zhili wrote: From: Zhao Zhili tmp_array in dmvr_hv takes 33024 bytes on stack, which can be dangerous. This patch fixed the C version and comment out the x86 asm version. You don't need to comment it out. The x86 versions don't use the new argument, so just update th

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h265: fix missing slice_block_cols assignment

2024-09-19 Thread Marvin Scholz
Instead of assigning to unit_opts.slice_block_cols, the slice_block_cols value from the context was incorrectly assigned to slice_block_rows. Regression from 12f158ca8f2ecc172f27569af88426d0e39ce995 Fixes CID1619479 Unused value --- libavcodec/vaapi_encode_h265.c | 2 +- 1 file changed, 1 insert

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_libvmaf: Add metadata propagation support

2024-09-19 Thread Kyle Swanson
Hi, On Wed, Sep 11, 2024 at 5:41 PM Yigithan Yigit wrote: > Yes, metadata callbacks are not coming in order. I looked libavutil and I > couldn’t find a data structure for this use case. I am open to suggestions If > we don’t prefer to use this data structure. Could we somehow get the AVFrame p

[FFmpeg-devel] [RFC PATCH] avcodec/vvc: Don't use large array on stack

2024-09-19 Thread Zhao Zhili
From: Zhao Zhili tmp_array in dmvr_hv takes 33024 bytes on stack, which can be dangerous. This patch fixed the C version and comment out the x86 asm version. --- libavcodec/vvc/ctu.h | 1 + libavcodec/vvc/dsp.h | 2 +- libavcodec/vvc/inter.c | 2 +- libavcode

[FFmpeg-devel] [PATCH v2] avformat/utils: added av_get_frame_filename3() (changed parameter int -> int64_t)

2024-09-19 Thread Filip Mašić
Resolves an integer overflow with the frame_pts option (issue 11194). Signed-off-by: Filip Mašić --- doc/APIchanges | 3 +++ libavformat/avformat.h | 5 - libavformat/img2enc.c | 6 ++ libavformat/utils.c| 12 +--- 4 files changed, 18 insertions(+), 8 deletions(-)

Re: [FFmpeg-devel] [PATCH] avformat/utils: added av_get_frame_filename3() (changed parameter int -> int64_t)

2024-09-19 Thread Michael Niedermayer
On Mon, Sep 16, 2024 at 10:32:00PM +0100, Filip Mašić wrote: > fix for ticket 11194 (frame_pts codepath requires a larger integer capacity > for normal workloads) > > Signed-off-by: Filip Mašić > --- > libavformat/avformat.h | 5 - > libavformat/img2enc.c | 6 ++ > libavformat/utils.

[FFmpeg-devel] Adding MPEGS New Uncompressed Codec

2024-09-19 Thread Devon Sookhoo
Hello, I am interested in FFMPEG playing uncompressed MP4 files according to the new ISO/IEC 23001-17:2024 standard here: https://www.iso.org/standard/82528.html I am new to FFMPEG, but was able to create a draft implementation here: https://github.com/FFmpeg/FFmpeg/compare/master...dukesook:FFmp

[FFmpeg-devel] [PATCH] avformat/img2enc: added av_get_frame_filename3() (changed parameter int -> int64_t)

2024-09-19 Thread Filip Mašić
I just realised image2 has a specific maintainer so I’d like to ask for guidance for my patch, so I CCed. Its point is to fix an integer overflow in img2enc, so I was unsure what to name it, or whether it qualifies as a security fix so sorry if I bumped it prematurely. I’ve looked into it a bit mor

[FFmpeg-devel] [PATCH v5 1/1] lavfi/vf_gopromax_opencl: add GoPro Max 360 video filter

2024-09-19 Thread TADANO Tokumei
Add an OpenCL filter for filtering GoPro Max native .360 files into standard equirectangular or youtube equiangular cubemap (eac) projection. The .360 file contains separated two video streams. This filter combine two streams into single stream with standard format. --- configure

[FFmpeg-devel] [PATCH v5 0/1] lavfi/vf_gopromax_opencl: add GoPor Max 360 video filter

2024-09-19 Thread TADANO Tokumei
This is updated patch of: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3943 I contacted to Ronan LE MEILLAT and agreed with him to submit new patch. Abstruct of GoPro Max .360 video file format is described in: https://gopro.com/news/max-tech-specs-stitching-resolution The specificati

[FFmpeg-devel] [PATCH] avformat/libsrt: Adding support for multiple clients as a server

2024-09-19 Thread nicolas . dato
From: Nicolas Jorge Dato When in listener mode and writing, now libsrt supports multiple clients configured with the max_clients parameter. When max_clients=1 (default), it behaves as before. When max_clientes > 1, after accepting the first client it launches a thread to listen for more clients,

Re: [FFmpeg-devel] [PATCH] ffmpeg_mux_init: correct log suggestion

2024-09-19 Thread Gyan Doshi
On 2024-09-17 05:45 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-09-17 13:15:45) The option is enc_time_base, not enc_timebase --- fftools/ffmpeg_mux_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index