Re: [FFmpeg-devel] [PATCH v2] configure: fix symbol prefix detection

On Wed, 11 Sep 2024, Marvin Scholz wrote: The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong.

[FFmpeg-devel] [PATCH v6 5/5] doc: DNxUncompressed Changelog and doc entries

--- Changelog | 1 + doc/general_contents.texi | 1 + 2 files changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 7237648..0464bee 100644 --- a/Changelog +++ b/Changelog @@ -20,6 +20,7 @@ version : - Intel QSV-accelerated VVC decoding - MediaCodec AAC/AMR-NB/AMR-WB

[FFmpeg-devel] [PATCH v6 3/5] libavcodec/dnxuc_parser: DNxUncompressed essence parser

--- libavcodec/Makefile | 1 + libavcodec/dnxuc_parser.c | 124 ++ libavcodec/parsers.c | 1 + 3 files changed, 126 insertions(+) create mode 100644 libavcodec/dnxuc_parser.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 1d27e55..

[FFmpeg-devel] [PATCH v6 4/5] libavcodec/dnxucdec: DNxUncompressed decoder

--- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/dnxucdec.c | 391 + 3 files changed, 393 insertions(+) create mode 100644 libavcodec/dnxucdec.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 55444cb..b2f00af 10

[FFmpeg-devel] [PATCH v6 1/5] libavcodec/: Add ID and desc entries for DNxUncompressed

Hopefully it's this time more acceptable... Martin --- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/version.c| 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index a28ef68..27bf105 100644

[FFmpeg-devel] [PATCH v6 2/5] libavformat/mxf: Add ULs for DNxUncompressed

--- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index a73e40e..b6c1f17 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -61,6 +61,7 @@ const MXFCodecUL ff_mxf_codec_uls[] = { { { 0x06,0x

Re: [FFmpeg-devel] [PATCH 10/10 v4] avcodec: add LCEVC decoding support via LCEVCdec

On Thu, 12 Sep 2024, at 02:59, James Almer wrote: > Signed-off-by: James Almer > --- > Somewhat improved the glue, making it all internal to decode.c and no longer > touching AVCodecInternal. Seems a ton better, as far as I am concerned. -- Jean-Baptiste Kempf - President +33 672 704 734 https

[FFmpeg-devel] [PATCH 1/2] lavu: Move vulkan_spirv to libavutil

Lynne has pushed multiple changes to vulkan usage in FFmpeg, this is the patch with those changes. Main one is the move to ff_vk_init. Signed-off-by: Petro Mozil --- libavcodec/Makefile | 4 + libavcodec/vulkan_glslang.c | 19 +++ libavcodec/vulkan_shaderc.c | 19 +++ libavcodec/v

[FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: fix leaks on error

In case of errors in this function, the allocated context was not properly freed in several cases. --- libavdevice/decklink_dec.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9a817daf187..418701

[FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: fix leak on error

In the early return when both draw_bars and signal_loss_action options are used, the context allocated previously was not properly freed. Introduced in 9bcb86b0fa58f1a5a2a8613065349e26abadb329 Fixes CID1619296 --- libavdevice/decklink_dec.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/l

Re: [FFmpeg-devel] [PATCH v5 1/4] libavcodec/dnxuc_parser: DNxUncompressed essence parser

On 11.09.24 21:47, Marton Balint wrote: The order of the patches is wrong. Every point in a series must be compilable, and a patch in a series must only depend on earlier patches in the series. So as a first patch you should add codec ID and codec desc, then you can add MXF demuxer support

Re: [FFmpeg-devel] [PATCH v4 2/4] libavformat/mxf: DNxUncompressed MXF related changes

On 11.09.24 21:41, Marton Balint wrote: I have to correct myself again: This Entry in the "PictureEssenceCoding" list of 'mxf.c' should according to the specification look like: + { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0x03,0x07 ,0x01,0x00 }, 15,  AV_CODEC_I

[FFmpeg-devel] [PATCH 09/10] avcodec/hevc/refs: ensure LCEVC SEI payloads are exported as frame side data before get_buffer() calls

Signed-off-by: James Almer --- libavcodec/hevc/refs.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavcodec/hevc/refs.c b/libavcodec/hevc/refs.c index 09d759f936..a75153c462 100644 --- a/libavcodec/hevc/refs.c +++ b/libavcodec/hevc/refs.c @@ -86,6 +86,19 @@ static HEVCFram

[FFmpeg-devel] [PATCH 08/10 v2] avcodec/decode: split ProgressFrame allocator into two functions

Signed-off-by: James Almer --- No changes since last version. libavcodec/decode.c| 11 +++ libavcodec/progressframe.h | 16 ++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 18ddd28690..e4e92e34e4 1006

[FFmpeg-devel] [PATCH 07/10 v2] avcodec/packet: add an LCEVC enhancement data payload side data type

Signed-off-by: James Almer --- No changes since last version. doc/APIchanges | 3 +++ libavcodec/decode.c | 1 + libavcodec/packet.c | 1 + libavcodec/packet.h | 6 ++ libavcodec/version.h | 2 +- 5 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/AP

[FFmpeg-devel] [PATCH 10/10 v4] avcodec: add LCEVC decoding support via LCEVCdec

Signed-off-by: James Almer --- Somewhat improved the glue, making it all internal to decode.c and no longer touching AVCodecInternal. I also tried abstracting the delayed processing API in FrameDecodeData by moving it into a standalone API, but the result was quite a bit of complexity that may on

[FFmpeg-devel] [PATCH 06/10 v2] avformat/mov: support for LCEVC tracks

Co-authored-by: V-Nova Team Signed-off-by: James Almer --- libavformat/isom.h | 3 ++ libavformat/isom_tags.c | 2 + libavformat/mov.c | 86 + 3 files changed, 91 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index 15e946

[FFmpeg-devel] [PATCH 05/10 v2] avformat: add an LCEVC stream group

Signed-off-by: James Almer --- Added some documentation and an index field to easily find the enhancement layer stream. doc/APIchanges | 5 + libavformat/avformat.c | 5 + libavformat/avformat.h | 27 +++ libavformat/dump.c | 27 +

[FFmpeg-devel] [PATCH 04/10 v2] avcodec/codec_id: add an LCEVC codec id for raw LCEVC data

Signed-off-by: James Almer --- No changes since last version. doc/APIchanges | 3 +++ libavcodec/codec_desc.c | 6 ++ libavcodec/codec_id.h | 1 + 3 files changed, 10 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index f937be87cc..9d7480e5ee 100644 --- a/doc/APIchang

[FFmpeg-devel] [PATCH 03/10] avcodec: add an export_side_data flag to export picture enhancement layers

Signed-off-by: James Almer --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 6 ++ libavcodec/options_table.h | 1 + libavcodec/version.h | 2 +- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 5d7b5ab91c..f937be87c

[FFmpeg-devel] [PATCH 02/10 v4] avcodec/h2645_sei: export raw LCEVC metadata

Signed-off-by: James Almer --- No changes since last version. libavcodec/h2645_sei.c | 34 ++ libavcodec/h2645_sei.h | 5 + libavcodec/itut35.h| 2 ++ 3 files changed, 41 insertions(+) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index 7

[FFmpeg-devel] [PATCH 01/10 v4] avutil/frame: add an LCEVC enhancement data payload side data type

Signed-off-by: James Almer --- No changes since last version doc/APIchanges | 3 +++ libavutil/frame.c | 1 + libavutil/frame.h | 6 ++ libavutil/version.h | 2 +- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 830a38cd69..5d7b5a

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_libvmaf: Add metadata propagation support

Hi, Thanks for feedbacks! > On Aug 30, 2024, at 7:44 AM, Kyle Swanson wrote: > > Hi, > > > On Mon, Aug 26, 2024 at 10:51=E2=80=AFAM Yigithan Yigit > mailto:yigithanyigitde...@gmail.com>> wrote: >> >> --- >> libavfilter/vf_libvmaf.c | 328 ++- >> 1 file cha

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: Recognize and Ignore MXF fill boxes

On 11.09.24 10:15, Tomas Härdin wrote: This could also be done using mxf_metadata_read_table[] using a simple stub callback. Alternatively we could add some logic to the parsing loop that skips KLVs whose key's entry in the table have read == NULL. The loop termination condition would need to

[FFmpeg-devel] [PATCH v2] configure: fix symbol prefix detection

The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to o

[FFmpeg-devel] [PATCH] configure: fix symbol prefix detection

The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to o

Re: [FFmpeg-devel] [PATCH v5 1/4] libavcodec/dnxuc_parser: DNxUncompressed essence parser

On Wed, 11 Sep 2024, Martin Schitter wrote: This time only small corrections... The order of the patches is wrong. Every point in a series must be compilable, and a patch in a series must only depend on earlier patches in the series. So as a first patch you should add codec ID and codec

Re: [FFmpeg-devel] [PATCH v4 2/4] libavformat/mxf: DNxUncompressed MXF related changes

On Wed, 11 Sep 2024, Tomas Härdin wrote: ons 2024-09-11 klockan 01:08 +0200 skrev martin schitter: On 10.09.24 15:14, Tomas Härdin wrote: > > +++ b/libavformat/mxf.c > > +    { { > > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0E,0x04,0x02,0x01,0x02, > > 0x1E,0x01,0x00 }, 16,  AV_CODEC_I

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix AV1 HDR metadata for delayed surfaces

Thanks for the fix. merged. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as vf_xfade_vulkan maintainer

--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b6fbfdc48..036066de84 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -345,6 +345,7 @@ Filters: vf_scale.c[2] Michael Niedermayer vf_tonemap_opencl.c R

[FFmpeg-devel] [PATCH] lavfi/af_channelmap: fix channelmap_init error handling

The channelmap_init function was returning success even on error after 7dc81d33c241b9e176ea85956e8317f29bc9e3c0 due to shadowing of the outer ret variable. Fixes CID1619297 Logically dead code --- libavfilter/af_channelmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liba

Re: [FFmpeg-devel] [PATCH] avfilter/af_join: pass the correct input layouts to ff_channel_layouts_ref

Quoting James Almer (2024-09-11 19:40:09) > Should fix memory leaks show in fate-filter-join and > fate-filter-crazychannels. > > Signed-off-by: James Almer > --- > libavfilter/af_join.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/af_join.c b/libavfilte

[FFmpeg-devel] [PATCH v2 08/14] aarch64/vvc: Add put_qpel_vx

From: Zhao Zhili put_luma_v_8_4x4_c: 1.0 ( 1.00x) put_luma_v_8_4x4_neon: 0.0 ( 0.00x) put_luma_v_8_8x8_c: 3.5 ( 1.00x) put_luma_v_8_8x8_neon: 0.5 ( 7.00x)

[FFmpeg-devel] [PATCH v2 14/14] aarch64/vvc: Add avg

From: Zhao Zhili avg_8_2x2_c: 0.2 ( 1.00x) avg_8_2x2_neon: 0.2 ( 1.00x) avg_8_4x4_c: 0.2 ( 1.00x) avg_8_4x4_neon: 0.2 ( 1.00x)

[FFmpeg-devel] [PATCH v2 13/14] aarch64/vvc: Add put_epel_hv

From: Zhao Zhili On Apple M1: put_chroma_hv_8_4x4_c: 1.7 ( 1.00x) put_chroma_hv_8_4x4_neon:0.2 ( 7.67x) put_chroma_hv_8_8x8_c: 5.5 ( 1.00x) put_chroma_hv_8_8x8_neon:

[FFmpeg-devel] [PATCH v2 12/14] aarch64/vvc: Add put_epel_h i8mm

From: Zhao Zhili put_chroma_h_8_4x4_c:0.4 ( 1.00x) put_chroma_h_8_4x4_neon: 0.0 ( 0.00x) put_chroma_h_8_4x4_i8mm: 0.1 ( 2.67x) put_chroma_h_8_8x8_c:1.6 ( 1.00x)

[FFmpeg-devel] [PATCH v2 11/14] aarch64/vvc: Add put_epel_h

From: Zhao Zhili put_chroma_h_8_4x4_c:0.2 ( 1.00x) put_chroma_h_8_4x4_neon: 0.2 ( 1.00x) put_chroma_h_8_8x8_c:0.8 ( 1.00x) put_chroma_h_8_8x8_neon: 0.2 ( 3.00x)

[FFmpeg-devel] [PATCH v2 09/14] aarch64/vvc: Add put_qpel_hv

From: Zhao Zhili With Apple M1 (no i8mm): put_luma_hv_8_4x4_c: 2.2 ( 1.00x) put_luma_hv_8_4x4_neon: 0.8 ( 3.00x) put_luma_hv_8_8x8_c: 7.0 ( 1.00x) put_luma_hv_8_8x8_neon:

[FFmpeg-devel] [PATCH v2 10/14] aarch64/vvc: Add sad

From: Zhao Zhili sad_8x16_c: 0.8 ( 1.00x) sad_8x16_neon: 0.2 ( 3.00x) sad_16x8_c: 0.5 ( 1.00x) sad_16x8_neon: 0.2 ( 2.00x)

[FFmpeg-devel] [PATCH v2 07/14] aarch64/h26x: Remove duplicate b.eq instruction

From: Zhao Zhili b.eq is added by calc_all after each calc. --- libavcodec/aarch64/h26x/qpel_neon.S | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/aarch64/h26x/qpel_neon.S b/libavcodec/aarch64/h26x/qpel_neon.S index 1fa5a1dd0e..417d43e365 100644 --- a/libavcodec/aarch64/h26x/qpel

[FFmpeg-devel] [PATCH v2 06/14] avcodec/hevc: ff_hevc_(qpel/epel)_filters are signed type

From: Zhao Zhili --- libavcodec/hevc/dsp_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc/dsp_template.c b/libavcodec/hevc/dsp_template.c index aebccd1a0c..a0f79c2673 100644 --- a/libavcodec/hevc/dsp_template.c +++ b/libavcodec/hevc/dsp_template.

[FFmpeg-devel] [PATCH v2 04/14] aarch64/vvc: Add put_pel/put_pel_uni/put_pel_uni_w

From: Zhao Zhili put_luma_pixels_8_4x4_c: 0.2 ( 1.00x) put_luma_pixels_8_4x4_neon: 0.2 ( 1.00x) put_luma_pixels_8_8x8_c: 0.7 ( 1.00x) put_luma_pixels_8_8x8_neon: 0.2 ( 3.22x)

[FFmpeg-devel] [PATCH v2 05/14] aarch64/vvc: Add put_qpel_hx i8mm

From: Zhao Zhili Benchmark on Android pixel 8 with -fno-vectorize put_luma_h_8_4x4_c: 0.2 ( 1.00x) put_luma_h_8_4x4_neon: 0.2 ( 1.00x) put_luma_h_8_4x4_i8mm: 0.0 ( 0.00x) put_luma_h_8_8x8_c:

[FFmpeg-devel] [PATCH v2 02/14] aarch64/hevc: Move epel/qpel to h26x directory

From: Zhao Zhili So vvc can reuse the implementation. --- libavcodec/aarch64/Makefile | 4 +- libavcodec/aarch64/h26x/dsp.h | 198 ++ .../{hevcdsp_epel_neon.S => h26x/epel_neon.S} | 0 .../{hevcdsp_qpel_neon.S => h26x/qpel_neon.S} | 0 liba

[FFmpeg-devel] [PATCH v2 01/14] aarch64/hevc: Simplify function prototypes by macro

From: Zhao Zhili --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 66 +++ 1 file changed, 18 insertions(+), 48 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_init_aarch64.c b/libavcodec/aarch64/hevcdsp_init_aarch64.c index a90da0246e..26bbc8750f 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH v2 03/14] aarch64/vvc: Add put_qpel_h_* and put_qpel_uni_h_*

From: Zhao Zhili Just share hevc implementation. checkasm --test=vvc_mc --benchmark: put_luma_h_8_4x4_c: 0.2 ( 1.00x) put_luma_h_8_4x4_neon: 0.2 ( 1.00x) put_luma_h_8_8x8_c: 1.0 ( 1.00x)

[FFmpeg-devel] [PATCH v2 00/14] aarch64/vvc: Add SIMD

From: Zhao Zhili Patches 1~9 has been updated according to Martin's review. Patches 10~14 are new. I have created a PR on github: https://github.com/quink-black/FFmpeg/pull/2 Zhao Zhili (14): aarch64/hevc: Simplify function prototypes by macro aarch64/hevc: Move epel/qpel to h26x directory

[FFmpeg-devel] [PATCH] avfilter/af_join: pass the correct input layouts to ff_channel_layouts_ref

Should fix memory leaks show in fate-filter-join and fate-filter-crazychannels. Signed-off-by: James Almer --- libavfilter/af_join.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index db0320aa70..0ea53248b6 100644 --- a/libavfi

[FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: don't write random data past the end of the buffer

Should fix fate-checkasm-sw_rgb under gcc-ubsan. Signed-off-by: James Almer --- tests/checkasm/sw_rgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index af9434073a..cdd43df8ba 100644 --- a/tests/checkasm/sw_rgb.c +++ b/te

Re: [FFmpeg-devel] [PATCH v3 1/2] tests/fate: force MPEG range for rawvideo tests

Merging tomorrow, as it fixes a release blocking bug. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscr

[FFmpeg-devel] [PATCH] lavc/hevcdec: set output frame pkt_dts

pkt_dts needs to be set manually when using the receive_frame() callback, so it was unset after 2fdecbb239714b6203e37067fda2521f80e19d47. Fixes PTS guessing for certain files with broken timestamps. Cf. https://github.com/mpv-player/mpv/issues/14806 Reported-by: llyyr --- libavcodec/hevc/hevcde

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: Add support for on-demand key frames

Thanks for your contribution. It looks good to me. If there are no comments, I'll merge it in a few days. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] ./configure and nvidia/cuda sdk

Quoting Top Secret (2024-09-11 14:21:21) > opencv's implementation of ffmpeg which then advertises a completely > different license(Apache). Huh? What is that supposed to be? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] ./configure and nvidia/cuda sdk

(I am not a lawyer, the following is my personal opinion and not legal advice) Quoting Top Secret (2024-09-11 14:21:21) > Hello, > > We are trying to redistribute a ffmpeg binary commercially. We use free > version for generally decoding video only(some demuxing). We want to use > nvidia's sugge

Re: [FFmpeg-devel] ./configure and nvidia/cuda sdk

On 11.09.2024 14:21, Top Secret wrote: Hello, We are trying to redistribute a ffmpeg binary commercially. We use free version for generally decoding video only(some demuxing). We want to use nvidia's suggestion of using the GPU with ffmpeg. They give a sample configure string like so: ./confi

Re: [FFmpeg-devel] [PATCH 3/3] aarch64/vvc: Add put_qpel_hv

On Wed, 11 Sep 2024, Zhao Zhili wrote: From: Zhao Zhili With Apple M1 (no i8mm): put_luma_hv_8_4x4_c: 2.2 ( 1.00x) put_luma_hv_8_4x4_neon: 0.8 ( 3.00x) put_luma_hv_8_8x8_c: 7.0 ( 1.00x) pu

Re: [FFmpeg-devel] [PATCH 2/3] aarch64/vvc: Add put_qpel_vx

On Wed, 11 Sep 2024, Zhao Zhili wrote: From: Zhao Zhili put_luma_v_8_4x4_c: 1.0 ( 1.00x) put_luma_v_8_4x4_neon: 0.0 ( 0.00x) put_luma_v_8_8x8_c: 3.5 ( 1.00x) put_luma_v_8_8x8_neon:

Re: [FFmpeg-devel] [PATCH 1/3] aarch64/h26x: Remove duplicate b.eq instruction

On Wed, 11 Sep 2024, Zhao Zhili wrote: From: Zhao Zhili b.eq is added by calc_all after each calc. --- libavcodec/aarch64/h26x/qpel_neon.S | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/aarch64/h26x/qpel_neon.S b/libavcodec/aarch64/h26x/qpel_neon.S index 8a372a76be..7868811b3b 1

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/hevc: ff_hevc_(qpel/epel)_filters are signed type

On Sun, 8 Sep 2024, Zhao Zhili wrote: From: Zhao Zhili --- libavcodec/hevc/dsp_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) The rest of these patches seem fine (or where I don't have much of an opinion). // Martin ___ ffm

[FFmpeg-devel] ./configure and nvidia/cuda sdk

Hello, We are trying to redistribute a ffmpeg binary commercially. We use free version for generally decoding video only(some demuxing). We want to use nvidia's suggestion of using the GPU with ffmpeg. They give a sample configure string like so: ./configure --enable-cuda --enable-cuvid --enabl

Re: [FFmpeg-devel] [PATCH 4/6] aarch64/vvc: Add put_pel/put_pel_uni/put_pel_uni_w

On Sun, 8 Sep 2024, Zhao Zhili wrote: diff --git a/libavcodec/aarch64/h26x/dsp.h b/libavcodec/aarch64/h26x/dsp.h index f72746ce03..076d01b477 100644 --- a/libavcodec/aarch64/h26x/dsp.h +++ b/libavcodec/aarch64/h26x/dsp.h @@ -248,4 +248,26 @@ NEON8_FNPROTO_PARTIAL_4(qpel, (int16_t *dst, const uin

Re: [FFmpeg-devel] [PATCH 01/60] fftools/ffmpeg_opt: fix variable shadowing

On Sun, Sep 08, 2024 at 07:14:10PM +0200, Marvin Scholz wrote: > --- > fftools/ffmpeg_opt.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) btw, iam not sure its needed to post patches for things like shadow fixes. Maybe we can fix the shadowing stuff quicker without posting patches

Re: [FFmpeg-devel] [PATCH 20/60] fftools/ffmpeg_mux_init: remove unused variable

Quoting Marvin Scholz (2024-09-08 22:20:42) > This dict is declared and freed but nothing is ever written to it. > --- > fftools/ffmpeg_mux_init.c | 2 -- > 1 file changed, 2 deletions(-) Very ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH 19/60] avdevice/jack: use av_err2str to simplify code

Quoting Marvin Scholz (2024-09-08 21:45:24) > No need to explicitly specify the buffer here as it is only > ever passed to av_log, so av_err2str can be used. > --- > libavdevice/jack.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) LGTM -- Anton Khirnov _

Re: [FFmpeg-devel] [PATCH 18/60] avutil/file: use av_err2str to simplify code

Quoting Marvin Scholz (2024-09-08 21:43:39) > No need to explicitly specify the buffer here as it is only > ever passed to av_log, so av_err2str can be used. > --- > libavutil/file.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) Looks ok -- Anton Khirnov ___

Re: [FFmpeg-devel] [PATCH 17/60] avformat/crypto: fix variable shadowing

Quoting Marvin Scholz (2024-09-08 21:38:12) > --- > libavformat/crypto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] [PATCH 15/60] avformat/network: use av_err2str to simplify code

Quoting Marvin Scholz (2024-09-08 21:16:45) > No need to explicitly specify the buffer here as it is only > ever passed to av_log, so av_err2str can be used. > --- > libavformat/network.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) Looks ok -- Anton Khirnov __

Re: [FFmpeg-devel] [PATCH 54/60] avformat/matroskadec: fix variable shadowing

On 9/8/2024 9:23 PM, Marvin Scholz wrote: --- libavformat/matroskadec.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index c8741ff2af..60b20e9658 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH 14/60] lavfi/vf_signature: use av_err2str to simplify code

Quoting Marvin Scholz (2024-09-08 20:56:38) > No need to explicitly specify the buffer here as it is only > ever passed to av_log, so av_err2str can be used. > --- > libavfilter/vf_signature.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_signatur

Re: [FFmpeg-devel] [PATCH 13/60] lavfi/f_metadata: use av_err2str to simplify code

Quoting Marvin Scholz (2024-09-08 20:53:11) > No need to explicitly specify the buffer here as it is only > ever passed to av_log, so av_err2str can be used. > --- > libavfilter/f_metadata.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Looks very ok -- Anton Khirnov __

Re: [FFmpeg-devel] [PATCH 09/13] avformat: add an LCEVC stream group

On 9/9/2024 8:33 AM, Anton Khirnov wrote: Quoting James Almer (2024-09-08 15:26:51) On 9/6/2024 8:44 AM, Anton Khirnov wrote: Quoting James Almer (2024-08-31 18:31:10) +typedef struct AVStreamGroupLCEVC { +const AVClass *av_class; + +/** + * Width of the final stream for presentati

Re: [FFmpeg-devel] [PATCH 12/60] lavfi/vf_ssim: narrow variable scopes

Quoting Marvin Scholz (2024-09-08 20:51:47) > --- > libavfilter/vf_ssim.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCH 11/60] lavfi/vf_ssim: use av_err2str to simplify code

Quoting Marvin Scholz (2024-09-08 20:13:45) > No need to explicitly specify the buffer here as it is only > ever passed to av_log, so av_err2str can be used. > --- > libavfilter/vf_ssim.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) LGTM -- Anton Khirnov __

[FFmpeg-devel] [PATCH v5 4/4] libavformat: DNxUncompressed aux files

--- Changelog | 1 + libavcodec/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 7237648..0464bee 100644 --- a/Changelog +++ b/Changelog @@ -20,6 +20,7 @@ version : - Intel QSV-accelerated VVC decoding - MediaCodec AAC/AMR-NB/AMR-WB/MP3 decodin

[FFmpeg-devel] [PATCH v5 3/4] libavformat/dnxucdec: DNxUncompressed decoder

--- libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_id.h | 1 + libavcodec/dnxucdec.c | 391 libavcodec/version.c| 2 +- 5 files changed, 401 insertions(+), 1 deletion(-) create mode 100644 libavcodec/dnxucdec

[FFmpeg-devel] [PATCH v5 2/4] libavformat/mxf: add DNxUncompressed MXF ULs

--- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index a73e40e..885b4df 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -61,6 +61,7 @@ const MXFCodecUL ff_mxf_codec_uls[] = { { { 0x06,0x

[FFmpeg-devel] [PATCH v5 1/4] libavcodec/dnxuc_parser: DNxUncompressed essence parser

This time only small corrections... --- libavcodec/dnxuc_parser.c | 124 ++ libavcodec/parsers.c | 1 + 2 files changed, 125 insertions(+) create mode 100644 libavcodec/dnxuc_parser.c diff --git a/libavcodec/dnxuc_parser.c b/libavcodec/dnxuc_parser.c n

Re: [FFmpeg-devel] is libswscale maintained?

On Wed, 11 Sep 2024 02:45:59 +0300 Andrew Randrianasulu wrote: > I can't find entry about it in ffmpeg/MAINTAINERS > > bugs meanwhile exist > > https://trac.ffmpeg.org/ticket/3345 > https://trac.ffmpeg.org/ticket/7978 There is on ongoing effort to redesign swscale, as well as fixing all currentl

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: Recognize and Ignore MXF fill boxes

ons 2024-09-11 klockan 10:15 +0200 skrev Martin Schitter: > This adds support for empty 'fill' boxes while decoding MXF files. > --- >  libavformat/mxfdec.c | 7 +++ >  1 file changed, 7 insertions(+) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 142b3e6..701fc9f 100644 >

Re: [FFmpeg-devel] [PATCH v4 2/4] libavformat/mxf: DNxUncompressed MXF related changes

On 11.09.24 08:14, Tomas Härdin wrote: btw. there is an annoying flaw in the ffmpeg mxf parser: The very common 'fill' boxes, which are used in DNxUncompressed files to align 'pack' boxes on 265 byte boundaries, are not recognized by ffmpegs mxf parser and generate lots of "Dark key 06.0e.2b.3

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: Recognize and Ignore MXF fill boxes

This adds support for empty 'fill' boxes while decoding MXF files. --- libavformat/mxfdec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 142b3e6..701fc9f 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -367,6 +367,8 @@