Re: [FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-08-19 Thread Dale Curtis
On Sat, Aug 17, 2024 at 1:42 AM Anton Khirnov wrote: > I don't follow, why would any code outside of libavcodec care about > anything in private data? > Sorry I was imprecise. The issue is that ff_codec_close() is called during "free_and_end", which releases a bunch of fields on the AVCodecConte

[FFmpeg-devel] [PATCH] avformat/dashenc: add option to set live DASH stream start time

2024-08-19 Thread Jerome Berclaz via ffmpeg-devel
When encoding a DASH stream in live ("dynamic") mode without timeline, the field "availabilityStartTime" is set to the system time. The new options allows the libavformat user to pass a specific time to be used instead of the system time. --- libavformat/dashenc.c | 9 - 1 file changed, 8

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: replace three bool arguments in ff_h2645_packet_split with a single flags one

2024-08-19 Thread James Almer
On 8/19/2024 4:21 PM, Anton Khirnov wrote: Quoting James Almer (2024-08-19 18:58:11) diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h index 128dea09ef..849e772115 100644 --- a/libavcodec/h2645_parse.h +++ b/libavcodec/h2645_parse.h @@ -93,6 +93,10 @@ typedef struct H2645Packet {

Re: [FFmpeg-devel] [PATCH] libswscale: arm: Don't assume aligned output in yuv2rgb functions

2024-08-19 Thread Martin Storsjö
On Mon, 19 Aug 2024, Martin Storsjö wrote: This fixes failures in recently added checkasm tests. While the buffers in most cases are aligned, libswscale in general can't assume the output to be aligned. --- This fixes FATE failures like in http://fate.ffmpeg.org/report.cgi?time=20240819041749&s

Re: [FFmpeg-devel] [PATCH 3/4] lavc/vp9dsp: R-V V mc tap h v

2024-08-19 Thread Rémi Denis-Courmont
Le perjantaina 9. elokuuta 2024, 17.24.05 EEST u...@foxmail.com a écrit : > From: sunyuechi Does not assemble with binutils 2.43.1 and default flags. -- 雷米‧德尼-库尔蒙 http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevc/hevcdec: Check refPicList

2024-08-19 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-08-17 01:15:03) > This is likely not the proper way to fix this I agree. Can you share the sample? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: replace three bool arguments in ff_h2645_packet_split with a single flags one

2024-08-19 Thread Anton Khirnov
Quoting James Almer (2024-08-19 18:58:11) > diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h > index 128dea09ef..849e772115 100644 > --- a/libavcodec/h2645_parse.h > +++ b/libavcodec/h2645_parse.h > @@ -93,6 +93,10 @@ typedef struct H2645Packet { > int ff_h2645_extract_rbsp(const u

Re: [FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-08-19 Thread Dale Curtis
On Sat, Aug 17, 2024 at 12:25 PM James Almer wrote: > On 8/17/2024 3:04 PM, Michael Niedermayer wrote: > > > > > 20978/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5746381832847360 > sent privately > Thanks for the sample Michael. I've confirmed it does not reproduce with my cha

Re: [FFmpeg-devel] Does rtspenc actually support AVFMT_GLOBALHEADER?

2024-08-19 Thread Martin Storsjö
On Mon, 19 Aug 2024, John Cox wrote: Does rtspenc actually support AVFMT_GLOBALHEADER? It is specified in the FFOutputFormat flags but I can't see anywhere in the code where extradata is referenced like it is in other output formats which support that flag. I ask because I have an encoder that

Re: [FFmpeg-devel] [PATCH, v2] avcodec/amfenc: increase precision of Sleep() on Windows

2024-08-19 Thread Timo Rothenpieler
On 19.08.2024 16:23, Araz Iusubov wrote: From: Evgeny Pavlov This commit increase precision of Sleep() function on Windows. This fix reduces the sleep time on Windows to improve AMF encoding performance on low resolution input videos. Fix for issue #10622 We evaluated CreateWaitableTimerExW w

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/riscv: add h264 qpel

2024-08-19 Thread Rémi Denis-Courmont
Le tiistaina 13. elokuuta 2024, 17.03.36 EEST J. Dekker a écrit : > +#include "libavutil/riscv/asm.S" > + > +.macro vnclipsu.wi shifti, lmul, lmul2, vregs:vararg > +vsetvli zero, zero, e16, \lmul2, ta, ma We don't typically do that for a very good reason. The vsetvli is most o

Re: [FFmpeg-devel] [PATCH 2/7] checkasm: improve print format

2024-08-19 Thread Lynne via ffmpeg-devel
On 16/08/2024 12:48, J. Dekker wrote: Lynne via ffmpeg-devel writes: On 13/08/2024 16:03, J. Dekker wrote: Port dav1d's checkasm output format to FFmpeg's checkasm, includes relative speedups and aligns results. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 53 +

[FFmpeg-devel] [PATCH] avcodec/h2645_parse: replace three bool arguments in ff_h2645_packet_split with a single flags one

2024-08-19 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bsf/extract_extradata.c | 2 +- libavcodec/cbs_h2645.c | 17 +++-- libavcodec/h2645_parse.c | 15 --- libavcodec/h2645_parse.h | 15 ++- libavcodec/h264_parse.c| 3 ++- liba

[FFmpeg-devel] [PATCH v2] hw_base_encode: refactor picture allocation/freeing

2024-08-19 Thread Lynne via ffmpeg-devel
This commit cleans up and refactors the mess of private state upon private state that used to be. Now, FFHWBaseEncodePicture is fully initialized upon call-time, and, most importantly, this lets APIs which require initialization data for frames (VkImageViews) to initialize this for both the input

Re: [FFmpeg-devel] [PATCH] hw_base_encode: refactor picture allocation/freeing

2024-08-19 Thread Lynne via ffmpeg-devel
On 19/08/2024 17:07, Tong Wu wrote: Lynne: Subject: [PATCH] hw_base_encode: refactor picture allocation/freeing This commit cleans up and refactors the mess of private state upon private state that used to be. Now, FFHWBaseEncodePicture is fully initialized upon call-time, and, most importantl

Re: [FFmpeg-devel] [PATCH] avfilter/vf_quirc: add missing header to unbreak build

2024-08-19 Thread Dennis Mungai
On Mon, Aug 19, 2024, 18:04 Gyan Doshi wrote: > filters.h has been needed since 42cbf66fff for FilterLink. > --- > libavfilter/vf_quirc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/vf_quirc.c b/libavfilter/vf_quirc.c > index 760f5d97de..afd172fa34 100644 > --- a/libavfi

[FFmpeg-devel] Does rtspenc actually support AVFMT_GLOBALHEADER?

2024-08-19 Thread John Cox
Hi Does rtspenc actually support AVFMT_GLOBALHEADER? It is specified in the FFOutputFormat flags but I can't see anywhere in the code where extradata is referenced like it is in other output formats which support that flag. I ask because I have an encoder that supports the flag and when set remov

Re: [FFmpeg-devel] [PATCH] hw_base_encode: refactor picture allocation/freeing

2024-08-19 Thread Tong Wu
Lynne: >Subject: [PATCH] hw_base_encode: refactor picture allocation/freeing > >This commit cleans up and refactors the mess of private state upon private >state >that used to be. > >Now, FFHWBaseEncodePicture is fully initialized upon call-time, and, most >importantly, this lets APIs which requir

[FFmpeg-devel] [PATCH] avfilter/vf_quirc: add missing header to unbreak build

2024-08-19 Thread Gyan Doshi
filters.h has been needed since 42cbf66fff for FilterLink. --- libavfilter/vf_quirc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_quirc.c b/libavfilter/vf_quirc.c index 760f5d97de..afd172fa34 100644 --- a/libavfilter/vf_quirc.c +++ b/libavfilter/vf_quirc.c @@ -27,6 +27,7 @@

Re: [FFmpeg-devel] [PATCH, v2] avcodec/amfenc: increase precision of Sleep() on Windows

2024-08-19 Thread epirat07
On 19 Aug 2024, at 16:23, Araz Iusubov wrote: > From: Evgeny Pavlov > > This commit increase precision of Sleep() function on Windows. > This fix reduces the sleep time on Windows to improve AMF encoding > performance on low resolution input videos. > > Fix for issue #10622 > > We evaluated Creat

[FFmpeg-devel] [PATCH, v2] avcodec/amfenc: increase precision of Sleep() on Windows

2024-08-19 Thread Araz Iusubov
From: Evgeny Pavlov This commit increase precision of Sleep() function on Windows. This fix reduces the sleep time on Windows to improve AMF encoding performance on low resolution input videos. Fix for issue #10622 We evaluated CreateWaitableTimerExW with CREATE_WAITABLE_TIMER_HIGH_RESOLUTION f

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/aarch64/mpegvideoencdsp: add neon implementations for pix_sum and pix_norm1

2024-08-19 Thread Martin Storsjö
On Mon, 19 Aug 2024, Ramiro Polla wrote: If the stride is a negative number, the first sxtw does the right thing, but the "lsl w1, w1, #1" will zero out the upper half of the register. I'll start adding negative stride tests to checkasm to spot these bugs. That's probably useful. The other a

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/aarch64/mpegvideoencdsp: add neon implementations for pix_sum and pix_norm1

2024-08-19 Thread Ramiro Polla
On Mon, Aug 19, 2024 at 11:46 AM Martin Storsjö wrote: > On Sun, 18 Aug 2024, Ramiro Polla wrote: > > I had tested the real world case on the A76, but not on the A53. I > > spent a couple of hours with perf trying to find the source of the > > discrepancy but I couldn't find anything conclusive. I

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/aarch64/mpegvideoencdsp: add neon implementations for pix_sum and pix_norm1

2024-08-19 Thread Martin Storsjö
On Sun, 18 Aug 2024, Ramiro Polla wrote: I had tested the real world case on the A76, but not on the A53. I spent a couple of hours with perf trying to find the source of the discrepancy but I couldn't find anything conclusive. I need to learn more about how to test cache misses. Nah, I guess

Re: [FFmpeg-devel] [PATCH 1/7] checkasm/mpegvideoencdsp: add pix_sum and pix_norm1

2024-08-19 Thread Martin Storsjö
On Sun, 18 Aug 2024, Ramiro Polla wrote: --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c| 3 ++ tests/checkasm/checkasm.h| 1 + tests/checkasm/mpegvideoencdsp.c | 77 4 files changed, 82 insertions(+) create mode 100644 tests/

[FFmpeg-devel] [PATCH] libswscale: arm: Don't assume aligned output in yuv2rgb functions

2024-08-19 Thread Martin Storsjö
This fixes failures in recently added checkasm tests. While the buffers in most cases are aligned, libswscale in general can't assume the output to be aligned. --- This fixes FATE failures like in http://fate.ffmpeg.org/report.cgi?time=20240819041749&slot=armv7-linux-gcc-9. --- libswscale/arm/yuv