Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices

2024-07-19 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-20 02:08:28) > On Wed, Jul 17, 2024 at 08:42:41AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-15 16:48:25) > [...] > > > @@ -3155,8 +3156,11 @@ static int decode_slice(HEVCContext *s, const > > > H2645NAL *nal, GetBitContext *gb) > > >

[FFmpeg-devel] [PATCH 10/11] avcodec/cfhdenc: Height of 16 is not supported

2024-07-19 Thread Michael Niedermayer
Fixes: out of array access Fixes: 68941/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-5990952685600768 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cfhdenc.c | 4 ++-- 1 fil

[FFmpeg-devel] [PATCH 09/11] avcodec/cfhdenc: Allocate more space

2024-07-19 Thread Michael Niedermayer
Fixes: Assertion failure Fixes: 68979/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-5375874714107904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cfhdenc.c | 3 +-- 1 file c

[FFmpeg-devel] [PATCH 08/11] avcodec/osq: fix integer overflow when applying factor

2024-07-19 Thread Michael Niedermayer
Fixes: signed integer overflow: -35511773 * 256 cannot be represented in type 'int' Fixes: 70406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6545326804434944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 07/11] avcodec/osq: avoid using too large numbers for shifts and integers in update_residue_parameter()

2024-07-19 Thread Michael Niedermayer
Fixes: 2.96539e+09 is outside the range of representable values of type 'int' Fixes: Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:423 Fixes: 62241/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-4525761925873664 Fixes: 70406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_I

[FFmpeg-devel] [PATCH 11/11] avcodec/hdrenc: Allocate more space

2024-07-19 Thread Michael Niedermayer
This needs to be double checked or a checking way of writing should be used Fixes: out of array access Fixes: 70007/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HDR_fuzzer-5478704150020096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg S

[FFmpeg-devel] [PATCH 06/11] avcodec/vaapi_encode: Check hwctx

2024-07-19 Thread Michael Niedermayer
Fixes: null pointer dereference Fixes: 70376/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_VAAPI_fuzzer-4733551250046976 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vaapi_encode.c

[FFmpeg-devel] [PATCH 05/11] avcodec/aac/aacdec_lpd: Check kv indec

2024-07-19 Thread Michael Niedermayer
Fixes: index 9 out of bounds for type 'uint32_t [8][8]' Fixes: 70363/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-6723855293415424.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 04/11] avcodec/aac/aacdec_usac: Dont leave invalid max_sfb in the context

2024-07-19 Thread Michael Niedermayer
Fixes: out of array read Fixes: 70363/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-6723855293415424.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec_usac.c

[FFmpeg-devel] [PATCH 03/11] avcodec/hevc/hevcdec: avoid signed shifts with lt_idx_sps

2024-07-19 Thread Michael Niedermayer
Fixes: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 70122/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5172200613675008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermay

[FFmpeg-devel] [PATCH 02/11] avcodec/proresdec: Consider negative bits left

2024-07-19 Thread Michael Niedermayer
Fixes: 70036/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PRORES_fuzzer-6298797647396864 Fixes: shift exponent 40 is too large for 32-bit type 'uint32_t' (aka 'unsigned int') Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 01/11] avcodec/alsdec: Clear shift_value

2024-07-19 Thread Michael Niedermayer
(the exact issue is unreproducable but the use of uninitialized data is reproducable) Should fix: signed integer overflow: -2147483648 - 127 cannot be represented in type 'int' Should fix: 69881/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-4751301204836352 Found-by: continuous

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices

2024-07-19 Thread Michael Niedermayer
On Wed, Jul 17, 2024 at 08:42:41AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-15 16:48:25) [...] > > @@ -3155,8 +3156,11 @@ static int decode_slice(HEVCContext *s, const > > H2645NAL *nal, GetBitContext *gb) > > int ret; > > > > ret = hls_slice_header(&s->sh, s,

Re: [FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

2024-07-19 Thread Peter Ross
On Fri, Jul 19, 2024 at 07:34:18AM -0400, redacted redacted wrote: > Hello there, > > The Sims 1: Unleashed makes use of WVE files for its intro videos. > Two of the files for the game use Mono ADPCM audio instead of Stereo. > However, FFmpeg's ADPCM_EA codec always expects the files to be in Ster

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Check extradata in mov_read_iacb()

2024-07-19 Thread James Almer
On 7/19/2024 5:10 AM, Michael Niedermayer wrote: On Thu, Jul 18, 2024 at 07:19:17PM -0300, James Almer wrote: On 7/18/2024 7:16 PM, Michael Niedermayer wrote: Fixes: MemLeak Fixes: 69853/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4660448545275904 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH v5 00/10] aacdec: add a native xHE-AAC decoder

2024-07-19 Thread Michael Niedermayer
On Thu, May 30, 2024 at 04:37:08AM +0200, Lynne via ffmpeg-devel wrote: > This commit adds a decoder for the frequency-domain part of USAC. > > Changes over version 4: > - Actually reset entropy decoding upon configuration. > - Support for LFE channels. > > Lynne (10): > channel_layout: add n

Re: [FFmpeg-devel] [PATCH] lavu/riscv: do not fallback to AT_HWCAP auxillary vector

2024-07-19 Thread Brad Smith
On 2024-07-19 11:46 a.m., Rémi Denis-Courmont wrote: If __riscv_hwprobe() fails, then the kernel version is presumably too old. There is not much point falling back to the auxillary vector. - The Linux kernel requires I, so the flag is always set on Linux, and run-time detection is unnecessar

Re: [FFmpeg-devel] Add Mediacodec audio decoders support

2024-07-19 Thread Martin Storsjö
On Wed, 17 Jul 2024, Anton Khirnov wrote: Quoting Cosmin Stejerean via ffmpeg-devel (2024-07-16 22:14:19) > On Jul 16, 2024, at 8:24 PM, Rémi Denis-Courmont wrote: > > Le tiistaina 16. heinäkuuta 2024, 18.48.06 EEST Cosmin Stejerean via ffmpeg- > devel a écrit : >> To add another data poin

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-19 Thread Stephen Hutchinson
On 7/18/24 10:53 AM, Stefan Oltmanns via ffmpeg-devel wrote: The AviSynth patch to remove it by Stephen Hutchinson does not introduce it somewhere else. It is now only called directly at the start in case a needed function cannot be loaded from the DLL. From what I read dlclose is only needed if

[FFmpeg-devel] [PATCH 2/2 v2] avformat/avisynth: remove mutex lock from avisynth_read_close

2024-07-19 Thread Stephen Hutchinson
Signed-off-by: Stephen Hutchinson --- Changes compared to v1: * Adjusted for patch #1's inclusion of dlclose libavformat/avisynth.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 26747671c0..b01263e010 100644 --- a/libavformat/avisynt

[FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-07-19 Thread Stephen Hutchinson
The atexit() handler in the avisynth demuxer was added because there was a conflict in AvxSynth that arose due to their use of C++ global objects, particularly in relation to having added a logging function relying on log4cpp. This conflict was responsible for causing a segfault on exit. It did no

[FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: fix sBIT writing for indexed-color PNGs

2024-07-19 Thread Leo Izen
We currently write invalid sBIT entries for indexed PNGs, which by PNG specification[1] must be 3-bytes long. The values also are capped at 8 for indexed-color PNGs, not the palette depth. This patch fixes both of these issues previously fixed in the decoder, but not the encoder. [1]: https://www.

[FFmpeg-devel] [PATCH 1/2] avcodec/pngdec: use 8-bit sBIT cap for indexed PNGs per spec

2024-07-19 Thread Leo Izen
The PNG specification[1] says that sBIT entries must be at most the bit depth specified in IHDR, unless the PNG is indexed-color, in which case sBIT must be between 1 and 8. We should not reject valid sBITs on PNGs with indexed color. [1]: https://www.w3.org/TR/png-3/#11sBIT Regression since 84b4

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

2024-07-19 Thread Rémi Denis-Courmont
Le torstaina 18. heinäkuuta 2024, 18.04.15 EEST flow gg a écrit : > > Again, I don't think that a maximul multiplier belongs here. If the > > calling code cannot scale the multiplier up, then it should be a normal > > loop providing the same code for all VLENs. > > I think it's acceptable to add s

[FFmpeg-devel] [PATCH] lavu/riscv: do not fallback to AT_HWCAP auxillary vector

2024-07-19 Thread Rémi Denis-Courmont
If __riscv_hwprobe() fails, then the kernel version is presumably too old. There is not much point falling back to the auxillary vector. - The Linux kernel requires I, so the flag is always set on Linux, and run-time detection is unnecessary. Our RISC-V assembler does anyway not support target

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-19 Thread Andrew Sayers
On Fri, Jul 19, 2024 at 05:31:53PM +0200, Paul B Mahol wrote: > Internal/private filter structures/API changes does not need be mentioned > in that file, isn't that fact obvious even for average Joe? The documentation[1] says "FFmpeg guarantees backward API and ABI compatibility for each library",

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-19 Thread Paul B Mahol
Internal/private filter structures/API changes does not need be mentioned in that file, isn't that fact obvious even for average Joe? On Fri, Jul 19, 2024 at 4:01 PM Andrew Sayers wrote: > These are accessed as AV_OPT_TYPE_IMAGE_SIZE AVOptions, > so must be implemented as (signed) int's > --- >

[FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-19 Thread Andrew Sayers
These are accessed as AV_OPT_TYPE_IMAGE_SIZE AVOptions, so must be implemented as (signed) int's --- doc/APIchanges | 6 ++ libavfilter/version_major.h | 1 + libavfilter/vf_tile.c | 4 libavfilter/vf_untile.c | 4 4 files changed, 15 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] lavc/hw_base_encode: correct the timestamp when input_order = decode_delay

2024-07-19 Thread Tong Wu
>From: Tong Wu >Sent: 2024年7月8日 23:13 >To: ffmpeg-devel@ffmpeg.org >Cc: Tong Wu >Subject: [FFmpeg-devel][PATCH 1/2] lavc/hw_base_encode: correct the >timestamp when input_order = decode_delay > >Fixed the command line: ffmpeg -hwaccel vaapi -pix_fmt nv12 -s:v >widthxheight -i input.yuv -vf "hwup

Re: [FFmpeg-devel] [PATCH v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned

2024-07-19 Thread James Almer
On 7/10/2024 11:54 AM, Andrew Sayers wrote: On Wed, Jul 10, 2024 at 04:01:44PM +0200, Paul B Mahol wrote: tile and untile are wrong How so? I think it's better to just make those filters use ints than changing what the API is documented to handle. __

Re: [FFmpeg-devel] [PATCH v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned

2024-07-19 Thread Paul B Mahol
Rudimentary programming skills. Unsigned range of values is different from signed range. On Fri, Jul 19, 2024 at 10:34 AM Andrew Sayers wrote: > Ping > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmp

[FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

2024-07-19 Thread redacted redacted
Hello there, The Sims 1: Unleashed makes use of WVE files for its intro videos. Two of the files for the game use Mono ADPCM audio instead of Stereo. However, FFmpeg's ADPCM_EA codec always expects the files to be in Stereo. In addition, they're supposed to play at 30 fps, but the EA demuxer assu

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Check extradata in mov_read_iacb()

2024-07-19 Thread Michael Niedermayer
On Thu, Jul 18, 2024 at 07:19:17PM -0300, James Almer wrote: > On 7/18/2024 7:16 PM, Michael Niedermayer wrote: > > Fixes: MemLeak > > Fixes: > > 69853/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4660448545275904 > > > > Found-by: continuous fuzzing process > > https://github.com/google

[FFmpeg-devel] [PATCH] hwcontext_vulkan: rewrite upload/download

2024-07-19 Thread Lynne via ffmpeg-devel
This commit was long overdue. The old transfer dubiously tried to merge as much code as possible, and had very little in the way of optimizations, apart from basic host-mapping. The new code uses buffer pools for any temporary bufflers, and handles falling back to buffer-based uploads if host-mapp

Re: [FFmpeg-devel] [PATCH v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned

2024-07-19 Thread Andrew Sayers
Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".