Quoting Michael Niedermayer (2024-07-09 00:24:10)
> Fixes: CID1513722 Operands don't affect result
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer
> ---
> libavfilter/vf_scale.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/libavfilter
Quoting Lynne via ffmpeg-devel (2024-07-09 03:07:12)
> @@ -151,6 +162,17 @@ typedef struct AVVulkanDeviceContext {
> * Similar to lock_queue(), unlocks a queue. Must only be called after
> locking.
> */
> void (*unlock_queue)(struct AVHWDeviceContext *ctx, uint32_t
> queue_family
On Ma, 2024-07-01 at 16:36 +0800, fei.w.wang-at-intel@ffmpeg.org wrote:
> From: Fei Wang
>
> Signed-off-by: Fei Wang
> ---
> libavcodec/vaapi_av1.c | 9 +
> libavcodec/vaapi_decode.c | 5 +++--
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/vaapi_
> On Jul 9, 2024, at 13:47, Helmut K. C. Tessarek wrote:
>
> I'm very sorry to bother the dev list with this, but this is the 2nd time in
> less than a year that the min version of macOS was changed in videotoolbox.
>
> 2023-09-22: macOS 10.13
> now: macOS 12
>
> Will ffmpeg soon only compil
On Di, 2024-07-02 at 01:47 +0200, Michael Niedermayer wrote:
> Fixes: CID1604548 Unused value
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer
> ---
> doc/examples/vaapi_encode.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/examples/vaapi_encode.c b
On So, 2024-07-07 at 20:47 +0200, Michael Niedermayer wrote:
> I am not sure this is possible (thus this requires review)
>
> Fixes: CID1604570 Overflowed constant
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/vaapi_h264.c | 6 +-
> 1 file cha
I'm very sorry to bother the dev list with this, but this is the 2nd
time in less than a year that the min version of macOS was changed in
videotoolbox.
2023-09-22: macOS 10.13
now: macOS 12
Will ffmpeg soon only compile on the current release of macOS (with
videtoolbox support)? While I unde
Finishes implementing ticket #7437.
Signed-off-by: James Almer
---
libavformat/movenc.c| 56 +++--
tests/ref/fate/copy-trac236 | 16 +--
2 files changed, 50 insertions(+), 22 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
in
Addresses part of ticket #7437.
Signed-off-by: James Almer
---
libavformat/mov.c | 78 +
tests/ref/fate/aic | 32 +-
tests/ref/fate/prores-transparency | 4 +-
tests/ref/fate/prores-transparency_skip | 4 +-
4 file
---
libavutil/vulkan.c | 68 ++
libavutil/vulkan.h | 2 +-
2 files changed, 21 insertions(+), 49 deletions(-)
diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c
index e0208c5a7c..d98e863711 100644
--- a/libavutil/vulkan.c
+++ b/libavutil/vulkan.c
@@
The issue with the old mechanism is that we had to introduce new
API each time we needed a new queue family, and all the queue families
were functionally fixed to a given purpose.
Nvidia's GPUs are able to handle video encoding and compute on the
same queue, which results in a speedup when pre-pro
On 08.07.2024 17:32, Zhao Zhili wrote:
On Jul 8, 2024, at 22:07, Timo Rothenpieler wrote:
On 08.07.2024 09:43, Zhao Zhili wrote:
From: Zhao Zhili
av_executor_execute run the task directly when thread is disabled.
The task can schedule a new task by call av_executor_execute. This
forms an i
Fixes: CID1513722 Operands don't affect result
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_scale.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c
index bf09196e10d..120ff473f2e
Helps: CID1513722 Operands don't affect result
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_scale.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c
index 841075193e6..bf09196e10d 10
Found by reviewing CID1513722 Operands don't affect result
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/scale_eval.c | 9 ++---
libavfilter/scale_eval.h | 2 +-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/libavfilter/scale_eval.c b/l
Helps: CID1435164 Out-of-bounds read
Helps: CID1435165 Out-of-bounds read
Helps: CID1435167 Out-of-bounds read
Helps: CID1435169 Out-of-bounds read
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_premultiply.c | 6 +++---
1 file changed, 3 insertions(+), 3
Fix/Robustness/whatever: CID1439575 Out-of-bounds read
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_neighbor_opencl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/vf_neighbor_opencl.c b/libavfilter/vf_neighbor_open
Fixes: CID1604398 Unchecked return value
Fixes: CID1604542 Unchecked return value
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_lut3d.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_l
Fixes: CID1509373 Logically dead code
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_fftfilt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavfilter/vf_fftfilt.c b/libavfilter/vf_fftfilt.c
index 1ffbe02ec41..af0e1f51d24 100644
Fixes: part of CID1355110 Overflowed constant
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_elbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_elbg.c b/libavfilter/vf_elbg.c
index 732a2c8abfb..dd22da07b6b 100644
---
On Sat, 6 Jul 2024 at 09:37, Michael Niedermayer wrote:
>
> On Wed, Jul 03, 2024 at 02:05:06PM -0700, Josh Allmann wrote:
> > Encoders may emit a buffering period SEI without a corresponding
> > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc.
> >
> > During Annex B conversion, this ma
Hi
On Fri, May 03, 2024 at 12:26:52PM +, Niklas Haas wrote:
> ffmpeg | branch: master | Niklas Haas | Wed Apr 24 12:03:00
> 2024 +0200| [bb8044581366fe286e16b14515d873979133dbda] | committer: Niklas
> Haas
>
> avfilter/vf_scale: add optional "ref" input
>
> This is automatically enabled i
TileContext in libavfilter/vf_tile.c and
UntileContext in libavfilter/vf_untile.c
point to unsigned ints - confirm this is OK.
---
Thanks Marcus - have updated my e-mail script to remind myself in future.
libavutil/opt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavut
TileContext in libavfilter/vf_tile.c and
UntileContext in libavfilter/vf_untile.c
point to unsigned ints - confirm this is OK.
---
libavutil/opt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/opt.h b/libavutil/opt.h
index 07e27a9208..9339b1a6ac 100644
--- a/libavut
On 7/8/2024 2:52 PM, Andreas Rheinhardt wrote:
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 4b91283119..a98d33abf3 100644
--- a/libav
On 7/8/2024 2:24 PM, Andreas Rheinhardt wrote:
The check "left >= INT_MAX - right" is supposed to check for
whether left + right does not overflow/wraparound, but given that
left and top are uint32_t INT_MAX - right can already wraparound
for big values of right (and ordinary 32-bit ints):
If rig
On 7/8/2024 2:09 PM, Andreas Rheinhardt wrote:
Forgotten in f194f291d8082134cdce625b0ca3548067428ea9
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index
Use the already available AVCodecParameters pointer instead.
Shortens lines.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaen
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 4b91283119..a98d33abf3 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.
On Sun, 9 Jun 2024, Michael Niedermayer wrote:
Fixes: CID1551679 Data race condition
Fixes: CID1551687 Data race condition
How is this a data race? Concurrent reading and writing is not supported
for UDP as far as I know.
Thanks,
Marton
Sponsored-by: Sovereign Tech Fund
Signed-off-by:
The check "left >= INT_MAX - right" is supposed to check for
whether left + right does not overflow/wraparound, but given that
left and top are uint32_t INT_MAX - right can already wraparound
for big values of right (and ordinary 32-bit ints):
If right == UINT32_MAX, INT_MAX - right is INT_MAX + 1;
Forgotten in f194f291d8082134cdce625b0ca3548067428ea9
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 216cb48884..e1adc0eba6 100644
--- a/libavformat/ma
Leo Izen:
> This test confirms that we can write mDCv chunks and read them back via
> the png decoder. It uses an HEVC conformance sample with this metadata
> as the base source for the side data in the frames.
>
> Signed-off-by: Leo Izen
> Reported-by: Jan Ekström
> ---
> tests/fate/image.mak
This test confirms that we can write mDCv chunks and read them back via
the png decoder. It uses an HEVC conformance sample with this metadata
as the base source for the side data in the frames.
Signed-off-by: Leo Izen
Reported-by: Jan Ekström
---
tests/fate/image.mak| 5 +
tests/ref/f
Signed-off-by: Andreas Rheinhardt
---
libavcodec/decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index cdb682cf69..187b5b6c85 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -1029,7 +1029,7 @@ enum AVPixelFormat
On 7/8/2024 12:58 PM, Andreas Rheinhardt wrote:
This "works" because the public AVCodecHWConfig is at the beginning of
AVCodecHWConfigInternal.
Fixes libavcodec/decode.c:1035:61: runtime error: member access within
null pointer of type 'const struct AVCodecHWConfigInternal'.
Signed-off-by: Andr
This "works" because the public AVCodecHWConfig is at the beginning of
AVCodecHWConfigInternal.
Fixes libavcodec/decode.c:1035:61: runtime error: member access within
null pointer of type 'const struct AVCodecHWConfigInternal'.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/decode.c | 7 +++--
Le maanantaina 1. heinäkuuta 2024, 19.09.01 EEST flow gg a écrit :
> I reviewed it again, the purpose of is_w is to limit lmul to a maximum of
> 1/4 of vlen,
1/4 of vlen? Do you mean limit to EMUL=1 for EEW=32 and EMUL=1/4 for EEW=8?
Limiting LMUL to less than 1 at maximum EEW is useless from a f
> On Jul 8, 2024, at 22:07, Timo Rothenpieler wrote:
>
> On 08.07.2024 09:43, Zhao Zhili wrote:
>> From: Zhao Zhili
>> av_executor_execute run the task directly when thread is disabled.
>> The task can schedule a new task by call av_executor_execute. This
>> forms an implicit recursive call. T
Ping. As the author of d3d12va_encode, I would like to get the access in order
maintain the code and add more new features.
>-Original Message-
>From: wutong1...@outlook.com
>Sent: 2024年7月2日 23:23
>To: ffmpeg-devel@ffmpeg.org
>Cc: Tong Wu
>Subject: [FFmpeg-devel][PATCH] MAINTAINERS: add
It is d3d12va's requirement that the FrameStartOffset must be aligned as
per hardware limitation. However, we could trim this alignment at output
to reduce coded size. A aligned_header_size is added to
D3D12VAEncodePicture.
Signed-off-by: Tong Wu
---
libavcodec/d3d12va_encode.c | 18
Fixed the command line: ffmpeg -hwaccel vaapi -pix_fmt nv12 -s:v
widthxheight -i input.yuv -vf "hwupload" -c:v hevc_vaapi -bf 10 -b_depth 3
-vframes 3 -f null -
Signed-off-by: Tong Wu
---
libavcodec/hw_base_encode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/h
On Mon, 1 Jul 2024 at 12:16, Anton Khirnov wrote:
>
> Quoting Kacper Michajłow (2024-06-02 03:38:18)
> > Fixes libavcodec/decode.c:1035:61: runtime error: member access within
> > null pointer of type 'const struct AVCodecHWConfigInternal'.
> >
> > This can happen when hwaccel fails to initialize
Connecting to an RTSP stream will now cause the SDP attributes of each media
stream to be stored in the codecpar of the relative AVStream.
The SDP attributes are stored in the coded_side_data using the (new) type
AV_PKT_DATA_SDP_ATTRIBUTES (AVPacketSideDataType enum).
Signed-off-by: Bernardo Pila
On 08.07.2024 09:43, Zhao Zhili wrote:
From: Zhao Zhili
av_executor_execute run the task directly when thread is disabled.
The task can schedule a new task by call av_executor_execute. This
forms an implicit recursive call. This patch removed the recursive
call.
---
libavutil/executor.c | 5 +
LGTM.
Thank you, Michael,
On Mon, Jul 8, 2024 at 2:48 AM Michael Niedermayer
wrote:
> Not a bugfix, but might fix CID1604361 Overflowed constant
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/vvc/refs.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Hello,
I have attached a patch with the requested changes.
Thanks,
vckt
From 5ac9b69d1c570eff4bc72ee4469874a9b182537d Mon Sep 17 00:00:00 2001
From: vckt
Date: Fri, 5 Jul 2024 18:51:32 +0530
Subject: [PATCH v2] avformat/hls: Fixed incorrect behaviour of default
setting, added autoselect and forc
Hi,
On Mon, Jul 8, 2024 at 8:34 AM Andrew Sayers
wrote:
> We often say e.g. "this struct currently has such-and-such members, but the
> size is not part of the public API". So it's not much of a stretch to say
> "this preset enables such-and-such features, but the value is not part of
> the
> p
LGTM
thank you, Zhili.
On Mon, Jul 8, 2024 at 3:40 PM Zhao Zhili wrote:
> From: Zhao Zhili
>
> ---
> libavcodec/vvc/thread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc/thread.c b/libavcodec/vvc/thread.c
> index 0cacb1f51c..8dd9a36fd5 100644
> --- a/
On Mon, Jul 8, 2024 at 8:14 PM Zhao Zhili wrote:
> From: Zhao Zhili
>
> av_executor_execute run the task directly when thread is disabled.
> The task can schedule a new task by call av_executor_execute. This
> forms an implicit recursive call. This patch removed the recursive
> call.
>
Thank you
>Envoyé : vendredi 14 juin 2024 13:27
>>Envoyé : lundi 3 juin 2024 12:00
>>>Envoyé : mardi 28 mai 2024 11:11
>>>
>>>This a new ping but I post the patch again to get fate cleanly completed on
>>>patchwork.
>>>
>>https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=11939
>
>To summarize, and fo
On Mon, Jul 08, 2024 at 07:58:44AM -0400, Ronald S. Bultje wrote:
> On Sat, Jul 6, 2024 at 1:29 PM Hendrik Leppkes wrote:
> > On Sat, Jul 6, 2024 at 6:42 PM Michael Niedermayer
[...]
> > > > The entire point of presets is to have them provide a predefined set
> > > > of parameters, easy for users
From: Zhao Zhili
av_executor_execute run the task directly when thread is disabled.
The task can schedule a new task by call av_executor_execute. This
forms an implicit recursive call. This patch removed the recursive
call.
---
v2: use bool type
libavutil/executor.c | 7 +++
1 file changed,
On Thu, Jul 4, 2024 at 11:40 AM Ramiro Polla wrote:
> Every function in yuv2rgb_template.c is only compiled exactly
> once, so detemplatize it.
I'll apply in a few days if there are no comments.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http
On Wed, Jul 3, 2024 at 12:30 AM Ramiro Polla wrote:
> The detection logic for v4l2 and fbdev was accidentally modified to
> depend on v4l2-m2m in 43b3412.
I'll apply in a few days if there are no comments.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmp
Hi,
On Sat, Jul 6, 2024 at 1:29 PM Hendrik Leppkes wrote:
> On Sat, Jul 6, 2024 at 6:42 PM Michael Niedermayer
> wrote:
> >
> > On Sat, Jul 06, 2024 at 02:11:30AM +0200, Hendrik Leppkes wrote:
> > > On Fri, Jul 5, 2024 at 11:34 PM Michael Niedermayer
> > > wrote:
> > > > > /**
> > > > > * The
Hi Michael,
All the patches in that patches look good to me. You can apply.
Steve
On 07/07/2024 22:23, Michael Niedermayer wrote:
Hi Steve
you are listed as maintainer for d3d11va, there are some trivial patches in
this patchset that i cannot easily test
can you either apply/approve/reject/t
From: Zhao Zhili
av_executor_execute run the task directly when thread is disabled.
The task can schedule a new task by call av_executor_execute. This
forms an implicit recursive call. This patch removed the recursive
call.
---
libavutil/executor.c | 5 +
1 file changed, 5 insertions(+)
dif
From: Zhao Zhili
av_executor_execute run the task directly when thread is disabled.
The task can schedule a new task by call av_executor_execute. This
forms an implicit recursive call. This patch removed the recursive
call.
---
libavutil/executor.c | 5 +
1 file changed, 5 insertions(+)
dif
From: Zhao Zhili
---
libavcodec/vvc/thread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vvc/thread.c b/libavcodec/vvc/thread.c
index 0cacb1f51c..8dd9a36fd5 100644
--- a/libavcodec/vvc/thread.c
+++ b/libavcodec/vvc/thread.c
@@ -565,7 +565,7 @@ static void task_
60 matches
Mail list logo