Re: [FFmpeg-devel] [PATCH 3/4] avformat/img2dec: ensure input padding is zeroed

2024-06-26 Thread Paul B Mahol
On Thu, Jun 27, 2024 at 3:57 AM Kacper Michajłow wrote: > Fixes use of uninitialized value, reported by MSAN. Specifically in > jpegxl parser. > > Found by OSS-Fuzz. > > Signed-off-by: Kacper Michajłow > --- > libavformat/img2dec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-26 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-27 01:50:12) > On Tue, Jun 25, 2024 at 09:27:55PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-06-25 21:25:46) > > > On Thu, Mar 28, 2024 at 12:27:02AM +0100, Michael Niedermayer wrote: > > > > On Wed, Mar 27, 2024 at 08:39:17AM +0100, Anton

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-26 Thread Paul B Mahol
On Thu, Jun 27, 2024 at 1:50 AM Michael Niedermayer wrote: > On Tue, Jun 25, 2024 at 09:27:55PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-06-25 21:25:46) > > > On Thu, Mar 28, 2024 at 12:27:02AM +0100, Michael Niedermayer wrote: > > > > On Wed, Mar 27, 2024 at 08:39:17AM +

[FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: Simplify padding cell trim logic

2024-06-26 Thread Marth64
When -trim option is used (by default), padding cells at the beginning of the title are supposed to be ignored. The current implementation does the ignoring when we attempt to lock on to the PGC navigation event stream, but this is a wrong assumption because we have already entered the PGC. This ca

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Simplify padding cell trim logic

2024-06-26 Thread Marth64
Please, ignore this particular patch. I have found a formatting mistake (opportunity to remove braces). I will send a v2. I apologize for the inconvenience. On Thu, Jun 27, 2024 at 12:38 AM Marth64 wrote: > > When -trim option is used (by default), padding cells > at the beginning of the title a

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: Simplify padding cell trim logic

2024-06-26 Thread Marth64
When -trim option is used (by default), padding cells at the beginning of the title are supposed to be ignored. The current implementation does the ignoring when we attempt to lock on to the PGC navigation event stream, but this is a wrong assumption because we have already entered the PGC. This ca

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: Fix duration logic with 1 chapter and validate chapter range

2024-06-26 Thread Marth64
Chapters and duration are calculated together in dvdvideo demuxer. Previous chapter calculation logic treated extraction of 1 chapter using chapter_start and chapter_end switches incorrectly, returning the duration of the entire title instead of just the segment. Fix the logic so that it calculate

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: Do not EOF on WAIT events

2024-06-26 Thread Marth64
A DVDNAV_WAIT event by itself should not warrant an EOF when navigating the program stream. Some discs have WAIT events in the middle of a title, causing playback to end prematurely prior to this fix. Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 17 - 1 file changed, 8

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpegxl_parser: ensure input padding is zeroed

2024-06-26 Thread Andreas Rheinhardt
Kacper Michajłow: > Fixes use of uninitialized value, reported by MSAN. > > Found by OSS-Fuzz. > > Signed-off-by: Kacper Michajłow > --- > libavcodec/jpegxl_parser.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c > index 8c45e1a

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-26 Thread James Almer
On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5791144363491328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libav

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-06-26 Thread Kacper Michajlow
On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer wrote: > > On Wed, Jun 26, 2024 at 09:07:42PM +0200, Kacper Michajlow wrote: > > Hi, > > > > Like in the topic. I think it would be useful to enable MSAN on > > OSS-Fuzz. We get some tiny issues and it would be probably good to > > have them tracke

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check remaining data buffer size

2024-06-26 Thread Kacper Michajlow
On Wed, 26 Jun 2024 at 21:00, Andreas Rheinhardt wrote: > > Kacper Michajłow: > > Fixes use of uninitialized value, reported by MSAN. > > > > Found by OSS-Fuzz. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavcodec/jpegxl_parser.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 dele

[FFmpeg-devel] [PATCH 4/4] avformat/jpegxl_anim_dec: ensure input padding is zeroed

2024-06-26 Thread Kacper Michajłow
Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/jpegxl_anim_dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat/jpegxl_anim_dec.c index ac95d3b961..2338a2e8c0 100644 --- a/

[FFmpeg-devel] [PATCH 3/4] avformat/img2dec: ensure input padding is zeroed

2024-06-26 Thread Kacper Michajłow
Fixes use of uninitialized value, reported by MSAN. Specifically in jpegxl parser. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/img2dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index ba52353074..c667d8574c 100644

[FFmpeg-devel] [PATCH 2/4] avcodec/parser: ensure input padding is zeroed

2024-06-26 Thread Kacper Michajłow
Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index af17ee9c15..426cc314fb 100644 --- a/libavcodec/parser.c +++ b/libavc

[FFmpeg-devel] [PATCH 1/4] avcodec/jpegxl_parser: ensure input padding is zeroed

2024-06-26 Thread Kacper Michajłow
Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/jpegxl_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index 8c45e1a1b7..f833f844c4 100644 --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-26 Thread Michael Niedermayer
On Tue, Jun 25, 2024 at 09:27:55PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-25 21:25:46) > > On Thu, Mar 28, 2024 at 12:27:02AM +0100, Michael Niedermayer wrote: > > > On Wed, Mar 27, 2024 at 08:39:17AM +0100, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2024-

[FFmpeg-devel] [PATCH 3/3] avformat/mov: set Stereo3D type when parsing eyes box

2024-06-26 Thread James Almer
If view is defined in the child stri box, then the type must be set to unspecified, as these boxes don't carry packing information. Signed-off-by: James Almer --- libavformat/mov.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c ind

[FFmpeg-devel] [PATCH 2/3] avutil/stereo3d: add a Stereo3D view to signal that the view is unspecified

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavutil/stereo3d.c | 1 + libavutil/stereo3d.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c index 647f9a952a..d6de476532 100644 --- a/libavutil/stereo3d.c +++ b/libavutil/stereo3d.c @@ -81,6 +81,7 @@ static

[FFmpeg-devel] [PATCH 1/3 v5] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-26 Thread James Almer
Given that a video stream/frame may have only one view or both views coded with the packing information being unavailable, this commit adds a new type value AV_STEREO3D_UNSPEC for this purpose. The most common case for this is container level signaling of Stereo3D video where the specifics are defi

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266: move decoded_picture_hash to CBS SEI

2024-06-26 Thread James Almer
It's defined in H.274 as a common SEI message type and not in H.266 Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 12 ++-- libavcodec/cbs_h266.h | 10 -- libavcodec/cbs_h266_syntax_template.c | 28 --- libavcodec/cb

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_sei: add support for Frame Packing Arrangement SEI parsing

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 20 libavcodec/cbs_h2645.c| 22 + libavcodec/cbs_h264_syntax_template.c | 34 +++ libavcodec/cbs_sei.h | 20 libavcodec

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start

2024-06-26 Thread Michael Niedermayer
On Wed, Jun 26, 2024 at 08:38:43AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-26 01:52:30) > > On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-06-24 01:01:35) > > > > Fixes: NULL pointer dereference > > > > Fixes: > > >

Re: [FFmpeg-devel] [PATCH] avcodec/aac/aacdec_usac: Fix error code for NULL AACDecContext

2024-06-26 Thread Michael Niedermayer
On Thu, Jun 27, 2024 at 12:48:22AM +0200, Michael Niedermayer wrote: > Found-by: Andreas Rheinhardt > > Signed-off-by: Michael Niedermayer > --- > libavcodec/aac/aacdec_usac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch withdrawn, information posted 2 minutes later says it is

[FFmpeg-devel] [PATCH] avcodec/aac/aacdec_usac: Fix error code for NULL AACDecContext

2024-06-26 Thread Michael Niedermayer
Found-by: Andreas Rheinhardt Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec_usac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index 4856c1786b7..3250fd71f6f 100644 --- a/libavcodec/aac/aacdec_usac

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-26 Thread Lynne via ffmpeg-devel
On 26/06/2024 21:45, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: On 26/06/2024 01:57, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-06-26 Thread Michael Niedermayer
On Wed, Jun 26, 2024 at 09:07:42PM +0200, Kacper Michajlow wrote: > Hi, > > Like in the topic. I think it would be useful to enable MSAN on > OSS-Fuzz. We get some tiny issues and it would be probably good to > have them tracked upstream. All infra is here, so enabling it is as > simple as adding

Re: [FFmpeg-devel] [PATCHv2 2/4] avcodec/mm: decode partial palette

2024-06-26 Thread Andreas Rheinhardt
Peter Ross: > Reviewed-by: Andreas Rheinhardt ? > --- > libavcodec/mmvideo.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c > index 3038d9ea92..933d895f96 100644 > --- a/libavcodec/mmvideo.c > +++ b/libavcodec/mm

[FFmpeg-devel] [PATCHv2 4/4] avcodec/mm: decode raw chunk type and skip unknown audio chunk type

2024-06-26 Thread Peter Ross
--- libavcodec/mmvideo.c | 11 +++ libavformat/mm.c | 9 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index d339967702..7313507deb 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -39,6 +39,7 @@

[FFmpeg-devel] [PATCHv2 3/4] avcodec/mm: don't fail if x offset exceeds frame width

2024-06-26 Thread Peter Ross
--- libavcodec/mmvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 933d895f96..d339967702 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -161,7 +161,7 @@ static int mm_decode_inter(MmContext * s, int half_

[FFmpeg-devel] [PATCHv2 2/4] avcodec/mm: decode partial palette

2024-06-26 Thread Peter Ross
Reviewed-by: Andreas Rheinhardt --- libavcodec/mmvideo.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 3038d9ea92..933d895f96 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -78,13 +78,10 @@ static

[FFmpeg-devel] [PATCHv2 1/4] avcodec/mm: set audio pts proportionally to audio offset

2024-06-26 Thread Peter Ross
--- libavformat/mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mm.c b/libavformat/mm.c index 23c025d852..a40b5c44bb 100644 --- a/libavformat/mm.c +++ b/libavformat/mm.c @@ -180,7 +180,8 @@ static int read_packet(AVFormatContext *s, if ((ret = av

Re: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-26 Thread Sean McGovern
Hi, On Thu, Jun 6, 2024, 12:51 Sean McGovern wrote: > > > On Thu, Jun 6, 2024, 05:53 Rémi Denis-Courmont wrote: > >> >> >> Le 6 juin 2024 10:43:05 GMT+03:00, Sean McGovern a >> écrit : >> >Hi, >> > >> >Attached inline is a _non-working_ implementation of flac_wasted32 for >> >VSX developed on

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-26 Thread Andreas Rheinhardt
Lynne via ffmpeg-devel: > On 26/06/2024 01:57, Michael Niedermayer wrote: >> On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: >>> On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NUL

[FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-06-26 Thread Kacper Michajlow
Hi, Like in the topic. I think it would be useful to enable MSAN on OSS-Fuzz. We get some tiny issues and it would be probably good to have them tracked upstream. All infra is here, so enabling it is as simple as adding it to the project.yaml. Except libbz2.so and libz.so would have to be built in

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check remaining data buffer size

2024-06-26 Thread Andreas Rheinhardt
Kacper Michajłow: > Fixes use of uninitialized value, reported by MSAN. > > Found by OSS-Fuzz. > > Signed-off-by: Kacper Michajłow > --- > libavcodec/jpegxl_parser.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_pa

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-26 Thread Michael Niedermayer
On Wed, Jun 26, 2024 at 08:58:27AM +0200, Lynne via ffmpeg-devel wrote: > On 26/06/2024 01:57, Michael Niedermayer wrote: > > On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: > > > On 24/06/2024 01:01, Michael Niedermayer wrote: > > > > ff_aac_usac_config_decode() needs AACDe

Re: [FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS

2024-06-26 Thread Ramiro Polla
Hi, On Wed, Jun 26, 2024 at 8:03 PM Mario Hros wrote: > Previous rewrite from inline assembly into nasm (commit e934194) missed the > required EMMS instruction to bring the x87 FPU back into usable state. > This needs to be done for 8-byte MMX or Extended MMX only. Sorry I didn't catch this thr

Re: [FFmpeg-devel] [PATCH] avutil/riscv/cpu: fix __riscv_v_min_vlen typo

2024-06-26 Thread Rémi Denis-Courmont
Le tiistaina 25. kesäkuuta 2024, 11.58.00 EEST J. Dekker a écrit : > Signed-off-by: J. Dekker > --- > libavutil/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/riscv/cpu.h b/libavutil/riscv/cpu.h > index bb8e08aa14..191e4478c5 100644 > --- a/libavut

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check remaining data buffer size

2024-06-26 Thread Kacper Michajłow
Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/jpegxl_parser.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index 8c45e1a1b7..8371d78a45 10

[FFmpeg-devel] [PATCH] lavu/lls: remove useless VSETVL

2024-06-26 Thread Rémi Denis-Courmont
This changes neither VL nor VTYPE, so it can safely be removed. --- libavutil/riscv/lls_rvv.S | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/riscv/lls_rvv.S b/libavutil/riscv/lls_rvv.S index e0e6f1008e..a36055bd7a 100644 --- a/libavutil/riscv/lls_rvv.S +++ b/libavutil/riscv/lls_rvv.S

[FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS

2024-06-26 Thread Mario Hros
Previous rewrite from inline assembly into nasm (commit e934194) missed the required EMMS instruction to bring the x87 FPU back into usable state. This needs to be done for 8-byte MMX or Extended MMX only. Signed-off-by: Mario Hros --- libswscale/x86/yuv_2_rgb.asm | 4 1 file changed, 4 in

Re: [FFmpeg-devel] [PATCH v4] lavc/vvc_mc: R-V V avg w_avg

2024-06-26 Thread Rémi Denis-Courmont
Le tiistaina 11. kesäkuuta 2024, 21.38.10 EEST u...@foxmail.com a écrit : > +#include "libavutil/riscv/asm.S" > + > +.macro vsetvlstatic8 w, vlen, is_w > +.if \w <= 2 > +vsetivlizero, \w, e8, mf8, ta, ma > +.elseif \w <= 4 && \vlen == 128 > +v

Re: [FFmpeg-devel] [PATCH 2/5] lavc/hevcdec: do not call export_stream_params_from_sei() in update_thread_context()

2024-06-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-06-26 18:13:44) > Anton Khirnov: > > It is redundant, since it only sets AVCodecContext fields that are > > already copied by the generic code. > > --- > > libavcodec/hevc/hevcdec.c | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/libavcodec/hevc/

Re: [FFmpeg-devel] [PATCH 2/5] lavc/hevcdec: do not call export_stream_params_from_sei() in update_thread_context()

2024-06-26 Thread Andreas Rheinhardt
Anton Khirnov: > It is redundant, since it only sets AVCodecContext fields that are > already copied by the generic code. > --- > libavcodec/hevc/hevcdec.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c > index e80f2f28c7..4a62170

Re: [FFmpeg-devel] [PATCH 5/5] lavc/hevcdec: improve check for PPS changing between slices

2024-06-26 Thread Frank Plowman
On 26/06/2024 13:43, Anton Khirnov wrote: > Compare actual PPS objects rather than just PPS ID, as the former might > change while the latter stays the same. > > Reported-by: Michael Niedermayer > --- > libavcodec/hevc/hevcdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

[FFmpeg-devel] [PATCH 5/5] avfilter/vf_showinfo: don't use sizeof(AVSphericalMapping)

2024-06-26 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 72b91329d2..c21dc0a10b 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_show

[FFmpeg-devel] [PATCH 4/5] avfilter/vf_showinfo: only print yaw, pitch, and roll if set

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 98c5632d52..72b91329d2 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -80,10 +80,12 @@ static void

[FFmpeg-devel] [PATCH 3/5] avfilter/vf_showinfo: use av_spherical_projection_name()

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index fdcf9210e7..98c5632d52 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -78

[FFmpeg-devel] [PATCH 2/5] avfilter/vf_showinfo: don't use sizeof(AVStereo3D)

2024-06-26 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 9790c202f5..fdcf9210e7 100644 --- a/libavfilter/vf_showinfo.c +++ b

[FFmpeg-devel] [PATCH 1/5] avfilter/vf_showinfo: print more Stereo 3D fields

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 28d8ea76e9..9790c202f5 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -121,6 +121,16 @@ s

Re: [FFmpeg-devel] [PATCH] add tools/target_swr_fuzzer

2024-06-26 Thread James Almer
On 6/26/2024 8:40 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- Makefile | 2 + tools/Makefile| 3 + tools/target_swr_fuzzer.c | 161 ++ 3 files changed, 166 insertions(+) create mode 100644 tools

[FFmpeg-devel] [PATCH 5/5] lavc/hevcdec: improve check for PPS changing between slices

2024-06-26 Thread Anton Khirnov
Compare actual PPS objects rather than just PPS ID, as the former might change while the latter stays the same. Reported-by: Michael Niedermayer --- libavcodec/hevc/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c

[FFmpeg-devel] [PATCH 2/5] lavc/hevcdec: do not call export_stream_params_from_sei() in update_thread_context()

2024-06-26 Thread Anton Khirnov
It is redundant, since it only sets AVCodecContext fields that are already copied by the generic code. --- libavcodec/hevc/hevcdec.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index e80f2f28c7..4a62170073 100644 --- a/libavcodec/hev

[FFmpeg-devel] [PATCH 1/5] lavc/hevcdec: call export_stream_params_from_sei() before ff_get_buffer()

2024-06-26 Thread Anton Khirnov
So that correct values of color_trc are set on the allocated frame. --- libavcodec/hevc/hevcdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index 1d2e53afc3..e80f2f28c7 100644 --- a/libavcodec/hevc/hevcdec.c ++

[FFmpeg-devel] [PATCH 3/5] lavc/hevcdec: do not pass a pixel format to set_sps()

2024-06-26 Thread Anton Khirnov
It is merely copied to AVCodecContext.pix_fmt, which serves no useful purpose. set_sps() is called from two places: * when a new SPS becomes active - then the pixel format is overridden immediately after the set_sps() call by the result from ff_get_format(); * when a new SPS is propagated acros

[FFmpeg-devel] [PATCH 4/5] lavc/hevcdec: move export_stream_params() from set_sps() to hevc_frame_start()

2024-06-26 Thread Anton Khirnov
The only other caller of set_sps() --- hevc_update_thread_context() --- does not need to call export_stream_params(), since it only updates AVCodecContext fields that have already been updated by generic code. --- libavcodec/hevc/hevcdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[FFmpeg-devel] [PATCH] add tools/target_swr_fuzzer

2024-06-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- Makefile | 2 + tools/Makefile| 3 + tools/target_swr_fuzzer.c | 161 ++ 3 files changed, 166 insertions(+) create mode 100644 tools/target_swr_fuzzer.c diff --git a/Makefile b/Makefile i

[FFmpeg-devel] [PATCH v2] avdevice/v4l2: add NV16 and NV24 pixel formats

2024-06-26 Thread Ramiro Polla
--- libavdevice/v4l2-common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavdevice/v4l2-common.c b/libavdevice/v4l2-common.c index b5b4448a31..ebfd2b6d8d 100644 --- a/libavdevice/v4l2-common.c +++ b/libavdevice/v4l2-common.c @@ -50,6 +50,12 @@ const struct fmt_map ff_fmt_conversio

[FFmpeg-devel] [PATCH] avdevice/v4l2: add NV16 and NV24 pixel formats

2024-06-26 Thread Ramiro Polla
--- libavdevice/v4l2-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/v4l2-common.c b/libavdevice/v4l2-common.c index b5b4448a31..ada9b91263 100644 --- a/libavdevice/v4l2-common.c +++ b/libavdevice/v4l2-common.c @@ -50,6 +50,8 @@ const struct fmt_map ff_fmt_conversion_tab

[FFmpeg-devel] [PATCH v2 5/5] hlsenc: Calculate the average and actual maximum bitrate of segments

2024-06-26 Thread Martin Storsjö
Previously, the bitrate advertised in the master playlist would only be based on the nominal values in either AVCodecParameters bit_rate, or via AVCPBProperties max_bitrate. On top of this, a fudge factor of 10% is added, to account for container overhead. Neither of these bitrates may be known, a

[FFmpeg-devel] [PATCH v2 4/5] hlsenc: When not using HLS_SINGLE_FILE, set vs->size to range_length

2024-06-26 Thread Martin Storsjö
This matches what is done in the corresponding case for HLS_SINGLE_FILE. Normally, vs->size is already initialized correctly - but when writing the initial segment, with mp4 files, vs->size has been set to the size of the init segment, while range_length contains the real size of the first segment

[FFmpeg-devel] [PATCH v2 3/5] hlsenc: Remove bogus check for if (vs->start_pos) for appending segments

2024-06-26 Thread Martin Storsjö
Previously, vs->start_pos was never 0 here, unless using the -hls_segment_size option, which wasn't allowed for SEGMENT_TYPE_FMP4. Therefore, this if statement was practically always taken anyway. Remove this bogus if statement, to allow changing vs->start_pos to reflect the right value when not u

[FFmpeg-devel] [PATCH v2 2/5] hlsenc: Fix setting vs->start_pos when not using HLS_SINGLE_FILE or hls_segment_size

2024-06-26 Thread Martin Storsjö
When not using HLS_SINGLE_FILE or hls_segment_size, we're writing each segment into a separate file. In that case, the file start pos for each segment will be zero. This matches the case in (hls->max_seg_size > 0) above, where we decide to switch to a new file. This fixes the calculation of "vs->

[FFmpeg-devel] [PATCH v2 1/5] hlsenc: Fix the return value accumulation in append_single_file

2024-06-26 Thread Martin Storsjö
Both the read_byte variable (which is accumulated into append_single_file) and the return value are int64_t; give the ret variable the right corresponding type too. --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsen

Re: [FFmpeg-devel] [PATCH 2/4] hlsenc: Fix setting vs->start_pos when not using HLS_SINGLE_FILE or hls_segment_size

2024-06-26 Thread Martin Storsjö
On Mon, 24 Jun 2024, Steven Liu wrote: On Jun 24, 2024, at 16:49, Martin Storsjö wrote: When not using HLS_SINGLE_FILE or hls_segment_size, we're writing each segment into a separate file. In that case, the file start pos for each segment will be zero. This matches the case in (hls->max_se

Re: [FFmpeg-devel] [PATCH] avutil/riscv/cpu: fix __riscv_v_min_vlen typo

2024-06-26 Thread Niklas Haas
On Tue, 25 Jun 2024 10:58:00 +0200 "J. Dekker" wrote: > Signed-off-by: J. Dekker > --- > libavutil/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/riscv/cpu.h b/libavutil/riscv/cpu.h > index bb8e08aa14..191e4478c5 100644 > --- a/libavutil/riscv/cpu

[FFmpeg-devel] [PATCH] avcodec/vvcdec: Fix compiling with MSVC 2022 17.8 and older

2024-06-26 Thread Martin Storsjö
Versions of MSVC older than 17.9 error out here with the following error: src/libavcodec/vvc/filter.c(815): error C2059: syntax error: '}' src/libavcodec/vvc/filter.c(832): error C2065: 'all_zero_bs': undeclared identifier src/libavcodec/vvc/filter.c(836): error C2065: 'all_zero_bs':

Re: [FFmpeg-devel] [PATCH] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support

2024-06-26 Thread Anton Khirnov
Quoting asivery via ffmpeg-devel (2024-06-15 07:57:05) > Right now both the ATRAC1 decoder implementation, and the AEA demuxer don't > accept 4-track and 8-track ATRAC data. This patch fixes that problem. > From c42e05855a018e28159bf29b49137bb33f5e45fd Mon Sep 17 00:00:00 2001 > From: asivery > D

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-26 Thread Anton Khirnov
Quoting Lynne via ffmpeg-devel (2024-06-17 21:04:30) > On 17/06/2024 21:01, Lynne wrote: > > On 17/06/2024 09:35, Anton Khirnov wrote: > >> No tests? > > > > Tests for this particular part are tricky. We still have the SBR issue > > where we add a single sample of delay to the output, which the r