On Wed, Jun 26, 2024 at 08:38:43AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-26 01:52:30) > > On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-06-24 01:01:35) > > > > Fixes: NULL pointer dereference > > > > Fixes: > > > > 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549698459009024 > > > > > > seems wrong > > > > Quite possible, but also your comment seems designed to be unhelpfull > > you leave the reader guessing what issue you saw exactly and why and > > what you think is better. > > My comment is designed to be as helpful as your commit message.
If you find my commit message inadequate, you should state that. Simply ommiting information you know in a reply is not efficient in moving a review forward > > "Fixes: NULL pointer dereference" says almost nothing about what > actually goes wrong. It should be impossible to get to that point with > the SPS being unset. Assuming it somehow does happen, the correct fix is > to prevent it from happening, not add random checks to random places. If it still reproduces when i look next time and noone else fixed it before then ill investigate what exactly is going on. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
