Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Lynne via ffmpeg-devel
On 26/06/2024 01:57, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement/tes

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start

2024-06-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-26 01:52:30) > On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-06-24 01:01:35) > > > Fixes: NULL pointer dereference > > > Fixes: > > > 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/hevc/hevcdec: Do not allow changes to parameter sets between slices

2024-06-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-26 01:27:36) > The specification explcitly doesnt allow the active *PS to change > > "Any PPS NAL unit containing the value of pps_pic_parameter_set_id for the > active PPS RBSP for a coded picture (and > consequently for the layer containing the coded picture

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-06-25 21:43:02) > On 6/25/2024 4:39 PM, Anton Khirnov wrote: > > Quoting James Almer (2024-06-25 21:14:01) > >> On 6/25/2024 4:10 PM, Anton Khirnov wrote: > >>> Quoting James Almer (2024-06-23 01:15:12) > Given that a video stream/frame may have only one or both views

Re: [FFmpeg-devel] [PATCH] aarch64: Add OpenBSD runtime detection of dotprod and i8mm using sysctl

2024-06-25 Thread Brad Smith
On 2024-06-24 4:15 a.m., Martin Storsjö wrote: On Sat, 22 Jun 2024, Brad Smith wrote: [PATCH] aarch64: Add OpenBSD runtime detection of dotprod and i8mm using sysctl Signed-off-by: Brad Smith --- libavutil/aarch64/cpu.c | 35 +++ 1 file changed, 35 insertions(+

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Michael Niedermayer
On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: > On 24/06/2024 01:01, Michael Niedermayer wrote: > > ff_aac_usac_config_decode() needs AACDecContext to be set but some callers > > pass NULL. > > > > I have no real testcase to implement/test this, so failing in this case >

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start

2024-06-25 Thread Michael Niedermayer
On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-24 01:01:35) > > Fixes: NULL pointer dereference > > Fixes: > > 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549698459009024 > > seems wrong Quite possible, but also your

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Lynne via ffmpeg-devel
On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement/test this, so failing in this case seems safest. Fixes: member access within null pointer of type 'AACDecContext' (aka 'stru

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/hevc/hevcdec: Do not allow changes to parameter sets between slices

2024-06-25 Thread Michael Niedermayer
On Tue, Jun 25, 2024 at 10:59:14AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-24 01:01:34) > > The slice code detects changes by comparing the pps index. > > That way the code cannot detect changes if the sets can change. > > > > Fixes: out of array access > > Fixes: > > 6

[FFmpeg-devel] [PATCH] avformat/nuv: return early if header id fails to read

2024-06-25 Thread Kacper Michajłow
Fixes use of uninitialized value in memcmp below, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/nuv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/nuv.c b/libavformat/nuv.c index 507a73b0fe..49915ecf16 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-25 Thread Ramiro Polla
On Thu, Jun 20, 2024 at 4:59 PM Ramiro Polla wrote: > checkasm gets a little spammy with this commit by printing "No > accelerated colorspace conversion found from %s to %s.\n" from > libswscale/yuv2rgb.c multiple times. Any suggestions? Perhaps > downgrading that message to AV_LOG_VERBOSE, or rai

Re: [FFmpeg-devel] [PATCH] libswscale/x86/yuv2rgb: Add missing EMMS

2024-06-25 Thread Michael Niedermayer
On Tue, Jun 11, 2024 at 05:19:06PM +, Mario Hros wrote: > Ping? > > Not including EMMS causes the FPU to become unusable (as the IE and SF bits > are set in the status word). This breaks code which, for instance, calls > fmod() and is compiled by GCC with the -O3 flag enabled. In that scenar

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing

2024-06-25 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sat, Apr 27, 2024 at 01:13:54PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> Fixes: NULL pointer dereference >>> Fixes: >>> 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP8_fuzzer-6180311026171904 >>> >>> Found-by: continuous fuzzing process >>

Re: [FFmpeg-devel] [PATCH 1/2] swscale/output: alpha can become negative after scaling, use multiply

2024-06-25 Thread Michael Niedermayer
On Sun, Jun 16, 2024 at 09:48:30AM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -3245 > Fixes: 69047/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6571511551950848 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmp

Re: [FFmpeg-devel] [PATCH 8/9] avcodec/smcenc: width < 4 is unsupported

2024-06-25 Thread Michael Niedermayer
On Tue, Jun 18, 2024 at 09:42:50AM +0200, Paul B Mahol wrote: > Fixed by making nx/ny always >= 0. will apply your commit thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out of college or go to

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/targaenc: Allocate space for the palette

2024-06-25 Thread Michael Niedermayer
On Mon, Jun 17, 2024 at 01:08:23AM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 68927/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TARGA_fuzzer-5105665067515904 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ff

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/r210enc: Use av_rescale for bitrate

2024-06-25 Thread Michael Niedermayer
On Mon, Jun 17, 2024 at 01:08:31AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 281612954574848 * 65344 cannot be represented > in type 'long' > Fixes: > 68956/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_R210_fuzzer-6459074458746880 > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/ratecontrol: Try to keep fps as a rational

2024-06-25 Thread Michael Niedermayer
On Tue, Jun 18, 2024 at 03:48:21PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ratecontrol.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) will apply patches 2,4,5 [...] -- Michael GnuPG fingerprint: 9FF2128B14

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing

2024-06-25 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 01:13:54PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: NULL pointer dereference > > Fixes: > > 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP8_fuzzer-6180311026171904 > > > > Found-by: continuous fuzzing process > > https://github.com/go

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread James Almer
On 6/25/2024 4:39 PM, Anton Khirnov wrote: Quoting James Almer (2024-06-25 21:14:01) On 6/25/2024 4:10 PM, Anton Khirnov wrote: Quoting James Almer (2024-06-23 01:15:12) Given that a video stream/frame may have only one or both views coded with the packing information being unavailable, this c

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-06-25 21:14:01) > On 6/25/2024 4:10 PM, Anton Khirnov wrote: > > Quoting James Almer (2024-06-23 01:15:12) > >> Given that a video stream/frame may have only one or both views coded with > >> the packing information being unavailable, this commit adds a new type > >> valu

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-25 21:25:46) > On Thu, Mar 28, 2024 at 12:27:02AM +0100, Michael Niedermayer wrote: > > On Wed, Mar 27, 2024 at 08:39:17AM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-03-23 00:08:16) > > > > Fixes: Timeout > > > > Fixes: > > > > 67044/cl

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-25 Thread Michael Niedermayer
On Thu, Mar 28, 2024 at 12:27:02AM +0100, Michael Niedermayer wrote: > On Wed, Mar 27, 2024 at 08:39:17AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-03-23 00:08:16) > > > Fixes: Timeout > > > Fixes: > > > 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-57911443634

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust threshold for MV30

2024-06-25 Thread Michael Niedermayer
On Fri, Dec 29, 2023 at 12:38:23AM +0100, Michael Niedermayer wrote: > Fixes: > 60867/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-6381933108527104 > Fixes: Timeout > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Adjust threshold for jpeg2000

2024-06-25 Thread Michael Niedermayer
On Sun, Jul 23, 2023 at 01:46:21AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 57385/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5394334324490240 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Si

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread James Almer
On 6/25/2024 4:10 PM, Anton Khirnov wrote: Quoting James Almer (2024-06-23 01:15:12) Given that a video stream/frame may have only one or both views coded with the packing information being unavailable, this commit adds a new type value AV_STEREO3D_UNSPEC for this purpose. The most common case f

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-06-23 01:15:12) > Given that a video stream/frame may have only one or both views coded with > the packing information being unavailable, this commit adds a new type value > AV_STEREO3D_UNSPEC for this purpose. > The most common case for this is container level signaling o

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread James Almer
On 6/25/2024 3:30 PM, Vittorio Giovara wrote: On Sun, Jun 23, 2024 at 1:16 AM James Almer wrote: Given that a video stream/frame may have only one or both views coded with the packing information being unavailable, this commit adds a new type value AV_STEREO3D_UNSPEC for this purpose. not t

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread Vittorio Giovara
On Sun, Jun 23, 2024 at 1:16 AM James Almer wrote: > Given that a video stream/frame may have only one or both views coded with > the packing information being unavailable, this commit adds a new type > value > AV_STEREO3D_UNSPEC for this purpose. > not to bikeshed the name, but why UNSPEC inste

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type

2024-06-25 Thread James Almer
On 6/25/2024 3:13 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/packet.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index a9a41576da..9dee035690 100644 --- a/libavcodec/packet.h +++ b/li

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type

2024-06-25 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/packet.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavcodec/packet.h b/libavcodec/packet.h > index a9a41576da..9dee035690 100644 > --- a/libavcodec/packet.h > +++ b/libavcodec/packet.h > @@ -330,6 +330,

[FFmpeg-devel] [PATCH] lavc/vvc: Don't discard return codes

2024-06-25 Thread Frank Plowman
Signed-off-by: Frank Plowman --- libavcodec/vvc/thread.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/thread.c b/libavcodec/vvc/thread.c index c90c316661..118d56b67e 100644 --- a/libavcodec/vvc/thread.c +++ b/libavcodec/vvc/thread.c @@ -443,8 +443,11

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Validate IBC block vector

2024-06-25 Thread Frank Plowman
On 25/06/2024 15:19, Nuo Mi wrote: > On Mon, Jun 24, 2024 at 9:31 PM Frank Plowman wrote: > >> From H.266 (V3) (09/2023) p. 321: >> >> It is a requirement of bitstream conformance that the luma block >> vector bvL shall obey the following constraints: >> - CtbSizeY is greater than or equal to >>

[FFmpeg-devel] [PATCH v2] lavc/vvc: Validate IBC block vector

2024-06-25 Thread Frank Plowman
From H.266 (V3) (09/2023) p. 321: It is a requirement of bitstream conformance that the luma block vector bvL shall obey the following constraints: - CtbSizeY is greater than or equal to ((yCb + (bvL[ 1 ] >> 4)) & (CtbSizeY − 1)) + cbHeight This patch checks this is true, which fixes crashes on f

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Don't adapt (last|next)_pic.linesize for field pics

2024-06-25 Thread Michael Niedermayer
On Mon, Jun 24, 2024 at 02:01:42AM +0200, Andreas Rheinhardt wrote: > These values are not read anywhere. Furthermore, since commit > fe6037fd04db8837dcdb9013f9c4ad4e7eb0592e the linesize values > of the MPVWorkPictures were wrong for subsequent fields > in a chain of B-pictures (as they are always

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-25 Thread Niklas Haas
On Mon, 24 Jun 2024 16:44:33 +0200 Vittorio Giovara wrote: > On Sun, Jun 23, 2024 at 7:57 PM James Almer wrote: > > > On 6/22/2024 7:19 PM, Vittorio Giovara wrote: > > > Needless to say I support the plan of renaming the library so that it can > > > be inline with the other libraries names, and

Re: [FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

2024-06-25 Thread Nuo Mi
On Tue, Jun 25, 2024 at 8:48 PM James Almer wrote: > On 6/25/2024 8:53 AM, Nuo Mi wrote: > > On Sat, Jun 22, 2024 at 2:24 PM Nuo Mi wrote: > > > >> see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 > >> > >> passed files: > >> GDR_A_ERICSSON_2.bit > >> GDR_B_NOKIA_2.

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Validate IBC block vector

2024-06-25 Thread Nuo Mi
On Mon, Jun 24, 2024 at 9:31 PM Frank Plowman wrote: > From H.266 (V3) (09/2023) p. 321: > > It is a requirement of bitstream conformance that the luma block > vector bvL shall obey the following constraints: > - CtbSizeY is greater than or equal to > ((yCb + (bvL[ 1 ] >> 4)) & (CtbSizeY − 1)) +

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping

2024-06-25 Thread Anton Khirnov
Quoting Paul B Mahol (2024-06-25 15:23:53) > On Tue, Jun 25, 2024 at 3:12 PM Anton Khirnov wrote: > > I expect plenty of broken files from various sources where the user will > > want to selectively ignore either codec or container cropping. > > So we could make this an enum option, with values >

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2024-06-25 Thread Paul B Mahol
On Tue, Jun 25, 2024 at 3:17 PM Dennis Mungai wrote: > On Tue, 25 Jun 2024 at 16:07, Paul B Mahol wrote: > > > On Tue, Jun 25, 2024 at 2:47 PM Dennis Mungai wrote: > > > > > On Sun, 28 Jun 2020 at 16:59, James Almer wrote: > > > > > > > On 6/27/2020 7:54 AM, Paul B Mahol wrote: > > > > > On 6/

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping

2024-06-25 Thread Paul B Mahol
On Tue, Jun 25, 2024 at 3:12 PM Anton Khirnov wrote: > Quoting James Almer (2024-06-25 14:38:58) > > On 6/25/2024 7:25 AM, Anton Khirnov wrote: > > > Quoting James Almer (2024-05-31 01:22:51) > > >> @@ -1000,11 +1001,21 @@ int ist_filter_add(InputStream *ist, > InputFilter *ifilter, int is_simple

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2024-06-25 Thread Dennis Mungai
On Tue, 25 Jun 2024 at 16:07, Paul B Mahol wrote: > On Tue, Jun 25, 2024 at 2:47 PM Dennis Mungai wrote: > > > On Sun, 28 Jun 2020 at 16:59, James Almer wrote: > > > > > On 6/27/2020 7:54 AM, Paul B Mahol wrote: > > > > On 6/26/20, James Almer wrote: > > > >> On 6/26/2020 4:16 PM, Lynne wrote:

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-06-25 14:38:58) > On 6/25/2024 7:25 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-05-31 01:22:51) > >> @@ -1000,11 +1001,21 @@ int ist_filter_add(InputStream *ist, InputFilter > >> *ifilter, int is_simple, > >> ist->filters[ist->nb_filters - 1] = ifilter; >

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2024-06-25 Thread Paul B Mahol
On Tue, Jun 25, 2024 at 2:47 PM Dennis Mungai wrote: > On Sun, 28 Jun 2020 at 16:59, James Almer wrote: > > > On 6/27/2020 7:54 AM, Paul B Mahol wrote: > > > On 6/26/20, James Almer wrote: > > >> On 6/26/2020 4:16 PM, Lynne wrote: > > >>> Jun 26, 2020, 19:05 by jamr...@gmail.com: > > >>> > > >>

Re: [FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

2024-06-25 Thread James Almer
On 6/25/2024 8:53 AM, Nuo Mi wrote: On Sat, Jun 22, 2024 at 2:24 PM Nuo Mi wrote: see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 passed files: GDR_A_ERICSSON_2.bit GDR_B_NOKIA_2.bit GDR_C_NOKIA_2.bit VIRTUAL_A_MediaTek_3.bit VIRTUAL_B_MediaTek_3.

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping

2024-06-25 Thread James Almer
On 6/25/2024 7:25 AM, Anton Khirnov wrote: Quoting James Almer (2024-05-31 01:22:51) @@ -1000,11 +1001,21 @@ int ist_filter_add(InputStream *ist, InputFilter *ifilter, int is_simple, ist->filters[ist->nb_filters - 1] = ifilter; if (ist->par->codec_type == AVMEDIA_TYPE_VIDEO) { +

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2024-06-25 Thread Dennis Mungai
On Sun, 28 Jun 2020 at 16:59, James Almer wrote: > On 6/27/2020 7:54 AM, Paul B Mahol wrote: > > On 6/26/20, James Almer wrote: > >> On 6/26/2020 4:16 PM, Lynne wrote: > >>> Jun 26, 2020, 19:05 by jamr...@gmail.com: > >>> > On 6/26/2020 1:58 PM, Paul B Mahol wrote: > > > On 6/26/20

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-25 Thread Nuo Mi
On Mon, Jun 24, 2024 at 12:48 PM Zhao Zhili wrote: > From: Zhao Zhili > > Before the patch, disable threads support at configure/build time > was the only method to force zero thread in executor. However, > it's common practice for libavcodec to run on caller's thread when > user specify thread

[FFmpeg-devel] [PATCH v1] avcodec/evc: Alterations following changes in libxeve

2024-06-25 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- configure| 2 +- libavcodec/libxeve.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 06a72e4114..de53fd4c68 100755 --- a/configure +++ b/configure @@ -7031,7 +7031,7 @@ enabled libx265

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-25 Thread Ramiro Polla
On Tue, Jun 25, 2024 at 11:19 AM Anton Khirnov wrote: > Quoting Ramiro Polla (2024-06-20 17:40:39) > > This commit adds support for V4L2's multiplanar API, but only when the > > number of planes is 1. > > > > Adding full support for the multiplanar API would require a device that > > actually uses

Re: [FFmpeg-devel] [PATCH 4/4] checkasm/vvc_alf: ensure right and bottom boundaries are not overwritten by asm

2024-06-25 Thread Nuo Mi
Applied. Thank you Ben for reviewing. On Sat, Jun 22, 2024 at 12:21 PM Nuo Mi wrote: > --- > tests/checkasm/vvc_alf.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c > index be8b930810..15e79289cd 100644 > ---

Re: [FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

2024-06-25 Thread Nuo Mi
On Sat, Jun 22, 2024 at 2:24 PM Nuo Mi wrote: > see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 > > passed files: > GDR_A_ERICSSON_2.bit > GDR_B_NOKIA_2.bit > GDR_C_NOKIA_2.bit > VIRTUAL_A_MediaTek_3.bit > VIRTUAL_B_MediaTek_3.bit > Applied. thank you >

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-05-31 01:22:51) > @@ -1000,11 +1001,21 @@ int ist_filter_add(InputStream *ist, InputFilter > *ifilter, int is_simple, > ist->filters[ist->nb_filters - 1] = ifilter; > > if (ist->par->codec_type == AVMEDIA_TYPE_VIDEO) { > +const AVPacketSideData *sd =

Re: [FFmpeg-devel] [PATCH 5/6] fftools/ffmpeg: support applying container level cropping

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-05-29 23:46:31) > @@ -254,6 +256,11 @@ typedef struct InputFilterOptions { > * accurate */ > AVRational framerate; > > +unsigned crop_top; > +unsigned crop_bottom; > +unsigned crop_left; > +unsigned crop_right; breaks vertical alignme

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-25 Thread Anton Khirnov
Quoting Ramiro Polla (2024-06-20 17:40:39) > This commit adds support for V4L2's multiplanar API, but only when the > number of planes is 1. > > Adding full support for the multiplanar API would require a device that > actually uses more than 1 plane, which I have not found yet. Out of curiosity,

Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-06-25 Thread Paul B Mahol
On Tue, Jun 25, 2024 at 11:10 AM Anton Khirnov wrote: > Quoting Stefan Oltmanns via ffmpeg-devel (2024-06-22 03:37:03) > > Hello, > > > > this is my first patch, I hope I got all the formalities correct. > > > > The current VapourSynth implementation is rarely used, as it links the > > VapourSynt

Re: [FFmpeg-devel] [PATCH] ffprobe: always print all Stereo3D fields

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-06-18 21:03:12) > ffprobe is meant to generate parseable output, and if a field is present, it > should be printed even if it has a default value. This approach implies that adding new fields will change existing output, possibly just by updating the libraries without any

Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-06-25 Thread Anton Khirnov
Quoting Stefan Oltmanns via ffmpeg-devel (2024-06-22 03:37:03) > Hello, > > this is my first patch, I hope I got all the formalities correct. > > The current VapourSynth implementation is rarely used, as it links the > VapourSynth library at build time, making the resulting build unable to > run

[FFmpeg-devel] [PATCH] configure: Fix Apple framework dependencies in .pc file

2024-06-25 Thread Zhao Zhili
From: Zhao Zhili configure use "-Wl,-framework,foo" and "-framework foo" to specify dependencies on Apple frameworks. These two styles essentially do the same thing when build ffmpeg. However, they do make difference when generate pkg-config files. Some tools interact with pkg-config cannot handl

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices

2024-06-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-24 01:01:36) > An alternative would be to leave the context unchanged on failure of > hls_slice_header() There's already slice_initialized. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start

2024-06-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-24 01:01:35) > Fixes: NULL pointer dereference > Fixes: > 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549698459009024 seems wrong -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/hevc/hevcdec: Do not allow changes to parameter sets between slices

2024-06-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-24 01:01:34) > The slice code detects changes by comparing the pps index. > That way the code cannot detect changes if the sets can change. > > Fixes: out of array access > Fixes: > 69585/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6389604524

[FFmpeg-devel] [PATCH] avutil/riscv/cpu: fix __riscv_v_min_vlen typo

2024-06-25 Thread J. Dekker
Signed-off-by: J. Dekker --- libavutil/riscv/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/riscv/cpu.h b/libavutil/riscv/cpu.h index bb8e08aa14..191e4478c5 100644 --- a/libavutil/riscv/cpu.h +++ b/libavutil/riscv/cpu.h @@ -65,7 +65,7 @@ static inline size_t f

Re: [FFmpeg-devel] [PATCH] Allow enabling SVC in libaomenc

2024-06-25 Thread Anton Khirnov
Quoting Chun-Min Chang (2024-06-24 20:50:59) > +const AVDictionaryEntry *en = NULL; > +while ((en = av_dict_iterate(ctx->svc_parameters, en))) { > +if (!strlen(en->value)) > +return AVERROR(EINVAL); > + > +if (!strcmp(en->key, "number_spatial_

Re: [FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: add a Stereo3D type to signal that the packing is defined by the view field

2024-06-25 Thread Anton Khirnov
Quoting James Almer (2024-06-22 04:41:11) > Given that a video stream/frame may have only one view coded, or both packed > in > an undefined way, and as the values of AVStereo3DView and AVStereo3DType may > clash (namely if type is AV_STEREO3D_2D, then AV_STEREO3D_VIEW_PACKED would be > invalid, a

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/hevcdec: Update slice index before hwaccel decode slice

2024-06-25 Thread Anton Khirnov
Quoting fei.w.wang-at-intel@ffmpeg.org (2024-06-24 08:23:31) > From: Fei Wang > > Otherwise, slice index will never update for hwaccel decode, and slice > RPL will be always overlap into first one which use slice index to construct. > > Fixes hwaccel decoding after 47d34ba7fbb81 > > Signed-