[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: fix vtctx reset condition

In vtenc_populate_extradata, the cleanup function vtenc_reset should not be used when no error occurs, otherwise some color information is lost (#11036). This patch checks the status code and conducts the correct cleanup. Signed-off-by: Hao Guan --- libavcodec/videotoolboxenc.c | 9 - 1

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/hevcdec: Put slice address checking after hwaccel decode slice

On Wed, 2024-06-19 at 10:27 +0800, fei.w.w...@intel.com wrote: > From: Fei Wang > > Slice address tab only been updated in software decode slice data. > > Fixes hwaccel decoding after > d725c737fe2a19091b481d4d115fd939e0a674b2. > > Signed-off-by: Fei Wang > --- >  libavcodec/hevc/hevcdec.c | 1

[FFmpeg-devel] [PATCH] avcodec/nvenc: Fix segfault with intra-only

In intra-only mode, frameIntervalP is 0, which means the frame data array is smaller than the number of surfaces. This causes a crash when closing the encoder. Fix this by making sure the frame data array is at least as big as the number of surfaces. --- libavcodec/nvenc.c | 2 +- 1 file changed,

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000dec: Add support for placeholder passes, CAP, and CPF markers

> On Jun 19, 2024, at 17:27, Tomas Hardin wrote: > > ons 2024-06-19 klockan 05:51 + skrev WATANABE Osamu: >> First of all, I appreciate your kind review. >> I'm writing to discuss the changes and would like to hear your >> feedback on these. >> >> >>> On Jun 18, 2024, at 23:20, Tomas Hard

Re: [FFmpeg-devel] [PATCH 5/9] avformat/mov: Check extend and base offset

On 6/20/2024 7:54 PM, Michael Niedermayer wrote: On Wed, Jun 19, 2024 at 03:08:58PM +0200, Rémi Denis-Courmont wrote: Le 19 juin 2024 14:34:59 GMT+02:00, James Almer a écrit : On 6/18/2024 4:07 AM, Rémi Denis-Courmont wrote: Le 17 juin 2024 01:08:27 GMT+02:00, Michael Niedermayer a écri

Re: [FFmpeg-devel] [PATCH 5/9] avformat/mov: Check extend and base offset

On Wed, Jun 19, 2024 at 03:08:58PM +0200, Rémi Denis-Courmont wrote: > > > Le 19 juin 2024 14:34:59 GMT+02:00, James Almer a écrit : > >On 6/18/2024 4:07 AM, Rémi Denis-Courmont wrote: > >> > >> > >> Le 17 juin 2024 01:08:27 GMT+02:00, Michael Niedermayer > >> a écrit : > >>> Fixes: signed i

[FFmpeg-devel] [PATCH 2/2] avfilter/textutils: Constify ff_expand_text()

Signed-off-by: Andreas Rheinhardt --- libavfilter/textutils.c | 6 +++--- libavfilter/textutils.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/textutils.c b/libavfilter/textutils.c index 0b132fd153..e6b5239b20 100644 --- a/libavfilter/textutils.c +++ b/libavf

[FFmpeg-devel] [PATCH 1/2] avfilter/textutils, vf_drawtext, qrencode: Constify function pointers

Signed-off-by: Andreas Rheinhardt --- libavfilter/qrencode.c| 2 +- libavfilter/textutils.c | 2 +- libavfilter/textutils.h | 2 +- libavfilter/vf_drawtext.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/qrencode.c b/libavfilter/qrencode.c index 0b1f7b

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin wrote: > > tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > > > > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > > > > From: Pierre-Anthony Lemieux > > > > >

[FFmpeg-devel] [PATCH 1/2] avfilter/textutils, vf_drawtext, qrencode: Constify function pointers

Signed-off-by: Andreas Rheinhardt --- libavfilter/qrencode.c| 2 +- libavfilter/textutils.c | 2 +- libavfilter/textutils.h | 2 +- libavfilter/vf_drawtext.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/qrencode.c b/libavfilter/qrencode.c index 0b1f7b

[FFmpeg-devel] [PATCH 4/4] avcodec/mpegvideo_enc: Do not duplicate pictures on shifting

Fixes: out of array access Fixes: 69098/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG2VIDEO_fuzzer-6107989688778752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_enc.c | 2

[FFmpeg-devel] [PATCH 3/4] avcodec/mpeg12enc: Use av_rescale() in vbv_buffer_size computation

Fixes: signed integer overflow: 20 * 2314885530818453759 cannot be represented in type 'long' Fixes: 69098/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG2VIDEO_fuzzer-6107989688778752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sig

[FFmpeg-devel] [PATCH 2/4] avcodec/utvideoenc: Use unsigned shift to build flags

Fixes: left shift of 255 by 24 places cannot be represented in type 'int' Fixes: 69083/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_UTVIDEO_fuzzer-5608202363273216 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nied

[FFmpeg-devel] [PATCH 1/4] avcodec/j2kenc: Merge dwt_norm into lambda

This moves computations out of a loop Fixes: signed integer overflow: 31665934879948800 * 9998 cannot be represented in type 'long' Fixes: 69024/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5949662967169024 Found-by: continuous fuzzing process https://github.com/google/oss

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: don't use sizeof(AVMasteringDisplayMetadata)

ons 2024-06-19 klockan 15:24 -0300 skrev James Almer: > It's not part of the libavutil ABI. > > Signed-off-by: James Almer > --- >  libavformat/mxfdec.c | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 852fb7e056..a

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add bgra/rgba to yuv

Le 20 juin 2024 18:02:31 GMT+02:00, Zhao Zhili a écrit  : > > >> On Jun 20, 2024, at 20:49, Martin Storsjö wrote: >> >> On Thu, 20 Jun 2024, Zhao Zhili wrote: >> On Jun 19, 2024, at 20:05, Rémi Denis-Courmont wrote: Le 19 juin 2024 11:24:28 GMT+02:00, Zhao Zhili >>>

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add bgra/rgba to yuv

> On Jun 20, 2024, at 20:49, Martin Storsjö wrote: > > On Thu, 20 Jun 2024, Zhao Zhili wrote: > >>> On Jun 19, 2024, at 20:05, Rémi Denis-Courmont wrote: >>> Le 19 juin 2024 11:24:28 GMT+02:00, Zhao Zhili >> > a écrit : > On Jun 19, 2024, at 15:07, Rémi Deni

Re: [FFmpeg-devel] [PATCH 1/3] avutil/ambient_viewing_environment: set a sane default value for AVRational fields

On 6/18/2024 4:20 PM, James Almer wrote: Prevent potential divisions by 0 when using them immediately after allocation. Signed-off-by: James Almer --- libavutil/ambient_viewing_environment.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavutil/ambient_viewing_environment

Re: [FFmpeg-devel] [PATCH] ffprobe: always print all Stereo3D fields

On 6/18/2024 4:03 PM, James Almer wrote: ffprobe is meant to generate parseable output, and if a field is present, it should be printed even if it has a default value. Signed-off-by: James Almer --- fftools/ffprobe.c| 9 +++-- tests/ref/fate/matroska-spherica

[FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

This commit adds support for V4L2's multiplanar API, but only when the number of planes is 1. Adding full support for the multiplanar API would require a device that actually uses more than 1 plane, which I have not found yet. --- libavdevice/v4l2.c | 93 +-

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

On Mon, Jun 17, 2024 at 12:28 AM Ramiro Polla wrote: > > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/sw_yuv2rgb.c | 205 > tests/fate/checkasm.mak | 1 + > 5 f

Re: [FFmpeg-devel] [PATCH 6/6] swscale/yuv2rgb/x86: remove mmx/mmxext yuv2rgb functions

On Mon, Jun 17, 2024 at 2:46 PM Ramiro Polla wrote: > On Mon, Jun 17, 2024 at 1:16 AM James Almer wrote: > > On 6/16/2024 7:28 PM, Ramiro Polla wrote: > > > These functions are either slower or barely faster than the C LUT > > > yuv2rgb code. > > > --- > > > libswscale/x86/yuv2rgb.c |

Re: [FFmpeg-devel] [PATCH v3 0/5] avcodec/dovi - disable metadata compression by default

> On Jun 19, 2024, at 3:21 AM, Niklas Haas wrote: > > On Thu, 23 May 2024 19:50:23 + Cosmin Stejerean via ffmpeg-devel > wrote: >> From: Cosmin Stejerean >> >> not all clients support metadata compression, output when >> vdr_dm_metadata_changed fails the DV verifier. >> >> Compared to

Re: [FFmpeg-devel] [PATCH v3] movenc: Add an option for resilient, hybrid fragmented/non-fragmented muxing

On 2024-06-20 15:47, Timo Rothenpieler wrote: On 20/06/2024 15:46, Martin Storsjö wrote: On Wed, 19 Jun 2024, Martin Storsjö wrote: This allows ending up with a normal, non-fragmented file when the file is finished, while keeping the file readable if writing is aborted abruptly at any point. (

Re: [FFmpeg-devel] [PATCH v3] movenc: Add an option for resilient, hybrid fragmented/non-fragmented muxing

On 20/06/2024 15:46, Martin Storsjö wrote: On Wed, 19 Jun 2024, Martin Storsjö wrote: This allows ending up with a normal, non-fragmented file when the file is finished, while keeping the file readable if writing is aborted abruptly at any point. (Normally when writing a mov/mp4 file, the unfin

Re: [FFmpeg-devel] [PATCH v3] movenc: Add an option for resilient, hybrid fragmented/non-fragmented muxing

On Wed, 19 Jun 2024, Martin Storsjö wrote: This allows ending up with a normal, non-fragmented file when the file is finished, while keeping the file readable if writing is aborted abruptly at any point. (Normally when writing a mov/mp4 file, the unfinished file is completely useless unless it i

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add bgra/rgba to yuv

On Thu, 20 Jun 2024, Zhao Zhili wrote: On Jun 19, 2024, at 20:05, Rémi Denis-Courmont wrote: Le 19 juin 2024 11:24:28 GMT+02:00, Zhao Zhili mailto:quinkbl...@foxmail.com>> a écrit : On Jun 19, 2024, at 15:07, Rémi Denis-Courmont wrote: Le 15 juin 2024 11:57:18 GMT+02:00, Zhao Zhili a é

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

On Wed, Jun 19, 2024 at 4:53 PM Nuo Mi wrote: > Hi all, > I will merge this tomorrow if there are no objections. > >> >>> Applied. Thank you, Frank, Christophe, Mark, and Anton, for a good discussion. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH v2] fate/vvc: add vvc-conformance-RPR_A_4

Sorry for missing this. Merged by James as https://github.com/FFmpeg/FFmpeg/commit/0eacad6921c6835d0432f02b1aa5ec9b492a3572 Thank you, James and Frank On Thu, Jun 20, 2024 at 6:13 PM Frank Plowman wrote: > On 10/06/2024 18:46, Frank Plowman wrote: > > Before

Re: [FFmpeg-devel] [PATCH] avformat: split off generic NAL function helpers into their own file

On Sun, Jun 16, 2024 at 7:09 PM James Almer wrote: > diff --git a/libavformat/nal.h b/libavformat/nal.h > new file mode 100644 > index 00..ce49ea70b0 > --- /dev/null > +++ b/libavformat/nal.h > @@ -0,0 +1,66 @@ > +/* > + * NAL helper functions for muxers > + * > + * This file is part of F

Re: [FFmpeg-devel] [PATCH v2] fate/vvc: add vvc-conformance-RPR_A_4

On 10/06/2024 18:46, Frank Plowman wrote: > BeforeAfter > - > make fate-vvc CPU Time (No ASM) 131.52s 134.83s > libavcodec/vvc/* Line Coverage 95.3%96.9% > inter_template.c Line Coverage 74.3%88.