Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

On 16/06/2024 10:54, Lynne wrote: Currently, no eSBR features are supported. Thankfully, no encoders exist for it yet. --- libavcodec/aac/aacdec_usac.c | 119 +++--- libavcodec/aacsbr.h | 11 ++ libavcodec/aacsbr_template.c | 232 --- lib

[FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: don't use sizeof(AVMasteringDisplayMetadata)

It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/mxfdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 852fb7e056..a5863445ab 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @

[FFmpeg-devel] [PATCH 2/3] avformat/mov: don't use sizeof(AVMasteringDisplayMetadata)

It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index c0a5788e08..35b767a52c 100644 --- a/libavformat/isom.h +++ b/li

[FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: don't use sizeof(AVMasteringDisplayMetadata)

It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/matroskadec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 328109b354..6bc5fa621e 100644 --- a/libavformat/matroskade

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add bgra/rgba to yuv

> On Jun 19, 2024, at 20:05, Rémi Denis-Courmont wrote: > > > > Le 19 juin 2024 11:24:28 GMT+02:00, Zhao Zhili > a écrit : >> >> >>> On Jun 19, 2024, at 15:07, Rémi Denis-Courmont wrote: >>> >>> >>> >>> Le 15 juin 2024 11:57:18 GMT+02:00, Zhao Zhili a >

[FFmpeg-devel] [PATCH v2 1/3] swscale/aarch64: Add bgr24 to yuv

From: Zhao Zhili Test on Apple M1 with kperf bgr24_to_uv_8_c: 41.5 bgr24_to_uv_8_neon: 41.8 bgr24_to_uv_128_c: 133.5 bgr24_to_uv_128_neon: 94.3 bgr24_to_uv_1080_c: 960.5 bgr24_to_uv_1080_neon: 751.0 bgr24_to_uv_1920_c: 1695.3 bgr24_to_uv_1920_neon: 1357.3 bgr24_to_uv_half_8_c: 45.0 bgr24_to_uv_h

[FFmpeg-devel] [PATCH v2 2/3] swscale/aarch64: Add bgra/rgba to yuv

From: Zhao Zhili Test on Apple M1 with kperf bgra_to_uv_8_c: 13.4 bgra_to_uv_8_neon: 37.4 bgra_to_uv_128_c: 155.9 bgra_to_uv_128_neon: 91.7 bgra_to_uv_1080_c: 1173.2 bgra_to_uv_1080_neon: 822.7 bgra_to_uv_1920_c: 2078.2 bgra_to_uv_1920_neon: 1437.7 bgra_to_uv_half_8_c: 17.9 bgra_to_uv_half_8_neo

[FFmpeg-devel] [PATCH v2 3/3] swscale/aarch64: Add argb/abgr to yuv

From: Zhao Zhili Test on Apple M1 with kperf: abgr_to_uv_8_c: 19.4 abgr_to_uv_8_neon: 29.9 abgr_to_uv_128_c: 146.4 abgr_to_uv_128_neon: 85.1 abgr_to_uv_1080_c: 1162.6 abgr_to_uv_1080_neon: 819.6 abgr_to_uv_1920_c: 2063.6 abgr_to_uv_1920_neon: 1435.1 abgr_to_uv_half_8_c: 16.4 abgr_to_uv_half_8_ne

Re: [FFmpeg-devel] [PATCH 37/57] avcodec/mpegutils: Don't output wrong mb skip values

Michael Niedermayer: > On Mon, Jun 17, 2024 at 01:08:56PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Wed, Jun 12, 2024 at 03:48:33PM +0200, Andreas Rheinhardt wrote: The earlier code had two problems: 1. For reference frames that are not directly output (happens unles

Re: [FFmpeg-devel] [PATCH 5/9] avformat/mov: Check extend and base offset

Le 19 juin 2024 14:34:59 GMT+02:00, James Almer a écrit : >On 6/18/2024 4:07 AM, Rémi Denis-Courmont wrote: >> >> >> Le 17 juin 2024 01:08:27 GMT+02:00, Michael Niedermayer >> a écrit : >>> Fixes: signed integer overflow: 2314885530818453536 + 9151314442816847872 >>> cannot be represented i

[FFmpeg-devel] [PATCH v3] movenc: Add an option for resilient, hybrid fragmented/non-fragmented muxing

This allows ending up with a normal, non-fragmented file when the file is finished, while keeping the file readable if writing is aborted abruptly at any point. (Normally when writing a mov/mp4 file, the unfinished file is completely useless unless it is finished properly.) This results in a file

Re: [FFmpeg-devel] [PATCH] avformat: split off generic NAL function helpers into their own file

On 6/18/2024 6:23 PM, Michael Niedermayer wrote: On Sun, Jun 16, 2024 at 02:00:06PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavformat/Makefile | 2 +- libavformat/avc.c | 164 +--- libavformat/avc.h | 37 -

Re: [FFmpeg-devel] [PATCH v2] movenc: Add an option for hiding fragments at the end

On 2024-06-19 06:04 pm, Martin Storsjö wrote: On Mon, 17 Jun 2024, Gyan Doshi via ffmpeg-devel wrote: Ultimately, as long as the doc is clear about what the use of this option is, and what to do next if the muxing does abort, it should not matter too much what the option is called. So, ar

Re: [FFmpeg-devel] [PATCH v2] movenc: Add an option for hiding fragments at the end

On Mon, 17 Jun 2024, Gyan Doshi via ffmpeg-devel wrote: On 2024-06-17 04:08 pm, Martin Storsjö wrote: On Sat, 15 Jun 2024, Gyan Doshi wrote: On 2024-06-15 03:54 am, Dennis Sädtler via ffmpeg-devel wrote: On 2024-06-14 13:23, Gyan Doshi wrote: On 2024-06-14 04:35 pm, Timo Rothenpieler wrote

Re: [FFmpeg-devel] [PATCH 5/9] avformat/mov: Check extend and base offset

On 6/18/2024 4:07 AM, Rémi Denis-Courmont wrote: Le 17 juin 2024 01:08:27 GMT+02:00, Michael Niedermayer a écrit : Fixes: signed integer overflow: 2314885530818453536 + 9151314442816847872 cannot be represented in type 'long' Fixes: 68359/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzze

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add bgra/rgba to yuv

Le 19 juin 2024 11:24:28 GMT+02:00, Zhao Zhili a écrit  : > > >> On Jun 19, 2024, at 15:07, Rémi Denis-Courmont wrote: >> >> >> >> Le 15 juin 2024 11:57:18 GMT+02:00, Zhao Zhili a >> écrit : >>> From: Zhao Zhili >>> >>> Test on Apple M1 with kperf >>> >>> bgra_to_uv_8_c: 13.4 >>> bgra_t

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mxfdec: Check container_ul->desc before use

On Tue, Jun 18, 2024 at 04:31:49PM +0200, Tomas Härdin wrote: > fre 2024-06-07 klockan 02:32 +0200 skrev Michael Niedermayer: > > Fixes: CID1592939 Dereference after null check > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > >  libavformat/mxfdec.c | 1 +

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/qsvvpp: Remove unreachable code

On Wed, Jun 12, 2024 at 08:19:17AM +, Xiang, Haihao wrote: > On Di, 2024-06-11 at 23:59 +0200, Michael Niedermayer wrote: > > Fixes: CID1598548 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > >  libavfilter/qsvvpp.c | 5 - > >

Re: [FFmpeg-devel] [PATCH 7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg

On Tue, Jun 18, 2024 at 12:09:34PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-18 01:48:25) > > On Mon, Jun 17, 2024 at 09:07:23AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-06-17 01:08:29) > > > > Ive been told that someone at the BCN video tech meet

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

On Mon, Jun 17, 2024 at 10:10:38AM -0700, James Zern via ffmpeg-devel wrote: > On Sun, Jun 16, 2024 at 4:09 PM Michael Niedermayer > wrote: > > > > This or fifo needs to be freed on errors explicitly > > I have not verified that its always safe to call vpx_free() this needs to > > be checked befo

Re: [FFmpeg-devel] [PATCH 4/9] avformat/iamf_parse: Layer, thou shalt not be 0

On Mon, Jun 17, 2024 at 09:33:59PM -0300, James Almer wrote: > On 6/16/2024 8:08 PM, Michael Niedermayer wrote: > > Fixes: out of array access > > Fixes: > > 68302/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4665793796177920 > > > > Found-by: continuous fuzzing process > > https://githu

Re: [FFmpeg-devel] [PATCH 3/9] avformat/iamf_parse: Try to use less space after the array

On Mon, Jun 17, 2024 at 09:35:06PM -0300, James Almer wrote: > On 6/16/2024 8:08 PM, Michael Niedermayer wrote: > > Fixes: out of array access > > Fixes: > > 68584/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6256656668229632 > > > > Found-by: continuous fuzzing process > > https://githu

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

Nuo Mi 于2024年6月19日周三 16:40写道： > > On Tue, Jun 18, 2024 at 8:06 PM Steven Liu wrote: > > > Nuo Mi 于2024年6月18日周二 19:51写道： > > > > > > On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili > > wrote: > > > > > > > > > > > > > > > > On Jun 17, 2024, at 16:45, Hendrik Leppkes > > wrote: > > > > > > > > > > On

Re: [FFmpeg-devel] [PATCH 3/6] swscale/yuv2rgb: fix yuv422p input in C code

On Mon, Jun 17, 2024 at 12:28:46AM +0200, Ramiro Polla wrote: > The C code was silently ignoring the second chroma line on yuv422p > input. > --- > libswscale/yuv2rgb.c | 228 +-- > 1 file changed, 196 insertions(+), 32 deletions(-) nice you found this. Tha

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add bgra/rgba to yuv

> On Jun 19, 2024, at 15:07, Rémi Denis-Courmont wrote: > > > > Le 15 juin 2024 11:57:18 GMT+02:00, Zhao Zhili a > écrit : >> From: Zhao Zhili >> >> Test on Apple M1 with kperf >> >> bgra_to_uv_8_c: 13.4 >> bgra_to_uv_8_neon: 37.4 >> bgra_to_uv_128_c: 155.9 >> bgra_to_uv_128_neon: 91.7 >

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

Hi all, I will merge this tomorrow if there are no objections. Thank you. On Mon, Jun 17, 2024 at 9:23 PM Nuo Mi wrote: > > > On Sun, Jun 16, 2024 at 11:26 PM Mark Thompson wrote: > >> On 15/06/2024 17:37, Frank Plowman wrote: >> > n 15/06/2024 13:24, Nuo Mi wrote: >> >> On Sat, Jun 15, 2024 a

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

On Tue, Jun 18, 2024 at 10:24 PM Zhao Zhili wrote: > > > > On Jun 18, 2024, at 19:50, Nuo Mi wrote: > > > > On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili > wrote: > > > >> > >> > >>> On Jun 17, 2024, at 16:45, Hendrik Leppkes > wrote: > >>> > >>> On Mon, Jun 17, 2024 at 10:03 AM Zhao Zhili > >>

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > > > From: Pierre-Anthony Lemieux > > > > > > p0_10.j2k is one of the reference codestreams included in Rec

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

On Tue, Jun 18, 2024 at 8:06 PM Steven Liu wrote: > Nuo Mi 于2024年6月18日周二 19:51写道： > > > > On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili > wrote: > > > > > > > > > > > > On Jun 17, 2024, at 16:45, Hendrik Leppkes > wrote: > > > > > > > > On Mon, Jun 17, 2024 at 10:03 AM Zhao Zhili > > > wrote: >

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000dec: Add support for placeholder passes, CAP, and CPF markers

ons 2024-06-19 klockan 05:51 + skrev WATANABE Osamu: > First of all, I appreciate your kind review. > I'm writing to discuss the changes and would like to hear your > feedback on these. > > > > On Jun 18, 2024, at 23:20, Tomas Hardin wrote: > > > > > > It seems this patch combines a lot of

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add bgra/rgba to yuv

Le 15 juin 2024 11:57:18 GMT+02:00, Zhao Zhili a écrit  : >From: Zhao Zhili > >Test on Apple M1 with kperf > >bgra_to_uv_8_c: 13.4 >bgra_to_uv_8_neon: 37.4 >bgra_to_uv_128_c: 155.9 >bgra_to_uv_128_neon: 91.7 >bgra_to_uv_1080_c: 1173.2 >bgra_to_uv_1080_neon: 822.7 >bgra_to_uv_1920_c: 2078.2 >bgr