[FFmpeg-devel] [PATCH 2/2] fate: Add fsync filter tests

2023-12-14 Thread Thilo Borgmann via ffmpeg-devel
--- tests/Makefile | 6 +++- tests/fate/filter-video.mak | 6 tests/maps/fsync-down| 7 tests/maps/fsync-up | 57 + tests/ref/fate/filter-fsync-down | 12 +++ tests/ref/fate/filter-fsync-up | 62

[FFmpeg-devel] [PATCH 1/2] avfilter: Add fsync filter

2023-12-14 Thread Thilo Borgmann via ffmpeg-devel
--- Changelog| 1 + MAINTAINERS | 1 + doc/filters.texi | 33 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- libavfilter/vf_fsync.c | 304 +++ 7 files chang

[FFmpeg-devel] [PATCH 0/2] avfilter: Add fsync filter

2023-12-14 Thread Thilo Borgmann via ffmpeg-devel
Synchronize video frames with an external mapping from a file. Follows up on the idea in https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305986.html implemented as a filter. Not storing the frame map in a probably huge string but buffering piece-wise. Using a fixed format string. Th

Re: [FFmpeg-devel] [PATCH] doc/examples/qsv_transcode: EINVAL is more appropriate and ENAVAIL will fail build with visual studio

2023-12-14 Thread hung kuishing
> From: ffmpeg-devel On Behalf Of Xiang, > Haihao > Sent: Thursday, December 7, 2023 3:37 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] doc/examples/qsv_transcode: EINVAL is > more appropriate and ENAVAIL will fail build with visual studio > > On Do, 2023-12-07 at 06:44 +

Re: [FFmpeg-devel] [PATCH] swr/swresample: avoid reapplication of firstpts

2023-12-14 Thread Gyan Doshi
On 2023-12-15 12:43 am, Michael Niedermayer wrote: On Tue, Dec 12, 2023 at 04:50:08PM +0530, Gyan Doshi wrote: During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using ha

[FFmpeg-devel] [PATCH v2] swr/swresample: avoid reapplication of firstpts

2023-12-14 Thread Gyan Doshi
During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using hard compensation) then upon first encountering a delay where a soft compensation is required, swr_set_compensation w

[FFmpeg-devel] [PATCH 3/3] avcodec/leaddec: Check remaining bits in decode_block()

2023-12-14 Thread Michael Niedermayer
Fixes: Timeout Fixes: 64163/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LEAD_fuzzer-6418925835124736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/leaddec.c | 3 +++ 1 file changed, 3

[FFmpeg-devel] [PATCH 2/3] avcodec/jpegxl_parser: Add padding to cs_buffer

2023-12-14 Thread Michael Niedermayer
Fixes: out of array access Fixes: 64081/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6151006496620544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpegxl_parser.c | 6 +++--- 1 file

[FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for QPEG

2023-12-14 Thread Michael Niedermayer
Fixes: 63712/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QPEG_fuzzer-456353017272729 Fixes: Timeout Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: emit proper PTS to decoded AVFrame

2023-12-14 Thread Leo Izen
On 12/14/23 03:28, Anton Khirnov wrote: Quoting Leo Izen (2023-12-08 18:31:06) If a sequence of JXL images is encapsulated in a container that has PTS information, we should use the PTS information from the container. At this time there is no container that does this, but if JPEG XL support is e

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-14 Thread Leo Izen
On 12/13/23 15:53, Zsolt Vadász via ffmpeg-devel wrote: --- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 214 + 3 files changed, 177 insertions(+), 39 deletions(-) diff --git a/configure b/configure index 7d

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266: more restrictive check on pps_tile_idx_delta_val

2023-12-14 Thread Michael Niedermayer
On Sun, Oct 22, 2023 at 11:04:35AM +0800, Nuo Mi wrote: > Fixes: out of array access > Fixes: > 62603/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5837632490569728 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > --- > libavcode

Re: [FFmpeg-devel] [PATCH] tests/fate: add median filter test

2023-12-14 Thread Michael Niedermayer
On Thu, Dec 07, 2023 at 03:12:39AM +0100, Michael Niedermayer wrote: > On Wed, Dec 06, 2023 at 12:21:02PM +0100, Paul B Mahol wrote: > > Attached. > > > fate/filter-video.mak |3 +++ > > ref/fate/filter-median |1 + > > 2 files changed, 4 insertions(+) > > 13f347a427b22bbb5ea4959ad092435

Re: [FFmpeg-devel] [PATCH] tests/fate: add pixelize filter tests

2023-12-14 Thread Michael Niedermayer
On Thu, Dec 07, 2023 at 03:15:31AM +0100, Michael Niedermayer wrote: > On Wed, Dec 06, 2023 at 11:20:06AM +0100, Paul B Mahol wrote: > > Attached. > > > fate/filter-video.mak|9 + > > ref/fate/filter-pixelize-avg |1 + > > ref/fate/filter-pixelize-max |1 + > > ref/fat

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-12-14 Thread Michael Niedermayer
On Sat, Aug 12, 2023 at 01:31:16PM -0700, p...@sandflow.com wrote: > From: Pierre-Anthony Lemieux > > Intended to replace > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.26482-3-mich...@niedermayer.cc/ > with a more accurate block decoding magnitude bound. > > --- > libavcod

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust threshold for VMIX

2023-12-14 Thread Michael Niedermayer
On Mon, Sep 25, 2023 at 09:19:19PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 62286/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMIX_fuzzer-5155237134204928 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

[FFmpeg-devel] [PATCH 7/8] avformat: Immersive Audio Model and Formats demuxer

2023-12-14 Thread James Almer
Signed-off-by: James Almer --- libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/iamf.c | 125 + libavformat/iamf.h | 163 ++ libavformat/iamf_parse.c | 1106 ++ libavformat/iamf_parse.h | 38 ++ libavform

[FFmpeg-devel] [PATCH 8/8] avformat: Immersive Audio Model and Formats muxer

2023-12-14 Thread James Almer
Signed-off-by: James Almer --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/iamf_writer.c | 860 ++ libavformat/iamf_writer.h | 51 +++ libavformat/iamfenc.c | 387 + 5 files changed, 1300 insertions(+)

[FFmpeg-devel] [PATCH 6/8] avformat/aviobuf: add ffio_read_leb() and ffio_write_leb()

2023-12-14 Thread James Almer
Signed-off-by: James Almer --- libavformat/avio_internal.h | 10 ++ libavformat/aviobuf.c | 33 + 2 files changed, 43 insertions(+) diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h index bd58499b64..f2e4ff30cb 100644 --- a/libav

[FFmpeg-devel] [PATCH 5/8] avcodec/get_bits: add get_leb()

2023-12-14 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bitstream.h | 2 ++ libavcodec/bitstream_template.h | 23 +++ libavcodec/get_bits.h | 24 3 files changed, 49 insertions(+) diff --git a/libavcodec/bitstream.h b/libavcodec/bitstream.h inde

[FFmpeg-devel] [PATCH 4/8] avcodec/packet: add IAMF Parameters side data types

2023-12-14 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avpacket.c | 3 +++ libavcodec/packet.h | 24 2 files changed, 27 insertions(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index e29725c2d2..0f8c9b77ae 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpack

[FFmpeg-devel] [PATCH 3/8] ffmpeg: add support for muxing AVStreamGroups

2023-12-14 Thread James Almer
Starting with IAMF support. Signed-off-by: James Almer --- doc/ffmpeg.texi | 200 ++ fftools/ffmpeg.h | 2 + fftools/ffmpeg_mux_init.c | 341 ++ fftools/ffmpeg_opt.c | 2 + 4 files changed, 545 insertions(+) dif

[FFmpeg-devel] [PATCH 2/8] avformat: introduce AVStreamGroup

2023-12-14 Thread James Almer
Signed-off-by: James Almer --- doc/fftools-common-opts.texi | 17 +++- libavformat/avformat.c | 91 +++-- libavformat/avformat.h | 153 +++ libavformat/dump.c | 147 +++-- libavformat/internal.h

[FFmpeg-devel] [PATCH 1/8] avutil: introduce an Immersive Audio Model and Formats API

2023-12-14 Thread James Almer
Signed-off-by: James Almer --- libavutil/Makefile | 2 + libavutil/iamf.c | 563 libavutil/iamf.h | 620 + 3 files changed, 1185 insertions(+) create mode 100644 libavutil/iamf.c create mode 100644 libavu

[FFmpeg-devel] [PATCH v7 0/8] avformat: introduce AVStreamGroup

2023-12-14 Thread James Almer
Addressed Anton's comments, plus some extra fixes for issues i found while testing. James Almer (8): avutil: introduce an Immersive Audio Model and Formats API avformat: introduce AVStreamGroup ffmpeg: add support for muxing AVStreamGroups avcodec/packet: add IAMF Parameters side data type

Re: [FFmpeg-devel] [PATCH 03/12] fftools/ffmpeg: replace OutputStream.file_index by a pointer

2023-12-14 Thread James Almer
On 12/14/2023 4:34 PM, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-12-14 20:20:01) On Wed, Dec 13, 2023 at 08:29:58PM +0100, Anton Khirnov wrote: Reduces the need to use the output_files global array. --- fftools/ffmpeg.c | 12 ++-- fftools/ffmpeg.h | 4

Re: [FFmpeg-devel] [PATCH 03/12] fftools/ffmpeg: replace OutputStream.file_index by a pointer

2023-12-14 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-12-14 20:20:01) > On Wed, Dec 13, 2023 at 08:29:58PM +0100, Anton Khirnov wrote: > > Reduces the need to use the output_files global array. > > --- > > fftools/ffmpeg.c | 12 ++-- > > fftools/ffmpeg.h | 4 +++- > > fftools/ffmpeg_enc.c

[FFmpeg-devel] [PATCH 3/9] fftools/ffmpeg_mux: factor timestamps processing out of write_packet()

2023-12-14 Thread Anton Khirnov
--- fftools/ffmpeg_mux.c | 50 ++-- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 3ce4ef131e..88ce3cd60c 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -135,20 +135,9 @@ sta

[FFmpeg-devel] [PATCH 8/9] fftools/ffmpeg_mux: deduplicate uniniting EncStats

2023-12-14 Thread Anton Khirnov
--- fftools/ffmpeg_mux.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 88ce3cd60c..357f34172f 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -773,6 +773,13 @@ int of_write_trailer(Outpu

[FFmpeg-devel] [PATCH 9/9] fftools/ffmpeg: use a mutex for enc_stats_write()

2023-12-14 Thread Anton Khirnov
It may be called concurrently from different threads to write into the same file. --- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_enc.c | 4 fftools/ffmpeg_mux.c | 4 fftools/ffmpeg_mux_init.c | 5 + 4 files changed, 16 insertions(+) diff --git a/fftools/ffmpeg.h b/f

[FFmpeg-devel] [PATCH 7/9] doc/ffmpeg: drop misleading claims from -stats_*_fmt

2023-12-14 Thread Anton Khirnov
The {br}/{abr} directives are not limited to post-encoding, they can also be used pre-muxing. The already-present {packet} tag describes this more accurately, so just drop the assertions. --- doc/ffmpeg.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ffmpeg.texi b/

[FFmpeg-devel] [PATCH 6/9] fftools/ffmpeg: print keyframe information with -stats_*

2023-12-14 Thread Anton Khirnov
--- doc/ffmpeg.texi | 3 +++ fftools/ffmpeg.h | 1 + fftools/ffmpeg_enc.c | 2 ++ fftools/ffmpeg_mux_init.c | 1 + 4 files changed, 7 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index f157c06e12..059102b75a 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.tex

[FFmpeg-devel] [PATCH 4/9] fftools/cmdutils: change option flags to (1 << N) style

2023-12-14 Thread Anton Khirnov
It is easier to read. --- fftools/cmdutils.h | 47 -- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h index 8b67d827cc..85479f90e4 100644 --- a/fftools/cmdutils.h +++ b/fftools/cmdutils.h @@ -106,28

[FFmpeg-devel] [PATCH 1/9] fftools/ffmpeg_mux: stop logging to AVFormatContext

2023-12-14 Thread Anton Khirnov
Only the muxer itself is supposed to do that. Log to OutputStream instead. Drop now-redundant information from the logged string. --- fftools/ffmpeg_mux.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 8e523dd49d

[FFmpeg-devel] [PATCH 5/9] fftools/ffmpeg_mux_init: change 1-bit bitfields from int to unsigned

2023-12-14 Thread Anton Khirnov
They cannot store 1 as signed, only 0 and -1. Avoids warnings such as: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] --- fftools/ffmpeg_mux_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[FFmpeg-devel] [PATCH 2/9] fftools/ffmpeg: deprecate -fps_mode/vsync drop

2023-12-14 Thread Anton Khirnov
It depends on the ability of muxers to generate timestamps, which is itself deprecated. --- doc/ffmpeg.texi | 3 --- fftools/ffmpeg.h| 3 +++ fftools/ffmpeg_filter.c | 9 +++-- fftools/ffmpeg_mux.c| 2 ++ fftools/ffmpeg_opt.c| 7 ++- 5 files changed, 18 insertions(+

Re: [FFmpeg-devel] [PATCH 03/12] fftools/ffmpeg: replace OutputStream.file_index by a pointer

2023-12-14 Thread Michael Niedermayer
On Wed, Dec 13, 2023 at 08:29:58PM +0100, Anton Khirnov wrote: > Reduces the need to use the output_files global array. > --- > fftools/ffmpeg.c | 12 ++-- > fftools/ffmpeg.h | 4 +++- > fftools/ffmpeg_enc.c | 21 +++-- > fftools/ffmpeg_filter.c |

Re: [FFmpeg-devel] [PATCH] avfilter/formats: set audio fmt lists for vaf filters

2023-12-14 Thread Michael Niedermayer
On Thu, Dec 14, 2023 at 03:40:36PM +0100, Niklas Haas wrote: > On Thu, 14 Dec 2023 15:39:11 +0100 Niklas Haas wrote: > > From: Niklas Haas > > > > Currently, the logic inside the FF_FILTER_FORMATS_QUERY_FUNC branch > > prevents this code from running in the event that we have a filter with > > a

Re: [FFmpeg-devel] [PATCH] swr/swresample: avoid reapplication of firstpts

2023-12-14 Thread Michael Niedermayer
On Tue, Dec 12, 2023 at 04:50:08PM +0530, Gyan Doshi wrote: > During a resampling operation where > > 1) user has specified first_pts > 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) > 3) first_pts has been fulfilled (always using hard compensation) > > then upon first encounte

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-14 Thread Thilo Borgmann via ffmpeg-devel
Am 14.12.23 um 18:51 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-14 11:34:11) Am 14.12.23 um 06:23 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 19:17:04) Am 13.12.23 um 17:28 schrieb Anton Khirnov: It is bad practice to design library

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Michael Niedermayer
On Thu, Dec 14, 2023 at 04:25:45AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-12-14 00:16:14) > > On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > > > ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > > > 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc2

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-14 Thread Anton Khirnov
Quoting Thilo Borgmann via ffmpeg-devel (2023-12-14 11:34:11) > Am 14.12.23 um 06:23 schrieb Anton Khirnov: > > Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 19:17:04) > >> Am 13.12.23 um 17:28 schrieb Anton Khirnov: > >>> It is bad practice to design library features around the needs and > >

Re: [FFmpeg-devel] [PATCH 1/2] checkasm/lpc: test compute_autocorr

2023-12-14 Thread Rémi Denis-Courmont
Le torstaina 14. joulukuuta 2023, 18.41.24 EET Michael Niedermayer a écrit : > SSE2: > - lpc.apply_welch_window_even [OK] > - lpc.apply_welch_window_odd [OK] > 0: 976.228035341704 - 976.998462662304 = -0.7704273206 >autocorr_10_sse2 (lpc.c:81) > - lpc.compute_autocorr_10 [FAILED] > 0:

Re: [FFmpeg-devel] [PATCH 1/2] checkasm/lpc: test compute_autocorr

2023-12-14 Thread Michael Niedermayer
On Tue, Dec 12, 2023 at 11:02:39PM +0200, Rémi Denis-Courmont wrote: > --- > tests/checkasm/lpc.c | 42 -- > 1 file changed, 40 insertions(+), 2 deletions(-) Often this works, but not always ffmpeg/tests/checkasm/checkasm --test=lpc checkasm: using random

Re: [FFmpeg-devel] [PATCH] avfilter/formats: set audio fmt lists for vaf filters

2023-12-14 Thread Niklas Haas
On Thu, 14 Dec 2023 15:39:11 +0100 Niklas Haas wrote: > From: Niklas Haas > > Currently, the logic inside the FF_FILTER_FORMATS_QUERY_FUNC branch > prevents this code from running in the event that we have a filter with > a single video input and a single audio output, as the resulting audio > o

[FFmpeg-devel] [PATCH] avfilter/formats: set audio fmt lists for vaf filters

2023-12-14 Thread Niklas Haas
From: Niklas Haas Currently, the logic inside the FF_FILTER_FORMATS_QUERY_FUNC branch prevents this code from running in the event that we have a filter with a single video input and a single audio output, as the resulting audio output link will not have its channel counts / samplerates correctly

Re: [FFmpeg-devel] [PATCH v2 03/15] avfilter: add negotiation API for color space/range

2023-12-14 Thread Niklas Haas
> segfaults > > ./ffmpeg -f lavfi -i > "amovie=fate-suite/wavpack/num_channels/eva_2.22_6.1_16bit-partial.wv,asplit=3[out1][a][b]; > [a]showwaves=s=340x240,pad=iw:ih*2[waves]; > [b]showspectrum=s=340x240[spectrum]; [waves][spectrum] overlay=0:h [out0]" > -t 0.1 -qscale 2 -bitexact /tmp/file-w

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Gyan Doshi
On 2023-12-14 04:56 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-12-14 12:22:51) On 2023-12-14 02:48 pm, Anton Khirnov wrote: On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 16:37:52 2023 +0200| [d119ae2fd82a494d9430

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Anton Khirnov
Quoting Gyan Doshi (2023-12-14 12:22:51) > > > On 2023-12-14 02:48 pm, Anton Khirnov wrote: > >>> On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] |

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Gyan Doshi
On 2023-12-14 02:48 pm, Anton Khirnov wrote: On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | committer: Anton Khirnov fftools/ffmpeg: convert to a threaded

Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-14 Thread Rémi Denis-Courmont
Le 13 décembre 2023 12:03:55 GMT+02:00, Nicolas George a écrit : >Rémi Denis-Courmont (12023-12-12): >> ...and test for overflow errors in errno.m (which shall have been >> zeroed beforehand). AFAIK, you need to do both if you want strict >> error detection. > >Or we can consider that 300647711

[FFmpeg-devel] [PATCH v3] gdigrab: Allow capturing a window by its handle

2023-12-14 Thread Lena via ffmpeg-devel
Updated the wording of the documentation, and added error checking for strtol. I looked at how other parts of the codebase check for errors on strtol and implemented it that way (iec61883, filter_units_bsf, etc). As for checking if the string value is larger/smaller than a long, i don't think t

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-14 Thread Thilo Borgmann via ffmpeg-devel
Am 14.12.23 um 06:23 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 19:17:04) Am 13.12.23 um 17:28 schrieb Anton Khirnov: It is bad practice to design library features around the needs and limitations of a single specific caller. The callers here would be the CLI a

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_sched: actually initialize/destroy schedule_lock

2023-12-14 Thread Thilo Borgmann via ffmpeg-devel
Am 14.12.23 um 10:17 schrieb Anton Khirnov: --- fftools/ffmpeg_sched.c | 6 ++ 1 file changed, 6 insertions(+) Fixes --assert-level=2 for me. LGTM. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinf

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-14 Thread Nicolas George
Anton Khirnov (12023-12-14): > As mentioned elsewhere in the thread, you can just as well pipe raw > video in yuv4mpeg or nut to the video player of your choice and thus As was already mentioned elsewhere in the thread, this solution has a lot more drawbacks. > avoid all these hacks. Please refr

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Anton Khirnov
Quoting Thilo Borgmann via ffmpeg-devel (2023-12-14 09:18:30) > Am 14.12.23 um 00:16 schrieb Michael Niedermayer: > > On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > >> ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > >> 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc2629

[FFmpeg-devel] [PATCH] fftools/ffmpeg_sched: actually initialize/destroy schedule_lock

2023-12-14 Thread Anton Khirnov
--- fftools/ffmpeg_sched.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index 96eaaae072..20063fe47e 100644 --- a/fftools/ffmpeg_sched.c +++ b/fftools/ffmpeg_sched.c @@ -565,6 +565,8 @@ void sch_free(Scheduler **psch) av_freep(&sc

Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: emit proper PTS to decoded AVFrame

2023-12-14 Thread Anton Khirnov
Quoting Leo Izen (2023-12-08 18:31:06) > If a sequence of JXL images is encapsulated in a container that has PTS > information, we should use the PTS information from the container. At > this time there is no container that does this, but if JPEG XL support > is ever added to NUT, AVTransport, or s

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Thilo Borgmann via ffmpeg-devel
Am 14.12.23 um 00:16 schrieb Michael Niedermayer: On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | committer: Anton Khirnov fftools/ffmpeg: convert to a thread

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-14 Thread Anton Khirnov
Quoting Marton Balint (2023-12-13 18:09:45) > On Wed, 13 Dec 2023, Anton Khirnov wrote: > > Quoting Marton Balint (2023-12-12 19:37:57) > >> > >> So for this flag, I'd rather make it clear it is not security-related, and > >> also that it has performance impact. > > > > So then maybe make a FF_EC f