Re: [FFmpeg-devel] [RFC] [PATCH] avfilter/avfilter: add flag to signal filters that support w/h change

2023-06-16 Thread Paul B Mahol
On Wed, Jun 14, 2023 at 7:33 PM Nicolas George wrote: > Paul B Mahol (12023-06-14): > > To flag filters that can work with variable frame size changes > > all the time in graph. So no rescalers are need to be inserted or > > filtergraph reset. > > > > Once all such filters are flaged with such ca

Re: [FFmpeg-devel] [PATCH] avcodec: Ignoring errors is only possible before the input end

2023-06-16 Thread Paul B Mahol
On Sat, Jun 3, 2023 at 9:44 PM Michael Niedermayer wrote: > Fixes: out of array read > Fixes: Ticket 10308 > Did you forgot to apply this? > > Signed-off-by: Michael Niedermayer > --- > libavcodec/h263dec.c | 2 +- > libavcodec/mpeg4videodec.c | 4 ++-- > 2 files changed, 3 insertions(

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-16 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > Make sure we don't repeatedly try to decode the same packet, making no > progress and possibly causing an infinite loop. > Doesn't all error paths, bellow goto label in function, needs this (reset of ch_offset to 0 and unref of pkt) ? > --

Re: [FFmpeg-devel] [PATCH] avcodec: Align AVFrame memory to page size for access via Apple Metal

2023-06-16 Thread Paul B Mahol
On Thu, Jun 15, 2023 at 12:34 PM Iskandar Safarov wrote: > Thanks for looking into this, > > The idea is to page-align the entire software-backed video pool allocation > where video frames are being taken from – both for decoding and/or encoding > (when done in software only). > > The default get

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-16 Thread Paul B Mahol
Please no more pseudo demuxers. Use libavfilter API. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscr

Re: [FFmpeg-devel] [PATCH 16/21] fftools/ffmpeg_dec: move decoding to a separate thread

2023-06-16 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-06-16 22:58:21) > On Wed, Jun 14, 2023 at 06:49:03PM +0200, Anton Khirnov wrote: > > This is only a preparatory step to a fully threaded architecture and > > does not yet make decoding truly parallel - the main thread will > > currently submit a packet and wait unt

[FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-16 Thread Anton Khirnov
Make sure we don't repeatedly try to decode the same packet, making no progress and possibly causing an infinite loop. --- libavcodec/binkaudio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c index f28ecba760..265f93a822 1

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-06-16 Thread Andreas Rheinhardt
asivery: > Hello, apologies for bothering you all with this, but if anyone could take a > look at this patch it would be great. The only other container that supports > ATRAC1 is AEA, and it's not that good of a format since it has no magic > number, and therefore is easily detected incorrectly.

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-06-16 Thread asivery
Hello, apologies for bothering you all with this, but if anyone could take a look at this patch it would be great. The only other container that supports ATRAC1 is AEA, and it's not that good of a format since it has no magic number, and therefore is easily detected incorrectly. Thank you in ad

[FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-16 Thread Brad Smith
--- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 0c77d8e1fe..653aafb1ea 100755 --- a/configure +++ b/configure @@ -7009,8 +7009,7 @@ enabled alsa && { check_pkg_config alsa alsa "alsa/asoundlib.h" snd_pcm_htimesta enabled libjack &

[FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- configure|5 + doc/demuxers.texi| 71 ++ libavformat/Makefile |2 + libavformat/allformats.c |2 + libavformat/sdrdemux.c | 1710 ++ 5 files changed, 1790 insertions(+) create m

[FFmpeg-devel] [PATCH 0/5] add sdr support

2023-06-16 Thread Michael Niedermayer
This patchset adds some basic SDR support to FFmpeg ATM, this supports AM demodulation, i will add FM later I have no immedeate plans to add DAB, DVB, ... but these should be added too and would be very welcome if someone else wants to work on them. The only dependancy this has is libsoapy which

[FFmpeg-devel] [PATCH 4/5] avcodec: Rename ff_kbd_window_init() as it will be needed from outside libavcodec

2023-06-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_template.c | 8 libavcodec/aactab.c | 4 ++-- libavcodec/ac3dec.c | 2 +- libavcodec/ac3enc_fixed.c| 2 +- libavcodec/ac3enc_float.c| 2 +- libavcodec/dolby_e.c | 4 ++-- libavcodec/kbdwin.c

[FFmpeg-devel] [PATCH 3/5] avcodec/kbdwin: Support arbitrary sized windows

2023-06-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/kbdwin.c | 22 ++ libavcodec/kbdwin.h | 8 +--- 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/libavcodec/kbdwin.c b/libavcodec/kbdwin.c index 163f9d5251..82755874d4 100644 --- a/libavcodec/kbdwin.c +++ b

Re: [FFmpeg-devel] [PATCH v2] avformat/jpegxl_anim_dec: avoid overrun with jxlp boxes in container

2023-06-16 Thread Leo Izen
On 6/16/23 15:00, Andreas Rheinhardt wrote: Leo Izen: This switches the jpegxl_collect_codestream_header function to use avcodec/bytestream2, which better enforces barriers, and should avoid overrunning buffers with jxlp boxes if the size is zero or if the size is so small the box is invalid. S

[FFmpeg-devel] [PATCH 2/5] avcodec/pcm: allow Changing parameters

2023-06-16 Thread Michael Niedermayer
SDR needs this for switching between mono and stereo stations Signed-off-by: Michael Niedermayer --- libavcodec/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 23955ba2dd..467ecb4fe0 100644 --- a/libavcodec/pcm.c +++ b/libavcode

[FFmpeg-devel] [PATCH 1/5] avutil/tx_template: extend to 2M

2023-06-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/tx_template.c | 12 1 file changed, 12 insertions(+) diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c index 983de75a47..c4ec9502e0 100644 --- a/libavutil/tx_template.c +++ b/libavutil/tx_template.c @@ -43,6 +43,10 @@

Re: [FFmpeg-devel] [PATCH 1/5] avcodec: Add new side data type to contain original PTS value

2023-06-16 Thread Andreas Rheinhardt
Devin Heitmueller: > In order to properly process SCTE-35 packets, we need the original > PTS value from the demux (i.e. not mangled by the application or > reclocked for the output). This allows us to set the pts_adjustment > field in an BSF on the output side. > > Introduce a new side data type

Re: [FFmpeg-devel] [PATCH 4/5] bsf: Add new bitstream filter to set pts_adjustment when reclocking

2023-06-16 Thread Andreas Rheinhardt
Devin Heitmueller: > Because SCTE-35 messages are represented in TS streams as sections > rather than PES packets, we cannot rely on ffmpeg's standard > mechanisms to adjust PTS values if reclocking the stream. > This filter will leverage the SCTE-35 pts_adjust field to > compensate for any change

[FFmpeg-devel] [PATCH 5/5] mpegtsenc: Don't periodically announce PCR on SCTE-35 streams

2023-06-16 Thread Devin Heitmueller
Changes were made between in the last two years to periodically send PCR-only packets on all PIDs, but for cases where the stream may send packets very infrequently (like SCTE-35), this results in extra TR101290 errors because it fails the PCR interval test. I am not quite sure what the "right" fi

[FFmpeg-devel] [PATCH 4/5] bsf: Add new bitstream filter to set pts_adjustment when reclocking

2023-06-16 Thread Devin Heitmueller
Because SCTE-35 messages are represented in TS streams as sections rather than PES packets, we cannot rely on ffmpeg's standard mechanisms to adjust PTS values if reclocking the stream. This filter will leverage the SCTE-35 pts_adjust field to compensate for any change in the PTS values in the stre

[FFmpeg-devel] [PATCH 3/5] mpegtsenc: Add support for output of SCTE-35 streams over TS

2023-06-16 Thread Devin Heitmueller
Introduce the ability to pass through SCTE-35 packets when creating MPEG transport streams. Note that this patch makes no effort to change the PTS values in the SCTE-35 packets, and thus only works when not reclocking the stream (i.e. using -copyts). A subsequent patch includes a BSF to recompute

[FFmpeg-devel] [PATCH 2/5] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-06-16 Thread Devin Heitmueller
We need the original PTS value in order to do subsequent processing, so set it as packet side data. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 385d78b..b8f

[FFmpeg-devel] [PATCH 1/5] avcodec: Add new side data type to contain original PTS value

2023-06-16 Thread Devin Heitmueller
In order to properly process SCTE-35 packets, we need the original PTS value from the demux (i.e. not mangled by the application or reclocked for the output). This allows us to set the pts_adjustment field in an BSF on the output side. Introduce a new side data type to store the original PTS. Si

[FFmpeg-devel] [PATCH 0/5] Add passthrough support for SCTE-35

2023-06-16 Thread Devin Heitmueller
Properly set up the MPEG-TS mux and recalculate the pts_adjust field in SCTE_35 packets, such that a user can transparently pass through SCTE-35 streams when both the input and output are MPEG-TS. Devin Heitmueller (5): avcodec: Add new side data type to contain original PTS value mpegts: Stas

Re: [FFmpeg-devel] [PATCH 16/21] fftools/ffmpeg_dec: move decoding to a separate thread

2023-06-16 Thread Michael Niedermayer
On Wed, Jun 14, 2023 at 06:49:03PM +0200, Anton Khirnov wrote: > This is only a preparatory step to a fully threaded architecture and > does not yet make decoding truly parallel - the main thread will > currently submit a packet and wait until it has been fully processed by > the decoding thread be

Re: [FFmpeg-devel] [PATCH v2] avformat/jpegxl_anim_dec: avoid overrun with jxlp boxes in container

2023-06-16 Thread Andreas Rheinhardt
Leo Izen: > This switches the jpegxl_collect_codestream_header function to use > avcodec/bytestream2, which better enforces barriers, and should avoid > overrunning buffers with jxlp boxes if the size is zero or if the size > is so small the box is invalid. > > Signed-off-by: Leo Izen > --- > li

Re: [FFmpeg-devel] [PATCH v2] avformat/jpegxl_anim_dec: avoid overrun with jxlp boxes in container

2023-06-16 Thread Leo Izen
On 6/12/23 09:22, Leo Izen wrote: This switches the jpegxl_collect_codestream_header function to use avcodec/bytestream2, which better enforces barriers, and should avoid overrunning buffers with jxlp boxes if the size is zero or if the size is so small the box is invalid. Signed-off-by: Leo Ize

Re: [FFmpeg-devel] [PATCH 01/11] avformat/evcdec: set the demuxer as AVFMT_NOTIMESTAMPS

2023-06-16 Thread James Almer
On 6/15/2023 12:18 PM, James Almer wrote: Signed-off-by: James Almer --- libavformat/evcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c index 89eda0f53e..807406885a 100644 --- a/libavformat/evcdec.c +++ b/libavformat/evcdec

Re: [FFmpeg-devel] [PATCH v2] avformat/http: copy only mime type from Content-Type

2023-06-16 Thread Kacper Michajlow
On Thu, 1 Jun 2023 at 21:44, Kacper Michajłow wrote: > > Content-Type can include charset and boundary which is not a part of > mime type and shouldn't be copied as such. > > Fixes HLS playback when the Content-Type includes additional fields. > > Signed-off-by: Kacper Michajłow > --- > libavfor

[FFmpeg-devel] [PATCH v2] avfilter/scale_cuda: add support for rgb32/bgr32 conversions

2023-06-16 Thread Philip Langdale
As we are introducing two new formats and supporting conversions between them, and also with the existing 0rgb32/0bgr32 formats, we get a combinatorial explosion of kernels. I introduced a few new macros to keep the things mostly managable. The conversions are all simple, following existing patter

[FFmpeg-devel] [PATCH 3/3] Add Changelog entry

2023-06-16 Thread Tomas Härdin
Bumping with a forgotten Changelog entry From 33045f32da50390e6d58c34e95b3d344a53b6968 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 16 Jun 2023 15:19:24 +0200 Subject: [PATCH 3/3] Add Changelog entry --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/C

Re: [FFmpeg-devel] [PATCH 09/22] lavfi/vf_libplacebo: replace s->input by dynamic array

2023-06-16 Thread Niklas Haas
On Fri, 16 Jun 2023 14:09:56 +0200 Andreas Rheinhardt wrote: > Niklas Haas: > > From: Niklas Haas > > > > For now, hard-coded to 1 element. > > --- > > libavfilter/vf_libplacebo.c | 18 +- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/libavfilter/vf

[FFmpeg-devel] [PATCH 2/2] lavu/hwcontext_qsv: fix memory leak for d3d9 impl

2023-06-16 Thread Tong Wu
Signed-off-by: Tong Wu --- libavutil/hwcontext_qsv.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index 931f905a51..4cbe8cc494 100644 --- a/libavutil/hwcontext_qsv.c +++ b/libavutil/hwcontext_qsv.c @@ -756,

[FFmpeg-devel] [PATCH 1/2] lavu/hwcontext_qsv: fix memory leak for d3d11va impl

2023-06-16 Thread Tong Wu
Signed-off-by: Tong Wu --- libavutil/hwcontext_qsv.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index 713dc90ffd..931f905a51 100644 --- a/libavutil/hwcontext_qsv.c +++ b/libavutil/hwcontext_qsv.c @@ -665,6

Re: [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field

2023-06-16 Thread Lynne
Jun 13, 2023, 19:18 by d...@lynne.ee: > Jun 13, 2023, 18:56 by andreas.rheinha...@outlook.com: > >> Lynne: >> >>> +dst->opaque= av_buffer_ref(src->opaque); >>> +if (!dst->opaque) { >>> +ret = AVERROR(ENOMEM); >>> +goto fail; >>> +} >>> >> >> According to the doxy, o

Re: [FFmpeg-devel] [PATCH 3/6] lavc/ac3dsp: RISC-V V ac3_sum_square_butterfly_int32

2023-06-16 Thread 沈佩婷
Hei, > -原始邮件-发件人:"Rémi Denis-Courmont" 发送时间:2023-06-16 > 03:25:07 (星期五)收件人:ffmpeg-devel@ffmpeg.org抄送:"Shen Peiting" > 主题:Re: [FFmpeg-devel] [PATCH 3/6] > lavc/ac3dsp: RISC-V V ac3_sum_square_butterfly_int32 > > Le torstaina 15. kesäkuuta 2023, 13.36.42 EEST Peiting Shen a écrit : > >

[FFmpeg-devel] [PATCH 19/22] lavfi/vf_libplacebo: skip cache selectively per-input

2023-06-16 Thread Niklas Haas
From: Niklas Haas It may be the case that we want to skip the single frame cache for some inputs but not others. --- libavfilter/vf_libplacebo.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index a30b244843..

[FFmpeg-devel] [PATCH 18/22] lavfi/vf_libplacebo: set format list for all inputs

2023-06-16 Thread Niklas Haas
From: Niklas Haas --- libavfilter/vf_libplacebo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 427a15dc47..a30b244843 100644 --- a/libavfilter/vf_libplacebo.c +++ b/libavfilter/vf_libplacebo.c @@ -1129,7 +11

[FFmpeg-devel] [PATCH 13/22] lavfi/vf_libplacebo: determine PTS of next frame from any input

2023-06-16 Thread Niklas Haas
From: Niklas Haas When combining multiple inputs with different PTS and durations, in input-timed mode, we emit one output frame for every input frame PTS, from *any* input. So when combining a low FPS stream with a high FPS stream, the output framerate would match the higher FPS, independent of

[FFmpeg-devel] [PATCH 22/22] lavfi/vf_libplacebo: add nb_inputs option

2023-06-16 Thread Niklas Haas
From: Niklas Haas To control the number of inputs. --- doc/filters.texi| 5 + libavfilter/vf_libplacebo.c | 25 ++--- 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 2ea4083c3e..41cf4976cb 100644 ---

[FFmpeg-devel] [PATCH 12/22] lavfi/vf_libplacebo: handle multiple inputs

2023-06-16 Thread Niklas Haas
From: Niklas Haas This commit still relies on a single input for PTS determination, to be changed in the next commit. --- libavfilter/vf_libplacebo.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 3d8125

[FFmpeg-devel] [PATCH 10/22] lavfi/vf_libplacebo: keep track of latest status globally

2023-06-16 Thread Niklas Haas
From: Niklas Haas This field will effectively hold the most recent status set by any input. Currently functionally equivalent to input->status, but will change soon. --- libavfilter/vf_libplacebo.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_lib

[FFmpeg-devel] [PATCH 11/22] lavfi/vf_libplacebo: support blending multiple inputs

2023-06-16 Thread Niklas Haas
From: Niklas Haas Subsequent inputs required frame blending to be enable, in order to not overwrite the existing frame contents. For output metadata, we implicitly copy the metadata of the *first* available stream (falling back to the second stream if the first has already reached EOF, and so on

[FFmpeg-devel] [PATCH 21/22] lavfi/vf_libplacebo: set time_base/frame_rate dynamically

2023-06-16 Thread Niklas Haas
From: Niklas Haas Use the gcd of all input timebases to ensure PTS accuracy. For the framerate, just pick the highest of all the inputs, under the assumption that we will render frames with approximately this frequency. Of course, this is not 100% accurate, in particular if the input frames are b

[FFmpeg-devel] [PATCH 20/22] lavfi/vf_libplacebo: also skip cache if in FPS == out FPS

2023-06-16 Thread Niklas Haas
From: Niklas Haas Fixes an oversight in the previous code which should have been >=, not >. --- libavfilter/vf_libplacebo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index b78391441a..9b1526f19e 100644 --- a/liba

[FFmpeg-devel] [PATCH 08/22] lavfi/vf_libplacebo: use correct link in update_crops()

2023-06-16 Thread Niklas Haas
From: Niklas Haas Instead of hard-coding input 0, pass the per-input structure and use the link contained inside it. --- libavfilter/vf_libplacebo.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index

[FFmpeg-devel] [PATCH 09/22] lavfi/vf_libplacebo: replace s->input by dynamic array

2023-06-16 Thread Niklas Haas
From: Niklas Haas For now, hard-coded to 1 element. --- libavfilter/vf_libplacebo.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 408fb3918a..fbac1b0354 100644 --- a/libavfilter/vf_libplaceb

[FFmpeg-devel] [PATCH 07/22] lavfi/vf_libplacebo: factor out ref frame logic

2023-06-16 Thread Niklas Haas
From: Niklas Haas Instead of finding the ref frame in output_frame() and then passing its signature to update_crops(), pull out the logic and invoke it a second time inside update_crops(). This may seem wasteful at present, but will actually become required in the future, since update_crops() ru

[FFmpeg-devel] [PATCH 06/22] lavif/vf_libplacebo: remove pl_frame_mix from output_frame_mix

2023-06-16 Thread Niklas Haas
From: Niklas Haas Instead, rename this function to `output_frame` and make it pull the `pl_frame_mix` from the input structure. Step towards handling multiple inputs. --- libavfilter/vf_libplacebo.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH 17/22] lavfi/vf_libplacebo: add in_idx variable

2023-06-16 Thread Niklas Haas
From: Niklas Haas To allow placing an input dynamically, as a function of the input index. --- doc/filters.texi| 2 ++ libavfilter/vf_libplacebo.c | 9 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index a46357bfd8..2ea40

[FFmpeg-devel] [PATCH 16/22] lavfi/vf_libplacebo: make input-dependent vars dynamic

2023-06-16 Thread Niklas Haas
From: Niklas Haas Because these can differ based on the input, for multiple inputs. --- libavfilter/vf_libplacebo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 5af8167bb3..f86493f4e2 100644 --- a/l

[FFmpeg-devel] [PATCH 15/22] lavfi/vf_libplacebo: generalize frame update to multiple inputs

2023-06-16 Thread Niklas Haas
From: Niklas Haas In the event that some frame mixes are OK while others are not, the priority goes: 1. Errors in updating any frame -> return error 2. Any input incomplete -> request frames and return 3. Any inputs OK -> ignore EOF streams and render remaining inputs 4. No inputs OK -> set outp

[FFmpeg-devel] [PATCH 14/22] lavfi/vf_libplacebo: only drain actually used PTS

2023-06-16 Thread Niklas Haas
From: Niklas Haas When combining multiple inputs, the output PTS may be less than the PTS of the input. In this case, the current's code assumption of always draining one value from the FIFO is incorrect. Replace by a smarter function which drains only those PTS values that were actually consumed

[FFmpeg-devel] [PATCH 05/22] lavfi/vf_libplacebo: move temporary vars into per-input struct

2023-06-16 Thread Niklas Haas
From: Niklas Haas Including the queue status, because these will need to be re-queried inside output_frame_mix when that function is refactored to handle multiple inputs. --- libavfilter/vf_libplacebo.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavfilter/v

[FFmpeg-devel] [PATCH 04/22] lavfi/vf_libplacebo: cosmetic

2023-06-16 Thread Niklas Haas
From: Niklas Haas Assign local variable 'in' for 's->input' and replace 'inlink' by 'in->link' to avoid hard-coding ID 0 in more than one place. --- libavfilter/vf_libplacebo.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_libplaceb

[FFmpeg-devel] [PATCH 03/22] lavfi/vf_libplacebo: move input handling to separate function

2023-06-16 Thread Niklas Haas
From: Niklas Haas To be re-used once we support more than one input. --- libavfilter/vf_libplacebo.c | 45 - 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 10fd432745..879a3a0508

[FFmpeg-devel] [PATCH 02/22] lavfi/vf_libplacebo: move input-specific state to struct

2023-06-16 Thread Niklas Haas
From: Niklas Haas In anticipation of a refactor which will enable multiple input support. Note: the renderer is also input-specific because it maintains a frame cache, HDR peak detection state and mixing cache, all of which are tied to a specific input stream. --- libavfilter/vf_libplacebo.c |

[FFmpeg-devel] [PATCH 01/22] lavfi/vf_libplacebo: drop redundant case

2023-06-16 Thread Niklas Haas
From: Niklas Haas If the input queue is EOF, then the s->status check should already have covered it, and prevented the code from getting this far. If we still hit this case for some reason, it's probably a bug. Better to hit the AVERROR_BUG branch. --- libavfilter/vf_libplacebo.c | 3 --- 1 fi

Re: [FFmpeg-devel] [PATCH] avformat/hls: Forward stream metadata from subdemuxer

2023-06-16 Thread Anton Khirnov
Quoting Armin Hasitzka (2023-06-08 13:37:12) > Hi all, > > just checking; do you consider this for merge into the upstream? It does > feel like a lot of upside without any downside. Looks ok, will push soonish if nobody objects. -- Anton Khirnov ___ f

[FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: register free function for device_derive

2023-06-16 Thread Tong Wu
When qsv device is created by device_derive, the ctx->free function is not registered, causing potential memory leak because of not properly closing the MFX session. Signed-off-by: Tong Wu Signed-off-by: Wenbin Chen --- libavutil/hwcontext_qsv.c | 3 +++ 1 file changed, 3 insertions(+) diff --