Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2023-01-21 Thread Marton Balint
On Wed, 28 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32:4

[FFmpeg-devel] [PATCH 2/2] avutil/tx_priv: Use unsigned in BF() to avoid signed overflows

2023-01-21 Thread Michael Niedermayer
Fixes: signed integer overflow: 100183269 - -2132769113 cannot be represented in type 'int' Fixes: 55063/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5039294027005952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed

[FFmpeg-devel] [PATCH 1/2] avcodec/utils: use 32pixel alignment for bink

2023-01-21 Thread Michael Niedermayer
bink supports 16x16 blocks in chroma planes thus we need to allocate enough. Fixes: out of array access Fixes: 55026/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-6013915371012096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Hendrik Leppkes
On Sat, Jan 21, 2023 at 10:30 PM Marvin Scholz wrote: > > Or do you mean that there should be a public devel branch where API/ABI > breaking patches can be proposed for that will eventually be merged into > master at a defined point in time together with major bump? > Yes, I'm talking about one c

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marvin Scholz
On 21 Jan 2023, at 22:36, Michael Niedermayer wrote: > On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: >> Quoting Michael Niedermayer (2023-01-20 03:05:09) >>> PS: iam not sure i fully understood the reason behind why versions should be >>> set to "wrong" values during some period,

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marton Balint
On Sat, 21 Jan 2023, Michael Niedermayer wrote: On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-01-20 03:05:09) PS: iam not sure i fully understood the reason behind why versions should be set to "wrong" values during some period, so as alway

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: fix double-free on init failure

2023-01-21 Thread Martin Storsjö
On Fri, 20 Jan 2023, Cameron Gutman wrote: mfenc sets FF_CODEC_CAP_INIT_CLEANUP, so calling mf_close() on failure inside mf_init() results in a double-free. Signed-off-by: Cameron Gutman --- libavcodec/mfenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mfenc.c b/libavcodec/mf

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Michael Niedermayer
On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-01-20 03:05:09) > > PS: iam not sure i fully understood the reason behind why versions should be > > set to "wrong" values during some period, so as always i might be missing > > something > > The re

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marvin Scholz
On 21 Jan 2023, at 21:17, Hendrik Leppkes wrote: > On Sat, Jan 21, 2023 at 8:33 PM Marvin Scholz wrote: >>> >>> Alternatively, we could just not have an instability period at all. >>> >> >> Not having any instability period at all seems like a bad idea. >> > > Actually that sounds like the bes

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Hendrik Leppkes
On Sat, Jan 21, 2023 at 8:33 PM Marvin Scholz wrote: > > > > Alternatively, we could just not have an instability period at all. > > > > Not having any instability period at all seems like a bad idea. > Actually that sounds like the best idea. You would just have to prepare the bump in a branch a

Re: [FFmpeg-devel] [PATCH 0/1] Handle ASS format subtitle encoding ambiguity

2023-01-21 Thread Tim Angus
On 18/01/2023 14:31, Tim Angus wrote: Some matroska files embed ASS format subtitles. The header for said subtitles include the header for the subtitle stream in the "codec private data" section. It appears to be optional whether or not the last byte of this data is 0, i.e. a null terminator for

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marvin Scholz
On 21 Jan 2023, at 17:51, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-01-20 03:05:09) >> PS: iam not sure i fully understood the reason behind why versions should be >> set to "wrong" values during some period, so as always i might be missing >> something > > The reason is that afte

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Anton Khirnov
Quoting Leo Izen (2023-01-20 22:23:23) > On 1/18/23 14:28, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > >> It's been a while since the last bump, so it's time to do some cleaning and > >> remove deprecated APIs. This will also give us an "Open ABI season" in > >> which we >

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-01-20 03:05:09) > PS: iam not sure i fully understood the reason behind why versions should be > set to "wrong" values during some period, so as always i might be missing > something The reason is that after the major bump, the API and ABI are declared to be unsta

Re: [FFmpeg-devel] [PATCH] trailing padding

2023-01-21 Thread Paul B Mahol
On 1/16/23, Tobias Rapp wrote: > On 12/01/2023 10:41, Paul B Mahol wrote: > >> Patches attached, ffmpeg.c should really not ignore initial padding >> and trailing padding. > > I guess ffprobe.xsd should be updated, too. Did you run FATE? > Yes, it should be eventually updated. ___

[FFmpeg-devel] [PATCH] add WADY demuxer and decoder

2023-01-21 Thread Paul B Mahol
Hi, Patches attached. From 5f4f4a77e19fe12bc44ab32021cc3690610d03b9 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 21 Jan 2023 12:21:44 +0100 Subject: [PATCH 1/3] avcodec: add WADY DPCM decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1

Re: [FFmpeg-devel] [PATCH v4] avformat/dvd: new dvd:// protocol for reading dvd folder/images

2023-01-21 Thread Stanislav Ionascu
On Tue, Jan 17, 2023 at 8:12 AM Nicolas George wrote: > > Stanislav Ionascu (12023-01-15): > > dvd:// protocol uses libdvdread for opening folders and/or disc-images, > > it then either identifies the longest title-set, or uses the title-set > > parameter. > > > > After opening the dvd, libdvdread

[FFmpeg-devel] [PATCH v5] avformat/dvd: new dvd:// protocol for reading dvd folder/images

2023-01-21 Thread Stanislav Ionascu
dvd:// protocol uses libdvdread for opening folders and/or disc-images, it then either identifies the longest title-set, or uses the title-set parameter. After opening the dvd, libdvdread-protocol will read and output all VOBs, in the cell and pack sequence defined by the program-chain. The (spli