Re: [FFmpeg-devel] [PATCH v3 3/7] avcodec/mediacodecenc: use bsf to handle crop

2022-12-20 Thread zhilizhao(赵志立)
> On Dec 21, 2022, at 02:24, Tomas Härdin wrote: > > tor 2022-12-15 klockan 01:37 +0800 skrev Zhao Zhili: >> On Wed, 2022-12-14 at 18:08 +0100, Tomas Härdin wrote: >> >>> >>> I think we might want something for this inside lavf somewhere, so >>> that >>> encoders can signal dimension alignmen

Re: [FFmpeg-devel] [PATCH v3 3/7] avcodec/mediacodecenc: use bsf to handle crop

2022-12-20 Thread Tomas Härdin
tor 2022-12-15 klockan 01:37 +0800 skrev Zhao Zhili: > On Wed, 2022-12-14 at 18:08 +0100, Tomas Härdin wrote: > > > > > I think we might want something for this inside lavf somewhere, so > > that > > encoders can signal dimension alignment requirements. Some > > containers > > (MXF, MOV) support

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: include stdbool.h

2022-12-20 Thread Tomas Härdin
mån 2022-12-19 klockan 10:11 +0800 skrev zhilizhao(赵志立): > > > > On Dec 16, 2022, at 11:39, Zhao Zhili > > wrote: > > > > From: Zhao Zhili > > > > Since NDK failed to do that: > > https://github.com/android/ndk/issues/1281 > > --- > > libavcodec/mediacodec_wrapper.c | 1 + > > 1 file changed,

Re: [FFmpeg-devel] [PATCH v2] avcodec/mediacodecdec: add AV1 decoding support

2022-12-20 Thread Tomas Härdin
mån 2022-12-19 klockan 20:45 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- >  configure  |  2 ++ >  libavcodec/Makefile    |  1 + >  libavcodec/allcodecs.c |  1 + >  libavcodec/mediacodecdec.c | 16 +++- >  libavcodec/version.h 

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2022-12-20 Thread Dmitrii Ovchinnikov
Hi, >>When was this release released? The release was 13.12.2022 >> Is it headers only or is it runtime too? it still supports old drivers, but to use the av1 encoder, you need an up-to-date driver version and a supported graphics card. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/apac: Sanity check bits_per_coded_sample

2022-12-20 Thread Michael Niedermayer
On Mon, Dec 19, 2022 at 08:35:45PM +0100, Paul B Mahol wrote: > On 12/18/22, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > > 'int' > > Fixes: > > 53931/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APAC_fuzzer-6072913738727424 > >

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/wavpack: Avoid undefined shift in get_tail()

2022-12-20 Thread Michael Niedermayer
On Sun, Dec 18, 2022 at 07:14:27PM +0100, Paul B Mahol wrote: > On 12/18/22, Michael Niedermayer wrote: > > Fixes: left shift of 1208485947 by 1 places cannot be represented in type > > 'int' > > Fixes: > > 54058/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5827521084260352 > >

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2022-12-20 Thread Jean-Baptiste Kempf
Hello, When was this release released? Is it headers only or is it runtime too? Best jb On Tue, 20 Dec 2022, at 16:20, Dmitrii Ovchinnikov wrote: > From: Dmitrii Ovchinnikov > > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > in

Re: [FFmpeg-devel] [PATCH v6] lavc: convert frame threading to the receive_frame() pattern

2022-12-20 Thread James Almer
On 12/20/2022 1:06 PM, Timo Rothenpieler wrote: Generally, I don't see the advantage of this. The only decoder that would benefit from it is SMVJPEG, yet for all other codecs it will just involve more allocs+frees. Being unable to support newer encoders because only the old (and I thought dep

Re: [FFmpeg-devel] [PATCH v6] lavc: convert frame threading to the receive_frame() pattern

2022-12-20 Thread Timo Rothenpieler
On 20.12.2022 12:45, Andreas Rheinhardt wrote: Timo Rothenpieler: From: Anton Khirnov Reorganize the code such that the frame threading code does not call the decoders directly, but instead calls back into the generic decoding code. This avoids duplicating the logic that wraps the decoder invo

[FFmpeg-devel] [crop support for matroska demuxer, V4 3/3] libavformat\matroskadec.c: crop support for matroska demuxer.

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov In webm specification, it supports cropping information. (https://www.webmproject.org/docs/container/) In ffmpeg, the implementation of webm is a subset of matroska. In matroskadec.c, those cropping related four fields are forced to 0. for the sample file with crop (c

[FFmpeg-devel] [crop support for matroska demuxer, V4 2/3] libavcodec: Public code to support container crop

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov Support both simple and receive_frame api The container crop information is applied additional to frame crop information --- libavcodec/codec_par.c | 30 ++- libavcodec/decode.c| 54 ++ 2 files changed, 73

[FFmpeg-devel] [crop support for matroska demuxer, V4 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov --- libavcodec/avcodec.h | 35 +++ libavcodec/codec_par.h | 8 libavcodec/options_table.h | 4 3 files changed, 47 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3edd8e2636..57b340c

[FFmpeg-devel] [PATCH 2/2] libavcodec/amfenc: add AV1 encoding support

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov --- configure | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/amfenc.c | 9 + libavcodec/amfenc.h | 6 + libavcodec/amfenc_av1.c | 361 6 files changed, 379 insertio

[FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2022-12-20 Thread Dmitrii Ovchinnikov
From: Dmitrii Ovchinnikov --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 2180ebb4f1..8a20d67612 100755 --- a/configure +++ b/configure @@ -7034,7 +7034,7 @@ fi enabled amf && check_cpp_condition amf "AMF/core/Version.h" \ -

[FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-20 Thread Wujian(Chin)
>Marvin Scholz (12022-12-19): > I agree, but then the docs should probably mention that to not give a >> false sense of absolute security here. And maybe note that it might >Indeed, documentation is necessary. Is it appropriate to describe this document? Please give some suggestions. Thank yo

Re: [FFmpeg-devel] [PATCH v6] lavc: convert frame threading to the receive_frame() pattern

2022-12-20 Thread Andreas Rheinhardt
Timo Rothenpieler: > From: Anton Khirnov > > Reorganize the code such that the frame threading code does not call the > decoders directly, but instead calls back into the generic decoding > code. This avoids duplicating the logic that wraps the decoder > invocation and will be useful in the follo

[FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-20 Thread Wujian(Chin)
>> @@ -215,13 +249,13 @@ static void prepare_app_arguments(int *argc_ptr, char >> ***argv_ptr) >> if (win32_argv_utf8) { >> *argc_ptr = win32_argc; >> *argv_ptr = win32_argv_utf8; >> -return; >> +goto end; > We only use goto for error processing. I th

[FFmpeg-devel] [PATCH v2] avformat/mov: fix buffering issue for special HTTP(s) mp4.

2022-12-20 Thread Chen, Jinkai
Problem: Using ffplay play on these sources: https://ali-sprite-video.yyouwang.com/video/works/202211/1667997073624_73.mp4 https://images.voghion.com/productImages/04_01_C_30011_2020220106GiuseppeFanara0012.mp4 Solution: Add a private option, it will use separated IO context(HTTP connection) for e