Re: [FFmpeg-devel] [PATCH] avcodec/libx265: fix build error

> On Nov 3, 2022, at 22:20, Zhao Zhili wrote: > > From: Zhao Zhili > > x265_sei is available since X265_BUILD 88. Bump required version > to 89 to fix the regression from commit 1f585030137, and remove a > conditional compilation. > > Signed-off-by: Zhao Zhili > --- > configure

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/libsvtav1: remove compressed_ten_bit_format and simplify alloc_buffer

On 11/17/2022 8:23 PM, Christopher Degawa wrote: On Thu, Oct 27, 2022 at 11:23 AM Christopher Degawa wrote: On Thu, Oct 20, 2022 at 11:56 PM Christopher Degawa wrote: From: Christopher Degawa compressed_ten_bit_format has been deprecated upstream and has no effect and can be removed. Pl

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/libsvtav1: remove compressed_ten_bit_format and simplify alloc_buffer

On Thu, Oct 27, 2022 at 11:23 AM Christopher Degawa wrote: > > > On Thu, Oct 20, 2022 at 11:56 PM Christopher Degawa > wrote: > >> From: Christopher Degawa >> >> compressed_ten_bit_format has been deprecated upstream and has no effect >> and can be removed. Plus, technically it was never used i

Re: [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE

Renewing ping. CC Andreas and Lynne since they were interested previously. amyspark On 07/11/2022 11:48, L. E. Segovia wrote: > Ping for review. > > amyspark > > On 03/11/2022 13:36, L. E. Segovia wrote: >> Hi all, >> >> This new version is intended to make Patchwork log the set correctly. >> (

[FFmpeg-devel] [PATCH] x86/intmath: use _bzhi_u32 instead of the GCC internal builtin

GCC does not recommend using their __builtin_ia32* builtins, so use the Intel defined one instead. Signed-off-by: James Almer --- libavutil/x86/intmath.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/x86/intmath.h b/libavutil/x86/intmath.h index 8a6b5ae261..2c70

Re: [FFmpeg-devel] [PATCH 1/7] configure: drop support for complex functions

On 11/17/22, Anton Khirnov wrote: > They are not used since 520a5d33f0ea9f8838dbc7282470db700d248065. > --- > configure | 25 - > 1 file changed, 25 deletions(-) > > diff --git a/configure b/configure > index e6470dc03b..868d11567b 100755 > --- a/configure > +++ b/configur

Re: [FFmpeg-devel] [PATCH 4/7] doc/developer.texi: document the use of other languages than C

Nov 17, 2022, 15:25 by jamr...@gmail.com: > On 11/17/2022 11:17 AM, Lynne wrote: > >> Nov 17, 2022, 11:09 by an...@khirnov.net: >> >>> --- >>> doc/developer.texi | 15 +-- >>> 1 file changed, 13 insertions(+), 2 deletions(-) >>> >>> diff --git a/doc/developer.texi b/doc/developer.texi

Re: [FFmpeg-devel] [PATCH 4/7] doc/developer.texi: document the use of other languages than C

On 11/17/2022 11:17 AM, Lynne wrote: Nov 17, 2022, 11:09 by an...@khirnov.net: --- doc/developer.texi | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 01735e07f5..44da6e41af 100644 --- a/doc/developer.texi +++

Re: [FFmpeg-devel] [PATCH 4/7] doc/developer.texi: document the use of other languages than C

Nov 17, 2022, 11:09 by an...@khirnov.net: > --- > doc/developer.texi | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 01735e07f5..44da6e41af 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -

[FFmpeg-devel] Ffmpeg/ffprobe not work well with a DASH stream

Hi, Thank you so much for this amazing project. I’ve found this project has been extremely useful for me. I’ve found out that ffmpeg/ffplay does not work well with one of our DASH streams. In comparison, I’ve tried the following players 1. ExoPlayer 2. DASH-JS player

[FFmpeg-devel] [PATCH] fate/aacenc: increase tolerance for ln-128k test

The encoder is sensitive to changes in precision, and its test target was a compromise. It was already close to failing on x87 FPUs. ff_mdct_init used double precision entirely from the scale to computing the MDCT exp tables. av_tx_init uses single-precision for the scale, with a small input change

Re: [FFmpeg-devel] [PATCH] fate: Mark the tiff-zip-* tests as requiring zlib

On Thu, 17 Nov 2022, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- tests/fate/image.mak | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 167c8ccf2c..42dd90feaa 100644 --- a/tests/fate/image.mak +++ b/tests/fate/i

[FFmpeg-devel] [PATCH 10/10] fftools/ffmpeg_mux_init: postpone matching -disposition to streams

Do it in set_dispositions() rather than during stream creation. Since at this point all other stream information is known, this allows setting disposition based on metadata, which implements #10015. This also avoids an extra allocated string in OutputStream that was unused after of_open(). --- ff

[FFmpeg-devel] [PATCH 07/10] fftools/ffmpeg: do not assume input streams exist

There can be zero input streams, with input provided by lavfi complex filtergraphs. --- fftools/ffmpeg.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0944f56b80..c43c3ca3bc 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@

[FFmpeg-devel] [PATCH 08/10] fftools/ffmpeg: declare loop variables inside loops in transcode_init()

--- fftools/ffmpeg.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index c43c3ca3bc..3767ab444b 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -3140,21 +3140,19 @@ static int init_output_stream(OutputStre

[FFmpeg-devel] [PATCH 04/10] fftools/ffmpeg: replace OutputStream.source_index with a pointer to InputStream

This is simpler. The indirection via an index exists for historical reasons that longer apply. --- fftools/ffmpeg.c | 42 ++- fftools/ffmpeg.h | 7 ++- fftools/ffmpeg_mux_init.c | 37 -- 3 files changed, 38

[FFmpeg-devel] [PATCH 09/10] fftools/ffmpeg: _-prefix variables in MATCH_PER_STREAM_OPT()

Avoids conflicts, e.g. when 'i' is used in the outvar expression. --- fftools/ffmpeg.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 5fc3b2d3d4..5cae266600 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h

[FFmpeg-devel] [PATCH 06/10] fftools/ffmpeg: remove the input_streams global

Replace it with an array of streams in each InputFile. This is a more accurate reflection of the actual relationship between InputStream and InputFile. Analogous to what was previously done to output streams in 7ef7a22251b852faab9404c85399ba8ac5dfbdc3. --- fftools/ffmpeg.c | 86

[FFmpeg-devel] [PATCH 05/10] fftools/ffmpeg_mux_init: simplify inner loop in map_auto_{video, audio}

Skip unusable streams early and do not compute any scores for them. --- fftools/ffmpeg_mux_init.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index e460e7603f..6db70cc852 100644 --- a/fftools/ffmpe

[FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg: move freeing an input stream into a separate function

--- fftools/ffmpeg.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index dfdfad3ce4..25155e155e 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -502,6 +502,28 @@ static int decode_interrup

[FFmpeg-devel] [PATCH 03/10] fftools/ffmpeg: stop inventing fake source information

This code was supposed to affect copying stream dispositions, but it does not achieve that after bd2d69, since dispositions are set earlier. --- fftools/ffmpeg.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 2c4dc83f03..08fdd6e98f

[FFmpeg-devel] [PATCH 02/10] fftools/ffmpeg: drop an arbitrary condition

Encoding init code will currently fall back to a 25fps default when no framerate is known or specified, but only if there is a known source input stream. There is no good reason for this condition, so drop it. --- fftools/ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[FFmpeg-devel] [PATCH 7/7] doc/developer.texi: extend and update naming conventions

Bring it up to date with current practice, as the current text does not cover everything. Drop the reference to unprefixed exported symbols, which do not exist anymore. --- doc/developer.texi | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff

[FFmpeg-devel] [PATCH 6/7] doc/developer.texi: drop a misplaced sentence from code formatting section

It describes a general development policy, not code formatting. It is also not true, as these days we tend to prioritize correctness, safety, and completeness over code size. --- doc/developer.texi | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index

[FFmpeg-devel] [PATCH 2/7] doc/developer.texi: move the language feature section higher up

It makes more sense to first describe the language we are using and only then document how to format code in it, rather than the reverse. --- doc/developer.texi | 104 ++--- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/doc/developer.texi b

[FFmpeg-devel] [PATCH 3/7] doc/developer.texi: update the language feature section

It is currently very out of touch with reality. * declare we are using C99 fully, rather than C90 plus extensions * mention our use of stdatomic.h * mention forbidden C99 features, like VLAs and complex numbers --- doc/developer.texi | 49 -- 1 file cha

[FFmpeg-devel] [PATCH 4/7] doc/developer.texi: document the use of other languages than C

--- doc/developer.texi | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 01735e07f5..44da6e41af 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -56,9 +56,9 @@ and should try to fix issues their commit caus

[FFmpeg-devel] [PATCH 5/7] doc/developer.texi: move editor configuration under formatting

It logically belongs there. --- doc/developer.texi | 67 +++--- 1 file changed, 34 insertions(+), 33 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 44da6e41af..d0e2e04a2d 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -

[FFmpeg-devel] [PATCH 1/7] configure: drop support for complex functions

They are not used since 520a5d33f0ea9f8838dbc7282470db700d248065. --- configure | 25 - 1 file changed, 25 deletions(-) diff --git a/configure b/configure index e6470dc03b..868d11567b 100755 --- a/configure +++ b/configure @@ -1317,21 +1317,6 @@ int main(void){ $func(); }

[FFmpeg-devel] [PATCH] fate: Mark the tiff-zip-* tests as requiring zlib

Signed-off-by: Martin Storsjö --- tests/fate/image.mak | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 167c8ccf2c..42dd90feaa 100644 --- a/tests/fate/image.mak +++ b/tests/fate/image.mak @@ -513,12 +513,13 @@ fate-tiff-lzw