Re: [FFmpeg-devel] [PATCH 2/2] lavc/pthread_frame: avoid leaving stale hwaccel state in worker threads

2022-09-11 Thread Wang Bin
Wang Bin 于2022年9月12日周一 10:02写道: > >> av_packet_unref(p->avpkt); >> @@ -655,6 +670,14 @@ void ff_thread_finish_setup(AVCodecContext *avctx) { >> async_lock(p->parent); >> } >> >> +/* save hwaccel state for passing to the next thread; >> + * this is done here so that this

Re: [FFmpeg-devel] [PATCH 2/2] lavc/pthread_frame: avoid leaving stale hwaccel state in worker threads

2022-09-11 Thread Wang Bin
> > > av_packet_unref(p->avpkt); > @@ -655,6 +670,14 @@ void ff_thread_finish_setup(AVCodecContext *avctx) { > async_lock(p->parent); > } > > +/* save hwaccel state for passing to the next thread; > + * this is done here so that this worker thread can wipe its own > hwacc

Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

2022-09-11 Thread Peter Ross
On Sun, Sep 11, 2022 at 06:38:39AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > >> It is a VP8-only feature. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/vp8.c | 3 +-- > >> 1 file changed, 1 inser

Re: [FFmpeg-devel] [PATCH v3 2/3] lavf/dashdec: Multithreaded DASH initialization

2022-09-11 Thread Lukas Fellechner
      Gesendet: Montag, 05. September 2022 um 12:45 Uhr Von: "Andreas Rheinhardt" An: ffmpeg-devel@ffmpeg.org Betreff: Re: [FFmpeg-devel] [PATCH v3 2/3] lavf/dashdec: Multithreaded DASH initialization Lukas Fellechner: >>> Moreover, older pthread standards did not allow to use >>> PTHREAD_MUTEX

Re: [FFmpeg-devel] [PATCH] slicethread: Limit the automatic number of threads to 16

2022-09-11 Thread Lukas Fellechner
>> 2. Spawning too many threads when "auto" is used in multiple places >> >> This can indeed be an efficiency problem, although probably not major. >> Since usually only one part of the pipeline is active at any time, >> many of the threads will be sleeping, consuming very little resources. > > For

Re: [FFmpeg-devel] [PATCH] slicethread: Limit the automatic number of threads to 16

2022-09-11 Thread Lukas Fellechner
Gesendet: Dienstag, 06. September 2022 um 23:11 Uhr Von: "Andreas Rheinhardt" An: ffmpeg-devel@ffmpeg.org Betreff: Re: [FFmpeg-devel] [PATCH] slicethread: Limit the automatic number of threads to 16 Lukas Fellechner: >> 1. Running out of address space in 32-bit processes >> >> It probably makes s

[FFmpeg-devel] [PATCH v2] configure: try to use -flto=thin or -flto=auto if available

2022-09-11 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9e51abd0d3..a651fdec5a 100755 --- a/configure +++ b/configure @@ -7173,8 +7173,9 @@ check_optflags -fno-signed-zeros if enabled lto; then test

Re: [FFmpeg-devel] [PATCH] Bonk, Bonk

2022-09-11 Thread Paul B Mahol
On 9/7/22, Paul B Mahol wrote: > Patches attached. > > Could decoder be made faster? > Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

2022-09-11 Thread Carl Eugen Hoyos
Am So., 11. Sept. 2022 um 17:29 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > From 421041e7cd1bce8952756e60a0dd428f1618d75a Mon Sep 17 00:00:00 2001 > > From: Carl Eugen Hoyos > > Date: Sun, 11 Sep 2022 16:02:09 +0200 > > Subject: [PATCH] lavc/x86/simple_idct: Fix linking shared libav

[FFmpeg-devel] [PATCH] fate/spdif: Add spdif tests

2022-09-11 Thread Andreas Rheinhardt
These tests test both the demuxer as well as the muxer wherever possible. It is not always possible due to the fact that the muxer supports more codecs than the demuxer. The spdif demuxer does currently not set the need_parsing flag. If one were to set this to AVSTREAM_PARSE_FULL, the test results

[FFmpeg-devel] [PATCH] swscale: add missing opaque parameter after f2de911818

2022-09-11 Thread Kacper Michajłow
Fixes function prototype mismatch, warning Wlto-type-mismatch. Signed-off-by: Kacper Michajłow --- libswscale/x86/rgb2rgb_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/x86/rgb2rgb_template.c b/libswscale/x86/rgb2rgb_template.c index 4aba25dd51..f6

[FFmpeg-devel] [PATCH] configure: use -flto=auto if available

2022-09-11 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9e51abd0d3..bf5a687239 100755 --- a/configure +++ b/configure @@ -7173,8 +7173,9 @@ check_optflags -fno-signed-zeros if enabled lto; then test

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

2022-09-11 Thread Andreas Rheinhardt
Carl Eugen Hoyos: > From 421041e7cd1bce8952756e60a0dd428f1618d75a Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Sun, 11 Sep 2022 16:02:09 +0200 > Subject: [PATCH] lavc/x86/simple_idct: Fix linking shared libavcodec with MS > link.exe > > link.exe hangs on empty simple_idct.o > > Fix

Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

2022-09-11 Thread Ronald S. Bultje
Hi, On Sun, Sep 11, 2022 at 10:41 AM Ronald S. Bultje wrote: > Hi, > > On Sun, Sep 11, 2022 at 12:38 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Peter Ross: >> > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: >> >> It is a VP8-only feature. >> >> >>

Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

2022-09-11 Thread Ronald S. Bultje
Hi, On Sun, Sep 11, 2022 at 12:38 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Peter Ross: > > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > >> It is a VP8-only feature. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/vp8.c | 3 +-

[FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Fix overflow in k=31

2022-09-11 Thread Michael Niedermayer
Untested with "non fuzzed" samples as i have no such file Fixes: shift exponent 32 is too large for 32-bit type 'int' Fixes: 50930/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-6319201949712384 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/maste

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

2022-09-11 Thread Carl Eugen Hoyos
Am So., 11. Sept. 2022 um 16:26 Uhr schrieb James Almer : > > On 9/11/2022 11:17 AM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #9909 for me, regression since 4618f36a > > > > Please comment, Carl Eugen > > It would help if the patch was attached :p Good point! Carl Eugen

[FFmpeg-devel] [PATCH 5/5] tools/target_dec_fuzzer: Adjust threshold for Jpeg2000

2022-09-11 Thread Michael Niedermayer
Fixes: Timeout Fixes: 50955/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5148704872464384 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +- 1 file cha

[FFmpeg-devel] [PATCH 4/5] avcodec/hdrdec: Update w in inner loop of decompress()

2022-09-11 Thread Michael Niedermayer
Fixes: out of array access Fixes: 50936/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HDR_fuzzer-5423041009549312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hdrdec.c | 2 +- 1 file ch

[FFmpeg-devel] [PATCH 1/5] avformat/mxfdec: Avoid some redundant writing to tables in mxf_compute_ptses_fake_index()

2022-09-11 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e63e803aa56..4ceb6cf672f 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1939,10 +1939,10 @@ stati

[FFmpeg-devel] [PATCH 3/5] avcodec/wavpack: Check for end of input in wv_unpack_dsd_high()

2022-09-11 Thread Michael Niedermayer
Fixes: Timeout Fixes: 50793/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-4980185027444736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.c | 4 1 file changed

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

2022-09-11 Thread James Almer
On 9/11/2022 11:17 AM, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #9909 for me, regression since 4618f36a Please comment, Carl Eugen It would help if the patch was attached :p ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

2022-09-11 Thread Carl Eugen Hoyos
Am So., 11. Sept. 2022 um 16:17 Uhr schrieb Carl Eugen Hoyos : > > Attached patch fixes ticket #9909 for me, regression since 4618f36a Sorry, it was bfb28b5ce89f3e950214b67ea95b45e3355c2caf Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

[FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

2022-09-11 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #9909 for me, regression since 4618f36a Please comment, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-

Re: [FFmpeg-devel] [PATCH v2] avformat/riffdec: don't unconditionally overwrite WAVEFORMATEXTENSIBLE layout

2022-09-11 Thread James Almer
On 9/10/2022 10:56 AM, James Almer wrote: Do it only if the value conflicts with the previous channels value. Fixes ticket #9912 Signed-off-by: James Almer --- libavformat/riffdec.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/riffdec.c b/libav

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/dstdec: Check for overflow in build_filter()

2022-09-11 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Hi, > > Down-casting to a signed type (here, int16_t) is implementation-defined. And > while normal compilers do the expected thing, with modulo-2^n complement, > sanitizers tend to dislike it. > 1. We expect the implementation-defined behaviour for signed types to match

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/dstdec: Check for overflow in build_filter()

2022-09-11 Thread Rémi Denis-Courmont
Hi, Down-casting to a signed type (here, int16_t) is implementation-defined. And while normal compilers do the expected thing, with modulo-2^n complement, sanitizers tend to dislike it. AFAIK, the clean solution is via an union whence you assign the uint16_t member, and then read the int16_t m

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_colorrange_cuda: CUDA-accelerated video filter for MPEG and JPEG color range conversions

2022-09-11 Thread Roman Arzumanyan
Thanks for the detailed review, Timo. Please find fixed patch in attachement. От: ffmpeg-devel от имени Timo Rothenpieler Отправлено: 10 сентября 2022 г. 16:16 Кому: FFmpeg development discussions and patches ; Roman Arzumanyan Копия: Yogender Gupta ; Sven Mi