[FFmpeg-devel] [PATCH v2] lavc/aarch64: hevc_add_res add 12bit variants

2022-08-15 Thread J. Dekker
hevc_add_res_4x4_12_c: 46.0 hevc_add_res_4x4_12_neon: 18.7 hevc_add_res_8x8_12_c: 194.7 hevc_add_res_8x8_12_neon: 25.2 hevc_add_res_16x16_12_c: 716.0 hevc_add_res_16x16_12_neon: 69.7 hevc_add_res_32x32_12_c: 3820.7 hevc_add_res_32x32_12_neon: 261.0 Signed-off-by: J. Dekker --- libavcodec/aarch64

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-15 Thread Gyan Doshi
On 2022-08-16 01:32 am, Thilo Borgmann wrote: +struct display_matrix_s { +const AVClass *class; +double rotation; +int hflip; +int vflip; +}; There should be a scale option too since the matrix encodes that transform as well. Ref. ISO/IEC 1

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: fix frag_index.current out of sync

2022-08-15 Thread zhilizhao(赵志立)
> On Aug 11, 2022, at 3:56 PM, Steven Liu wrote: > > "zhilizhao(赵志立)" 于2022年8月11日周四 15:07写道: >> >> >> >>> On Jul 31, 2022, at 1:14 AM, Zhao Zhili wrote: >>> >>> From: Zhao Zhili >>> >>> frag_index.current is used by cenc_filter, and is updated inside >>> mov_read_moof. It can out of syn

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread Mark Gaiser
On Mon, Aug 15, 2022 at 11:57 PM Nicolas George wrote: > Michael Niedermayer (12022-08-15): > > It says this now: > >"IPFS does not appear to be running.\n\n" > >"Installing IPFS locally is recommended to " > >"improve performance and re

[FFmpeg-devel] [PATCH] avformat/mov: don't read duration from mvhd atom

2022-08-15 Thread James Almer
This duration is equal to the longest duration in all track's tkhd atoms, which may be comprised of the sum of all edit lists in each track. Empty edit lists in tracks represent start_time, and the actual media duration is stored in the mdhd atom. This change lets the generic demux code derive the

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/h263dec: Remove redundant code to set cur_pic_ptr

2022-08-15 Thread Michael Niedermayer
On Mon, Aug 15, 2022 at 01:49:24PM +0200, Andreas Rheinhardt wrote: > It is done later in ff_mpv_frame_start() (and nobody uses > current_picture_ptr between setting it in ff_mpv_frame_start()). > > (The reason the vsynth*-h263-obmc code changes is because > the call to ff_find_unused_picture() no

Re: [FFmpeg-devel] [PATCH 2/3] lavc/vaapi: Add support for remaining 10/12bit profiles

2022-08-15 Thread Michael Niedermayer
On Sun, Aug 14, 2022 at 02:33:12PM -0700, Philip Langdale wrote: > With the necessary pixel formats defined, we can now expose support for > the remaining 10/12bit combinations that VAAPI can handle. > > Specifically, we are adding support for: > > * HEVC > ** 12bit 420 > ** 10bit 422 > ** 12bit

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread Nicolas George
Michael Niedermayer (12022-08-15): > It says this now: >"IPFS does not appear to be running.\n\n" >"Installing IPFS locally is recommended to " >"improve performance and reliability, " > That removes the gateway (because it cant be trusted

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread Michael Niedermayer
On Mon, Aug 15, 2022 at 08:35:18PM +0100, Derek Buitenhuis wrote: > On 8/10/2022 11:27 PM, Derek Buitenhuis wrote: > > A gateway can see everything, and we should not be shipping a hardcoded > > default from a third party company; it's a security risk. > > > > Signed-off-by: Derek Buitenhuis > >

Re: [FFmpeg-devel] [PATCH v2 0/2] 32bps FLAC patches

2022-08-15 Thread Martijn van Beurden
Op ma 1 aug. 2022 om 14:03 schreef Martijn van Beurden : > Recently libFLAC gained the ability (not in any released version yet > though) to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integers, which the

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/h263dec: Sanity check against minimal I/P frame size

2022-08-15 Thread Michael Niedermayer
On Mon, Aug 15, 2022 at 09:04:09PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: Timeout > > Fixes: > > 49718/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-4874987894341632 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/t

[FFmpeg-devel] [PATCH v2 4/4] ffmpeg: Allow printing of option arguments in help output

2022-08-15 Thread Thilo Borgmann
$subject -ThiloFrom 33abe03ac137bd1e4bf4af90731ec177d34298a8 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 15 Aug 2022 21:00:18 +0200 Subject: [PATCH v2 4/4] ffmpeg: Allow printing of option arguments in help output --- fftools/cmdutils.c | 5 + libavutil/opt.c| 14 +++

[FFmpeg-devel] [PATCH v2 3/4] ffmpeg: Deprecate display rotation override with a metadata key

2022-08-15 Thread Thilo Borgmann
$subject -ThiloFrom 2c556c126b77b7bc90749096f858daa6124cf097 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= Date: Mon, 15 Aug 2022 20:58:05 +0200 Subject: [PATCH v2 3/4] ffmpeg: Deprecate display rotation override with a metadata key Now that we have proper options for defining

[FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-15 Thread Thilo Borgmann
$subject -ThiloFrom fe2ff114cb004f897c7774753d9cf28298eba82d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= Date: Mon, 15 Aug 2022 21:09:27 +0200 Subject: [PATCH v2 2/4] ffmpeg: Add display_matrix option This enables overriding the rotation as well as horizontal/vertical flip sta

[FFmpeg-devel] [PATCH v2 1/4] fftools: Add support for dictionary options

2022-08-15 Thread Thilo Borgmann
Hi, this is an updated and cleaned-up version of Jan's patchset discussed in [1], therefore v2... Comments from the previous thread are in and left-overs from the several options version removed. I'd especially appreciate any comments on 2/4, ffmpeg_opt.c:112ff which is pretty ugly as-is. Sho

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread James Almer
On 8/15/2022 4:35 PM, Derek Buitenhuis wrote: On 8/10/2022 11:27 PM, Derek Buitenhuis wrote: A gateway can see everything, and we should not be shipping a hardcoded default from a third party company; it's a security risk. Signed-off-by: Derek Buitenhuis --- libavformat/ipfsgateway.c | 11 ++

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread Derek Buitenhuis
On 8/10/2022 11:27 PM, Derek Buitenhuis wrote: > A gateway can see everything, and we should not be shipping a hardcoded > default from a third party company; it's a security risk. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/ipfsgateway.c | 11 --- > 1 file changed, 4 inserti

Re: [FFmpeg-devel] The case for a good string API

2022-08-15 Thread Michael Niedermayer
On Fri, Jun 17, 2022 at 04:57:55PM +0200, Nicolas George wrote: > Stefano Sabatini (12022-06-17): > > I was thinking about mempool (and no, I don't think it's really > > neeeded for this use case). > > > > I still had to read the implementation, now I think I got what this is > > about. > > You h

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/h263dec: Sanity check against minimal I/P frame size

2022-08-15 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: Timeout > Fixes: > 49718/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-4874987894341632 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcod

[FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs

2022-08-15 Thread Gyan Doshi
c11fb46731 led to a regression whereby the return code for missing input or input probe is overridden by writer close return code and hence not conveyed in the exit code. --- fftools/ffprobe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Affects 5.1 so will need to be backported the

Re: [FFmpeg-devel] [PATCH 08/11] avutil/half2float: move non-inline init code out of header

2022-08-15 Thread Michael Niedermayer
On Mon, Aug 15, 2022 at 06:20:45AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Aug 11, 2022 at 11:31:32PM +0200, Andreas Rheinhardt wrote: [...] > > make distclean ; ../configure --enable-shared --cc='ccache clang-6.0' > > --enable-pthreads --samples=fate/fate-suite/ --ena

[FFmpeg-devel] [PATCH 2/4] avcodec/hevcdec: Check s->ref in the md5 path similar to hwaccel

2022-08-15 Thread Michael Niedermayer
This is somewhat redundant with the is_decoded check. Maybe there is a nicer solution Fixes: Null pointer dereference Fixes: 49584/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5297367351427072 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/p

[FFmpeg-devel] [PATCH 3/4] avcodec/h263dec: Sanity check against minimal I/P frame size

2022-08-15 Thread Michael Niedermayer
Fixes: Timeout Fixes: 49718/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-4874987894341632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h263dec.c | 2 ++ 1 file changed, 2

[FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust threshold for ZLIB

2022-08-15 Thread Michael Niedermayer
Fixes: Timeout Fixes: 49769/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZLIB_fuzzer-6302938657587200 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

[FFmpeg-devel] [PATCH 1/4] avcodec/mpegaudiodec_template: use unsigned shift in handle_crc()

2022-08-15 Thread Michael Niedermayer
Fixes: left shift of 192 by 24 places cannot be represented in type 'int' Fixes: 49577/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MP1FLOAT_fuzzer-5205996678545408 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread Michael Niedermayer
On Wed, Aug 10, 2022 at 11:27:08PM +0100, Derek Buitenhuis wrote: > A gateway can see everything, and we should not be shipping a hardcoded > default from a third party company; it's a security risk. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/ipfsgateway.c | 11 --- > 1 file

[FFmpeg-devel] API enhancements / broken promises

2022-08-15 Thread Nicolas George
Hi. Over the years, I have promised quite a few enhancement to FFmpeg's API, some of them connecting to user interface: stored error messages instead of just logging, universal serialization of objects into various formats (JSON, XML, etc.), a way to exfiltrate data from filters and other componen

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_dec: Don't sync AVCodecContext fields manually

2022-08-15 Thread Andreas Rheinhardt
They are already synced generically in update_context_from_thread() in pthread_frame.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c index 7566fe69f9..fd706070b2 10

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread Jean-Baptiste Kempf
Yo, On Mon, 15 Aug 2022, at 16:09, Nicolas George wrote: > As for what to do now, I suggest we approve Derek's patch removing the > default gateway, and discuss the rest after. I agree. This is the simplest for now, yes. What one can do, is suggest known examples of gateways in the error log m

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-15 Thread Nicolas George
Michael Niedermayer (12022-08-13): > what iam a bit "upset" about is that running a IPFS node is presented as > if that was more private than using a gateway. I do not think it was suggested that it was more private and/or secure. A more accurate and detailed statement of the issue is that both s

[FFmpeg-devel] [PATCH 6/7] avcodec/ffv1enc: Don't create and keep unnecessary reference

2022-08-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ffv1.h| 1 + libavcodec/ffv1enc.c | 15 ++- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index ac80fa85ce..3532815501 100644 --- a/libavcodec/ffv1.h +++ b/libavcodec/ffv1.h @@

[FFmpeg-devel] [PATCH 7/7] avcodec/ffv1enc: Remove redundant wrapper

2022-08-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ffv1enc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 6f8b8275b5..90593fbaf1 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -1240,12 +1240,6 @@ static

[FFmpeg-devel] [PATCH 5/7] avcodec/get_buffer: Don't get AVPixFmtDescriptor unnecessarily

2022-08-15 Thread Andreas Rheinhardt
It is unused since 3575a495f6dcc395656343380e13c57d48b9f976 (and the error message is dangerous: av_get_pix_fmt_name(format) returns NULL iff av_pix_fmt_desc_get(format) returns NULL and using a NULL string for %s would be UB). Signed-off-by: Andreas Rheinhardt --- libavcodec/get_buffer.c | 8 --

[FFmpeg-devel] [PATCH 4/7] avcodec/mpegvideo_dec: Remove commented-out cruft

2022-08-15 Thread Andreas Rheinhardt
The fields in question were removed in 759001c534287a96dc96d1e274665feb7059145d. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c index 93ba4e31b3..17d0c73926 100644 --- a

[FFmpeg-devel] [PATCH 3/7] avcodec/mpegpicture: Reset fields explicitly instead of memsetting them

2022-08-15 Thread Andreas Rheinhardt
Improves the grepability of the code. (Furthermore, I hope that no compiler will really call memset for 28 bytes.) Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpe

[FFmpeg-devel] [PATCH 2/7] avcodec/h263dec: Don't set frame parameters redundantly

2022-08-15 Thread Andreas Rheinhardt
This frame will be reset later in ff_mpv_frame_start() anyway. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263dec.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index a65f16caea..a14d7811f5 100644 --- a/libavcodec/h263dec.c +++ b/libavc

[FFmpeg-devel] [PATCH 1/7] avcodec/h263dec: Remove redundant code to set cur_pic_ptr

2022-08-15 Thread Andreas Rheinhardt
It is done later in ff_mpv_frame_start() (and nobody uses current_picture_ptr between setting it in ff_mpv_frame_start()). (The reason the vsynth*-h263-obmc code changes is because the call to ff_find_unused_picture() now happens after the older pictures have been unreferenced in ff_mpv_frame_star

Re: [FFmpeg-devel] [PATCH v2 4/5] libswscale: Enable hscale_avx2 for all input sizes.

2022-08-15 Thread Alan Kelly
Hi Michael, Is there anything blocking this change being applied? Is there anything I can do to help? Thanks, Alan On Mon, Jul 18, 2022 at 6:49 PM Michael Niedermayer wrote: > On Mon, Jul 18, 2022 at 09:54:39AM +0200, Alan Kelly wrote: > > Hi Michael, > > > > I have tried to recreate this loc