[FFmpeg-devel] lavf/isom: is ff_mp4_obj_type for FLAC useful somewhere

2022-05-31 Thread Martijn van Beurden
In libavformat/isom.c there is a table of object type indications, ff_mp4_obj_type. There are a few entries at the bottom that are nonstandard. I was wondering where this table is used, and more specifically, where the FLAC entry is used. I can find few references to this table in the source code,

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/qsvdec: Implement SEI parsing for QSV decoders

2022-05-31 Thread Xiang, Haihao
On Thu, 2022-05-26 at 08:08 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > libavcodec/qsvdec.c | 233 > 1 file changed, 233 insertions(+) > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > index 5fc5bed4c8..

[FFmpeg-devel] [PATCH v2] tools/target_dec_fuzzer: add a custom get_buffer2() implementation

2022-05-31 Thread James Almer
Unlike avcodec_default_get_buffer2(), this version does not allocate more than what the normal image helper functions consider should be allocated for a given frame. Since the get_buffer2() documentation does not require any kind of buffer overallocation for any of the planes, this should help dete

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: add a custom get_buffer2() implementation

2022-05-31 Thread James Almer
Unlike avcodec_default_get_buffer2(), this version does not allocate more than what the normal image helper functions consider should be allocated for a given frame. Since the get_buffer2() documentation does not require any kind of buffer overallocation for any of the planes, this should help dete

[FFmpeg-devel] [PATCH 2/2] fate/dca: Fix test requirements

2022-05-31 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/dca.mak | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/fate/dca.mak b/tests/fate/dca.mak index 5168c1bc78..2b8f83497c 100644 --- a/tests/fate/dca.mak +++ b/tests/fate/dca.mak @@ -22,7 +22,7 @@ DCADEC_SUITE_

[FFmpeg-devel] [PATCH 1/2] tests/Makefile: Add PCM function

2022-05-31 Thread Andreas Rheinhardt
For use with the "pcm" command. Signed-off-by: Andreas Rheinhardt --- tests/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/tests/Makefile b/tests/Makefile index 035bdf783e..d9c509a415 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -108,6 +108,10 @@ FRAMECRC = $(call ALLYES

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-31 Thread James Almer
On 5/31/2022 4:12 PM, Vignesh Venkatasubramanian wrote: On Wed, May 18, 2022 at 10:37 AM Vignesh Venkatasubramanian wrote: libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Sig

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-05-31 Thread Vignesh Venkatasubramanian
On Thu, May 19, 2022 at 9:08 AM Vignesh Venkatasubramanian wrote: > > On Wed, May 18, 2022 at 7:36 PM Bang He wrote: > > > > error happened: > > > > ./ffmpeg -i alpha.png -filter_complex [0:v]alphaextract[a] -map 0 -map [a] > > -still-picture 1 avif_with_alpha.avif > > ffmpeg version N-106936-gff

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-31 Thread Vignesh Venkatasubramanian
On Wed, May 18, 2022 at 10:37 AM Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > images. Expose that in the ffmpeg's wrapper. This is especially > useful for encoding still AVIF images. > > Signed-off-by: Vignesh Venkatasubramanian > --- >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-05-31 Thread Vignesh Venkatasubramanian
On Thu, May 19, 2022 at 9:13 AM Vignesh Venkatasubramanian wrote: > > On Mon, May 16, 2022 at 9:59 AM Vignesh Venkatasubramanian > wrote: > > > > Update the still AVIF parser to only read the primary item. With this > > patch, AVIF still images with exif/icc/alpha channel will no longer > > fail

Re: [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace.

2022-05-31 Thread Ronald S. Bultje
Hi, On Thu, May 19, 2022 at 4:42 PM Mohammad Izadi < izadi-at-google@ffmpeg.org> wrote: > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support > YCGCO as input. Added YCOCG to the inputs. > --- > libavfilter/vf_colorspace.c | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [FFmpeg-devel] [PATCH] avcodec: add QOI decoder and demuxer and parser

2022-05-31 Thread Tomas Härdin
tis 2022-05-31 klockan 13:32 +0200 skrev Paul B Mahol: > > diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h > index 03234b7543..a716dc87c3 100644 > --- a/libavcodec/codec_id.h > +++ b/libavcodec/codec_id.h > @@ -311,6 +311,7 @@ enum AVCodecID { > AV_CODEC_ID_VBN, > AV_CODEC_ID_

Re: [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace.

2022-05-31 Thread Mohammad Izadi
FYI On Thu, May 19, 2022 at 1:42 PM Mohammad Izadi wrote: > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support > YCGCO as input. Added YCOCG to the inputs. > --- > libavfilter/vf_colorspace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/vf_colors

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Wang Bin
Nicolas George 于2022年5月31日周二 22:40写道: > Александр (12022-05-31): > > I analyzed problem a little bit. Only gcc/clang allows to use this trick. > > Msvc compiler forbidens such code (even with different enabled > > optimizations like remove unused references, whole program optimization > > etc) I

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hevcdec: make set_side_data() accessible

2022-05-31 Thread Soft Works
> -Original Message- > From: Xiang, Haihao > Sent: Tuesday, May 31, 2022 11:38 AM > To: ffmpeg-devel@ffmpeg.org > Cc: softwo...@hotmail.com > Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hevcdec: make > set_side_data() accessible > > On Thu, 2022-05-26 at 08:08 +, softworkz wrot

Re: [FFmpeg-devel] [PATCH v3 6/6] avfilter/showinfo: refactor to use avutil/uuid

2022-05-31 Thread Pierre-Anthony Lemieux
On Tue, May 31, 2022 at 12:10 AM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > --- > > libavfilter/vf_showinfo.c | 17 + > > 1 file changed, 5 insertions(+), 12 deletions(-) > > > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/v

Re: [FFmpeg-devel] [PATCH v3 1/6] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-31 Thread Pierre-Anthony Lemieux
On Tue, May 31, 2022 at 3:40 AM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Zane van Iperen > > > > Addresses review comments including: > > > > * simplifying av_uuid_parse_range() > > * removing avcodec/cbs_sei from this refactoring exercise > > > > Co-authored-by: Pierre-Anthony

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Александр
I duplicated question at another channel (users). I wrote here because I get answers on my question here. On another channel I am ready to provide any detailed information. вт, 31 мая 2022 г. в 17:40, Nicolas George : > Александр (12022-05-31): > > I analyzed problem a little bit. Only gcc/clang

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Nicolas George
Александр (12022-05-31): > I analyzed problem a little bit. Only gcc/clang allows to use this trick. > Msvc compiler forbidens such code (even with different enabled > optimizations like remove unused references, whole program optimization > etc) I have made patch, which uses preprocessor #if direc

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Александр
I analyzed problem a little bit. Only gcc/clang allows to use this trick. Msvc compiler forbidens such code (even with different enabled optimizations like remove unused references, whole program optimization etc) I have made patch, which uses preprocessor #if directive instead. If it will be helpf

Re: [FFmpeg-devel] [PATCH v7 1/1] avutil/csp: create public API for colorspace structs

2022-05-31 Thread Ronald S. Bultje
Hi, On Sat, May 28, 2022 at 9:30 AM Leo Izen wrote: > This commit moves some of the functionality from avfilter/colorspace > into avutil/csp and exposes it as a public API so it can be used by > libavcodec and/or libavformat. It also converts those structs from > double values to AVRational to m

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Andreas Rheinhardt
Timo Rothenpieler: > On 31.05.2022 12:03, Александр wrote: >> I tried to build ffmpeg 4.4 library and link with it and I received >> multiple unresolved references. I came across on unusual architecture in >> ffmpeg for multiple platforms.The library has many places with code like >> this: >> >> vo

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Timo Rothenpieler
On 31.05.2022 12:03, Александр wrote: I tried to build ffmpeg 4.4 library and link with it and I received multiple unresolved references. I came across on unusual architecture in ffmpeg for multiple platforms.The library has many places with code like this: void foo() { // DO SOMETHING

[FFmpeg-devel] [PATCH] vp9: don't overread by 4 pixels in ff_vp9_avg4_mmxext().

2022-05-31 Thread Ronald S. Bultje
If the block is at the end of the allocated buffer and there is no padding, this will over-read, which may cause crashes. Reported by Firefox. --- libavcodec/x86/vp9mc.asm | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/x86/vp9mc.asm b/libavcodec/x86/vp9mc.asm index f64161b2c2.

[FFmpeg-devel] [PATCH] vp9: don't overread by 4 pixels in ff_vp9_avg4_mmxext().

2022-05-31 Thread Ronald S. Bultje
If the block is at the end of the allocated buffer and there is no padding, this will over-read, which may cause crashes. Reported by Firefox. --- libavcodec/x86/vp9mc.asm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/vp9mc.asm b/libavcodec/x86/vp9mc.asm in

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: ipred_hd_16x16_16 avx2 implementation

2022-05-31 Thread Ronald S. Bultje
Hi, On Thu, May 26, 2022 at 12:43 AM FacelessLake wrote: > From: Semen Belozerov > > --- > libavcodec/x86/vp9dsp_init_16bpp.c| 2 + > libavcodec/x86/vp9intrapred_16bpp.asm | 54 +++ > 2 files changed, 56 insertions(+) > Apologies for forgetting about this, this is

[FFmpeg-devel] [PATCH] avcodec: add QOI decoder and demuxer and parser

2022-05-31 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h| 1 + libavcodec/parsers.c | 1 + libavcodec/qoi_parser.c | 77 ++ libavcodec/qoidec.c | 139

Re: [FFmpeg-devel] [PATCH v3 1/6] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-31 Thread Andreas Rheinhardt
p...@sandflow.com: > From: Zane van Iperen > > Addresses review comments including: > > * simplifying av_uuid_parse_range() > * removing avcodec/cbs_sei from this refactoring exercise > > Co-authored-by: Pierre-Anthony Lemieux > Signed-off-by: Zane van Iperen > --- > libavutil/Makefile | 2

[FFmpeg-devel] (ping) Re: [PATCH] avcodec/vp9: ipred_hd_16x16_16 avx2 implementation

2022-05-31 Thread Sam Blackriver
Чт, 26 мая 2022 г. в 11:43 AM, FacelessLake : > From: Semen Belozerov > > --- > libavcodec/x86/vp9dsp_init_16bpp.c| 2 + > libavcodec/x86/vp9intrapred_16bpp.asm | 54 +++ > 2 files changed, 56 insertions(+) > > diff --git a/libavcodec/x86/vp9dsp_init_16bpp.c > b/liba

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Nicolas George
Александр (12022-05-31): > This code leads to linker errors because there is no any stub methods for > other platforms. I observed root MakeFile, it optionally includes platform > dependent code for each library (path like $(LIB_SUBDIR)/$(ARCH)/MakeFile) > where each foo_ is defined. > > So, how d

[FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Александр
I tried to build ffmpeg 4.4 library and link with it and I received multiple unresolved references. I came across on unusual architecture in ffmpeg for multiple platforms.The library has many places with code like this: void foo() { // DO SOMETHING if (ARCH_MIPS) // maybe #if ARCH_MIPS (..

[FFmpeg-devel] [PATCH 8/8] libavcodec/jpeg2000: Call av_codec_is_encoder() only once in init_prec()

2022-05-31 Thread Tomas Härdin
From 1485b06278f38dcda5ff83f17e0a3446949809b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Mon, 23 May 2022 11:20:57 +0200 Subject: [PATCH 8/8] libavcodec/jpeg2000: Call av_codec_is_encoder() only once in init_prec() --- libavcodec/jpeg2000.c | 7 +-- 1 file changed

[FFmpeg-devel] [PATCH 7/8] libavcodec/jpeg2000_parser: Localize m->bytes_read

2022-05-31 Thread Tomas Härdin
From 7b5e442033f0691bddbe2c2a0292f4abffd46c3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 20 May 2022 14:50:00 +0200 Subject: [PATCH 7/8] libavcodec/jpeg2000_parser: Localize m->bytes_read Another 6% --- libavcodec/jpeg2000_parser.c | 8 +--- 1 file changed, 5

[FFmpeg-devel] [PATCH 6/8] libavcodec/jpeg2000_parser: Reindent

2022-05-31 Thread Tomas Härdin
From 96fc66ca55a306575faf6d3b17ea58aae4c6c046 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 31 May 2022 11:37:55 +0200 Subject: [PATCH 6/8] libavcodec/jpeg2000_parser: Reindent --- libavcodec/jpeg2000_parser.c | 26 +- 1 file changed, 13 inser

[FFmpeg-devel] [PATCH 5/8] libavcodec/jpeg2000_parser: Rearrange ifs

2022-05-31 Thread Tomas Härdin
From 68add7a3abb85d84e484ae58b1661d7bbf66c04d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 20 May 2022 14:44:54 +0200 Subject: [PATCH 5/8] libavcodec/jpeg2000_parser: Rearrange ifs A modest 8% improvement --- libavcodec/jpeg2000_parser.c | 6 -- 1 file changed,

[FFmpeg-devel] [PATCH 4/8] libavcodec/jpeg2000_parser: LUTify info_marker()

2022-05-31 Thread Tomas Härdin
From d84f106d1eac7a3ea98935d11dc65e0afe8a8fb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 20 May 2022 14:41:38 +0200 Subject: [PATCH 4/8] libavcodec/jpeg2000_parser: LUTify info_marker() This speeds find_frame_end() up by 39% according to valgrind --- libavcodec/jp

[FFmpeg-devel] [PATCH 3/8] libavcodec/jpeg2000_parser: next_state is just a temporary

2022-05-31 Thread Tomas Härdin
From 682701613a9b816aac9e75848216e3c7e6a12974 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 20 May 2022 11:45:23 +0200 Subject: [PATCH 3/8] libavcodec/jpeg2000_parser: next_state is just a temporary --- libavcodec/jpeg2000_parser.c | 3 +-- 1 file changed, 1 inserti

[FFmpeg-devel] [PATCH 2/8] libavcodec/jpeg2000_parser: Simplify, fix reset_context()

2022-05-31 Thread Tomas Härdin
From 4bf4593c0d4cbc36d8fcaabe9e36b39134403c34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 20 May 2022 11:44:06 +0200 Subject: [PATCH 2/8] libavcodec/jpeg2000_parser: Simplify, fix reset_context() --- libavcodec/jpeg2000_parser.c | 23 ++- 1 file

[FFmpeg-devel] [PATCH 1/8] libavcodec/jpeg2000_parser: Speed up long skips

2022-05-31 Thread Tomas Härdin
From fedd7f9ae2c691a25c37be935d7547be61d46017 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 20 May 2022 11:38:25 +0200 Subject: [PATCH 1/8] libavcodec/jpeg2000_parser: Speed up long skips --- libavcodec/jpeg2000_parser.c | 11 +++ 1 file changed, 11 insertion

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hevcdec: make set_side_data() accessible

2022-05-31 Thread Xiang, Haihao
On Thu, 2022-05-26 at 08:08 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > libavcodec/hevcdec.c | 117 +-- > libavcodec/hevcdec.h | 2 + > 2 files changed, 60 insertions(+), 59 deletions(-) > > diff --git a/libavcodec/he

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hevcdec: make set_side_data() accessible

2022-05-31 Thread Xiang, Haihao
On Thu, 2022-05-26 at 08:08 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > libavcodec/hevcdec.c | 117 +-- > libavcodec/hevcdec.h | 2 + > 2 files changed, 60 insertions(+), 59 deletions(-) > > diff --git a/libavcodec/he

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/mpeg12dec: make mpeg_decode_user_data() accessible

2022-05-31 Thread Xiang, Haihao
On Thu, 2022-05-26 at 08:08 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > libavcodec/mpeg12.h| 28 > libavcodec/mpeg12dec.c | 40 +--- > 2 files changed, 33 insertions(+), 35 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/vpp_qsv: Copy side data from input to output frame

2022-05-31 Thread Xiang, Haihao
On Thu, 2022-05-26 at 08:08 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > libavfilter/qsvvpp.c | 6 ++ > libavfilter/vf_overlay_qsv.c | 19 +++ > 2 files changed, 21 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/qsvvpp.

[FFmpeg-devel] lavc/libopenjpegdec: Enable slice threading

2022-05-31 Thread Tomas Härdin
From 230f9e23072d971f184b90a8f108517fc866461f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 31 May 2022 10:54:08 +0200 Subject: [PATCH] lavc/libopenjpegdec: Enable slice threading --- libavcodec/libopenjpegdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0

2022-05-31 Thread Xiang, Haihao
On Sun, 2022-05-01 at 05:13 +, Soft Works wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Xiang, Haihao > > Sent: Sunday, May 1, 2022 6:52 AM > > To: an...@khirnov.net; ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio relat

Re: [FFmpeg-devel] [PATCH v08 09/10] qsv: use a new method to create mfx session when using oneVPL

2022-05-31 Thread Xiang, Haihao
On Sun, 2022-05-01 at 04:03 +, Xiang, Haihao wrote: > On Sat, 2022-04-30 at 17:14 +0100, Mark Thompson wrote: > > On 28/04/2022 10:23, Haihao Xiang wrote: > > > In oneVPL, MFXLoad() and MFXCreateSession() are required to create a > > > workable mfx session[1] > > > > > > Add config filters for

Re: [FFmpeg-devel] [PATCH v3 6/6] avfilter/showinfo: refactor to use avutil/uuid

2022-05-31 Thread Andreas Rheinhardt
p...@sandflow.com: > From: Pierre-Anthony Lemieux > > --- > libavfilter/vf_showinfo.c | 17 + > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > index 12d39310ef..0d6f2805bb 100644 > --- a/libavfilter/vf_sh