LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
James Almer:
> This is unfortunately needed to remove (or reduce the awfulness) of certain
> modules violating the AVFrame API and using sizeof(AVFrame).
> With this, the sizeof(AVFrame) value of the libavutil loaded at runtime can be
> used instead of the compile time value of whatever library inc
Signed-off-by: Andreas Rheinhardt
---
libavcodec/alsdec.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
index f8609e61fd..c09401d257 100644
--- a/libavcodec/alsdec.c
+++ b/libavcodec/alsdec.c
@@ -2094,12 +2094,6 @@ static
Signed-off-by: Andreas Rheinhardt
---
libavcodec/alsdec.c | 30 ++
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
index 9e1aaf065a..f8609e61fd 100644
--- a/libavcodec/alsdec.c
+++ b/libavcodec/alsdec.c
@@ -1990
Signed-off-by: Andreas Rheinhardt
---
libavcodec/msmpeg4dec.c | 114
1 file changed, 57 insertions(+), 57 deletions(-)
diff --git a/libavcodec/msmpeg4dec.c b/libavcodec/msmpeg4dec.c
index ba72c7ee50..ac7c7d75e2 100644
--- a/libavcodec/msmpeg4dec.c
+++ b/l
This automatically makes the remaining mpegvideo-decoders
(namely msmpeg4v[1-3], mss2, VC-1, VC-1 Image, WMV-[1-3]
and WMV-3 Image) init-threadsafe.
These were the last native codecs that were not init-threadsafe;
only wrappers for external libraries and for hardware accelerations
are now not init-
Signed-off-by: Andreas Rheinhardt
---
libavcodec/avcodec.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
index 4df834c708..92639dda6b 100644
--- a/libavcodec/avcodec.c
+++ b/libavcodec/avcodec.c
@@ -169,8 +169,6 @@ int a
It does not modify any static data in its init function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vorbisdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
index 6e07bc5a8a..be4ac055e0 100644
--- a/libavcodec/vorbisdec
This decoder does not initialize any static data in its init function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/exr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/exr.c b/libavcodec/exr.c
index 8b04fab951..fc32ef1dde 100644
--- a/libavcodec/exr.c
+++ b/libavcodec/exr.c
Signed-off-by: Andreas Rheinhardt
---
libavcodec/ituh263dec.c | 42 -
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c
index 6fa5249569..c141888003 100644
--- a/libavcodec/ituh263dec.c
+++ b/l
This automatically makes the FLV, H.263, H.263+, Intel H.263,
MPEG-4, RealVideo 1.0 and RealVideo 2.0 decoders init-threadsafe.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/flvdec.c| 3 ++-
libavcodec/h263dec.c | 6 --
libavcodec/intelh263dec.c | 3 ++-
libavcodec/ituh2
It does not initialize any static data in its init function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/alsdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
index 029c37e99c..b9629fc3d2 100644
--- a/libavcodec/alsdec.c
+++ b
Signed-off-by: Andreas Rheinhardt
---
libavcodec/alsdec.c | 4 +++-
libavcodec/mlz.c| 7 ++-
libavcodec/mlz.h| 2 +-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
index c09401d257..029c37e99c 100644
--- a/libavcodec/alsdec.c
Signed-off-by: Andreas Rheinhardt
---
libavcodec/apedec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index 607304fe36..923f79046b 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -1666,7 +1666,7 @@ const AVCodec ff_ap
Signed-off-by: Andreas Rheinhardt
---
libavcodec/rv40.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/libavcodec/rv40.c b/libavcodec/rv40.c
index 31a7a04e51..8f7589242d 100644
--- a/libavcodec/rv40.c
+++ b/libavcodec/rv40.c
@@ -27,6 +27,7 @@
#include "config.h"
#
Init-threadsafe since f697622f687c22392194d6939914c9a6a01ce69e.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/rv30.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/rv30.c b/libavcodec/rv30.c
index 751647bebe..bd4d43aeeb 100644
--- a/libavcodec/rv30.c
+++ b/li
It performs no initialization of static data in its init function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/amrwbdec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/amrwbdec.c b/libavcodec/amrwbdec.c
index 3ff4077f7f..7d1b820bbb 100644
--- a/libavcodec/amrwbdec.c
+++ b/l
It performs no initialization of static data during its init function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/amrnbdec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/amrnbdec.c b/libavcodec/amrnbdec.c
index d8e0370a3b..1e11445cd3 100644
--- a/libavcodec/amrnbdec.c
+++
The only interesting thing done in SVQ3's init function
is using zlib, but this is fine: https://zlib.net/zlib_faq.html#faq21
Signed-off-by: Andreas Rheinhardt
---
libavcodec/svq3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c
index be
James Almer:
> This is unfortunately needed to remove (or reduce the awfulness) of certain
> modules violating the AVFrame API and using sizeof(AVFrame).
> With this, the sizeof(AVFrame) value of the libavutil loaded at runtime can be
> used instead of the compile time value of whatever library inc
On Fri, Feb 11, 2022 at 10:05:19PM +0100, Marton Balint wrote:
>
>
> On Sat, 5 Feb 2022, lance.lmw...@gmail.com wrote:
>
> > From: Limin Wang
> >
> > Suggested by zhilizhao, vlc project has solved the compatibility by
> > the same way, so I borrowed the comments from vlc project.
> >
> > Fix
Use instead the new internal avpriv_avframe_size constant. This will
ensure the actual size of AVFrame from the libavutil loaded at runtime
is used instead.
Also add the missing padding bytes required by the AVPacket API while
at it.
Signed-off-by: James Almer
---
libavformat/vapoursynth.c | 12
Use instead the new internal avpriv_avframe_size constant. This will
ensure the actual size of AVFrame from the libavutil loaded at runtime
is used instead.
Signed-off-by: James Almer
---
libavcodec/wrapped_avframe.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/
Signed-off-by: James Almer
---
libavcodec/wrapped_avframe.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/libavcodec/wrapped_avframe.c b/libavcodec/wrapped_avframe.c
index a7834b86e8..004bd5e0e7 100644
--- a/libavcodec/wrapped_avframe.c
+++ b/libavcodec/
This is unfortunately needed to remove (or reduce the awfulness) of certain
modules violating the AVFrame API and using sizeof(AVFrame).
With this, the sizeof(AVFrame) value of the libavutil loaded at runtime can be
used instead of the compile time value of whatever library included frame.h
Signed
This patch should allow to play an image sequence in backwards
direction, without needing to apply a reverse filter.
ffmpeg -i sequence%05d.png forward.mkv
ffmpeg -reverse 1 -i sequence%05d.png backward.mkv
Signed-off-by: Sergio Acereda
---
libavformat/img2.h| 1 +
libavformat/img2dec.c
On Sat, 5 Feb 2022, lance.lmw...@gmail.com wrote:
From: Limin Wang
Suggested by zhilizhao, vlc project has solved the compatibility by
the same way, so I borrowed the comments from vlc project.
Fix #ticket9449
Signed-off-by: Limin Wang
---
libavformat/udp.c | 15 +--
1 file ch
will apply soon
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> I think Apple Mail wraps the lines in the mail or somehow else alters it
> breaking
> the patch.
>
> I would recommend to use git send-email or try it with a different mail
> client
> like MailMate maybe.
I see... I'll try with git send-email then, not sure if it will open a new
thread or
On Feb 9, 2022, 7:31 AM +0800, Jan Ekström , wrote:
> On Tue, Feb 8, 2022 at 9:48 AM Wang Chuan wrote:
> >
> > Any news?
> >
>
> Sorry, was not able to get to this according to the time line I
> expected. Will see if I can find some time for this soon.
>
> The attempt I had done in October was qui
On Fri, Feb 11, 2022 at 09:50:58AM +0100, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/vp6.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
nice
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Why no
On 11 Feb 2022, at 17:45, Sergio Acereda wrote:
Not sure what I'm doing wrong here. This is what I'm doing:
$ git pull
$ git co master
...apply changes...
$ git add libavformat/img2.h
$ git add libavformat/img2dec.c
$ git commit -s -m"[PATCH] avformat/img2dec: Option to play sequence
backwar
Not sure what I'm doing wrong here. This is what I'm doing:
$ git pull
$ git co master
...apply changes...
$ git add libavformat/img2.h
$ git add libavformat/img2dec.c
$ git commit -s -m"[PATCH] avformat/img2dec: Option to play sequence backwards"
$ git format-patch -s -o "outputfolder" --add-head
This patch should allow to play a image sequence in backwards direction,
without needing to apply a reverse filter.
$ ffmpeg -i sequence%05.png forward.mkv
$ ffmpeg -reverse 1 sequence%05.png backward.mkv
Signed-off-by: Sergio Acereda
---
libavformat/img2.h| 1 +
libavformat/img2dec.c | 32
ffmpeg use 50-70% cpu only
How change thread or add virtual vcpu?
If I run 2 instances of ffmpeg I get 100% cpu and real processing
speedup, but I need to speed up single-instances calculation
base command :
ffmpeg -y -i $file -vcodec libx264 -acodec copy $file.mp4
_
The exif.h header doesn't use anything from tiff.h. We also just need
to include tiff_common.h in .c files where it actually used.
Signed-off-by: Andreas Schneider
---
libavcodec/exif.c | 1 +
libavcodec/exif.h | 1 -
libavcodec/mjpegdec.c | 1 +
libavcodec/webp.c | 1 +
4 files chan
bytestream.h should be directly included for GetByteContext and not
rely on other headers to include it. It could be removed from there.
Signed-off-by: Andreas Schneider
---
libavcodec/exif.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/exif.h b/libavcodec/exif.h
index 4db84a1c
Just some small header cleanup.
Andreas Schneider (2):
avcodec/exif: Include bytestream.h for GetByteContext
avcodec/exif: Include tiff_common.h only where needed
libavcodec/exif.c | 1 +
libavcodec/exif.h | 2 +-
libavcodec/mjpegdec.c | 1 +
libavcodec/webp.c | 1 +
4 files chan
Steven Liu:
> Fixes: null pointer dereference
>
> Reported-by: TOTE Robot
> Signed-off-by: Steven Liu
> ---
> libavcodec/vp6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c
> index d024370793..7ddabbff80 100644
> --- a/libavcodec/vp6.c
> +++ b/l
Fixes: null pointer dereference
Reported-by: TOTE Robot
Signed-off-by: Steven Liu
---
libavcodec/vp6.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c
index d024370793..7ddabbff80 100644
--- a/libavcodec/vp6.c
+++ b/libavcodec/vp6.c
@@ -653,6 +653,8 @@
On Wed, Feb 9, 2022 at 9:49 AM Paul B Mahol wrote:
> On Wed, Feb 9, 2022 at 1:56 AM Vittorio Giovara <
> vittorio.giov...@gmail.com>
> wrote:
>
> > On Thu, Feb 3, 2022 at 3:12 PM Derek Buitenhuis <
> > derek.buitenh...@gmail.com>
> > wrote:
> >
> > > On 2/3/2022 1:26 AM, Aman Karmani wrote:
> > >
If a frame-threaded decoder with inter-frame dependencies
returns an error when decoding a frame and the returned frame
isn't clean, an error message is emitted claiming that this
is a bug. This seems to be based upon the thinking that
in this case a ThreadFrame has not been properly unreferenced.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc1.c | 213 +++
1 file changed, 106 insertions(+), 107 deletions(-)
diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c
index 40e2b4d692..fa028a5784 100644
--- a/libavcodec/vc1.c
+++ b/libavcodec/vc1.c
@@
The only unorthodox thing that this codec's init function does
is calling ff_get_format(). Yet this is supposed to be save,
as any get_format callback already has to deal with the scenario
of different AVCodecContext's calling it simultaneously.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/8
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/4xm.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c
> index cb315cd7e4..cb361772d2 100644
> --- a/libavcodec/4xm.c
> +++ b/libavcodec/4xm.c
> @@ -1008,1
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/proresenc_kostya.c | 14 --
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c
> index 85651fce2a..08a874dd4e 100644
> --- a/libav
Andreas Rheinhardt:
> L[i] can be in the range of 0-255, see table B.5 of ITU T.81.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/cbs_jpeg.h | 2 +-
> libavcodec/cbs_jpeg_syntax_template.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/l
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/cavs.c| 4 +---
> libavcodec/cavsdec.c | 1 +
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/cavs.c b/libavcodec/cavs.c
> index e29d9c659b..5367c44248 100644
> --- a/libavcodec/cavs.c
>
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/tta.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/tta.c b/libavcodec/tta.c
> index 17b4ca9032..accac38893 100644
> --- a/libavcodec/tta.c
> +++ b/libavcodec/tta.c
> @@ -114,10
Andreas Rheinhardt:
> It is sane, but UB. It could happen in case of allocation errors
> in vc2_encode_init().
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/vc2enc_dwt.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/vc2enc_dwt.c b/libavcode
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/ralf.c | 26 +++---
> 1 file changed, 7 insertions(+), 19 deletions(-)
>
> diff --git a/libavcodec/ralf.c b/libavcodec/ralf.c
> index bb80119b0c..0c51f49939 100644
> --- a/libavcodec/ralf.c
> +++ b/lib
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/metasound.c | 2 +-
> libavcodec/twinvq.c| 5 +
> libavcodec/twinvq.h| 1 +
> libavcodec/twinvqdec.c | 2 +-
> 4 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/metasound.c b/libavco
Andreas Rheinhardt:
> Adapt it to the actual (sane) behaviour.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavutil/tx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/tx.h b/libavutil/tx.h
> index 087355f10d..3de2f7231b 100644
> --- a/libavutil/tx.h
> +++
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/g2meet.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c
> index 4c53838af5..8628016ef4 100644
> --- a/libavcodec/g2meet.c
> +++ b/libavcodec/g2meet.c
>
On Mon, 7 Feb 2022, Martin Storsjö wrote:
Signed-off-by: Martin Storsjö
---
This should reduce the risk of anyone accidentally writing new code
based on an incorrect example.
---
libavcodec/aarch64/h264dsp_neon.S | 176 +++---
1 file changed, 88 insertions(+), 88 deletion
Nothing with static storage duration is initialized by these codecs.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vp5.c | 2 +-
libavcodec/vp6.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/vp5.c b/libavcodec/vp5.c
index dc24f5b096..6146fbbc3a 100644
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vp5.c | 10 --
libavcodec/vp56.c | 12
libavcodec/vp56.h | 2 --
3 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/libavcodec/vp5.c b/libavcodec/vp5.c
index a3c3da7ba6..dc24f5b096 100644
--- a/libavcodec/vp5.c
+
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vp6.c | 51 +---
1 file changed, 27 insertions(+), 24 deletions(-)
diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c
index 3acca16f3c..ae8e223349 100644
--- a/libavcodec/vp6.c
+++ b/libavcodec/vp6.c
@@ -6
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vp6.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c
index 6bcbbce47b..3acca16f3c 100644
--- a/libavcodec/vp6.c
+++ b/libavcodec/vp6.c
@@ -652,10 +652,8 @@ static av_cold int vp6_d
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vp5.c | 1 +
libavcodec/vp56.c | 4 +---
libavcodec/vp56.h | 4
libavcodec/vp6.c | 2 ++
4 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavcodec/vp5.c b/libavcodec/vp5.c
index f68c62527b..a3c3da7ba6 100644
--- a/libavcodec/
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vp6.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c
index d75e717082..95ed5eba0f 100644
--- a/libavcodec/vp6.c
+++ b/libavcodec/vp6.c
@@ -654,11 +654,12 @@ static av_cold int vp6_dec
63 matches
Mail list logo