Re: [FFmpeg-devel] [PATCH 10/10] avcodec/avcodec: Remove outdated comment

Marvin Scholz: > > > On 5 Jan 2022, at 22:56, Andreas Rheinhardt wrote: > >> avcodec_open2() is supposed to be thread-safe (those codecs >> whose init functions are not thread-safe are guarded >> by a global lock). >> > > Maybe it would be better to note since which version this is > the case,

[FFmpeg-devel] [PATCH V2] doc/encoders.texi: Add doc for qsv

Add doc for qsv decoder. Add more option's introduction to qsv encoder. Signed-off-by: Wenbin Chen --- doc/decoders.texi | 42 doc/encoders.texi | 253 +- 2 files changed, 292 insertions(+), 3 deletions(-) diff --git a/doc/decoders.texi b/do

Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: Add missing entry for ADPCM_IMA_AMV_ENCODER

On 6/1/22 04:44, Andreas Rheinhardt wrote: Forgotten in 555f5c1fc5ae0c4e7b0431dc3166c3fcf3f4e979. ...how did I miss this? LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH 10/10] avcodec/avcodec: Remove outdated comment

On 5 Jan 2022, at 22:56, Andreas Rheinhardt wrote: avcodec_open2() is supposed to be thread-safe (those codecs whose init functions are not thread-safe are guarded by a global lock). Maybe it would be better to note since which version this is the case, or at least mention it in the api ch

[FFmpeg-devel] [PATCH 06/10] avcodec/mpeg4videodec: Fix data race when initializing VLCs

Both the MPEG-4 parser as well as the decoder initialized several VLCs. There is a "static int done = 0;" in order to guard against initializing these multiple times, but this does not work when several threads try to initialize these VLCs concurrently, which can happen when initializing several pa

[FFmpeg-devel] [PATCH 10/10] avcodec/avcodec: Remove outdated comment

avcodec_open2() is supposed to be thread-safe (those codecs whose init functions are not thread-safe are guarded by a global lock). Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 7e

[FFmpeg-devel] [PATCH 09/10] avcodec: Remove unnecessary h263.h inclusions

Signed-off-by: Andreas Rheinhardt --- libavcodec/flvenc.c | 1 - libavcodec/h261dec.c | 1 - libavcodec/h261enc.c | 1 - libavcodec/msmpeg4.c | 1 - libavcodec/msmpeg4data.c | 2 +- libavcodec/snow.c| 1 - libavcodec/snowdec.c | 2 -- libavcodec/svq1dec.c | 2 +-

[FFmpeg-devel] [PATCH 08/10] avcodec/bitstream: Don't pretend VLCs to be initialized concurrently

Since the MPEG-4 parser no longer initializes some MPEG-4 VLCs, no VLC is initialized concurrently by multiple threads (initializing static VLCs is guarded by locks and nonstatic VLCs never posed an issue in this regard). So remove the code in bitstream.c that only exists because of this possibilit

[FFmpeg-devel] [PATCH 07/10] avcodec/rl: Don't pretend ff_rl_init() initializes a RLTable twice

It can't any longer, because all users of ff_rl_init() are now behind ff_thread_once() or the global codec lock. Therefore the check for whether the RLTable is already initialized can be removed; as can the stack buffers that existed to make sure that nothing is ever set to a value different from i

[FFmpeg-devel] [PATCH 05/10] avcodec/mpeg4video: Skip unneeded element when parsing picture header

Namely, skip some elements that are only useful for a decoder when calling ff_mpeg4_decode_picture_header() from the MPEG-4 parser. In particular, this ensures that the VLCs need no longer be initialized by the parser. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263dec.c | 4 ++

[FFmpeg-devel] [PATCH 04/10] avcodec/h263: Move functions only used once to their caller

In this case it means moving ff_h263_pred_dc() resp. ff_h263_pred_acdc() to ituh263enc.c resp. ituh263dec.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263.c | 128 libavcodec/h263.h | 2 - libavcodec/ituh263dec.c | 89 ++

[FFmpeg-devel] [PATCH 03/10] avcodec/mpegvideo: Avoid macro/av_calloc for ordinary allocations

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index af433153f2..e9f2fb212a 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -632,9 +632,

[FFmpeg-devel] [PATCH 02/10] avcodec/mpegvideo: Don't unnecessarily allocate buffers

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 1c2b28f450..af433153f2 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -371,17 +371

[FFmpeg-devel] [PATCH 01/10] avcodec/mpeg12dec: Don't set write-only variable

MpegEncContext.picture_number is write-only for MPEG-1/2 decoding. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 35dfc74fe7..6ad9fb245c 100644 --- a/libavcodec/mpeg12dec

[FFmpeg-devel] [PATCH 3/3] avcodec/jpeglsdec: Avoid get_bits_long() where possible

It is possible here, because the values of ff_log2_run used here are actually in the range 0..15 given that run_index is in the range 0..31. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeglsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/jpeglsdec.c b/l

[FFmpeg-devel] [PATCH 2/3] avcodec/mlpdec: Use get_bits() instead of get_bits_long() when possible

huff_lsbs is guaranteed to be in the range of 0..24 and so is lsb_bits here, so one can use get_bits(). Signed-off-by: Andreas Rheinhardt --- libavcodec/mlpdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c index 29fac54542..61b9a6

[FFmpeg-devel] [PATCH 1/3] avformat/takdec: Don't initialize get_bits context to read one value

Signed-off-by: Andreas Rheinhardt --- libavcodec/tak.h | 1 - libavformat/takdec.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/tak.h b/libavcodec/tak.h index dc45a8c070..6069118971 100644 --- a/libavcodec/tak.h +++ b/libavcodec/tak.h @@ -44,7 +44,6 @@ #d

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Factor writing golomb codes out

Andreas Rheinhardt: > Most users only want to either read or write golomb codes, not both. > By splitting these headers one avoids having unnecesssary > (get|put)_hits.h inclusions. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ffv1enc.c | 2 +- > libavcodec/flacenc.c |

[FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: Avoid redundant entry_point_offsets array

Instead modify the offsets in place. Signed-off-by: Andreas Rheinhardt --- libavcodec/hevcdec.c | 19 +-- libavcodec/hevcdec.h | 1 - 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index fc0dc7a584..6aa14455d0 100644 -

[FFmpeg-devel] [PATCH 3/4] avcodec/hevcdec: Combine related data into structure

Signed-off-by: Andreas Rheinhardt --- libavcodec/hevcdec.c | 28 +--- libavcodec/hevcdec.h | 8 ++-- 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 85a1b9f47a..fc0dc7a584 100644 --- a/libavcodec/hevcd

[FFmpeg-devel] [PATCH 2/4] avcodec/hevcdec: Remove redundant frees

These arrays have already been freed in pic_arrays_free(). Signed-off-by: Andreas Rheinhardt --- libavcodec/hevcdec.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 568bdb5ab7..85a1b9f47a 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 1/4] avcodec/hevcdec: Combine multiple allocations

Reduces the number of allocs and frees. Signed-off-by: Andreas Rheinhardt --- libavcodec/hevcdec.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 8d7a4f7147..568bdb5ab7 100644 --- a/libavcodec/hevcdec.c +++ b/liba

[FFmpeg-devel] [PATCH] configure: Add missing libshine->mpegaudioheader dependency

Signed-off-by: Andreas Rheinhardt --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index f113f8f4ec..1225faf15a 100755 --- a/configure +++ b/configure @@ -3355,7 +3355,7 @@ librav1e_encoder_deps="librav1e" librav1e_encoder_select="extract_ex

[FFmpeg-devel] [PATCH] avcodec/Makefile: Add missing entry for ADPCM_IMA_AMV_ENCODER

Forgotten in 555f5c1fc5ae0c4e7b0431dc3166c3fcf3f4e979. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 8c0c19ca27..cfc70a3eaf 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @

Re: [FFmpeg-devel] [PATCH v2] avcodec/Makefile: Only compile nvenc.o if needed

applied, thanks! smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wi

Re: [FFmpeg-devel] [PATCH] doc/developer: patches should not cross libs or mix MAINTAINER changes in

Michael Niedermayer: > maintainer part inspired by IRC comments by lynne > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index addee0d8263..eae3ade48a7 100644 > --- a/doc/dev

[FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

This resulted in a dimmed tonemapping due to bad resulting luma calculation. Found by: Derek Buitenhuis Signed-off-by: Vittorio Giovara --- libavfilter/vf_tonemap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c

Re: [FFmpeg-devel] [PATCH v8 1/3] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

Am 05.01.22 um 15:51 schrieb Marvin Scholz: > On 31 Dec 2021, at 18:42, Romain Beauxis wrote: > >> * Implement support for AudioConverter >> * Switch to AudioConverter's API to convert unsupported PCM >>   formats (non-interleaved, non-packed) to supported formats >> * Minimize data copy. >> >> Th

Re: [FFmpeg-devel] [PATCH v8 1/3] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

On 31 Dec 2021, at 18:42, Romain Beauxis wrote: * Implement support for AudioConverter * Switch to AudioConverter's API to convert unsupported PCM formats (non-interleaved, non-packed) to supported formats * Minimize data copy. This fixes: https://trac.ffmpeg.org/ticket/9502 API ref: https:/

Re: [FFmpeg-devel] [PATCH v8 2/3] libavdevice/avfoundation.m: Replace mutex-based concurrency handling in avfoundation.m by a thread-safe fifo queue with maximum length

On 31 Dec 2021, at 18:43, Romain Beauxis wrote: * Use a CMSimpleQueueEnqueue with maximum length to queue and process incoming audio and video frames. * Log avfoundation errors. * Use AVERROR_EXTERNAL instead of AVERROR(EIO) in avfoundation errors. Signed-off-by: Romain Beauxis — [Sorry for t

Re: [FFmpeg-devel] [PATCH v2] Adds DVD protocol

On 1/5/2022 11:04 AM, Lucien Murray-Pitts wrote: Copies the existing Bluray protocol format to add DVD protocol support using libdvdnav. Since title selection is mandatory ffprobe cant provide information for the complete disk but a single title only.  Chapter information for probe  will als

[FFmpeg-devel] [PATCH v3] Adds DVD protocol

Adds DVD protocol Copies the existing Bluray protocol format to add DVD protocol support using libdvdnav. Since title selection is mandatory ffprobe cant provide information for the complete disk but a single title only. Chapter information for probe will also be missing. To see a complete disk

Re: [FFmpeg-devel] [PATCH v2] avfilter: add a blend_vulkan filter

Lynne wrote: > 5 Jan 2022, 10:11 by jianhua.wu-at-intel@ffmpeg.org: > >> [PATCH v2 1/3] avfilter: add a blend_vulkan filter >> [PATCH v2 2/3] avfilter/vf_blend: fix un-checked potential memory allocation >> failure >> [PATCH v2 3/3] avutil/hwcontext_vulkan: fixed incorre

Re: [FFmpeg-devel] [PATCH v2] avfilter: add a blend_vulkan filter

5 Jan 2022, 10:11 by jianhua.wu-at-intel@ffmpeg.org: > [PATCH v2 1/3] avfilter: add a blend_vulkan filter > [PATCH v2 2/3] avfilter/vf_blend: fix un-checked potential memory allocation > failure > [PATCH v2 3/3] avutil/hwcontext_vulkan: fixed incorrect memory offset > > Patches attached. > T

[FFmpeg-devel] [PATCH v2] Adds DVD protocol

Copies the existing Bluray protocol format to add DVD protocol support using libdvdnav. Since title selection is mandatory ffprobe cant provide information for the complete disk but a single title only. Chapter information for probe will also be missing. To see a complete disk catalog of titles/

[FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

This resulted in a dimmed tonemapping due to bad resulting luma calculation. Found by: Derek Buitenhuis Signed-off-by: Vittorio Giovara --- libavfilter/vf_tonemap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c in

[FFmpeg-devel] [PATCH v2] avcodec/Makefile: Only compile nvenc.o if needed

This fixes compilation errors in case nvenc is enabled (e.g. autodected) with both nvenc-based encoders disabled because nvenc uses ff_alloc_a53_sei(), yet only the nvenc-based encoders require atsc_a53. (This error does not manifest itself in case of static linking (nothing pulls in nvenc.o), but

Re: [FFmpeg-devel] [PATCH] configure: Make nvenc select atsc_a53

On 05.01.2022 06:39, Andreas Rheinhardt wrote: It is the common code (that is compiled depending upon CONFIG_NVENC) that uses ff_alloc_a53_sei(), so it is natural to make nvenc itself select atsc_a53. This fixes compilation errors in case nvenc is enabled (e.g. autodected) with both nvenc-based e

Re: [FFmpeg-devel] [PATCH] windows: Remove the VS_FFI_FILEFLAGSMASK setting

On Wed, 5 Jan 2022, Hendrik Leppkes wrote: On Wed, Jan 5, 2022 at 1:21 PM Martin Storsjö wrote: According to the documentation, the VS_FFI_FILEFLAGSMASK mask consists of all the following flags set: VS_FF_DEBUG, VS_FF_PATCHED, VS_FF_PRERELEASE, VS_FF_PRIVATEBUILD, VS_FF_SPECIALBUILD. The doc

Re: [FFmpeg-devel] [PATCH] windows: Remove the VS_FFI_FILEFLAGSMASK setting

On 1/5/2022 9:29 AM, Hendrik Leppkes wrote: On Wed, Jan 5, 2022 at 1:21 PM Martin Storsjö wrote: According to the documentation, the VS_FFI_FILEFLAGSMASK mask consists of all the following flags set: VS_FF_DEBUG, VS_FF_PATCHED, VS_FF_PRERELEASE, VS_FF_PRIVATEBUILD, VS_FF_SPECIALBUILD. The d

Re: [FFmpeg-devel] [PATCH] windows: Remove the VS_FFI_FILEFLAGSMASK setting

On Wed, Jan 5, 2022 at 1:21 PM Martin Storsjö wrote: > > According to the documentation, the VS_FFI_FILEFLAGSMASK mask > consists of all the following flags set: > VS_FF_DEBUG, VS_FF_PATCHED, VS_FF_PRERELEASE, VS_FF_PRIVATEBUILD, > VS_FF_SPECIALBUILD. > > The documentation of these fields say e.g.

Re: [FFmpeg-devel] [PATCH] Adds DVD protocol

On 1/5/2022 9:02 PM, Michael Niedermayer wrote: On Tue, Jan 04, 2022 at 10:37:46PM +0900, Lucien Murray-Pitts wrote: Copies the Bluray protocol but uses libdvdnav to add simple DVD protocol error: corrupt patch at line 20 [...] Thank you - I just noticed today via the automated patchwork, th

[FFmpeg-devel] [PATCH] windows: Remove the VS_FFI_FILEFLAGSMASK setting

According to the documentation, the VS_FFI_FILEFLAGSMASK mask consists of all the following flags set: VS_FF_DEBUG, VS_FF_PATCHED, VS_FF_PRERELEASE, VS_FF_PRIVATEBUILD, VS_FF_SPECIALBUILD. The documentation of these fields say e.g. this: VS_FF_PATCHED File has been modified and is not identic

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

On Wed, 5 Jan 2022, James Almer wrote: On 1/5/2022 5:31 AM, Martin Storsjö wrote: While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02, wh

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

On 1/5/2022 5:31 AM, Martin Storsjö wrote: While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02, which later was reverted). --- libavcodec

Re: [FFmpeg-devel] [PATCH] Adds DVD protocol

On Tue, Jan 04, 2022 at 10:37:46PM +0900, Lucien Murray-Pitts wrote: > Copies the Bluray protocol but uses libdvdnav to add simple DVD protocol > support.Since title selection is mandatory, ffprobe cant provide > information for the complete disk but a single title only. Chapter > information

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: fix duration in mdhd box

> On Dec 18, 2021, at 2:48 AM, Martin Storsjö wrote: > > On Fri, 17 Dec 2021, Zhao Zhili wrote: > >> mvhd and tkhd present the post-editlist duration, while mdhd should >> have the pre-editlist duration. Regression since c2424b1f3. >> --- >> libavformat/movenc.c | 2 +- >> tests/ref/fate/moven

[FFmpeg-devel] [PATCH v2] avfilter: add a blend_vulkan filter

[PATCH v2 1/3] avfilter: add a blend_vulkan filter [PATCH v2 2/3] avfilter/vf_blend: fix un-checked potential memory allocation failure [PATCH v2 3/3] avutil/hwcontext_vulkan: fixed incorrect memory offset Patches attached. 0002-avfilter-vf_blend-fix-un-checked-potential-memory-al.patch Descri

[FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02, which later was reverted). --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +- 1 fi

[FFmpeg-devel] [PATCH 2/4] Revert "lavc/aarch64: add hevc sao edge 8x8"

This reverts commit c97ffc1a77ccaf901e642bd21ed26aaf75557745, as it breaks fate-hevc. --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 3 -- libavcodec/aarch64/hevcdsp_sao_neon.S | 51 --- 2 files changed, 54 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_init_aarch6

[FFmpeg-devel] [PATCH 3/4] Revert "lavc/aarch64: add hevc sao edge 16x16"

This reverts commit a9214a2ca31c9d54f893c5ac4004a5ff30a08d10, as it breaks fate-hevc. --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 8 +-- libavcodec/aarch64/hevcdsp_sao_neon.S | 65 --- 2 files changed, 2 insertions(+), 71 deletions(-) diff --git a/libavcodec/aarch64/h

[FFmpeg-devel] [PATCH 1/4] Revert "lavc/aarch64: add hevc sao band 8x8 tiling"

This reverts commit f63f9be37c799ddc835af358034630d31fb7db02, as it breaks fate-hevc. --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +- libavcodec/aarch64/hevcdsp_sao_neon.S | 11 --- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_in

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc/arm: dont assign hevc_qpel functions for non-multiple of 8 widths

On Wed, 5 Jan 2022, Andreas Rheinhardt wrote: J. Dekker: The assembly is written assuming that the width is a multiple of 8. However the real issue is the functions were errorneously assigned to the 2, 4, 6 & 12 widths. This behaviour never broke the decoder as samples which trigger the functi

[FFmpeg-devel] [PATCH] avcodec/Makefile: Add missing HEVC decoder->h274.o dependency

Forgotten in 3cc3f5de2afda5b8f880c0817e9d67c2dafbfe1e. Signed-off-by: Andreas Rheinhardt --- Will apply and backport this soon. libavcodec/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 242b48ff7c..995b2792e4 100644