Re: [FFmpeg-devel] [PATCH] avfilter/vf_morpho: Fix compilation with MSVC

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Wednesday, 29 September 2021 07:10 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] avfilter/vf_morpho: Fix compilation > with MSVC > > MSVC (or rather the winde

[FFmpeg-devel] [PATCH] avfilter/vf_morpho: Fix compilation with MSVC

2021-09-28 Thread Andreas Rheinhardt
MSVC (or rather the windef.h header) defines min and max as macros, breaking compilation here. Fix this by adding parentheses around min and max, so that they are no longer recognizable as function-like macros. Signed-off-by: Andreas Rheinhardt --- Untested as I don't have an MSVC setup. libavf

Re: [FFmpeg-devel] [PATCH] lavc/{av1, h264, h265}_metadata_bsf: fix description of tick_rate

2021-09-28 Thread zhilizhao(赵志立)
Ping for review. > On Aug 27, 2021, at 3:13 PM, Zhao Zhili wrote: > > Users may take the description literally which leads to inverted > results. > --- > doc/bitstream_filters.texi | 8 > libavcodec/av1_metadata_bsf.c | 2 +- > libavcodec/h264_metadata_bsf.c | 2 +- > libavcodec/h265_

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Wednesday, 29 September 2021 02:48 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing i

Re: [FFmpeg-devel] [PATCH 9/9] checkasm/hevc_pel: Fix stack buffer overreads

2021-09-28 Thread zhilizhao(赵志立)
> On Sep 28, 2021, at 10:41 PM, Andreas Rheinhardt > wrote: > > This patch increases several stack buffers in order to fix > stack-buffer-overflows (e.g. in put_hevc_qpel_uni_hv_9 in > line 814 of hevcdsp_template.c) detected with ASAN in the hevc_pel > checkasm test. > The buffers are increas

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: add x86-optimized tetrahedral interpolation

2021-09-28 Thread chen
Hello, Excuse me, how about FMADD on AVX2 platform? For example +mulps m7, m7, m14 +addps m0, m0, m7 ==> fmadd231ps m0,m7,m14 Regards, Min Chen 2021-09-29 09:18:05,mindm...@gmail.com >From: Mark Reid > >Only supports float and 16bit planer formats at the momoment. >Mainly focu

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/siren: Check available bits at frame start

2021-09-28 Thread James Almer
On 9/28/2021 7:28 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Suggested-by: James Almer Signed-

[FFmpeg-devel] [PATCH] avfilter/vf_lut3d: add x86-optimized tetrahedral interpolation

2021-09-28 Thread mindmark
From: Mark Reid Only supports float and 16bit planer formats at the momoment. Mainly focused on AVX and AVX2 optimizations, but SSE2 does seem offer some speed gains. f32 1920x1080 1 thread with prelut c impl 1389936500 UNITS in lut3d->interp,       1 runs,      0 skips 1425800240 UNITS in lut3d

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Wednesday, 29 September 2021 02:25 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > Soft Works: > > >

[FFmpeg-devel] [PATCH] avfilter/vf_floodfill: constify the AVFrame parameter in is_same() and pick_pixel() functions

2021-09-28 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_floodfill.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavfilter/vf_floodfill.c b/libavfilter/vf_floodfill.c index 21741cdb4f..5f2a4f4392 100644 --- a/libavfilter/vf_floodfill.c +++ b/libavfilt

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Wednesday, 29 September 2021 02:04 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure >> frames are writable when processing in-place

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Wednesday, 29 September 2021 02:04 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > Soft Works: > > >

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Wednesday, 29 September 2021 01:42 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure >> frames are writable when processing in-place

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Wednesday, 29 September 2021 01:42 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > Soft Works: > > >

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Tuesday, 28 September 2021 22:08 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure >> frames are writable when processing in-place >> >> On

Re: [FFmpeg-devel] [PATCH] libavcodec/nvenc.c: copy incoming hwaccel frames instead of ref count increase

2021-09-28 Thread Roman Arzumanyan
Thanks for the quick update, Timo. Honestly I just might have missed this moment with input frame registering as I was tracking CUdeviceptr's in map / unmap and memcpy calls. Strangely enough the patch has passed extensive QA validation round on different codecs and HW setups. I think your appr

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Wednesday, 29 September 2021 00:30 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > On 9/28/2021 7:00 PM, So

[FFmpeg-devel] [PATCH v2] avcodec/hevcdec: apply H.274 film grain

2021-09-28 Thread Niklas Haas
From: Niklas Haas Similar in spirit and design to 66845cffc3bbb, but slightly simpler due to the lack of interlaced frames in HEVC. See that commit for more details. For the seed value, since no specification for this appears to exist, I semi-arbitrarily decided to base it off the POC id alone,

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Wednesday, 29 September 2021 00:27 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > On 9/28/2021 4:54 PM, So

Re: [FFmpeg-devel] [PATCH] libavcodec/nvenc.c: copy incoming hwaccel frames instead of ref count increase

2021-09-28 Thread Roman Arzumanyan
This is a good point, let me check and come back later. От: Timo Rothenpieler Отправлено: 28 сентября 2021 г. 21:28 Кому: FFmpeg development discussions and patches ; Roman Arzumanyan Копия: Yogender Gupta ; Ricardo Monteiro Тема: Re: [FFmpeg-devel] [PATCH] lib

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 7:00 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, 28 September 2021 23:50 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place On

[FFmpeg-devel] [PATCH 3/3] avcodec/siren: Improve the bits left threshold in decode_envelope()

2021-09-28 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/siren.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/siren.c b/libavcodec/siren.c index 8c9628e2d8e..ee7514f93c4 100644 --- a/libavcodec/siren.c +++ b/libavcodec/siren.c @@ -447,7 +447,7 @@ static int decode_envel

[FFmpeg-devel] [PATCH 1/3] avcodec/siren: Check available bits at frame start

2021-09-28 Thread Michael Niedermayer
Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Suggested-by: Peter Ross Signed-off-by: Michael Niedermayer --- libavcodec/siren.c

[FFmpeg-devel] [PATCH 2/3] avcodec/siren: Check available bits at frame start

2021-09-28 Thread Michael Niedermayer
Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Suggested-by: James Almer Signed-off-by: Michael Niedermayer --- libavcodec/siren.

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 4:54 PM, Soft Works wrote: Signed-off-by: softworkz --- v2: Reduced to cases without AVFILTERPAD_FLAG_NEEDS_WRITABLE libavfilter/vf_cover_rect.c | 7 +-- libavfilter/vf_floodfill.c | 5 + libavfilter/vf_vflip.c | 7 ++- 3 files changed, 16 insertions(+), 3 de

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Wednesday, 29 September 2021 00:01 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing i

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, 28 September 2021 23:50 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > On 9/28/2021 6:22 PM, Soft

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 6:22 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, 28 September 2021 23:19 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place On

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, 28 September 2021 22:08 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > On 9/28/2021 4:54 PM, Soft

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, 28 September 2021 23:19 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > On 9/28/2021 6:00 PM, Soft

[FFmpeg-devel] [PATCH v6 4/4] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-28 Thread quietvoid
Also fixes incorrect parsing of dv_bl_signal_compatibility_id, with correct skipping of dependency_pid in DOVI TS descriptor. Signed-off-by: quietvoid --- libavformat/mpegts.c | 43 +++ 1 file changed, 3 insertions(+), 40 deletions(-) diff --git a/libavfo

[FFmpeg-devel] [PATCH v6 3/4] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-28 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 50 +-- 1 file changed, 9 insertions(+), 41 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH v6 2/4] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-09-28 Thread quietvoid
Adds handling of dvcC/dvvC block addition mappings. The parsing creates AVDOVIDecoderConfigurationRecord side data. The configuration block is written when muxing into Matroska, if DOVI side data is present for the track. In version 2.2 of the Dolby ISOM specification, there is also dvwC but it is

[FFmpeg-devel] [PATCH v6 1/4] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-09-28 Thread quietvoid
According to specification "Dolby Vision Stream Within the ISO Base Media File Format Version 2.2" This only adds support for the "Dolby Vision configuration box". Other configuration boxes, such as "Dolby Vision enhancement layer configuration box" are not supported. The new functions will be us

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 6:00 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, 28 September 2021 22:08 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place On

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, 28 September 2021 22:08 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > On 9/28/2021 4:54 PM, Soft

Re: [FFmpeg-devel] [PATCH v4 1/1] libavformat/asfdec: A collection of related fixes for asfdec

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Tuesday, 28 September 2021 22:18 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] libavformat/asfdec: A > collection of related fixes for

[FFmpeg-devel] [PATCH] libavcodec/nvenc.c: copy incoming hwaccel frames instead of ref count increase

2021-09-28 Thread Roman Arzumanyan
Hello, This patch makes nvenc copy incoming hwaccel frames instead of ref count increase. It fixes the bug which may happen when on-GPU transcoding is done and encoder is set to use B frames. How to reproduce the bug: ./ffmpeg \ -hwaccel cuda -hwaccel_output_format cuda \ -i input.mkv \ -

Re: [FFmpeg-devel] [PATCH v4 1/1] libavformat/asfdec: A collection of related fixes for asfdec

2021-09-28 Thread Michael Niedermayer
On Tue, Sep 28, 2021 at 08:10:02PM +, Soft Works wrote: > Fix 1: Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had > introduced a check for value_len > UINT16_MAX. > As a consequence, attached images of sizes larger than > UINT16_MAX could no longer be read. > > Fix 2: The value_len is an ui

Re: [FFmpeg-devel] [PATCH v4 10/10] configure: add --enable-libvpl option

2021-09-28 Thread James Almer
On 9/23/2021 3:28 AM, Haihao Xiang wrote: This allows user to build FFmpeg against Intel oneVPL. oneVPL 2.2 is the required minimum version when building Intel oneVPL code. It will fail to run configure script if both libmfx and libvpl are enabled. It is recommended to use oneVPL for new work,

[FFmpeg-devel] [PATCH v4 1/1] libavformat/asfdec: A collection of related fixes for asfdec

2021-09-28 Thread Soft Works
Fix 1: Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had introduced a check for value_len > UINT16_MAX. As a consequence, attached images of sizes larger than UINT16_MAX could no longer be read. Fix 2: The value_len is an uint32 not an int32 per spec. That value must not be truncated, neither by

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 4:54 PM, Soft Works wrote: Signed-off-by: softworkz --- v2: Reduced to cases without AVFILTERPAD_FLAG_NEEDS_WRITABLE Can't this flag used in these filters? libavfilter/vf_cover_rect.c | 7 +-- libavfilter/vf_floodfill.c | 5 + libavfilter/vf_vflip.c | 7 ++

Re: [FFmpeg-devel] [PATCH v2] avformat/aacdec: enable probesize-sized resyncs mid-stream

2021-09-28 Thread Jan Ekström
On Tue, Sep 28, 2021 at 10:55 PM James Almer wrote: > > On 9/27/2021 7:47 PM, Jan Ekström wrote: > > Before adts_aac_resync would always bail out after probesize amount > > of bytes had been progressed from the start of the input. > > > > Now just query the current position when entering resync, a

Re: [FFmpeg-devel] [PATCH] avfilter: add sharpen_npp video filter

2021-09-28 Thread Timo Rothenpieler
From 0df6297bd3664beb05c813c5fc62852e61616fa9 Mon Sep 17 00:00:00 2001 From: Roman Arzumanyan Date: Mon, 6 Sep 2021 14:26:27 +0300 Subject: [PATCH] sharpen_npp video filter added Same as the other patch, should be as the mail subject. --- configure| 5 +- libavfilter/Ma

[FFmpeg-devel] [PATCH v3 1/1] libavformat/asfdec: A collection of related fixes for asfdec

2021-09-28 Thread Soft Works
Fix 1: Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had introduced a check for value_len > UINT16_MAX. As a consequence, attached images of sizes larger than UINT16_MAX could no longer be read. Fix 2: The value_len is an uint32 not an int32 per spec. That value must not be truncated, neither

Re: [FFmpeg-devel] [PATCH v2] avformat/aacdec: enable probesize-sized resyncs mid-stream

2021-09-28 Thread James Almer
On 9/27/2021 7:47 PM, Jan Ekström wrote: Before adts_aac_resync would always bail out after probesize amount of bytes had been progressed from the start of the input. Now just query the current position when entering resync, and at most advance probesize amount of data from that start position.

[FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread Soft Works
Signed-off-by: softworkz --- v2: Reduced to cases without AVFILTERPAD_FLAG_NEEDS_WRITABLE libavfilter/vf_cover_rect.c | 7 +-- libavfilter/vf_floodfill.c | 5 + libavfilter/vf_vflip.c | 7 ++- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_cover_

Re: [FFmpeg-devel] [PATCH v4 09/10] qsv: use a new method to create mfx session when using oneVPL

2021-09-28 Thread James Almer
On 9/23/2021 3:28 AM, Haihao Xiang wrote: In oneVPL, MFXLoad() and MFXCreateSession() are required to create a workable mfx session[1] Add AccelerationMode config filter for D3D9/D3D11 session (galinart) The default device is changed to d3d11va for oneVPL when both d3d11va and dxva2 are enabled

Re: [FFmpeg-devel] [PATCH v4 03/10] qsv: remove mfx/ prefix from mfx headers

2021-09-28 Thread James Almer
On 9/23/2021 3:28 AM, Haihao Xiang wrote: The following Cflags has been added to libmfx.pc, so mfx/ prefix is no longer needed when including mfx headers in FFmpeg. Cflags: -I${includedir} -I${includedir}/mfx Some old versions of libmfx have the following Cflags in libmfx.pc Cflags: -I${

Re: [FFmpeg-devel] [PATCH] avfilter: add scale2ref_npp video filter

2021-09-28 Thread Timo Rothenpieler
On 13.09.2021 11:07, Roman Arzumanyan wrote: This patch adds scale2ref_npp video filter which is similar to scale2ref, but accelerated by NPP. CLI sample: ./ffmpeg \ -hwaccel cuda -hwaccel_output_format cuda \ -i ./bbb_sunflower_1080p_30fps_normal.mp4 \ -i ./920px-Wilber-huge-alpha

Re: [FFmpeg-devel] [PATCH 9/9] checkasm/hevc_pel: Fix stack buffer overreads

2021-09-28 Thread Martin Storsjö
On Tue, 28 Sep 2021, Andreas Rheinhardt wrote: This patch increases several stack buffers in order to fix stack-buffer-overflows (e.g. in put_hevc_qpel_uni_hv_9 in line 814 of hevcdsp_template.c) detected with ASAN in the hevc_pel checkasm test. The buffers are increased by the minimal amount ne

Re: [FFmpeg-devel] [PATCH v2] DXVA2: Add ARGB format

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Thursday, 26 August 2021 21:43 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] DXVA2: Add ARGB format > > > > > -Original Message- > > From

Re: [FFmpeg-devel] [PATCH] libavcodec/nvenc.c: copy incoming hwaccel frames instead of ref count increase

2021-09-28 Thread Timo Rothenpieler
On 28.09.2021 19:58, Timo Rothenpieler wrote: Hmm, so far my approach to deal with this was to inject a scale_cuda=passthrough=0 into the filter chain, which pretty much does exactly this, but only controllable by the user. But I do agree that this is a bit of a clutch and not all that user f

Re: [FFmpeg-devel] [PATCH] libavcodec/nvenc.c: copy incoming hwaccel frames instead of ref count increase

2021-09-28 Thread Timo Rothenpieler
On 28.09.2021 19:58, Timo Rothenpieler wrote: On 28.09.2021 18:22, Roman Arzumanyan wrote: Hello, This patch makes nvenc copy incoming hwaccel frames instead of ref count increase. It fixes the bug which may happen when on-GPU transcoding is done and encoder is set to use B frames. How to r

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/siren: Check available bits at frame start

2021-09-28 Thread Paul B Mahol
On Tue, Sep 28, 2021 at 8:09 PM James Almer wrote: > On 9/28/2021 3:03 PM, Michael Niedermayer wrote: > > On Tue, Sep 28, 2021 at 09:44:01PM +1000, Peter Ross wrote: > >> On Tue, Sep 28, 2021 at 12:07:49AM -0300, James Almer wrote: > >>> On 9/27/2021 7:37 PM, Michael Niedermayer wrote: > Fix

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/siren: Check available bits at frame start

2021-09-28 Thread James Almer
On 9/28/2021 3:03 PM, Michael Niedermayer wrote: On Tue, Sep 28, 2021 at 09:44:01PM +1000, Peter Ross wrote: On Tue, Sep 28, 2021 at 12:07:49AM -0300, James Almer wrote: On 9/27/2021 7:37 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/siren: Check available bits at frame start

2021-09-28 Thread Michael Niedermayer
On Tue, Sep 28, 2021 at 09:44:01PM +1000, Peter Ross wrote: > On Tue, Sep 28, 2021 at 12:07:49AM -0300, James Almer wrote: > > On 9/27/2021 7:37 PM, Michael Niedermayer wrote: > > > Fixes: Timeout > > > Fixes: > > > 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854

Re: [FFmpeg-devel] [PATCH] libavcodec/nvenc.c: copy incoming hwaccel frames instead of ref count increase

2021-09-28 Thread Timo Rothenpieler
On 28.09.2021 18:22, Roman Arzumanyan wrote: Hello, This patch makes nvenc copy incoming hwaccel frames instead of ref count increase. It fixes the bug which may happen when on-GPU transcoding is done and encoder is set to use B frames. How to reproduce the bug: ./ffmpeg \ -hwaccel cuda -h

Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to include alpha values in the quantization procedure

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Tuesday, 28 September 2021 19:35 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to > include alpha values in the quantiza

Re: [FFmpeg-devel] [PATCH] avfilter: add morpho filter

2021-09-28 Thread Paul B Mahol
will apply ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to include alpha values in the quantization procedure

2021-09-28 Thread Paul B Mahol
On Tue, Sep 28, 2021 at 7:16 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Paul B Mahol > > Sent: Tuesday, 28 September 2021 18:05 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH] avf

Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to include alpha values in the quantization procedure

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Tuesday, 28 September 2021 18:05 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to > include alpha values in the quantiza

Re: [FFmpeg-devel] [PATCH 2/3] librist: allow use of circular buffer for receiving.

2021-09-28 Thread Marton Balint
On Tue, 28 Sep 2021, Gijs Peskens wrote: libRIST internally stores packets in a fifo of 1024 packets, overwriting old packets when not read in a sufficient pace. Unfortunately this results in many fifo overflow errors when ffmpeg consumes a libRIST stream. This patch creates a receiver thread

[FFmpeg-devel] [PATCH] avfilter: add huesaturation filter

2021-09-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 56 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_huesaturation.c | 485 + 4 files changed, 543 insertions(+) create mode 100644 libavfilter/vf_

Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to include alpha values in the quantization procedure

2021-09-28 Thread Paul B Mahol
On Tue, Sep 28, 2021 at 5:43 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Paul B Mahol > > Sent: Monday, 27 September 2021 18:37 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH] avfi

Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to include alpha values in the quantization procedure

2021-09-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Monday, 27 September 2021 18:37 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to > include alpha values in the quantizat

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Gyan Doshi
On 2021-09-28 07:29 pm, Arif Driessen wrote: These should be formatted like they are in the surround filter for the option with the same name. Good catch! Looking around, I see there are other filters too with a win_func option. When I next get a moment (either later today or more likely tom

Re: [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support

2021-09-28 Thread Denis Shulyaka
Hi all, This is a kind reminder. Best regards, Denis Shulyaka вс, 11 апр. 2021 г. в 13:21, Denis Shulyaka : > Hi Carl, > > Thanks for the review. > > сб, 10 апр. 2021 г. в 18:05, Carl Eugen Hoyos : > >> Please use "&" instead of "%". >> > > Fixed > > Please remove this line. >> > > Fixed > >

Re: [FFmpeg-devel] [PATCH] Fix SPDIF detection score

2021-09-28 Thread Denis Shulyaka
Hi all, This is a kind reminder. Best regards, Denis Shulyaka ср, 16 июн. 2021 г. в 02:07, Denis Shulyaka : > Sorry for not giving the proper description! Here it is: > The spdif is based on blocks with fixed length, each block starts with a > sync word. It matters how many sync words we find d

[FFmpeg-devel] [PATCH 9/9] checkasm/hevc_pel: Fix stack buffer overreads

2021-09-28 Thread Andreas Rheinhardt
This patch increases several stack buffers in order to fix stack-buffer-overflows (e.g. in put_hevc_qpel_uni_hv_9 in line 814 of hevcdsp_template.c) detected with ASAN in the hevc_pel checkasm test. The buffers are increased by the minimal amount necessary in order not to mask potential future bugs

[FFmpeg-devel] [PATCH 8/9] avcodec/bmpenc: Remove redundant pixel format check

2021-09-28 Thread Andreas Rheinhardt
ff_encode_preinit() already checked the pixel format via AVCodec.pix_fmts. Signed-off-by: Andreas Rheinhardt --- libavcodec/bmpenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/bmpenc.c b/libavcodec/bmpenc.c index 1eebf5a4b6..672c0e4980 100644 --- a/libavcodec/bmpenc.c +++ b

[FFmpeg-devel] [PATCH 7/9] avcodec/dnxhdenc: Remove redundant pixel format check

2021-09-28 Thread Andreas Rheinhardt
ff_encode_preinit() already checked the pixel format via AVCodec.pix_fmts. Signed-off-by: Andreas Rheinhardt --- libavcodec/dnxhdenc.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index b45fb41515..ebfb85341d 100644 --- a/libavcodec/dnxhden

[FFmpeg-devel] [PATCH 6/9] avcodec/dpxenc: Remove redundant pixel format check

2021-09-28 Thread Andreas Rheinhardt
ff_encode_preinit() already checked the pixel format via AVCodec.pix_fmts. Signed-off-by: Andreas Rheinhardt --- libavcodec/dpxenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c index 09036a2125..0db6aa832d 100644 --- a/libavcodec/dpxenc.c +++ b

[FFmpeg-devel] [PATCH 5/9] avcodec/magicyuvenc: Remove redundant pixel format check

2021-09-28 Thread Andreas Rheinhardt
ff_encode_preinit() already checked the pixel format via AVCodec.pix_fmts. Signed-off-by: Andreas Rheinhardt --- libavcodec/magicyuvenc.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c index 7ab5e61ffe..ab32d4cee3 100644 --- a/libavcode

[FFmpeg-devel] [PATCH 4/9] avcodec/proresenc_anatoliy: Remove redundant pixel format check

2021-09-28 Thread Andreas Rheinhardt
ff_encode_preinit() already checked the pixel format via AVCodec.pix_fmts. Signed-off-by: Andreas Rheinhardt --- libavcodec/proresenc_anatoliy.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 21938c8f34..b7e00f2087 10

[FFmpeg-devel] [PATCH 3/9] avcodec/snowenc: Remove redundant pixel format check

2021-09-28 Thread Andreas Rheinhardt
ff_encode_preinit() already checked the pixel format via AVCodec.pix_fmts. Signed-off-by: Andreas Rheinhardt --- libavcodec/snowenc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 55ebfba50f..96b0d320bc 100644 --- a/li

[FFmpeg-devel] [PATCH 2/9] avcodec/zmbvenc: Remove redundant pixel format check

2021-09-28 Thread Andreas Rheinhardt
ff_encode_preinit() already checked the pixel format via AVCodec.pix_fmts. Signed-off-by: Andreas Rheinhardt --- libavcodec/zmbvenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/zmbvenc.c b/libavcodec/zmbvenc.c index b431476241..8efdbc963e 100644 --- a/libavcodec/zmbvenc.c +

[FFmpeg-devel] [PATCH 1/9] avcodec/magicyuvenc: Use immediate when known

2021-09-28 Thread Andreas Rheinhardt
It allows the compiler to optimize the bytestream2 checks away. Signed-off-by: Andreas Rheinhardt --- libavcodec/magicyuvenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c index 5aef810a58..7ab5e61ffe 100644 --- a/l

[FFmpeg-devel] [PATCH] lavf/movenc: Write 'dby1' minor brand if Dolby content is being muxed to MP4

2021-09-28 Thread Derek Buitenhuis
This is as per: * mp4ra: http://mp4ra.org/#/brands * Dolby Vision muxing spec (which is public): https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-content-creators/dolby_vision_bitstreams_within_the_iso_base_media_file_format_dec2017.pdf Signed-off-by: Derek

Re: [FFmpeg-devel] [PATCH 3/4] avutil/detection_bbox: simplify code for better readability

2021-09-28 Thread lance . lmwang
On Tue, Sep 28, 2021 at 03:57:27PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/detection_bbox.c | 24 +--- > > 1 file changed, 13 insertions(+), 11 deletions(-) > > > > diff --git a/

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Arif Driessen
> These should be formatted like they are in the surround filter for the option with the same name. Good catch! Looking around, I see there are other filters too with a win_func option. When I next get a moment (either later today or more likely tomorrow) I'll double check with the code, and add d

Re: [FFmpeg-devel] [PATCH 1/4] avutil/detection_bbox: fix the memory leak on error

2021-09-28 Thread lance . lmwang
On Tue, Sep 28, 2021 at 03:45:03PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/detection_bbox.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavutil/detection_bbox.c b/libavutil/dete

Re: [FFmpeg-devel] [PATCH 3/4] avutil/detection_bbox: simplify code for better readability

2021-09-28 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/detection_bbox.c | 24 +--- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c > index 8bfdff7..3de66ce 10064

Re: [FFmpeg-devel] [PATCH 1/4] avutil/detection_bbox: fix the memory leak on error

2021-09-28 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/detection_bbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c > index 40711e6..d066567 100644 > --- a/libavutil/detection_bbox.c > +++

[FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: set the film grain property if present

2021-09-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevcdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 57a6175..b4edb3b 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -385,6 +385,9 @@ static int export_stream

[FFmpeg-devel] [PATCH 3/4] avutil/detection_bbox: simplify code for better readability

2021-09-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/detection_bbox.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c index 8bfdff7..3de66ce 100644 --- a/libavutil/detection_bbox.c +++ b/l

[FFmpeg-devel] [PATCH 2/4] avutil/detection_bbox: use offsetof for bboxes_offset

2021-09-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/detection_bbox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c index d066567..8bfdff7 100644 --- a/libavutil/detection_bbox.c +++ b/libavutil/detection_bbo

[FFmpeg-devel] [PATCH 1/4] avutil/detection_bbox: fix the memory leak on error

2021-09-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/detection_bbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c index 40711e6..d066567 100644 --- a/libavutil/detection_bbox.c +++ b/libavutil/detection_bbox.c @@ -61,6 +61,7 @@

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/vf_codecview: added new options for block

2021-09-28 Thread lance . lmwang
On Tue, Sep 21, 2021 at 12:32:02PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/filters.texi | 3 +++ > libavfilter/version.h | 2 +- > libavfilter/vf_codecview.c | 35 +++ > 3 files changed, 3

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Gyan Doshi
On 2021-09-28 02:05 pm, Arif Driessen wrote: Hello all, excited about my first patch! Documented the possible window functions for `afftfilt`. Needs review/signing-off. These should be formatted like they are in the surround filter for the option with the same name. --- doc/filters.te

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/siren: Check available bits at frame start

2021-09-28 Thread Peter Ross
On Tue, Sep 28, 2021 at 12:07:49AM -0300, James Almer wrote: > On 9/27/2021 7:37 PM, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 > > > > Found-by: continuous fuzzing process > > https://gith

[FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Arif Driessen
Hello all, excited about my first patch! Documented the possible window functions for `afftfilt`. Needs review/signing-off. --- doc/filters.texi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 0b7e21f7f8..0a04165f11 100644 --- a/d

[FFmpeg-devel] [PATCH 3/3] librist: set logsocket config to -1

2021-09-28 Thread Gijs Peskens
Signed-off-by: Gijs Peskens --- libavformat/librist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/librist.c b/libavformat/librist.c index 47c01a8432..987056ccd1 100644 --- a/libavformat/librist.c +++ b/libavformat/librist.c @@ -245,6 +245,7 @@ static int librist_open(URLContex

[FFmpeg-devel] [PATCH 2/3] librist: allow use of circular buffer for receiving.

2021-09-28 Thread Gijs Peskens
libRIST internally stores packets in a fifo of 1024 packets, overwriting old packets when not read in a sufficient pace. Unfortunately this results in many fifo overflow errors when ffmpeg consumes a libRIST stream. This patch creates a receiver thread based on the UDP circular buffer code. Signed

[FFmpeg-devel] [PATCH 1/3] librist: replace deprecated functions.

2021-09-28 Thread Gijs Peskens
This gets rid of of rist_receiver_data_read, rist_receiver_data_block_free and rist_parse_address these functions have been deprecated since librist release v0.2.1 and are replaced with functions suffixed with 2. I added a version macro check at the top of the file to ensure ffmpeg can still be

[FFmpeg-devel] [PATCH 3/3] avfilter/avfiltergraph: Remove always-true check

2021-09-28 Thread Andreas Rheinhardt
Always true since bc1a985ba030e9861d24965d42792850b43a43ea. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfiltergraph.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index d1b121cc17..6dcff95ac4 100644 --- a/

[FFmpeg-devel] [PATCH 2/3] avfilter/avfiltergraph: Free AVFilterGraph options properly

2021-09-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/avfiltergraph.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index ee0c82030d..d1b121cc17 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergraph

[FFmpeg-devel] [PATCH 1/3] avfilter/avfiltergraph: Simplify adding filter to graph

2021-09-28 Thread Andreas Rheinhardt
By reallocating the array of pointers to the AVFilterContexts before allocating the new AVFilterContext one can avoid freeing the new AVFilterContext in case the array could not be reallocated. Also switch to av_realloc_array() while just at it. Signed-off-by: Andreas Rheinhardt --- libavfilter

Re: [FFmpeg-devel] [PATCH 3/4] libswscale/x86/rgb2rgb: add uyvytoyuv422 avx2

2021-09-28 Thread Wu, Jianhua
Min Chen wrote: > > The current algoithm may get improve, may you combin these optimize with > your patches? since extra VPERM make code a little more slower. > > > > On Haswell > Current alogithm: > RSHIFT_COPY m6, m2, 1 ; UYVY UYVY -> YVYU YVY... > pand m6, m1; YxYx YxYx... RSHIFT_COPY m7, m3