Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/vble: Return value check for init_get_bits

On Aug 31, 2021, at 11:02 AM, Andreas Rheinhardt mailto:andreas.rheinha...@outlook.com>> wrote: So instead of removing said check it In the previous version I didn’t remove it, but Paul B Mahol said remove the previous check. Here

[FFmpeg-devel] [PATCH v2] avcodec/truemotion1: Cleanup prediction code in truemotion1_decode_16bit and truemotion1_decode_24bit

This cleans up the code in the decode24bit and decode16bit functions by putting it in way that expresses the true intent while making it easier to read. --- libavcodec/truemotion1.c | 40 +--- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/lib

Re: [FFmpeg-devel] [PATCH v2] avcodec/libvpxenc: Apply codec options to alpha codec context

On Fri, Sep 3, 2021 at 1:33 AM Adam Chelminski wrote: > > When encoding yuva420 (alpha) frames, the vpx encoder uses a second > vpx_codec_ctx to encode the alpha stream. However, codec options were > only being applied to the primary encoder. This patch updates > codecctl_int and codecctl_intp to

[FFmpeg-devel] [PATCH 10/11] examples/hw_decode: Don't use stack packet

Signed-off-by: Andreas Rheinhardt --- doc/examples/hw_decode.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/doc/examples/hw_decode.c b/doc/examples/hw_decode.c index 096a229c0d..0d23f451e6 100644 --- a/doc/examples/hw_decode.c +++ b/doc/examples/hw_d

[FFmpeg-devel] [PATCH 11/11] examples/qsvdec: Don't use stack packet

Signed-off-by: Andreas Rheinhardt --- doc/examples/qsvdec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/examples/qsvdec.c b/doc/examples/qsvdec.c index 571d868f93..b662ae91c3 100644 --- a/doc/examples/qsvdec.c +++ b/doc/examples/qsvdec.c @@ -113,7 +1

[FFmpeg-devel] [PATCH 09/11] examples/filtering_video: Don't use stack packet

Signed-off-by: Andreas Rheinhardt --- doc/examples/filtering_video.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/doc/examples/filtering_video.c b/doc/examples/filtering_video.c index 88394530ab..7b3e16c40c 100644 --- a/doc/examples/filtering_video.c +++ b/

[FFmpeg-devel] [PATCH 07/11] examples/extract_mvs: Do not use stack packet

Signed-off-by: Andreas Rheinhardt --- doc/examples/extract_mvs.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/doc/examples/extract_mvs.c b/doc/examples/extract_mvs.c index 84f071075a..cc1311da91 100644 --- a/doc/examples/extract_mvs.c +++ b/doc/examples/

[FFmpeg-devel] [PATCH 08/11] examples/filtering_audio: Don't use stack packet

Signed-off-by: Andreas Rheinhardt --- doc/examples/filtering_audio.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/doc/examples/filtering_audio.c b/doc/examples/filtering_audio.c index 2af73a7031..7d0eb19bbe 100644 --- a/doc/examples/filtering_audio.c +++ b/d

[FFmpeg-devel] [PATCH 06/11] examples/muxing: Don't use stack packet

Signed-off-by: Andreas Rheinhardt --- doc/examples/muxing.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/doc/examples/muxing.c b/doc/examples/muxing.c index 879fe06299..8a11e52842 100644 --- a/doc/examples/muxing.c +++ b/doc/examples/muxing.c @

[FFmpeg-devel] [PATCH 05/11] examples/remuxing: Don't use stack packet

Signed-off-by: Andreas Rheinhardt --- doc/examples/remuxing.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/doc/examples/remuxing.c b/doc/examples/remuxing.c index b23431567c..4e9354c535 100644 --- a/doc/examples/remuxing.c +++ b/doc/examp

[FFmpeg-devel] [PATCH 04/11] examples/remuxing: Use av_packet_rescale_ts()

Signed-off-by: Andreas Rheinhardt --- doc/examples/remuxing.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/examples/remuxing.c b/doc/examples/remuxing.c index 9835cc4c00..b23431567c 100644 --- a/doc/examples/remuxing.c +++ b/doc/examples/remuxing.c @@ -156,9 +156,7 @

[FFmpeg-devel] [PATCH 03/11] fftools/ffmpeg, doc/examples: Remove redundant av_packet_unref

av_interleaved_write_frame() already returns blank packets. Signed-off-by: Andreas Rheinhardt --- doc/examples/muxing.c | 4 +++- doc/examples/remuxing.c | 4 +++- fftools/ffmpeg.c| 1 - 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/examples/muxing.c b/doc/examples

[FFmpeg-devel] [PATCH 02/11] avformat/avformat: Clarify documentation of av_interleaved_write_frame()

The earlier documentation claimed that av_interleaved_write_frame() always orders by dts, which is not necessarily true when using muxers with custom interleavement functions or the audio_preload option. Furthermore, the documentation stated that libavformat takes ownership of the reference of the

[FFmpeg-devel] [PATCH 01/11] avformat/mux: Sanitize packets without data and side-data

The BSF API treats such packets as signalling EOF and therefore such a packet might corrupt the BSF state. In such a case, the guarantee that av_interleaved_write_frame() always frees the packet is not upheld. Signed-off-by: Andreas Rheinhardt --- My first attempt was to disallow such packets, bu

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix crash with too big STSZ atoms

Paul B Mahol: > On Sat, Jul 24, 2021 at 6:09 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> mov_read_stsz() did not ensure that every bit of a buffer is addressable >> by an int as is required by the get_bits API, leading to a crash in >> ticket #9344. Fix this by restrictin

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix crash with too big STSZ atoms

On Sat, Jul 24, 2021 at 6:09 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > mov_read_stsz() did not ensure that every bit of a buffer is addressable > by an int as is required by the get_bits API, leading to a crash in > ticket #9344. Fix this by restricting the size more thoroug

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegutils: consolidate single byte av_log()

Michael Niedermayer: > Fixes: Timeout (56sec -> 15sec) > Fixes: > 37141/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-6192122867875840 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/xpmdec: Move allocations down after more error checks

probably fine ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/argo: Move U, fix shift

lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/4] avcodec/argo: Move U, fix shift

Fixes: left shift of 255 by 24 places cannot be represented in type 'int' Fixes: 37249/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARGO_fuzzer-5754862984888320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niederm

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegutils: consolidate single byte av_log()

On 9/3/2021 3:39 PM, Michael Niedermayer wrote: Fixes: Timeout (56sec -> 15sec) Fixes: 37141/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-6192122867875840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michae

[FFmpeg-devel] [PATCH 4/4] avcodec/xpmdec: Move allocations down after more error checks

Fixes: Timeout Fixes: 37035/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-5142718576721920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/xpmdec.c | 14 +++--- 1 file c

[FFmpeg-devel] [PATCH 3/4] avcodec/mpegutils: consolidate single byte av_log()

Fixes: Timeout (56sec -> 15sec) Fixes: 37141/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-6192122867875840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpegutils.c | 56 ++

[FFmpeg-devel] [PATCH 1/4] avcodec/utils: ARGO writes 4x4 blocks without regard to the image dimensions

Fixes: out of array access Fixes: 37197/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARGO_fuzzer-5877046382297088 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 6 ++ 1 fil

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix compilation after recent libdav1d API changes

On 9/3/2021 1:53 PM, James Almer wrote: They were done in preparation for an upcoming 1.0 release. Keep supporting previous releases for the time being. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) Reviewe

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/nvenc: Add intra refresh support

On 02.09.2021 12:38, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/nvenc.c | 24 +--- libavcodec/nvenc.h | 1 + libavcodec/nvenc_h264.c | 2 ++ libavcodec/nvenc_hevc.c | 2 ++ 4 files changed, 26 insertions(+), 3

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Remove unused fields

lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet filter

> -Original Message- > From: ffmpeg-devel On Behalf Of > Moritz Barsnick > Sent: Friday, 3 September 2021 10:24 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet > filter > > On Tue, Aug 31, 2021 a

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Remove unused fields

Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index b21a2376d2..8184099b05 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -360,8 +360,6 @@ typedef struct InputStream { unsigned int

[FFmpeg-devel] [PATCH] avcodec/libdav1d: fix compilation after recent libdav1d API changes

They were done in preparation for an upcoming 1.0 release. Keep supporting previous releases for the time being. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libd

Re: [FFmpeg-devel] [PATCH] avformat/mux: Fix double-free when using AVPacket.opaque_ref

3 Sept 2021, 17:23 by andreas.rheinha...@outlook.com: > Andreas Rheinhardt: > >> Up until now, ff_write_chained() copied the packet (manually, not with >> av_packet_move_ref()) from a packet given to it to a stack packet whose >> timing and stream_index is then modified before being sent to anothe

Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet filter

> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Friday, 3 September 2021 10:31 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet > filter > > Moritz Barsnick (12021-0

Re: [FFmpeg-devel] [PATCH v3 25/25] avfilter/vf_xmedian: Split portion of init unique to xmedian off

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_xmedian.c | 56 ++-- > 1 file changed, 31 insertions(+), 25 deletions(-) > > diff --git a/libavfilter/vf_xmedian.c b/libavfilter/vf_xmedian.c > index f8e4e4adb2..a9e3255a2a 100644 >

Re: [FFmpeg-devel] [PATCH] avformat/mux: Fix double-free when using AVPacket.opaque_ref

Andreas Rheinhardt: > Up until now, ff_write_chained() copied the packet (manually, not with > av_packet_move_ref()) from a packet given to it to a stack packet whose > timing and stream_index is then modified before being sent to another > muxer via av_(interleaved_)write_frame(). Afterwards it is

Re: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: Don't access AV(In|Out)putformat.get_device_list

Andreas Rheinhardt: > It is not part of the public API. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/cmdutils.c | 16 ++-- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 2dd035a7cf..69c39479f5 100644 > ---

Re: [FFmpeg-devel] [PATCH 01/13] avcodec/vp9: Do not destroy uninitialized mutexes/conditions

Steve Lhomme: > On 2021-09-02 17:34, Andreas Rheinhardt wrote: >> Also do not destroy and reinitialize mutexes and conditions when >> certain input parameters change. Given that the decoder did not >> create these variables at all during init, uninitialized mutexes >> and conditions are destroyed b

[FFmpeg-devel] [PATCH 2/2] ffmpeg: allow to pass "auto" to filter_threads

This way it accepts the same values as the libavcodec specific option "threads" Fixes FATE with THREADS=auto which was broken in bdc1bdf3f5. Signed-off-by: James Almer --- fftools/ffmpeg.c| 1 + fftools/ffmpeg.h| 2 +- fftools/ffmpeg_filter.c | 7 +-- fftools/ffmpeg_opt.c

[FFmpeg-devel] [PATCH 1/2] avfilter/avfiltergraph: add an "auto" constant to the threads option

Signed-off-by: James Almer --- libavfilter/avfiltergraph.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 383d9c5478..727c8b7f5c 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergraph.c @@ -

Re: [FFmpeg-devel] [PATCH] avcodec/h264_levels, h265_profile_level: Avoid relocations

Andreas Rheinhardt: > H.264 and H.265 levels' names are usually of the form "x" or "x.y" > with x and y being single digits; the one exception are the H.264 1b > levels. All of those levels' names fit into a char[4] and it is likely > that this future levels will do so, too. > > Therefore this com

Re: [FFmpeg-devel] [PATCH] ffmpeg: allow to pass "auto" to filter_threads

James Almer: > This way it accepts the same values as the libavcodec specific option > "threads" > > Fixes FATE with THREADS=auto which was broken in bdc1bdf3f5 > > Signed-off-by: James Almer > --- > fftools/ffmpeg_opt.c | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH] ffmpeg: allow to pass "auto" to filter_threads

This way it accepts the same values as the libavcodec specific option "threads" Fixes FATE with THREADS=auto which was broken in bdc1bdf3f5 Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg

Re: [FFmpeg-devel] [PATCH] fftools: Remove remnants of resample_opts

lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] fftools: Remove remnants of resample_opts

These were intended to pass options to auto-inserted avresample resampling filters. Yet FFmpeg uses swresample for this purpose (with its own AVDictionary swr_opts similar to resample_opts). Therefore said options were not forwarded any more since commit 911417f0b34e611bf084319c5b5a4e4e630da940; mo

Re: [FFmpeg-devel] [PATCH 2/2] lavc/aarch64: h264, add idct for 10bit

On Fri, 20 Aug 2021, Mikhail Nitenko wrote: Benchmarks: A53 A72 h264_idct4_add_10bpp_c:187.7 115.2 h264_idct4_add_10bpp_neon: 72.545.0 h264_idct4_add_dc_10bpp_c:

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

On Fri, 3 Sep 2021, Martin Storsjö wrote: +function \type\()_h264_qpel8_v_lowpass_neon_10 +ld1 {v16.8H}, [x1], x3 +ld1 {v18.8H}, [x1], x3 +ld1 {v20.8H}, [x1], x3 +ld1 {v22.8H}, [x1], x3 +ld1 {v24.

[FFmpeg-devel] [PATCH 1/2] arm/aarch64: Improve scheduling in the avg form of h264_qpel

Don't use the loaded registers directly, avoiding stalls on in order cores. Use vrhadd.u8 with q registers where easily possible. --- libavcodec/aarch64/h264qpel_neon.S | 60 +++--- libavcodec/arm/h264qpel_neon.S | 57 2 files changed, 54 in

[FFmpeg-devel] [PATCH 2/2] aarch64: h264qpel: Do vertical filtering without transposing

This gives rather big speedups on these functions: Before: put_h264_qpel_8_mc01_8_neon: 241.0 131.5 138.7 put_h264_qpel_8_mc02_8_neon: 214.7 121.2 127.5 put_h264_qpel_8_mc03_8_neon: 242.5 131.2 135.7 put_h264_qpel_8_mc11_8_neon: 421.2 218.7 251.0 put_h264_qpel_8_mc1

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

On Thu, 19 Aug 2021, Mikhail Nitenko wrote: diff --git a/libavcodec/aarch64/h264qpel_neon.S b/libavcodec/aarch64/h264qpel_neon.S index d27cfac494..eb18469b7f 100644 --- a/libavcodec/aarch64/h264qpel_neon.S +++ b/libavcodec/aarch64/h264qpel_neon.S @@ -932,3 +932,518 @@ endfunc h264_qpel

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aarch64: move transpose_4x4S and transpose_8x8S to neon.S

On Fri, 20 Aug 2021, Mikhail Nitenko wrote: transpose_4x4S and transpose_8x8S were declared in vp9itxfm_16bpp_neon, however these macros are not unique to vp9 and could be used elsewhere. Signed-off-by: Mikhail Nitenko --- libavcodec/aarch64/neon.S| 49

[FFmpeg-devel] [PATCH v2] avcodec/libvpxenc: Apply codec options to alpha codec context

When encoding yuva420 (alpha) frames, the vpx encoder uses a second vpx_codec_ctx to encode the alpha stream. However, codec options were only being applied to the primary encoder. This patch updates codecctl_int and codecctl_intp to also apply codec options to the alpha codec context when encoding

Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet filter

Moritz Barsnick (12021-09-03): > Well, at least it demonstrates the boilerplate required for a simple > S->S filter, which touches only text (no timings or positioning or so). > A review of this boilerplate would be great. That would be a waste of time since the grounds of this patch series are un

[FFmpeg-devel] [PATCH] sws: implement slice threading

--- Now actually committing the changes. --- libswscale/options.c | 3 ++ libswscale/swscale.c | 59 libswscale/swscale_internal.h | 14 ++ libswscale/utils.c| 85 +++ 4 files changed, 161 insertions(+) di

Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet filter

On Tue, Aug 31, 2021 at 22:49:12 +, Soft Works wrote: > As for the "sleet" filter: Yes - it is totally useless for practical > use. I had explained why I added it in the 0/8 message: > > > Why leet? Real world use is surely questionable, but it has two advantages > > that make it a great choice

[FFmpeg-devel] [PATCH] sws: implement slice threading

--- Added a verbose log to context_init_threaded(). --- libswscale/options.c | 3 ++ libswscale/swscale.c | 59 + libswscale/swscale_internal.h | 14 ++ libswscale/utils.c| 82 +++ 4 files changed, 158 inser

[FFmpeg-devel] [PATCH] sws: add a new scaling API

--- Better doxy for output slice alignment. --- libswscale/swscale.c | 294 ++ libswscale/swscale.h | 92 +++ libswscale/swscale_internal.h | 21 +++ libswscale/swscale_unscaled.c | 2 + libswscale/utils.c| 72 + 5

Re: [FFmpeg-devel] [PATCH 12/13] avcodec/omx: Check initializing mutexes/conditions

Steve Lhomme: > On 2021-09-02 17:41, Andreas Rheinhardt wrote: >> The earlier code did not properly check these initializations: >> It only recorded whether the part of init where these initializations >> are has been reached, but it did not check whether the initializations >> were successful, alt