On Fri, 20 Aug 2021, Mikhail Nitenko wrote:
transpose_4x4S and transpose_8x8S were declared in vp9itxfm_16bpp_neon, however these macros are not unique to vp9 and could be used elsewhere.Signed-off-by: Mikhail Nitenko <mnite...@gmail.com> --- libavcodec/aarch64/neon.S | 49 ++++++++++++++++++++++++ libavcodec/aarch64/vp9itxfm_16bpp_neon.S | 49 ------------------------ 2 files changed, 49 insertions(+), 49 deletions(-) diff --git a/libavcodec/aarch64/neon.S b/libavcodec/aarch64/neon.S index 1ad32c359d..4186186185 100644 --- a/libavcodec/aarch64/neon.S +++ b/libavcodec/aarch64/neon.S @@ -160,3 +160,52 @@ trn2 \r7\().2D, \r9\().2D, \r7\().2D .endm + +.macro transpose_4x4S r0, r1, r2, r3, r4, r5, r6, r7
-.macro transpose_4x4s r0, r1, r2, r3, r4, r5, r6, r7
Here, you are changing the case of the macro name. This breaks the existing users of the macro in vp9itxfm when built with clang or gas-preprocessor, which both treat macros case-sensitively.
If you want to make the casing consistent with the rest of neon.S here, then please do mention it in the commit message, and update vp9itxfm correspondingly.
// Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
