Re: [FFmpeg-devel] [PATCH v4 0/2] TTML in MP4, part 1

2021-08-24 Thread Jan Ekström
On Mon, Aug 23, 2021 at 11:31 AM Jan Ekström wrote: > > On Mon, Aug 16, 2021 at 3:26 PM Jan Ekström wrote: > > > > To keep it simpler this first part includes only non-fragmented use > > cases if the built-in sample squashing is utilized. Contains the basic > > mapping code as well as the functio

Re: [FFmpeg-devel] [PATCH v3 1/1] avcodec/vp6: return value check for init_get_bits

2021-08-24 Thread Peter Ross
On Mon, Aug 23, 2021 at 02:35:01PM -0400, maryam ebrahimzadeh wrote: > avcodec/vp6: Return value check for init_get_bits > > As the second argument for init_get_bits(buf) can be crafted, > a return value check for this function call is necessary. > Also replace init_get_bits with init_get_bits8. >

Re: [FFmpeg-devel] [PATCH v3 1/1] avcodec/vp6: return value check for init_get_bits

2021-08-24 Thread Maryam Ebrahimzadeh
ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v5 1/1] avcodec/vc1dec: Return value check for init_get_bits

2021-08-24 Thread Maryam Ebrahimzadeh
ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: fix possible out-of-bounds array access

2021-08-24 Thread James Almer
On 8/25/2021 12:06 AM, Niklas Haas wrote: From: Niklas Haas If slice_type is > 9, the access to ff_h264_golomb_to_pict_type is out-of-bounds. Fix this by simply setting the slice_type to 0 in this case. This is completely inconsequential because the value is only being used to being used as an

[FFmpeg-devel] [PATCH] avcodec/h264dec: fix possible out-of-bounds array access

2021-08-24 Thread Niklas Haas
From: Niklas Haas If slice_type is > 9, the access to ff_h264_golomb_to_pict_type is out-of-bounds. Fix this by simply setting the slice_type to 0 in this case. This is completely inconsequential because the value is only being used to being used as an offset in the calculation of the film grain

Re: [FFmpeg-devel] [PATCH 1/3] checkasm: collapse hevc pel tests

2021-08-24 Thread Thilo Borgmann
Am 05.08.21 um 22:32 schrieb Martin Storsjö: > On Thu, 5 Aug 2021, J. Dekker wrote: > >> Also add to `make fate-checkasm' target. >> >> Signed-off-by: J. Dekker >> --- >> tests/checkasm/checkasm.c | 11 +-- >> tests/checkasm/checkasm.h | 11 +-- >> tests/checkasm/hevc_pel.c | 34 +++

[FFmpeg-devel] [PATCH] avfilter: add adecorrelate filter

2021-08-24 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 14 ++ libavfilter/Makefile | 1 + libavfilter/af_adecorrelate.c | 268 ++ libavfilter/allfilters.c | 1 + 4 files changed, 284 insertions(+) create mode 100644 libavfilter/af_adeco

Re: [FFmpeg-devel] [PATCH 1/1] Add grayworld color correction filer

2021-08-24 Thread Paul B Mahol
On Tue, Aug 24, 2021 at 8:51 PM Paul Buxton wrote: > Thanks, will resolve these issues, the alphabetical issues are mostly > because I originally was calling it underwater filter. > > Regarding the iteration over the buffer, I wasn't sure that buffer would > always be planar, can tidy this up. I

Re: [FFmpeg-devel] [PATCH 1/1] Add grayworld color correction filer

2021-08-24 Thread Paul Buxton
Thanks, will resolve these issues, the alphabetical issues are mostly because I originally was calling it underwater filter. Regarding the iteration over the buffer, I wasn't sure that buffer would always be planar, can tidy this up. I assume it may be strided however? Paul On Tue, Aug 24, 2021

Re: [FFmpeg-devel] [PATCH 1/1] Add grayworld color correction filer

2021-08-24 Thread Paul B Mahol
On Tue, Aug 24, 2021 at 6:58 PM Paul Buxton wrote: > Signed-off-by: Paul Buxton > --- > MAINTAINERS| 1 + > doc/filters.texi | 14 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/version.h | 2 +- > libavfilter/vf_

[FFmpeg-devel] [PATCH v2] doc/general_contents: Fix dead links

2021-08-24 Thread Mapul Bhola
The x265 configuration and installation guide has moved to Bitbucket so the updated link reflects that one. As the openCV site currently only has docs for opencv3 and the filter in libavfilter is an opencv2 an alternative link is provided. --- doc/filters.texi | 2 +- doc/general_conte

Re: [FFmpeg-devel] [PATCH] avcodec/truemotion1: Cleanup prediction code in truemotion1_decode_16bit and truemotion1_decode_24bit

2021-08-24 Thread Mapul Bhola
ping August 19, 2021 12:48 PM, ffmpegandmahanstreamer@e.email wrote: > ping > > August 14, 2021 7:29 AM, ffmpegandmahanstreamer@e.email wrote: > >> This cleans up the code in the decode24bit and decode16bit functions by >> putting it in way that >> expresses the true intent while making it eas

Re: [FFmpeg-devel] [PATCH v2] avfilter: add libdewobble_opencl filter

2021-08-24 Thread Mapul Bhola
August 23, 2021 10:43 PM, "Daniel Playfair Cal" wrote: > On Tue, Aug 24, 2021 at 3:09 AM Paul B Mahol wrote: > >> library is named dewobble, thus filter should be libdewobble. > > Lynne suggested "libdewobble_opencl". I can rename it to "libdewobble" > if you prefer, but will everyone be happ

[FFmpeg-devel] Fate Test for linear RGB filter

2021-08-24 Thread Paul Buxton
Hi, I have just submitted my first path, hopefully it should meet the contribution requirements. I did try and implement a Fate test to exercise the filter but was struggling to get them to run as it would complain about there being no path between the colorspaces. Looking through the fate tests fo

[FFmpeg-devel] [PATCH 1/1] Add grayworld color correction filer

2021-08-24 Thread Paul Buxton
Signed-off-by: Paul Buxton --- MAINTAINERS| 1 + doc/filters.texi | 14 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_grayworld.c | 401 + 6 files chan

[FFmpeg-devel] [PATCH 0/1] avfilter Add grayworld color correction filter

2021-08-24 Thread Paul Buxton
Implements a grayworld based color correction filter aimed at use for underwater video, but applicable to other situations Paul Buxton (1): Add grayworld color correction filer MAINTAINERS| 1 + doc/filters.texi | 14 ++ libavfilter/Makefile | 1 + libavfi

[FFmpeg-devel] [PATCH 2/2] avcodec/wma: handle run_level_decode error

2021-08-24 Thread Olivier Crête
From: Stéphane Cerveau Consider data as invalid if ff_wma_run_level_decode gets out with an error. It avoids an unpleasant sound distorsion. See http://trac.ffmpeg.org/ticket/9358 --- libavcodec/wmadec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH 1/2] avcodec/wma: Return specific error code

2021-08-24 Thread Olivier Crête
This way, the calling functioin can just forward it instead of making it up. Signed-off-by: Olivier Crête --- libavcodec/wma.c | 4 ++-- libavcodec/wmaprodec.c | 13 - 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libavcodec/wma.c b/libavcodec/wma.c index 004

Re: [FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

2021-08-24 Thread Ronald S. Bultje
Hi, On Tue, Aug 24, 2021 at 9:07 AM Olivier Crête wrote: > Hi Andreas, > > > Generally, one should forward error codes and not make up some on the > > fly; in this case, the callee does not return proper error codes, so > > this should be fixed, too (but not in the same commit and not > > necess

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: add a return at the end of a non-void function

2021-08-24 Thread James Almer
On 8/24/2021 10:12 AM, Nicolas George wrote: James Almer (12021-08-24): Fixes compilation with GCC 11 when configured with "--disable-optimizations --toolchain=gcc-tsan" Signed-off-by: James Almer --- libavfilter/avfilter.c | 1 + 1 file changed, 1 insertion(+) Ok, thanks. Regards, Ap

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: add a return at the end of a non-void function

2021-08-24 Thread Nicolas George
James Almer (12021-08-24): > Fixes compilation with GCC 11 when configured with "--disable-optimizations > --toolchain=gcc-tsan" > > Signed-off-by: James Almer > --- > libavfilter/avfilter.c | 1 + > 1 file changed, 1 insertion(+) Ok, thanks. Regards, -- Nicolas George signature.asc Des

Re: [FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

2021-08-24 Thread Olivier Crête
Hi Andreas, > Generally, one should forward error codes and not make up some on the > fly; in this case, the callee does not return proper error codes, so > this should be fixed, too (but not in the same commit and not > necessarily by you). Even more importantly, the callee emits an error > messa

[FFmpeg-devel] [PATCH] avfilter/avfilter: add a return at the end of a non-void function

2021-08-24 Thread James Almer
Fixes compilation with GCC 11 when configured with "--disable-optimizations --toolchain=gcc-tsan" Signed-off-by: James Almer --- libavfilter/avfilter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 4b6a3d1e8f..a04f8ed62f 100644 --- a/l

[FFmpeg-devel] [PATCH 2/2] avformat/mxf: support MCA audio information

2021-08-24 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 283 ++- 2 files changed, 278 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

[FFmpeg-devel] [PATCH 1/2] avformat/mxf: rename sub_descriptors as file_descriptors

2021-08-24 Thread Marc-Antoine Arnaud
--- libavformat/mxfdec.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 34cbd2cd77..c28549f6a9 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -203,8 +203,8 @@ typedef struct MXFDescri

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: silence valgrind warning

2021-08-24 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- fftools/ffmpeg_filter.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 49076f13ee..b3f230e8b6 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -975,12 +975,13