Hi, On Tue, Aug 24, 2021 at 9:07 AM Olivier Crête <olivier.cr...@collabora.com> wrote:
> Hi Andreas, > > > Generally, one should forward error codes and not make up some on the > > fly; in this case, the callee does not return proper error codes, so > > this should be fixed, too (but not in the same commit and not > > necessarily by you). Even more importantly, the callee emits an error > > message, stating that an error will be ignored, which will no longer > > true with this patch. > > If I understand correctly, the "ignoring" refers to the block being > ignored because of errors, not to the error being ignored. > No, the opposite. He suggests to try: ret = try_decode_wma(); if (ret < 0) return ret; instead of: if (ret < 0) return AVERROR_INVALIDDATA; Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
