[FFmpeg-devel] [PATCH] ffmpeg_hw: Don't ignore key parameters when initializing a hw device

2021-08-10 Thread Haihao Xiang
Currently user may use '-init_hw_device type=name' to initialize a hw device, however the key parameter is ignored when use '-init_hw_device type=name,key=value'. After applying this patch, user may set key parameter if needed. --- fftools/ffmpeg_hw.c | 16 +++- 1 file changed, 15 inse

[FFmpeg-devel] [RFC PATCH] avformat/mov: add AVFMT_SHOW_IDS flag

2021-08-10 Thread Gyan Doshi
The MOV muxer can store streamids as track ids but they aren't visible when probing the result via lavf/dump or ffprobe due to lack of this flag in the demuxer. This current submission is just to get Patchwork FATE results. Will be updated with changed refs, if any. --- libavformat/mov.c | 2 +-

[FFmpeg-devel] [PATCH v3 2/2] doc/examples/qsvdec: simplify this example via hw_device_ctx interface

2021-08-10 Thread Haihao Xiang
--- doc/examples/qsvdec.c | 45 +-- 1 file changed, 9 insertions(+), 36 deletions(-) diff --git a/doc/examples/qsvdec.c b/doc/examples/qsvdec.c index 7415eefca5..571d868f93 100644 --- a/doc/examples/qsvdec.c +++ b/doc/examples/qsvdec.c @@ -44,38 +44,10 @@

[FFmpeg-devel] [PATCH v3 1/2] qsvdec: add support for HW_DEVICE_CTX method

2021-08-10 Thread Haihao Xiang
This allows user set hw_device_ctx instead of hw_frames_ctx for QSV decoders, hence we may remove the ad-hoc libmfx setup code from FFmpeg. "-hwaccel_output_format format" is applied to QSV decoders after removing the ad-hoc libmfx code. In order to keep compatibility with old commandlines, the de

Re: [FFmpeg-devel] [PATCH v2] libavcodec/qsvence: Use QSV encoder defaults as ffmpeg defaults

2021-08-10 Thread Xiang, Haihao
On Tue, 2021-08-10 at 08:53 +, Soft Works wrote: > Signed-off-by: softworkz > --- > libavcodec/qsvenc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index fc8a14143e..58984f996f 100644 > --- a/libavcodec/qsvenc.h > +

[FFmpeg-devel] [PATCH 4/4] avcodec/vp9: use ff_thread_replace_frame()

2021-08-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/vp9.c | 67 ++-- 1 file changed, 42 insertions(+), 25 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 874005a5ae..85f44b9d8c 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -186,6 +1

[FFmpeg-devel] [PATCH 10/10] avfilter/avfilter: Hide most internal AVFilterLink fields

2021-08-10 Thread Andreas Rheinhardt
AVFilterLink does not have a separate structure for its internal fields. Instead these fields are in the public avfilter.h header together with a typical public/private separation line. But because one of these fields (not a pointer) has a non-public type, they are #ifdef'ed away and need to be mad

[FFmpeg-devel] [PATCH 07/10] avfilter/internal: Factor out executing a filter's execute_func

2021-08-10 Thread Andreas Rheinhardt
The current way of doing it involves writing the ctx parameter twice. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_acrossover.c| 2 +- libavfilter/af_adeclick.c | 2 +- libavfilter/af_adenorm.c | 2 +- libavfilter/af_aemphasis.c | 2 +- libavfilter/

[FFmpeg-devel] [PATCH 09/10] avfilter/avfilter: Make ff_update_link_current_pts static

2021-08-10 Thread Andreas Rheinhardt
Only used here. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 10 ++ libavfilter/internal.h | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 6925d99659..ef049fe9b6 100644 --- a/libavfilter/avfil

[FFmpeg-devel] [PATCH 08/10] avfilter: Avoid allocation of AVFilterInternal

2021-08-10 Thread Andreas Rheinhardt
This can be achieved by allocating it together with AVFilterContext, with the public AVFilterContext as first element in the new structure. Given that said structure is now more than just the internal, it has been renamed to FFFilterContext. Accessing it is not type-safe, so this unsafety has been

[FFmpeg-devel] [PATCH 06/10] avfilter: Avoid allocation of AVFilterGraphInternal

2021-08-10 Thread Andreas Rheinhardt
This can be achieved by allocating it together with AVFilterGraph, with the public AVFilterGraph as first element in the new structure. Given that said structure is now more than just the internal, it has been renamed to FFFilterGraph. Accessing it is not type-safe, so this unsafety has been confin

[FFmpeg-devel] [PATCH 05/10] avfilter/af_loudnorm: Simplify setting common samplerates

2021-08-10 Thread Andreas Rheinhardt
This filter has only one input and output, so what it does can be more easily achieved by using ff_set_common_samplerates(). Signed-off-by: Andreas Rheinhardt --- libavfilter/af_loudnorm.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavfilter/af_loudnorm.c b

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-10 Thread Wu, Jianhua
Ping > -Original Message- > From: Wu, Jianhua > Sent: Wednesday, August 4, 2021 10:06 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Wu, Jianhua > Subject: [PATCH v2 1/5] libavfilter/x86/vf_gblur: add > ff_postscale_slice_avx512() > > Co-authored-by: Cheng Yanfei > Co-authored-by: Jin Jun > S

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_(guided|program_opencl): Add missing dynamic inputs flag

2021-08-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_guided.c | 3 ++- libavfilter/vf_program_opencl.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c index 202a6a0586..e2bf08f5c3 100644 --- a/libavfilter/vf_guided.c

[FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Use av_memdup where appropriate

2021-08-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 908e812b5c..c04aefcaa8 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -659,10 +659,9 @@

[FFmpeg-devel] [PATCH 1/3] avfilter/avfilter: Fix leaks upon filter creation error

2021-08-10 Thread Andreas Rheinhardt
Both the name as well as the options need to be freed. (Right now there is no option for the AVFilterContext itself that could leak, but some filters have options (e.g. of type AV_OPT_TYPE_STRING) that can leak.) Signed-off-by: Andreas Rheinhardt --- I intend to remove this duplicated freeing cod

Re: [FFmpeg-devel] [PATCH 3/3] avcodech/h264_picture: use ff_thread_replace_frame()

2021-08-10 Thread James Almer
On 8/10/2021 7:16 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/h264_picture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c index ff30166b4d..109a8ff31d 100644 --- a/libavcod

Re: [FFmpeg-devel] [PATCH 3/3] avcodech/h264_picture: use ff_thread_replace_frame()

2021-08-10 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/h264_picture.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c > index ff30166b4d..109a8ff31d 100644 > --- a/libavcodec/h264_picture.c > +++ b/libavcodec/

[FFmpeg-devel] [PATCH 3/3] avcodech/h264_picture: use ff_thread_replace_frame()

2021-08-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264_picture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c index ff30166b4d..109a8ff31d 100644 --- a/libavcodec/h264_picture.c +++ b/libavcodec/h264_picture.c @@ -154,8 +154,7

[FFmpeg-devel] [PATCH 2/3] avcodec/pthread_frame: add ff_thread_replace_frame()

2021-08-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/pthread_frame.c | 29 + libavcodec/thread.h| 2 ++ libavcodec/utils.c | 20 3 files changed, 51 insertions(+) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 2ff

[FFmpeg-devel] [PATCH 1/3] avutil/frame: add av_frame_replace

2021-08-10 Thread James Almer
Signed-off-by: James Almer --- Not going to bother with implementing replace for side data, since it's IMO not worth it, but patches are welcome of course. Missing version bump and APIchanges entry. libavutil/frame.c | 98 +++ libavutil/frame.h | 18 +

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mxfdec: prefer footer and complete partitions for metadata

2021-08-10 Thread Michael Niedermayer
On Sun, Aug 01, 2021 at 01:15:32AM +, Marton Balint wrote: > ffmpeg | branch: master | Marton Balint | Sun Jun 27 > 22:59:49 2021 +0200| [7b4bdcd68e1e0abfab21a8be81789531d649c1ff] | committer: > Marton Balint > > avformat/mxfdec: prefer footer and complete partitions for metadata > > Also

Re: [FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log timing

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Tuesday, 10 August 2021 21:09 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log > timing > > Soft Works: > > > > > >> -Original Message- > >>

Re: [FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log timing

2021-08-10 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Tuesday, 10 August 2021 20:49 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log >> timing >> >> Soft Works: >>> This commit adds t

Re: [FFmpeg-devel] [PATCH] libavcodec/nvdec: Do not exceed 32 surfaces when initializing hw_frames_ctx

2021-08-10 Thread Ameer Jalil
Turns out the issue I was facing which prompted this patch request stemmed from improper usage of the APIs, and this patch was a workaround that was hiding the proper fix. Please feel free to reject this patch request, especially if it is likely to cause unforeseen issues down the line. Thanks -Am

Re: [FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log timing

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Tuesday, 10 August 2021 20:49 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log > timing > > Soft Works: > > This commit adds two logging flags: 'time

Re: [FFmpeg-devel] [PATCH v7 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Andreas Rheinhardt
Soft Works: > Signed-off-by: softworkz > --- > doc/APIchanges | 3 +++ > libavutil/log.c | 33 + > libavutil/log.h | 10 ++ > libavutil/version.h | 2 +- > 4 files changed, 43 insertions(+), 5 deletions(-) > > diff --git a/doc/APIchanges b/d

Re: [FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log timing

2021-08-10 Thread Andreas Rheinhardt
Soft Works: > This commit adds two logging flags: 'time' and 'datetime'. > > Usage: > > ffmpeg -loglevel +time > > or > > ffmpeg -loglevel +datetime > > Signed-off-by: softworkz > --- > doc/fftools-common-opts.texi | 4 > fftools/cmdutils.c | 21 + > fftoo

[FFmpeg-devel] [PATCH] fftools/cmdutils: Use av_strstart() instead of strncmp()

2021-08-10 Thread Andreas Rheinhardt
This also avoids hardcoding lengths. Signed-off-by: Andreas Rheinhardt --- Will apply this tomorrow unless there are objections in order not to block Soft Works' patch. fftools/cmdutils.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdu

[FFmpeg-devel] [PATCH] avutil/mem: Correct av_calloc() documentation

2021-08-10 Thread Andreas Rheinhardt
Incorrect since 4959f18a8e11ad7d3529b1c4fc429f1b6b76ad7c. Signed-off-by: Andreas Rheinhardt --- Do we even need both av_mallocz_array and av_calloc given that they do exactly the same? I'd like to deprecate one, namely av_mallocz_array() (it has the longer name). libavutil/mem.h | 2 +- 1 file

[FFmpeg-devel] [PATCH 2/2] avutil/mem: Reinline av_size_mult() internally

2021-08-10 Thread Andreas Rheinhardt
Since 580e168a945b65100ec2c25433f33bfacfe9f7be, av_size_mult() is no longer inlined; on systems where interposing is a thing, this also inhibits the compiler from inlining said function into the internal callers of said function, although inlining such a small function is typically beneficial: With

[FFmpeg-devel] [PATCH 1/2] avformat/oggdec: Use av_realloc_array()

2021-08-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- This also removes the last user of av_size_mult from libavformat (indeed, from anything outside of mem.c), so this removes one entry from the list of dynamic symbols (if using a shared build). libavformat/oggdec.c | 5 ++--- 1 file changed, 2 insertions(+),

[FFmpeg-devel] [PATCH v7 2/2] fftools: Add option to log timing

2021-08-10 Thread Soft Works
This commit adds two logging flags: 'time' and 'datetime'. Usage: ffmpeg -loglevel +time or ffmpeg -loglevel +datetime Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 fftools/cmdutils.c | 21 + fftools/ffmpeg.c | 6 +- 3 fil

[FFmpeg-devel] [PATCH v7 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Soft Works
Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 33 + libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 43 insertions(+), 5 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6eefc7fc33

Re: [FFmpeg-devel] [PATCH v6 2/2] fftools: Add option to log timing

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: Tuesday, 10 August 2021 19:07 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v6 2/2] fftools: Add option to log > timing > > 10 Aug 2021, 18:12 by softwo...@

[FFmpeg-devel] [PATCH] avfilter/vf_scale: Avoid unnecessary indirection

2021-08-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_scale.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index aa855b894a..160ad8b584 100644 --- a/libavfilter/vf_scale.c +++ b/liba

Re: [FFmpeg-devel] [PATCH v6 2/2] fftools: Add option to log timing

2021-08-10 Thread Lynne
10 Aug 2021, 18:12 by softwo...@hotmail.com: > This commit adds two logging flags: 'timing' and 'datetiming'. > > Usage: > > ffmpeg -loglevel +timing > > or > > ffmpeg -loglevel +datetiming > 'timing'? 'datetiming'? Just name them 'time' and 'datetime'. __

[FFmpeg-devel] [PATCH] libavformat/file.c: 'file_delete()' and 'file_move()' require 'CONFIG_FILE_PROTOCOL'

2021-08-10 Thread Michael Witten
This quashes 2 warnings when the 'file' protocol is not enabled. --- libavformat/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 8303436be0..9c23f680cd 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@ -167,6 +1

[FFmpeg-devel] [PATCH v6 2/2] fftools: Add option to log timing

2021-08-10 Thread Soft Works
This commit adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 fftools/cmdutils.c | 21 + fftools/ffmpeg.c | 6 +

[FFmpeg-devel] [PATCH v6 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Soft Works
Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 33 + libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 43 insertions(+), 5 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6eefc7fc33

Re: [FFmpeg-devel] [PATCH v5 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Tuesday, 10 August 2021 17:33 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 1/2] libavutil/log: Add capability > to prefix loglines with current time or current date+time > > Sof

Re: [FFmpeg-devel] [PATCH 1/2] imgutils: expose av_image_copy_plane_uc_from()

2021-08-10 Thread Lynne
10 Aug 2021, 17:29 by andreas.rheinha...@outlook.com: > Lynne: > >> diff --git a/libavutil/version.h b/libavutil/version.h >> >> index 6b4a265457..678cb9bfa6 100644 >> >> --- a/libavutil/version.h >> >> +++ b/libavutil/version.h >> >> @@ -80,7 +80,7 @@ >> >> >> >> #define LIBAVUTIL_VERSION_MAJOR

Re: [FFmpeg-devel] [PATCH v5 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Andreas Rheinhardt
Soft Works: > Signed-off-by: softworkz > --- > doc/APIchanges | 3 +++ > libavutil/log.c | 35 ++- > libavutil/log.h | 10 ++ > libavutil/version.h | 2 +- > 4 files changed, 44 insertions(+), 6 deletions(-) > > diff --git a/doc/APIchanges b

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/sbrdsp_fixed: Fix negation overflow in sbr_neg_odd_64_c()

2021-08-10 Thread Michael Niedermayer
On Sat, Jul 31, 2021 at 07:48:42PM +0200, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > an unsigned type to negate this value to itself > Fixes: > 35593/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5182217725804544

Re: [FFmpeg-devel] [PATCH] avcodec/faxcompr: Check for end of input in cmode == 1 in decode_group3_2d_line()

2021-08-10 Thread Michael Niedermayer
On Sat, Jul 31, 2021 at 09:26:49PM +0200, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 35591/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4503764022198272 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/2] imgutils: expose av_image_copy_plane_uc_from()

2021-08-10 Thread Andreas Rheinhardt
Lynne: > diff --git a/libavutil/version.h b/libavutil/version.h > index 6b4a265457..678cb9bfa6 100644 > --- a/libavutil/version.h > +++ b/libavutil/version.h > @@ -80,7 +80,7 @@ > > #define LIBAVUTIL_VERSION_MAJOR 57 > #define LIBAVUTIL_VERSION_MINOR 3 > -#define LIBAVUTIL_VERSION_MI

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: clear old slice POC values on parsing failure

2021-08-10 Thread James Almer
On 8/10/2021 12:04 PM, Andreas Rheinhardt wrote: James Almer: If a slice header fails to parse, and the next one uses different Sequence and Picture parameter sets, certain values may not be read if they are not coded, resulting in the previous slice values being used. Signed-off-by: James Alme

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: clear old slice POC values on parsing failure

2021-08-10 Thread Andreas Rheinhardt
James Almer: > If a slice header fails to parse, and the next one uses different Sequence and > Picture parameter sets, certain values may not be read if they are not coded, > resulting in the previous slice values being used. > > Signed-off-by: James Almer > --- > libavcodec/h264_slice.c | 3 ++

[FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-10 Thread Soft Works
Hi, A while ago there was a discussion about moving forward and migrating the ffmpeg development process from the mailing list to another platform (like GitLab). That discussion had died without further results and an important takeaway for me was that there are just too many that love this way

Re: [FFmpeg-devel] [PATCH v2] configure: [loongson] adjust MMI check in configure

2021-08-10 Thread Michael Niedermayer
On Tue, Aug 10, 2021 at 05:01:13PM +0800, 金波 wrote: > Ping. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nations do behave wisely once they have exhausted all other alternatives. -- Abba Eban signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] Mail quoting (was: libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Tuesday, 10 August 2021 16:28 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Mail quoting (was: libavutil/log: Add > capability to prefix loglines with current time or curren

Re: [FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Tuesday, 10 August 2021 16:03 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add > capability to prefix loglines with current time

Re: [FFmpeg-devel] Mail quoting (was: libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Nicolas George
Michael Niedermayer (12021-08-10): > if your MUA doesnt color the text to make it easy, > maybe you should consider a different MUA This is good advice in this specific instance, but I would not consider it an excuse for myself not to properly trim the replies I make, on the principle that I shou

Re: [FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Michael Niedermayer
On Tue, Aug 10, 2021 at 09:47:31AM +, Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Nicolas George > > Sent: Tuesday, 10 August 2021 11:16 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: [FFmpeg-devel] Mail q

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs: add a helper to read extradata within packet side data

2021-08-10 Thread James Almer
On 8/5/2021 12:24 PM, James Almer wrote: Using ff_cbs_read() on the raw buffer will not parse it as extradata, resulting in parsing errors for example when handling ISOBMFF avcC. This helper works around that. Signed-off-by: James Almer --- libavcodec/cbs.c | 13 + libavcodec/cbs

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: clear old slice POC values on parsing failure

2021-08-10 Thread James Almer
On 8/8/2021 3:38 PM, James Almer wrote: If a slice header fails to parse, and the next one uses different Sequence and Picture parameter sets, certain values may not be read if they are not coded, resulting in the previous slice values being used. Signed-off-by: James Almer --- libavcodec/h26

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_picture: split copying some H264Picture fields into a separate function

2021-08-10 Thread James Almer
On 8/8/2021 7:56 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/h264_picture.c | 57 ++- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c index eec5e9fb9a..89aef37edd 100

Re: [FFmpeg-devel] [PATCH] libavcodec/nvdec: Do not exceed 32 surfaces when initializing hw_frames_ctx

2021-08-10 Thread Dennis Mungai
On Tue, 10 Aug 2021 at 15:04, Timo Rothenpieler wrote: > On 10.08.2021 04:37, Ameer J wrote: > > From: ameerj <52414509+ame...@users.noreply.github.com> > > > > nvdec is likely to fail when the initial pool size exceeds 32. This > change ensures we don't exceed the limit when initializing a new >

Re: [FFmpeg-devel] [PATCH] libavcodec/nvdec: Do not exceed 32 surfaces when initializing hw_frames_ctx

2021-08-10 Thread Timo Rothenpieler
On 10.08.2021 04:37, Ameer J wrote: From: ameerj <52414509+ame...@users.noreply.github.com> nvdec is likely to fail when the initial pool size exceeds 32. This change ensures we don't exceed the limit when initializing a new hw_frames_ctx Signed-off-by: ameerj <52414509+ame...@users.noreply.gi

[FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: use GPU memcpy when copying to system RAM

2021-08-10 Thread Lynne
This should speed it up significantly on systems where it matters. Patch attached. >From b904c881ba23230dc86d0d34d6de0649c8d9c0cc Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 10 Aug 2021 12:47:06 +0200 Subject: [PATCH 2/2] hwcontext_vulkan: use GPU memcpy when copying to system RAM This sho

[FFmpeg-devel] [PATCH 1/2] imgutils: expose av_image_copy_plane_uc_from()

2021-08-10 Thread Lynne
The reason why the generic av_image_copy_uc_from() doesn't really fit in the case for Vulkan is because some planes may be copied via other methods (such as mapping GPU memory), and if they don't satisfy the strict alignment requirements, a gpu image->gpu buffer->cpu ram copy is performed. We nee

[FFmpeg-devel] [PATCH v5 2/2] fftools: Add option to log timing

2021-08-10 Thread Soft Works
This commit adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 fftools/cmdutils.c | 21 + fftools/ffmpeg.c | 6 +

[FFmpeg-devel] [PATCH v5 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Soft Works
Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 35 ++- libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 44 insertions(+), 6 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6eefc7fc

[FFmpeg-devel] [PATCH v2] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions

2021-08-10 Thread Soft Works
The test /libavutil/tests/hwdevice checks that when deriving a device from a source device and then deriving back to the type of the source device, the result is matching the original source device, i.e. the derivation mechanism doesn't create a new device in this case. Previously, this test was u

Re: [FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Tuesday, 10 August 2021 11:16 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add capability > to prefix loglines with cur

[FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Nicolas George
Soft Works (12021-08-10): > I meant the e-mail body of the previous conversation. Well, it is my mail, I put what I want in it, and you do what you want with yours. But ask yourself: which one do you find easier to read: one where you have to scroll half a dozen pages of old mail just to get to t

Re: [FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Tuesday, 10 August 2021 11:06 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to > prefix loglines with current

Re: [FFmpeg-devel] [PATCH] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Monday, 9 August 2021 09:27 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avutils/hwcontext: When deriving a > hwdevice, search for existing device in both directions > > On Sat, 2021-0

Re: [FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Nicolas George
Soft Works (12021-08-10): > I'm not sure whether it's OK to strip all content when there's nothing > new inside..? I do not understand what you are talking about, sorry. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpe

Re: [FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Monday, 9 August 2021 10:28 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to > prefix loglines with current time

Re: [FFmpeg-devel] [PATCH v2] configure: [loongson] adjust MMI check in configure

2021-08-10 Thread 金波
Ping. "yinshiyou-hf" 写道: > > -原始邮件- > > 发件人: "Jin Bo" > > 发送时间: 2021-08-03 12:05:21 (星期二) > > 收件人: ffmpeg-devel@ffmpeg.org > > 抄送: > > 主题: [FFmpeg-devel] [PATCH v2] configure: [loongson] adjust MMI check in > > configure > > > > After standardizing the use of

[FFmpeg-devel] [PATCH v2] libavcodec/qsvence: Use QSV encoder defaults as ffmpeg defaults

2021-08-10 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/qsvenc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h index fc8a14143e..58984f996f 100644 --- a/libavcodec/qsvenc.h +++ b/libavcodec/qsvenc.h @@ -76,8 +76,8 @@ #define QSV_COMMON_OPTS \

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Don't auto flush fragment if no frame available

2021-08-10 Thread Martin Storsjö
On Tue, 10 Aug 2021, 胡玮文 wrote: Thank you for your detailed explaination. Now I agree your patch is better. Ok, I pushed that one then. // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Don't auto flush fragment if no frame available

2021-08-10 Thread 胡玮文
Thank you for your detailed explaination. Now I agree your patch is better. On Mon, Aug 09, 2021 at 09:36:12PM +0300, Martin Storsjö wrote: > Hi, > > On Mon, 9 Aug 2021, Hu Weiwen wrote: > > > Even if FF_MOV_FLAG_FRAG_EVERY_FRAME is set, don't flush if no frame > > available. > > > > This fixe